ChangeLog 489 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
2003-08-23  Per Cederqvist  <ceder@ceder.dyndns.org>

	Release administrativa.
	* HACKING: Mention that our automake patch is obsolete.
	* README: Some minor errors fixed.  Ask the reader to vote for the
	bugs he considers important.

	Update the protocol and document history of Protocol A.
	* doc/Protocol-A.texi (Future changes): Don't mention bugs that
	are closed.  Mention that the list of included bugs is
	incomplete.
	(Protocol Version History): Document version 11.
	(Document Edition History): Document edition 11.0.
	* doc/constructs.expected: Updated.

	Revert the Xenofarm automount workaround.
	* src/server/connections.c (dump_connections): Revert the
	automount workaround attempt.  It didn't work, and it also
	introduced an endless loop.

21 22
2003-08-22  Per Cederqvist  <ceder@ceder.dyndns.org>

23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
	Keep track of clients that are beind killed, and don't re-add them
	to the kill list.  (Bug 1100).
	* src/server/internal-connections.h (get_conn_by_number): Document
	that it returns NULL if the session doesn't exist.
	* src/server/internal-connections.c (init_connection): Set the new
	kill_status field of Connection instead of the old kill_pending
	field.
	(new_client): Ditto.
	(check_conn_exists): Dead code removed.
	(get_conn_by_number): Don't crash if no connections exist.  It
	isn't abnormal if the supplied connection number doesn't exist, so
	remove code inside NDEFENSIVE_CHECKS that assumed it was.
	Whitespace fixes.
	* src/server/connections.h (enum kill_state): New enum.
	(Connection): Replaced the "Bool kill_pending" field with a "enum
	kill_stat kill_status" field.
	* src/server/connections.c (check_kill_flg): Use the new
	kill_status field of Connection instead of the old kill_pending
	field.
	(read_from_connection): Ditto.
	(add_to_kill_list): Ditto.  Don't add the client if it is dying.
	
	Update var/lyskomd.clients when the handshake completes by a DNS
	response.
	* src/server/connections.c (dns_resolution): If the DNS resolution
	completed the handshake, dump out the connections again to reflect
	that fact.

Per Cederqvist's avatar
Per Cederqvist committed
51 52 53 54 55 56
	Test for bug 1100.
	* src/server/testsuite/lyskomd.0/47.exp: New file: Test client
	disconnect while logged in and receiving async-logout.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	47.exp.

57 58 59 60 61 62
	Xenofarm automount workaround.
	* src/server/connections.c (dump_connections): If the rename of
	the file fails with ENOENT, retry it a few times before giving
	up.  This is an attempt to work around an automount problem on the
	Xenofarm at Lysator.

63 64 65 66 67 68 69 70
	Fixed an error in the new function l2gi_prev().
	* src/server/local-to-global.c (l2gi_prev): Don't read memory
	before the start of an array.

	Make dump_connections() static.
	* src/server/internal-connections.h (dump_connections): Removed.
	* src/server/connections.c (dump_connections): Now static.

71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
	New requests: local-to-global-reverse and
	map-created-texts-reverse.  (Bug 1092).
	* doc/Protocol-A.texi (Mapping Local to Global Text Numbers):
	Renamed the field "later-texts-exists" in "Text-Mapping" to
	"more-texts-exists", so that it is useful for the new requests
	defined below.  Updated the descriptions of some fields for the
	same purpose.
	(local-to-global): Added a link to local-to-global-reverse.
	(map-created-texts): Added a link to map-created-texts-reverse.
	(set-connection-time-format): Added a missing protocol number.
	(local-to-global-reverse): New request.
	(map-created-texts-reverse): New request.
	* src/server/fncdef.txt: Added local_to_global_reverse and
	map_created_texts_reverse.
	* src/include/services.h (map_created_texts_reverse): New
	request.
	(local_to_global_reverse): New request.
	* src/server/text.c (local_to_global_reverse): New function.
	* src/server/person.c (map_created_texts_reverse): New request.
	* src/include/kom-types.h (Text_mapping_reverse): New struct.
	* src/server/prot-a.c (prot_a_reply): Handle
	rt_text_mapping_reverse.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
	(prot_a_output_text_mapping_reverse): New function.
	* src/server/connections.h (enum res_type): Added
	rt_text_mapping_reverse.
	(union result_holder): Added text_mapping_reverse.
	* src/server/testsuite/renumber.el
	(renumber-lyskom-send-simple-expect-indented): New function.
	* src/server/testsuite/lyskomd.0/00.exp: Added test cases for
	local-to-global-reverse and map-created-texts-reverse.
	* src/server/testsuite/lyskomd.0/01.exp: Ditto.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.

	Added support for reverse local-to-global iterators.
	* src/include/kom-types.h (L2g_reverse_iterator): New struct.
	* src/server/local-to-global.h (l2gi_searchsome_reverse): New
	function.
	(l2gi_prev): New function.
	* src/server/Makefile.am (check-l2g): New target.
	* src/server/local-to-global.c (find_block_index_key_reverse): New
	static function.
	(l2gi_searchsome_reverse): New function.
	(l2gi_prev): New function.
	* src/server/testsuite/test-l2g.c (main): Handle command "b", for
	testing backwards iterators.  ("r", "R", and "I" were all taken).
	* src/server/testsuite/l2g.0/07.exp: Added test cases for reverse
	iterators.
	* src/server/testsuite/l2g.0/10.exp: Ditto.
	* src/server/testsuite/l2g.0/11.exp: Ditto.

122 123
2003-08-20  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
124 125 126 127 128 129 130 131
	Code cleanup.  (Bug 1097).
	* src/server/aux-items.c (find_linked_aux_item_list): Removed all
	traces of PERS_OBJECT_TYPE.
	(mark_linked_object_as_changed): Ditto.
	* src/include/kom-types.h (enum object_type): Removed all traces
	of PERS_OBJECT_TYPE.  Don't explicitly specify the values of the
	constants, since they don't matter.

132 133 134 135 136 137 138 139 140 141 142 143
	Fix output of linefeed in Protocol A examples.  (Bug 376).
	* doc/Protocol-A.texi (Connecting to the Server): Say "linefeed",
	not "newline" or "line feed".
	(create-text): Ditto.
	(Reformattable Text (text/x-kom-basic)): Ditto.
	(The User Area): Ditto.
	(Text formatting): Ditto.
	(Protocol Version History): Ditto.
	(get-text): Use "@bullet{}" to represent linefeed characters
	inside hollerith strings.
	(create-text-old): Ditto.
	(create-anonymous-text-old): Ditto.
Per Cederqvist's avatar
Per Cederqvist committed
144
	* doc/constructs.expected: Updated.
145

146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176
	Return the error code long-array instead of a protocol error if
	a too long array is sent to mark-as-read.  (Bug 836).  Get rid of
	c_local_text_no_p -- use Number_list instead.
	* src/server/fncdef.txt (mark_as_read): Changed the argument from
	"num num c_local_text_no_p" to the more modern "num num_list".
	* src/include/services.h (mark_as_read): Changed the arguments
	"int no_of_text; const Local_text_no *text_arr" into a single more
	modern-style Number_list argument.
	* src/server/membership.c (mark_as_read): Changed the arguments
	"int no_of_text; const Local_text_no *text_arr" into a single more
	modern-style Number_list argument.  Return KOM_LONG_ARRAY if the
	array is too long.  Simplified the code.  
	(set_read_ranges): Call CHK_CONNECTION before checking the
	supplied read_ranges.
	* src/server/prot-a.c (prot_a_init): Removed
	handling of c_local_text_no_p.
	(prot_a_destruct): Ditto.
	* src/server/prot-a-parse-arg-c.awk: Removed
	handling of c_local_text_no_p.
	* src/server/internal-connections.c (init_connection): Removed
	handling of c_local_text_no_p.
	(kill_client): Ditto.  But do check for left-over data in
	num_list.
	* src/server/connections.h (Connection): Removed
	c_local_text_no_p.
	* src/server/connections.c (free_parsed): Removed handling of
	c_local_text_no_p.
	* src/server/call-switch.awk: Removed handling of
	c_local_text_no_p.
	* src/server/testsuite/lyskomd.0/29.exp: Don't expect bug 836.

177 178 179 180 181 182 183 184 185 186 187 188 189 190
	Send mail using sendmail, to avoid malformed mails.  (Bug 185).
	Make the path to sendmail configurable.  Make it possible to turn
	off mail delivery completely.
	* configure.in: Search for a sendmail binary.
	* doc/lyskomd.texi (Parameters): Document "sendmail path".
	* src/server/param.h (struct kom_par): Added sendmail_path.
	* src/server/server-config.c (parameters): Added "sendmail path".
	(read_configuration): Handle it.
	* src/server/updateLysKOM.c (checkstatus): Send mail by opening a
	pipe to "sendmail -t".  That is more portable than pipeing a
	message into "mail".  Turn off mail delivery completely if
	"sendmail path" is set to ":".
	* src/server/Makefile.am (paths.h): Write SENDMAIL_PATH.

191 192 193 194
	Test suite: Don't forget to distribute aux-items-bad.conf.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	aux-items-bad.conf.

195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215
	Fix text_read_access() so that it uses the privileges of the
	supplied connection, and never uses active_connection. (Bug 178).
	Fixing this also required me to remove the ability to specify an
	faq-text for a freshly created person on a session where nobody is
	logged on; this could be considered a security fix.
	* src/server/text.c (person_text_read_access): Removed.  Integrate
	the functionality inteo text_read_access.
	(text_read_access): Use the supplied Connection for all checks.
	Don't use active_connection, ENA, ACTPERS or ACT_P.  Fail and log
	an error message if the Connection is NULL.  Use is_supervisor()
	instead of is_supervisor_2().
	* src/server/manipulate.h (is_supervisor_2): Removed.
	(person_text_read_access): Removed.
	* src/server/conference.c (is_supervisor_2): Removed.
	* src/server/aux-items.c (aux_item_validate_existing_text): Don't
	allow access to texts if you are not logged in.  This change means
	that create-person cannot accept aux-items with the
	existing-readable-text validator if nobody is logged in.  I think
	this is more reasonable than the number of special cases in the
	code that were needed to support the old functionality.
	* src/server/testsuite/lyskomd.0/40.exp: Don't expect bug 178.
216
	* src/server/testsuite/lyskomd.0/41.exp: Don't expect bug 178.
217 218 219 220 221
	* src/server/testsuite/lyskomd.0/03.exp: Don't expect to be able
	to create a person with an faq-text.  Add the faq-text using a
	modify-conf-info request instead.  Test that creation of a new
	person with a faq-text item really fails.

222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342
	Keep track of the connection that is creating an aux-item, so that
	ENA_C() and text_read_access() can be used.  Get rid of broken
	concept "owner", and introduced "subordinate" instead.  (Bug 334).
	Some other aux-item-related code cleanup.
	* src/server/aux-items.h (Aux_item_validation_data): Removed
	item_creator, object_creator and owner_check.  Added
	creating_conn and subordinate.  Placed add_to_list,
	start_looking_at and object_type inside #if 0..#endif, since they
	are not currently used.
	(aux_inherit_items):Removed arguments target_creator, creating
	and object_type.  Added argument subordinate.  Changed type of
	arguments object_no and object, since we know that they are a
	Text_no and Text_stat, respectively.
	(check_delete_aux_item_list): Renamed the "owner" argument
	"subordinate".
	(text_stat_check_add_aux_item): Removed the item_creator and
	creating arguments.  Added the creating_conn argument.
	(conf_stat_check_add_aux_item_list): Ditto.
	(system_check_add_aux_item_list): Ditto.
	(conf_stat_check_add_aux_item): Declaration for undefined and
	unused function removed.
	(conf_stat_add_aux_item): Ditto.
	* src/server/aux-items.c (aux_item_validate): Return Success, not
	Bool.  All callers updated.
	(aux_item_add_perm): Removed the arguments item_creator,
	object_creator and owner_check.  Added the arguments creating_conn
	and subordinate.  All callers updated.  Simplified the code.  Use
	is_supervisor() instead of is_strictly_supervisor() where
	appropriate.  Use the supplied connection instead of checking that
	ACTPERS is the item_creator.  Adjusted for the new contents of
	Aux_item_validation_data.
	(aux_inherit_items): Removed arguments target_creator, creating
	and object_type.  Added argument subordinate.  Changed type of
	arguments object_no and object, since we know that they are a
	Text_no and Text_stat, respectively.
	(filter_aux_item_list): Assert that the viewer_conn argument is
	non-NULL.
	(check_delete_aux_item_list): Renamed the "owner" argument
	"subordinate".
	(text_stat_check_add_aux_item_list): Removed the item_creator and
	creating arguments.  Added the creating_conn argument, and assert
	it is non-NULL.
	(conf_stat_check_add_aux_item_list): Replaced the "creator"
	argument with "creating_conn".  Argument assertions added.
	(system_check_add_aux_item_list): Ditto.
	(aux_item_validate_existing_text): Changed return type from Bool
	to Success.  Use person_text_read_access() only when necessary,
	and add a comment explaining why it might happen.
	* src/server/text.c (create_text_add_aux): Adjusted to new API of
	aux_inherit_items().
	(do_create_text): Adjusted to new API of
	text_stat_check_add_aux_item_list().
	(modify_text_info): Ditto.
	* src/server/person.c (create_person_generic): Adjusted to new API
	of conf_stat_check_add_aux_item_list().
	* src/server/manipulate.h (text_read_access): Docstring updated.
	(person_text_read_access): Docstring added.
	* src/server/conference.c (do_create_conf): New argument:
	creating_connection.  All callers updated.
	(modify_conf_info): Adjusted to new API of
	check_delete_aux_item_list() and
	conf_stat_check_add_aux_item_list().
	* src/server/admin.c (modify_system_info): Adjusted to new API of
	system_check_add_aux_item_list().
	* src/server/testsuite/lyskomd.0/24.exp: Use good_bad_expect
	instead of a "if {0}" construct.  Don't expect it to fail.  Fixed
	a broken test outcome.

	Added code to diagnose Success vs. Bool mixups.
	* HACKING (Release generation): Use TYPE_CHECK_COMPILATION for
	increased quality assurance.
	* src/include/misc-types.h (TYPE_CHECK_COMPILATION): New
	compilation switch.
	(SUCCESS_AS_PTR): Ditto.
	(Bool): Provide a pointer-based non-working implementation, that
	can be used for compile-time checks, but not for running code.
	(Success): Provide a pointer-based implementation.  Switch to
	using it, at least for now; this might give us good warnings from
	the compilers.
	* src/server/misc-types.c: New file.  Implementation of the types
	in misc-type.h.
	* src/server/Makefile.am (libcheck_a_SOURCES): Added
	misc-types.c.
	(lyskomd_SOURCES): Ditto.
	(komrunning_SOURCES): Ditto.
	(updateLysKOM_SOURCES): Ditto.
	(dbck_SOURCES): Ditto.
	(splitkomdb_SOURCES): Ditto.
	* src/server/testsuite/Makefile.am (test_l2g_LDADD): libcheck.a
	must be linked twice.
	(get_time_often_LDADD): Ditto.

	Make etags find our documentation.
	* Makefile.am (AM_ETAGSFLAGS): Use --declarations, so that the
	tags command finds the documentation.

	Include an Emacs indentation style for our code.
	* doc/kom-style.el ("KOM"): New C style for c-add-style.  This
	sets up proper indentation for Emacs.
	* doc/Makefile.am (EXTRA_DIST): Added kom-style.el.

	Added more hacking documentation.
	* doc/lyskomd.texi (The Database): Mention that untranslated
	Swedish text exists.
	(local-to-global): Ditto.
	(Modifying Stored Types): Mention that dbck needs to be updated.
	(Coding conventions): New section.

	Document that send async-deleted-text, async-new-text,
	async-new-text-old, async-new-recipient and async-sub-recipient
	are sent to recipients of text linked to the relevant text.
	The functionality was added 2003-01-13.  (Bug 59).
	* doc/Protocol-A.texi (Aux-Item Inheritance): Added a missing
	parenthesis.
	(async-new-text-old): Document that recipients of linked texts
	also gets this message.
	(async-deleted-text): Ditto.
	(async-new-text): Ditto.
	(async-new-recipient): Ditto.
	(async-sub-recipient): Ditto.

343 344
2003-08-19  Per Cederqvist  <ceder@ceder.dyndns.org>

345 346 347 348
	Test permissons for setting the canonical-name aux-item.
	* src/server/testsuite/lyskomd.0/45.exp: Test that only an enabled
	admin can set a canonical-name aux-item on the system.

349 350 351 352 353 354 355 356
	Improve aux-item documentation.
	* doc/Protocol-A.texi (About Aux-Items): Reduce the amount of text
	talking about aux-items on persons.
	(Aux-Item Inheritance): New node.
	* doc/lyskomd.texi (Aux-Item Definition File): Document that
	author-only and supervisor-only has no effect on items placed on
	the system.

357 358 359 360 361 362 363 364 365 366 367 368 369
	Speed up the test suite slightly.
	* src/server/testsuite/lyskomd.0/gen-19.py (DEBUG): Turn it off.

	Improve documentation on set-connection-time-format, and make it
	recommended.
	* doc/Protocol-A.texi (Common Types): Mention that times can be
	expressed in UTC if the set-connection-time-format request has
	been used.
	(get-last-text): Ditto.
	(set-connection-time-format): Change the status from experimental
	to recommended.
	* doc/constructs.expected: Updated.

370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
	Fixed a crash in setup_timer().
	* src/libraries/libmisc/timeval-util.c (setup_timer): Fixed a
	fence error that triggered an assertion with a probability of one
	in a million.

	Warn about using SIGWINCH to read a new aux-item file.  If there
	is a syntax error, the server will abort.
	* doc/lyskomd.texi (Parameters): Warn about Bug 1095.
	(Signals): Ditto.

	Test parsing of broken aux-items at runtime.
	* src/server/testsuite/lyskomd.0/46.exp: New file: Test parsing a
	broken aux-item file as a result of SIGWINCH.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	46.exp.
	* src/server/testsuite/config/unix.exp (lyskomd_death): New
	reason: "restart_kom".
	* src/server/testsuite/lyskomd.0/aux-items-bad.conf: New file with
	syntax errors.

390 391 392 393 394
2003-08-18  Per Cederqvist  <ceder@ceder.dyndns.org>

	Write test case for aux-item inheritance.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	45.exp.
395 396
	* src/server/testsuite/lyskomd.0/45.exp: New file: Test aux-item
	inheritance.
397

398 399
2003-08-17  Per Cederqvist  <ceder@ceder.dyndns.org>

400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415
	Simplified the statistics code.  Don't crash if the time moves
	backwards, but log a nice error message including how much the
	time moved.
	* src/server/connections.c (set_time): Log how much the time moves
	backwards when it moves backwards.
	* src/server/stats.h (check_all_stats): Removed. 
	* src/server/stats.c: Don't attempt to keep a running average.
	Rounding errors are far too common.  Recompute it whenever it is
	requested instead.  This results in simpler code as well.
	(dump_stats): Removed.
	(update_one_stat): Check if the time moves backward, to avoid
	triggering an assertion.
	(is_nonzero): Removed.
	(check_all_stats): Removed.
	* src/server/ramkomd.c (main): Removed calls to check_all_stats().

416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
	Simplify handling of the sent_by misc-info.  Allow the supervisor
	of the author and sender to modify or remove a recipient (Bug 966,
	Bug 181 and Bug 1089).  Don't allow a text to be both a footnote
	and a comment of the same text at the same time (Bug 1090).  Code
	cleanup.
	* doc/Protocol-A.texi (add-comment): Added error codes
	already-comment and already-footnote.
	(add-footnote): Added error codes already-comment.
	* src/server/text.c (find_textlink): New static function.
	(is_supervisor_of_sender): New static function.
	(is_sender): Removed.
	(is_comm_sender): Removed.
	(is_comment_to): Removed.
	(recp_sent_by): Removed.
	(is_footnote_to): Removed.
	(sender): Removed.
	(do_add_footnote): New arguments: the Text_stat objects.  All
	callers updated.
	(do_add_comment): Ditto.
	(do_add_recipient): The text_s argument may no longer be NULL.
	All callers updated.
	(skip_recp): New simplified API.
	(filter_secret_info): Use is_supervisor_of_sender() instead of
	recp_sent_by().  Use the new API of is_supervisor().
	(person_text_read_access): Use is_supervisor_2() instead of
	is_supervisor() until bug 178 is fixed.
	(create_text_add_miscs): New argument: new_stat.  Pass it to
	do_add_footnote(), do_add_comment() and do_add_recipient() for a
	slight performance gain.  All callers updated.
	(delete_text): Use new API of is_supervisor().
	(add_recipient): Allow the supervisor of the author to modify the
	recipient (fixes bug 966).  Allow the supervisor of the sender to
	modify the recipient (fixes bug 181).
	(sub_recipient): Use the new API of is_supervisor().  Allow the
	supervisor of the sender to remove the recipient (fixes bug
	1089).
	(check_add_textlink): New helper function with the common parts of
	add_comment() and add_footnote().  Don't allow a text to be both a
	footnote and a comment of the same text at the same time (fixes
	bug 1090).
	(add_comment): Move code to check_add_textlink().
	(sub_comment): Use find_textlink() instead of is_comment_to().
	Use new API of is_supervisor().  Allow the supervisor of the
	sender to remove the comment link.
	(add_footnote): Use check_add_textlink() to simplify the code.
	(sub_footnote): Use find_textlink() instead of is_footnote_to().
	Use new API of is_supervisor().
	* src/server/session.c (login_old): Use new API of
	is_supervisor().  Simplify and reindent code.
	(login): Ditto.
	(disconnect): Ditto.
	* src/server/person.c (set_passwd): Use new API of
	is_supervisor().  Simplify and reindent code.
	* src/server/membership.c (access_perm_helper): Use new API of
	is_supervisor().  Simplify and reindent code.
	(sub_member): Ditto.
	(add_member_common): Ditto.
	(do_get_members): Ditto.
	* src/server/conference.c (is_supervisor): Replaced the Pers_no
	and Person arguments with a Connection argument.
	(is_supervisor_2): New function, with the old API of
	is_supervisor().
	(set_permitted_submitters): Use new API of is_supervisor().
	(set_super_conf): Ditto.
	* src/server/aux-items.c (filter_aux_item_list): Use new API of
	is_supervisor().
	(check_delete_aux_item_list): Ditto.
	* src/server/manipulate.h (is_supervisor): Replaced the Pers_no
	and Person arguments with a Connection argument.
	(is_supervisor_2): New function, with the old API of
	is_supervisor().  This is only used in one place, and will be
	removed when bug 178 is fixed.
	* src/server/testsuite/lyskomd.0/44.exp: Bugs 966, 181, 1089 and
	1090 are now fixed.
	* src/server/testsuite/lyskomd.0/14.exp: Bug 181 is now fixed.

492 493 494 495 496 497 498
	Added test cases for bug 1090.
	* src/server/testsuite/lyskomd.0/44.exp: Added test cases for bug
	1090.
	* src/server/testsuite/config/unix.exp (good_bad_expect): Handle
	the case where the bad result contains only a success indicator
	and a refno (such as "=1032").

499 500 501 502 503 504 505 506 507 508
	Allow recipients to be converted in a few more cases.
	* doc/Protocol-A.texi (add-recipient): The permission-denied error
	code is given if you are not supervisor of the author, recipient
	or sender.  The condition used to be more restrictive.

	Test suite fixes.
	* src/server/testsuite/lyskomd.0/14.exp: Simplified the code by
	using good_bad_expect.
	* src/server/testsuite/lyskomd.0/41.exp: Fixed typo in a comment.

Per Cederqvist's avatar
Per Cederqvist committed
509
	Added test cases for bug 181, bug 966 and bug 1089.
510 511
	* src/server/testsuite/lyskomd.0/44.exp: New file, that tests
	conversion of recipients from one type to another.
Per Cederqvist's avatar
Per Cederqvist committed
512 513
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	44.exp.
514 515 516 517 518

	Fixed dist error introduced yesterday.
	* scripts/Makefile.am (EXTRA_DIST): Dont forget to distribute the
	$(noinst_SCRIPTS).

519 520
2003-08-16  Per Cederqvist  <ceder@ceder.dyndns.org>

521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548
	Send and receive times in UTC, if the clients requests it.  
	(Bug 957).
	* doc/Protocol-A.texi (set-connection-time-format): New request.
	* src/include/services.h (set_connection_time_format): New
	request.
	* src/server/connections.h (Connection): Added use_utc.
	* src/server/fncdef.txt: Added set_connection_time_format.
	* src/server/text.c (get_last_text): Handle use_utc.
	* src/server/session.c (set_connection_time_format): New
	function.
	* src/server/prot-a-output.c (prot_a_output_time): Handle use_utc.
	* src/server/internal-connections.c (init_connection): Initialize
	use_utc.
	(new_client): Ditto.
	* src/server/prot-a-parse.c (prot_a_parse_misc_info): This code
	used to convert the broken-down time to a time_t using mktime().
	The value was never used.  Instead of introducing a portability
	problem using by calling timelocal(), we now simply store a 0 in
	the time field of rec_time and sent_at misc-infos.
	* src/server/testsuite/lyskomd.0/01.exp: Test
	set_connection_time_format.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	
	Installation fixes.
	* README: Fixed minor error in upgrade instructions.
	* run-support/Makefile.am (install-data-local): Create var/run,
	which will hold the pid file.

549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567
	New async: async-text-aux-changed.  (Bug 910).
	* doc/Protocol-A.texi (Client-Specific Aux-Item Types): Reserve
	10200-10299 for private test use.  Refer to Bugzilla.
	(async-text-aux-changed): New async message.
	* src/server/async.h (enum async): Added ay_text_aux_changed.
	* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
	(prot_a_async_text_aux_changed): New function.
	* src/server/send-async.c, src/server/send-async.h
	(async_text_aux_changed): New function.
	* src/server/session.c (accept_async): Handle ay_text_aux_changed.
	* src/server/text.c (send_async_text_aux_changed): New function.
	(modify_text_info): Call it.
	* src/server/testsuite/lyskomd.0/03.exp: Handle
	async-text-aux-changed.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	43.exp.
	* src/server/testsuite/lyskomd.0/43.exp: New file.  Test
	async-text-aux-changed.

Per Cederqvist's avatar
Per Cederqvist committed
568
	Code cleanup.
569 570 571 572 573 574 575 576 577
	* src/server/aux-items.c: Fixed indentation of bool operators.
	(commit_aux_item_list_internal): Removed a redundant "continue".
	(delete_aux_item_list): Fixed cut-n-paste errors in comments.
	(aux_item_list_add_items): Simplified the code.
	* src/server/prot-a-parse.c (prot_a_parse_misc_info_list): Fixed
	a cut-n-paste error: wrong function name in log message.
	* src/server/testsuite/lyskomd.0/00.exp: Removed the "test"
	argument to one of the simple_expect, to help diagnose problems
	where 127.0.0.1 isn't properly resolved.
Per Cederqvist's avatar
Per Cederqvist committed
578

Per Cederqvist's avatar
Per Cederqvist committed
579 580 581 582
	The man-pages will stay.
	* HACKING: It is good to have man-pages that refer to the real
	documentation, so don't remove them.  (Bug 77).

583 584 585 586 587
	Refer to Bugzilla, not email.  (Bug 724).
	* All files: Change the phrase "Please mail bug reports to
	bug-lyskom@lysator.liu.se." to "Please report bugs at
	http://bugzilla.lysator.liu.se/."

588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656
	Make config files refer to their documentation.
	* run-support/aux-items.conf: Added a reference to the
	documentation.
	* run-support/config: Added a reference to the documentation.

	Use better file names, so that lyskomd can be installed in /usr or
	/usr/local.  (Bug 66 and Bug 132).
	* NEWS: Documented all changed path names.
	* README: Removed the warning not to use /usr/local as the
	prefix.  Document how an upgrade should be made.  Document what
	needs to be done when upgrading from pre-2.1.0 to 2.1.0.  The
	binaries are now in "sbin", not "bin".
	* Makefile.am (SUBDIRS): Moved scripts before doc.
	* src/server/server-config.c (assign_path): New define for
	assign_string.
	(unassign_path): New define for unassign_string.
	(parameters): Use assign_path and unassign_path for all path
	parameters, to make them easier to find.  Use default values from
	paths.h instead of hardcoding the defaults in the file.  A lot of
	values have changed; see the summary in the NEWS file.
	(CONFIG_FILE): Removed.  This is now a define in paths.h.
	(compiled_config_file): New constant.
	(get_default_config_file_name): Use compiled_config_file instead
	of CONFIG_FILE.
	(free_default_config_file_name): Ditto.
	* src/server/connections.h: Updated a comment.
	* src/server/Makefile.am (MOSTLYCLEANFILES): Added paths.h.
	(AM_CPPFLAGS): Removed the DEFAULT_PREFIX define.  Use paths.h
	instead.
	(sbin_PROGRAMS): Was: bin_PROGRAMS.
	(BUILT_SOURCES): Added paths.h.
	(.gdbinit): Removed redundant "-f" option to $(RM).
	(DEFP): New constant.
	(paths.h): New target.
	(server-config.o): Added explicit dependency on paths.h.
	* scripts/unprefix: New script.
	* scripts/definepath: New script.
	* scripts/common.make (dbdir): Moved here from
	db-crypt/db/Makefile.am.
	(exportdir): New constant.
	* scripts/Makefile.am (noinst_SCRIPTS): Added unprefix and
	definepath.  Moved lyskomd-copyrights and update-copyright here
	from EXTRA_DIST.
	* run-support/config: Mention that this is installed as
	lyskomd.conf.
	* run-support/Makefile.am (sbin_SCRIPTS): Renamed savecore to
	savecore-lyskom, to avoid confusion with the /usr/bin/savecore
	program on Solaris.
	(MOSTLYCLEANFILES): Track the change.
	(savecore-lyskom): Track the change.
	(install-data-local): Install the config file as lyskomd.conf, not
	config.  Create the lyskomd.cores directory.
	(uninstall-local): Track the name change of lyskomd.conf.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Use the
	old path names, so that we don't have to update the entire test
	suite.
	* doc/lyskomd.texi: Updated the default paths to the new world
	order.
	* db-crypt/db/Makefile.am (dbdir): Moved to common.make.

	Added man pages that refer to the Texinfo documentation for all
	installed programs.  Made the man pages static.
	* doc/man/splitkomdb.8: New file.
	* doc/man/savecore-lyskom.8: New file.
	* doc/man/lyskomd.8: Removed the version number.
	* doc/man/updateLysKOM.8: Removed the version number.
	* doc/man/Makefile.am (man_MANS): Added savecore-lyskom.8 and
	splitkomdb.8.

657 658
2003-08-15  Per Cederqvist  <ceder@ceder.dyndns.org>

659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686
	Distribution fix.
	* mkmi: Always regenerate scripts/depcomp.

	Xenofarm fix.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Added "DNS log
	threshold: 3600" to support a certain slow Xenofarm computer.

	Calculate the file name of the configuration file in a single
	place.  Related code cleanup.
	* src/server/updateLysKOM.c (main): Use
	get_default_config_file_name() to find the config file.
	* src/server/splitkomdb.c (main): Ditto.
	* src/server/komrunning.c (main): Ditto.
	* src/server/dbck.c (main): Ditto.
	* src/server/ramkomd.c (main): Ditto.  Don't set read_config_file
	-- nothing used the value.
	* src/server/server-config.c (read_config_file): Variable removed.
	(CONFIG_FILE): Now static.
	(default_config): New static variable.
	(get_default_config_file_name): New function.
	(free_default_config_file_name): New function.
	(DEFAULT_DBASE_DIR): Removed.
	* src/server/param.h (read_config_file): Variable removed.
	* src/include/kom-config.h (DEFAULT_DBASE_DIR): Removed.
	(CONFIG_FILE): Removed.
	(get_default_config_file_name): New function.
	(free_default_config_file_name): New function.

687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719
	Handle scheduling of different weights.  The scheduling priority
	must still be 0.
	* doc/lyskomd.texi (Parameters): Document "Default priority", "Max
	priority", "Default weight" and "Max weight".
	* src/server/connections.h (Connection): New field: schedule.
	* src/server/server-config.c (parameters): Added "Default
	priority", "Max priority", "Default weight" and "Max weight".
	(require_less_eq): New static function.
	(read_configuration): Check the new parameters.  For now,
	max_priority must be set to 0, since connections.c can only handle
	a single priority.
	* src/server/param.h (struct kom_par): New fields:
	default_priority, max_priority, default_weight, max_weight.
	* src/server/internal-connections.c (init_connection): Initialize
	the schedule.
	* src/server/connections.c (login_request): Set the priority and
	weight from param.default_priority and param.default_weight.
	(adjust_penalty): Use the weight to reduce the penalty.
	(get_scheduling): Return the actual scheduling information from
	the connection.
	(set_scheduling): Check the priority and weight against
	param.max_priority and param.max_weight.  Allow the user to change
	them, as long as it is done within those limits.  Store the new
	values in the connection.  Note: the current implementation cannot
	handle more than one priority.  The check for that is made in
	server-config.c.
	* src/server/testsuite/get-time-often.c (longopts): Added
	--priority and --weight.
	(main): Handle the new options.
	* src/server/testsuite/lyskomd.0/01.exp: The new default weight is
	20.  The new maximum weight is 100.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.

720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772
2003-08-14  Per Cederqvist  <ceder@ceder.dyndns.org>

	Added the set-scheduling and get-scheduling requests.  The current
	implementation only supports priority==0 and weight==1.
	* doc/Protocol-A.texi (Session Information): Added Scheduling-Info.
	(get-scheduling): New request.
	(set-scheduling): New request.
	(Error Codes): Added priority-denied, weight-denied and
	weight-zero.
	* src/server/prot-a.c (prot_a_reply): Handle rt_scheduling_info.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
	(prot_a_output_scheduling_info): New function.
	* src/server/fncdef.txt: Added get_scheduling and set_scheduling.
	* src/server/connections.h (enum res_type): Added
	rt_scheduling_info.
	(union result_holder): Added scheduling_info.
	* src/server/connections.c (get_scheduling): New request.
	(may_change_scheduling): New static function.
	(set_scheduling): New request.
	* src/include/services.h (set_scheduling): New request.
	(get_scheduling): New request.
	* src/include/kom-types.h (Scheduling_info): New struct.
	* src/include/kom-errno.h (enum kom_err): Added
	KOM_PRIORITY_DENIED, KOM_WEIGHT_DENIED and KOM_WEIGHT_ZERO.
	* src/server/testsuite/lyskomd.0/01.exp: Test get-scheduling and
	set-scheduling.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.

	Test suite improvement.
	* src/server/testsuite/Makefile.am
	(../../libraries/adns/client/adnshost): New target.
	(site.exp): Depend on adnshost, so that "make check" works even if
	"make check" has not been run in the adns directory.

	Minor doc fixes.
	* doc/lyskomd.texi (Parameters): Document the default value of
	"Low penalty".  Removed some text that was left behind a
	cut-n-paste operation.
	(Adding a New Protocol Request): Added a CHK_CONNECTION call to
	the example.

	Changed status of set-keep-commented from experimental to
	recommended.
	* doc/Protocol-A.texi (Protocol Requests): Changed the status of
	set-keep-commented from experimental to recommended.
	(set-keep-commented): Ditto.

	Clarify the description of get-stats-description and get-stats.
	* doc/Protocol-A.texi (get-stats-description): State that this
	always returns the same during a session, so clients can cache
	this value aggressively.
	(get-stats): Elaborate on the access-denied error code.

773 774
2003-08-13  Per Cederqvist  <ceder@ceder.dyndns.org>

775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800
	Use AM_PATH_PYTHON to find the Python interpreter.  (Bug 329).
	* configure.in: Use AM_PATH_PYTHON.
	(HAVE_PYTHON): New automake conditional.
	* HACKING: Use Automake 1.7.6 with a patch for better Python
	handling.
	* doc/Makefile.am (check-doc): Only perform the tests if
	HAVE_PYTHON is set.  Use $(PYTHON) instead of python.  Print a
	warning if HAVE_PYTHON isn't set.
	* src/server/testsuite/Makefile.am (check-lyskomd): Only perform
	the tests if HAVE_PYTHON is set.  Use $(PYTHON) instead of python.
	Print a warning if HAVE_PYTHON isn't set.
	(check-leaks): Ditto.
	(site.exp): Set python to the Python interpreter found by
	configure.
	* src/server/testsuite/lyskomd.0/Makefile.am ($(srcdir)/15.exp):
	Use $(PYTHON) instead of python.  Use the HAVE_PYTHON Automake
	conditional.
	($(srcdir)/19.exp): Ditto.
	* src/server/testsuite/config/unix.exp (obtain_lock): Use $python
	from site.exp instead of hardcoding "python".
	(client_start): Ditto.
	(client_start_fail): Ditto.
	* scripts/xenofarm.sh: Removed tests for python.  We should get a
	warning message from "make check" if python is missing, but it
	should still succeed.

801 802 803 804 805 806 807 808 809 810
	Testsuite improvement.
	* src/server/testsuite/lyskomd.0/37.exp: Added "DNS log threshold"
	entries so that a slow DNS server won't interfere with this test.

	Protocol-A.texi was incompatible with the texinfo.tex supplied
	with Automake 1.7.6.
	* doc/Protocol-A.texi (\tensltt): Define this command using TeX
	syntax, and add a \global.  I have only a vague idea what this
	does, but it seems to work with texinfo.tex 2003-05-04.08.

811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839
	Create scripts/common.make, and include it from all LysKOM
	Makefile.am files.  Move the RM setting to it.  (Bug 851).
	* scripts/common.make: New file, which contains makefile fragments
	that all makefiles should include.
	(RM): Moved this variable to this file.
	* db-crypt/db/Makefile.am: Include common.make instead of setting
	RM.
	* doc/Makefile.am: Ditto.
	* run-support/Makefile.am: Ditto.
	* src/libraries/libeintr/Makefile.am: Ditto.
	* src/server/testsuite/Makefile.am: Ditto.
	* src/server/testsuite/lyskomd.0/Makefile.am: Ditto.
	* Makefile.am: Include common.make.
	* db-crypt/Makefile.am: Ditto.
	* scripts/Makefile.am: Ditto.
	* src/Makefile.am: Ditto.
	* src/include/Makefile.am: Ditto.
	* src/include/server/Makefile.am: Ditto.
	* src/libraries/Makefile.am: Ditto.
	* src/libraries/libansi/Makefile.am: Ditto.
	* src/libraries/libcommon/Makefile.am: Ditto.
	* src/libraries/libmisc/Makefile.am: Ditto.
	* src/server/Makefile.am: Ditto.
	* src/server/testsuite/config/Makefile.am: Ditto.
	* doc/man/Makefile.am: Ditto.
	
	Automake lint.
	* configure.in: Use new-style call to AM_INIT_AUTOMAKE.

840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855
	Implement find-next-conf-no and find-previous-conf-no.  
	(Bug 123).
	* doc/Protocol-A.texi (Server Information): Refer to
	find-previous-conf-no.
	(find-next-conf-no): New request.
	(find-previous-conf-no): New request.
	* src/server/fncdef.txt: Added find_next_conf_no and
	find_previous_conf_no.
	* src/include/services.h, src/server/conference.c
	(find_next_conf_no): New function.
	(find_previous_conf_no): New function.
	* src/server/testsuite/lyskomd.0/01.exp: Test find_next_conf_no
	and find_previous_conf_no.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	* src/server/testsuite/lyskomd.0/41.exp: Ditto.

856 857 858 859 860 861 862 863 864 865 866 867
	The test suite failed on really really slow computers.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Increase
	the "Connect timeout" and "Login timeout" to 1 day, unless the
	test specifies them.  I suspect that the "Connect timeout"
	interfered with a test on one of the slower members of the
	Xenofarm.
	* src/server/testsuite/lyskomd.0/38.exp: Fixed a race condition:
	if the client was killed at the wrong time, the test would crash.
	* src/server/testsuite/lyskomd.0/37.exp: Pass a $base_config to
	lyskomd_start in the other place as well.  The fix made on
	2003-08-07 was incomplete.

868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898
	Implement first-unused-conf-no and first-unused-text-no.
	(Bug 121).
	* doc/Protocol-A.texi (first-unused-conf-no): New request.
	(first-unused-text-no): New request.
	(Server Information): Refer to the new requests instead of
	inferior ways to get the same information.
	* src/include/services.h (first_unused_conf_no): New function.
	(first_unused_text_no): New function.
	* src/server/text.c (first_unused_text_no): New function.
	* src/server/simple-cache.c (query_next_conf_no): New function.
	* src/server/prot-a.c (prot_a_reply): Handle rt_conf_no.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
	(prot_a_output_conf_no): New function.
	* src/server/fncdef.txt: Added first_unused_conf_no and
	first_unused_text_no.
	* src/server/connections.h (enum res_type): Aded rt_conf_no.
	(union result_holder): Added conf_no.
	* src/server/conference.c (first_unused_conf_no): New function.
	* src/server/cache.h (query_next_conf_no): New function.
	* src/server/testsuite/lyskomd.0/01.exp: Test
	114:first-unused-conf-no and 115:first-unused-text-no.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	* src/server/testsuite/lyskomd.0/41.exp: Ditto.

	Makefile improvements that might help portability to
	CYGWIN_NT-5.0.
	* src/server/testsuite/Makefile.am (AM_CPPFLAGS): Added ../../..,
	so that config.h is properly found.
	* src/server/Makefile.am (aux.h): Don't append to a non-existing
	file; use ">" instead of ">>" to create it.

899 900
2003-08-12  Per Cederqvist  <ceder@ceder.dyndns.org>

901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926
	Implement and use has_access() to simplify code.  (Bug 723).
	* src/server/manipulate.h, src/server/membership.c (has_access):
	New function.  This is a simple wrapper around access_perm that
	simplifies the code.
	* src/server/membership.c (filter_conf_no): Use has_access()
	instead of access_perm() to simplify code.
	(sub_member): Ditto.
	(add_member_common): Ditto.
	* src/server/text.c (filter_secret_info): Ditto.
	(add_recipient): Ditto.
	(sub_recipient): Ditto.
	* src/server/send-async.c (async_new_name): Ditto.
	(async_new_user_area): Ditto.
	* src/server/regex-match.c (lookup_regexp): Ditto.
	* src/server/person.c (do_query_read_texts): Ditto.
	* src/server/conference.c (set_conf_errno): Ditto.
	(lookup_name): Ditto.
	(lookup_z_name): Ditto.
	(do_lookup): Ditto.
	(send_async_new_presentation): Ditto.
	(send_async_new_motd): Ditto.
	(modify_conf_info): Ditto.
	* src/server/admin.c (send_message): Ditto.
	* doc/lyskomd.texi (Adding a New Protocol Request): Fixed broken
	code example.  Use has_access() instead of access_perm().

927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953
	lyskomd is now officially shut down via SIGTERM.  (SIGHUP still
	works, and SIGINT also shuts it down.)  (Bug 808).
	* doc/lyskomd.texi (Parameters): lyskomd is now officially shut
	down by SIGTERM, not SIGHUP.
	(Signals): Ditto.  However, SIGHUP and SIGINT also works.
	(Administration): Recommend SIGTERM, not SIGHUP.
	(Bugs): Removed entry about terminating on SIGINT and SIGTERM.
	* src/server/testsuite/config/unix.exp (lyskomd_death): The reason
	"signal" now means SIGTERM.  Also handle "sighup" and "sigint".
	* src/server/updateLysKOM.c (checkstatus): Use SIGTERM, not
	SIGHUP.
	* src/server/sigflags.h: Updated a comment: SIGTERM is now the
	official way to shut down lyskomd.
	* src/server/ramkomd.c (server_init): Handle SIGTERM and SIGINT
	the same way as SIGHUP: shut down.
	(main): Ditto.
	(sighandler_term): New name for former sighandler_hup.  Log proper
	message depending on which signal was used to shut down the
	server.
	* src/server/komrunning.c (shutdown_lyskom): Use SIGTERM, not
	SIGHUP, to shut down lyskomd.
	* src/server/connections.c: Updated a comment: SIGTERM is now the
	official way to shut down lyskomd.
	* src/server/testsuite/lyskomd.0/31.exp: Test to shut down the
	server by both SIGTERM, SIGHUP and SIGINT.
	* src/server/testsuite/lyskomd.0/07.exp: Use TERM instead of HUP
	to shut down lyskomd.
954 955 956 957 958 959 960 961
	* src/server/testsuite/lyskomd.0/11.exp: Ditto.
	* src/server/testsuite/lyskomd.0/30.exp: Ditto.
	* src/server/testsuite/lyskomd.0/37.exp: Ditto.
	* src/server/testsuite/lyskomd.0/38.exp: Ditto.
	* src/server/testsuite/lyskomd.0/39.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-48.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-810.exp: Ditto.
962

963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988
	The same text can no longer be FAQ for the same conference twice.
	(Bug 572).
	* run-support/aux-items.conf (faq-conf): Added unique-data, so
	that the same text cannot be faq for a conference more than once.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	bug-572.exp.
	* src/server/testsuite/lyskomd.0/bug-572.exp: New file.  Test that
	the same text cannot be FAQ for the same conference more than
	once.

	Added support for aux-items that must contain a unique piece of
	data.
	* doc/lyskomd.texi (Aux-Item Definition File): Document
	unique-data.
	* src/server/aux-items.h (struct Aux_item_definition_s): Added
	unique_data.
	* src/server/aux-items.c (empty_aux_item_definition): Added
	unique-data.
	(simple_aux_item): Ditto.
	(aux_item_add_perm): If aux_item_check_unique sets kom_errno,
	don't override it.
	(aux_item_check_unique): Check for unique_data violations.
	* src/server/aux-item-def-parse.y (assign): Handle unique-data.
	(parse_aux_item_definitions): Handle unique-data in the debug code
	that prints the parsed aux-item.

989 990 991 992 993 994 995
	"./configure && make install" no longer fails.  (Bug 856).
	* src/server/Makefile.am (connections.o): Add an explicit
	dependency on prot-a-parse-arg.h so that "./configure&&make
	install" works.
	* HACKING: Before a release, a "./configure&&make install" check
	should be made.

Per Cederqvist's avatar
Per Cederqvist committed
996 997 998 999 1000
	Test suite fix.
	* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Re-updated
	expected leak count.  Since the leak due to bug 689 is now
	suppressed, it only shows up among the suppressions.

1001 1002 1003 1004 1005
	The get-boottime-info implementation caused compilation errors
	unless DEBUG_CALLS was defined.
	* src/server/simple-cache.c: services.h and manipulate.h are
	always needed.

1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
	Added get-boottime-info.  (Bug 6).
	* src/server/testsuite/lyskomd.0/03.exp,
	src/server/testsuite/lyskomd.0/01.exp: Test get-boottime-info.
	* src/server/stats.h, src/server/stats.c (read_stat_value): New
	function.
	* src/server/simple-cache.c (boottime_info): New static variable.
	(init_cache): Initialize boottime_info.
	(get_boottime_info): New request.
	* src/server/prot-a.c (prot_a_reply): Handle
	rt_static_server_info.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
	(prot_a_output_static_server_info): New function.
	* src/server/fncdef.txt: Added get_boottime_info.
	* src/server/connections.h (enum res_type): Added
	rt_static_server_info.
	(union result_holder): Added static_server_info.
	* src/include/services.h (get_boottime_info): New request.
	* src/include/kom-types.h (Static_server_info): New type.
	* doc/constructs.expected: Updated.
	* doc/Protocol-A.texi (Server Information): Document
	Static-Server-Info.
	(get-boottime-info): New request.

	Measure the number of existing conferences and persons.
	* src/server/testsuite/lyskomd.0/03.exp,
	src/server/testsuite/lyskomd.0/01.exp: Test STAT_CONFS and
	STAT_PERSONS.
	* src/server/stats.h (enum stat_type): Added STAT_CONFS and
	STAT_PERSONS.
	* src/server/stats.c (name): Handle STAT_CONFS and STAT_PERSONS.
	* src/server/simple-cache.c (init_cache): Update STAT_CONFS and
	STAT_PERSONS.
	* src/server/person.c (do_delete_pers): Update STAT_PERSONS.
	(create_person_generic): Update STAT_PERSONS and STAT_CONFS.
	* src/server/conference.c (do_delete_conf): Update STAT_CONFS.
	(do_create_conf): Ditto.
	* doc/Protocol-A.texi (Measured Properties): Added "confs" and
	"persons".

1045 1046
2003-08-11  Per Cederqvist  <ceder@ceder.dyndns.org>

1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
	Testsuite fixes.
	* src/server/testsuite/lyskomd.0/41.exp: Code cleanup.
	* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Updated
	expected suppressed leak count.

	Test handling of the keep-commented field and its interaction with
	the garb.  Added the debug request backdate_comment_link.  (Bug 902).
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	42.exp.
	* src/server/testsuite/lyskomd.0/42.exp: New file.  Test
	keep-commented handling.
	* src/server/fncdef.txt: Added backdate_comment_link.
	* src/server/debug.c (backdate_comment_link): New debug request.
	* src/include/services.h (backdate_comment_link): New debug
	request.

1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081
	Comments and footnotes now protect the parent text from being
	garbed until the comment is keep_commented days old.  (Bug 902).
	* src/include/kom-types.h (Small_conf): Added keep_commented.
	* src/server/cache.h (cached_get_keep_commented): New function.
	* src/server/text-garb.c (saved_by_recipient): Code cleanup.
	(find_comment_limit_and_age): New static function.
	(saved_by_keep_commented): New static function.
	(saved): Call saved_by_keep_commented.
	* src/server/simple-cache.c (mark_conference_as_changed): Copy
	the keep_commented field to the small_conf.
	(setup_small_conf): Ditto.
	(init_small_conf): Initialize keep_commented.
	(cached_get_keep_commented): New function.
	* src/server/dbck-cache.c (cached_get_keep_commented): New
	function.

	Code cleanup.
	* src/server/conference.c: Fixed a cut-n-paste comment error.

1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094
	Add a valgrind suppression.
	* src/server/testsuite/lyskomd.supp: Added a suppression for a
	known leak in regex_compile().

	Reorganized text-garb.c for readability.
	* src/server/text-garb.c (day_to_sec): New constant.
	(default_save): New constant.
	(saved_by_aux): New static helper function.
	(saved_by_recipient): Ditto.
	(saved_by_comment): Ditto.
	(saved): Ditto.
	(garb_text): Use the saved() function to simplify code.

1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
2003-08-10  Per Cederqvist  <ceder@ceder.dyndns.org>

	Use valgrind-20030725.  Use leak suppression to ignore harmless
	leaks we cannot fix.  (Bug 974).
	* scripts/warnings.sed: Adjusted a line number.
	* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Updated for
	valgrind-20030725.
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: The possible
	leaks are now suppressed.
	* src/server/testsuite/config/unix.exp (check_valgrind): The
	expected_leaks argument should now include the number of
	suppressed memory leaks.  Ignore up to 25 suppressed leaks.  Don't
	ignore any reachable leaks.
	* src/server/testsuite/lyskomd.supp: Updated for
	valgrind-20030725.  Add suppressions of known harmless memory
	leaks.

1112 1113
2003-08-08  Per Cederqvist  <ceder@ceder.dyndns.org>

1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
	Implement async-new-motd.  (Bug 906).
	* doc/Protocol-A.texi (async-new-motd): New async message.
	* src/server/async.h (enum async): Added ay_new_motd.
	* src/server/session.c (accept_async): Handle ay_new_motd.
	* src/server/send-async.h, src/server/send-async.c
	(async_new_motd): New function.
	* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
	(prot_a_async_new_motd): New function.
	* src/server/conference.c (send_async_new_motd): New function.
	(do_set_etc_motd): Call it.  Clean up variable names.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Track change
	in error message from do_set_etc_motd.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	41.exp.
	* src/server/testsuite/lyskomd.0/41.exp: Test async-new-motd.
	* src/server/testsuite/lyskomd.0/03.exp: Handle ay-new-motd.
	* src/server/testsuite/lyskomd.0/40.exp: Fixed a broken comment.

1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154
	Implement async-new-presentation.  (Bug 904).
	* src/server/session.c (accept_async): Handle ay_new_presentation.
	* src/server/send-async.h, src/server/send-async.c
	(async_new_presentation): New function.
	* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
	(prot_a_async_new_presentation): New function.
	* src/server/conference.c (send_async_new_presentation): New
	function.
	(do_set_presentation): Call it.  Clean up variable names, and
	remember the text statuses of the old and new presentation so they
	can be passed to send_async_new_presentation().  Include the text
	number of the old presentation in the error message that is
	printed if the old presentation lacks a mark.
	* src/server/testsuite/config/unix.exp (client_good_bad_expect):
	New proc.
	(client_extracting_expect): New proc.
	* src/server/testsuite/lyskomd.0/03.exp: Handle
	async-new-presentation.
	* src/server/testsuite/lyskomd.0/40.exp: async-new-presentation is
	now implemented.  Expect bug 178.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Track change
	in error message from do_set_presentation.

1155 1156 1157 1158 1159 1160 1161 1162 1163
	Document async-new-presentation and write a test suite for it.
	(Bug 904).
	* doc/Protocol-A.texi (async-presentation-changed): New async.
	* src/server/async.h (enum async): Added ay_new_presentation.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	40.exp.
	* src/server/testsuite/lyskomd.0/40.exp: Test async-new-presentation.
	* src/server/testsuite/config/unix.exp (client_expect): New proc.

1164 1165
2003-08-07  Per Cederqvist  <ceder@ceder.dyndns.org>

1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182
	The test suite failed on really really slow computers.
	* src/server/testsuite/lyskomd.0/37.exp: Pass a $base_config to
	lyskomd_start, since we don't want lyskomd_start to modifiy the
	compiled-in default of "Sync interval".
	* src/server/testsuite/config/unix.exp (lyskomd_start): Set the
	"Sync interval" to 1 day, so that it doesn't interfere with the
	tests.  Added a colon to the strings that extra_config is checked
	against, so that parameters that are prefixes of other parameters
	are handled correctly.

	Stats improvements.
	* src/server/stats.c: The "updates" field now counts incremental
	updates of avenrun.
	(update_history): Adjusted.
	(update_one_stat): Adjusted.
	(check_one_stat): Adjusted.

1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201
	Make it easier to change the file descriptor reserved for
	valgrind.  Don't use a file descriptor that interferes with the
	test suite.
	* src/server/testsuite/config/unix.exp (PROTECTED_FDS): Added a
	comment that refers to ../Makefile.am.  Check that valgrind_fd is
	set properly.
	(lyskomd_host): This is now set in site.exp, not here.
	(l2g_start): Use valgrind_fd instead of hardcoding the value.
	(spawn_lyskomd): Ditto.
	(dbck_run): Ditto.
	* src/server/testsuite/Makefile.am (VALGRIND_FD): New constant,
	set to 21.  Added a comment that refers to PROTECTED_FDS in
	unix.exp.
	(site.exp): Set lyskomd_host to whatever 127.0.0.1 resolves to,
	or 127.0.0.1 if it cannot be looked up at all.  Set valgrind_fd to
	the constant defined in VALGRIND_FD.
	(valgrind.wrap): Use VALGRIND_FD, instead of hardcoding the value
	in two places.  Changed the valgrind file descriptor to 21, which
	is currently the highest reserved file descriptor.
1202 1203 1204
	(check_DATA): Was: noinst_DATA.   site.exp should not be built
	until adnshost is built, and the other stuff in noinst_DATA was
	also not needed until check time.
1205 1206 1207 1208 1209 1210

	Don't log simple reverse lookup errors for localhost, since they
	interfere with the test suite and are fairly common and harmless.
	* src/server/connections.c (dns_resolution): Don't log errors if
	the lookup of localhost fails due to "nxdomain" or "inconsistent".

1211 1212 1213 1214 1215 1216 1217
	The AIX 4.2 and 4.3 builds have failed the tests for max open
	clients since we enabled ADNS.  Attempt to fix.  But can they
	really have an extra overhead of 8-9 file descriptors?
	* src/include/kom-config.h (PROTECTED_FDS): Account for the two
	file descriptors used by ADNS.
	* src/server/testsuite/config/unix.exp: Ditto.

1218 1219 1220 1221 1222
	Send async-rejected-connection even to sessions where the reverse
	DNS lookup hasn't completed yet.
	* src/server/internal-connections.c (handshake_ok): Actually 
	ignore the dns_done field when told to do so.

1223 1224
2003-08-06  Per Cederqvist  <ceder@ceder.dyndns.org>

1225 1226 1227 1228 1229
	Don't crash if shut down with a pending reverse DNS lookup.
	* src/server/connections.c (dns_resolution): Don't re-enable idle
	check during shutdown.  Simplify code.
	(toploop): Simplify code by using enable_idle_check().

1230 1231 1232 1233 1234
	Test suite: Obtain the name "localhost" using adns.
	* src/server/testsuite/config/unix.exp (lyskomd_host): Use
	adnshost to set it, so that it is set the same way as when lyskomd
	is running.

1235 1236 1237 1238 1239 1240 1241
	Compile the adnshost program during "make check".
	* src/libraries/adns/Makefile.am (SUBDIRS): Added client.
	* src/libraries/adns/configure.in: Generate client/Makefile.
	* src/libraries/adns/client/Makefile.am: New file.  Compile
	adnshost as part of the "make check" phase.
	* src/libraries/adns/client/Makefile.in: Removed.

1242 1243 1244
	Document undocumented TeX code.  (Bug 195).
	* doc/Protocol-A.texi: Document some TeX code.

1245 1246 1247 1248
	Fix the "make check" target in liboop.
	* src/libraries/liboop/test-oop.c (get_name): Adjusted the call to
	oop_adns_submit.

1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273
	Use ADNS, so that IPv4 reverse DNS lookups are non-blocking.
	Since ADNS does not yet support IPv6, reverse lookups of IPv6
	addresses are still blocking.  (Bug 627).
	* src/server/prot-a.c (prot_a_parse_packet): Skip whitespace when
	blocking the client waiting for a DNS reply.
	* src/server/connections.c (parse_unparsed): Return immediately if
	the session became blocked by DNS.
	(dns_resolution): Schedule an idle check, as a client may have
	become unblocked.  Don't call isc_enable() here.  Instead, add the
	session to the run-queue.  There may be pending input in the input
	buffer.  Handle ADNS errors.
	(login_request): Check the return value of isc_resolve_remote().
	(read_from_connection): Return if the session is blocked by DNS.
	* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: After the
	adns integration, we need to ignore 25 unreachable blocks.
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: After the
	adns integration, we need to ignore 25 unreachable blocks.
	* src/server/testsuite/config/unix.exp (check_valgrind): After the
	adns integration, we need to ignore 25 unreachable blocks.

	Added the ability to do reverse queries to the oop adns adapter.
	* src/libraries/liboop/oop-adns.h, src/libraries/liboop/adns.c
	(oop_adns_submit): New argument: errcode.
	(oop_adns_submit_reverse): New function.

1274 1275
2003-08-05  Per Cederqvist  <ceder@ceder.dyndns.org>

1276 1277 1278 1279 1280 1281
	Update testsuite: clients that hasn't completed the handshake
	should be invisible.
	* src/server/testsuite/lyskomd.0/connections-cov.exp:
	Disconnecting a client that hasn't declared a protocol yet now
	should fail.

Per Cederqvist's avatar
Per Cederqvist committed
1282 1283 1284 1285
	"make clean" fix.
	* src/server/testsuite/Makefile.am (MOSTLYCLEANFILES): Added 
	memory-usage-*.log.

1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375
	Use a callback-based API for DNS lookup, in preparation for ADNS
	integration.  Block clients, and make them invisible for all other
	clients, until the DNS lookup has completed.
	* doc/lyskomd.texi (Files): Document the handshake_ok field of
	connections.txt.
	(Function Templates for send-async.c): Include a call to
	handshake_ok() in prototype code.
	(Traversing Connections): Ditto.
	* src/server/session.c:  All users of the hostname updated to get
	it from the isc_scb.
	(who_is_on): Removed dead code.
	(who_is_on_ident): Ditto.
	(who_is_on_dynamic): Removed dead code.  Don't include sessions
	until the handshake is completed.
	(get_session_info): Don't include sessions until the handshake is
	completed.
	(get_static_session_info): Don't include sessions until the
	handshake is completed.  
	(get_session_info_ident): Ditto.
	(disconnect): Don't include sessions until the handshake is
	completed.
	(get_client_name): Ditto.
	(get_client_version): Ditto.
	* src/server/send-async.c (async_new_text_old): Use handshake_ok()
	to check if it is OK to send the message to the client.  As a
	result, the message will not be sent until the DNS lookup has
	completed.
	(async_new_text): Ditto.
	(async_i_am_on): Ditto.
	(async_logout): Ditto.
	(async_new_name): Ditto.
	(async_forced_leave_conf): Ditto.
	(async_login): Ditto.
	(async_deleted_text): Ditto.
	(async_new_recipient): Ditto.
	(async_sub_recipient): Ditto.
	(async_new_membership): Ditto.
	(async_new_user_area): Ditto.
	(async_garb_ended): Ditto.
	(async_sync_db): Ditto, but ignore the DNS lookup.
	(async_rejected_connection): Ditto.
	* src/server/prot-a.c (prot_a_parse_packet): Disable the session
	after the initial handshake if the dns resolution hasn't completed
	yet.
	* src/server/membership.c (send_async_new_membership): Indentation
	fixed.
	* src/server/internal-connections.h (enum ignored_conditions): New
	enum.
	(handshake_ok): New function.
	* src/server/internal-connections.c (init_connection): Updated to
	initialize all fields.  Several were forgotten.
	(kill_client): Clear the remote_ip.
	(handshake_ok): New function.
	* src/server/connections.h (Connection): Removed the hostname
	field, since that is now stored as isc_session->remote.  Added
	dns_done, blocked_by_dns, and remote_ip.
	* src/server/connections.c (dump_connections): Include a flag that
	tells if the session has completed the handshake or not.
	(dns_resolution): New function.
	(get_host_name): Removed.
	(login_request): Reorganized the code to use the new
	callback-driven API of ISC host lookups.
	* src/server/admin.c (shutdown_kom): Get the host name from the
	isc_scb, now that the information is no longer stored in the
	connection.
	* src/libraries/libmisc/timeval-util.h,
	src/libraries/libmisc/timeval-util.c (timeval_diff_d): New
	function.

	The session_start field of a Connection was used both to record
	the connect time and the login/logout time.  As a result, the
	connection-time of a Static-Session-Info was not actually static.
	Fixed by keeping track of the connect time and the login/logout
	separately.
	* src/server/connections.h (Connection): Replaced the
	session_start field with connect_time and login_time.  All users
	updated.  
	* src/server/session.c: (login_old): Set login_time, not connect_time.
	(login): Ditto.
	(logout): Use login_time, not connect_time.
	(get_session_info): Use connect_time, not login_time, as the
	connection_time.
	(get_static_session_info): Use connect_time, not login_time, as the
	connection_time.
	(get_session_info_ident): Ditto.
	* src/server/internal-connections.c (new_client): Set both
	connect_time and login_time.
	* src/server/connections.c (handle_accept_event): Call set_time(),
	so that the connect_time is set correctly.

1376 1377
2003-08-04  Per Cederqvist  <ceder@ceder.dyndns.org>

1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391
	Don't leave whitespace in the input buffers.
	* src/server/prot-a.c (prot_a_parse_packet): Delete leading and
	trailing whitespace, to avoid having it linger in the input
	buffer.
	* src/server/prot-a-parse.h, src/server/prot-a-parse.c
	(prot_a_parse_skip_whitespace): New function.

	Code cleanup.
	* src/server/isc-parse.c (parse_nonwhite_char): Use WHITESPACE
	instead of hardcoding the string.

	Xenofarm: warnings from <float.h>.
	* scripts/warnings.sed: Ignore warnings from lenin.

1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404
	Track the simplified API of ISC callback functions.
	* src/server/ramkomd.c (handle_accept_event): Added a forward
	declaration using the isc_accept_callback typedef.
	* src/server/connections.h (handle_accept_event): Adjusted to the
	new API of ISC callback functions.
	* src/server/connections.c (write_err_cb): Adjusted to the new API
	of ISC callback functions.
	(stale_cb): Ditto.
	(idle_cb): Ditto.
	(login_request): Ditto.
	(data_available_callback): Ditto.
	(handle_accept_event): Ditto.

1405 1406 1407 1408 1409
	Slow DNS servers could interfere with the test suite.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Set the
	"DNS log threshold" to one hour, to avoid that it interferes with
	the test suite.

1410 1411
2003-08-03  Per Cederqvist  <ceder@ceder.dyndns.org>

1412 1413 1414 1415 1416 1417 1418 1419 1420 1421
	Track some minor cleanup of ISC.  (Bug 916).
	* src/server/ramkomd.c (server_init): Use the address stored in
	listen_client->laddr instead of calling isc_getladdress().
	* src/server/testsuite/lyskomd.supp: Removed a suppressions for
	calling accept() with NULL pointers.  ISC no longer does that.

	Plug a memory leak in a test program.
	* src/server/testsuite/get-time-often.c (tcp_connect): Plugged a
	memory leak.

1422 1423 1424 1425 1426 1427
	The idle timeouts interfered with some tests on slow computers.
	Fix.
	* src/server/testsuite/lyskomd.0/29.exp (startup): Set the idle
	timeouts to 6 hours, to make sure that they do not interfere with
	the test.

1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448
	Bug fixes for the idle client disconnect.
	* src/server/server-config.c (parameters): Changed "Connect
	timeout" to 30 seconds.  Changed "Login timout" to 30 minutes.
	(read_configuration): Don't require the various idle timeouts to
	be longer than the stale timeout.
	* doc/lyskomd.texi (Parameters): Updated the description of the
	idle timeouts.
	* src/server/testsuite/lyskomd.0/39.exp: Extended: test each
	timeout by itself.  Removed the test that "Stale timeout" should
	be less than the idle timeouts, since that is no longer required.
	* src/server/testsuite/lyskomd.0/37.exp: Updated the expected
	values for "Connect timeout" and "Login timeout", and fixed the
	expected default suffix of "Active timeout".

	Bug fixes for get-stats.  (Bug 1072).
	* src/server/stats.c (update_one_stat): The accumulator was not
	updated in a proper way.
	(update_stat): Update the ascending and descending values even
	when the delta is 0, so that they are updated when the get-stats
	request is issued.

1449 1450
2003-08-02  Per Cederqvist  <ceder@ceder.dyndns.org>

1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484
	Disconnect idle clients after a few days.  (Bug 11).
	* doc/lyskomd.texi (Parameters): Document "Connect timeout",
	"Login timeout" and "Active timeout".
	* src/server/server-config.c (parameters): Added "Connect timeout",
	"Login timeout" and "Active timeout".
	(require_less): New static function.
	(read_configuration): Check that "Stale timeout" is smaller than
	the three new timeouts.
 	* src/server/param.h (struct param): Added connect_timeout,
	login_timeout and active_timeout.
	* src/server/session.c (login_old): Set the idle timeout to
	param.active_timeout.
	(login): Ditto.
	(logout): Set the idle timeout to param.login_timeout.
	* src/server/ramkomd.c (server_init): Set the default idle timeout
	to param.connect_timeout.
	* src/server/prot-a.c (prot_a_parse_packet): Set the idle timeout
	to param.login_timeout once the handshake is done.
	* src/server/connections.c (idle_cb): New static function.
	(login_request): Pass idle_cb() to isc_set_read_callback().
	* src/server/testsuite/lyskomd.0/37.exp: Expect the new timeval
	settings: "Connect timeout", "Login timeout" and "Active timeout".
	* src/server/testsuite/lyskomd.0/39.exp: New file, with tests for
	idle client disconnect.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	39.exp.

	Fixed a race condition in the test suite.
	* src/server/testsuite/config/unix.exp (client_start_fail): Don't
	add an expect_always handler for eof.  In some tests two or more
	clients are supposed to die "at once", and this would lead to a
	race condition.
	(get_time_client_start): Ditto.

1485 1486 1487 1488 1489
	Test suite framework improvement.
	* src/server/testsuite/config/unix.exp (extracting_expect): Report
	the value that was found in the "pass" message.  This may help
	debugging.

1490
	Test suite: Made the "stalled client" test more robust.
1491 1492 1493 1494 1495 1496
	* src/server/testsuite/lyskomd.0/38.exp: Set the sync interval to
	1 day, to avoid spurious save async messages on slow hosts.  Don't
	change the timeout.  Keep waiting as long as the server processes
	new requests, even if it is so slow that it takes a long while for
	the output queue to start filling up.
	(req_rate): New proc.
1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
	* src/server/testsuite/lyskomd.0/38.exp: Made the test for a
	stalled client more robust.
	(monitor_progress): Shut down the client if a timeout occurs.
	(send_queue_size): New proc.
	* src/server/testsuite/get-time-often.c (reading_from_server): New
	variable.
	(request_limit): New variable.
	(start_writing): New static function.
	(start_reading): Ditto.
	(stop_reading): Ditto.
	(read_stdin): New command: start-reading.
1508 1509 1510
	(read_server): If do_write_only, just return OOP_HALT when eof,
	EPIPE or ECONNRESET on the server is seen--don't print anything.
	Print a message if more than request_limit replies are received.
1511 1512 1513 1514 1515 1516
	(write_server): Made a log message unique.
	(main): Use start_reading(), start_writing() and stop_reading() to
	simplify the code.  Don't do a final write; different Unixes
	handles this in various strange ways, and we don't want to test
	*them*.

1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532
	Test suite fix.
	* src/server/testsuite/lyskomd.0/38.exp: Use a small message size
	and transmit queue.

	Make the packet sizes and output queue parameters configurable.
	* doc/lyskomd.texi (Parameters): Document "Max client message
	size", "Max client transmit queue messages" and "Max client
	transmit queue bytes".
	* src/server/server-config.c (parameters): Renamed "Max client
	transmit queue" to "Max client transmit queue messages".  Added
	"Max client message size" and "Max client transmit queue bytes".
	* src/server/ramkomd.c (server_init): Call isc_cfg_queue_size().
	Actually *use* param.maxqueuedsize and param.maxdequeuelen.
	* src/server/param.h (struct param): Added maxmsgsize and
	maxqueuedsize_bytes.

1533 1534 1535 1536 1537 1538
2003-08-01  Per Cederqvist  <ceder@ceder.dyndns.org>

	get-stats should never return a negative number.
	* src/server/stats.c (check_one_stat): Fix the value if it has
	become negative, even if the error isn't large enough to fix.

1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550
2003-08-01  Per Cederqvist  <ceder@lysator.liu.se>

	Fix struct timeval overflow problems on Linux/Alpha.
	* src/libraries/libmisc/timeval-util.h,
	src/libraries/libmisc/timeval-util.c (timeval_ctor): Changed type
	of the sec argument from int to time_t.
	* src/server/testsuite/lyskomd.0/37.exp: Handle the %g format now
	created by timeval-overflow.
	* src/server/testsuite/timeval-overflow.c (main): Use %g instead
	of %f to print the numbers, to avoid overflow problems in the %f
	representation.

1551 1552
2003-08-01  Per Cederqvist  <ceder@ceder.dyndns.org>

1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581
	More fixes to the test of stalled clients.
	* src/server/testsuite/get-time-often.c (main): Actually retry
	after a EAGAIN, EWOULDBLOCK or EINTR result from the final write.
	Retry if it succeeds as well -- the server may just be slow
	closing the socket.

	Collect statistics of the read and write queues.
	* doc/Protocol-A.texi (Measured Properties): Document
	send-queue-bytes and recv-queue-bytes.
	* src/server/stats.h (enum stat_type): Added STAT_SEND_QUEUE and
	STAT_RECV_QUEUE.
	* src/server/stats.c (name): Handle STAT_SEND_QUEUE and
	STAT_RECV_QUEUE.
	* src/server/ramkomd.c (write_queue_change_callback): New static
	function.  Update STAT_SEND_QUEUE.
	(server_init): Register write_queue_change_callback with isc.
	* src/server/internal-connections.c (kill_client): Update
	STAT_RECV_QUEUE.
	* src/server/connections.c (read_from_connection): Update
	STAT_RECV_QUEUE.
	* src/server/testsuite/lyskomd.0/01.exp: Test send-queue-bytes and
	recv-queue-bytes.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	* src/server/testsuite/lyskomd.0/38.exp: Ditto.

	Bug fix.
	* src/server/connections.c (toploop): Cancel the timer for
	check_kill_flag if needed during shutdown.

1582 1583 1584 1585 1586 1587 1588
	Don't be too efficient...  (Back out part of the "ignore clients"
	patch.)
	* src/server/connections.c (read_from_connection): Revert part of
	last change: flush the output even if the client is disconnecting.
	We want it to have a chance see the reply to the disconnect or
	shutdown request.

Per Cederqvist's avatar
Per Cederqvist committed
1589 1590 1591 1592
	Test suite fix.
	* src/server/testsuite/lyskomd.0/38.exp: Increased the timeout
	for stalled client detection even further.

1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605
	Fixed a memory leak during shutdown.  Ignore clients that are
	being killed more efficiently.
	* src/server/connections.h (Connection): New field: kill_pending.
	* src/server/internal-connections.c (init_connection): Initialize
	kill_pending.
	(new_client): Ditto.
	* src/server/connections.c (add_to_kill_list): Check and update
	kill_pending.
	(check_kill_flg): Ditto.
	(read_from_connection): Ignore connections with a pending kill.
	(toploop): Call check_kill_flg() during shutdown if any kill is
	pending, so that the kill list is freed.

1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622
	Test suite fixes.
	* src/server/testsuite/lyskomd.0/37.exp: Handle "Stale timeout".
	* src/server/testsuite/lyskomd.0/38.exp: Use --write-only without
	the --time-abort.  Use the new "shutdown" command of
	get-time-client.  Allow the server half a minute to fill the
	output queue for the --write-only test.
	* src/server/testsuite/config/unix.exp (client_start_fail): Don't
	call wait from expect_always code.  It would wait on the wrong
	process.
	(client_start_fail): Ditto.
	(get_time_client_start): Ditto.
	* src/server/testsuite/get-time-often.c (read_stdin): Implement
	the commands "ping" and "shutdown".
	(write_server): Don't return OOP_HALT just because the socket to
	the server is reset, but stop writing in that case.
	(main): Allow --write-only without --time-abort.  Retry the final
	write up to 3 times if it fails with EPIPE, ECONNRESET or EINTR.
Per Cederqvist's avatar
Per Cederqvist committed
1623
	(main): Write more than a single byte in the final write.
1624 1625 1626 1627 1628

	Xenofarm: ignore more warnings.
	* scripts/warnings.sed: Allow line numbers in floating point
	comparison warnings from mathinline.h to differ.

1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663
	Disconnect stale clients.
	* doc/lyskomd.texi (Parameters): Document "Stale timeout".
	* src/server/server-config.c (parameters): Added "Stale timeout".
	* src/server/ramkomd.c (server_init): Configure the stale timeout
	of ISC.
	* src/server/param.h (struct kom_par): Added stale_timeout.
	* src/server/connections.c (stale_cb): New static function.
	(login_request): Pass stale_cb to isc_set_read_callback().
	(setup_timer): Moved to timeval-util.h, and added a return value.
	All callers updated to check it.
	* src/server/testsuite/lyskomd.0/38.exp: Set the "Stale timeout"
	to 10 seconds, so that we