ChangeLog 57.4 KB
Newer Older
1
2
1998-08-09  Per Cederqvist  <ceder@lysator.liu.se>

3
4
5
6
	Fixed bugs in get_created_texts.
	* src/server/person.c (get_created_texts): Fixed a fencepost error
	and two other errors, all introduced 1998-07-26.

7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
	Test suite improvements.
	* src/server/testsuite/lyskomd.0/00.exp: Added more tests.  Added
	tests for get-created-texts.
	* src/server/testsuite/l2g.0/10.exp: New file.
	* src/server/testsuite/config/unix.exp (l2g_stop): Send a quit
	command to test-l2g, so that we can be sure that the test case
	doesn't miss some unexpected final output from the test program.
	(unanchored_expect): Fixed an error message.
	* src/server/testsuite/test-l2g.c (main): Added 'q' (quit)
	command.

	Fixed more bugs in get_map.
	* src/server/text.c (get_map): Set result.first_local_no correctly
	if the map in the conference is completely empty.
	* src/server/prot-a-output.c
	(prot_a_output_l2g_iterator_as_text_list): Don't forget to emit
	trailing zeroes in the text-list.

	Document some previously undocumented behavior of get-map and
	get-created-texts.
	* doc/Protocol-A.texi (get-map): Document what happens when
	attempting to retrieve texts before the start of the map.
	(get-created-texts): Likewise.

	The L2g_iterator sometimes iterated past the end of a bounded search.
	* src/server/local-to-global.c (l2gi_searchsome): Set search_ended
	correctly when the end is set so that the iterator will loop over
	nothing, even though later texts exists.

36
37
38
39
40
	Let automake generate the INSTALL file.
	* README: Include the contents of the INSTALL file.  This file
	needs a major overhaul.
	* mkmi: Remove INSTALL and expect automake to recreate it.

41
42
43
44
45
46
47
48
49
50
51
52
53
	Removed GNU malloc.  The integration was poor, to say the least,
	and it was not generally an improvement to use GNU malloc.
	* src/server/testsuite/Makefile.am: Removed references to gnumalloc.
	* src/server/Makefile.am: Removed reference to gnumalloc.
	* src/libraries/Makefile.am (SUBDIRS): Removed @GNUMALLOC@.
	* INSTALL: Don't mention GNU malloc.
	* configure.in: --with-gnu-malloc: flag removed.  Don't substitute
	GNUMALLOC.  Don't define USE_GNU_MALLOC or USING_GNU_MALLOC.
	Don't use the following that was only used because of GNU malloc:
	SUNOS_LOCALTIME_BUG, getpagesize, memmove, AC_USG.  Don't attempt
	to create src/libraries/gnumalloc/Makefile.
	* src/libraries/gnumalloc: All files in this directory removed.

54
55
56
57
	Added sanity check to local_to_global.
	* src/server/text.c (local_to_global): Check that the no_of_texts
	argument isn't larger than 255.

58
59
1998-08-08  Per Cederqvist  <ceder@lysator.liu.se>

60
61
62
63
	Fixed a protocol error with async_deleted_text.
	* src/server/prot-a-send-async.c (prot_a_async_deleted_text):
	Fixed the size in the header.  This emits 18 elements, not 16.

Per Cederqvist's avatar
Per Cederqvist committed
64
65
66
67
68
	Minor documentation fixes.
	* doc/aux-info.doc: Document dont-garb.
	* doc/Protocol-A.texi: Spell checking performed.  Some other minor
	typos fixed.  State that the aux-item read-confirm should only be
	added after the user has acknowledged that he has read the text.
69
70
71
72
	(accept-async): Moved some text that belonged here from the
	query-async node.  The error-status indicates the first offending
	number, not the index of the first offending number, when
	unknown-async is returnd.
Per Cederqvist's avatar
Per Cederqvist committed
73
	
74
75
76
77
78
79
	Fixed bugs in get_map and local_to_global.
	* src/server/text.c (get_map): Fixed a couple of fence errors.
	(local_to_global): Using first_local_no==0 is an error.  Fixed a
	fence error.
	* src/server/prot-a-output.c (prot_a_output_text_mapping): Emit
	"0" or "1", not "48" or "49", as the later-texts-exists flag.
80
	Fixed a bug that could cause much too much data to be written.
81
82
83

	Fixed bugs and made improvements to the test cases for get_map and
	local_to_global.
84
85
	* src/server/testsuite/lyskomd.0/00.exp: Many bugs fixed.  Several
	tests added. 
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
	* src/server/testsuite/config/unix.exp (attach): New constant.
	(line_leader): New variable.
	(meta_line_leader): New variable.
	(l2g_start): Set l2g_id, expect_active and expect_always.
	(fix_expect_after): New proc.
	(simple_expect): New argument: meta.  Handle line leaders.
	Removed tests for unexpected lines, which should now be handled
	via expect_active.
	(unanchored_expect): Added missing quotes.
	(lyskomd_start): Handle attach.  Set expect_active and
	expect_always to something sane.
	(client_start): Use tcpconnect.py and line leaders to make it
	easier to debug the test cases.  Set expect_active and
	expect_always to something sane.
	(talk_to): Handle l2g.  Handle line leaders.  Call
	fix_expect_after.
102
	(client_death): New proc.
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
	* src/server/testsuite/tcpconnect.py: New file.
	* src/server/testsuite/Makefile.am (../lyskomd): New target.
	(lyskomd_check): Depend on ../lyskomd.
	(site.exp): Added srcdir.
	(EXTRA_DIST): Added tcpconnect.py.
	* src/server/Makefile.am (all-recursive check-recursive): Depend
	on lyskomd.
	
	Read the file name of the "Aux-item definition file" from the
	config file, not from the command line.
	* src/server/testsuite/config/Makefile.am (lyskomd-config): Added
	"Aux-item definition file".
	* src/server/server-config.c (parameters): Added "Aux-item
	definition file".
	(AUX_DEF_FILE): Removed.
118
119
	(read_configuration): Handle aux_def_file just like all the other
	file names.
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
	* src/server/ramkomd.c (initialize): Removed the aux_def_file
	argument.  All callers updated.  Get the file of the aux_def_file
	from the config file.
	(main): Removed the -c and -a options.  This reverts the change
	from Sat Sep 13 15:07:32 1997.  It is more consistent to get the
	file name of the aux-def file from the config file.  The -c option
	was buggy anyhow.
	* src/server/param.h (struct kom_par): Added aux_def_file.
	* doc/man/lyskomd.8: Removed the -c and -c flags.  Added "Aux-item
	definition file".
	* src/include/config.h (AUX_DEF_FILE): Constant removed.

	Default to sending async_new_text_old and ay_leave_conf, bug not
	async_new_text, just as the documentation says.
	* src/server/send-async.c (async_new_text_old): Use
	prot_a_async_new_text_old, not prot_a_async_new_text.
	* src/server/async.h (ASYNC_DEFAULT_MESSAGES): Added
	ay_new_text_old instead of ay_new_text.  Added ay_leave_conf.

	Get rid of some compiler warnings.
	* src/server/rfc931.c (get_real_username): Mark unused arguments.
	* src/server/dbck-cache.c (cached_lock_person): Marked unused
	arguments.
	(cached_unlock_person): Likewise.
	(cached_lock_conf): Likewise.
	(cached_unlock_conf): Likewise.

147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
1998-08-07  Per Cederqvist  <ceder@signum.se>

	Merged old uncommitted changes to prot-A.txt.
	* doc/prot-A.txt: Error code 38=no-connect is no longer used.
	Documented 85=get-collate-table.  Typo fixes.

	Facilitate testing of Local_to_global with Electric Fence.
	* src/server/testsuite/config/unix.exp (efence): New constant.
	(efence_blurb): New proc.
	(l2g_start): Handle an efence-instrumented test program if the
	global variable efence is true.

	Improved the documentation on the config file.
	* doc/man/lyskomd.8: Documented the values that you can pass to
	bool config parameters.

163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
1998-08-06  Per Cederqvist  <ceder@lysator.liu.se>

	Added the beginnings of a test suite for the complete lyskomd
	binary.
	* README: Talk a little about the test suite.
	* src/server/testsuite/Makefile.am (l2g_check): Added --srcdir to
	the runtest command line.
	(lyskomd_check): New target.
	* src/server/testsuite/Makefile.am (check): Added lyskomd_check.
	* src/server/testsuite/lyskomd.0/00.exp: New file.
	* src/server/testsuite/config/unix.exp:
	(hollerith): New constant.
	(maxint): New constant.
	(clientport): New constant.
	(muxport): New constant.
	(unanchored_expect): Continue with the expect if an unexpected
	line is detected.
	(lyskomd_start): New proc.
	(lyskomd_death): New proc.
	(client_start): New proc.
	(talk_to): New proc.
	(holl): New proc.
	* src/server/testsuite/config/Makefile.am (noinst_DATA): Added
	lyskomd-config.
	(lyskomd-config): New target.

	Regenerate protocol-a.info automatically.
	* doc/Makefile.am (protocol-a.info): Added an explicit rule
	because Automake 1.3 fails to add it automatically.

193
194
1998-08-05  Per Cederqvist  <ceder@lysator.liu.se>

195
196
197
198
	Fixed the documentation for the local-to-global call.
	* doc/Protocol-A.texi (LysKOM Data Types): Changed the name of the
	type Local-To-Global_Result to Text-Mapping.  All uses updated.

199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
	Implemented the local-to-global call.
	* src/server/fncdef.txt: Added local_to_global.
	* src/include/services.h (local_to_global): New function.
	* src/include/kom-types.h (Text_mapping): New type.
	* src/server/text.c (get_map): Fixed the type of the no_of_texts
	argument.
	(local_to_global): New function.
	* src/server/prot-a.c (prot_a_reply): Handle rt_text_mapping.
	(prot_a_is_legal_fnc): Handle call_fnc_local_to_global.
	* src/server/prot-a-output.c (prot_a_output_text_mapping): New
	function.
	* src/server/prot-a-output.h: Likewise.
	* src/server/connections.h (Res_type): Added rt_text_mapping.
	(Result_holder): Added text_mapping.

214
215
216
217
218
219
220
221
222
223
224
225
226
1998-08-03  Per Cederqvist  <ceder@lysator.liu.se>

	Document the local-to-global call.
	* doc/Protocol-A.texi (Articles): Refer to local-to-global instead
	of get-map.
	(LysKOM Data Types): Added subsection titled "Mapping Local to
	Global Text Numbers".
	(Protocol Requests): Mark get-map as obsolete, and refer to 103.
	Added 103=local-to-global.
	(get-map): This is superseded by local-to-global.
	(accept-async): Fixed typo.
	(local-to-global): New node.

227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
1998-08-02  Per Cederqvist  <ceder@lysator.liu.se>

	Generate and install protocol-a.info.
	* doc/Makefile.am (info_TEXINFOS): New target.  Moved
	Protocol-A.texi here.
	(EXTRA_DIST): Moved Protocol-A.texi to info_TEXINFOS.
	* mkmi: Remove scripts/texinfo.tex and expect automake to
	regenerate it.

	Minor syntactic documentation fixes.
	* doc/Protocol-A.texi: Added @dircategory and @direntry commands.
	(Protocol Requests): Added set-membership-type to the menu.
	(set-membership-type): Minor typo fixed.
	(Top): State that this is a draft, and that the version numbers
	are wrong.

243
244
245
246
247
248
249
1998-07-27  Per Cederqvist  <ceder@lysator.liu.se>

	Fixed a pointer bug in Local_to_global.
	* src/server/local-to-global.c (join_range): Fixed a bug where
	a pointer that pointed to the old position of a reallocated block
	was used.

Per Cederqvist's avatar
Per Cederqvist committed
250
251
1998-07-26  Per Cederqvist  <ceder@lysator.liu.se>

252
253
254
255
256
257
258
	dbck can now read database format 2.
	* src/server/dbck-cache.c (init_cache): Handle database format 2.

	Fix the bootstrap database.
	* db-crypt/db/lyskomd-data: CONF-RECORD uses the Local_to_global
	structure.

259
260
261
262
263
264
265
266
267
	Remove all traces of the Text_list type.
	* src/include/kom-types.h (Text_list): Removed.
	* src/server/connections.h (Res_type): Removed rt_text_list.
	(Result_holder): Removed text_list.
	* src/server/prot-a-output.h (prot_a_output_text_list): Removed.
	* src/server/prot-a-output.c (prot_a_output_text_list): Removed.
	* src/server/prot-a.c (prot_a_reply): Don't attempt to handle
	rt_text_list.

Per Cederqvist's avatar
Per Cederqvist committed
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
	Code cleanup.
	* src/server/aux-item-def.y: Fixed indentation of include statements.
	* src/server/aux-item-def.lex.c: No longer kept under version
	control.

	Improve documentation.
	* doc/server.extend: Updated.

	Start using the Local_to_global structure.
	* doc/lyskomd-database-format (DATABASE VERSION 2): CONF-RECORD
	and PERS-RECORD uses the Local_to_global structure.
	* configure.in: Added AC_C_INLINE.
	* src/server/text.c (add_text_in_conf): Adjusted to the fact that
	the texts member of Conference is now a l2g.
	(do_sub_recpt): Likewise.
	(set_loc_no): Removed.
	(adjust_text_list): Removed.
	(do_delete_text): Adjusted to the fact that the created_texts
	member of Person is now a l2g.
	(do_create_text): Likewise.
	(get_map): The result argument now points to a
	l2g_iterator_as_text_list instead of a Text_list.  Adjusted to the
	fact that the texts member of Conference is now a l2g.
	* src/server/simple-cache.c (mark_conference_as_changed): Adjusted
	to the fact that the texts member of Conference is now a l2g.
	(setup_small_conf): Likewise.
	* src/server/ram-parse.h (fparse_text_list): Removed.
	* src/server/ram-parse.c (fparse_conference_2): Use l2g_read
	instead of fparse_text_list.
	(fparse_person_2): Likewise.
	(fparse_text_list): The result argument now points to a
	Local_to_global instead of a Text_list.
	* src/server/ram-output.h (foutput_text_list): The text_list
	argument is now a pointer to Local_to_global instead of a
	Text_list.
	* src/server/ram-output.c (foutput_person_0): Adjusted to new API
	of foutput_text_list.
	(foutput_person_2): Use l2g_write instead of foutput_text_list.
	(foutput_conference_2): Likewise.
	(foutput_conference_1): Adjusted to new API of foutput_text_list.
	(foutput_conference_0): Likewise.
	(foutput_text_list): The text_list argument is now a pointer to
	Local_to_global instead of a Text_list.  The generated output is
	still the same.
	(foutput_ulong): Eliminated a future buffer overrun.  Cleaned up
	the code.
	* src/server/prot-a.c (prot_a_reply): Handle
	rt_l2g_iterator_as_text_list.
	* src/server/prot-a-output.h
	(prot_a_output_l2g_iterator_as_text_list): New function.
	* src/server/prot-a-output.c (prot_a_output_person): Adjusted to
	the fact that the created_texts member of Person is now a l2g.
	(prot_a_output_conference): Adjusted to the fact that the texts
	member of Conference is now a l2g.
	(prot_a_output_conference_old): Likewise.
	(prot_a_output_l2g_iterator_as_text_list): New function which
	emulates a Text_list.
	* src/server/person.c (do_delete_pers): Adjusted to the fact that
	the created_texts member of Person is now a l2g.
	(get_created_texts): The return value is now an
	l2g_iterator_as_text_list, not a Text_list.  Adjusted to the fact
	that the created_texts member of Person is now a l2g.
	* src/server/memory.c (clear_text_list): Removed.
	(copy_text_list): Removed.
	(clear_conference): Adjusted to the fact that the texts member of
	Conference is now a l2g.
	(init_conference): Likewise.
	(copy_conference): Likewise.  Added const qualifier to the
	argument.
	(clear_person): Adjusted to the fact that the created_texts member
	of Person is now a l2g.
	(copy_person): Likewise.
	(init_person): Likewise.
	(init_text_list): Removed.
	(copy_aux_item_list): Added const qualifier to the src argument.
	* src/server/membership.c (add_rec_time): Adjusted to the fact
	that the texts member of Conference is now a l2g.
	(adjust_read): Likewise.
	(mark_as_read): Likewise.
	(check_membership): Likewise.
	(set_unread): Likewise.
	(set_last_read): Likewise.
	* src/server/kom-memory.h (copy_conference): The argument is const.
	(copy_aux_item_list): Likewise.
	(init_text_list): Removed.
	* src/server/fncdef.txt (get_map): Changed return type from
	text_list to l2g_iterator_as_text_list.
	(get_created_texts): Likewise.
	* src/server/dbck.c (struct delete_list): New struct.
	(delete_list_append): New static function.
	(execute_deletions): New static function.
	(check_misc_infos): Adjusted to the fact that the texts member of
	Conference is now a l2g.
	(adjust_text_list): Deleted.
	(check_created_texts): The "created" argument now points to a
	Local_to_global.  Removed the check for "bad created_texts array"
	since it can no longer be bad in that way.
	(check_membership): Adjusted to the fact that the texts member of
	Conference is now a l2g.
	(check_texts_in_conf): The "tlist" argument now points to a
	Local_to_global.  Removed the check for "bad created_texts array"
	since it can no longer be bad in that way.
	* src/server/dbck-cache.c (cached_get_highest_local_no): Adjusted
	to the fact that the texts member is now a l2g.
	(cache_sync): Fixed type in some printf format strings.
	* src/server/connections.h (Res_type): Added
	rt_l2g_iterator_as_text_list.
	(Result_holder): Added l2g_iterator_as_text_list.
	* src/server/conference.c: (do_delete_conf): Adjusted to the fact
	that the texts member is now a l2g.
	* src/server/Makefile.am (DBCK): Added local-to-global.c.
	(all-recursive, check-recursive): Require libcheck.a to be built.
	* src/include/services.h (get_created_texts): Changed type of
	the result to L2g_iterator_as_text_list.
	(get_map): Likewise.
	* src/include/kom-types.h (struct l2g_block_info): New forward
	declaration.
	(Local_to_global): New type.
	(L2g_iterator): New type.
	(L2g_iterator_as_text_list): New type.
	(Conference): The texts member is now a Local_to_global, not a
	Text_list.
	(Person): The created_texts member is now a Local_to_global, not a
	Text_list.

	Fixes and improvements to the Local_to_global structure.
	* src/server/local-to-global.h (L2G_BLOCKSIZE): Moved to
	local-to-global.c.
	(L2g_block_info): Likewise.
	(Local_to_global): Likewise.
	(l2g_copy): Switched placement of src and dest to match other copy
	functions in the lyskomd code.  Added const qualifier.
	(l2g_lookup): Added const qualifier to the l2g argument.
	(l2g_next_key): Likewise.
	(l2g_compact): Removed.
	(l2g_first_appendable_key): New function.
	(l2g_delete_global_in_sorted): New function.
	(l2g_dump): Switch placement of l2g and file arguments to match
	other similar functions in the lyskomd code.  Added const
	qualifier.
	(l2g_write): Likewise.
	(l2g_read): Likewise.
	(l2g_searchall): Added const qualifier.
	(L2g_iterator): Moved to kom-types.h.
	(l2gi_searchsome): Added const qualifier.
	(l2gi_begin): New function.
	(l2gi_end): New function.
	* src/server/local-to-global.c: Include assert.h.  Only include
	stdlib.h if HAVE_STDLIB_H.  Include stdio.h if we didn't get NULL
	from stdlib.h.  Inlucd lyskomd.h and server/smalloc.h.
	(L2G_BLOCKSIZE): Moved here from local-to-global.h.
	(struct l2g_block_info): Likewise.
	(is_dense): New static function.
	(is_empty): New static function.
	(key_value): New static function.
	(sparse_skip_deleted): New static function.
	(sparse_locate_value): New static function.
	(sparse_compact): New static function.
	(add_block): Use srealloc instead of realloc.  Don't initialize
	start -- the caller is responsible for doing so.
	(delete_block): Use sfree instead of free, and srealloc instead of
	realloc.
	(make_sparse): Don't change the value of start, since there is no
	need to, and make_sparse may now be called on an empty block,
	which would cause start to be set to a garbage value.
	(find_block): Added a const qualifier to the return value and l2g
	argument.  Use key_value to simplify code.
	(find_block_index_key): Added a const qualifier to the l2g
	argument.  Use helper functions to simplify the code.  Use
	sparse_skip_deleted so that the function never returns a deleted
	key.  Never return deleted keys in dense blocks either.
	(join_range): New static function.
	(join_blocks): New static function.
	(l2g_init): Set first_unused to 1.
	(l2g_clear): Use sfree instead of free.  Set first_unused to 1.
	(l2g_copy): Added const qualifier to the src argument.  Simplified
	code by using helper functions and relying on the fact that
	calling l2g_append with a Text_no=0 is a no-op.  Set first_unused
	of the copy.
	(l2g_append): Send a log message and do nothing if an attempt to
	set a local number lower than first_unused is detected.  Set
	first_unused.  Fixed the logic about when to add a new block, when
	to compact the last block, and when to make it sparse.  Simplify
	code by using the helper functions.
	(l2g_delete): Don't increase the zeroes counter if a zero is
	deleted.  Delete the entire block if it became empty.  Attempt to
	join this block to its neighbors.  Compact the block if it was
	sparse and contained too many deleted entries.
	(l2g_lookup): Added const qualifier to the l2g argument.  Don't
	return uninitialized data.  Use helper functions to simplify code
	and make it slightly faster.
	(l2g_next_key): Added const qualifier to the l2g argument.
	(l2g_first_appendable_key): New function.
	(l2g_delete_global_in_sorted): New function.
	(l2g_compact): Removed.
	(l2g_dump): Switch placement of l2g and file arguments to match
	other similar functions in the lyskomd code.  Added const
	qualifier.  Dump first_unused.  Use helper functions to simplify
	code.
	(l2g_read): Switch placement of l2g and file arguments to match
	other similar functions in the lyskomd code.  Read first_unused.
	Return a success indicator.  Detect unexpected EOF conditions.
	(l2g_write): Switch placement of l2g and file arguments to match
	other similar functions in the lyskomd code.  Write first_unused.
	Use helper functions to simplify code.
	(l2gi_searchall): Added const qualifier to the l2g argument.
	Simplify code by calling l2gi_searchsome instead of duplicating
	the code.
	(l2gi_searchsome): Added const qualifier to the l2g argument.
	Complain if the begin argument is less than 1.  Don't forget to
	initialize search_ended.  Set beginval.  Giving end==0 means that
	the iterator should continue to the end of the set.  Use helper
	functions to simplify the code.
	(l2gi_next): Use helper functions to simplify code.  The iterator
	is unlimited if endval==0.
	(l2gi_begin): New function.
	(l2gi_end): New function.
	
	Improve the test suite with new tests of the Local_to_global
	structure.
	* src/server/testsuite/l2g.0/00.exp: The "C" command now takes the
	arguments the other way around.  Adjust the test case.  Comments
	added.  Expect the "u" command to print first_unused.
	* src/server/testsuite/l2g.0/02.exp: New file.
	* src/server/testsuite/l2g.0/03.exp: New file.
	* src/server/testsuite/l2g.0/04.exp: New file.
	* src/server/testsuite/l2g.0/05.exp: New file.
	* src/server/testsuite/l2g.0/06.exp: New file.
	* src/server/testsuite/l2g.0/07.exp: New file.
	* src/server/testsuite/l2g.0/08.exp: New file.
	* src/server/testsuite/l2g.0/09.exp: New file.
	* src/server/testsuite/config/unix.exp (l2g_stop): Added a wait
	statement to avoid creating zombies.
	(simple_expect): Added a missing space in a prompt regexp.
	* src/server/testsuite/test-l2g.c (main): Removed the 'c' command
	since l2g_compact no longer exists.  Added the 'i' command that
	tests iterators.  Adjusted to the new API of l2g_dump, l2g_read
	and l2g_write.  Require an extra trailing newline after the
	representation l2g_read expects when the 'r' command is used, and
	produce a corresponding newline with the 'w' command.  Renamed the
	'p' command to 'w'.

Per Cederqvist's avatar
Per Cederqvist committed
510
511
512
513
514
515
1998-07-19  Per Cederqvist  <ceder@lysator.liu.se>

	Protocol buglets fixed.
	* doc/Protocol-A.texi (Membership-Type, Session-Flags): Fixed
	syntax error in the definition.

516
517
1998-07-12  Per Cederqvist  <ceder@lysator.liu.se>

518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
	Build the program in the test suite.
	* src/server/ramkomd.c (restart_kom): Moved to log.c.
	* src/server/log.c (restart_kom): Moved here from ramkomd.c.
	* src/server/Makefile.am (noinst_LIBRARIES): Added libcheck.a.
	(libcheck_a_SOURCES): New library, used by the test suite.
	* src/server/testsuite/Makefile.am (noinst_PROGRAMS): Added test-l2g.
	(EXTRA_DIST): Removed test-l2g.c.
	(test_l2g_SOURCES): Added test-l2g.c.
	(test_l2g_LDADD): Added ../libcheck.a.
	(../libcheck.a): New target.

	Removed all old makefile template files.
	* Makefile.src: Removed.
	* doc/Makefile.src: Removed.
	* doc/man/Makefile.src: Removed.
	* run-support/Makefile.src: Removed.
	* scripts/Makefile.src: Removed.
	* src/Makefile.src: Removed.
	* src/include/Makefile.src: Removed.
	* src/include/server/Makefile.src: Removed.
	* src/libraries/Makefile.src: Removed.
	* src/libraries/gnumalloc/Makefile.src: Removed.
	* src/libraries/libansi/Makefile.src: Removed.
	* src/libraries/libcommon/Makefile.src: Removed.
	* src/libraries/libisc-new/Makefile.src: Removed.
	* src/libraries/libisc-new/src/Makefile.src: Removed.
	* src/libraries/libmisc/Makefile.src: Removed.
	* src/libraries/regex/Makefile.src: Removed.
	* src/libraries/regex/doc/Makefile.src: Removed.
	* src/libraries/regex/test/Makefile.src: Removed.
	* src/server/Makefile.src: Removed.
	* src/server/testsuite/Makefile.src: Removed.
	
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
	Fixed "make dist".
	* SERVER-RELEASE: Slightly updated.
	* src/server/testsuite/config/Makefile.am: New file.
	* src/server/testsuite/Makefile.am (SUBDIRS): Added config.
	(EXTRA_DIST): Added .cvsignore and test-l2g.c.
	(MOSTLYCLEANFILES): Added .gdbinit and site.exp.
	* src/server/Makefile.am (EXTRA_DIST): Added .cvsignore,
	ChangeLog.1, Magics, To-do, aux-item-def.l, aux-item-def.y,
	call-switch.awk, com-h.awk, fnc-def-init.awk,
	prot-a-parse-arg-c.awk, prot-a-parse-arg-h.awk, fncdef.txt,
	free.gdb, handle-malloc-dump.el, malloc.gdb, realloc.gdb,
	trace-mem.gdb and logII.c.
	(MOSTLYCLEANFILES): Added .gdbinit, call-switch.incl, com.h,
	fnc-def-init.incl, fncdef-no-str-limit.txt, prot-a-parse-arg.h and
	version.incl.
	(MAINTAINERCLEANFILES): Added aux-item-def.tab.h.
	(lyskomd_SOURCES): Added admin.h, async.h, aux-items.h,
	cache-node.h, cache.h, conf-file.h, connections.h,
	end-of-atomic.h, exp.h, internal-connections.h,
	internal-services.h, isc-interface.h, isc-malloc.h, isc-parse.h,
	kom-memory.h, local-to-global.h, log.h, lyskomd.h, manipulate.h,
	minmax.h, mux-parse.h, mux.h, param.h, prot-a-output.h,
	prot-a-parse.h, prot-a-send-async.h, prot-a.h, ram-output.h,
	ram-parse.h, rfc931.h, send-async.h, server-config.h,
	string-malloc.h, text-garb.h, tmp-limits.h and version-info.h.
	(dbck_SOURCES): Added dbck-cache.h and getopt.h.
	* src/libraries/libmisc/Makefile.am (EXTRA_DIST): Added ChangeLog.1.
	* src/libraries/libcommon/Makefile.am (EXTRA_DIST): Added ChangeLog.1.
	* src/include/Makefile.am (EXTRA_DIST): Added ChangeLog.1.
	* run-support/Makefile.am (EXTRA_DIST): Added .cvsignore,
	komrunning.sh and savecore.sh.
	* doc/man/Makefile.am (EXTRA_DIST): Added $(man_MANS).
	* doc/prot-A-english.txt: Added a reference to Protocol-A.texi.
	* doc/Makefile.am (EXTRA_DIST): Added Buggar.fixade, Bugrapporter,
	LOGG, Protocol-A.texi, aux-info.doc, clients.assigned,
	cmsltt12.mf, dbck.latexinfo, disc-cache.spec, local-to-global.doc,
	lyskomd-database-format, mux.proto, prot-A-english.txt and
	security-levels.txt.
	* db-crypt/db/Makefile.am (EXTRA_DIST): Added .cvsignore.
	* db-crypt/Makefile.am (EXTRA_DIST): Added .cvsignore.
	* configure.in: Generate src/server/testsuite/config/Makefile.
	* Makefile.am (EXTRA_DIST): Added ChangeLog.1, README.FSF,
	SERVER-RELEASE, mkmi and versions.

	Removed	obsolete and unused files.
	* src/server/disk-end-of-atomic.c: Don't include disk-cache.h.
	* src/server/sync.c: Removed.
	* src/server/disk-cache.h: Removed.
	* src/server/cache.c: Removed.
	* src/server/cache-database.h: Removed.
	* src/server/cache-database.c: Removed.
	* scripts/mkmi.m4: Removed.
	* scripts/makedist.sh: Removed.
	* doc/libraries: Removed
	* doc/fileformat: Removed.
	* doc/elisp-client.user-manual: Removed.
	* doc/elisp-client.internals: Removed.
	* doc/Introduktion: Removed.

	Don't version-control generated files.
	* src/server/aux-item-def.tab.h: No longer kept under version
	control.

	Removed the last traces of zmalloc.
	* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Removed
	zmalloc.h.

618
619
1998-07-11  Per Cederqvist  <ceder@lysator.liu.se>

620
	Install the sample database (unless it was already installed).
Per Cederqvist's avatar
Per Cederqvist committed
621
	* configure.in: Generate db-crypt/db/Makefile.
622
623
624
	* db-crypt/Makefile.am (SUBDIRS): Added db.
	* db-crypt/db/Makefile.am: New file.

625
626
627
628
	Fix compilation outside the source directory.
	* src/server/Makefile.am (aux-item-def.tab.c): Look for
	aux-item-def.y in srcdir.

629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
1998-07-10  Per Cederqvist  <ceder@lysator.liu.se>

	Fix "make install".
	* run-support/Makefile.am (sysconf_DATA): Added, but empty.
	(EXTRA_DIST): Added config and aux-items.conf.
	(komrunning): The current standard names the variable sysconfdir,
	not etcdir.
	(savecore): Likewise.
	(install-data-local): Likewise.
	
	Fix the configure script so that --enable-isc-printf is no longer
	needed.
	* configure.in: Force enable_isc_printf so that libisc contains
	the proper things.

	Some versions of libnsl and/or libsocket are reportedly bogus, so
	don't link against them unless it is really necessary.
	* configure.in: Improved checking for -lsocket and -lnsl.

648
649
1998-07-09  Per Cederqvist  <ceder@lysator.liu.se>

650
	Don't forget src/server/testsuite.
651
652
	* configure.in: Don't forget src/server/testsuite.
	(USING_GNU_MALLOC): An automake conditional.
653
654
655
656
657
658
	* src/server/testsuite/test-l2g.c (main): Make it a proper
	prototype.  Avoid problems with signed chars.  Fixed typo: use
	l2g_write, not l2g_print.
	* src/server/testsuite/Makefile.am: New file.
	* src/server/Makefile.am (SUBDIRS): New variable; added testsuite.

659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
	Don't try to compile zmalloc which was removed yesterday.
	* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Removed
	zmalloc.c.

	Build komrunning and savecore.
	* run-support/Makefile.am: New file.

	Switch to using automake.
	* mkmi: Run aclocal, automake and autoconf instead of creating
	Makefile.in via a m4 script.
	* configure.in: Move up AC_CONFIG_AUX_DIR so that both automake
	and autoconf detects it early enough.  Remove explicit AC_SUBST of
	several variables that automake handles automatically, or that was
	used for functionality that automake provides in different ways:
	CFLAGS, CPPFLAGS, LDFLAGS, DEPENDFLAGS, INCLUDE_CURRENT,
	EXTRAARFLAGS, SRCTOPDIR, BUILDTOPDIR. Added call to
	AM_C_PROTOTYPES.  Rely on automakes ability to fix dependencies
	automatically and handle ARFLAGS properly.  Use
	CMOD_COMPILER_CC_ACCEPTS to check for a lot of warning flags to
	use.  Use CMOD_C_ATTRIBUTE_UNUSED.  Use AM_PROG_LEX instead of
	AC_PROG_LEX.  Removed check for sys/select.h, which only isc uses.
	Added check for values.h.  Run configure in
	src/libraries/libisc-new instead of creating makefiles in that
682
	directory.  Generate db-crypt/Makefile and run-support/Makefile.
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704

	Don't version-control files that are generated by aclocal,
	automake, autoconf or bison.
	* Makefile.in: No longer kept under version control.
	* aclocal.m4: Likewise.
	* configure: Likewise.
	* doc/Makefile.in: Likewise.
	* doc/man/Makefile.in: Likewise.
	* run-support/Makefile.in: Likewise.
	* scripts/Makefile.in: Likewise.
	* scripts/install-sh: Likewise.
	* scripts/mkinstalldirs: Likewise.
	* src/Makefile.in: Likewise.
	* src/include/Makefile.in: Likewise.
	* src/include/server/Makefile.in: Likewise.
	* src/libraries/Makefile.in: Likewise.
	* src/libraries/libansi/Makefile.in: Likewise.
	* src/libraries/libcommon/Makefile.in: Likewise.
	* src/libraries/libmisc/Makefile.in: Likewise.
	* src/server/Makefile.in: Likewise.
	* src/server/aux-item-def.tab.c: Likewise.

705
706
707
708
709
710
1998-07-08  Per Cederqvist  <ceder@lysator.liu.se>

	Use libisc-0.99.
	* src/server/isc-interface.h: Include "isc.h" instead of
	"isc-new.h".
	(ISC_PRINTF_SUPPORT): Define it.
711
712
713
	* src/libraries/libisc-new: Replace the old contents with that of
	isc-0.99.  Se src/libraries/libisc-new/ChangeLog for information
	about any modifications that are made to the library.
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947

	Added files that automake requires.
	* AUTHORS: New file.
	* README-serverrelease: Renamed to README.
	* README: New name for former README-serverrelease.
	* acinclude.m4: New file.  Contents taken from the old
	aclocal.m4, but changed to match the contents of libisc.

	Added new makefile templates for automake.
	* Makefile.am: New file.
	* db-crypt/Makefile.am: New file.
	* doc/Makefile.am: New file.
	* doc/man/Makefile.am: New file.
	* scripts/Makefile.am: New file.
	* src/Makefile.am: New file.
	* src/include/Makefile.am: New file.
	* src/include/server/Makefile.am: New file.
	* src/libraries/Makefile.am: New file.
	* src/libraries/libansi/Makefile.am: New file.
	* src/libraries/libcommon/Makefile.am: New file.
	* src/libraries/libmisc/Makefile.am: New file.
	* src/server/Makefile.am: New file.

	Code cleanup for increased portability.
	* src/libraries/libmisc/pom.c: Use HAVE_VALUES_H instead of
	__svr4__ and __sparc__ to protect inclusion of <values.h>.
	(rcsid): Added a missing const.

	Improved some variable types and fixed problems with signed
	chars.
	* src/server/simple-cache.c (rcsid): Added a missing const.
	(next_free_num): Changed type from int to Conf_no.
	(next_text_num): Changed type from int to Text_no.
	(read_person): Flag unused parameters.
	(read_conference): Likewise.
	(read_text_stat): Likewise.
	(cached_get_text_stat): Adjusted printf format according to
	the next_text_num change.
	(init_cache): Likewise.
	(free_match_table): Renamed a parameter name to avoid
	warnings from gcc.
	(build_matching_info): Renamed a local variable name to avoid
	warnings from gcc.
	(pre_sync): Use tno_iter and cno_iter instead of i to get all
	types correct.
	(post_sync): Likewise.
	(copy_file): Flag unused parameters.
	* src/server/ram-parse.c (rcsid): Added a missing const.
	(fparse_info_0): Now static.
	(fparse_info_2): Likewise.
	(fparse_conference_2): Likewise.
	(fparse_conference_0): Likewise.
	(fparse_person_0): Likewise.
	(fparse_person_2): Likewise.
	(fparse_text_stat_2): Likewise.
	(fparse_text_stat_0): Likewise.
	(fparse_conf_list): Changed type of local variable "i" from int to
	unsigned long.
	(fparse_text_list): Likewise.
	* src/server/ram-output.c (foutput_text_list): Changed
	type of local variable "i" from int to unsigned long.
	(foutput_time): Renamed a parameter name to avoid
	warnings from gcc.
	(rcsid): Added a missing const.
	* src/server/prot-a-output.c (prot_a_output_conf_list): Changed
	type of local variable "i" from int to unsigned long.
	(prot_a_output_text_list): Likewise.
	(prot_a_output_time): Renamed local variable
	names to avoid warnings from gcc.
	(rcsid): Added a missing const.
	* src/server/local-to-global.c (Local_text_no_iter): New
	experimental typedef.
	(l2g_append): Renamed i to ix and changed type to
	Local_text_no_iter.
	* src/server/dbck-cache.c: Include dbck-cache.h.
	(rcsid): Added a missing const.
	(next_text_num): Changed type from int to Text_no.
	(TEXT_RANGE): Adjusted printf format for next_text_num change.
	(VOID_TEXT_RANGE): Likewise.
	(cache_sync): Changed type of local variable i from int to
	unsigned long.  Removed extern declaration of oformat.
	Adjusted printf formats for next_text_num change.
	(init_cache): Removed extern declaration of oformat.
	Adjusted printf formats for next_text_num change.
	* src/server/conference.c (do_create_conf): Now static.
	(do_lookup): Changed type of local variables i and retsize to
	avoid warnings.  Handle overflow a little better and log warning
	messages if overflow ever occurs.
	(rcsid): Added a missing const.
	* src/libraries/libmisc/s-string.c (s_strcmp): Changed type of
	loop variable from "unsigned int" to "String_size".
	(s_usr_strcmp): Likewise.
	(char2digit): Added const qualifier to translate_table.  Use an
	int as argument to isalpha and tolower to avoid problems with
	signed chars.
	(rcsid): Added a missing const.
	* src/server/conf-file.c (assign_text_no):  Don't use isdigit
	unless isascii is true.  Use an int as argument to isalpha and
	isdigit to avoid problems with signed chars.
	(assign_conf_no): Likewise.
	(assign_int): Likewise.
	(rcsid): Added a missing const.

	Many minor tweaks to remove annoying but harmless warnings from
	gcc.
	* src/server/updateLysKOM.c (checkstatus): Now static.
	* src/server/text.c: Include internal-services.h.
	(rcsid): Added a missing const.
	(set_loc_no): Renamed a parameter name to avoid
	warnings from gcc.
	(find_recipient): Now static.  Removed declaration of errno.
	* src/server/session.c (get_time): Renamed a parameter name to avoid
	warnings from gcc.
	(rcsid): Added a missing const.
	* src/server/server-config.c (log_param): Flag unused argument.
	(param_name): Now static.
	(rcsid): Added a missing const.
	* src/server/rfc931.c: Include rfc931.h.
	(get_real_username): Added a const qualifier to the return value.
	* src/server/rfc931.h (get_real_username): Added a const qualifier
	to the return value.
	* src/server/ramkomd.c (rcsid): Added a missing const.
	(init_data_base): Removed unused argument dir_base.  All callers
	updated.
	(sighandler_hup): Flag unused argument.
	(sighandler_quit): Likewise.
	(sighandler_usr1): Likewise.
	(sighandler_usr2): Likewise.
	(go_daemon): Make it a function prototype.
	(initialize): New static.
	* src/server/mux.c: (rcsid): Added a missing const.
	(UCB_printf): Specify the return type in the extern declaration.
	* src/server/membership.c (do_add_member): Renamed local variable
	names to avoid warnings from gcc.
	(do_sub_member): Likewise.
	(locate_member): Likewise.
	(check_membership): Likewise.
	(set_membership_type): Likewise.
	(rcsid): Added a missing const.
	* src/server/log.c (rcsid): Added a missing const.
	(logv): Renamed local variable names to avoid warnings
	from gcc.
	(log): Likewise.
	* src/server/internal-services.h (do_create_conf): Declaration
	removed.  This function is static.
	* src/server/dbck.c (register_jubel): Flag unused arguments.
	(locate_member): Renamed local variable names to avoid warnings
	from gcc.
	(check_misc_infos): Likewise.
	(check_created_texts): Likewise.
	(check_membership): Likewise.
	(check_texts_in_conf): Likewise.
	(confirm): Added const qualifier to argument question.
	(check_member): Likewise.
	(init_data_base): Removed the unused dbase_dir argument.  All
	callers updated.
	* src/server/dbck-cache.h (oformat): Declaration added.
	* src/server/connections.c (login_request): Added a missing const
	to the realuser local variable.
	(rcsid): Added a missing const.
	* src/server/conf-file.h (struct parameter): Added const qualifier
	to the name and default_val tags.
	* src/server/aux-items.c: Include services.h.
	(aux_item_definition_cache_regexp): Now static.
	(initialize_aux_items): Removed declaration of
	parse_aux_item_definitions.
	(aux_item_call_add_triggers): Now static.
	(aux_item_call_delete_triggers): Now static.
	(aux_item_call_undelete_triggers): Now static.
	* src/server/aux-items.h (Aux_item_definition_s): Added const
	qualifier to the name tag.
	(Aux_item_trigger_mapping): Likewise.
	(parse_aux_item_definitions): Declaration added.
	* src/server/aux-item-def.y: 
	(aux_item_def_typename): Added const qualifier to the return value.
	(aux_item_def_check_assign): Added const qualifier to the id argument.
	(aux_item_def_check_trigger): Added const qualifier to the
	check_name argument.
	* src/server/admin.c (shutdown_kom): Flag unused arguments.
	(rcsid): Added a missing const.
	* src/include/services.h: Renamed a few parameter names to avoid
	warnings from gcc.
	* src/server/prot-a-output.h: Likewise.
	* src/server/ram-output.h: Likewise.
	* src/libraries/libcommon/parser.h: Likewise.
	* src/server/manipulate.h: Likewise.
	* src/libraries/libcommon/kom-errno.c (rcsid): Added a missing const.
	* src/libraries/libcommon/misc-parser.c: Likewise.
	* src/libraries/libcommon/parser.c: Likewise.
	* src/libraries/libmisc/s-collat-tabs.c: Likewise.
	* src/server/cache-node.c: Likewise.
	* src/server/disk-end-of-atomic.c: Likewise.
	* src/server/internal-connections.c: Likewise.
	* src/server/isc-malloc.c: Likewise.
	* src/server/isc-parse.c: Likewise.
	* src/server/memory.c: Likewise.
	* src/server/mux-parse.c: Likewise.
	* src/server/person.c: Likewise.
	* src/server/prot-a-parse.c: Likewise.
	* src/server/prot-a-send-async.c: Likewise.
	* src/server/prot-a.c: Likewise.
	* src/server/ram-smalloc.c: Likewise.
	* src/server/regex-match.c: Likewise.
	* src/server/send-async.c: Likewise.
	* src/server/string-malloc.c: Likewise.
	* src/server/text-garb.c: Likewise.
	* src/libraries/libansi/empty.c: Likewise.
	
	Remove some old unused files.
	* src/libraries/libmisc/zmalloc.c: Unused file removed.
	* src/libraries/libmisc/zmalloc.h: Unused file removed.
	* src/server/kom-types.c: Empty file removed.
	* scripts/Summarize-Headers: File removed.
	* scripts/List-Files: File removed.
	* src/libraries/libclient/.cvsignore: File removed.
	* src/libraries/libclient/Makefile.in: File removed.
	* src/libraries/libclient/async.c: File removed.
	* src/libraries/libclient/async.h: File removed.
	* src/libraries/libclient/client-Makefile.in: File removed.
	* src/libraries/libclient/client-malloc.h: File removed.
	* src/libraries/libclient/client.c: File removed.
	* src/libraries/libclient/client.h: File removed.
	* src/libraries/libclient/input.c: File removed.
	* src/libraries/libclient/input.h: File removed.
	* src/libraries/libclient/kom-types.c: File removed.
	* src/libraries/libclient/output.c: File removed.
	* src/libraries/libclient/output.h: File removed.
	* src/libraries/libclient/parse.c: File removed.
	* src/libraries/libclient/parse.h: File removed.
	* src/libraries/libclient/send.c: File removed.
	* src/libraries/libclient/send.h: File removed.
	* src/libraries/libclient/services.c: File removed.
	* src/libraries/libclient/services.h: File removed.

948
949
950
951
952
953
954
955
956
957
1998-07-07  Per Cederqvist  <ceder@gratia>

	Fixed spelling of the config file parameter "Max broadcast length".
	* src/server/server-config.c (parameters): Fixed mis-spelling of
	"Max broadcast length".
	* doc/man/lyskomd.8: Likewise.

	* doc/Protocol-A.texi: Minor errata.
	* doc/security-levels.txt: Converted from swascii to latin1.

958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
1998-06-10  David Byers  <davby@ida.liu.se>

	* src/server/membership.c (sub_member): Return KOM_NOT_MEMBER for
	secret memberships.

1998-06-08  David Byers  <davby@ida.liu.se>

	* src/server/membership.c (set_membership_type): New function.

	* src/server/prot-a-output.c (prot_a_output_membership): Output
	added_at. 
	(prot_a_output_member): Output added_at

	* src/server/membership.c (do_add_member): Set added_at.
	(get_members): Filter out added_at.

	* src/server/memory.c (init_membership): Init added_at.

	* src/server/ram-output.c (foutput_member_2): Added output of
 	added_at.

	* src/server/ram-parse.c (fparse_member_2): Added parsing of added_at.

	* src/include/kom-types.h: Added added_at to Membership och Member.

	* src/server/ram-parse.c (fparse_membership_2): Added parsning of
 	added_at.

	* src/server/ram-output.c (foutput_membership_2): Added output of
 	added_at.

Fri Jan 16 22:51:52 1998  David Byers  <davby@litefix.ida.liu.se>

	* src/include/kom-types.h (Aux_item_flags): Added dont_garb.

	* src/server/text-garb.c (garb_text): Check dont_garb aux-item
 	flag.

David Byers's avatar
David Byers committed
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
Mon Sep 22 19:06:05 1997  David Byers  <davby@litefix.ida.liu.se>

	* src/server/cache-node.h: New flags: snapshot and synced.

Sun Sep 21 21:16:28 1997  David Byers  <davby@litefix.ida.liu.se>

	* src/server/memory.c (copy_text_stat): Call copy_aux_item_list. 
	(copy_aux_item_list): New function.
	(copy_aux_item): New function.
	(copy_conference): Call copy_aux_item_list.
	(clear_conference): Free the aux_item_list
	(init_conference): Init the aux_item_list.
	(clear_text_stat): Free the aux_item_list.
	(init_text_stat): Init the aux_item_list.
	(init_aux_item_list): New function.

1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
Sat Sep 13 15:07:32 1997  David Byers  <davby@ida.liu.se>

	* run-support/aux-items.conf: New file. This is the aux-item
 	definition file.

	* src/server/aux-items.h: New file. Include this when using
 	aux-items.

	* src/server/aux-items.c: New file. Implements most of the
 	functionality associated with aux-items.

	* src/server/aux-item-def.l: New file. Implements the scanner for
 	the aux-item definition file parser.

	* src/server/aux-item-def.y: New file. Implements the aux-item
 	definition file parser.

	* src/server/text.c: Added support for aux-items. Set err_stat
 	whenever kom_errno is set.
	(create_text_old): Renamed from create_text. Use do_create_text.
	(create_text): New RPC function.
	(create_anonymous_text): New RPC function.
	(create_anonymous_text_old): Renamed from create_anonymous_text. 
	Use do_create_text.
	(do_create_text): New function similar to old create_text, but
 	with aux-item support.
	(count_recipients): Handle bcc-recpt.
	(find_recipient): Handle bcc-recpt.
	(do_add_bcc_recpt): New function to add bcc-recipient.
	(do_delete_misc): Handle bcc_recpt.
	(do_sub_recpt): Handle bcc_recpt.
	(sender): Handle bcc_recpt.
	(is_sender): Handle bcc_recpt.
	(is_comm_sender): Handle bcc_recpt.
	(skip_recp): Handle bcc_recpt.
	(is_member_in_recpt): Handle bcc_recpt.
	(filter_secret_info): Handle bcc_recpt.
	(text_read_access): Handle bcc_recpt.
	(do_delete_text): Handle bcc_recpt.
	(check_double_subm): Handle bcc_recpt.
	(check_double_comm): Handle bcc_recpt.
	(create_text_check_misc): Handle bcc_recpt.
	(create_text_add_miscs): Handle bcc_recpt.
	(add_recipient): Handle bcc_recpt.
	(filter_secret_info): Filter aux-items as well as misc-info.
	(create_text_add_aux): New function.
	(send_async_new_text_old): Renamed from send_async_new_text.
	(send_async_new_text): New function.
	(get_text_stat_old): Renamed from get_text_stat.
	(get_text_stat): New RPC function.
	(modify_text_info): New RPC function.
	(do_delete_text): Send async deleted text.

	* src/server/text-garb.c (garb_text): Handle bcc-recpt.

	* src/server/simple-cache.c: Set err_stat whenever kom_errno is
 	set.
	(cached_lookup_name): Set kom_errno to KOM_INTERNAL_ERROR is
 	parse() fails.
	(pre_sync): Write version 2 data file.
	(cached_delete_conf): Delete conference name from small_conf_arr.
	(pre_sync): Use foutput_info instead of writing it here.
	(init_cache): Return KOM_INTERNAL_ERROR on problems with the
 	files. Prettier handling of datafile versions (switch instead of
 	testing for one single version.) Call set_input_format to set the
 	input format. Use fparse_info to read info instead of parsing it
 	here. If we encounter an unknown key, print its offset.

	* src/server/session.c: Set err_stat whenever kom_errno is set.
	(accept_async): Return KOM_UNKNOWN_ASYNC if an unknown async
 	message is requested.
	(login_old): Test wheel bit (test removed from is_supervisor.)
	(login):  Test wheel bit (test removed from is_supervisor.)
	(disconnect):  Test wheel bit (test removed from is_supervisor.)

	* src/server/server-config.c (parameters): Add max_add_aux and
 	max_delete_aux. 
	(toplevel): Set AUX_DEF_FILE constant.

	* src/server/send-async.h: Declare new functions in send-async.c

	* src/server/send-async.c (async_new_text_old): Renamed from
 	async_new_text.
	(async_new_text): New function to send new new-text async.
	(async_send_group_message): Return KOM_MESSAGE_NOT_SENT on failure
 	because of no accepting recipient. Return KOM_FEATURE_DISABLED if
 	messages are disabled. Return INTERNAL_ERROR on an internal error.
	(async_deleted_text): New function to send new deleted-text async.

	* src/server/regex-match.c (lookup_regexp): Set err_stat when
 	kom_errno is set.

	* src/server/ramkomd.c:
	(initialize): Initialize aux-item definitions.
	(main): Handle -a and -c options, and user-selectable aux-item
 	definition file.

	* src/server/ram-parse.h: Declare new function in ram-parse.c

	* src/server/ram-parse.c: Better support for reading different
 	input formats by using solution similar to that in ram-output.c. 
	New variable input_format controls input format.
	(set_input_format): New function selects input format.
	(fparse_info_0): New function.
	(fparse_info_2): New function.
	(fparse_info): New function.
	(fparse_conference_2): New function.
	(fparse_conference_0): New function.
	(fparse_conference): New function.
	(fparse_person_0): New function.
	(fparse_person_2): New function.
	(fparse_person): New function.
	(fparse_text_stat_2): New function.
	(fparse_text_stat_0): New function.
	(fparse_text_stat): New function.
	(fparse_aux_item_flags): New function to read aux-item flags.
	(fparse_aux_item): New function to read an aux-item.
	(fparse_aux_item_list): New function to read an aux-item-list.
	(fparse_misc_info): Parse bcc-recpt.

	* src/server/ram-output.h: Declare new functions in ram-output.c

	* src/server/ram-output.c: Better support for writing different
 	output formats by using foutput_something_<version> and a switch
 	in foutput_something. New variable output_format selects output
 	format.
	(set_output_format): New function to select output format.
	(foutput_info_0): New function.
	(foutput_info_2): New function.
	(foutput_info): New function.
	(foutput_person_0): New function.
	(foutput_person_2): New function.
	(foutput_person): New function.
	(foutput_conference_2): New function.
	(foutput_conference): New function.
	(foutput_text_stat_0): New function.
	(foutput_text_stat_2): New function.
	(foutput_text_stat): New function.
	(foutput_aux_flags): New function to output aux-item flags.
	(foutput_aux_item): New function to output aux-items.
	(foutput_aux_item_list): New function to output aux-item-lists.
	(foutput_misc_info): Output bcc-recpt.

	* src/server/prot-a.c (prot_a_reply): Added support for new and
 	renamed return types: rt_conference, rt_conference_old,
 	rt_text_stat, rt_text_stat_old, rt_info, rt_info_old.
	(prot_a_init): Initialize aux_item_list of Connection.
	(prot_a_destruct): Clear the aux_item_list in Connection.
	(prot_a_is_legal_fnc): Add support for new and changed RPC calls
 	(see entry for fncdef.txt.)

	* src/server/prot-a-send-async.h: Declare new functions in
 	prot-a-send-async.c

	* src/server/prot-a-send-async.c (prot_a_async_new_text_old):
 	Renamed from prot_a_async_new_text.
	(prot_a_async_new_text): New async message function.
	(prot_a_async_deleted_text): New async message function.

	* src/server/prot-a-parse.h: Declare new functions in
 	prot-a-parse.c

	* src/server/prot-a-parse.c (prot_a_parse_aux_item_flags): New
 	function.
	(prot_a_parse_aux_item): New function.
	(prot_a_parse_aux_item_list): New function.
	(prot_a_parse_misc_info): Parse bcc_recpt info type.

	* src/server/prot-a-output.h: Declare new functions in
 	prot-a-output.c

	* src/server/prot-a-output.c (prot_a_output_conference): New
 	output function.
	(prot_a_output_conference_old): Renamed from old
 	prot_a_output_conference.
	(prot_a_output_aux_item_flags): New function.
	(prot_a_output_aux_item): New function.
	(prot_a_output_text_stat_old): Renamed from
 	prot_a_output_text_stat.
	(prot_a_output_aux_item_list): New function.
	(prot_a_output_text_stat): New function.
	(prot_a_output_info): New function.
	(prot_a_output_info_old): Renamed from prot_a_output_info.
	(prot_a_output_misc_info): Output bcc_recpt misc type.

	* src/server/person.c: Added support for aux-items. Set err_stat
 	whenever kom_errno is set.
	(create_person_generic): Moved all generic create_person code to
 	this function.
	(create_person_old): Renamed from create_person, use
 	create_person_generic.
	(create_person): New RPC function.
	(set_passwd): Test wheel bit when doing is_supervisor (test
 	removed from is_supervisor.)

	* src/server/param.h: Added max_delete_aux, max_add_aux to struct
 	kom_par.

	* src/server/memory.c (free_aux_item_list): New function to free
 	all data in an Aux_item_list.

	* src/server/membership.c: Set err_stat whenever kom_errno is set. 
	(access_perm): Test wheel bit (test removed from is_supervisor.)
	(add_member): Test wheel bit (test removed from is_supervisor.)

	* src/server/manipulate.h: Set err_stat whenever kom_errno is set. 
	Declare is_strictly_supervisor.

	* src/server/kom-memory.h: Declare free_aux_item_list.

	* src/server/internal-connections.c (init_connection): Clear
 	aux_item and aux_item_list fields of Connection. Clear
 	aux_item_list field of Info.

	* src/server/fncdef.txt: Added comments to separate protocol
 	versions. New calls: get_collate_table, create_text,
 	create_anonymous_text, create_conf, create_person, get_text_stat,
 	get_conf_stat, modify_text_info, modify_conf_info, get_info,
 	modify_server_info, query_predefined_aux_items, set_expire. 
	Renamed calls: get_text_stat to get_text_stat_old,
 	get_conf_stat_old to get_conf_stat_older, get_conf_stat to
 	get_conf_stat_old, get_info to get_info_old, create_conf to
 	create_conf_old, create_pers to create_pers_old, create_text to
 	create_text_old, create_anonymous_text to
 	create_anonymous_text_old.

	* src/server/dbck.c (check_misc_infos): Handle m_bcc_recpt.
	(is_recipient): Handle bcc_recpt.
	(main): Use set_output_format to select the output format.

	* src/server/dbck-cache.c: Set err_stat whenever kom_errno is set.
	(cache_sync): Use foutput_info instead of outputting the info
 	here.
	(cache_sync): Call foutput_conference, not foutput_conference_old. 
	ram-output now takes care of selecting the correct version to
 	write.
	(init_cache): Use fparse_info instead of reading the info here. 

	* src/server/connections.h: (Connection): Add aux_item_list and
 	aux_item.
	(Res_type): Renamed return types: rt_conference to
 	rt_conference_old. rt_text_stat to rt_text_stat_old, rt_info to
 	rt_info_old. Addet rt_conference, rt_text_stat and rt_info.
	(Result_holder): Added conference_old, text_stat_old and info_old.

	* src/server/connections.c: Include kom-memory.h. Set err_stat
 	whenever kom_errno is set.
	(free_parsed): Free data in aux_item and aux_item_list.

	* src/server/conference.c: Added support for aux-items. Set
 	err_stat whenever kom_errno is set.
	(is_strictly_supervisor): New function.
	(is_supervisor): Use is_strictly_supervisor. Don't test the wheel
 	bit of ACTPERS.
	(create_conf_generic): Moved generic create_conf code here.
	(create_conf_old): Renamed from create_conf. Use
 	create_conf_generic.
	(create_conf): New RPC function.
	(get_conf_stat): New RPC function.
	(get_conf_stat_old): Renamed from get_conf_stat
	(modify_conf_info): New RPC function.
	(set_expire): New RPC function.

	* src/server/call-switch.awk: Parse aux_item_list. 

	* src/server/async.h: Added ay_new_text, ay_deleted_text. Renamed
 	old ay_new_text to ay_new_text_old.

	* src/server/admin.c (modify_server_info): New RPC function.
	(toplevel): Update initializer for kom_info. 
	(all): Set err_stat whenever kom_errno is set.
	(get_info): New function. Old get_info is not get_info_old.
	(get_collate_table): New RPC function.


	* src/server/Makefile.src: Added the new files to source lists. 
	Rules to build aux-item-parser and scanner added.

	* src/libraries/libcommon/misc-parser.h: Added m_bcc_recpt to
 	Misc_struct_type. Added bcc_recipient to Misc_info_group struct.

	* src/include/services.h: Declared all new RPC functions and
 	renamed the now obsolete ones. New functions are: create_person,
 	create_conf, create_text, get_conf_stat, get_text_stat,
 	create_anonymous_text, modify_conf_info, modify_text_info,
 	get_info, modify_server_info, get_collate_table, set_expire,
 	query_predefined_aux_items

	* src/include/kom-errno.h (KOM_err): Added KOM_ILL_AUX,
 	KOM_AUX_PERM, KOM_UNKNOWN_ASYNC, KOM_INTERNAL_ERROR,
 	KOM_FEATURE_DISABLED, KOM_MESSAGE_NOT_SENT.

	* src/include/config.h: Added AUX_DEF_FILE.

	* run-support/Makefile.src: Install aux-items.conf.

	* doc/man/lyskomd.8: Documented aux-item related settings.

	* doc/lyskomd-database-format: Documented data file version 2.

	* doc/Protocol-A.texi: Completed all calls, asynch messages, data
 	structures, error codes. Documented protocol version 10.

	* db-crypt/db/lyskomd-data: Updated to data file version 2.

	* configure.in: Check for bison and flex (can't use the regular
 	YACC and LEX tests since we need bison and flex specifically.)

	* INSTALL: Mention that bison and flex may be needed for
 	installation.

1323
1324
1325
1326
1327
Wed Jul 23 22:40:08 1997  Per Cederqvist  <ceder@gratia>

	* src/server/conference.c (get_uconf_stat): Added a comment about
	a bug that needs to be fixed.

1328
1329
1330
1331
1332
1333
1334
Sun Jul 20 16:04:23 1997  Per Cederqvist  <ceder@lysator.liu.se>

	The regexp code could use the wrong collate table.
	* src/server/regex-match.c (lookup_regexp): Use
	DEFAULT_COLLAT_TAB, not swedish_collate_tab.  (Reported by David
	Byers).

Per Cederqvist's avatar
Per Cederqvist committed
1335
1336
1337
1338
1339
1340
1341
1342
Fri Jun  6 23:16:28 1997  Per Cederqvist  <ceder@lysator.liu.se>

	Port to AIX.
	* src/server/local-to-global.c: Include stdlib.h instead of the
	non-standard malloc.h.
	* configure.in: Create src/server/Makefile before
 	src/server/testsuite/Makefile.

1343
1344
1345
1346
1347
1348
1349
1350
1351
Sun Dec 29 15:55:44 1996  Per Cederqvist  <ceder@lysator.liu.se>

	* doc/prot-A.txt: 59=create-anonymous-text, 78=get-uconf-stat,
	58=get-last-text and 77=set-last-read are recommended, not
	experimental.  Fixed bug in declaration of
	Dynamic-Session-Info-List.

	* src/server/Makefile.in (GENOBJS): Added local-to-global.o.

inge's avatar
inge committed
1352
1353
1354
1355
1356
1357
1358
Thu Sep 12 19:14:39 1996  Inge Wallin  <inge@lysator.liu.se>

	* local-to-global.h: Added code for an iterator.
	* local-to-global.c: Added code for an iterator.

	* kom-types.h: Include some files which are used here.

inge's avatar
inge committed
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
Sun Sep  1 21:32:22 1996  Inge Wallin  <inge@lysator.liu.se>

	* (l2g_delete): Delete the block if empty.
	* local-to-global.c (delete_block): New function

	* local-to-global.c (l2g_destruct): Don't free blocks.
	* (l2g_clear): Only free if non-NULL.
	* (l2g_copy): more efficient code.

	* local-to-global.h, local-to-global.c (l2g_print): Renamed to
	l2g_write.	
	* (l2g_read, l2g_write): Now implemented.
	
	* log.h: Include stdarg.h if possible.

Per Cederqvist's avatar
Per Cederqvist committed
1374
1375
1376
1377
Sun Aug 25 14:47:16 1996  Per Cederqvist  <ceder@lysator.liu.se>

	* src/server/Makefile.src (GENOBJS): Added local-to-global.o.
	* src/server/local-to-global.c: New file, written by Inge Wallin.
1378

1379
	Disconnect spamming clients:
1380
1381
1382
1383
	* src/server/prot-a-parse.c (prot_a_get_token): Disconnect the
 	client if it attempts to send a token (other than a string) that
 	is longer than 1000 characters.

1384
	Delete obsolete code:
1385
1386
1387
1388
1389
	* src/libraries/libcommon/kom-errno.c (kom_perror): Removed
	KOM_NO_CONNECT.
	* src/include/kom-errno.h (Kom_err): Removed the unused value
	KOM_NO_CONNECT.

1390
	Purify support:
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
	* scripts/mkmi.m4 (PURIFY): New make variable.
	* configure.in: New argument --with-purify enables debugging with
	Purify.
	* src/server/Makefile.src (lyskomd): Added $(PURIFY) in front of
	the link line.
	(updateLysKOM): Likewise.
	(dbck): Likewise.

	* src/server/local-to-global.c: Include <sys/types.h>, <time.h>
	and "s-string.h".
 	(l2g_next_key): Don't dereference memory past the last block!

1403
	Test suite integration:
1404
1405
	* configure.in: Generate src/server/testsuite/Makefile.  Touch
 	src/server/testsuite/dependencies.
Per Cederqvist's avatar
Per Cederqvist committed
1406
1407
	* src/server/testsuite/Makefile.src: New file.
	* mkmi: Added src/server/testsuite/Makefile.
1408
	* src/server/testsuite/l2g.0/00.exp: New file.
Per Cederqvist's avatar
Per Cederqvist committed
1409
1410
1411
	* src/server/testsuite/l2g.0/01.exp: New file, containing real
	data from the map of conference 603 (LysKOM; Elispklientens
	buggrapporter) in LysLysKOM.
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
	* src/server/testsuite/config/unix.exp: New file.
	* src/server/testsuite/test-l2g.c: New file.

	* For older changes, see ChangeLog.1, src/include/ChangeLog.1,
 	src/server/ChangeLog.1, src/libraries/libcommon/ChangeLog.1, and
 	src/libraries/libmisc/ChangeLog.1.  Starting today, all changes in
 	those directories should be documented in this file.

	Not that local changes to foreign libraries that are included in
 	this distribution should still be documented in a ChangeLog in
 	their directory, so that somebody who looks at them can see what
 	we have modified.  As of this writing, the following ChangeLog
 	files fall into this category: src/libraries/gnumalloc/ChangeLog,
 	src/libraries/libisc-new/src/ChangeLog,
 	src/libraries/regex/ChangeLog and
 	src/libraries/regex/test/ChangeLog.