ChangeLog 357 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
2002-11-15  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor doc fixes.
	* doc/Protocol-A.texi (mark-as-read): Added markup.
	(set-unread): Ditto.
	(get-membership): This was introduced in protocol version 11, not
	10.

	Added new requests 109=mark-as-unread and 110=set-read-ranges.
	* doc/Protocol-A.texi (mark-as-unread): New request.
	(set-read-ranges): New request.
	(Error Codes): Added invalid-range and invalid-range-list.
	* src/include/services.h (mark_as_unread): New request.
	(set_read_ranges): New request.
	* src/server/fncdef.txt: Added mark_as_unread and
	set_read_ranges.
	* src/server/membership.c (remove_loc_no): New static function.
	(read_ranges_precondition): New static function.
	(read_ranges_postcondition): New static function.
	(mark_as_read): Extracted debug code to read_ranges_precondition
	and read_ranges_postcondition.
	(mark_as_unread): New function.
	(check_range_list): New static function.
	(set_read_ranges): New function.
	* src/server/testsuite/lyskomd.0/01.exp: Test 109=mark-as-unread
	and 110=set-read-ranges.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.

	Added parsing of "ARRAY Read-Range", aka read_range_list, needed
	by request 110=set-read-ranges.
31 32
	* doc/lyskomd.texi (Parameters): Document "Max read_ranges per
	call".
33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51
	* src/server/param.h (struct kom_par): Added max_read_ranges.
	* src/server/server-config.c (parameters): Added "Max read_ranges
	per call".
	* src/server/prot-a.c (prot_a_destruct): Free read_range_list.
	* src/server/prot-a-parse.h (prot_a_parse_read_range_list): New
	function.
	* src/server/prot-a-parse.c (prot_a_parse_read_range): New static
	function.
	(prot_a_parse_read_range_list): New function.
	* src/server/prot-a-parse-arg-c.awk: Handle read_range_list.
	* src/server/internal-connections.c (init_connection): Initialize
	read_range_list.
	* src/server/connections.h (Connection): Added read_range_list.
	* src/server/connections.c (free_parsed): Free read_range_list.
	* src/server/call-switch.awk: Handle read_range_list.
	* src/include/kom-types.h (struct read_range_list): New struct.
	* src/include/kom-errno.h (enum kom_err): Added KOM_INVALID_RANGE
	and KOM_INVALID_RANGE_LIST.

52 53
2002-11-14  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
54 55 56
	Release administrativa.
	* HACKING: Publish the NEWS file on the web when doing a release.

57 58 59 60 61 62 63 64
	Test 107=query-read-texts and 108=get-membership even 
	more.  (Bug 590).
	* src/server/testsuite/lyskomd.0/bug-37.exp: Test
	107=query-read-texts and 108=get-membership.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145
2002-11-13  Per Cederqvist  <ceder@ceder.dyndns.org>

	Release administrativa.
	* HACKING: Make sure no closed bugs are left on the TODO list.

	Test 107=query-read-texts and 108=get-membership.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Fixed a couple of
	errors in the range-based test cases.
	(checkit): Test 107=query-read-texts and 108=get-membership.
	(checktrunc): New proc.  Use it a few times to check that the new
	requests can truncate the ranges of read texts.
	* src/server/testsuite/lyskomd.0/03.exp: Be prepared that
	query-read-texts-old now adjusts the read ranges.  Test
	107=query-read-texts and 108=get-membership.  Renumber.
	* src/server/testsuite/lyskomd.0/01.exp: Test 107=query-read-texts
	and 108=get-membership.  Renumber.

	Implement 107=query-read-texts and 108=get-membership.
	* src/server/prot-a.c (prot_a_reply): Handle rt_membership and
	rt_membership_list.
	* src/server/prot-a-output.h, src/server/prot-a-output.c 
	(prot_a_output_membership): New function.
	(prot_a_output_membership_list): New function.
	* src/server/person.c (do_query_read_texts): New arguments:
	want_read_ranges and max_ranges.  All callers updated.  Call
	adjust_read() if want_read_ranges is true.
	(query_read_texts): New function.
	* src/server/membership.c (copy_public_confs): New arguments:
	keep_read and max_ranges.  All callers updated.
	(adjust_read): Now has external linkage.  Changed return type from
	void to Bool; return true if the membership was modified.
	(do_get_membership): New arguments: keep_ranges and max_ranges.
	Renamed the want_read_texts argument to want_read_ranges.  All
	callers updated.
	(get_membership): New function.
	* src/server/manipulate.h (adjust_read): Now has external
	linkage.
	* src/server/fncdef.txt: Added query_read_texts and
	get_membership.
	* src/server/connections.h (Connection): Added num4.
	(enum res_type): Added rt_membership and rt_membership_list.
	(union result_holder): Added membership and membership_list.
	* src/include/services.h (get_membership): New function.
	(query_read_texts): New function.

	Documented new range-based requests get-membership and
	query-read-texts.  Renamed the old versions by adding a "-10"
	suffix.
	* doc/constructs.expected: Removed references to bug 52.
	* doc/Protocol-A.texi (Membership and Reading): Talk about
	read-ranges, not last-text-read and read-texts.
	(Person Status Types): Mention read-ranges.
	(Membership Information): Mention that obsolete versions of
	Membership exists.
	(Membership Information): Renamed Membership to Membership-10, and
	added new Membership and Read-Range types.
	(Protocol Requests): Flag 98=query-read-texts-10 and
	99=get-membership-10 as obsolete.  Added 107=query-read-texts and
	108=get-membership.
	(sub-member): Changed get-membership to get-membership-old, since
	that is was the example uses.  Added markup.
	(mark-as-read): Changed query-read-texts to query-read-texts-old,
	since that is what the example uses.  Added markup.
	(set-unread): Ditto.
	(set-last-read): Ditto.
	(query-read-texts-10): New name for former request
	query-read-texts.  Mark it as obsolete and refer to the new
	query-read-texts request.  Changed return type to Membership-10.
	(get-membership-10): New name for former request
	get-membership.  Mark it as obsolete and refer to the new
	get-membership request.  Changed return type to ARRAY
	Membership-10.
	(query-read-texts): New request.
	(get-membership): New request.
	(Membership visibility): Added get-membership-10 and
	query-read-texts-10.
	(What do I have unread): Added markup.
	(Future changes): Removed references to bug 52.
	(Document Edition History): Tracked the renaming of
	query-read-texts-10 and get-membership-10.

146 147
2002-11-12  Per Cederqvist  <ceder@ceder.dyndns.org>

148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196
	Added a "_10" suffix to type Membership and all derived types and
	functions, in preparation of writing range-based replacements.
	* src/server/fncdef.txt: Renamed functions:
	    query_read_texts -> query_read_texts_10
	    get_membership   -> get_membership_10
	Renamed types:
	    membership       -> membership_10
	    membership_list  -> membership_list_10
	* src/include/services.h: Renamed functions:
	    query_read_texts -> query_read_texts_10
	    get_membership   -> get_membership_10
	* src/server/connections.h (enum res_type): Renamed:
	    rt_membership      -> rt_membership_10
	    rt_membership_list -> rt_membership_list_10
	(union result_holder): Renamed:
	    membership      -> membership_10
	    membership_list -> membership_list_10
	* src/server/prot-a.c (prot_a_reply): Use membership_old instead
	of membership where appropriate.  Track rename of *membership* to
	*membership*_10.
	* src/server/person.c (query_read_texts_10): Renamed from
	query_read_texts.
	* src/server/membership.c (get_membership_10): Renamed from
	get_membership.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
	(prot_a_output_membership_10): Renamed from
	prot_a_output_membership.
	(prot_a_output_membership_list_10): Renamed from
	prot_a_output_membership_list.

	Allow types in Protocol A to end in a number suffix.
	* doc/checkargs.py (lexer.__bad_type): Allow types that ends in a
	number, such as "Membership-10".

	Testsuite: work on even slower computers.
	* src/server/testsuite/config/unix.exp (timeout): Increase the
	timeout even further.

	Log message fixed.
	* src/server/ram-parse.c (fparse_read_range_0): Fixed wrong
	function name in a log message.

	Ignore gcov-generated files in libeintr.
	* src/libraries/libeintr/.cvsignore: Ignore *.bb, *.bbg and
	*.da.

	Doc typo fixed.
	* doc/lyskomd.texi (Modifying Output Types): Typo fixed.

197 198 199 200 201 202 203 204 205 206 207 208
	Fixed all known bugs in the range-based read-texts implementation.
	* src/server/ram-parse.c (fparse_read_range_0): Don't forget the
	first interval that is created based on last-text-read.
	* src/server/membership.c (adjust_read): Aim at setting first_read
	of the first range to 1, even if that is lower than the first
	currently existing text in the conference.  Make the code that
	tries to extend ranges towards higher numbers more efficient -- no
	loop is needed, since l2g_next_key can be used.  Removed some dead
	code.
	* src/server/testsuite/lyskomd.0/bug-52.exp (start): Use serial
	number 999 instead of 1000 to ease debugging.

209 210 211 212 213 214
2002-11-11  Per Cederqvist  <ceder@ceder.dyndns.org>

	Finish the test-suite for range-based representation.  This
	reveals at least two errors in the implementation.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Renumber and extend.
	(do_restart): Set to 1.
215
	(check_unread_confs): New proc.  Use it several times.
216

217 218 219 220 221 222 223 224 225 226 227 228 229 230
2002-11-10  Kent Engstrm  <kent@lysator.liu.se>

        Add support for the mx-refuse-import aux item.
	* run-support/aux-items.conf: Add mx-refuse-import [35].
	* doc/Protocol-A.texi (Aux-Item Types): Ditto.
	* doc/constructs.expected: Add @code{all}, @code{spam}.
	* src/server/testsuite/lyskomd.0/01.exp: Fix to accept the
	added aux item.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	* src/server/testsuite/lyskomd.0/18.exp: Ditto.

	Add information about dependence on texinfo version.
	* HACKING: Add entry about texinfo.

231 232 233 234
2002-11-10  Per Cederqvist  <ceder@lysator.liu.se>

	Make do_get_members() look nicer.
	* src/server/membership.c (do_get_members): Minor code cleanup and
235 236
	indentation fixes.  Use init_member() to set all fields, and then
	explicitly set (only) the secret bit.
237

238 239
2002-11-09  Per Cederqvist  <ceder@ceder.dyndns.org>

240 241 242 243 244 245 246 247 248 249
	Even more tests for the range-based representation.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Expand the test suite
	and prepare it for range-based information commands.
	(lazy_expand): New variable.
	(mark_as_read_atomic): New variable.
	(do_restart): New variable.  This is currently set to 0 to hide
	known errors...
	(restart): New proc.
	(checkit): New argument: ranges.

250 251 252
	Added more tests of the range-based representation for read
	texts.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
253
	bug-52.data, bug-52.texts and bug-52.exp.
254 255 256 257 258 259
	* src/server/testsuite/lyskomd.0/bug-52.exp: New file.
	* src/server/testsuite/lyskomd.0/bug-52.data: New file.
	* src/server/testsuite/lyskomd.0/bug-52.texts: New file.
	* src/server/testsuite/config/unix.exp (unpack_db): New proc.
	(lyskomd_start): New args: confs, texts and nogarb.

260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
2002-11-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Use a range-based representation in core for the texts a user has
	read.  The external representation is not yet affected.  (Bug 52).
	* src/include/kom-types.h (struct read_range): New struct.
	(Membership): Removed fields last_text_read, no_of_read and
	read_texts.  Added fields no_of_read_ranges, read_ranges and
	skip_read_texts.
	* src/server/ram-parse.c (fparse_read_range_0): New static
	function that handles the new range-based representation of
	memberships.
	(fparse_membership_2): Use it.
	(fparse_membership_0): Use it.
	(fparse_membership_list_0): Handle the new range-based
	representation of memberships.
	(fparse_membership_list_2): Ditto.
	* src/server/ram-output.c (foutput_read_ranges_0): New static
	function that handles the new range-based representation of
	memberships.
	(foutput_membership_0): Use it.
	(foutput_membership_2): Use it.
	* src/server/prot-a-output.c (prot_a_output_read_texts): New
	static function that handles the new range-based representation of
	memberships.
	(prot_a_output_membership_old): Use it.
	* src/server/person.c (do_query_read_texts): Handle new
	range-based representation of memberships.
	* src/server/memory.c (clear_membership): Handle new
	range-based representation of memberships.
	(copy_membership): Ditto.
	(init_membership): Ditto.
	* src/server/membership.c (copy_public_confs): Handle new
	range-based representation of memberships.
	(adjust_read): Ditto.
	(insert_loc_no): Ditto.
	(do_add_member): Ditto.
	(do_sub_member): Ditto.
	(check_membership): Ditto.
	(mark_as_read): Ditto.
	(do_get_membership): Ditto.
	(get_unread_confs): Ditto.
	(set_unread): Ditto.
	(set_last_read): Ditto.
	(last_text_read): New static inline function.
	* src/server/dbck.c (check_membership): Handle range-based
	representation of memberships.

	Xenofarm warnings.
	* scripts/xenofarm.sh: Ignore warnings about reduced hard ulimit.

310 311
2002-11-05  Per Cederqvist  <ceder@ceder.dyndns.org>

312 313 314 315
	Spell-check Protocol-A.texi.
	* HACKING: Spell-check Protocol-A.texi when a release is made.
	* doc/Protocol-A.texi: A few spelling errors fixed.

316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
	Testsuite: timeout handling was broken.
	* src/server/testsuite/config/unix.exp (fix_expect_after): Don't
	unconditionally add a timeout pattern.  Contrary to my belief, a
	timeout pattern seems to refer to a specific spawn id.  If we add
	it here when there are no spawned processes, the timeout will
	refer to stdin, and this will cause expect to detect eof on stdin
	when run from Xenofarm.  Instead, everything that spawns a process
	must add timeout patterns to the expect_active variable.
	(l2g_start): Add a timeout pattern to expect_active.
	(lyskomd_start): Ditto.
	(lyskomd_start_fail): Ditto.
	(client_start): Ditto.
	(client_start_fail): Ditto.

	Test suite fixes.
Per Cederqvist's avatar
Per Cederqvist committed
331 332
	* src/server/testsuite/config/unix.exp (dbck_run): Added missing
	"global spawn_id".
333 334
	* src/server/testsuite/lyskomd.0/12.exp: After dbck_run has
	finished, we must re-specify which client we want to talk to.
Per Cederqvist's avatar
Per Cederqvist committed
335

336 337 338 339 340 341 342 343
	The test suite didn't stop listening to lyskomd when it died.
	* src/server/testsuite/config/unix.exp (lyskomd_death): Don't
	listen to the lyskomd spawn id once it has died.
	(kill_lyskomd): Ditto.
	* src/server/testsuite/lyskomd.0/11.exp: Match all output.
	Somehow this test didn't fail even though there were unmatched
	output from lyskomd.  Strange.

344
	Never reuse text or conference numbers.  (Bug 810).
345 346
	* doc/lyskomd.texi (Parameters): New parameters: "Number file:"
	and "Number temp file:".
347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377
	* src/server/param.h (struct kom_par): Added numberfile_name and
	numberfile_tmp_name.
	* src/server/server-config.c (parameters): Added "Number file" and
	"Number temp file".
	(read_configuration): Handle them.
	* src/server/simple-cache.c (highest_conf_no): Explicitly
	initialize to 0.
	(highest_text_no): Ditto.
	(write_number_file): New static function.
	(read_number_file): Ditto.
	(cached_create_conf): Call write_number_file, and return
	KOM_TEMPFAIL if it fails.
	(cached_create_text): Ditto.
	(init_cache): Don't set highest_conf_no and highest_text_no.  They
	are only used during the save phase.  Call read_number_file.
	* db-crypt/db/number.txt: New file.
	* db-crypt/db/Makefile.am (EXTRA_DIST): Added number.txt.
	(install-data-local): Install number.txt.
	(uninstall-local): Remove number.txt.  Don't remove anything if
	number.txt is altered.
	* src/server/testsuite/config/unix.exp (lyskomd_start): New
	optional arguments: log_messages, init_db and want_stale.  Copy
	number.txt.  Don't copy the database if init_db is 0.  Expect a
	log message about a removal of a stale lock file if want_stale is
	1.  Expect log_messages after the startup messages but before the
	garb messages.
	(lyskomd_fail_start): Copy number.txt.
	* src/server/testsuite/lyskomd.0/bug-810.exp: Expect messages
	about lost texts and conferences in the log.  Don't expect any
	failures.

378 379 380 381 382 383 384 385 386 387 388
2002-11-04  Per Cederqvist  <ceder@ceder.dyndns.org>

	Write test case for bug 810: retain text, person and conference
	numbers after a crash.
	* src/server/testsuite/config/unix.exp (kill_lyskomd): New proc.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	bug-810.exp.
	* src/server/testsuite/lyskomd.0/bug-810.exp: Test that text,
	person and conference number are never reused, not even when the
	server crashes.

389 390 391 392 393 394 395 396 397
2002-11-04  Per Cederqvist  <ceder@ingate.com>

	Xenofarm: ignore warnings from assignment of SIG_IGN.
	* scripts/xenofarm.sh: Updated list of warnings to ignore.
	* src/server/ramkomd.c (set_handler_sig_ign): New function.
	(server_init): Use it.
	(go_daemon): Use it.  This reduces the number of warnings on some
	platforms.

398 399
2002-11-04  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
400 401 402 403
	Fixed a grammar error.
	* doc/Protocol-A.texi (Document Edition History): Fixed grammar
	error.  Reported by Hans Persson.

404 405 406 407 408 409 410 411
	Fixed typo.
	* src/server/ram-smalloc.c: Fixed a typo in a comment.

	Release administrativa that missed the deadline.
	* README: Recommend the "-C" option of "./configure".
	* HACKING: Updated with stuff found while performing the 2.0.7
	release.

412 413 414 415
2002-11-03  Per Cederqvist  <ceder@lysator.liu.se>

	* Release 2.0.7.

416 417
2002-11-02  Per Cederqvist  <ceder@ceder.dyndns.org>

418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437
	Disable the extended tests for the release.
	* src/server/testsuite/lyskomd.0/gen-19.py (EXTENDED): Reset to 0.
	* src/server/testsuite/lyskomd.0/gen-15.py (EXTENDED): Reset to 0.

	Not all makes sets RM, so do it manually in all Makefile.am.
	* src/libraries/libeintr/Makefile.am (RM): Set it.
	* run-support/Makefile.am (RM): Set it.
	* db-crypt/db/Makefile.am (RM): Set it.

	A few files lacked a copyright header.
	* src/server/testsuite/lyskomd.0/summarize.sh: Added copyright
	header.
	* src/server/testsuite/bignum.c: Added copyright header.
	* src/libraries/libeintr/gen-wrapper.awk: Added copyright header.
	* src/libraries/libeintr/eintr.h.pre: Added copyright header.
	
	Update the copyright updater.
	* scripts/lyskomd-copyrights: Ignore generated files in libeintr
	and the testsuite.

438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453
	Run extended tests on the Xenofarm.
	* src/server/testsuite/lyskomd.0/gen-19.py (EXTENDED): Set to 1.
	* src/server/testsuite/lyskomd.0/gen-15.py (EXTENDED): Set to 1.

	Fix the distribution.
	* src/libraries/libeintr/Makefile.am (nodist_libeintr_a_SOURCES):
	Added the nodist_ prefix, to avoid distributing these generated
	files.
	(MOSTLYCLEANFILES): Added the generated files.

	Release administrativa.
	* scripts/lyskomd-copyrights: Updated the copyright statement.
	* README: Updated version numbers for TCL and expect.  Updated
	copyright statement.
	* NEWS: Updated.
	* HACKING: We actually use Python 2.1 for the release generation,
454
	not 2.2.1.  Extract the release from the Xenofarm build package.
455 456 457 458 459 460 461 462 463 464 465
	* doc/Protocol-A.texi (Document Edition History): Updated with all
	made changes.

	Fixed a few minor problems with Protocol-A.texi.
	* doc/Protocol-A.texi(Some Client-specific Aux-Item Types): New
	name for the appendix formerly known as "Client-specific Aux-Item
	Types".  Another node of that name already exists!
	(LysKOM Content Types): Fixed a typo.
	(Membership visibility): Fixed typos.
	(Order of misc-info groups): Fixed a typo.

466 467 468 469 470 471
2002-11-01  Per Cederqvist  <ceder@ceder.dyndns.org>

	The timeout of the test suite was too low.
	* src/server/testsuite/config/unix.exp (timeout): Increase the
	timeout further.  Hal apparently needs it.

472 473
2002-10-31  Per Cederqvist  <ceder@ceder.dyndns.org>

474 475 476 477
	NFS-mounted databases may fail.  Warn the administrator.
	* README: Added a warning that NFS-mounted databases may fail due
	to EINTR.

478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521
	Added a library of wrapper functions that checks for EINTR.
	* configure.in: Generate src/libraries/libeintr/Makefile.
	* src/libraries/Makefile.am (SUBDIRS): Added libeintr.
	* src/libraries/libeintr/gen-wrapper.awk: New file.  Generate
	simple wrappers that check for EINTR.
	* src/libraries/libeintr/funcs.txt: New file.  Use wrappers for
	fopen, fclose and rename.
	* src/libraries/libeintr/eintr.h.pre: New file.
	* src/libraries/libeintr/Makefile.am: New file.

	Use the libeintr wrappers instead of fopen, fclose and rename.
	* src/server/Makefile.am (AM_CPPFLAGS): Added libeintr.
	(lyskomd_LDADD): Ditto.
	(dbck_LDADD): Ditto.
	(LDADD): Ditto.
	* src/server/updateLysKOM.c (main): Use i_fopen instead of fopen.
	Don't forget to close the status file.
	* src/server/splitkomdb.c (copy_file, copy_db_file): Use i_fopen
	and i_fclose instead of fopen and fclose.
	* src/server/simple-cache.c (is_clean, get_version, post_sync)
	(save_one_text, sync_part, init_cache, free_all_cache): Use
	i_fopen and i_fclose instead of fopen and fclose.
	(pre_sync): Ditto, and i_rename instead of rename.
	* src/server/ramkomd.c (save_pid, dump_exit_statistics): Use
	i_fopen and i_fclose instead of fopen and fclose.
	* src/server/ram-smalloc.c (trace_alloc_file): Use f_fopen
	intstead of fopen.
	* src/server/pidfile.c (read_pid_file): Use i_fopen and i_fclose
	instead of fopen and fclose.
	* src/server/komrunning.c (create_status): Use i_fopen and
	i_fclose instead of fopen and fclose.
	* src/server/dbck.c (garb_text_file): Use i_rename instead of
	rename.  Check the return value.
	* src/server/dbck-cache.c (get_version, is_clean, cache_sync_all) 
	(cache_open_new_text_file, init_cache): Use i_fopen, i_fclose and
	i_rename instead of fopen, fclose and rename.
	* src/server/connections.c (dump_statistics): Use i_fopen and
	i_fclose instead of fopen and fclose.
	(dump_connections): Ditto, and i_rename instead of rename.
	* src/server/conf-file.c (read_config): Use i_fopen and i_fclose
	instead of fopen and fclose.
	* src/server/aux-item-def-parse.y (parse_aux_item_definitions):
	Use i_fopen and i_fclose instead of fopen and fclose.

Per Cederqvist's avatar
Per Cederqvist committed
522 523
2002-10-28  Per Cederqvist  <ceder@ingate.com>

524 525 526 527 528
	Check if rename really sets errno to EINTR.
	* src/server/connections.c (dump_connections): Set errno to 0
	before the rename that strangely returns with EINTR during the
	Xenofarm tests.

Per Cederqvist's avatar
Per Cederqvist committed
529 530
	* NEWS: Updated.

531 532
2002-10-28  Per Cederqvist  <ceder@ceder.dyndns.org>

533 534 535 536 537
	Make dump_connections more robust.
	* src/server/connections.c (dump_connections): Call fflush() and
	ferror().  This might help track down spurious errors from the
	rename that I don't understand.

538 539 540 541 542 543
	Release administrativa.
	* HACKING: Mention "make distcheck".

	Test suite cleanup.
	* scripts/xenofarm.sh: Removed the "eintr" task.

544 545 546 547 548 549 550 551 552 553 554
2002-10-28  Per Cederqvist  <ceder@lysator.liu.se>

	Port to AIX 4.2: limit the number of open file descriptors
	properly.
	* src/server/connections.c (toploop) [!USING_RLIMIT_NOFILE]: Fixed
	a off-by-one error.

	Fixed compile error on systems lacking SA_RESTART.
	* src/server/ramkomd.c (setup_sighandlers): Added a missing
	semicolon.

Per Cederqvist's avatar
Per Cederqvist committed
555 556
2002-10-27  Per Cederqvist  <ceder@ceder.dyndns.org>

557 558 559 560 561 562 563 564 565 566 567 568 569 570
	Testsuite fixes.  Don't use __FILE__ in log messages, as it isn't
	very useful, and makes the test suite more complex.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: Don't expect
	the "connections.c" file name in the log message, as that broke
	when doing an srcdir build.
	* src/server/text.c (is_member_in_recpt): Don't use __FILE__.
	(do_sub_recpt): Ditto.
	(check_double_subm): Ditto.
	(check_double_comm): Ditto.  Fix the function name in a log
	message.
	* src/server/memory.c (clear_text_stat): Don't use __FILE__.  Fix
	the function name in a log message.
	* src/server/connections.c (dump_statistics): Don't use __FILE__.

571 572 573 574 575 576
	Don't require bison/yacc when compiling.  (Bug 843).
	* src/server/Makefile.am: The explicit dependencies added
	2002-10-21 to fix "make clean; make check" was broken: the ".c"
	extension was used instead of ".o" in several cases.  This
	resulted in bison being run on the client.

Per Cederqvist's avatar
Per Cederqvist committed
577 578 579 580 581
	Consider FD_SETSIZE.
	* src/server/ramkomd.c (initialize): Don't allow the number of
	open files to be larger than FD_SETSIZE.
	* src/server/testsuite/testfd.c (find_limits): Report FD_SETSIZE.

Per Cederqvist's avatar
Per Cederqvist committed
582 583 584 585 586 587 588 589 590 591 592
2002-10-27  Per Cederqvist  <ceder@lysator.liu.se>

	Testsuite fixes.
	* src/server/testsuite/lyskomd.0/11.exp: Fixed a race condition in
	the test.
	* src/server/testsuite/config/unix.exp (obtain_lock): Search for
	locksuite.py in $srcdir.
	(lyskomd_start): Removed unused global declaration of srcdir.
	(lyskomd_fail_start): Ditto.
	(client_death): Ditto.

593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621
2002-10-27  Per Cederqvist  <ceder@ceder.dyndns.org>

	Port to AIX 4.2: limit the number of open file descriptors in a
	more portable way.
	* src/include/kom-config.h (PROTECTED_FDS): Added parenthesis
	around the number.
	(MAX_NO_OF_CONNECTIONS): Removed.
	(USING_RLIMIT_NOFILE): Define if we have a good setrlimit.
	(fd_ceiling): New variable.
	* src/server/server-config.c (MAX_NO_OF_CONNECTIONS): Removed.
	(fd_ceiling): New variable.
	* src/server/connections.c (toploop): Transform ISC_EVENT_LOGIN to
	ISC_EVENT_LOGIN_UNRELOCATED if the file descriptor is above
	fd_ceiling.  This can only happen if USING_RLIMIT_NOFILE is
	undefined, so ifdef out this code.
	* src/server/ramkomd.c (go_daemon): Close everything below
	fd_ceiling instead of using MAX_NO_OF_CONNECTIONS + PROTECTED_FDS.
	(initialize): Use getrlimit/setrlimit if USING_RLIMIT_NOFILE is
	defined.  Check that getrlimit after setrlimit returns a sane
	value.  Don't use sysconf(_SC_OPEN_MAX), since getrlimit provides
	a better value.  Set fd_ceiling instead of MAX_NO_OF_CONNECTIONS.
	Make it possible to lower the ceiling even when we don't have a
	working setrlimit.  Removed the final sanity checks; the world
	ain't sane.
	* src/server/testsuite/testfd.c (main): Adjusted logic for error
	checks to be similar to the code now used.  In particular, don't
	test sysconf(_SC_OPEN_MAX), and don't test getrlimit if
	HAVE_BROKEN_NOFILE.

622 623 624 625 626 627 628
2002-10-26  Per Cederqvist  <ceder@lysator.liu.se>

	Prepare for more portable handling of the number of file
	descriptors used.
	* configure.in: Define HAVE_BROKEN_NOFILE if
	setrlimit(RLIMIT_NOFILE) fails.

629 630
2002-10-26  Per Cederqvist  <ceder@ceder.dyndns.org>

631 632 633 634 635 636 637 638
	Update the testsuite so that it doesn't fail because of
	SA_RESTART/select() on HP-UX.
	* src/server/testsuite/Makefile.am (check-test-select): Pass
	--no-sa-restart to test-select, so that we test the code the way
	we actually use it.
	* src/server/testsuite/test-select.c (main): New argument:
	--no-sa-restart.  Don't use SA_RESTART if given.

639 640 641 642 643 644 645 646 647 648 649 650
	Port to HP-UX: Use SA_RESTART except while calling select().
	* src/server/sigflags.h (restart_syscalls_on_intr): New function.
	(intr_syscalls_on_intr): New function.
	* src/server/ramkomd.c (setup_sighandlers): New function.  Use
	SA_RESTART if the "restartable" argument is true.
	(restart_syscalls_on_intr): New function.
	(intr_syscalls_on_intr): New function.
	(main): Move signal handler setup to setup_sighandlers().
	* src/server/connections.c (toploop): Call intr_syscalls_on_intr()
	before calling isc_getnextevent, and restart_syscalls_on_intr()
	immediately after its return.

651 652 653 654 655 656 657 658
2002-10-26  Per Cederqvist  <ceder@lysator.liu.se>

	Port to SunOS 4.1.1_U1 that lacks SA_RESTART.
	* src/server/testsuite/test-select.c (main): Call link_ansi().
	Only set SA_RESTART if it is available.
	* src/server/testsuite/Makefile.am (test_select_LDADD): New
	variable.

659 660
2002-10-26  Per Cederqvist  <ceder@ceder.dyndns.org>

661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676
	Use SA_RESTART.
	* src/server/ramkomd.c (main): Use SA_RESTART, even though it
	potentially will cause lyskomd to block in select() instead of
	responding promptly to signals.

	Check that SA_RESTART can interrupt select().
	* src/server/testsuite/test-select.c: Test if select() can be
	interrupted by a signal even when SA_RESTART is specified.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
	test-select.
	(test_select_SOURCES): New variable.
	(check): Added check-test-select.
	(check-test-select): New target.
	* scripts/xenofarm.sh: Added eintr test, to check the
	select/SA_RESTART in a separate task.

677 678 679 680 681 682 683 684 685 686
	Fixed a race condition in the test suite.
	* src/server/testsuite/tcpconnect.py: Flush stdout more often.
	Give feedback on "#supsend socket" and "#resume socket" to avoid a
	race condition.
	* src/server/testsuite/config/unix.exp (kill_client): Include the
	client number in the test name when testing for stray output.
	This makes it easier to see which client that misbehaves.
	(suspend_client): Expect a response from the client.
	(resume_client): Ditto.

687 688
2002-10-25  Per Cederqvist  <ceder@ceder.dyndns.org>

689 690 691 692 693 694 695 696 697 698 699 700 701 702
	The test suite now test for buffer overflow in the proper way.
	(Bug 844).
	* src/server/testsuite/config/unix.exp (l2g_start): Test for
	"full_buffer".  An old expect document has fooled us to test for
	"buffer_full" instead; that doesn't work.
	(simple_expect): Ditto.
	(good_bad_expect): Ditto.
	(extracting_expect): Ditto.
	(unanchored_expect): Ditto.
	(lyskomd_start): Ditto.
	(lyskomd_fail_start): Ditto.
	(client_start): Ditto.
	(client_start_fail): Ditto.

703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721
	The test suite failed when configured with --with-debug-calls.
	* src/server/testsuite/config/unix.exp (lyskomd_fail_start):
	Handle --with-debug-calls compilations.
	* src/server/testsuite/lyskomd.0/09.exp: Handle --with-debug-calls
	compilations.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Ditto.

	Improve a few log messages.
	* src/server/person.c (do_set_user_area): Improve the "Old
	user_area X unmarked" message.
	* src/server/conference.c (do_set_presentation): Improve the "Old
	presentation not marked" message.
	(do_set_etc_motd): Improve the "New motd has X marks" and "Old
	motd not marked" messages.
	* src/server/admin.c (set_motd_of_lyskom): The "Old motd not
	marked" message used the wrong function name.

722 723 724 725 726
	Log the reason why the connection status file cannot be renamed.
	(Bug 841).
	* src/server/connections.c (dump_connections): Emit
	strerror(errno) when file operations fails.

727 728
2002-10-23  Per Cederqvist  <ceder@ceder.dyndns.org>

729 730 731 732 733 734 735 736 737 738 739 740
	Plugged a memory leak.  (Bug 816).
	* src/server/prot-a.c (prot_a_destruct): Clear dummy_aux_item, to
	plug a memory leak.  To trigger this leak, you had to send an
	oversized aux-item-list, that contained an oversized string in the
	last part of the oversized array, and disconnect while sending the
	last part of the string.

	Test client disconnect more thoroughly.  (Bug 63).
	* src/server/testsuite/lyskomd.0/29.exp: Several more test cases
	added.  We now trigger bug 816.
	(startup): Reduce "Max aux_item length" and "Max links per text".

Per Cederqvist's avatar
Per Cederqvist committed
741 742 743 744 745 746 747
	Test suite fixes.
	* src/server/testsuite/lyskomd.0/03.exp: Wait for a third tick.
	This test failed on computers that were too fast, due to the
	script waiting too short a time.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Added a
	missing dot that caused --with-debug-calls tests to fail.

748 749 750 751 752 753
	Clients should offer to add the letterbox of the author if he
	isn't a member of any of the recipients.
	* doc/Protocol-A.texi (Recipients of comments): Added a
	description of what to do when the author of a new comment isn't a
	member of any of the recipients.

754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830
	Added option "-f" (stay in foreground) to lyskomd.  "-d" no longer
	implies "stay in foreground".
	* src/server/ramkomd.c (foreground): New static variable.
	(go_daemon): Stay in foreground if given -f, not -d.
	(initialize): Prompt the operator for confirmation when given -f,
	not -d.
	(main): Ditto.  Handle -f: stay in foreground.
	* doc/lyskomd.texi (Invoking lyskomd): Documented the new -f
	option.

	Let the test suite check all output from lyskomd.
	* src/server/testsuite/config/unix.exp (maxint): Unused constant
	removed.
	(lyskomd_expect): New proc.
	(spawn_lyskomd): Use -f, not -d.
	(lyskomd_start): Check all output from lyskomd.
	(lyskomd_fail_start): Ditto.
	(lyskomd_death): New argument: reason. Check all output from
	lyskomd.
	(talk_to): Set current_talk_what and current_talk_nr, so that
	lyskomd_expect can restore the old settings.  Set proper
	line_leader for lyskomd.
	* src/server/testsuite/lyskomd.0/03.exp: Check all output from
	lyskomd.
	* src/server/testsuite/lyskomd.0/05.exp: Ditto.
	* src/server/testsuite/lyskomd.0/06.exp: Ditto.
	* src/server/testsuite/lyskomd.0/24.exp: Ditto.
	* src/server/testsuite/lyskomd.0/25.exp: Ditto.
	* src/server/testsuite/lyskomd.0/27.exp: Ditto.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-349.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-612.exp: Ditto.
	* src/server/testsuite/lyskomd.0/conf-file-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/gen-15.py: Ditto.
	* src/server/testsuite/lyskomd.0/gen-19.py: Ditto.
	* src/server/testsuite/lyskomd.0/membership-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/session-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/text-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/11.exp: Use the -f argument of
	lyskomd, not -d.  Pass the reason argument to lyskomd_death.
	* src/server/testsuite/lyskomd.0/07.exp: Pass the reason argument
	to lyskomd_death.

	Test suite cleanup.
	* src/server/testsuite/lyskomd.0/29.exp: Removed spurious newline
	from the log file.

	Fixed a race condition in the test suite.  (Bug 692).
	* src/server/testsuite/lyskomd.0/18.exp: Check all output from
	lyskomd.  Closes bug 692.
	* src/server/ramkomd.c (sighandler_winch): Moved log message to
	toploop().
	* src/server/connections.c (toploop): Log a message when SIGWINCH
	has been processed and the aux definitions reloaded.

	Fixed a false log message about a memory leak. (Half of Bug 816).
	* src/server/prot-a.c (prot_a_destruct): Set c_local_text_no_p to
	NULL after freeing it, to avoid logging "kill_client(): unexpected
	local_text_no remains." when a client disconnects while sending a
	c_local_text_no_p array.

	Clean up the output from lyskomd.
	* src/server/conf-file.c (configure_line): Don't add blank lines
	to the log.
	* src/server/aux-items.c (aux_item_validate): Added a trailing dot
	to a log message.
	* src/server/aux-item-def-parse.y: Fixed typo in a log message.

831 832
2002-10-21  Per Cederqvist  <ceder@ceder.dyndns.org>

833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850
	Don't crash if a client sends the length of an aux-item list and
	disconnects before sending the "{".  Fixed similar code for other
	arrays.
	* src/server/prot-a-parse.c (prot_a_parse_num_list): Don't set
	res->length until res->data is allocated.
	(prot_a_parse_misc_info_list): Ditto.
	(prot_a_parse_aux_item_list): Ditto.  Without this fix, a client
	can cause a crash by sending the length of the list, and
	disconnect before sending the "{".
	(prot_a_parse_string): Add an additional comment explaining why a
	client_len field should be added (bug 162).

	Fix testsuite.
	* src/server/testsuite/lyskomd.0/29.exp: Expect bug 836:
	mark-text-as-read gives a protocol error response instead of the
	error code long-array when an overly long array is sent to the
	server.

851 852 853 854 855 856 857 858 859 860 861 862 863 864
	"make clean; make check" failed.
	* src/server/Makefile.am: Added explicit dependencies so that
	"make clean; make check" no longer fails.

	Added missing semicolon i bison file.
	* src/server/aux-item-def-parse.y (action): Inserted a missing
	semicolon.

	Fixed a testsuite bug.
	* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Use
	client_death instead of kill_client after receiving the "%% No
	connections left" message.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.

865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
2002-10-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Test client disconnect while while the client has sent partial
	requests.
	* src/server/testsuite/lyskomd.0/29.exp: New file: test for client
	disconnect.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	29.exp.

	Testsuite: check for unexpected data sent to clients immediately
	before they are killed.
	* src/server/testsuite/config/unix.exp (kill_client): Look for
	stray output before killing the client.
 
	Testsuite framework: make it possible to send incomplete lines to
	the server.
	* src/server/testsuite/tcpconnect.py: Added support for sending
	incomplete lines to the server via the "#nocr" instruction.

Per Cederqvist's avatar
Per Cederqvist committed
884 885 886 887 888 889
2002-10-18  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor doc improvement.
	* doc/Protocol-A.texi (Auxiliary Information): Added a reference
	to Aux-Item Types.

890 891 892 893 894 895 896
2002-10-17  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fixed a broken lookup-z-name example.
	* doc/Protocol-A.texi (lookup-z-name): "T C" doesn't match "Trains
	(-) Discussion", so remove it from the result.  Reported by Hans
	Persson.

Per Cederqvist's avatar
Per Cederqvist committed
897 898 899 900 901 902
2002-10-16  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fixed a typo.
	* doc/Protocol-A.texi (Membership Information): Fixed typo:
	"added-by", not "added-byp".

903 904 905 906 907 908
2002-10-15  Per Cederqvist  <ceder@ceder.dyndns.org>

	Better logging of leaks during client disconnect.
	* src/server/internal-connections.c (kill_client): Log left-overs
	from misc_info_list and local_text_no separately.

Per Cederqvist's avatar
Per Cederqvist committed
909 910 911 912 913 914 915 916
2002-10-14  Per Cederqvist  <ceder@ceder.dyndns.org>

	Port testfd.c to SunOS 5.4.
	* src/server/testsuite/testfd.c (find_limits): The code failed to
	compile unless HAVE_GETDTABLESIZE.  Flush stdout before writing
	something to stderr.
	(main): Flush stdout before writing something to stderr.

917 918 919 920 921 922 923
2002-10-13  Per Cederqvist  <ceder@ceder.dyndns.org>

	Gather more info about file descriptor usage.
	* src/server/testsuite/testfd.c: Lower the limit using setrlimit
	and test the limits afterwards as well.  Report an error if the
	assumptions made by lyskomd do not hold.

924 925
2002-10-12  Per Cederqvist  <ceder@ceder.dyndns.org>

926 927 928 929 930 931 932 933 934 935
	File descriptor counting on AIX is apparently wrong.  Collect some
	information from the farm.
	* scripts/xenofarm.sh: Run check-testfd as a separate task, so
	that the info can be easily collected.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added testfd.
	(testfd_SOURCES): New variable.
	(check): Added check-testfd.
	(check-testfd): New target.
	* src/server/testsuite/testfd.c: New test program.

936 937 938 939 940 941 942 943
	Handle a failure mode that seems to occur.
	* src/server/testsuite/lyskomd.0/11.exp: Handle one case of early
	lyskomd death.

	Improve testsuite lock handling.
	* src/server/testsuite/locksuite.py (try_symlink): Break stale
	lock files.

944 945 946 947 948 949 950
2002-10-11  Per Cederqvist  <ceder@ceder.dyndns.org>

	Removed obsolete Xenofarm compatibility cruft.
	* scripts/xenofarm.sh: Removed old Xenofarm compatibility stuff,
	including the --compat argument and the ability to give the
	compiler to use as an argument.  Added the --make argument.

951 952 953 954 955 956 957 958 959 960 961 962 963 964
2002-10-09  Per Cederqvist  <ceder@ceder.dyndns.org>

	Use AM_CPPFLAGS instead of the obsolete variable INCLUDES.
	* src/server/testsuite/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.
	* src/server/Makefile.am: (AM_CPPFLAGS): New name for former
	INCLUDES.
	* src/libraries/libmisc/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.
	* src/libraries/libcommon/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.
	* src/libraries/libansi/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.

965 966 967 968 969 970 971
2002-10-07  Per Cederqvist  <ceder@ceder.dyndns.org>

	Xenofarm builds could get stuck forever on a stale lock file.
	* src/server/testsuite/config/unix.exp (obtain_lock): This failed
	to break stale locks if the host name contained for instance a
	dot.  So this failed if a FQDN name is used.

Per Cederqvist's avatar
Per Cederqvist committed
972 973 974 975 976 977
2002-10-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix the doc fix.
	* doc/lyskomd.texi (Template for ram-parse.c): Break a too long
	line.

Per Cederqvist's avatar
Per Cederqvist committed
978 979 980 981 982 983 984
2002-10-06  Daniel Andersson <daniel@ds.hj.se>

        Doc fix. (Bug 814).
	* doc/lyskomd.texi (Template for ram-output.c): Corrections to
	function names etc.
	(Template for ram-parse.c): Ditto.

985 986
2002-10-06  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
987 988 989 990 991
	Xenofarm cleanup.
	* scripts/xenofarm.sh: Removed special cases for aristocat,
	moghedien and lysator.  Path setup et c is better handled in the
	configuration files of the corresponding computer.

992 993 994 995 996 997
	Fix configure tests for <sys/resource.h> and rlim_t.
	* configure.in: When checking for rlim_t in <sys/resource.h>, and
	when checking for <sys/resource.h> itself, include <time.h> and
	<sys/time.h> in the proper way.  Both these tests were made too
	early.

998 999
2002-10-05  Per Cederqvist  <ceder@ceder.dyndns.org>

1000 1001 1002 1003 1004
	Update Xenofarm configuration of asmodean and moghedien.
	* scripts/xenofarm.sh: asmodean is no longer used by Xenofarm.
	moghedien needs runtest, but not a special makeinfo.  Also, 
	"uname -n" doesn't return a FQDN there.

1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015
	Send a broadcast message when the server fails to save the
	database.  (Bug 813).
	* src/server/simple-cache.c (sync_part): Send a broadcast message
	to everyone if the save failed.  Patch from Daniel Andersson,
	slightly edited.

	Get rid of some compiler warnings about conversions between char
	and unsigned char.
	* src/include/kom-config.h, src/server/server-config.c
	(WHITESPACE): Changed type from const unsigned char* to const
	char* to remove some compiler warnings.
1016 1017 1018 1019 1020 1021 1022 1023
	* src/libraries/libmisc/s-string.h,
	src/libraries/libmisc/s-string.c (s_usr_strcmp): Changed type of
	collat_tab argument from char to unsigned char.
	(s_usr_strhead): Ditto.
	* src/libraries/libcommon/parser.h,
	src/libraries/libcommon/parser.c (match): Changed type of
	collat_tab argument from char to unsigned char.
	(parse): Ditto.
1024 1025 1026 1027 1028 1029 1030 1031 1032 1033
	* src/server/regex-match.c (lookup_regexp): Cast the "pattern"
	argument of re_compile_pattern to char* to get rid of a warning.
	(lookup_regexp): Cast the "string" argument of re_search to char*
	to get rid of a warning.
	* src/server/aux-items.c (aux_item_definition_cache_regexp):
	Don't set the translate field of the pattern buffer to
	DEFAULT_COLLAT_TAB.  That causes a warning.  The field is anyhow
	set to NULL on the next line, as it should be.
	(aux_item_validate): Cast the "string" argument of re_search to
	char* to get rid of a warning.
1034

1035 1036
2002-10-04  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1037 1038 1039 1040 1041 1042
	Xenofarm refinements.
	* scripts/xenofarm.sh: Remove makewarn.txt and ckprgwarn.txt if
	they are empty.  Create ckprgfail.txt and cause the ckprg steg to
	fail if the string "error" is found in the output (case
	insensitive).

1043 1044 1045 1046 1047
	Change s_free() to s_clear() in comments in s-string.h.
	* src/libraries/libmisc/s-string.h: Two comments mentioned
	s_free(), but the actual name of the function is s_clear().  
	Fixed the comments.

1048 1049
2002-10-02  Per Cederqvist  <ceder@ingate.com>

1050 1051 1052 1053
	Watch for runtest problems.
	* scripts/xenofarm.sh: Added "error" to the list of strings that
	should cause ckprg to flag a warning.

1054 1055 1056 1057 1058 1059
	Remove warnings about unused libraries from the test suite.
	* src/server/testsuite/test-l2g.c (main): Call link_ansi().
	* src/server/testsuite/Makefile.am (test_l2g_LDADD): Removed
	$(LDADD).  Added libmisc.a, liblyskom-server.a and libansi.a.
	(LDADD): Removed.  The bignum program doesn't need any of this,
	and test-l2g only needs parts of it.
1060
	(INCLUDES): Added libansi.
1061

1062 1063
2002-10-02  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1064 1065 1066 1067 1068 1069
	Port to the ecc compiler.
	* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Improve the test, by
	checking that __attribute__((unused)) is accepted in a function
	declaration.  The ecc compiler on Linux/ia64 seems to accept it
	and give a warning when used on a local variable, but chokes on
	it when used in a function declaration.
Per Cederqvist's avatar
Per Cederqvist committed
1070 1071
	* scripts/xenofarm.sh: Ignore a warning created by
	__attribute__((format)) when compiling with ecc.
Per Cederqvist's avatar
Per Cederqvist committed
1072

1073 1074 1075 1076
	Get more info from Xenofarm builds.
	* scripts/xenofarm.sh: Retrieve config.log and
	src/libraries/libisc-new/config.log.

Per Cederqvist's avatar
Per Cederqvist committed
1077 1078 1079 1080 1081
2002-10-01  Per Cederqvist  <ceder@ceder.dyndns.org>

	Doc fix.
	* doc/man/dbck.8: Refer to lyskomd.info, not dbck.info.

Per Cederqvist's avatar
Per Cederqvist committed
1082 1083 1084 1085 1086
2002-09-28  Per Cederqvist  <ceder@ceder.dyndns.org>

	Xenofarm warning handling.
	* scripts/xenofarm.sh: Fixed a warning regexp.

1087 1088 1089 1090 1091 1092 1093 1094 1095
2002-09-19  Per Cederqvist  <ceder@ceder.dyndns.org>

	Get rid of a warning.  Xenofarm warning handling.
	* src/server/conference.c (do_lookup): Introduce a new variable
	letterflag to get rid of a compiler warning from gcc-2.7.2.2 on
	AIX.
	* scripts/xenofarm.sh: Check for warnings during configure and
	ckprg.  Ignore a few more warnings during make.

1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
2002-09-10  Per Cederqvist  <ceder@ceder.dyndns.org>

	Remove warnings about unused libraries.
	* src/server/updateLysKOM.c (main): Call link_ansi().
	* src/server/splitkomdb.c (main): Call link_ansi().
	* src/server/ramkomd.c (main): Call link_ansi().
	* src/server/komrunning.c (main): Call link_ansi().
	* src/server/dbck.c (main): Call link_ansi().
	* src/server/Makefile.am (INCLUDES): Added libansi.
	(lyskomd_LDADD): New variable.
	(dbck_LDADD): New variable.
	(LDADD): Removed several libraries that the other programs don't
	use.
	* src/libraries/libansi/empty.c (link_ansi): New function.
	(neveruse): Removed.
	* src/libraries/libansi/Makefile.am (libansi_a_SOURCES): Added
	linkansi.h.
	* src/libraries/libansi/linkansi.h: New file.
	(link_ansi): New function.

	Ignore a warning from <vnode.h>.
	* scripts/xenofarm.sh: Ignore a harmless warning from
	/usr/include/sys/vnode.h.

1120 1121
2002-09-09  Per Cederqvist  <ceder@ingate.com>

1122 1123 1124 1125
	Port to SunOS 4.1.1_U1 which lacks rlim_t.
	* configure.in: Check for rlim_t.
	* src/server/ramkomd.c [!HAVE_RLIM_T]: typedef rlim_t to int.

1126 1127 1128 1129
	No wonder locksuite.py failed: it wasn't distributed!
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
	locksuite.py.  Sorted the lines.

1130 1131 1132 1133
	Xenofarm went amok on some computers, where locksuite.py fails.
	* src/server/testsuite/config/unix.exp (obtain_lock): Don't loop
	forever if we get an unexpected eof from locksuite.py.

1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147
2002-09-09  Per Cederqvist  <ceder@ceder.dyndns.org>

	Lock the test suite so that only one run at a time is performed.
	* src/server/testsuite/config/unix.exp (lock_count): New variable.
	(obtain_lock): New proc.
	(release_lock): New proc.
	(l2g_start): Get the lock.
	(l2g_stop): Release it.
	(lyskomd_start): Get the lock.
	(lyskomd_fail_start): Get and release the lock.
	(lyskomd_death): Release it.
	(client_start_fail): Get and release the lock
	* src/server/testsuite/lyskomd.0/11.exp: Release the lock.

Per Cederqvist's avatar
Per Cederqvist committed
1148 1149
2002-09-08  Per Cederqvist  <ceder@ceder.dyndns.org>

1150 1151 1152 1153 1154 1155
	Prepare for locking the test suite.
	* src/server/testsuite/config/unix.exp (clientport): Comment updated.
	* src/server/testsuite/locksuite.py: New file.  This is a basic
	building block for preventing simultaneous test runs on the same
	computer or in the same directory.

1156 1157 1158 1159 1160 1161
	Get rid of some compiler warnings.
	* src/include/kom-types.h (Info): Change highest_aux_no from long
	to unsigned long, since that is what aux_item_list_add_items()
	wants it to be.
	* configure.in: Check for crypt only if crypt isn't found in libc.

Per Cederqvist's avatar
Per Cederqvist committed
1162 1163
	More Xenofarm improvements.
	* scripts/xenofarm.sh: Include config.h in the result package.
1164 1165
	Ignore warnings about duplicate volatile.  These are due to AIX
	apparently including volatile in sig_atomic_t.
Per Cederqvist's avatar
Per Cederqvist committed
1166

1167 1168
2002-09-07  Per Cederqvist  <ceder@ceder.dyndns.org>

1169 1170 1171 1172
	Better support for building multiple configurations under Xenofarm.
	* scripts/xenofarm.sh: Implement --cfg option.  Removed special
	setup for moria.

1173 1174 1175
	Tweak types and add a few casts to get rid of several gcc warnings.
	* src/server/splitkomdb.c (copy_file): Changed type of sz from int
	to size_t to get rid of compiler warnings.
1176 1177
	* src/server/simple-cache.c (init_cache): Replaced "i" with "ic"
	and "it" to get rid of warnings when the wrong type was used.
1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194
	* src/server/ramkomd.c (initialize): Added casts to remove warnings.
	* src/server/ram-parse.c (fparse_aux_item_link): Added cast to
	remove warning.
	* src/server/prot-a.c (prot_a_parse_packet): Added cast to remove
	warning.
	* src/server/local-to-global.h (l2g_set_block_size): Comment
	updated.
	* src/server/local-to-global.c (l2g_append): Added cast to remove
	warning.
	(l2g_expensive_set): Ditto.
	(l2g_expensive_set): Ditto.
	* src/server/dbck.c (motd_of_lyskom): Now a Text_no, not int.
	(main): Use atol, not atoi, when setting motd_of_lyskom.
	* src/server/dbck-cache.c (next_free_num): Change type to
	Conf_no.  Added static qualifier.
	(cache_sync_all): Replaced the local variable "i" with "ic" and
	"it", for loops over conferences and texts.
1195
	(init_cache): Changed type of "i" to unsigned long.  Changed type of
1196 1197 1198 1199 1200 1201 1202 1203 1204
	motd_of_lyskom to Text_no.
	* src/server/connections.h, src/server/connections.c
	(num_fnc_defs): Change type to int.

	Make Xenofarm ignore a few warnings in code that we didn't write.
	* scripts/xenofarm.sh: Ignore warnings from aux-item-def-scan.c
	about defined stuff that isn't used.  This is an auto-generated
	file, and we can't help that it includes a few unused labels and
	functions.  Ignore warning from getopt about a function
1205 1206
	declaration that isn't a prototype.  Ignore cast warnings in
	<bits/socket.h>.
1207

Per Cederqvist's avatar
Per Cederqvist committed
1208 1209 1210 1211 1212 1213
2002-09-04  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix bugs in last commit.
	* scripts/xenofarm.sh: More portable handling of "(W)".  
	Process all options, not just the first.

Per Cederqvist's avatar
Per Cederqvist committed
1214 1215 1216 1217 1218 1219
2002-09-03  Per Cederqvist  <ceder@ceder.dyndns.org>

	Xenofarm improves.  Adapt.
	* scripts/xenofarm.sh: Handle the --compat option.  Handle
	compilers that flag warnings with the string "(W)".

1220 1221 1222 1223 1224
2002-08-25  Per Cederqvist  <ceder@ceder.dyndns.org>

	Create Xenofarm warning indications.
	* scripts/xenofarm.sh: Check for warnings during the build.

Per Cederqvist's avatar
Per Cederqvist committed
1225 1226 1227 1228
2002-08-24  Per Cederqvist  <ceder@ceder.dyndns.org>

	* NEWS: Updated.

Per Cederqvist's avatar
Per Cederqvist committed
1229 1230
2002-08-23  Per Cederqvist  <ceder@ceder.dyndns.org>

1231 1232 1233 1234
	Remove false xenofarm failures.
	* scripts/xenofarm.sh: Run without optimization and with an old
	version of gcc, to make valgrind more happy.

Per Cederqvist's avatar
Per Cederqvist committed
1235 1236 1237 1238
	Port to Solaris 2.4.
	* src/server/connections.c (login_request): Don't use snprintf.
	It's not portable.

1239
2002-08-22  Per Cederqvist  <ceder@ceder.dyndns.org>
1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252

	Compile with more than one compiler on Xenofarm.
	* scripts/xenofarm.sh: Take an optional argument: the name of the
	compiler to use.  Include it in machineid.txt, and pass it to the
	configure script.

	Solaris 2.4 porting.
	* src/libraries/libmisc/s-collat-tabs.c,
	src/libraries/libmisc/s-collat-tabs.h:
	(swedish_collate_tab, english_collate_tab): Use unsigned char, not
	signed char, to get rid of a warning from SparcWorks 5.1 under
	Solaris 2.4.

1253 1254 1255 1256 1257 1258 1259 1260
	The info about elisp-client-specific aux-items is informative
	only.  (Bug 726).
	* doc/Protocol-A.texi (Aux-Item Types): Moved
	elisp-client-read-faq [10000] and
	elisp-client-rejected-recommendation [10001] to an appendix.
	(Client-specific Aux-Item Types): New appendix.
	(Document Edition History): Fixed broken @xref usage.
	* doc/Makefile.am (check-doc): Handle the "Client-specific
1261
	Aux-Item Types" appendix.
1262

Per Cederqvist's avatar
Per Cederqvist committed
1263 1264 1265 1266 1267 1268 1269 1270
2002-08-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Release administrativa.
	* doc/Protocol-A.texi (Order of misc-info groups): Fix typo.
	(Document Edition History): Updated edition 10.7 according to the
	NEWS file from 2002-08-17.
	* NEWS: "common block", not "common area".

1271 1272
2002-08-20  Per Cederqvist  <ceder@ingate.com>

1273 1274 1275 1276 1277 1278 1279 1280 1281
	Document how lines in a text are separated.  Document the order of
	misc-info groups.
	* doc/Protocol-A.texi (create-text): Say "Misc-Info items", not
	"misc-items".
	(LysKOM Content Types): There should be no linefeed after the last
	line.
	(Reformattable Text (text/x-kom-basic)): Ditto.
	(Order of misc-info groups): New node.

1282 1283 1284
	The test suite failed on certain slow machines.
	* src/server/testsuite/config/unix.exp: Increase the timeout.

1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305
2002-08-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Code cleanup.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Removed an
	unused global declaration.

	The test suite failed on 64-bit platforms.
	* src/server/testsuite/bignum.c: New program.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added bignum.
	(bignum_SOURCES): New variable.
	(check-lyskomd): Depend on bignum.
	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Use bignum
	to find a suitable big number.

	Don't include <sys/time.h> when it isn't available.
	* src/server/connections.c: Fix include guards for <time.h> and
	<sys/time.h>.
	* src/server/ramkomd.c: Ditto.

	Xenofarm tweaks.
	* scripts/xenofarm.sh: Store error message from "import socket" in
Per Cederqvist's avatar
Per Cederqvist committed
1306 1307
	the proper log file.  Run valgrind on moria.

1308

1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
2002-08-19  Per Cederqvist  <ceder@ceder.dyndns.org>

	Increase test suite portability.
	* src/server/testsuite/lyskomd.0/18.exp (copy_aux): Don't use
	"file copy", since that isn't portable to old TCL versions.

	Fixed test suite typos.
	* src/server/testsuite/config/unix.exp (l2g_start): Fixed typo:
	";wait" should not be part of the fail string.
	(lyskomd_fail_start): Ditto.
	(client_start): Ditto.
	(client_start_fail): Ditto.

	Xenofarm refinements.
	* scripts/xenofarm.sh: Don't bother running the tests of python
	cannot import socket.

1326 1327
2002-08-18  Per Cederqvist  <ceder@ceder.dyndns.org>

1328 1329 1330 1331 1332 1333 1334
	Increase test suite portability.
	* src/server/testsuite/lyskomd.0/18.exp (copy_aux): Don't use
	"file delete", since that isn't portable to old TCL versions.

	Make the Xenofarm result pages more readable.
	* scripts/xenofarm.sh: Shorten the header names.

1335 1336 1337
	Break out "dvi" and "pdf" from Xenofarm task "checkdoc".
	* scripts/xenofarm.sh: Make check-doc, pdf and dvi separately,
	instead of using the "make check" target of the doc subdirectory.
1338
	Don't attempt to "make pdf" unless we find pdftex.
1339 1340
	Don't attempt to "make dvi" unless we find texi2dvi and tex.
	
Per Cederqvist's avatar
Per Cederqvist committed
1341 1342
2002-08-17  Per Cederqvist  <ceder@ceder.dyndns.org>

1343 1344 1345 1346 1347 1348 1349 1350 1351
	Don't require "grep -f" and "tac" to check the documentation.
	* doc/filterlines.py: New file, that we can use instead of the
	non-portable "grep -v -f ...".
	* doc/tac.py: New file, that replaces the "tac" program.
	* doc/Makefile.am (check-doc): Use filterlines.py instead of "grep
	-v -f ...".  Adjust the contents of several temporary files
	accordingly: they now contains lines to ignore, not regexp
	patterns to ignore.  Use tac.py instead of tac; not everybody has
	GNU textutils installed.
1352
	(EXTRA_DIST): Added filterlines.py and tac.py.
1353 1354 1355
	* scripts/xenofarm.sh (checkdocok): "grep -f" and tac are no
	longer required to "make check" in the doc subdirectory.

Per Cederqvist's avatar
Per Cederqvist committed
1356 1357 1358 1359
	Xenofarm refinements.
	* scripts/xenofarm.sh: Attempt to identify the version of the C
	compiler and the makeinfo program.

1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
	Flag automatically generated files.
	* src/server/testsuite/lyskomd.0/gen-15.py: Insert a warning in
	the output that the result is automatically generated.
	* src/server/testsuite/lyskomd.0/gen-19.py: Ditto.
	* src/server/Makefile.am (aux.h): Se the mode of this generated
	file to 444, to avoid accidental edits.

	Portability fix.
	* configure.in: Use "test x && test y" instead of "test x -a y",
	since the -a option is less portable than the "&&" construct.

	Update copyright headers.
	* <all files>: update the year in the copyright notice.
	* scripts/lyskomd-copyrights: Updated the list of files to ignore.
	* src/server/testsuite/renumber.el: Copyright header added.

	Xenofarm integration.
	* scripts/xenofarm.sh: New file.  This version was taken from
	revision 1.9 of projects/lyskom-server/source-transform.sh in the
	xenofarm CVS module, and a copyright header and some initial
	comments were added.
	* scripts/Makefile.am (EXTRA_DIST): Added xenofarm.sh.
	* Makefile.am (ident-cc): New target.
	* doc/Makefile.am (ident-makeinfo): New target.

Per Cederqvist's avatar
Per Cederqvist committed
1385 1386 1387 1388 1389 1390
	Release administrativa.
	* HACKING: Mention gpg, the paths of the FTP an WWW servers, a few
	web pages, and Freshmeat.
	* NEWS: Updated for the upcoming 2.0.7 release.  This is only a
	first draft and needs more work.

1391 1392
2002-08-16  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1393 1394 1395
	Portability fixes.
	* doc/Makefile.am (check-doc): Use "diff -c" instead of "diff -u"
	for increased portability.
1396 1397
	* HACKING: Use bison 1.35.  Bison 1.28 produces a file that fails
	on AIX.
Per Cederqvist's avatar
Per Cederqvist committed
1398

Per Cederqvist's avatar
Per Cederqvist committed
1399 1400 1401 1402
	Fix Texinfo error.
	* doc/Makefile.am (protocol-a.texi): Use '@"a', not '@"a{}', when
	substituting IAM.
	* doc/Protocol-A.texi (IAM): Use '@"a', not '@"a{}'.
Per Cederqvist's avatar
Per Cederqvist committed
1403
	* doc/constructs.expected: @"a{} is no longer used.
Per Cederqvist's avatar
Per Cederqvist committed
1404

1405 1406 1407
	"make check" / Python 1.5 compatibility fixes.
	* doc/checkargs.py (lexer.__init__): Use string.split for Python
	1.5 compatibility.
1408 1409 1410
	(number_suffixed): Don't use "".startswith.
	(isalpha): New function.  Use it instead of "".isalpha.
	(isdigit): New function.  Use it instead of "".isdigit.
1411
	(isupper): New function.  Use it instead of "".isupper.
1412 1413
	(islower): New function.  Use it instead of "".islower.
	(isspace): New function.  Use it instead of "".isspace.
1414 1415 1416 1417
	(prot_a_bitstring.check_implemented): Old Python versions cannot
	loop over a dictionary; add an explicit call to the .keys()
	method.
	(lexer.__init__): Use string.strip instead of "".strip.
1418

1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437
	Dump info about existing sessions to a file specified by 
	"Connection status file:".  (Bug 706).
	* src/server/connections.h (Connection): Added the "peer" field.
	* src/server/connections.c (dump_connections): New function.
	(check_kill_flg): Call dump_connections if any connection was
	killed.
	(login_request): Set the "peer" field.
	* src/server/internal-connections.h (dump_connections): New
	function.
	* src/server/internal-connections.c (kill_client): Free the "peer"
	field.
	* src/server/server-config.c (parameters): Added "Connection
	status file" and "Connection status temp file".
	(read_configuration): Handle them.
	* src/server/param.h (struct kom_par): Added
	connection_status_file and connection_status_file_tmp.
	* doc/lyskomd.texi (Parameters): New parameters: "Connection
	status file:" and "Connection status temp file:".

1438 1439
2002-08-15  Per Cederqvist  <ceder@ceder.dyndns.org>

1440 1441 1442 1443 1444 1445
	"make check" may now work with Python 1.5.
	* doc/checkargs.py (prot_a_type.use): Don't use +=.
	(reader.getc_eofok): Ditto.
	(lexer.toplevel_rarg): Ditto.
	(lexer.toplevel_aarg): Ditto.

1446 1447 1448 1449 1450 1451 1452 1453 1454 1455
	"make check" should no longer require gawk.
	* doc/Makefile.am (.texi.notab): Use $(AWK), not gawk.  At least
	some other awk implementations supports this script.

2002-08-14  Per Cederqvist  <ceder@ceder.dyndns.org>

	Makefile bug fixed.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Fixed
	a makefile syntax error.

1456 1457 1458
2002-08-13  Per Cederqvist  <ceder@ceder.dyndns.org>

	* HACKING: Updated version number of automake.
1459
	Mention Xenofarm.
1460

1461 1462
2002-08-11  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475
	Distribution cleanup.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	21.exp, 22.exp, 23.exp, 24.exp, 25.exp, 26.exp, 27.exp, 28.exp,
	bug-145.exp, bug-225.exp, bug-349.exp, bug-37-2.exp, bug-37-3.exp,
	bug-37-4.exp, bug-37.exp, bug-38.exp, bug-598-2.exp, bug-598.exp,
	bug-612.exp and bug-84.exp.
	* doc/Makefile.am (MOSTLYCLEANFILES): Added TeX temp file
	regarding protocol-a.texi, and protocol-a.texi.
	(DISTCLEANFILES): Added Protocol-A.pdf.
	(Protocol-A.dvi): Fix the TEXINPUTS setting so that a VPATH
	compile works.
	(Protocol-A.pdf): Ditto.

1476 1477 1478 1479 1480 1481 1482
	Update version numbers.
	* configure.in: Set version 2.0.7.
	* versions (SERVER-VERSION): 2.0.7.
	(SERVER-COMPAT-VERSION): 20007.
	* doc/Protocol-A.texi (PROTOEDITION): Set to 10.7.
	(VERSION): Set to 2.0.7.

1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494
	Document "language" in the common area.  (Bug 124).
	Fix grammar of common area.
	* doc/Protocol-A.texi (The User Area): The description of the
	common block grammar contained many errors.  State that everything
	is encoded as HOLLERITHs, and that they in turn contain
	datatypes.  Removed "list" and "elems"; added "string-list".
	Added the "language" setting.
	* doc/constructs.expected: Updated.
	* doc/checkargs.py (lexer.toplevel_copying): Ignore.
	(lexer.toplevel_quotation): Ignore
	(lexer.toplevel_insertcopying): Ignore.

1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509
	Make it possible to disable DNS lookups.  Log DNS lookups that
	takes too long.  (Bug 627).
	* src/server/server-config.c (parameters): Removed "Y2K
	Compatibility".  Added "Use DNS" and "DNS log threshold".
	* doc/lyskomd.texi (Parameter Types): Document "double".
	(Parameters): New parameters: "Use DNS:" and "DNS log
	threshold:".
	* src/server/param.h (struct kom_par): Added use_dns and
	dns_log_threshold.  Removed y2k_compat.
	* src/server/connections.c (get_host_name): New function.
	(login_request): Use get_host_name.
	(logout_request): Ditto.
	* src/server/conf-file.h, src/server/conf-file.c (assign_double):
	New function.

1510 1511
2002-08-10  Per Cederqvist  <ceder@ceder.dyndns.org>

1512 1513 1514 1515 1516 1517 1518 1519
	Fix documentation of privilege bits create-conf and create-pers.
	(Bug 688).
	* doc/Protocol-A.texi (Security): create-conf and create-pers are
	normally not assigned.  Added a footnote that says that they are
	normally not needed, either.
	* src/server/testsuite/lyskomd.0/27.exp: Removed references to bug
	688.

1520 1521 1522 1523 1524 1525 1526 1527 1528 1529
	Check for ar. (Bug 523).
	* configure.in: Check for ar.  Look in $PATH:/usr/ccs/bin, and
	stop with an error if no ar can be found.

	Avoid duplicating the license in Protocol-A.texi. (Bug 441).
	* doc/Protocol-A.texi: Use the new @copying and @insertcopying
	commands, to avoid repeating the copyright information.
	(About this document): New node, that makes the copyright
	information visible in Info and HTML.

1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556
	Fix the parser so that negative numbers are rejected.  Don't
	pretend that the protocol base will ever be anything but ten.
	(Bug 225).
	* src/libraries/libmisc/s-string.h: (s_strtol): Removed the base
	argument.
	* src/libraries/libmisc/s-string.c (char2digit): Removed the base
	argument.  Simplified the code.  This should be faster now.
	(s_strtol): Removed the base argument.  Don't allow leading '+'
	or '-' signs.  This simplifies the code.
	* src/server/prot-a-parse.c (prot_a_parse_long): Removed the
	base argument of s_strtol.
	(prot_a_parse_string): Ditto.
	* src/server/aux-items.c (aux_item_trigger_mark_text): Removed the
	base argument of s_strtol.
	(aux_item_trigger_unmark_text): Ditto.
	(aux_item_trigger_mirror_faq): Ditto.
	(aux_item_validate_existing_text): Ditto.
	* src/include/kom-config.h (PROTOCOL_NUMBER_BASE): Removed.
	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Updated,
	now that the parser no longer accepts negative numbers.
	* src/server/testsuite/lyskomd.0/bug-225.exp: Test bug 225.

	Fix references to dbck documentation.  (Bug 386).
	* doc/lyskomd.texi (Parameters): Don't refer to dbck.info, since
	that document is now part of lyskomd.texi.
	(Administration): Ditto.

1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590
	Fix error codes for query-read-texts, query-read-texts-old and
	sub-member.  (Bug 161, Bug 703, Bug 43 and Bug 612).
	* src/server/person.c: "kom-errno.h" must now be included
	before "manipulate.h".
	(do_query_read_texts): Fix error code computations.  Previously,
	ENA(admin,4) was needed.  Now, ENA(admin,2) or ENA(wheel,8) is
	enough. (Bug 161 & Bug 703).
	* src/server/membership.c (enum memb_visibility): Moved to
	manipulate.h.
	(membership_visible): No longer static.
	(sub_member): Improve error code computations.  (Bug 612 & Bug 43).
	* src/server/manipulate.h (enum memb_visibility): Moved here from
	membership.c.
	(membership_visible): Now exported from membership.c.
	(set_conf_errno): New function.
	* src/server/conference.c: "kom-errno.h" must now be included
	before "manipulate.h".
	(set_conf_errno): New function.
	* src/server/admin.c: "kom-errno.h" must now be included before
	"manipulate.h".
	* src/server/aux-items.c: Ditto.
	* src/server/dbck.c: Ditto.
	* src/server/send-async.c: Ditto.
	* src/server/server-config.c: Ditto.
	* src/server/session.c: Ditto.
	* src/server/standalone.c: Ditto.
	* src/server/text.c: Ditto.
	* src/server/testsuite/lyskomd.0/27.exp: Bug 703 is fixed.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Bug 703 is fixed.
	* src/server/testsuite/lyskomd.0/bug-612.exp: Test cases for bug
	612.
	* doc/Protocol-A.texi (sub-member): Document the value of
	error-status for permission-denied errors.

1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612
	get-membership and get-membership-old didn't always honor
	unread-is-secret. (Bug 607).  (Bug 608).
	* src/server/membership.c (copy_public_confs): New argument:
	pers_no.  Caller updated.  Use membership_visible to simplify code
	and fix bugs 607 and 607.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Bug 607 and bug 608
	are now fixed.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.

	get-members and get-members-old leaks secret persons (Bug 705).
	* src/server/membership.c (membership_visible): New arguments:
	is_supervisor_of_member, is_supervisor_of_conf.  Callers updated.
	Avoid calling access_perm if possible.  Grant full access if
	ENA(admin,2) or ENA(wheel,8), as do_get_members did.
	(do_get_members): Use membership_visible to simplify code, and fix
	bug 705.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Bug 705 fixed.

	Minor doc fix.
	* doc/Protocol-A.texi (Membership visibility): Markup fixed.
	* doc/constructs.expected: Updated.

1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628
	Fix membership visibility for get-unread-confs. (Bug 597).
	* src/server/membership.c (enum memb_visibility): New enum.
	(check_unread): New static function.
	(membership_visible): New static function, that fully implements
	the membership visibility rules that were documented 2002-08-07.
	(get_unread_confs): Use membership_visible to simplify the code
	and use the correct membership visibility rules.  Various code
	cleanup.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: get-unread-confs is
	now better.  Bug 597 fixed.
	* src/server/testsuite/lyskomd.0/bug-37.exp: get-unread-confs now
	fails in a different, and better, way for secret persons.
	* src/server/testsuite/lyskomd.0/27.exp: query-read-texts-old, 
	query-read-texts and get-unread-confs should not censor the secret
	conference, since the viewer is supervisor of the member.

1629 1630
2002-08-08  Per Cederqvist  <ceder@ceder.dyndns.org>

1631 1632 1633 1634
	Comment added.
	* src/server/membership.c (sub_member): Added comments for bug
	612.

1635 1636 1637 1638 1639 1640 1641 1642 1643
	Code cleanup: remove global define of SMALLOC_MAGIC_ALLOC and
	SMALLOC_MAGIC_FREE. (Bug 562).
	* src/server/ram-smalloc.c (SMALLOC_MAGIC_ALLOC): Moved here from
	smalloc.h.  Only define if USE_MALLOC_GUARDS is true.
	(SMALLOC_MAGIC_FREE): Ditto.
	* src/include/server/smalloc.h (SMALLOC_MAGIC_ALLOC): Moved to
	ram-smalloc.c.
	(SMALLOC_MAGIC_FREE): Ditto.

1644 1645 1646 1647 1648 1649 1650
	Test membership visibility in get-members-old and get-members.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Test get-members-old
	and get-members.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.

1651 1652 1653 1654
2002-08-07  Per Cederqvist  <ceder@ceder.dyndns.org>

	Documented membership visibility.  (Bug 693).
	* doc/Protocol-A.texi (Membership visibility): New chapter.
1655 1656 1657
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Updated for new
	membership visibility rules.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
1658

1659 1660 1661 1662 1663 1664 1665
2002-08-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix some "make maintainer-clean" lossage.
	* src/server/Makefile.am (aux-item-def-scan.o): Added an explicit
	dependency on aux-item-def-parse.h.
	* Makefile.am (DISTCLEANFILES): Added config.cache.

Per Cederqvist's avatar
Per Cederqvist committed
1666 1667 1668 1669 1670 1671
2002-08-02  Per Cederqvist  <ceder@ceder.dyndns.org>

	More valgrind integration.
	* src/server/testsuite/config/unix.exp (check_valgrind): Remove
	boring valgrind logfiles.

1672 1673 1674 1675 1676 1677 1678 1679
2002-08-02  David Byers  <david.byers@swipnet.se>

	Add missing test cases for bug 84.
	* src/server/testsuite/config/prot-a.exp (kom_delete_text): New
	function. Use to delete a text from the test suite.
	* src/server/testsuite/lyskomd.0/bug-84.exp: Added missing test
	cases for bug 84 and one xfail for bug 690.

1680
2002-08-02  Per Cederqvist  <ceder@ceder.dyndns.org>
1681 1682 1683 1684 1685

	Work around a race condition in the test suite.
	* src/server/testsuite/lyskomd.0/18.exp: Sleep six seconds to work
	around a race condition (Bug 692).

1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732
	Suppress errors from regex.c.  Handle simultaneous runs of lyskomd
	and dbck.
	* src/server/testsuite/lyskomd.supp: New file for valgrind.  This
	contains a suppression for bug 691.
	* src/server/testsuite/config/unix.exp (l2g_start): Pass a log
	file name to the valgrind wrapper.
	(dbck_run): Ditto.
	(spawn_lyskomd): New argument: log file name.  All callers
	updated.  Use the lyskomd.supp valgrind suppressions file.  Pass
	--show-reachable=yes and a log file name to valgrind.
	(check_valgrind): New arguments: logfile, need_leaks and
	need_errs.  All callers updated.
	* src/server/testsuite/Makefile.am (valgrind.wrap): Expect the log
	file name as the first argument.
	(EXTRA_DIST): Added lyskomd.supp.

	Make it possible to run lyskomd without malloc guard areas.
	* configure.in: Added --disable-malloc-guards.  This is useful
	when combined with --with-valgrind, but should not be used in a
	production setting.
	* src/server/ram-smalloc.c: Document our guard areas, and make
	them optional.
	(OVERHEAD): New macro, that computes a size including the guard
	area overhead.  Two versions, depending on if USE_MALLOC_GUARDS is
	defined or not.
	(smalloc): Reindent.  Test USE_MALLOC_GUARDS.
	(sfree): Test USE_MALLOC_GUARDS.
	(srealloc): Test USE_MALLOC_GUARDS.

	Fixed a read past the end of a buffer.
	* src/libraries/libmisc/s-string.c (s_strtol): When a string
	containing only whitespace was passed to s_strtol, s_strtol would
	attempt to read the sign ('+' or '-') past the end of the string.

	Fix the l2g test cases.
	* src/server/testsuite/l2g.0/00.exp: Destroy all structures before
	exit, so that the leak check of valgrind works properly.
	* src/server/testsuite/l2g.0/01.exp: Ditto.
	* src/server/testsuite/l2g.0/02.exp: Ditto.
	* src/server/testsuite/l2g.0/03.exp: Ditto.
	* src/server/testsuite/l2g.0/04.exp: Ditto.
	* src/server/testsuite/l2g.0/05.exp: Ditto.
	* src/server/testsuite/l2g.0/06.exp: Ditto.
	* src/server/testsuite/l2g.0/07.exp: Ditto.
	* src/server/testsuite/l2g.0/08.exp: Ditto.
	* src/server/testsuite/l2g.0/09.exp: Ditto.
	* src/server/testsuite/l2g.0/10.exp: Ditto.
1733