membership.c 54.6 KB
Newer Older
Linus Tolke's avatar
Linus Tolke committed
1
/*
2
 * $Id: membership.c,v 0.93 2003/08/20 17:40:18 ceder Exp $
Per Cederqvist's avatar
Per Cederqvist committed
3
 * Copyright (C) 1991-2002  Lysator Academic Computer Association.
Linus Tolke's avatar
Linus Tolke committed
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 *
 * This file is part of the LysKOM server.
 * 
 * LysKOM is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License as published by 
 * the Free Software Foundation; either version 1, or (at your option) 
 * any later version.
 * 
 * LysKOM is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with LysKOM; see the file COPYING.  If not, write to
 * Lysator, c/o ISY, Linkoping University, S-581 83 Linkoping, SWEDEN,
 * or the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, 
 * MA 02139, USA.
 *
Per Cederqvist's avatar
Per Cederqvist committed
23
 * Please report bugs at http://bugzilla.lysator.liu.se/. 
Linus Tolke's avatar
Linus Tolke committed
24
 */
Per Cederqvist's avatar
Per Cederqvist committed
25
26
27
28
29
30
/*
 * membership.c
 *
 * All atomic calls that controlls who is a member in what.
 * (The person/conf relation).
 */
Per Cederqvist's avatar
Per Cederqvist committed
31

David Byers's avatar
David Byers committed
32
33
34
35
36
37


#ifdef HAVE_CONFIG_H
#  include <config.h>
#endif

Per Cederqvist's avatar
Per Cederqvist committed
38
39
#define DEBUG_MARK_AS_READ

40
#include <assert.h>
Per Cederqvist's avatar
Per Cederqvist committed
41
#include <stdio.h>
Per Cederqvist's avatar
Per Cederqvist committed
42
43
44
#ifdef HAVE_STRING_H
#  include <string.h>
#endif
45
#include <stddef.h>
46
#include "timewrap.h"
Per Cederqvist's avatar
Per Cederqvist committed
47
#include <setjmp.h>
48
#include <sys/types.h>
Per Cederqvist's avatar
Per Cederqvist committed
49
50

#include "misc-types.h"
51
#include "s-string.h"
Per Cederqvist's avatar
Per Cederqvist committed
52
53
54
#include "kom-types.h"
#include "services.h"
#include "server/smalloc.h"
Per Cederqvist's avatar
Per Cederqvist committed
55
56
#include "lyskomd.h"
#include "com.h"
57
#include "async.h"
Per Cederqvist's avatar
Per Cederqvist committed
58
59
#include "connections.h"
#include "internal-connections.h"
Per Cederqvist's avatar
Per Cederqvist committed
60
61
62
63
64
#include "kom-errno.h"
#include "manipulate.h"
#include "cache.h"
#include "send-async.h"
#include "minmax.h"
Per Cederqvist's avatar
Per Cederqvist committed
65
#include "kom-memory.h"
66
#include "param.h"
67
#include "local-to-global.h"
68
#include "server-time.h"
Per Cederqvist's avatar
Per Cederqvist committed
69
70

#ifdef DEBUG_MARK_AS_READ
71
72
#  include "log.h"
#  include "ram-output.h"
Per Cederqvist's avatar
Per Cederqvist committed
73
74
#endif

75
76
static void
set_membership_type_bits(Membership_type *type,
77
78
79
80
81
82
83
84
			 Bool invitation,
			 Bool passive,
			 Bool secret,
			 Bool passive_message_invert,
			 Bool reserved2,
			 Bool reserved3, 
			 Bool reserved4,
			 Bool reserved5)
85
86
87
88
{
    type->invitation = invitation;
    type->passive = passive;
    type->secret = secret;
89
    type->passive_message_invert = passive_message_invert;
90
91
92
93
94
95
    type->reserved2 = reserved2;
    type->reserved3 = reserved3;
    type->reserved4 = reserved4;
    type->reserved5 = reserved5;
}

96
97
98
99
100
101
102
103
104
105
106
107
108

static enum memb_visibility
check_unread(Pers_no member)
{
    Person *memb_p;
    GET_P_STAT(memb_p, member, mv_none);
    if (memb_p->flags.unread_is_secret)
	return mv_censor_unread;
    else
	return mv_full;
}


109
enum memb_visibility
110
111
112
membership_visible(const Connection *viewer_conn,
		   Pers_no member,
		   Conf_no conf_no,
113
114
115
116
		   Membership_type type,
		   Bool is_supervisor_of_member,
		   Bool is_supervisor_of_conf)

117
{
118
119
120
121
    enum access ma = error;
    enum access ca = error;
    
    if (ENA_C(viewer_conn, admin, 2) || ENA_C(viewer_conn, wheel, 8))
122
123
	return mv_full;

124
125
126
127
128
    if (is_supervisor_of_member
	|| (ma = access_perm(member, viewer_conn, unlimited)) >= unlimited)
    {
	return mv_full;
    }
129

130
131
    if (is_supervisor_of_conf
	|| (ca = access_perm(conf_no, viewer_conn, unlimited)) >= unlimited)
132
133
134
    {
	return check_unread(member);
    }
135
136
137

    if (ma >= read_protected && ca >= read_protected && !type.secret)
	return check_unread(member);
138
139
140
141
    
    return mv_none;
}

Per Cederqvist's avatar
Per Cederqvist committed
142
143
144
145
146
147
148
/*
 * Copy all information that ACTPERS is authorized to know about ORIG_P's
 * membership in all conferences to CENSOR_P.
 *
 * This function is used in get_membership().
 */
static void
David Byers's avatar
Server    
David Byers committed
149
copy_public_confs (Connection * conn, /* The connection for which we copy */
150
		   Pers_no    pers_no,  /* The person being censored */
David Byers's avatar
Server    
David Byers committed
151
                   Person   * censor_p,	/* The censored Person-struct */
Per Cederqvist's avatar
Per Cederqvist committed
152
		   Person   * orig_p,	/* The uncensored Person-struct */
153
154
155
		   Bool       keep_read,
		   Bool       want_read,
		   unsigned long max_ranges)
Per Cederqvist's avatar
Per Cederqvist committed
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
{
    int i;			/* Number of mships lefte in ORIG_P */
    Membership * censor_m;		/* Pointer in CENSOR_P */
    Membership * orig_m;	/* Pointer in ORIG_P */

    /* Copy all information except the secret. */
		    
    censor_p->conferences.confs
	= tmp_alloc( orig_p->conferences.no_of_confs * sizeof(Membership));
    censor_p->conferences.no_of_confs = 0;

    censor_m = censor_p->conferences.confs;
    orig_m   = orig_p->conferences.confs;

    for ( i = 0; i < orig_p->conferences.no_of_confs; i++, orig_m++ )
    {
172
173
174
175
	enum memb_visibility vis = membership_visible(
	    conn, pers_no, orig_m->conf_no, orig_m->type, FALSE, FALSE);

	if (vis > mv_none)
Per Cederqvist's avatar
Per Cederqvist committed
176
177
178
	{
	    *censor_m = *orig_m;

179
	    if (!want_read)
180
181
182
183
184
185
186
187
188
189
190
	    {
		if (keep_read)
		    censor_m->skip_read_texts = TRUE;
		else
		    censor_m->read_ranges = NULL;
	    }
	    else
	    {
		if (max_ranges > 0 && censor_m->no_of_read_ranges > max_ranges)
		    censor_m->no_of_read_ranges = max_ranges;
	    }
Per Cederqvist's avatar
Per Cederqvist committed
191

192
	    if (vis == mv_censor_unread)
Per Cederqvist's avatar
Per Cederqvist committed
193
194
	    {
		censor_m->last_time_read = NO_TIME;
195
196
		censor_m->no_of_read_ranges = 0;
		censor_m->read_ranges = NULL;
Per Cederqvist's avatar
Per Cederqvist committed
197
198
199
200
201
202
203
204
205
206
207
	    }
	    
	    ++censor_m;
	    ++censor_p->conferences.no_of_confs;
	}
    }
}

/*
 * Change the priority of a certain conference in a person.
 */
David Byers's avatar
David Byers committed
208

Per Cederqvist's avatar
Per Cederqvist committed
209
210
static void
do_change_priority (Membership * mship,
211
212
                    Conf_no conf_no,
                    Conference * conf_c,
213
214
		    unsigned char	 priority,
		    unsigned short	 where,
Per Cederqvist's avatar
Per Cederqvist committed
215
		    Pers_no	 pers_no,
216
		    Person     * pers_p,
David Byers's avatar
David Byers committed
217
218
                    Membership_type * type,
                    Bool            fake_passive)
Per Cederqvist's avatar
Per Cederqvist committed
219
220
{
    Membership tmp_conf;
David Byers's avatar
David Byers committed
221
    Member *mem;
Per Cederqvist's avatar
Per Cederqvist committed
222
    
David Byers's avatar
David Byers committed
223
    if (priority == 0 && fake_passive)
224
    {
David Byers's avatar
David Byers committed
225
        type->passive = 1;
226
227
228
229
230
    }
    else
    {
        mship->priority = priority;
    }
David Byers's avatar
David Byers committed
231

232
    mship->type = *type;
Per Cederqvist's avatar
Per Cederqvist committed
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
    
    /* Check range of where */
    
    if ( where >= pers_p->conferences.no_of_confs )
    {
	where = pers_p->conferences.no_of_confs - 1;
    }
    
    /* And now move the conference to slot number 'where' */
    
    if ( mship < pers_p->conferences.confs + where )
    {
	tmp_conf = *mship;
	while ( mship < pers_p->conferences.confs + where)
	{
	    *mship = *(mship + 1);
	    mship++;
	}
	*mship = tmp_conf;
    }
    else
    {
	tmp_conf = *mship;
	while ( mship > pers_p->conferences.confs + where)
	{
	    *mship = *(mship - 1);
	    mship--;
	}
	*mship = tmp_conf;
    }

David Byers's avatar
David Byers committed
264
265
266
    /* Sync the change with the corresponding member list */
    mem = locate_member(pers_no, conf_c);
    if (mem != NULL)
267
    {
David Byers's avatar
David Byers committed
268
269
        mem->type = *type;
        mark_conference_as_changed( conf_no );
270
271
    }

Per Cederqvist's avatar
Per Cederqvist committed
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
    mark_person_as_changed( pers_no );
}


/*
 * Insert a rec_time misc item to a text_status.
 * The item is put at position POS on the list. (0 == first)
 * Take no action if the misc_item at POS is a rec_time.
 * This function is only used when a person marks his letters as read.
 *
 *	Text_stat * text_stat_pointer	Textstatus to modify
 *	int	    pos			Where to insert rec_time
 */

static void
do_add_rec_time (Text_stat    * text_stat_ptr,
		 int		pos)
{
    int i;

    /* Defensive checks */
    if ( pos < 0 || pos > text_stat_ptr->no_of_misc )
    {
	restart_kom("do_add_rec_time() - illegal pos\n");
    }

    /* Check that no rec_time exists */

    if ( pos < text_stat_ptr->no_of_misc
	&& text_stat_ptr->misc_items[ pos ].type == rec_time )
    {
	return;
    }
    
    /* Allocate space */
    text_stat_ptr->misc_items
    = srealloc(text_stat_ptr->misc_items,
	       (++(text_stat_ptr->no_of_misc)) * sizeof(Misc_info));

    /* Move items. */

    for ( i = text_stat_ptr->no_of_misc - 1; i > pos; i-- )
    {
	text_stat_ptr->misc_items[ i ] = text_stat_ptr->misc_items[ i - 1 ];
    }

    /* Set type */
    text_stat_ptr->misc_items[ pos ].type = rec_time;

    /* Set value */
322
    text_stat_ptr->misc_items[ pos ].datum.received_at = current_time.tv_sec;
Per Cederqvist's avatar
Per Cederqvist committed
323
324
325
326
}

/*
 * add_rec_time adds a 'rec_time'  misc_item to text number LOC_NO in
David Byers's avatar
Server    
David Byers committed
327
328
 * conference CONF_C. The item will follow a recpt or cc_recpt to pers_no.
 * No action is taken if PERS_NO is not a recipient of the text, or the text
Per Cederqvist's avatar
Per Cederqvist committed
329
330
331
 * no longer exists, or the text has already been received.
 */
static void
332
add_rec_time(Conference * conf_c,
David Byers's avatar
Server    
David Byers committed
333
334
	     Local_text_no local_no,
             Pers_no pers_no)
Per Cederqvist's avatar
Per Cederqvist committed
335
336
337
338
339
340
{
    Bool 	  found;
    Text_no	  text_no;
    Text_stat 	* t_stat;
    int		  i;
    
341
    text_no = l2g_lookup(&conf_c->texts, local_no);
Per Cederqvist's avatar
Per Cederqvist committed
342
343
344
345
346
347

    if ( text_no == 0 )
    {
	return;			/* Text is deleted. */
    }
    
Per Cederqvist's avatar
Per Cederqvist committed
348
    VOID_GET_T_STAT(t_stat, text_no);
Per Cederqvist's avatar
Per Cederqvist committed
349
350
351
352
353
354
355
356
357

    /* locate the misc_item which says that ACTPERS is a recipient */

    for ( found = FALSE, i = 0; !found && i < t_stat->no_of_misc; i++ )
    {
	switch ( t_stat->misc_items[ i ].type )
	{
	case recpt:
	case cc_recpt:
358
	case bcc_recpt:
359
	    if ( t_stat->misc_items[ i ].datum.recipient == pers_no )
360
	    {
361
		do_add_rec_time( t_stat, i + 2 ); /* Add after loc_no */
362
363
364
365
		found = TRUE;
	    }
	    break;

Per Cederqvist's avatar
Per Cederqvist committed
366
367
368
369
370
371
372
373
374
	case comm_to:
	case comm_in:
	case footn_to:
	case footn_in:
	case loc_no:
	case rec_time:
	case sent_by:
	case sent_at:
	    break;
David Byers's avatar
David Byers committed
375
376
377
378

        case unknown_info:
        default:
            restart_kom("ERROR: bogus misc_info type detected in text %lu\n", text_no);
Per Cederqvist's avatar
Per Cederqvist committed
379
380
381
382
383
	}
    }

    if( found ==  FALSE )
    {
David Byers's avatar
David Byers committed
384
	kom_log("ERROR: add_rec_time(): found==FALSE\n");
Per Cederqvist's avatar
Per Cederqvist committed
385
386
387
388
389
390
391
    }
    
    mark_text_as_changed( text_no);
    return;
}

/*
392
393
 * Check if any read_ranges can be extended due to deleted texts.
 * Merge read_ranges blocks, if possible.
Per Cederqvist's avatar
Per Cederqvist committed
394
 *
395
396
397
 * This is currently only used from mark_as_read(), but it would be
 * good to have a background task that does this whenever a text has
 * been deleted.
398
399
 *
 * Returns non-zero if any change was performed.
Per Cederqvist's avatar
Per Cederqvist committed
400
 */
401
Bool
402
403
adjust_read(Membership *m,
	    const Conference *conf)
Per Cederqvist's avatar
Per Cederqvist committed
404
{
405
406
407
408
409
410
    struct read_range *ptr;
    struct read_range *prev;
    struct read_range *next;
    struct read_range *tail;
    struct read_range *begin;
    struct read_range *end;
411
    Bool change = FALSE;
412

Per Cederqvist's avatar
Per Cederqvist committed
413
414
    Local_text_no   conf_max;	/* Highest used local_text_no in conf */
    Local_text_no   conf_min;	/* Lowest used local_text_no in conf */
415

416
417
418
    Local_text_no   past_block;	/* The next local_text_no after the current block. */
    Local_text_no   limit;

419
420
    /* If nothing is marked as read, there is nothing to adjust.  */
    if (m->no_of_read_ranges == 0)
421
	return change;
Per Cederqvist's avatar
Per Cederqvist committed
422

423
    /* (conf_min <= x < conf_max) if x is an existing local_text_no */
424
    conf_min = l2g_next_key(&conf->texts, 0);
425
426
    if (conf_min == 0)
	conf_min = l2g_first_appendable_key(&conf->texts);
427
    conf_max = l2g_first_appendable_key(&conf->texts);
Per Cederqvist's avatar
Per Cederqvist committed
428

429
430
    begin = &m->read_ranges[0];
    end = begin + m->no_of_read_ranges;
Per Cederqvist's avatar
Per Cederqvist committed
431

432
433
434
435
#ifdef DEBUG_MARK_AS_READ
    
    /* Check that the items in read_texts really ARE sorted in ascending order.
       If not, there is probably a bug in this routine or in mark_as_read. */
Per Cederqvist's avatar
Per Cederqvist committed
436

437
    for (ptr = begin; ptr < end; ptr++)
438
    {
439
	if (ptr->first_read > ptr->last_read)
Per Cederqvist's avatar
Per Cederqvist committed
440
	{
441
442
443
444
445
446
	    kom_log("Bad input to adjust_read. Conference %lu, Priority %lu."
		    " Range %lu-%lu is nonsensical.\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)ptr->first_read,
		    (unsigned long)ptr->last_read);
447
	    return change;
Per Cederqvist's avatar
Per Cederqvist committed
448
	}
449
450

	if (ptr != begin && (ptr-1)->last_read >= ptr->first_read)
451
	{
452
453
454
455
456
457
458
459
	    kom_log("Bad input to adjust_read. Conference %lu, Priority %lu."
		    " Overlapping ranges: %lu-%lu, %lu-%lu.\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)(ptr-1)->first_read,
		    (unsigned long)(ptr-1)->last_read,
		    (unsigned long)ptr->first_read,
		    (unsigned long)ptr->last_read);
460
	    return change;
461
462
	}
    }
463
464
465
#endif

    for (ptr = begin; ptr < end; ptr++)
Per Cederqvist's avatar
Per Cederqvist committed
466
    {
467
468
469
470
471
472
473
474
475
	if (ptr == begin)
	    prev = NULL;
	else
	    prev = ptr - 1;
	next = ptr + 1;
	if (next == end)
	    next = NULL;

	/* Try to lower first_read. */
476
	while (ptr->first_read > 1
477
478
	       && (prev == NULL || prev->last_read + 1 < ptr->first_read)
	       && l2g_lookup(&conf->texts, ptr->first_read - 1) == 0)
Per Cederqvist's avatar
Per Cederqvist committed
479
	{
480
	    change = TRUE;
481
	    ptr->first_read--;
482
483
	    if (ptr->first_read < conf_min)
		ptr->first_read = 1;
Per Cederqvist's avatar
Per Cederqvist committed
484
	}
485

486
487
488
489
490
491
492
493
494
	/* Raise last_read past any deleted texts. */
	past_block = l2g_next_key(&conf->texts, ptr->last_read);
	if (next != NULL)
	    limit = next->first_read;
	else
	    limit = conf_max;

	if (past_block == 0 || past_block > limit)
	    past_block = limit;
495
496
497
498
499
	if (ptr->last_read != past_block - 1)
	{
	    ptr->last_read = past_block - 1;
	    change = TRUE;
	}
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
    }

    /* Join any ranges that became adjacent. */
    tail = begin;
    for (ptr = begin + 1; ptr < end; ptr++)
    {
	if (tail->last_read + 1 == ptr->first_read)
	    tail->last_read = ptr->last_read;
	else if (++tail != ptr)
	    *tail = *ptr;
    }
    if (end != tail + 1)
    {
	end = tail + 1;
	m->no_of_read_ranges = end - begin;
	m->read_ranges = srealloc(
	    m->read_ranges,
	    m->no_of_read_ranges * sizeof(m->read_ranges[0]));
518
	change = TRUE;
Per Cederqvist's avatar
Per Cederqvist committed
519
520
    }

521
#ifndef NDEFENSIVE_CHECKS
Per Cederqvist's avatar
Per Cederqvist committed
522
523
    
    /* Check that the items in read_texts really ARE sorted in ascending order.
524
525
526
       If not, there is probably a bug in this routine or in mark_as_read. */

    for (ptr = begin; ptr < end; ptr++)
Per Cederqvist's avatar
Per Cederqvist committed
527
    {
528
	if (ptr->first_read > ptr->last_read)
Per Cederqvist's avatar
Per Cederqvist committed
529
	{
530
531
532
533
534
535
536
	    kom_log("Bug in adjust_read. Conference %lu, Priority %lu."
		    " Range %lu-%lu is nonsensical (fixed).\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)ptr->first_read,
		    (unsigned long)ptr->last_read);
	    ptr->last_read = ptr->first_read;
537
538
	    change = TRUE;
	    return change;
Per Cederqvist's avatar
Per Cederqvist committed
539
540
	}

541
542
543
544
545
546
547
548
549
550
551
	if (ptr != begin && ptr->first_read <= (ptr-1)->last_read)
	{
	    kom_log("Bug in adjust_read. Conference %lu, Priority %lu."
		    " %lu not greater than %lu (fixed).\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)ptr->first_read,
		    (unsigned long)(ptr-1)->last_read);
	    sfree(m->read_ranges);
	    m->read_ranges = NULL;
	    m->no_of_read_ranges = 0;   
552
553
	    change = TRUE;
	    return change;
554
	}
Per Cederqvist's avatar
Per Cederqvist committed
555
556
    }
#endif
557
    return change;
Per Cederqvist's avatar
Per Cederqvist committed
558
559
560
}

/*
561
 * insert TEXT in the set of read texts in M.
Per Cederqvist's avatar
Per Cederqvist committed
562
563
564
565
566
567
568
569
570
571
 *
 * Returns FAILURE if the text is already read.
 *
 * This is only used from mark_as_read().
 */

static Success
insert_loc_no(Local_text_no   text,
	      Membership    * m)
{
572
573
574
575
576
577
578
579
580
581
    struct read_range *lo;
    struct read_range *hi;
    struct read_range *mid;
    struct read_range *begin;
    struct read_range *end;
    ptrdiff_t save;
    struct read_range *gap;
    struct read_range *move;

    if (m->no_of_read_ranges == 0)
Per Cederqvist's avatar
Per Cederqvist committed
582
    {
583
584
585
586
587
	m->read_ranges = smalloc(sizeof(m->read_ranges[0]));
	m->no_of_read_ranges = 1;
	m->read_ranges[0].first_read = text;
	m->read_ranges[0].last_read = text;
	return OK;
Per Cederqvist's avatar
Per Cederqvist committed
588
589
    }

590
591
592
593
    begin = lo = &m->read_ranges[0];
    end = hi = lo + m->no_of_read_ranges;

    while (hi - lo > 1)
Per Cederqvist's avatar
Per Cederqvist committed
594
    {
595
596
597
598
599
600
	mid = lo + (hi - lo) / 2;
	if (text < mid->first_read - 1)
	    hi = mid;
	else if (text > mid->last_read + 1)
	    lo = mid;
	else
Per Cederqvist's avatar
Per Cederqvist committed
601
	{
602
603
	    lo = mid;
	    hi = mid + 1;
Per Cederqvist's avatar
Per Cederqvist committed
604
	}
605
    }
Per Cederqvist's avatar
Per Cederqvist committed
606

607
608
    if (text >= lo->first_read && text <= lo->last_read)
	return FAILURE;		/* This text was already read. */
Per Cederqvist's avatar
Per Cederqvist committed
609

610
611
612
613
614
    if (text == lo->first_read - 1)
    {
	lo->first_read = text;
	return OK;
    }
Per Cederqvist's avatar
Per Cederqvist committed
615

616
617
618
619
    if (text == lo->last_read + 1)
    {
	lo->last_read = text;
	return OK;
Per Cederqvist's avatar
Per Cederqvist committed
620
621
    }

622
623
624
625
626
627
628
629
630
631
632
633
634
635
    /* We have to allocate a new block. */
    if (lo->last_read < text)
	lo++;

    save = lo - begin;
    m->read_ranges = srealloc(
	m->read_ranges,
	++(m->no_of_read_ranges) * sizeof(m->read_ranges[0]));
    begin = &m->read_ranges[0];
    gap = begin + save;
    end = begin + m->no_of_read_ranges;
    for (move = end - 1; move > gap; move--)
	*move = *(move - 1);
    gap->first_read = gap->last_read = text;
Per Cederqvist's avatar
Per Cederqvist committed
636
637
638
    return OK;
}

639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
static void
remove_loc_no(Local_text_no   text,
	      Membership    * m)
{
    struct read_range *lo;
    struct read_range *hi;
    struct read_range *mid;
    struct read_range *begin;
    struct read_range *end;
    ptrdiff_t save;
    struct read_range *gap;
    struct read_range *move;

    if (m->no_of_read_ranges == 0)
	return;

    begin = lo = &m->read_ranges[0];
    end = hi = lo + m->no_of_read_ranges;

    while (hi - lo > 1)
    {
	mid = lo + (hi - lo) / 2;
	if (text < mid->first_read - 1)
	    hi = mid;
	else if (text > mid->last_read + 1)
	    lo = mid;
	else
	{
	    lo = mid;
	    hi = mid + 1;
	}
    }

    if (text < lo->first_read || text > lo->last_read)
	return;			/* This text was already unread. */
    
    if (text == lo->first_read)
    {
	if (lo->first_read != lo->last_read)
	{
	    /* Remove the first text of this range. */
	    lo->first_read++;
	    return;
	}

	/* This range contains a single text.  Remove the entire range.  */
	for (move = lo; move < (end-1); move++)
	    *move = *(move+1);
	m->no_of_read_ranges--;
688
689
690
691
692
693
694
695
696
697
	if (m->no_of_read_ranges == 0)
	{
	    sfree(m->read_ranges);
	    m->read_ranges = NULL;
	}
	else
	    m->read_ranges = srealloc(
		m->read_ranges,
		m->no_of_read_ranges * sizeof(m->read_ranges[0]));

698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
	return;
    }

    if (text == lo->last_read)
    {
	assert(text != lo->first_read);

	/* Remove the last text of this range.  */
	lo->last_read--;
	return;
    }

    assert(lo->first_read < text && text < lo->last_read);

    /* We have to split this block. */
    save = lo - begin;
    m->read_ranges = srealloc(
	m->read_ranges,
	++(m->no_of_read_ranges) * sizeof(m->read_ranges[0]));
    begin = &m->read_ranges[0];
    gap = begin + save;
    end = begin + m->no_of_read_ranges;
    for (move = end - 1; move > gap; move--)
	*move = *(move - 1);

    assert(gap->first_read == (gap+1)->first_read);
    assert(gap->last_read == (gap+1)->last_read);
    assert(text > gap->first_read);
    assert(text < gap->last_read);

    gap->last_read = text - 1;
    (gap+1)->first_read = text + 1;
    return;
}

733
734
735
736
737
738
739

/*
 * Send a new-membership message to the affected person
 */

static void
send_async_new_membership(Pers_no pers_no,
740
			  Conf_no conf_no)
741
742
743
744
745
746
747
748
749
750
751
752
753
754
{
    Connection *cptr = NULL;
    Session_no i = 0;

    while ((i = traverse_connections(i)) != 0)
    {
        cptr = get_conn_by_number(i);
        if (cptr->pers_no == pers_no)
        {
            async_new_membership(cptr, pers_no, conf_no);
        }
    }
}

755
756
757
758
759
760
761
762
763
764
765
766
767
/*
 * Compute the derived last-text-read value.
 */
static inline Local_text_no
last_text_read(const Membership *mship)
{
    if (mship->no_of_read_ranges == 0)
	return 0;
    if (mship->read_ranges[0].first_read > 1)
	return 0;
    return mship->read_ranges[0].last_read;
}

768

Per Cederqvist's avatar
Per Cederqvist committed
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
/*
 * End of static functions
 */

/*
 * Functions that are exported to the server.
 */

/*
 * Add a member to a conference. All errorchecking should already
 * be done when this function is called. The person must not already
 * be a member of the conference. It is _not_ an error to make WHERE bigger
 * than the number of conferences the person is a member in.
 */

void
do_add_member(Conf_no	   conf_no,  /* Conference to add a new member to. */
	      Conference * conf_c,   /* Conf. status. Must NOT be NULL.  */
	      Pers_no	   pers_no,  /* Person to be added. */
	      Person	 * pers_p,   /* Pers. status. Must NOT be NULL. */
David Byers's avatar
Server    
David Byers committed
789
              Pers_no      added_by, /* Person doing the adding */
790
	      unsigned char	   priority, /* Prioritylevel to assign to this conf */
791
	      unsigned short	   where,   /* Sequence number in the list */
David Byers's avatar
David Byers committed
792
793
              Membership_type      * type, /* Type of the membership */
              Bool              fake_passive
794
              )
Per Cederqvist's avatar
Per Cederqvist committed
795
796
{
    Membership  * mship;
David Byers's avatar
David Byers committed
797
798
799
800
801
802
803
804
    Member	* mem;


    if (fake_passive && priority == 0)
    {
        type->passive = 1;
    }

Per Cederqvist's avatar
Per Cederqvist committed
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825

    /* First add the conference in the person-struct.
     * Make room for it.
     */
    
    pers_p->conferences.confs = srealloc( pers_p->conferences.confs,
					 ++(pers_p->conferences.no_of_confs)
					 * sizeof(Membership));
    
    /* Fill in the room */

    /* Find last slot */    
    mship = pers_p->conferences.confs + pers_p->conferences.no_of_confs - 1 ;
    
    /* Move all data beyond WHERE */
    while ( mship > pers_p->conferences.confs + where )
    {
	*mship = *(mship - 1);
	mship--;
    }

826
    init_membership(mship);
Per Cederqvist's avatar
Per Cederqvist committed
827
    
David Byers's avatar
Server    
David Byers committed
828
    mship->added_by = added_by;
829
    mship->added_at = current_time.tv_sec;
Per Cederqvist's avatar
Per Cederqvist committed
830
831
    mship->conf_no = conf_no;
    mship->priority = priority;
832
    mship->last_time_read = current_time.tv_sec;
833
834
    mship->no_of_read_ranges = 0;
    mship->read_ranges = NULL;
835
    mship->type = *type;
836
    mship->skip_read_texts = FALSE;
837

Per Cederqvist's avatar
Per Cederqvist committed
838
839
840
841
842
843
844
845
    /* Make room for the person in the conference */
    
    conf_c->members.members = srealloc( conf_c->members.members,
				       ++(conf_c->members.no_of_members)
				       * sizeof(Member));

    /* New members go to the end of the list */
    
David Byers's avatar
David Byers committed
846
847
    mem = (conf_c->members.members + conf_c->members.no_of_members - 1);
    mem->member = pers_no;
David Byers's avatar
Server    
David Byers committed
848
    mem->added_by = added_by;
849
    mem->added_at = current_time.tv_sec;
David Byers's avatar
David Byers committed
850
    mem->type = *type;
Per Cederqvist's avatar
Per Cederqvist committed
851
852
853
    
    mark_conference_as_changed( conf_no );
    mark_person_as_changed( pers_no );
854

Per Cederqvist's avatar
Per Cederqvist committed
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
    return;
}

/*
 * Send an asynchronous message to person pers_no (if he is logged on)
 * and tell him that he is no longer a member of conf_no. Also calls
 * leave_conf(). 
 */
extern void
forced_leave_conf(Pers_no pers_no,
		  Conf_no conf_no)
{
    Connection *real_active_connection;
    Session_no i = 0;
    
    real_active_connection = active_connection;

    while ( (i = traverse_connections(i)) != 0 )
    {
	active_connection = get_conn_by_number(i);

	if ( active_connection->pers_no == pers_no )
	{
	    async_forced_leave_conf(active_connection, conf_no);

	    if ( active_connection->cwc == conf_no )
David Byers's avatar
Server    
David Byers committed
881
		leave_conf(active_connection);
Per Cederqvist's avatar
Per Cederqvist committed
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
	}
    }

    active_connection = real_active_connection;
}

/*
 * Delete a member from a conference.
 * No checks are made on the parameters.
 * The dynamically allocated areas conf_c->members.members and
 * pers_p->confs are NOT reallocated since they will anyhow sooner or later
 * be flushed from core.
 */

Success
do_sub_member(Conf_no	   conf_no, /* Conf to delete member from. */
	      Conference * conf_c,  /* May be NULL */
899
	      Member     * mbr,     /* May be NULL */
Per Cederqvist's avatar
Per Cederqvist committed
900
901
902
903
904
905
906
907
908
909
910
911
912
913
	      Pers_no	   pers_no, /* Person to be deleted. */
	      Person	 * pers_p,  /* May be NULL */
	      Membership * mship)   /* Pointer to the persons membership in
				       conf., or NULL if not known. */
{
    if ( conf_c == NULL )
	GET_C_STAT(conf_c, conf_no, FAILURE);
    
    if ( pers_p == NULL )
	GET_P_STAT(pers_p, pers_no, FAILURE);
    
    if ( mship == NULL && (mship = locate_membership(conf_no, pers_p)) == NULL)
	restart_kom("do_sub_member() - can't find mship\n");

914
    if ( mbr == NULL && (mbr = locate_member(pers_no, conf_c)) == NULL)
Per Cederqvist's avatar
Per Cederqvist committed
915
916
917
918
919
920
	restart_kom("do_sub_member() - can't find member.\n");

    forced_leave_conf(pers_no, conf_no);
    
    /* Delete from Person */

921
    sfree(mship->read_ranges);
Per Cederqvist's avatar
Per Cederqvist committed
922
923
924
925
926
927
928
929
930
931
932
    --pers_p->conferences.no_of_confs;
    while ( mship
	   < pers_p->conferences.confs + pers_p->conferences.no_of_confs )
    {
	*mship = *(mship + 1);
	++mship;
    }

    /* Delete from Conference */

    --conf_c->members.no_of_members;
933
    while ( mbr < conf_c->members.members + conf_c->members.no_of_members )
Per Cederqvist's avatar
Per Cederqvist committed
934
    {
935
936
	*mbr = *(mbr + 1);
	++mbr;
Per Cederqvist's avatar
Per Cederqvist committed
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
    }

    mark_person_as_changed( pers_no );
    mark_conference_as_changed( conf_no );
    
    return OK;    
}


/*
 * VICTIM is a person or a conference.
 * Meaning of return values:
 *	unlimited: ACTPERS is supervisor of VICTIM, or ACTPERS is admin,
 *		   or ACTPERS is VICTIM
 *	none:	   VICTIM is secret, and ACTPERS is not a member
 *	member:	   ACTPERS is a member in VICTIM, but doesn't have unlimited
 *		   access.
 *	read_protected: The conference is rd_prot and ACTPERS is not a member.
 *	limited:   otherwise.
 *	error:	   see kom_errno
 */

959
static enum access
960
961
access_perm_helper(Conf_no victim,
		   const Connection *conn,
962
		   enum access wanted_access)
Per Cederqvist's avatar
Per Cederqvist committed
963
{
964
    Conf_type   victim_type;
965
    int         victim_type_known = 0;
966
    static int  maxwarnings = 10;
967
968
969
970
971
972
973

    if (!cached_conf_exists(victim))
    {
        kom_errno = KOM_UNDEF_CONF;
        err_stat = victim;
	return error;
    }
David Byers's avatar
Server    
David Byers committed
974

975
    if (victim == conn->pers_no)
Per Cederqvist's avatar
Per Cederqvist committed
976
977
    	return unlimited;

978
    if (ENA_C(conn, admin, 2) || ENA_C(conn, wheel, 8))
Per Cederqvist's avatar
Per Cederqvist committed
979
980
    	return unlimited;

981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
    if (wanted_access <= limited)
    {
	victim_type = cached_get_conf_type(victim);
	victim_type_known = 1;

	if (victim_type.secret == 0)
	{
	    if (victim_type.rd_prot)
	    {
		if (wanted_access <= read_protected)
		    return read_protected;
	    }
	    else
		return limited;
	}
    }

998
    if (is_supervisor(victim, conn))
Per Cederqvist's avatar
Per Cederqvist committed
999
1000
    	return unlimited;

1001
    if (conn->pers_no != 0)
1002
    {
1003
	if (conn->person == NULL)
1004
1005
1006
	{
	    if (maxwarnings > 0)
	    {
1007
		kom_log("WNG: conn->person unexpectedly NULL in "
1008
1009
1010
1011
			"access_perm_helper()\n");
		if (--maxwarnings == 0)
		    kom_log("WNG: Won't log the above warning any more.\n");
	    }
1012
1013
1014
	    kom_errno = KOM_INTERNAL_ERROR;
	    err_stat = 0;
	    return error;
1015
	}
1016

1017
1018
	/* FIXME (bug 155): no need to call the expensive
	   locate_membership if supervisor(victim) == victim. */
1019
	if (locate_membership(victim, conn->person) != NULL)
1020
1021
	    return member;
    }
Per Cederqvist's avatar
Per Cederqvist committed
1022

1023
1024
    if (victim_type_known == 0)
	victim_type = cached_get_conf_type(victim);
1025

1026
    if (victim_type.secret)
Per Cederqvist's avatar
Per Cederqvist committed
1027
1028
        return none;

1029
    if (victim_type.rd_prot)
Per Cederqvist's avatar
Per Cederqvist committed
1030
1031
1032
1033
1034
1035
	return read_protected;
    
    return limited;
}


1036
enum access
1037
1038
access_perm(Conf_no victim,
	    const Connection *viewer_conn,
1039
	    enum access wanted_access)
1040
{
1041
    enum access result;
1042

1043
    if (wanted_access != read_protected
1044
1045
	&& wanted_access != limited
	&& wanted_access != unlimited)
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
    {
	static int ctr = 0;
	if (ctr < 10)
	{
	    kom_log("WNG: access_perm called with wanted_access=%d\n",
		    (int)wanted_access);
	    ctr++;
	    if (ctr == 10)
		kom_log("WNG: won't log the above warning any more.\n");
	}
    }

1058
    result = access_perm_helper(victim, viewer_conn, wanted_access);
1059
1060
1061
1062
1063
1064
1065
1066

    if (wanted_access < result)
	return wanted_access;
    else
	return result;
}


1067
1068
1069
1070
1071
1072
1073
1074
1075
Bool
has_access(Conf_no victim,
	   const Connection *viewer_conn,
	   enum access wanted_access)
{
    return access_perm(victim, viewer_conn, wanted_access) >= wanted_access;
}


1076
1077
1078
1079
Conf_no
filter_conf_no(Conf_no victim,
	       const Connection *viewer_conn)
{
1080
    if (has_access(victim, viewer_conn, read_protected))
1081
1082
1083
1084
1085
	return victim;
    else
	return 0;
}

1086

Per Cederqvist's avatar
Per Cederqvist committed
1087
1088
1089
1090
1091
1092
1093
1094
/*
 * Locate the Member struct in CONF_C for person PERS_NO
 */

Member *
locate_member(Pers_no      pers_no,
	      Conference * conf_c)
{
1095
    Member * mbr;
Per Cederqvist's avatar
Per Cederqvist committed
1096
1097
    int      i;

1098
1099
    for(mbr = conf_c->members.members, i = conf_c->members.no_of_members;
	i > 0; i--, mbr++)
Per Cederqvist's avatar
Per Cederqvist committed
1100
    {
1101
	if ( mbr->member == pers_no )
Per Cederqvist's avatar
Per Cederqvist committed
1102
	{
1103
	    return mbr;
Per Cederqvist's avatar
Per Cederqvist committed
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
	}
    }

    return NULL;
}


/*
 * Find the data about PERS_P:s membership in CONF_NO.
 * Return NULL if not found
 */

Membership *
1117
1118
locate_membership(Conf_no       conf_no,
                  const Person *pers_p)
Per Cederqvist's avatar
Per Cederqvist committed
1119
1120
1121
1122
1123
1124
1125
1126
1127
{
    Membership * confp;
    int    i;

    for(confp = pers_p->conferences.confs, i = pers_p->conferences.no_of_confs;
	i > 0; i--, confp++)
    {
	if ( confp->conf_no == conf_no )
	{
1128
            confp->position = pers_p->conferences.no_of_confs - i;
Per Cederqvist's avatar
Per Cederqvist committed
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
	    return confp;
	}
    }

    return NULL;
}

/*
 * Atomic functions.
 */

/*
 * Unsubscribe from a conference.
 *
 * You must be supervisor of either conf_no or pers_no to be allowed to
 * do this.
 */
extern Success
sub_member(	Conf_no		conf_no,
		Pers_no		pers_no )
{
    Conference  * conf_c;
    Membership	* mship;
    Person	* pers_p;
    
David Byers's avatar
Server    
David Byers committed
1154
    CHK_CONNECTION(FAILURE);
Per Cederqvist's avatar
Per Cederqvist committed
1155
1156
1157
    CHK_LOGIN(FAILURE);
    GET_C_STAT(conf_c, conf_no, FAILURE);

1158
    if ((pers_p = cached_get_person_stat(pers_no)) == NULL)
Per Cederqvist's avatar
Per Cederqvist committed
1159
    {
1160
1161
1162
	/* If the conference is secret, we have to return an error
	   code for the conference instead of for the person. */

1163
	if (!has_access(conf_no, active_connection, read_protected))
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
	{
	    kom_errno = KOM_UNDEF_CONF;
	    err_stat = conf_no;
	}
	return FAILURE;
    }

    if ((mship = locate_membership(conf_no, pers_p)) == NULL
	|| membership_visible(active_connection, pers_no, conf_no, 
			      mship->type, FALSE, FALSE) == mv_none)
    {
	/* FIXME (bug 707): If the person is secret, and the viewer
	   has no access to it, we should return KOM_UNDEF_PERS
	   instead of KOM_NOT_MEMBER. */
	set_conf_errno(active_connection, conf_no, KOM_NOT_MEMBER);
Per Cederqvist's avatar
Per Cederqvist committed
1179
1180
1181
	return FAILURE;
    }

1182
1183
1184
1185
    if (!is_supervisor(conf_no, active_connection)
	&& !is_supervisor(pers_no, active_connection)
	&& !ENA(wheel,8)        /* OK -- In an RPC call */
	&& !ENA(admin, 4) )	/* OK -- in an RPC call */
Per Cederqvist's avatar
Per Cederqvist committed
1186
    {
1187
	set_conf_errno(active_connection, conf_no, KOM_PERM);
Per Cederqvist's avatar
Per Cederqvist committed
1188
1189
1190
	return FAILURE;
    }

David Byers's avatar
David Byers committed
1191
1192
1193
1194
    return do_sub_member(conf_no, conf_c, NULL, pers_no, pers_p, mship);
}


Per Cederqvist's avatar
Per Cederqvist committed
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
/*
 * Add a member to a conference (join a conference) or
 * Change the priority of a conference.
 *
 * Anyone may add anyone as a member as long as the new member is not
 * secret and the conference is not rd_prot. This might be a bug.
 *
 * PRIORITY is the assigned priority for the conference. WHERE says
 * where on the list the person wants the conference. 0 is first. WHERE
 * is automatically set to the number of conferences that PERS_NO is member
 * in if WHERE is too big, so it is not an error to give WHERE == ~0 as
 * a parameter.
 *
 * You can only re-prioritize if you are supervisor of pers_no.
 */
1210

David Byers's avatar
David Byers committed
1211
1212
1213
static Success
add_member_common(Conf_no              conf_no,
                  Pers_no              pers_no,
1214
1215
                  unsigned char        priority,
                  unsigned short       where,		/* Range of where is [0..] */
David Byers's avatar
David Byers committed
1216
1217
1218
                  Membership_type     *type,
                  Bool                 fake_passive
    )
Per Cederqvist's avatar
Per Cederqvist committed
1219
{
1220
    Conference  * conf_c;
Per Cederqvist's avatar
Per Cederqvist committed
1221
1222
1223
    Person	* pers_p;
    Membership	* mship;

David Byers's avatar
Server    
David Byers committed
1224
    CHK_CONNECTION(FAILURE);
Per Cederqvist's avatar
Per Cederqvist committed
1225
1226
1227
1228
    CHK_LOGIN(FAILURE);
    GET_C_STAT(conf_c, conf_no, FAILURE);
    GET_P_STAT(pers_p, pers_no, FAILURE);

David Byers's avatar
David Byers committed
1229
    /* Force invitation bit if not adding as admin or supervisor */
1230
1231
1232
    if (param.invite_by_default
	&& !is_supervisor(pers_no, active_connection)
	&& !ENA(admin, 2))	/* OK -- Guarded */
1233
1234
1235
1236
    {
        type->invitation = 1;
    }

David Byers's avatar
David Byers committed
1237
1238
1239
    /* Check if secret membership bit is set and allowed */
    if (type->secret &&
        (!param.secret_memberships || conf_c->type.forbid_secret))
1240
1241
1242
1243
1244
1245
    {
        err_stat = 0;
        kom_errno = KOM_INVALID_MEMBERSHIP_TYPE;
        return FAILURE;
    }

David Byers's avatar
David Byers committed
1246
    /* Check access to the conference. We need limited access or more */
1247
    if (!has_access(conf_no, active_connection, limited)
David Byers's avatar
Server    
David Byers committed
1248
	&& !ENA(wheel, 8) )     /* OK -- Guarded */
Per Cederqvist's avatar
Per Cederqvist committed
1249
    {
1250
        err_stat = conf_no;
1251
	kom_errno = (conf_c->type).secret ? KOM_UNDEF_CONF : KOM_ACCESS;
Per Cederqvist's avatar
Per Cederqvist committed
1252
1253
1254
1255
1256
1257
1258
	return FAILURE;
    }

    /* Is he already a member? */

    if ( (mship = locate_membership( conf_no, pers_p )) != NULL)
    {
David Byers's avatar
David Byers committed
1259
1260
        Bool pers_supervisor;
        Bool conf_supervisor;
Per Cederqvist's avatar
Per Cederqvist committed
1261

1262
1263
        pers_supervisor = is_supervisor(pers_no, active_connection);
        conf_supervisor = is_supervisor(conf_no, active_connection);
David Byers's avatar
David Byers committed
1264
1265

        /* Already a member, but a secret member? */
1266
1267
1268
        if (mship->type.secret &&
            !pers_supervisor &&
            !conf_supervisor &&
David Byers's avatar
Server    
David Byers committed
1269
1270
            !ENA(admin,2) &&    /* OK -- Guarded */
            !ENA(wheel,8))      /* OK -- Guarded */
David Byers's avatar
David Byers committed
1271
        {
1272
            /* FIXME (bug 156): This leaks secret information */
David Byers's avatar
David Byers committed
1273
1274
1275
1276
1277
1278
1279
1280
            /* The person is already a member, but we are not allowed
               to know this. Pretend that the addition worked, and hope
               that the user does not double-check */

            return OK;
        }

	/* He is already a member. Only change the priority. */
1281
	if( !pers_supervisor &&
David Byers's avatar
Server    
David Byers committed
1282
            !ENA(admin,2) && 
1283
            !ENA(wheel, 8) )
1284
1285
	{
	    /* Noone else can change one's priorities. */
1286
            err_stat = pers_no;
Per Cederqvist's avatar
Per Cederqvist committed
1287
1288
1289
1290
	    kom_errno = KOM_PERM;
	    return FAILURE;
	}

David Byers's avatar
David Byers committed
1291
1292
1293
1294
	do_change_priority( mship, conf_no, conf_c,
                            priority, where, pers_no, pers_p,
                            type, fake_passive );

Per Cederqvist's avatar
Per Cederqvist committed
1295
1296
1297
    }
    else
    {
1298
	if (pers_no != ACTPERS)
1299
        {
David Byers's avatar
David Byers committed
1300
	    kom_log("Person %lu added to conference %lu by %lu.\n",
1301
1302
1303
		(unsigned long)pers_no,
		(unsigned long)conf_no,
		(unsigned long)ACTPERS);
1304
        }
1305

David Byers's avatar
Server    
David Byers committed
1306
	do_add_member(conf_no, conf_c, pers_no, pers_p, ACTPERS,
David Byers's avatar
David Byers committed
1307
1308
                      priority, where, type, fake_passive);

David Byers's avatar
David Byers committed
1309
        send_async_new_membership(pers_no, conf_no);
Per Cederqvist's avatar
Per Cederqvist committed
1310
1311
1312
1313
1314
    }

    return OK;
}

David Byers's avatar
David Byers committed
1315
1316
1317
1318
1319
1320
1321
1322
1323

extern Success
add_member_old(Conf_no	conf_no,
               Pers_no	pers_no,
               unsigned char	priority,
               unsigned short	where)
{
    Membership_type type;

David Byers's avatar
Server    
David Byers committed
1324
    /* CHK_CONNECTION in add_member_common */
1325
    set_membership_type_bits(&type, 0,0,0,0,0,0,0,0);
David Byers's avatar
David Byers committed
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
    return add_member_common(conf_no, pers_no, priority, where, &type, TRUE);
}


extern Success
add_member(Conf_no	conf_no,
           Pers_no	pers_no,
           unsigned char	priority,
           unsigned short	where,		/* Range of where is [0..] */
           Membership_type     *type
           )
{
David Byers's avatar
Server    
David Byers committed
1338
    /* CHK_CONNECTION in add_member_common */
David Byers's avatar
David Byers committed
1339
1340
1341
1342
    return add_member_common(conf_no, pers_no, priority, where, type, FALSE);
}


Per Cederqvist's avatar
Per Cederqvist committed
1343
1344
1345
1346
#ifdef DEBUG_MARK_AS_READ
static int
check_membership(Pers_no pno,
		 const Conference *conf,
1347
		 Membership *mship)
Per Cederqvist's avatar
Per Cederqvist committed
1348
{
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
    static int log_no = 0;

    int errors = 0;
    struct read_range *begin;
    struct read_range *end;
    struct read_range *ptr;

    if (mship->no_of_read_ranges == 0 && mship->read_ranges != NULL)
    {
	if (log_no <