ChangeLog 155 KB
Newer Older
1 2 3 4 5 6 7 8
1999-05-21  Per Cederqvist  <ceder@lysator.liu.se>

	Remove all gcov files in "make mostlyclean".
	* src/server/testsuite/Makefile.am (MOSTLYCLEANFILES): Added "*.da",
	"*.bb", "*.gcov" and "*.bbg".
	* src/libraries/libmisc/Makefile.am: Likewise.
	* src/libraries/libcommon/Makefile.am: Likewise.

David Byers's avatar
David Byers committed
9 10 11 12 13 14 15 16
1999-05-21  David Byers  <davby@ida.liu.se>

	* doc/lyskomd.texi (Adding New Input Types): Document the fact
	that you have to free data in prot_a_destruct as well.

	* src/server/prot-a.c (prot_a_destruct): Free num_lists in the
	client structure.
	
17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
1999-05-21  Per Cederqvist  <ceder@paragon.signum.se>

	Don't lock the database when dbck is running in read-only mode.
	* src/server/dbck.c (iflag): Now static.
	(rflag): Now static.
	(gflag): Now static.
	(sflag): Now static.
	(force_output): Now static.
	(unset_change_name_is_error): Now static.
	(dump_text_numbers): Now static.
	(main): Only lock the database when dbck might want to change it.
	Added a missing break statement.  Mark the database as modified if
	any of --pres-pres-conf, --conf-pres-conf, --motd-conf,
	--motd-of-kom or --kom-news-conf is used.

David Byers's avatar
David Byers committed
32 33
1999-05-21  David Byers  <davby@ida.liu.se>

34 35
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added null.exp 

David Byers's avatar
David Byers committed
36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139
	* doc/lyskomd.texi: Merged lyskomdb.texi into this document. 

	* src/server/server-config.c: Unassign the lockfile name.

	* doc/Makefile.am (info_TEXINFOS): Removed deleted files.
	(EXTRA_DIST): Removed deleted files from EXTRA_DIST.

	* src/server/conf-file.c (unassign_string): New function.

	* src/server/conf-file.h (parameter): Added a free function.

	* src/server/simple-cache.c (free_all_cache): Free the
	small_conf_arr.

	* src/server/ramkomd.c (dump_exit_statistics): Moved remaining
	frees from main to here.

1999-05-20  David Byers  <davby@ida.liu.se>

	* src/server/testsuite/config/unix.exp: You can now supply
	MEMTRACE, ATTACH and EFENCE algorithms on the runtest command
	line.

	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added new leak
	tests to EXTRA_DIST.

	Eliminated memory leaks in aux-item definition parser
	* src/server/aux-items.c (free_aux_item_definitions): Free each
	individual aux item definition. Another memory leak down the
	drain.

	* src/server/aux-item-def-parse.y: Free the string of an ID
	parameter when we see one. Another memory leak bites the dust.

	* src/server/aux-items.c (aux_item_definition_cache_regexp): Plug
	a really minor (constant size) memory leak.

	* src/server/aux-item-def-parse.y: Use string_free to free stuff
	allocated with s_crea_c_str.

	* src/server/aux-items.c (aux_item_trigger_link_item): Use
	string_free to free string allocated with s_crea_c_str.
	(free_aux_item_definitions): Same here.

1999-05-19  David Byers  <davby@ida.liu.se>

	* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Clear
	the dummy aux item after parsing it. Memory leak plugged.

	* src/server/memory.c (clear_aux_item): New function.
	(free_aux_item_list): Use it.

	* src/server/prot-a-parse.c (prot_a_parse_num_list): Handle
	truncation so protocol errors during truncation will not break the 
	server.
	(prot_a_hunt_nl): Same here.
	(prot_a_parse_aux_item_list): Same here.

	* src/server/prot-a.c (prot_a_init): Initialize
	array_parse_parsed_length

	* src/server/internal-connections.c (init_connection): Initialize
	array_parse_parsed_length

	* src/server/connections.c (free_parsed): Initialize
	array_parse_parsed_length.

	* src/server/connections.h (Connection): Added
	array_parse_parsed_length

	* src/server/fncdef.txt: Truncate strings in set_client_version to 
	client_data_len.

	* src/server/ramkomd.c (main): Free aux-item definitions on exit.

	* src/server/aux-items.c (free_aux_item_definitions): New function
 	to free all data associated with aux-item defs.

	* src/server/ramkomd.c (main): Free aux-item definition.

1999-05-18  David Byers  <davby@ida.liu.se>

	* src/server/prot-a-parse.c (prot_a_parse_aux_item_flags): Handle
	variable-length bitfields.

	* src/server/memory.c (init_aux_item_flags): New function.

	* src/server/prot-a-parse.c (prot_a_parse_priv_bits): Handle
 	variable-length bitfields.
	(prot_a_parse_membership_type): Same here.
	(prot_a_parse_conf_type): Same here.

	* src/server/memory.c (init_membership_type): New function.

	* doc/Protocol-A.texi (set-client-version): Added list of known
	clients.

	* ChangeLog.1: Inserted doc/LOGG

	* doc/LOGG: Added to ChangeLog.1

	* src/server/conference.c (set_supervisor): Use
	is_strictly_supervisor instead of is_supervisor.

140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158
1999-05-21  Per Cederqvist  <ceder@gratia>

	Lock the database file with an explicit lock file.
	* src/server/dbck.c (main): Lock and unlock the database.
	* src/server/ramkomd.c (init_data_base): Log the name of the lock
	file.
	(initialize): Lock the database before opening it.
	(main): Unlock the database.
	* src/server/server-config.c (parameters): Added "Lock file".
	(read_configuration): Handle param.lockfile_name.
	* src/server/param.h (struct kom_par): Added lockfile_name.
	* src/server/Makefile.am (lyskomd_SOURCES): Added lockdb.h and
	lockdb.c.
	(DBCK): Likewise.
	* src/server/lockdb.c, src/server/lockdb.h: New files.
 	(lock_db): New function.
	(unlock_db): New function.
	* doc/lyskomd.texi (Parameters): Document "Lock file:".

159 160 161 162 163 164 165 166 167 168
1999-05-20  Per Cederqvist  <ceder@signum.se>

	Clean up the framework for hunting memory leaks.
	* src/server/ram-smalloc.c: Document --with-traced-allocations.
	* src/server/realloc.gdb: File removed.
	* src/server/malloc.gdb: File removed.
	* src/server/free.gdb: File removed.
	* src/server/Makefile.am (EXTRA_DIST): Removed free.gdb,
	malloc.gdb and realloc.gdb.

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204
1999-05-20  Per Cederqvist  <ceder@gratia>

	dbck failed to handle bcc_recpts.
	* src/libraries/libcommon/misc-parser.c (parse_next_misc): Handle
	bcc_recpt.  Fix usage of the COMPILE_CHECKS macro.

	Fix usage of the COMPILE_CHECKS macro.
	* src/server/text.c (find_recipient): Fix usage of the
 	COMPILE_CHECKS macro.
	(is_member_in_recpt): Likewise.
	(do_delete_misc): Likewise.
	(do_sub_recpt): Likewise.
	(sender): Likewise.
	(is_sender): Likewise.
	(is_comm_sender): Likewise.
	(skip_recp): Likewise.
	(recp_sent_by): Likewise.
	(filter_secret_info): Likewise.
	(do_delete_text): Likewise.
	(check_double_subm): Likewise.
	(check_double_comm): Likewise.
	(create_text_add_miscs): Likewise.
	* src/server/text-garb.c (garb_text): Fix usage of the
 	COMPILE_CHECKS macro.
	* src/server/ram-output.c (foutput_misc_info): Fix usage of the
 	COMPILE_CHECKS macro.
	* src/server/prot-a-output.c (prot_a_output_misc_info): Fix usage
 	of the COMPILE_CHECKS macro.
	* src/server/dbck.c (delete_misc): Fix usage of the
	COMPILE_CHECKS macro.
	(is_recipient): Likewise.

	Code cleanup.
	* src/include/kom-types.h: Removed code within #ifdef PROT_a.  It
	was never used, and is obsoleted by aux-items.

Per Cederqvist's avatar
Per Cederqvist committed
205 206 207 208
1999-05-19  Per Cederqvist  <ceder@signum.se>

	* NEWS: We document in Texinfo, not info.

209 210 211 212 213 214 215 216 217 218 219 220
1999-05-18  Per Cederqvist  <ceder@gratia>

	Avoid ".*" in regexps in the test suite, since they can easily
	match too much.
	* src/server/testsuite/lyskomd.0/06.exp: Use "$hollerith" instead
 	of a hard-coded regexp, to avoid parsing past newlines.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/04.exp: Use "$any" instead of "."
	to match any character, to avoid parsing past newlines.
	* src/server/testsuite/lyskomd.0/membership-cov.exp: Likewise.

Per Cederqvist's avatar
Per Cederqvist committed
221 222 223 224 225 226 227
1999-05-18  Per Cederqvist  <ceder@lysator.liu.se>

	Increase coverage.
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
	lyskomd.0/08.exp.
	* src/server/testsuite/lyskomd.0/08.exp: New file.

David Byers's avatar
David Byers committed
228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259
1999-05-18  David Byers  <davby@ida.liu.se>

	* doc/lyskomd.texi: Merged dbck.texi and hacking.texi into
	lyskomd.texi.

	* src/server/testsuite/lyskomd.0/03.exp: Updated
	query-predefined-aux-items result.

	* src/server/testsuite/lyskomd.0/01.exp: Updated
	query-predefined-aux-items result.

	* src/server/aux-items.c (undelete_aux_item_list): Fixed
	conference/text mixup
	(delete_aux_item_list): Same here.
	(undelete_aux_item_list): Save kom_errno and err_stat across call.

	* src/server/aux-item-def-parse.y: Deal with disabled definitions
	in a more sensible manner.

	* src/server/aux-items.c (aux_item_add_perm): Check the disabled
	field of the aux-item definition.

	* src/server/aux-items.h: Added disabled field.

1999-05-17  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (aux_item_list_add_items): New utility
	function.
	(system_add_aux_item_list): Use aux_item_list_add_items.
	(text_stat_add_aux_item_list): Use aux_item_list_add_items.
	(conf_stat_add_aux_item_list): Use aux_item_list_add_items.

260 261
1999-05-16  Per Cederqvist  <ceder@lysator.liu.se>

262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314
	Use a global variable to store the current time, so that it is
	never changes during an atomic call, and so that we don't call
	time() more than once per call.
	* src/server/server-time.h: New file.
	* src/server/ramkomd.c (main): Initialize current_time.
	* src/server/connections.c (milli_timevaldiff): Removed.
	(dump_statistics): Use current_time instead of calling time().
	(toploop): Call time once per select loop instead of calling
	gettimeofday twice.  Simplify the computation of the timeout.
	* src/server/conference.c (do_create_conf): Use current_time
	instead of time().
	* src/server/text.c (add_text_in_conf): Use current_time instead
	of calling time().
	(do_create_text): Likewise.
	(add_recipient): Likewise.
	(add_footnote): Likewise.
	(add_comment): Likewise.
	(create_text_add_miscs): Removed the now argument.  All callers
	updated.  User current_time instead of now.
	* src/server/text-garb.c (garb_text): Use current_time instead of
	calling time().
	* src/server/simple-cache.c (sync_part): Use current_time instead
	of calling time().
	(init_cache): Likewise.
	* src/server/session.c (leave_conf): Use current_time instead of
	calling time().
	(login_old): Likewise.
	(login): Likewise.
	(logout): Likewise.
	(who_is_on_dynamic): Likewise.
	(get_session_info): Likewise.
	(get_session_info_ident): Likewise.
	(get_time): Likewise.
	(user_active): Likewise.
	* src/server/send-async.c (async_rejected_connection): Use
	current_time instead of calling time().
	* src/server/person.c (create_person_generic): Use
	current_time instead of calling time().
	* src/server/membership.c (do_add_rec_time): Use
	current_time instead of calling time().
	(do_add_member): Likewise.
	* src/server/internal-connections.c (init_connection): Use
	current_time instead of calling time().
	(new_client): Likewise.
	* src/server/aux-items.h: (prepare_aux_item_list): Removed the
	"now" argument.
	(prepare_aux_item): Likewise.
	* src/server/aux-items.c (prepare_aux_item_list): Removed the
	"now" argument.  Use current_time instead.  Call callers updated.
	(prepare_aux_item): Likewise.
	* src/server/admin.c (modify_server_info): Don't pass the current
	time to prepare_aux_item_list.

315 316 317 318 319 320 321 322 323
	Document updateLysKOM and komrunning.  Make them accept -v/-V.
	* doc/lyskomd.texi: Removed all up, next and prev pointers.
	(Invoking updateLysKOM): New node.
	(Invoking komrunning): New node.
	* src/server/updateLysKOM.c (main): Use PACKAGE and VERSION (from
	config.h) when reporting the version number.
	* src/server/komrunning.c (usage): Accept -v and -V.
	(main): Likewise.
	
324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
	The test suite now fails without having to wait for a timeout if a
	wrong result with the proper ref-no is returned.
	* src/server/testsuite/config/unix.exp (MEMTRACE): Default to
	/dev/null.
	(simple_expect): Recognize attempts to match protcol-A replies,
	and fail without a timeout if the correct reference number is
	returned with bogus data.

	Fix "make dist".
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
	lyskomd.0/07.exp, lyskomd.0/broken-aux-items.conf,
	lyskomd.0/cache-node-cov.exp, lyskomd.0/conf-file-cov.exp,
	lyskomd.0/conference-cov.exp, lyskomd.0/connections-cov.exp,
	lyskomd.0/disk-end-of-atomic-cov.exp,
	lyskomd.0/internal-connections-cov.exp,
	lyskomd.0/isc-parse-cov.exp, lyskomd.0/log-cov.exp,
	lyskomd.0/membership-cov.exp, lyskomd.0/memory-cov.exp,
	lyskomd.0/person-cov.exp, lyskomd.0/prot-a-parse-cov.exp,
	lyskomd.0/prot-a-send-async-cov.exp, lyskomd.0/send-async-cov.exp,
	lyskomd.0/session-cov.exp and lyskomd.0/text-cov.exp.
	* src/server/Makefile.am (komrunning_SOURCES): Added pidfile.h.
	(updateLysKOM_SOURCES): Added pidfile.h.
	(lyskomd_SOURCES): Added trace-alloc.h.

348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
	Fix the framework for hunting memory leaks.
	* configure.in: Handle --with-traced-allocations.
	* acconfig.h (TRACED_ALLOCATIONS): New define.
	* src/server/trace-alloc.h: New file.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Handle
	TRACED_ALLOCATIONS.
	(lyskomd_fail_start): Likewise.
	* src/server/ramkomd.c (main): Call trace_alloc_file very early
	during startup if compiled with TRACED_ALLOCATIONS.
	* src/server/ram-smalloc.c: Test TRACED_ALLOCATIONS instead of
	DEBUG_MALLOC.
	(trace_alloc_file): New function, that sets up malloc_fp.
	(trace_smalloc): Write to malloc_fp.
	(trace_free): Likewise.
	(srealloc): Likewise.
	* src/server/ram-smalloc.c: Don't test USE_GNU_MALLOC; that symbol
	was removed 1998-08-09.

David Byers's avatar
David Byers committed
366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383
1999-05-16  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (prepare_aux_item): Don't clear the link
	field of the aux item.
	(aux_inherit_items): Clear the link in the copied item before
	calling add triggers.
	(aux_item_link_items): New function.
	(aux_item_trigger_mirror_faq): Use aux_item_link_items.
	(aux_item_trigger_link_item): Use aux_item_link_items.
	(aux_item_call_add_triggers): Fix the trigger data after calling
	each trigger since one of them might move the aux item list in 
	memory.

1999-05-15  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (aux_item_trigger_link_item): New
	function for debugging linking aux items.

Per Cederqvist's avatar
Per Cederqvist committed
384 385 386 387 388 389 390 391 392 393 394 395 396
1999-05-14  Per Cederqvist  <ceder@lysator.liu.se>

	Fixes to the test suite.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: A client
	dies immediately when it receives %% No connections left, so the
	test case should not expect it to live longer.  Renumber the
	ref-nos.  The nologin file exists in the build directory, not in
	srcdir.
	* src/server/testsuite/leaks.0/leaks02.exp: Don't forget the flags
	argument to create-person.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Don't attempt
	to use debug calls unless debug_calls is true.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Likewise.
Per Cederqvist's avatar
Per Cederqvist committed
397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
	* src/server/testsuite/lyskomd.0/person-cov.exp: Look for
	config/prot-a.exp in srcdir.  Don't fail if the clock ticks.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Look for
	config/prot-a.exp in srcdir.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/membership-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/session-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/text-cov.exp: Likewise.
	* src/server/testsuite/config/unix.exp (timeout): Don't alter the
	default value.  Not every computer is fast computer.
	(lyskomd_start): The aux-item config file is found relative to
	$srcdir, not [pwd].  The config/lyskomd-config file is found
	relative to the current working directory.
	(lyskomd_fail_start): Likewise.  Find the database files relative
	to top_srcdir.
Per Cederqvist's avatar
Per Cederqvist committed
415

David Byers's avatar
David Byers committed
416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525
1999-05-14  David Byers  <davby@ida.liu.se>

	* src/server/text.c (do_create_text): Return long-array if there
	are too many misc items.
	(modify_text_info): Set err_stat to max length when returning
	KOM_LONG_ARRAY.

	* src/include/kom-types.h (Info_datum): Added unknown_type to
	union.

	* src/server/text.c (find_recipient): Add unknown_info to the
	switch. Stop the server if COMPILE_CHECKS is undefined.
	(is_member_in_recpt): Same here.
	(do_delete_misc): Same here.
	(do_sub_recpt): Same here.
	(sender): Same here.
	(is_sender): Same here.
	(is_comm_sender): Same here.
	(skip_recp): Same here.
	(recp_sent_by): Same here.
	(filter_secret_info): Same here.
	(do_delete_text): Same here. 
	(check_double_subm): Same here.
	(check_double_comm): Same here.
	(create_text_check_misc): Return an illegal-info-typye if we see
	an unknown info. Set err_stat to the index of the bad item when
	returning a KOM_ILL_MISC.
	(create_text_add_miscs): Same here.

	* src/server/prot-a.c (prot_a_destruct): Free the misc_info_list
	field of the connection.

	* src/server/membership.c (add_rec_time): Handle unknown_info and
	other unknown misc info types by shutting down the server.

	* src/server/call-switch.awk: Add support for misc_info_list in
	fncdef.txt.

	* src/server/text.c (create_text_old): Changed parameter list to
	use Misc_info_list instead of an integer and a Misc_info pointer.
	(create_text): Same here.
	(create_anonymous_text): Same here.
	(create_anonymous_text_old): Same here.

	* src/server/fncdef.txt: Changed all "num c_misc_info_p" to
	misc_info_list. 

	* src/server/prot-a-parse-arg-c.awk: The aux_item type works again.
	Allow misc_info_list as a type name.

	* src/server/prot-a-parse.c (prot_a_parse_misc_info_list): New
	function. 

	* src/server/prot-a.c (prot_a_init): Initialize the misc_info_list 
	field.

	* src/server/internal-connections.c (kill_client): Use
	misc_info_list field of Connection.

	* src/server/connections.c (free_parsed): Clear the misc_info_list 
	field.

	* src/include/kom-types.h (Misc_info_list): New type

	* src/server/internal-connections.c (init_connection): Initialize
	hunt_parse_pos, array_hunt_depth and array_hunt_num. Initialize
	misc_info_list. 

	* src/server/prot-a-parse.c (prot_a_hunt_array_end): New function
	hunts for the end of an array.c

	* src/server/prot-a.c (prot_a_init): Initialize hunt_parse_pos and 
	array_hunt_num.


	* src/include/kom-types.h (Info_type): Added unknown info type. 

	* src/server/prot-a-parse.c (prot_a_parse_misc_info): Parse all
	misc-info types that the server knows about. Unknown types
	generate a protocol error.

	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp (1021):
	Expcet long-array and not protocol-error.

	* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Discard
	the part of the list that is longer than the max rather than send
	a protocol error.

1999-05-13  David Byers  <davby@ida.liu.se>

	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp
	(protocol_error): Removed expected failure.

	* src/server/admin.c (modify_server_info): Return KOM_LONG_ARRAY
 	when we see a long array.

	* src/server/conference.c (modify_conf_info): Return
 	KOM_LONG_ARRAY when we see a long array.

	* src/server/text.c (modify_text_info): Return KOM_LONG_ARRAY when 
	we see a long array.

	* src/server/prot-a-parse.c (prot_a_parse_num_list): Truncate a
	parsed array to one more than the maximum length and skip all
	other elements.

	* src/server/aux-items.c (undelete_aux_item_list): Log if the link 
	type is undefined and do not attempt to undelete.
	(delete_aux_item_list): Likewise.

526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
1999-05-13  Per Cederqvist  <ceder@gratia>

	Distribute the leaks tests, and run them during "make check".
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Track the rename
	of lyskoms.0/leaks*.exp -> leaks.0/leaks*.exp.
	(check): Depend on check-leaks.
	(check-leaks): New target.

	Code cleanup/minor bugs fixed.
	* src/server/testsuite/tcpconnect.py: socket.recv can raise
	socket.error!  Handle it as end-of-file.
	* src/server/simple-cache.c (cached_conf_exists): Removed the
	unused variable node.
	* src/server/aux-items.c (find_linked_aux_item_list): Don't use an
	uninitialized variable.
	(delete_aux_item_list): Fail if the default branch is reached.
	(undelete_aux_item_list): Fail if the default branch is reached.
	(aux_item_trigger_mirror_faq): Test data->object for NULLness
	intstead of the uninitialized variable conf_stat.
	* doc/hacking.texi (Linking Pairs of Aux Items): Texinfo problem
	fixed.
	* doc/Protocol-A.texi (set-info): Untabify.
	(accept-async): Untabify.
	(query-async): Untabify.

David Byers's avatar
David Byers committed
551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781
1999-05-12  David Byers  <davby@ida.liu.se>

	Stuff I forgot to add below

	* Renamed log to kom_log since log is a function in math.h.
	
	* src/include/services.h (set_pers_flags): New prototype. 
	(create_person): Added flags parameter.
	
	* run-support/config: Set defaults for max texts and max
	conferences.

	* run-support/aux-items.conf (faq-text): Removed all triggers. Set
 	add-trigger to link-faq, added validator.
	(faq-for-conf): New item definition.

	* doc/lyskomd.texi (Parameters): Added Max conferences, Max texts, 
	Max client data length, Nologin fle. Updated some other parameter
	descriptions.
	(Aux-Item Definition File): Added system-only. Rewrote validate to 
	allow function identifiers. Added list of validator functions and
	triggers.
	(Files): Document /etc/nologin.

	* doc/hacking.texi: Correct minor typos. Change some @code into
	@file.
	(Linking Pairs of Aux Items): New section.

	* doc/Protocol-A.texi: Correct minor typos
	(Predefined Aux-Item Types): Rephrase some
	of the text. Remove statement that faq-text item marks a text.
	Document faq-for-conf. Specify formate for mx-message-id. 
	(Simple Data Types): Removed documentation for INTEGER.
	(set-etc-motd): Change too-many-marks to mark-limit
	(mark-text-old): Change too-many-marks to mark-limit
	(set-conf-type): Correct documentation for secret-public error.
	Correct spelling in invalid-membership-type documentation.
	(add-recipient): Add documentation for access-denied error
	(add-comment): Define error-status in index-out-of-range.
	(sub-comment): Change no-comment to not-comment.
	(send-message): Complete documentation of message-not-sent error.
	(create-text): Add index-out-of-range as possible error.
	(create-conf): Complete doc of permission-denied error.
	(create-person): Added personal-flags parameter.
	(create-person): Document person-exists error.
	(set-pers-flags): New call.
	(Error Codes): Clarify message-not-sent and index-out-of-range.

	* configure.in: Added flag --with-insure++. Define AVOID_ABORTS
	when compiling with support for gcov.
	
	* src/server/testsuite/tcpconnect.py: Added #hose socket to hose
 	the socket with lots of zeroes.

	* src/server/testsuite/config/prot-a.exp: New functions
	kom_set_permitted_submitters, kom_set_super_conf, kom_login_old,
	kom_mark_text, kom_sub_recipient, kom_set_conf_type,
	kom_change_conference, kom_set_priv_bits.
	(kom_create_person): Send the pers_flags field.

	* src/server/testsuite/config/unix.exp: Print a dot for every test 
	case in verbose mode.
	(lyskomd_start): New parameters extra_config for additional config 
	file contents and base_config for basic config file contents
	(defaults will not be used.) Don't print defaults for max
	conferences or max texts if they are in extra_config. It is
	possible to start lyskomd with arbitrary arguments.
	(lyskomd_fail_start): Function to use when lyskomd is supposed to
	not start properly (like lyskomd_start, but server failue is
	expected.)
	(client_start_fail): New function like client_start, but failure
	is expected.
	(kill_client): Unset expect_active and expect_always instead of
	setting to the empty string.
	(hose_client): New function

	* src/server/testsuite/lyskomd.0/00.exp: Send pers-flags in calls
	to create-person.

	* src/server/testsuite/lyskomd.0/01.exp: Update expected results
	in query-predefined-aux-items. Send pers-flags in call to
	create-person. Add test for set-pers-flags. Add test for
	nonexistent call 107.

	* src/server/testsuite/lyskomd.0/02.exp: Send pers-flags in call
	to create-person.

	* src/server/testsuite/lyskomd.0/03.exp: Expect aux-item 28 in
	query-predefined-aux-items. Send pers-flags in call to
	create-person. Expect the faq-for-conf aux-item in test 1327.
	Expect failure attempting to set nonexistent text as faq (test
	1342.) Remove the now failed faq item in subsequent tests. Add
	test for set-pers-flags.

	* src/server/testsuite/lyskomd.0/04.exp: Send pers-flags in calls
	to kom_create_person.

	* src/server/testsuite/lyskomd.0/05.exp: Send pers-flags in calls
	to kom_create_person. Be more flexible when expecting time
	corresponding to time_t zero. Set garb and sync interval to
	something really high to avoid spurious async messages while
	running the tests.

	* src/server/testsuite/lyskomd.0/06.exp: Send pers-flags in calls
	to kom_create_person.

	* src/server/testsuite/lyskomd.0/admin-cov.exp: More setup to
	support new tests. Test that we can't send messages to secret
	confs. Test that messages are filtered for passive members.

	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Send
	pers-flags in calls to kom_create_person. Attempt to create
	aux-items with broken validation regexp. Test the system-only
	attribute. Test a broken aux-item config file.

	* src/server/testsuite/lyskomd.0/aux-items.cov: Add an item
	definition with system-only property.
	
	* src/server/prot-a-parse.h: Added prototype for
 	prot_a_parse_pers_flags
	
	* src/server/prot-a-parse.c (prot_a_parse_pers_flags): New
	function to parse pers flags.
	
	* src/server/prot-a-output.c (prot_a_output_text_mapping):
 	Initialize the fields of iter to avoid warnings from tools that
 	detect access to uninitialize memory.
	
	* src/server/local-to-global.c: Use kom_log instead of log.
	
	* src/server/kom-memory.c: Added prototypes for init_aux_item and
	init_aux_item_link. 
	
	* src/server/aux-items.c (system_check_add_aux_item_list): Call
	aux_item_add_perm with INFO_OBJECT_TYPE for the object_type
	parameter.

	* src/server/admin.c: Use kom_log instead of log everywhere. 
	(send_message): Do not permit sending group messages to secret
	conferences. Set errno to KOM_MESSAGE_NOT_SENT if there are no
	appropriate recipients.

	* src/server/aux-item-def-parse.y: Parse validation functions in
	addition to validation regexps. Use kom_log instead of log. Parse
	the system-only property.
	(aux_item_def_check_validate): New function.

	* src/server/aux-items.c: Add the aux-item being involved item
 	itself to aux-item trigger data.
	(aux_item_validate_existing_text): New validation function.
 	(aux_item_trigger_mirror_faq): New add trigger function
 	(aux_item_trigger_unmark_text): Modified to work for aux-items on
 	texts and conferences, not just conferences. Do not unmark an
 	unmarked text.
	(aux_item_trigger_mark_text): Do not add more marks than
 	permitted.
	(find_aux_item_index): New function to find the index of an item
	with a particular number in an aux item list.
	(commit_aux_item_list): Renamed to commit_aux_item_list_internal.
	(commit_aux_item_list_internal): Delete linked aux items.
	(commit_aux_item_list): Wrapper for commit_aux_item_list_internal.
	(delete_aux_item_list): Manage deletion of linked items.
	(undelete_aux_item_list): Manage undeletion of linked items.
	(mark_linked_object_as_changed): New function to mark the object
	containing a linked aux item as changed.
	(find_linked_aux_item): New function to find the aux item that is
	linked to a given aux item.
	(find_linked_aux_item_list): New function to find the aux item
	list containing the aux item that is linked to a given aux item.
	(aux_item_validate): New function for validating aux items. Deals
	with regexps and validation functions.
	(aux_item_add_perm): Handle the system-only property of aux item
	definitions.
	

1999-05-09  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (prepare_aux_item): Clear the linked_item
 	field properly.

	* src/server/memory.c (init_aux_item_link): New function.
	(init_aux_item): Use init_aux_item_link
	(init_aux_item): New function added earlier.

	* src/server/prot-a-parse.c (prot_a_parse_aux_item): Clear the
	parsed aux_item to get good defaults for fields that are not read
	in the parser.

	* src/server/admin.c (modify_server_info): Pass INFO_OBJECT_TYPE
	to delete_aux_item_list and undelete_aux_item_list.

	* src/server/aux-items.h: Changed all declarations of object_type
	from short to Object_type.

	* src/server/aux-items.c: Changed all declarations of object_type
	from short to Object_type.

	* src/server/ram-parse.c (fparse_aux_item_link): New function.
	(fparse_aux_item): Parse the link as well.

	* src/include/kom-types.h (Object_type): New type (moved defs from
 	aux-items.h) 
	(Aux_item_link): New type
	(Aux_item): Added linked_item field.

	* src/server/ram-output.c (foutput_aux_item): Output linked_item
	field.
	(foutput_aux_item_link): New function to output a link to another
	aux item.

	* src/server/aux-items.c: Added handling of item field in aux item 
	trigger calls.

	* src/server/aux-items.h (Aux_item_trigger_data_s): Added item
	field.

	* src/server/aux-items.c (system_check_add_aux_item_list): Set
	owner_check to TRUE in call to aux_item_add_perm so system-only
	restriction works on system-info aux-item list.

	* src/server/testsuite/lyskomd.0/admin-cov.exp: Added tests for
	sending messages to secret confs and to conf with passive member
	logged in.

	* doc/Protocol-A.texi (send-message): Document that
	message-not-sent is returned when there are no recipients for a
	group message.

	* src/server/com-h.awk: Set illegal_fnc to -1 (was cnt) since cnt
	might be a legal function.

782 783 784 785
1999-05-02  Per Cederqvist  <ceder@gratia>

	"make check" in the top directory failed in some environments.
	* src/server/testsuite/Makefile.am (check-lyskomd): Close file
786
	descriptors 3-9 to avoid interference between file descriptors
787 788
	inherithed from make, sshd et c with lyskomd.0/07.exp.

Per Cederqvist's avatar
Per Cederqvist committed
789 790 791 792 793 794 795
1999-05-01  Per Cederqvist  <ceder@lysator.liu.se>

	Use libisc-1.00.
	* src/libraries/libisc-new: Replace the old contents with that of
	isc-1.00.  Se src/libraries/libisc-new/ChangeLog for information
	about any modifications that are made to the library.

796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926
1999-04-28  Per Cederqvist  <ceder@lysator.liu.se>

	Remove support for the mux protocol.  Don't use isc_printf.
	* src/server/testsuite/lyskomd.0/07.exp: Decrease the all file
	descriptors by one, now that the server no longer listens for a
	mux.  Test that protocol B is unsupported.
	* src/server/testsuite/config/unix.exp (muxport): Removed.
	(lyskomd_start): Don't set "Mux port" in the config file.
	* src/server/server-config.c (parameters): Removed parameter "Mux
	port".
	* doc/lyskomd.texi (Parameters): Removed "Mux port".
	* src/server/ramkomd.c (listen_mux): Removed.
	(server_init): Remved the "mux_port" argument.  Don't listen for
	muxes.
	(initialize): Don't pass the "mux_port" argument to server_init.
	* src/server/prot-a.c (prot_a_reply): Use isc_putc, isc_putul,
	isc_flush and prot_a_output_ul instead of mux_printf, mux_flush
	and mux_putc.
	(prot_a_parse_packet): Likewise.
	* src/server/prot-a-send-async.c (async_header): Use isc_putc,
	isc_putul, prot_a_output_ul and isc_flush instead of mux_printf,
	mux_putc and mux_flush.
	(async_trailer): Likewise.
	(prot_a_async_new_text_old): Likewise.
	(prot_a_async_new_text): Likewise.
	(prot_a_async_logout): Likewise.
	(prot_a_async_new_name): Likewise.
	(prot_a_async_forced_leave_conf): Likewise.
	(prot_a_async_login): Likewise.
	(prot_a_async_send_message): Likewise.
	(prot_a_async_deleted_text): Likewise.
	(prot_a_async_new_recipient): Likewise.
	(prot_a_async_sub_recipient): Likewise.
	(prot_a_async_new_membership): Likewise.
	* src/server/prot-a-output.h (prot_a_output_ul): New function.
	* src/server/prot-a-parse.c (prot_a_get_token): Use isc_puts and
	isc_flush instead of mux_printf and mux_flush.
	(prot_a_parse_num_list): Likewise.
	(prot_a_parse_string): Likewise.
	* src/server/prot-a-output.c (prot_a_output_ul): New function.
	(prot_a_output_person): Use prot_a_output_ul, isc_puts, isc_putc
	and isc_write instead of mux_printf, mux_putc and mux_write.
	(prot_a_output_membership_type): Likewise.
	(prot_a_output_membership): Likewise.
	(prot_a_output_membership_old): Likewise.
	(prot_a_output_membership_list_old): Likewise.
	(prot_a_output_membership_list): Likewise.
	(prot_a_output_conf_list): Likewise.
	(prot_a_output_conf_no_list): Likewise.
	(prot_a_output_conference): Likewise.
	(prot_a_output_conference_old): Likewise.
	(prot_a_output_uconference): Likewise.
	(prot_a_output_mark_list): Likewise.
	(prot_a_output_aux_item_flags): Likewise.
	(prot_a_output_aux_item): Likewise.
	(prot_a_output_text_stat_old): Likewise.
	(prot_a_output_aux_item_list): Likewise.
	(prot_a_output_who_info_ident): Likewise.
	(prot_a_output_who_info): Likewise.
	(prot_a_output_who_info_list): Likewise.
	(prot_a_output_who_info_ident_list): Likewise.
	(prot_a_output_who_info_list_old): Likewise.
	(prot_a_output_session_info): Likewise.
	(prot_a_output_session_info_ident): Likewise.
	(prot_a_output_info_old): Likewise.
	(prot_a_output_string): Likewise.
	(prot_a_output_priv_bits): Likewise.
	(prot_a_output_personal_flags): Likewise.
	(prot_a_output_conf_type): Likewise.
	(prot_a_output_extended_conf_type): Likewise.
	(prot_a_output_member_list): Likewise.
	(prot_a_output_member_list_old): Likewise.
	(prot_a_output_member): Likewise.
	(prot_a_output_member_old): Likewise.
	(prot_a_output_mark): Likewise.
	(prot_a_output_misc_info): Likewise.
	(prot_a_output_time): Likewise.
	(prot_a_output_session_no): Likewise.
	(prot_a_output_text_no): Likewise.
	(prot_a_output_conf_z_info): Likewise.
	(prot_a_output_conf_z_info_list): Likewise.
	(prot_a_output_version_info): Likewise.
	(prot_a_output_num_list): Likewise.
	(prot_a_output_dynamic_session_info): Likewise.
	(prot_a_output_dynamic_session_info_list): Likewise.
	(prot_a_output_l2g_iterator_as_text_list): Likewise.
	(prot_a_output_text_mapping): Likewise.
	(prot_a_output_memory_info): Likewise.
	* src/server/param.h (struct kom_par): Removed ip_mux_port,
	num_ip_mux_port and num_ip_client_port.
	* src/server/isc-interface.h (ISC_UDGTYPE): Use "struct
	connection" instead of "struct mux".
	(ISC_PRINTF_SUPPORT): Don't define it.
	* src/server/internal-connections.c (init_connection): Use
	isc_session instead of mux.
	(kill_client): Likewise.
	* src/server/connections.h (Connection): Replaced mux with isc_session.
	* src/server/connections.c (logout_client): Use ISC instead of the
	removed mux layer.
	(parse_packet): Likewise.
	(parse_unparsed): Likewise.
	(login_request): Likewise.  Don't handle muxes.
	(logout_request): Likewise.
	(message_request): Likewise.
	(mux_handle_packet): Removed.
	(mux_logout): Removed.
	(mux_parse_unparsed): Removed.
	(mux_parse_message): Removed.
	(milli_timevaldiff): New name for former timevaldiff.  Return the
	difference in milliseconds instead of microseconds.
	(toploop): Use milli_timevaldiff instead of timevaldiff.  This is
	a thousand times better at avoiding overflow.  Use isc_puts
	instead of isc_printf.
	* src/server/mux.h: File removed.
	* src/server/mux.c: File removed.
	* src/server/mux-parse.h: File removed.
	* src/server/mux-parse.c: File removed.
	* src/server/Makefile.am (lyskomd_SOURCES): Removed mux-parse.h
	and mux.h.
	(MUX): Removed.  Removed mux.c and mux-parse.c.
	(GENOBJS): Removed $(MUX).
	* doc/mux.proto: File removed.
	* doc/Makefile.am (EXTRA_DIST): Remove mux.proto.
	* configure.in: Remove enable_isc_printf -- we no longer need
	isc_printf.

	Fix a warning message in the testsuite.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Fixed the
	"unsupported" message: The configure option is named
	--with-debug-calls, not --enable-debug-calls.

927 928 929 930 931 932 933 934 935 936 937 938
1999-04-25  Per Cederqvist  <ceder@gratia>

	Increase the block size of the l2g structure from 10 to 250.
	* src/server/local-to-global.h (l2g_set_block_size): New function.
	* src/server/local-to-global.c (L2G_BLOCKSIZE): Now a static int
	instead of a define.
	(l2g_set_block_size): New function, that can be called once to
	set the block size
 	(l2g_init): Set the block size to 250 unless it has already been
	set.
	* src/server/testsuite/test-l2g.c (main): Set the block size to 10.

David Byers's avatar
David Byers committed
939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959
1999-04-23  David Byers  <davby@ida.liu.se>

	* src/server/standalone.c (kom_info): Initialize the
	aux_item_list too.

	* src/server/ramkomd.c (initialize): Use kom_log instead of log.

	* src/server/local-to-global.c (l2g_read): Use kom_log instead of
	log.

	* src/server/text.c (text_read_access): Call
	person_text_read_access to do the work.
	(person_text_read_access): New function generalizes
	text_read_access.

	* src/server/manipulate.h: Prototype for person_text_read_access.

1999-04-21  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (aux_item_find_validator): New function.

960 961 962 963 964 965 966 967
1999-04-20  Per Cederqvist  <ceder@gratia>

	Two file descriptors were leaked during startup.
	* src/server/aux-item-def-parse.y (parse_aux_item_definitions):
	Close the config file once it is read.
	* src/server/conf-file.c (read_config): Close the config file once
	it is read.

Per Cederqvist's avatar
Per Cederqvist committed
968 969 970 971 972 973 974 975 976 977 978
1999-04-19  Per Cederqvist  <ceder@gratia>

	New parameter: "Client host".
	* doc/lyskomd.texi (Parameters): Documented "Client host".
	* src/server/server-config.c (parameters): New parameter: "Client
	host".
	* src/server/ramkomd.c (server_init): New argument: host.  Bind
	the specified IP number.
	(initialize): Pass param.ip_client_host to server_init.
	* src/server/param.h (struct kom_par): Added ip_client_host.

979 980 981 982 983 984
1999-04-19  Per Cederqvist  <ceder@lysator.liu.se>

	Test the "% No connections left." message.
	* src/server/testsuite/lyskomd.0/07.exp: Test what happens when
	too many clients try to connect at the same time.

Per Cederqvist's avatar
Per Cederqvist committed
985 986 987 988 989 990 991
1999-04-18  Per Cederqvist  <ceder@lysator.liu.se>

	More documentation.
	* doc/lyskomd.texi (Parameters): Documented "lyskomd path",
	"savecore path", "Normal shutdown time", "Mail after downtime" and
	"Mail until downtime".
	* doc/Protocol-A.texi (Protocol Version History): Call
Per Cederqvist's avatar
Per Cederqvist committed
992
	102=set-membership-type was omitted, and later calls were
Per Cederqvist's avatar
Per Cederqvist committed
993 994 995
	misnumbered.
	(map-created-texts): Documented.

996 997 998 999 1000 1001 1002 1003 1004 1005 1006
1999-04-18  Per Cederqvist  <ceder@gratia>

	Removed the last hardcoded configuration from updateLysKOM.
	* src/server/updateLysKOM.c (savecore): Use param.core_dir and
	param.savecore_path instead of hardcoding the values.
	* src/server/server-config.c (parameters): New parameter:
	"savecore path".
	(read_configuration): Handle param.savecore_path.
	* src/server/param.h (struct kom_par): New parameter:
	savecore_path.

1007 1008
1999-04-17  Per Cederqvist  <ceder@lysator.liu.se>

1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037
	updateLysKOM now reads the configuration file.
	* src/server/updateLysKOM.c (usage): New function.
	(checkstatus): Use parameters "Normal shutdown time", "Mail after
	downtime" and "Mail until downtime" instead of
	using hard-coded values.  Use "mail" instead of "Mail" to send the
	mail.
	(main): Read the configuration file.  Use parameters "Pid file",
	"Status file" and "lyskomd path" instead of hard-coded values.
	* src/server/server-config.c (param): Moved here from various
	files.
	(parameters): Added "Normal shutdown time", "Mail after downtime",
	"Mail until downtime" and "lyskomd path".
	(read_configuration): Handle param.lyskomd_path.
	* src/server/ramkomd.c: (param): Moved to server-config.c.
	* src/server/dbck.c (param): Moved to server-config.c.
	* src/server/Makefile.am (READ_CONFIG): New variable.
	(komrunning_SOURCES): Use READ_CONFIG to simplify code.
	(updateLysKOM_SOURCES): Added READ_CONFIG.
	* src/server/param.h (struct kom_par): New parameters:
	lyskomd_path, normal_shutdown_time, downtime_mail_start and
	downtime_mail_end.
	* src/server/server-config.c (parameters): Moved a few entries
	around, so that they fit under the various headings.

	Fixes to komrunning.c.
	* src/server/komrunning.c (param): Moved to server-config.c.
	(create_status): Write the name of the user as the first line of
	the status file.  With luck, that is a valid email address.

1038 1039 1040 1041 1042 1043 1044 1045 1046
	Handle many simultaneous clients.
	* src/server/connections.c (login_request): Don't handle the "% No
	connections left" situation.
	(toploop): Handle ISC_EVENT_LOGIN_UNRELOCATED by returning a "% No
	connections left" message and closing the session, the way
	login_request used to do.
	* src/server/ramkomd.c (initialize): Warn if getrlimit and sysconf
	don't agree on the number of possible open files.

1047 1048 1049 1050 1051 1052 1053
1999-04-17  Per Cederqvist  <ceder@gratia>

	Work towards handling more than 250 simultaneous clients.
	* src/server/ramkomd.c (server_init): Use isc configuration 1006
	and isc session configuration 1002.  Fill in fd_relocate with
	PROTECTED_FDS.

1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083
1999-04-17  Per Cederqvist  <ceder@lysator.liu.se>

	Re-implement komrunning in C.
	* src/server/standalone.c (register_jubel): Dummy implementation.
	* src/server/dbck.c (register_jubel): Moved to standalone.c.
	* src/server/dbck-cache.c (kom_info): Moved to standalone.c.
	* src/server/komrunning.c: New file; a reimplementation of
	komrunning.sh in C.
	* src/server/Makefile.am (bin_PROGRAMS): Added komrunning.
	(komrunning_SOURCES): New variable, which among other files
	includes komrunning.c.
	(updateLysKOM_SOURCES): Added pidfile.c.
	(dbck_SOURCES): Added standalone.c.
	* run-support/komrunning.sh: Removed.
	* run-support/Makefile.am (komrunning): Target removed.
	(bin_SCRIPTS): Removed komrunning.
	(EXTRA_DIST): Removed komrunning.sh.
	(MOSTLYCLEANFILES): Removed komrunning.

	Introduce the "Status file" parameter.
	* src/server/server-config.c (parameters): Added "Status file".
	(read_configuration): Handle param.status_file.
	* src/server/param.h (struct kom_par): Added status_file.
	* doc/lyskomd.texi (Parameters): Documented "Status file".

	Move pid file reading to pidfile.c.
	* src/server/updateLysKOM.c (main): Use pidfile to simplify code.
	* src/server/pidfile.h (read_pid_file): New function.
	* src/server/pidfile.c (read_pid_file): New function.

Per Cederqvist's avatar
Per Cederqvist committed
1084 1085
1999-04-15  Per Cederqvist  <ceder@lysator.liu.se>

Per Cederqvist's avatar
Per Cederqvist committed
1086 1087 1088 1089 1090 1091 1092
	Document 103=local-to-global.
	* doc/Protocol-A.texi (accept-async): Added the error code
	long-array.
	(add-member): Added a comment.
	(local-to-global): Documented.
	(The User Area): Register WWW-kom.

Per Cederqvist's avatar
Per Cederqvist committed
1093 1094 1095
	Test suite improvement.
	* src/server/testsuite/lyskomd.0/03.exp: Test calls 103 and 104.

1096 1097 1098 1099 1100
1999-04-06  Per Cederqvist  <ceder@gratia>

	Yesterdays changes were incomplete.
	* src/server/ramkomd.c: Include local-to-global.h.

1101 1102 1103 1104 1105
1999-04-05  Per Cederqvist  <ceder@panic.signum.se>

	Explain the Text-Mapping data type.
	* doc/Protocol-A.texi (LysKOM Data Types): Explain Text-Mapping.

1106 1107
1999-04-05  Per Cederqvist  <ceder@gratia>

1108 1109 1110 1111 1112 1113 1114 1115
	Change the external file format of a Local_to_global.
	* src/server/testsuite/l2g.0/09.exp: Adjusted to new external
	format of Local_to_global.
	* db-crypt/db/lyskomd-data: Adapted to new format of
	Local_to_global objects.
	* src/server/local-to-global.c (l2g_read): New file format.
	(put_ulong): New static function.
	(l2g_write): New file format.
Per Cederqvist's avatar
Per Cederqvist committed
1116 1117
	* src/server/testsuite/l2g.0/11.exp: Added lots of test cases for
	l2g_write.
1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187

	Added statistics to Local_to_global.
	* src/server/ramkomd.c (dump_exit_statistics): Call dump_l2g_stats.
	* src/server/local-to-global.h: Comments added and improved.
	(dump_l2g_stats): New function.
	* src/server/local-to-global.c (nr_constructs): New static
	variable, used to gather statistics.  Changed all functions to set
	it where appropriate.
	(nr_l2gs): Likewise.
	(nr_l2gs_peak): Likewise.
	(nr_destructs): Likewise.
	(nr_clears): Likewise.
	(nr_copies): Likewise.
	(nr_joins): Likewise.
	(nr_joined_blocks): Likewise.
	(nr_blocks): Likewise.
	(nr_blocks_peak): Likewise.
	(nr_blocks_sparse): Likewise.
	(nr_blocks_sparse_peak): Likewise.
	(sparse_skip_cost): Likewise.
	(nr_sparse_compactions): Likewise.
	(nr_sparsifications): Likewise.
	(l2g_destruct): Actually fill the destructed object with garbage
	data, unless NDEBUG is defined.
	(dump_l2g_stats): New function.

	Make a lot of functions in ram-output.c static.  Increase const
	awareness.
	* src/server/ram-output.c (foutput_person_0): Added const
	qualifier to the person argument.
	(foutput_person_2): Likewise.
	(foutput_person): Likewise.
	(foutput_conference_2): Added const qualifier to the conf_c
	argument.
	(foutput_aux_flags): Now static.
	(foutput_aux_item): Now static.
	(foutput_aux_item_list): Now static.  Added const qualifier to the
	aux argument.
	(foutput_membership_type): Now static.
	(foutput_string): Now static.
	(foutput_priv_bits): Now static.
	(foutput_personal_flags): Now static.
	(foutput_text_list): Now static.
	(foutput_mark_list): Added const qualifier to the mark_list
	argument.
	(foutput_mark): Now static.
	(foutput_membership_list): Now static.
	(foutput_time): Now static.
	(foutput_member_list): Now static.
	(foutput_member): Now static.
	(foutput_conf_type): Now static.
	(foutput_misc_info): Now static.
	(foutput_ulong): Now static.
	* src/server/ram-output.h: Track changes in ram-output.c.
	* src/include/kom-types.h (Text_mapping): The l2g pointer is
	const.

	Some minor improvements to memory handling.
	* src/server/memory.c (free_conference): Call l2g_destruct.
	(free_person): Likewise.
	* src/server/conference.c (do_delete_conf): Don't call l2g_clear,
	since cache_delete_conf will do so.

	Remove useless compiler warnings.
	* configure.in: Don't use -Wtraditional and -Wnested-externs.

	Test suite improvement.
	* src/server/testsuite/config/unix.exp (lyskomd_death): Collect
	etc/memory-usage in usage.all.

1188 1189 1190 1191 1192 1193 1194
	Test suite fix.
	* src/server/testsuite/config/unix.exp (lyskomd_start): The
	detection of a server compiled with --with-debug-calls was
	broken.

	Test Local_to_global even more.
	* src/server/testsuite/l2g.0/11.exp: Increase coverage even
1195
	further.  Test l2g_clear.
1196 1197 1198
	* src/server/local-to-global.h: Comments improved.
	* src/server/local-to-global.c: Comments improved.

1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
1999-04-05  Per Cederqvist  <ceder@panic.signum.se>

	Added range-begin and range-end to Text-Mapping.
	* doc/Protocol-A.texi (LysKOM Data Types): Added range-begin and
	range-end to Text-Mapping.
	* src/server/prot-a-output.c (prot_a_output_text_mapping): Emit
	range-begin and range-end.
	* src/server/person.c (map_created_texts): Set result->first to
	the first text number that the user requested.  Don't move it
	forward if the text has been deleted.
	* src/server/text.c (local_to_global): Likewise.
	* src/server/testsuite/lyskomd.0/00.exp: Expect range-begin and
	range-end in Text-Mappings.

Per Cederqvist's avatar
Per Cederqvist committed
1213 1214
1999-04-04  Per Cederqvist  <ceder@panic.signum.se>

1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
	Merge everything from prot-A.txt into Protocol-A.texi and remove
	prot-A.txt.
	* doc/prot-A.txt: Removed.  Everything in it should now be present
	in Protocol-A.texi.
	* doc/Makefile.am (EXTRA_DIST): Removed prot-A.txt.
	* doc/Protocol-A.texi: Removed all up, next and prev pointers.
	Makeinfo can figure them out automatically.  Fixed proper nesting
	of nodes, and use @Top, so that this work.  Merge everything in
	prot-A.txt into this document:
	(Document Revision History): This is going to be revision 10.0
	which documents protocol version 10.  9.0 was distributed with
	lyskomd 1.9.0.  8.0 was distributed with lyskomd 1.8.0.
	(Protocol Version History): New name for former "Protocol Revision
	History".  Updated the information about version 9.
	(Protocol Design Principles): Node removed.  The "Client-Server
	Dialog" node contains the same information.
	(Client-Server Dialog): Specify the LysKOM port in the example.
	(Simple Data Types): Moved the text about data element separator
	and call terminator to "Client-Server Dialog".
	(user-active): Talk more about when clients should send this.
	(who-is-on-dynamic): Improved the explanation.
	(get-static-session-info): State that the returned information is
	immutable.

Per Cederqvist's avatar
Per Cederqvist committed
1239 1240 1241
	Distribute sigflags.h.
	* src/server/Makefile.am (lyskomd_SOURCES): Added sigflags.h.

1242 1243
1999-04-03  Per Cederqvist  <ceder@lysator.liu.se>

1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297
	Renam do_sync_db to do_statistics.  Use sig_atomic_t instead of
	Bool for variables set from signal handlers.
	* src/server/sigflags.h: New file, containing sig_atomic_t flags.
	* src/server/ramkomd.c: Include "sigflags.h".
	(sighandler_hup): Use 1 instead of TRUE as
	value of go_and_die.
	(sighandler_usr1): Use 1 instead of TRUE as value of
	do_statistics.  Use do_statistics instead of do_sync_db.
	* src/server/connections.h (go_and_die): Declaration moved to
	sigflags.h.
	(do_sync_db): Renamed to do_statistics and moved to sigflags.h.
	* src/server/connections.c (go_and_die): Now sig_atomic_t instead
	of Bool.
	(do_statistics): New name for former do_sync_db.  New type:
	sig_atomic_t instead of Bool.  All users of do_sync_db updated.
	(toploop): Don't call cache_sync when do_statistics is set.
	* src/server/admin.c (shutdown_kom): Set go_and_die to 1, not TRUE.

	Cosmetic code cleanup.
	* src/server/prot-a-parse-arg-c.awk: Insert a blank line between
	the system includes and the local includes.

	Remove the empty function cache_sync.  Rename cache_sync in dbck
	to cache_sync_all.
	* src/server/simple-cache.c (cache_sync): Removed.
	* src/server/logII.c (log): Call cache_sync_all instead
	of cache_sync.
	* src/server/dbck.c (garb_text_file): Call cache_sync_all instead
	of cache_sync.
	(main): Likewise.
	* src/server/dbck-cache.c (cache_sync_all): New name for former
	cache_sync.
	* src/server/cache.h (cache_sync): Function removed.

	Distribution cleanup.
	* src/server/Makefile.am (EXTRA_DIST): Don't distribute logII.c.
	* configure.in: Create src/libraries/regex/doc/Makefile and
	src/libraries/regex/test/Makefile.

	Documentation fixes.
	* doc/lyskomdb.texi (Version 0): next-free-num and next-text-num
	are one greater than the number of existing records.
	(Version 1): The same error probably exists here.  Added comment
	about it.
	* doc/lyskomd.texi (Server Configuration File): Markup fixes.
	(Parameter Types): Markup fixes.
	(Parameters): Markup fixes.
	(Aux-Item Definition File): Markup fixes.
	(Administration): Update the discussion about updateLysKOM, dbck
	and komrunning.  Markup fixes.

	Make all man pages obsolete.  Generate the version number in
	lyskomd.texi automatically.  Make sure that lyskomd.texi and
	dbck.texi includes everyting that was documented in the man pages.
1298 1299 1300 1301
	* mkmi: Remove scripts/mdate-sh, which should be generated by
	automake.
	* doc/man/dbck.8: All documentation removed.  Refer to
	dbck.info.
1302 1303 1304
	* doc/man/lyskom.5: Documentation removed.  Refer to lyskomdb.info.
	* doc/man/updateLysKOM.8: All documentation removed.  Refer to
	lyskomd.info.
1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332
	* doc/dbck.texi (Invoking dbck): Mention that dbck with no
	argument will examine the database without modifying it.
	(General Options): Document -h (aka --help).
	(Format Conversion Options): Minor layout fix.
	(Notes): Typos fixed.
	(Files): Markup fixes.
	* doc/Makefile.am: Break long lines.
	* doc/man/lyskomd.8: All documentation removed.  Refer to
	lyskomd.info.
	* doc/lyskomd.texi: Include version.texi and use @value{VERSION}
	instead of hard-coding the value.
	(Overview): Add Peter Eriksson to the list of signficant
	contributors.  ISC was a piece of very important "enabling
	technology".
	(Parameter Types): Mention that all files are absolute if the
	begin with '/'.
	(Parameters): Use @var{} instead of @i{}.  Markup fixes and other
	minor typo fixes.  The "Log statistics" path is used when the
	server receives a SIGUSR1 signal -- not a SIGHUP!
	(Aux-Item Definition File): The file name was wrong.  Don't use
	@i{}.  Document the "server" keyword.  Mention that permanent
	aux-items will be deleted when the object they belong to are
	deleted.
	(Signals): Removed a note about SIGUSR2 not working on Suns.  It
	should work fine there as well.
	(Files): Don't use @i{}.
	(Bugs): There is no detectable memory leak worth noting.

1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344
1999-04-03  Per Cederqvist  <ceder@gratia>

	The test cases shouldn't fail just because --with-debug-calls
	wasn't enabled.
	* src/server/ramkomd.c (main): Emit a warning message when
	--with-debug-calls is enabled.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Look for
	the warning message about --with-debug-calls, and set debug_calls
	to a true value if it is found.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Don't attempt to
	use debug calls unless debug_calls is true.

1345 1346
1999-04-02  Per Cederqvist  <ceder@panic.signum.se>

Per Cederqvist's avatar
Per Cederqvist committed
1347 1348 1349 1350
	Fix "make clean".
	* src/server/testsuite/Makefile.am (mostlyclean-local): Remove db
	and etc.

1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372
	Use automake defaults for the Lex and Yacc files, so that the
	distribution works.
	* src/server/Makefile.am (YFLAGS): Set it to "-d" so that we get
	the .h header file.
	(EXTRA_DIST): Removed aux-item-def.l and aux-item-def.y.
	(MAINTAINERCLEANFILES): Removed aux-item-def.tab.h.
	(lyskomd_SOURCES): Added aux-item-def-parse.y,
	aux-item-def-parse.h and aux-item-def-scan.l.
	(DISKOBJS): Removed aux-item-def.tab.c and aux-item-def.lex.c.
	(aux-item-def.tab.c): Target removed.  Rely on automake.
	(aux-item-def.lex.c): Target removed.  Rely on automake.
	* src/server/aux-item-def-parse.y: Rename hack added.  Don't
	redefine yyin and yylineno, since the Lex file no longer uses
	"%option prefix".  Remove blank lines at end of file.
	* src/server/aux-item-def-scan.l: Rename hack added.  Include
	aux-item-def-parse.h instead of aux-item-def.tab.h.  Don't
	redefine yylval and yyerror, and don't use "%option prefix" -- this
	change makes it impossible to have multiple Lex scanners, but on
	the other hand, it makes it possible to use automake.
	* src/server/aux-item-def.l: Renamed aux-item-def-scan.l.
	* src/server/aux-item-def.y: Renamed aux-item-def-parse.y.

1373 1374 1375 1376 1377 1378 1379 1380 1381
	Added some missing files to the distribution.
	* doc/Makefile.am (EXTRA_DIST): Added IDEAS.
	* src/include/Makefile.am (noinst_HEADERS): Added kom-config.h.
	* src/server/Makefile.am (EXTRA_DIST): Added prot-a-is-legal-fnc.awk.
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
	renumber.el, l2g.0/*.exp, lyskomd.0/*.exp,
	lyskomd.0/summarize.sh,	lyskomd.0/aux-items.conf,
	lyskomd.0/aux-items.cov and lyskomd.0/aux-items.leaks.

1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416
1999-04-02  Per Cederqvist  <ceder@gratia>

	Make it possible to run "make check" even when not building in
	srcdir.
	* src/server/testsuite/config/unix.exp: (lyskomd_start): Run the
 	test suite in the build directory.  Look for files relative to
 	$srcdir or top_srcdir so that they are found properly.
	(aux_item_default_conf_file): Use $top_srcdir to get a full path.
	* src/server/testsuite/config/leaks.exp: Look for exp files in
	$srcdir.
	* src/server/testsuite/lyskomd.0/04.exp: Likewise.
	* src/server/testsuite/lyskomd.0/05.exp: Likewise.
	* src/server/testsuite/lyskomd.0/06.exp: Likewise.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks00.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks01.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks02.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks03.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks04.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks05.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks06.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks07.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks08.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks99.exp: Likewise.

	Fix broken tests.
	* src/server/testsuite/lyskomd.0/01.exp: The test could fail due
	to bad timing.  Fixed.

	Makefile fixes.
	* src/server/testsuite/config/Makefile.am (EXTRA_DIST): Added
	leaks.exp.
	(MOSTLYCLEANFILES): Added lyskomd-config.

1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431
1999-03-31  Per Cederqvist  <ceder@gratia>

	Fix bugs in "make dist".
	* doc/Makefile.am (EXTRA_DIST): Removed Makefile.src.

	Dead code removal.
	* src/server/local-to-global.c (find_block_index_key): Blocks can
	never be completely empty.  Code simplified accordingly.
	(l2g_append): Likewise.
	(l2gi_next): Likewise.
	* src/server/ram-parse.c (fparse_info_2): Unreachable code removed.

	Increase coverage of local-to-global.c.
	* src/server/testsuite/l2g.0/11.exp: New file.

Per Cederqvist's avatar
Per Cederqvist committed
1432 1433 1434 1435 1436
1999-03-28  Per Cederqvist  <ceder@link>

	* TODO: Updated according to priorization made by me and David
	Byers.

David Byers's avatar
David Byers committed
1437 1438 1439 1440 1441 1442 1443 1444 1445 1446
1999-03-28  David Byers  <davby@ida.liu.se>

	* src/server/simple-cache.c (cached_conf_exists): Test existance
	in small_conf_arr. Don't go to disk.
	(cached_delete_conf): Free the associated small_conf_stat and set
	small_conf_arr[x] to NULL.

	* run-support/aux-items.conf: Restrict creation of mx-author to
	creation time.

1447 1448 1449 1450
1999-02-06  Per Cederqvist  <ceder@gratia>

	* configure.in: Fixed a syntax error introduced yesterday.

1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486
1999-02-05  Per Cederqvist  <ceder@gratia>

	Don't produce meaningless warnings.
	* configure.in: Remove -Wshadow and -Wcast-qual since they give
	too many false warnings and are of limited use.

	Get rid of some warnings.
	* src/include/kom-types.h (Version_info_internal): const
	qualifiers added.
	* src/server/Makefile.am (version-info.c): Added const qualifier
	to kom_version_info.
	* src/server/version-info.h (kom_version_info): Added const
	qualifier.

	Don't use the wrong member of a union.
	* src/server/prot-a.c (prot_a_reply): Emit
	res->membership_list_old, not res->membership_list, when the
	return type is rt_membership_list_old.

	Remove the L2g_iterator_as_text_list typedef.
	* src/server/text.c (get_map): Use L2g_iterator
 	instead of L2g_iterator_as_text_list.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
 	(prot_a_output_l2g_iterator_as_text_list): Use L2g_iterator
 	instead of L2g_iterator_as_text_list.
	* src/server/person.c (get_created_texts): Use L2g_iterator
	instead of L2g_iterator_as_text_list.
	* src/server/connections.h (Result_holder): The
	l2g_iterator_as_text_list member is now of type L2g_iterator
	instead of the typedef L2g_iterator_as_text_list.
	* src/include/services.h (get_created_texts): Use L2g_iterator
	instead of L2g_iterator_as_text_list.
	(get_map): Likewise.
	* src/include/kom-types.h (L2g_iterator_as_text_list): Typedef
	removed.

David Byers's avatar
David Byers committed
1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565
1999-02-02  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.h (Aux_item_validation_data): New type.
	(Aux_item_validation_function): New type.
	(Aux_item_validator): New type.

1999-01-28  David Byers  <davby@ida.liu.se>

	* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Check
	array size for -1. Check allocation of result.

	* src/server/person.c (mark_text): Return no-such-text if the user 
	is not allowed to read the text (just like get-text-stat)
	(set_user_area): Return UNDEF_PERS, not UNDEF_CONF.

	* src/include/kom-errno.h (enum kom_errno): Define
	KOM_PERS_EXISTS.

	* src/server/person.c (create_person_generic): Return
	KOM_PERS_EXISTS instead of KOM_CONF_EXISTS

1999-01-27  David Byers  <davby@ida.liu.se>

	* src/server/conference.c (do_create_conf): Don't just DIE if we
	fail to create a conference. Log a message and return an error.

	* src/server/person.c (create_person_generic): Don't just DIE if
	we fail to create a conference. Log a message and return an error.

	* src/server/ram-output.c (foutput_conference_2): Output a space
	before the l2g mapping.
	(foutput_person_2): Same thing here.

1999-01-26  David Byers  <davby@ida.liu.se>

	* src/server/person.c (create_person_old): Add parameter in call
	to create_person.
	(create_person): Added flags parameter.
	(create_person_generic): Set the personal flags from the
	parameter.
	(set_pers_flags): New function to set the personal flags of a
	person.

	* src/server/fncdef.txt: Added set_pers_flags and added pers_flags 
	argument to create_person.

1999-01-25  David Byers  <davby@ida.liu.se>

	* doc/hacking.texi (Parsing Bit Fields): New section.

	* src/server/prot-a-parse.c (prot_a_parse_priv_bits): New
	function. New model for parsing bit fields that's really tolerant
	about the token length. Anything from one bit and up is cool.

	* src/server/prot-a-parse.h: Added prot_a_parse_priv_bits.

	* src/server/connections.h: Added pers_flags to Connection.

	* src/server/internal-connections.c (init_connection): Initializer 
	pers_flags field.

	* src/server/prot-a-parse-arg-c.awk: Added pers_flags.

	* src/server/call-switch.awk: Added pers_flags.

	* src/server/person.c (set_user_area): Return KOM_UNDEF_CONF if
	the person is secret.

	* src/server/conference.c (get_conf_stat_old): Check access with
	<= none and not == none.
	(get_conf_stat_older): Same here.

	* src/server/person.c (get_person_stat): Check access with <= none 
	and not == none
	(get_person_stat_old): Same here.
	(get_created_texts): Same here.
	(map_created_texts): Same here.

1999-01-24  David Byers  <davby@ida.liu.se>
1566

David Byers's avatar
David Byers committed
1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
	* src/server/connections.c (login_request): Use param.nologin_file 
	instead of hard-coded path.

	* doc/lyskomd.texi (Parameters): Documented Nologin file

	* src/server/server-config.c: Added "Nologin file"

	* src/server/param.h: Added nologin_file.

	* src/server/conference.c (legal_name): Return bad-name on attempt 
	to use null string.

	* src/server/log.c (restart_kom): Do normal exit if AVOID_ABORTS
	is defined.

	* acconfig.h: Added AVOID_ABORTS

	* configure.in: Define AVOID_ABORTS when the user says --with-gcov 

	* src/server/conf-file.c (configure_line): Complain about too many 
	assignments at one too many assignments, not two too many.

	* src/server/simple-cache.c (sync_part): Don't save if
	param.never_save is set.

	* src/server/server-config.c: Compile in never_save always.

1999-01-23  David Byers  <davby@ida.liu.se>

	* src/server/session.c (set_client_version): Use client_data_len
	as max length for client version and client name.

	* doc/lyskomd.texi (Parameters): Documented max client data
	length.

	* src/server/param.h: Added client_data_len.

	* src/server/server-config.c: Added max client data length.

	* src/server/text.c (submit_to): Set err-stat to the last conf in
	the chain, not zero, if we hit the top of the super-conf chain
	without finding something we can write to.
	(sub_recipient): Check for access to the supposed recipient before 
	checking if it is a recipient. This plugs two leaks of secret
	information. 
	(add_footnote): Set err-stat to footnote when failing because of
	not being author to footnote.
	(check_comm): Don't set err-stat. The caller will.

1999-01-22  David Byers  <davby@ida.liu.se>

	* src/server/text.c (create_text_check_misc): Return no-such-text
	if no read access to footnoted text. Check read access before
	checking anything else to avoid leaking secret information.

	* src/server/membership.c (fast_access_perm): fast_access_perm
	always returned read_protected for rd_prot conferences, even if
	the viewer was the supervisor. Fixed.

	* src/server/text.c (text_read_access): If an open conf is a bcc
	recpt, anyone can see the text.

	* doc/Protocol-A.texi (add-recipient): Added error code
	access-denied.

	* src/server/text.c (create_text_check_misc): Don't set
	kom_errno if it was set in submit_to.
	(submit_to): Set kom_errno here instead of in the caller.
	(add_recipient): Return KOM_ACCESS if we are not allowed to write
	to the target conference.

	* doc/Protocol-A.texi (Error Codes): Fxied speling error

1999-01-21  David Byers  <davby@ida.liu.se>

	* src/server/text.c (recp_sent_by): Fixed error message.
	(do_create_text): Fixed speling erorr

	* doc/lyskomd.texi (Parameters): Added documentation for max
 	conferences and max texts.

1999-01-19  David Byers  <davby@ida.liu.se>

	* src/server/text.c (do_create_text): Pass time to
	create_text_add_miscs to ensure correct timestamp.
	(create_text_add_miscs): Set last_written to correct 
	timestamp.

	* src/server/conf-file.c (assign_ulong): New function.

	* run-support/config: Added max_confs and max_texts to default
	config file.

 	Remove compiled-in size limits.
	* src/server/dbck-cache.c (init_cache): Dynamically allocate
	pers_arr, conf_arr, text_arr and name_list.

	* src/server/dbck.c: Dynamically alloc person_scratchpad in
	init_person_scratchpad.

	* src/server/simple-cache.c (init_cache): Allocate the
	small_conf_arr.
	(cached_create_conf): Use param.max_conf, not MAX_CONF
	(cached_create_text): Use param.max_text, not MAX_TEXT
	(init_cache): Use param.max_conf and param.max_text, not MAX_CONF
	and MAX_TEXT

	* src/server/aux-items.c: Moved initialization of sent_at to
	prepare_aux_item_list from other functions.

	* src/server/log.h: Changed names from log to kom_log to avoid
	shadowing log in math.h. 

1999-01-18  David Byers  <davby@ida.liu.se>
1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721

	* src/server/testsuite/config/unix.exp (suspend_client): New
	function. Suspends reading from lyskomd.
	(resume_client): New function. Resumes reading.

	* src/server/testsuite/.cvsignore:  Added .da, .bb, .bbg and .da
	files.

	* src/libraries/libansi/.cvsignore: Added .da, .bb, .bbg and .da
	files.

	* src/libraries/libmisc/.cvsignore: Added .da, .bb, .bbg and .da
	files.

1999-01-17  David Byers  <davby@ida.liu.se>

	* src/server/conference.c: Don't allow change to forbid_secret if
	there are secret members.

	* src/server/testsuite/tcpconnect.py (fdset): Added command
 	#suspend socket to stop the relay from reading from the socket, to
 	simulate a communications failure of sorts. Added #resume socket
 	to reopen communications.

1999-01-16  David Byers  <davby@ida.liu.se>

	* src/server/debug.c: New file.
	(get_memory_info): Moved here from admin.c.

	* src/server/Makefile.am (ATOMS): Added debug.c

	* src/server/person.c (create_person_generic): Don't autologin
	unless do_auto_login is true
	(create_person_old): Set do_auto_login to true in call to
	create_person_generic.
	(create_person): Set do_auto_login to false in call to
	create_person_generic. 

	* src/server/connections.c (logout_client): Send async logout if
	the session is not logged in.

1722 1723
1999-01-15  David Byers  <davby@ida.liu.se>

1724 1725 1726 1727 1728 1729 1730 1731 1732
	* src/server/send-async.c (async_new_name): Send new-name only to
	clients with the appropriate privileges.

	* src/server/membership.c (fast_access_perm): Only check priv bits 
	if the viewer is ACTPERS or ACT_P
	(access_perm): Ditto.

	* src/server/manipulate.h (ENA_C): New macro.

1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746
	* configure.in: New argument --with-optimization

	* src/server/conference.c (legal_name): Set err_stat when
	returning KOM_LONG_STR.

	* src/server/text.c (do_create_text): Set err_stat when returning
	KOM_LONG_STR.

	* src/server/aux-item-def.y: Never add disabled items to the
	definition list. 

	* src/server/admin.c (send_message): Set err_stat to
	param.broadcast_len.

1747 1748
1999-01-14  David Byers  <davby@ida.liu.se>

1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759
	* src/server/connections.h: Added Memory_info to Res_type and
	Result_holder to be compiled if DEBUG_CALLS is defined.

	* src/server/admin.c (debug_info): New function to get memory
	usage stats.

	* src/server/prot-a.c (prot_a_reply): Output memory_info

	* configure.in: Check for mallinfo if we do debug calls.
	Substitute EFENCE=1 if we use efence.

1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844
	* src/server/session.c (who_is_on): Changed for loops to while
	loops to deal with new semantics of session 0 and to make the code 
	clearer. (who_is_on_ident): Ditto. (who_is_on_dynamic): Ditto.
	(who_is_on_old): Ditto.

	* src/server/internal-connections.c (get_conn_by_number): Always
 	interpred session 0 as the current session. 
	(traverse_connections): Explicit check for session_no == 0 since
 	change in get_conn_by_number.

	* src/server/session.c (disconnect): disconnect(0) disconnects the 
	current session

	Did some work on mail import and export (that jsk should have
	taken care of. Grrrr....)
	* doc/Protocol-A.texi (Predefined Aux-Item Types): Rewrote
	documentation for mail import and export aux-items. Wrote a
	chapter on mail import and export.

	* run-support/aux-items.conf: Added aux-items for mail import and
	export. 

	* doc/Protocol-A.texi: Removed all @codes surrounding
	cross-references since texinfo chokes on them.

	* doc/hacking.texi (Notes for fncdef.txt): Added notes on
	fncdef.txt.

1999-01-13  David Byers  <davby@ida.liu.se>

	Handle #ifdef/#endif and empty lines in fncdef.txt
	* src/server/fncdef.txt: Added debug_info. This call does NOTHING
	at the moment. It is just a proof of concept. It will do stuff
	later.

	* src/server/prot-a-parse-arg-h.awk: Handle #ifdef and #endif and
	empty lines.

	* src/server/fnc-def-init.awk: Ditto.

	* src/server/prot-a-is-legal-fnc.awk: Ditto.

	* src/server/call-switch.awk: Ditto.

	* src/server/prot-a-parse-arg-c.awk: Ditto.

	* src/server/com-h.awk: Ditto.

	* acconfig.h: Added DEBUG_CALLS

	* configure.in: Added option --with-efence to link with efence.
	Added option --with-debug-calls to define DEBUG_CALLS when
	compiling.

	Arranged things so we have to put a call number into the
	fncdef.txt file. This makes call numbers more explicit. It is also 
	possible to have non-contiguous call numbers.
	* src/server/prot-a.c (prot_a_parse_packet): Use function_index
	field of connection to access parsers etc.

	* src/server/connections.c: Added num_fnc_defs

	* src/server/prot-a-parse-arg-h.awk: Updated for new format.

	* src/server/connections.c (dump_statistics): Changed the format
	of the statistics file to output function number before the call
	number.

	* src/server/connections.h: New field function_index
	Added function field to Fnc_descriptor.

	* src/server/call-switch.awk: Updated for new format in fncdef.txt 

	* src/server/com-h.awk: Updated for new format in fncdef.txt

	* src/server/prot-a-parse-arg-c.awk: Updated for new format in
	fncdef.txt.

	* src/server/prot-a.c (prot_a_is_legal_fnc): Removed hard-coded
	switch and replaced it with include of prot-a-is-legal-fnc.incl

	* src/server/prot-a-is-legal-fnc.awk: New function.

	* src/server/Makefile.am: Add rules for prot-a-is-legal-fnc.incl

1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933
1999-01-12  David Byers  <davby@ida.liu.se>

	* src/server/testsuite/lyskomd.0/03.exp: Updated membership tests.
	
	* src/server/testsuite/lyskomd.0/05.exp: Updated membership tests.

	* src/server/membership.c (do_get_membership): Set the position
	field in the returned structure.
	(locate_membership_and_position): Removed.
	(locate_membership): Set the position field in the membership.

	* src/server/memory.c (init_membership): Init position field.

	* src/include/kom-types.h: Removed Extended_Membership. Added
	position field to Membership.

	* src/server/connections.h: Removed Extended_Membership.

	* src/server/prot-a.c (prot_a_reply): Removed
	rt_extended_membership.

	* src/server/prot-a-output.c (prot_a_output_membership): Output
	membership position.

1999-01-08  David Byers  <davby@ida.liu.se>

	* db-crypt/db/lyskomd-data: Updated database with keep_commented
	field.

1999-01-07  David Byers  <davby@ida.liu.se>

	* src/server/person.c (create_person_generic): Initialize
	keep_commented.

	* src/server/memory.c (copy_conference): Copy keep_commented.
	(init_conference): Initialize keep_commented.

	* src/server/dbck.c (delete_misc): Moved initialization of ready
	to avoid spurious compiler warning.

	* src/server/text.c (do_delete_misc): Moved initialization of
	ready to avoid spurious compiler warning.

	* src/server/simple-cache.c: Changed sync_next to unsigned to get
	rid of compiler warnings.
	(save_one_conf): Output sync_next as unsigned.
	(save_one_text): Ditto.
	(init_cache): Move initialization of done, read_text_no and
	read_conf_no to avoit spurious compiler warning.
	(init_cache): Initialize c for same reason.

	* src/server/cache-node.c: Added initializer for s.snapshot in
	EMPTY_CACHE_NODE.

	* src/server/cache-node.h: Removed saved_sirty [sic] flag from
	cache_node. It wasn't used anywhere.

	* src/include/rcs.h (USE): Use __typeof__ to avoid compiler
	warnings. This macro only does something when __GCC__ is two or
	more, in which case __typeof__ exists, so it should be safe.

	* src/server/server-config.c: Added default_keep_commented to
	parameters.

	* src/server/param.h: Added default_keep_commented to kom_par.

	* src/server/conference.c (do_create_conf): Initialize
	keep_commented

	* doc/lyskomd.texi (Parameters): Documented Default keep commented 
	nice.

	* src/include/services.h: Declare set_keep_commented.

	* src/server/conference.c (set_keep_commented): New function.

	* src/server/fncdef.txt: Added set_keep_commented.

	* src/server/prot-a-output.c (prot_a_output_conference): Output
	keep_commented after nice.

	* src/server/ram-parse.c (fparse_conference_2): Parse
	keep_commented.

	* src/include/kom-types.h: New field keep_commented.

	* src/server/ram-output.c (foutput_conference_2): Output
	keep_commented. 

Per Cederqvist's avatar
Per Cederqvist committed
1934 1935 1936 1937 1938
1999-01-01  Per Cederqvist  <ceder@gratia>

	Use NO_TIME instead of 0.
	* src/server/memory.c (init_membership): Use NO_TIME instead of 0.

1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957
1998-12-31  Per Cederqvist  <ceder@lysator.liu.se>

	Avoid pty buffer size overflow in the test suite.
	* src/server/testsuite/lyskomd.0/03.exp: Split long lines so that
	at most approximately 250 bytes are sent via a pty.  Many
	operating systems have a limit of approximately 256 bytes per
	line.

	Fix test suite typo.
	* src/server/testsuite/config/leaks.exp (check_usage): Fixed a
 	typo: it is an error if the number of strings is use change, not
 	if they stay the same.

	Ignore some generated files.
	* src/server/testsuite/.cvsignore: Ignore lyskomd.*.base,
	lyskomd.*.usage and usage-base.tmp.
	* .cvsignore: Ignore config.h, config.h.in, stamp-h and
	stamp-h.in.

David Byers's avatar
David Byers committed
1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970
1998-12-30  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.h: Removed ADD_AUX_ITEM macro.

	* src/server/aux-items.c (aux_inherit_items): Fixed memory leak.

	* src/server/ramkomd.c (free_kom_info): New function.
	(main): Call it so that memory usage reported at end of session is 
	not dependent on the length of the aux-item list attached to
	kom_info since that messes up testing for memory leaks.

	* doc/lyskomd.texi: Added this file. Finished writing it too.

1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997
1998-12-29  David Byers  <davby@ida.liu.se>

	* src/server/testsuite/config/unix.exp (lyskomd_start): Added
	optional third argument for stuff to put at the end of the config
	file.

	* src/server/prot-a-send-async.c (prot_a_async_new_membership):
	Send the correct header.

	* src/server/membership.c (add_member_common): Added calls to
	send_async_new_membership.
	(send_async_new_membership): Send message to the right recipients.

1998-12-28  David Byers  <davby@ida.liu.se>

	* src/server/membership.c (add_member_old): Don't set invitation
	bit here. It is dealt with in add_member_common.
	(do_change_priority): Don't change priority to zero if we are
	being called from old functions. Just fake the passive bit.
	(locate_membership_and_position): Return the correct position of
	the membership.

1998-12-27  David Byers  <davby@ida.liu.se>

	* doc/Protocol-A.texi (Error Codes): Added
	invalid-membership-type.

David Byers's avatar
David Byers committed
1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091
1998-12-26  David Byers  <davby@ida.liu.se>

	* doc/man/lyskomd.8 (value): Documented regexps use collate
	table.

	* src/server/param.h: Added regex_use_collate_table.

	* src/server/server-config.c: Added regexps use collate table.

	* src/server/regex-match.c (lookup_regexp): Set translation table
	for regex according to regex_use_collate_table option.

	* src/server/manipulate.h: New function declaration.

	* src/server/membership.c (locate_membership_and_position): New
	function. 
	(locate_membership): Use it.

	* src/server/person.c 	(do_query_read_texts): New function.
	(query_read_texts_old): Use it. (query_read_texts): Use it.

	* src/server/prot-a-output.h(prot_a_output_extended_membership):
	New function declaration.

	* src/server/prot-a-output.c (prot_a_output_extended_membership):
	New function.

	* src/server/prot-a.c (prot_a_reply): Added
	rt_extended_membership.

	* src/include/kom-types.h: New type Extended_Membership.

	* src/server/connections.h: Added extended_membership to
	Result_holder. Added rt_extended_membership to Res_type

	* src/include/services.h: Declare query_read_texts to take an
	Extended_Membership

	* doc/Protocol-A.texi (query-read-texts): Documented that this
	function returns the position as well as the membership.

1998-12-25  David Byers  <davby@ida.liu.se>

	* README: Updated clients information.

	* src/server/membership.c (set_membership_type): Removed F-word
	from comment. Inserted F-abbreviation instead :-)

	* src/server/conference.c (get_uconf_stat): Removed FIXME after
	fixing fast_access_perm.

	* src/server/membership.c (fast_access_perm): Set kom_errno if we
	can't find the conference conf_no.

	* src/server/membership.c (do_get_members): Don't filter secret
	memberships if we have privilege bits set.

	* doc/Protocol-A.texi (Error Codes): Fixed error in documentation
	of secret-public

1998-12-24  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (system_add_aux_item_list): Call add
	triggers
	(check_delete_aux_item_list): Return KOM_AUX_PERM if an item to
	delete is mission. This is in accordance with the documentation.

	* src/server/aux-items.h (INFO_OBJECT_TYPE): New constant.

1998-12-23  David Byers  <davby@ida.liu.se>

	* src/server/testsuite/lyskomd.0/03.exp: Updated test 1010 for
	item 27.
	Updated test 1017 for asyncs 16, 17 and 18
	Updated test 1020 for asyncs 16, 17 and 18
	Updated test 1022 for asyncs 16, 17 and 18
	Updated test 1024 for asyncs 16, 17 and 18
	In test 1032 updated async messages to show the bcc recpt. This is 
	because of the change to make bcc recpts visible to the creator
	and to all when target is an open conference.	
	Added sleep 2 before test 1310. Otherwise test 1311 may fail since 
	one of the clients has not been idle for long enough (lyskomd is
	OK.)
	Updated test 1333 to not show deleted items
	Similar in 1334, 1335 and 1339.

	* src/server/testsuite/lyskomd.0/01.exp: Updated
	query-predefined-aux-items test for item 27

1998-12-22  David Byers  <davby@ida.liu.se>

	* src/server/conf-file.c (MAXLINE): Increased line length limit to 
	1000 characters

Per Cederqvist's avatar
Per Cederqvist committed
2092 2093 2094 2095 2096
1998-12-22  Per Cederqvist  <ceder@gratia>

	One more test.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 99.

2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114
1998-12-20  Per Cederqvist  <ceder@gratia>

	More tests.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 95-98.

	Speed up regexp matching a little.
	* src/server/regex-match.c (lookup_regexp): Attempt to allocate a
	fastmap.

	The invitation bit should not be set when a user himself joins a
	conference.
	* src/server/membership.c (add_member_old): Never set the
	invitation bit when a user adds himself to a conference.

	Avoid too long lines in the documentation.
	* doc/Protocol-A.texi (modify-system-info): Remove whitespace to
	avoid too long lines in the generated info file.

David Byers's avatar
David Byers committed
2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130
1998-12-17  David Byers  <davby@ida.liu.se>

	* src/server/testsuite/config/Makefile.am (lyskomd-config): Use
	aux-items.conf in this directory instead of in run-support.

	* src/server/text.c (modify_text_info): Call commit_aux_item_list.

	* src/server/conference.c (modify_conf_info): Call
	commit_auc_item_list.

	* src/server/admin.c (modify_server_info): Call
	commit_aux_item_list.

	* src/server/aux-items.c (commit_aux_item_list): New function to
	really delete aux_items.

2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146
1998-11-14  Per Cederqvist  <ceder@gratia>

	Fixed another uninitialized memory problem: the allow_anon,
	reserved1, reserved2 and reserved3 bits of the Conf_type was not
	always properly initialized.
	* src/server/person.c (create_person_generic): Initialize
 	allow_anon, reserved1, reserved2, and reserved3.
	* src/server/memory.c (init_conf_type): Initialize allow_anon,
	reserved1, reserved2, and reserved3.
	* src/server/prot-a-parse.c (prot_a_parse_conf_type): Let
	allow_anon default to 1, not 0.  We really should have a way to
	let it default to unset, so that a set-conf-type that only
	specifies four bits doesn't alter the remaining bits.
	* src/server/testsuite/lyskomd.0/03.exp: Set allow_anon, and
	expect it to be set.  Test call 92-94.

2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159
1998-11-09  Per Cederqvist  <ceder@gratia>

	Fixed an uninitialized memory problem.
	* src/server/memory.c (init_conference): Initialize highest_aux
	and expire to 0.
	* src/server/conference.c (do_create_conf): Initialize expire to 0.

	Avoid symbols with global linkage.
	* src/server/aux-items.c (aux_item_triggers): Now static.
	
	One more test case.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 91.

2160 2161 2162 2163 2164 2165 2166 2167 2168 2169
1998-11-09  Per Cederqvist  <ceder@gratia>

	More test cases.
	* src/server/testsuite/lyskomd.0/03.exp: Test calls 86-90.

	Minor fixes to the documentation.
	* doc/Protocol-A.texi (create-text): This call can never generate
	the error ``anonymous-rejected''.
	(create-anonymous-text): Avoid too long lines.

2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207
1998-10-22  Per Cederqvist  <ceder@gratia>

	More test cases.
	* src/server/testsuite/config/unix.exp (extracting_expect): New proc.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 46-85.
	* src/server/testsuite/renumber.el
	(renumber-lyskom-send-simple-expect): Handle extracting_expect.

	Only allow one call to set-client-version.
	* src/include/kom-errno.h (KOM_CLIENT_IS_CRAZY): Old favourite
	resurrected.
	* src/server/session.c (set_client_version): Fail if the client
	version already was set.

	Allow set-info with motd_of_lyskom set to 0.
	* src/server/admin.c (set_info): Allow motd_of_lyskom to be 0.

	Fixed the error-status of find-previous-text-no.
	* src/server/text.c (greater): Added const qualifier.
	(find_previous_text_no): Fixed the returned error status.
	* src/server/testsuite/lyskomd.0/01.exp: Adjusted to the error
	status that is now returned by the bug-fixed find_previous_text_no.

	Documentation fixes and updates.
	* doc/Protocol-A.texi (send-message): Document that recipient 0
	means that the message is sent to all sessions.
	(get-last-text): Say that this relies on all texts being written
	in chronological order.
	(set-client-version): This call can only be used once per
	session.  It will return client-is-crazy if used twice.
	(get-client-version): This was called "get-client-name".
	(mark-text): Bogus example fixed.
	(unmark-text): Bogus example fixed.
	(lookup-z-name): The want-pers and want-confs arguments were
	swapped in the function header.
	(set-info): Document that lyskomd 1.9.0 erroneously returned
	text-zero if MOTD was 0.

2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237
1998-10-17  Per Cederqvist  <ceder@gratia>

	More tests.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 30-45.

	Fixed a memory corruption problem.
	* src/server/memory.c (copy_conference): Fixed a memory corruption
	problem that was introduced when Local_to_global was introduced.
	(copy_person): Likewise.
	(copy_text_stat): Added a const qualifier.  Rewritten to decrease
	the probability that the same kind of bug is introduced here, that
	is, assign each field separately instead of assigning the entire
	struct at once.
	(copy_aux_item_list): Now static.  Rewritten as above.
	(coy_aux_item): Added const qualifier.  Rewritten as above.
	* src/server/kom-memory.h (copy-person): Added const qualifier.
	(copy_text_stat): Likewise.
	(copy_aux_item): Likewise.
	(copy_aux_item_list): Removed (now static).

	Minor fixes to the documentation.
	* doc/Protocol-A.texi (Predefined Aux-Item Types): Fixed a Texinfo
	syntax error.
	(sync-kom): Fixed bugs in the example.

1998-10-16  Per Cederqvist  <ceder@gratia>

	More tests.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 27-29, 40.

2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261
1998-10-14  Per Cederqvist  <ceder@gratia>

	More test cases.
	* src/server/testsuite/lyskomd.0/03.exp: Test calls 8-27, 50, 78.
	* src/server/testsuite/lyskomd.0/summarize.sh: New file.

	Fixed bug in mark_as_read.
	* src/server/membership.c (adjust_read): Fixed a fence-post error
	that was introduced when Local_to_global was introduced.

	Clarify the documentation.  Change the specification of
	async-leave-conf.
	* doc/Protocol-A.texi (delete-conf): State the mailboxes can be
 	removed.
	(get-conf-stat-older): Document the mask argument.
	(mark-text-old): Document that mark-type 0 is used to remove the
 	mark.
	(async-leave-conf): This message is always sent to a person when
 	that person ceases to be a member of a conference, whatever the
 	reason is.  The protocol specification used to say that it was
	only sent when a person was forced to leave a conference.  The
	current wording makes more sense, and it was also the implemented
	behavior, so update the specification rather than the program.

David Byers's avatar
David Byers committed
2262 2263 2264 2265 2266
1998-10-12  David Byers  <davby@anton9.ida.liu.se>

	* src/libraries/libcommon/Makefile.am (INCLUDES): Added -DSERVER
	as in src/server

Jonas S Karlsson's avatar
Jonas S Karlsson committed
2267 2268 2269 2270 2271 2272
1998-10-11  Jonas S Karlsson  <jsk@lysator.liu.se>

	Aux-info defined for import/export of emails.
	These are preliminary. but will be improved.
	* doc/Protocol-A.texi: email aux-infos x-XXX
	
2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296
1998-10-11  Per Cederqvist  <ceder@lysator.liu.se>

	Keep an extra copy of the database, just in case.  Do some sanity
	checking when copying file contents.
	* src/server/simple-cache.c (pre_sync): Store the previous backup
	file.
	(copy_file): Abort if we cannot seek or read the file we copy
	from.  Abort if the value we read didn't end in a newline, start
	with "T ", "C " or "P ", if the identity number in the data isn't
	what we expected, or if it isn't followed by a space.  This
	change attempts to detect file damage as early as possible.
	* src/server/server-config.c (parameters): Added "Backup file 2".
	(read_configuration): Handle backupfile_name_2.
	* src/server/ramkomd.c (init_data_base): Print backupfile_name_2.
	* src/server/param.h (struct kom_par): Added backupfile_name_2.
	* src/server/dbck-cache.c (cache_sync): Store the previous backup
	file.
	* doc/man/lyskomd.8: Added "Backup file 2".

	Allow compaction of the text file even if there are errors in the
	data base.
	* src/server/dbck.c (main): Allow -g even if errors occured, but
	only if the user confirms.

Per Cederqvist's avatar
Per Cederqvist committed
2297 2298 2299 2300 2301
1998-10-11  Per Cederqvist  <ceder@gratia>

	More test cases.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 4-7.

2302 2303 2304 2305 2306 2307
1998-10-09  Per Cederqvist  <ceder@signum.se>

	Commit some Emacs support code for test script writers.
	* src/server/testsuite/renumber.el: New file.
	(renumber-lyskom-send-simple-expect): New function.

Per Cederqvist's avatar
Per Cederqvist committed
2308 2309 2310 2311 2312 2313 2314
1998-10-08  Per Cederqvist  <ceder@gratia>

	More test cases.
	* src/server/testsuite/lyskomd.0/03.exp: Test call 0, 1, 2 and 3.
	* doc/Protocol-A.texi (login-old): The error-status indicates the
 	person number when invalid-password is returned.

David Byers's avatar
David Byers committed
2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349
1998-10-08  David Byers  <davby@ida.liu.se>

	* src/server/prot-a-output.c (prot_a_output_membership): Output
	break_type.

	* src/server/ram-output.c (foutput_membership_2): Output
	break_type.

	* src/server/ram-parse.c (fparse_membership_2): Parse break_type.

1998-10-07  David Byers  <davby@ida.liu.se>

	* src/server/text.c (recp_sent_by): New function.
	(filter_secret_info): Let the sender of a bcc see a bcc and
	let bccs to open conferences be visible to all.

1998-10-06  David Byers  <davby@ida.liu.se>

	* src/server/send-async.c (async_new_membership): New function.
	(async_sub_recipient): Ditto.
	(async_new_recipient): Ditto.

	* src/server/prot-a-send-async.c (prot_a_async_new_membership):
	New function.
	(prot_a_async_sub_recipient): Ditto.
	(prot_a_async_new_recipient): Ditto.

	* src/server/text.c (send_async_add_recipient): New function.
	(add_recipient): Send async-new-recipient
	(send_async_sub_recipient): New function.
	(do_sub_recpt): Send async-sub-recipient.

	* src/server/membership.c (send_async_new_membership): New function.
	(add_member_common): Send async-new-membership

2350
1998-10-06  Per Cederqvist  <ceder@gratia>
2351 2352 2353 2354 2355 2356 2357
	
	Document bcc-recpt.  A created person is a member of his mailbox.
	* doc/Protocol-A.texi (The Misc-Info List): Document blank carbon
	copies.
	(create-person-old): Document that the new person will be a member
	of his letterbox.
	(create-person): Likewise.
2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388

	Clarify the documentation about accept_async and make the
	implementation conform to the documentation.
	* src/server/session.c (accept_async): Don't accept 1, 2, 3, 4 or
	10 (which are in the interval [0..ay_dummy_last) but not used).
	Complain about the first rejected async number, not the last.
	* doc/Protocol-A.texi (query-async): Added a reference to the
	currently preselected asynchronous messages, since the example is
	valid for lyskomd 1.9 but not lyskomd 2.0.
	(Asynchronous Messages): Encourage clients to use accept-async
	instead of trusting the defaults.  State that the obsolete calls
	may be non-existing.

	More test cases.
	* src/server/testsuite/lyskomd.0/03.exp: New file.
	* src/server/testsuite/lyskomd.0/01.exp: Use read_versions instead
	of duplicating code.
	* src/server/testsuite/config/unix.exp (read_versions): New
	function, extracted from ../lyskomd.0/01.exp.

	Makefile improvements.
	* src/server/testsuite/Makefile.am (MOSTLYCLEANFILES): Added *.sum
	and *.log.
	(check-l2g): New name for former target l2g_check.
	(check-lyskomd): New name for former target lyskomd_check.

	Remove some unused code.
	* src/libraries/libcommon/kom-errno.c (kom_perror): Was
	unused. Removed.
	* src/include/config.h (kom_errout): Was unused. Removed.

David Byers's avatar
David Byers committed
2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437
1998-10-04  David Byers  <davby@ida.liu.se>

	* configure.in: Output to include/config.h

	* src/server/aux-items.c (delete_aux_item_list): Call undelete
	triggers.

	* src/server/dbck.c: Moved BUGDECL to top level.

	* src/server/internal-connections.c (init_connection): Cast in
	comparisons to get rid of compiler warnings.

	* src/server/text-garb.c: Moved BUGDECL to top level.

	* src/server/person.c: Moved BUGDECL to top level.

	* src/server/conference.c: Moved BUGDECL to top level.

	* src/server/membership.c (do_change_priority): Only fake the
	passive flag when fake_passive is true.

	* src/server/connections.c (dump_statistics): Remove compiler
	warnings by casting in comparisons.

	* src/include/kom-types.h: Declared fields of
	Version_info_internal const to get rid of compiler warnings (plus, 
	it makes sense.)

	* src/server/simple-cache.c (cached_get_text): Remove compiler
	warnings by casting in comparisons.

	* src/include/server/smalloc.h (SMALLOC_MAGIC_FREE): Declare
	constants as unsigned to avoid compiler warnings.

	* src/server/ram-parse.c (fparse_string): Remove compiler warnings 
	by casting in comparisons.

	* src/server/local-to-global.c (find_block): Removed const
	declarations to get rid of compiler warnings (it was cast away
	anyway.)

	* src/libraries/libcommon/kom-errno.c: Include kom-config

	* src/server/admin.c: Conditionally include config.h

	* src/server/dbck.c (check_membership): Check duplicated info
	between member and membership records. Redeclared mship param
	as non-const.

Per Cederqvist's avatar
Per Cederqvist committed
2438 2439 2440 2441
1998-10-04  Per Cederqvist  <ceder@lysator.liu.se>

	* TODO: New file.

2442 2443 2444 2445 2446 2447 2448 2449 2450 2451
1998-08-31  Per Cederqvist  <ceder@gratia>

	Added more tests and documentation.
	* doc/Protocol-A.texi (get-text): Uses the text-zero error code.
	(get-text-stat-old): Likewise.
	(get-text-stat): Likewise.
	* src/server/testsuite/lyskomd.0/02.exp: Added tests for
	get-text-stat and get-text-stat-old.  Check that a text wiht one
	public and one secret recipient is properly filtered.

2452 2453
1998-08-30  Per Cederqvist  <ceder@lysator.liu.se>

2454 2455 2456 2457
	query-predefined-aux-items was broken.
	* src/server/aux-items.c (query_predefined_aux_items): Added a
	missing statement so that the next link really is followed.

2458 2459
	Added more tests and documentation.
	* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
2460
	89-104.
2461 2462 2463
	* doc/Protocol-A.texi (get-conf-stat): Removed a note that said
	that only the old bits of the Any-Conf-Type are returned by this
	call.
2464 2465 2466 2467 2468
	(Protocol Requests): 47 is obsoleted by 104.
	(get-created-texts): 47 is obsoleted by 104.
	(set-membership-type): Document the login-first error code.
	(local-to-global): Likewise.
	(map-created-texts): New node.  More documentation is needed here.
2469

2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501
1998-08-29  Per Cederqvist  <ceder@lysator.liu.se>

	Introduce Aux-Item-Input in the protocol spec.  (It is a subset of
	Aux-Item.)  Don't include aux_no in it.
	* src/server/testsuite/lyskomd.0/00.exp: Don't send the aux_no
	field in Aux-Item-Input data.
	* src/server/prot-a-parse.c (prot_a_parse_aux_item): Don't expect
	the aux_no field.  Leave that field as garbage.
	* doc/Protocol-A.texi (LysKOM Data Types): Added Aux-Item-Input.
	Removed the '<10>' indicator in the Text-Stat declaration.
	(create-text): Use type Aux-Item-Input for input parameters.
	(create-anonymous-text): Likewise.
	(create-conf): Likewise.
	(create-person): Likewise.
	(modify-text-info): Likewise.
	(modify-conf-info): Likewise.
	(modify-system-info): Likewise.

	Clean up Protocol-A.texi.
	* doc/Makefile.am (protocol-a.info): Don't allow tabs in the
	document.
	* doc/Protocol-A.texi: Write all types as "Foo-Bar", never
	"Foo-bar".  Don't use tabs.
	(Notation): Be explicit about how types are written.

	Misc documentation fixes.
	* doc/Protocol-A.texi (who-is-on-ident): Corrected the return type
	to ARRAY Who-Info-Ident.
	(modify-system-info): Changed the type of the times-to-delete
	argument from the undefined type Number-List to ARRAY Aux-No.
	(set-info): This accepts an Info-Old, not an Info.

2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522
1998-08-29  Per Cederqvist  <ceder@gratia>

	Fixed a memory problem in get_collate_table.
	* src/server/admin.c (get_collate_table): The result contains
	garbage on entry, so don't call s_clear() on it.

	Added more tests and documentation.
	* src/server/testsuite/lyskomd.0/01.exp: Read $top_srcdir/versions
	instead of ../version.incl, so the script gets all the versions.
	Added tests for requests 63-88.
	* src/server/testsuite/Makefile.am (site.exp): Depends on
	Makefile.  Set top_srcdir, but not srcdir.  (srcdir can still be
	used in the test scripts, since runtest sets it when the --srcdir
	option is used.)
	* doc/Protocol-A.texi (LysKOM Data Types): The invisible bit is
	always set for sessions where no-one is logged on.
	(who-is-on-dynamic): Likewise.
	(set-info): The version number was missing from the example.
	(create-conf): Indentation fixes.

1998-08-28  David Kgedal  <davidk@lysator.liu.se>
2523 2524 2525 2526 2527

	* doc/Protocol-A.texi: Cleaned up the call definitions.  Removed
 	all type synonyms for ARRAY types.  Conference had an extra 'type'
	field.

2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542
1998-08-28  Per Cederqvist  <ceder@gratia>

	Added more tests and documentation.
	* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
	51-62.
	* doc/Protocol-A.texi (LysKOM Data Types): The order of the
	elements in Who-Innfo-Old was wrong.  The same bug existed at
	least as far back as in the prot-A.txt file that was distributed
	with the 1.7.0 server.  I find it better to change the
	documentation than the code.
	(create-person-old): Document the auto-login feature.
	(who-is-on): Clarify which sessions that are returned.
	(get-unread-confs): Clarify that this request may return extra
	conferences.  This request may not be made before you log in.

2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555
1998-08-27  Per Cederqvist  <ceder@gratia>

	Added more tests and documentation.
	* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
	42-50.
	* doc/Protocol-A.texi (LysKOM Data Types): Removed Member-Old and
	Member-List-Old.
	(shutdown-kom): exit-val is an argument to the request, not the
	result from the request.
	(get-members-old): Simplified the return value to "ARRAY Pers-No"
	instead of "Member-List-Old".  Explicitly state that the returned
	list is truncated if there are too few members of the conference.

2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570
1998-08-25  Per Cederqvist  <ceder@lysator.liu.se>

	The request 36=get-info was broken.
	* src/server/fncdef.txt (get_info_old): Returns an info_old, not
	an info.

	Added more tests and documentation.
	* src/server/testsuite/lyskomd.0/01.exp: Added tests for requests
	32-41.
	* doc/Protocol-A.texi (LysKOM Data Types): Document the
	aux-item-list part of the Info structure.
	(who-is-on-old): Document that the returned list contains only
	sessions that are logged in visibly.

1998-08-25  Per Cederqvist  <ceder@gratia>
2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589

	Documentation fixes: async-login was wrong.
	* doc/Protocol-A.texi (LysKOM Data Types): Added Any-Conf-Type to
	the type index.
	(get-text): Never fails with login-first.  The no-such-text error
	is used when the user isn't logged in.
	(get-text-stat-old): Likewise.
	(get-text-stat): Likewise.
	(async-login): This async message includes a session number.

	More test cases added.
	* src/server/testsuite/config/unix.exp (any_num): New constant.
	(lyskomd_start): Increase the timeout around the start of lyskomd,
	since it can take quite a while on slow computers.
	* src/server/testsuite/lyskomd.0/01.exp: Added tests of more requests.
	* src/server/testsuite/lyskomd.0/02.exp: New file.
	* src/server/testsuite/Makefile.am (lyskomd_check): Added a
	missing quote character.

2590 2591 2592 2593 2594 2595 2596 2597
1998-08-23  Per Cederqvist  <ceder@lysator.liu.se>

	Fixed the documentation of 12=lookup-name.
	* doc/Protocol-A.texi (LysKOM Data Types): Documented
	Conf-List-Archaic.
	(lookup-name): This request returns a Conf-List-Archaic, not a
	Conf-No-List.  Added an example.

2598 2599
1998-08-22  Per Cederqvist  <ceder@lysator.liu.se>

2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628
	Document more of the used error codes.
	* doc/Protocol-A.texi (get-person-stat-old): Added error code
	`login-first'.
	(login): Added error code `conference-zero'.
	(Error Codes): Renamed `illegal-password' to `invalid-password',
	which is the name the rest of the document uses.

	More test cases.
	* src/server/testsuite/lyskomd.0/01.exp: New test suite.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Create a
	fresh database before starting lyskomd.
	* src/server/testsuite/Makefile.am (lyskomd_check): Don't create
	the database before running the lyskomd tests.

	Fixed bugs from the Local_to_global introduction.
	* src/server/membership.c (adjust_read): Fixed a fencepost error
	that was introduced 1998-07-26.
	* src/server/ram-output.c (foutput_text_list): Handle empty text
	lists properly.
	* src/server/prot-a-output.c (prot_a_output_person): Handle empty
	Local_to_global structures properly.
	(prot_a_output_conference): Likewise.
	(prot_a_output_conference_old): Likewise.
	* src/server/ram-output.c (foutput_text_list): Handle empty text
	lists that once was non-empty properly.

	Added indices to the protocol specification.
	* doc/Protocol-A.texi: Added a Request Index and a Type Index.

2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644
	Eliminated a race condition in the test case.
	* src/server/testsuite/config/unix.exp (lyskomd_death):
	Synchronize with the lyskomd process so that it dies at a proper
	time.
	* src/server/ramkomd.c (main): Don't terminate until a
	confirmation is read on stdin when running under DejaGnu.

	Implemented map_created_texts.
	* src/include/services.h (map_created_texts): New function.
	* src/server/person.c (map_created_texts): New function.
	* src/server/fncdef.txt: Added map_created_texts.
	* src/server/prot-a.c (prot_a_is_legal_fnc): Added
	call_fnc_map_created_texts.
	* src/server/testsuite/lyskomd.0/00.exp: Added test cases for
	map_created_texts.

2645 2646 2647 2648 2649 2650
1998-08-16  Per Cederqvist  <ceder@lysator.liu.se>

	Documented all undocumented Aux-Items.
	* doc/Protocol-A.texi (Predefined Aux-Item Types): Documented
	aux-items 13, 14 and 15.

2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663
1998-08-14  Per Cederqvist  <ceder@signum.se>

	The cache tried to free person, text and conference 0 during
	server shutdown.
	* src/server/simple-cache.c (free_all_cache): Don't attempt to
	access Pers_no, Conf_no or Text_no 0.
	(get_conf_node): Fail if the argument is less than 1.
	(get_pers_node): Likewise.
	(get_text_node): Likewise.
	(traverse_person): Unused function; don't compile it.

	* run-support/aux-items.conf (creating-software): New aux-info.

2664 2665 2666 2667 2668 2669 2670
1998-08-10  Per Cederqvist  <ceder@gratia>

	Ported the test suite to DejaGnu 1.2.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Added
	missing global declarations.
	(l2g_start): Likewise.

Per Cederqvist's avatar
Per Cederqvist committed
2671 2672 2673 2674 2675 2676
1998-08-10  Per Cederqvist  <ceder@signum.se>

	Typo in a Makefile.am fixed.
	* src/server/testsuite/config/Makefile.am (lyskomd-config): Added
	a missing quote.

2677 2678
1998-08-09  Per Cederqvist  <ceder@lysator.liu.se>

2679 2680 2681 2682
	Fixed bugs in get_created_texts.
	* src/server/person.c (get_created_texts): Fixed a fencepost error
	and two other errors, all introduced 1998-07-26.

2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711
	Test suite improvements.
	* src/server/testsuite/lyskomd.0/00.exp: Added more tests.  Added
	tests for get-created-texts.
	* src/server/testsuite/l2g.0/10.exp: New file.
	* src/server/testsuite/config/unix.exp (l2g_stop): Send a quit
	command to test-l2g, so that we can be sure that the test case
	doesn't miss some unexpected final output from the test program.
	(unanchored_expect): Fixed an error message.
	* src/server/testsuite/test-l2g.c (main): Added 'q' (quit)
	command.

	Fixed more bugs in get_map.
	* src/server/text.c (get_map): Set result.first_local_no correctly
	if the map in the conference is completely empty.
	* src/server/prot-a-output.c
	(prot_a_output_l2g_iterator_as_text_list): Don't forget to emit
	trailing zeroes in the text-list.

	Document some previously undocumented behavior of get-map and
	get-created-texts.
	* doc/Protocol-A.texi (get-map): Document what happens when
	attempting to retrieve texts before the start of the map.
	(get-created-texts): Likewise.

	The L2g_iterator sometimes iterated past the end of a bounded search.
	* src/server/local-to-global.c (l2gi_searchsome): Set search_ended
	correctly when the end is set so that the iterator will loop over
	nothing, even though later texts exists.

2712 2713 2714 2715 2716
	Let automake generate the INSTALL file.
	* README: Include the contents of the INSTALL file.  This file
	needs a major overhaul.
	* mkmi: Remove INSTALL and expect automake to recreate it.

2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729
	Removed GNU malloc.  The integration was poor, to say the least,
	and it was not generally an improvement to use GNU malloc.
	* src/server/testsuite/Makefile.am: Removed references to gnumalloc.
	* src/server/Makefile.am: Removed reference to gnumalloc.
	* src/libraries/Makefile.am (SUBDIRS): Removed @GNUMALLOC@.
	* INSTALL: Don't mention GNU malloc.
	* configure.in: --with-gnu-malloc: flag removed.  Don't substitute
	GNUMALLOC.  Don't define USE_GNU_MALLOC or USING_GNU_MALLOC.
	Don't use the following that was only used because of GNU malloc:
	SUNOS_LOCALTIME_BUG, getpagesize, memmove, AC_USG.  Don't attempt
	to create src/libraries/gnumalloc/Makefile.
	* src/libraries/gnumalloc: All files in this directory removed.

2730 2731 2732 2733
	Added sanity check to local_to_global.
	* src/server/text.c (local_to_global): Check that the no_of_texts
	argument isn't larger than 255.

2734 2735
1998-08-08  Per Cederqvist  <ceder@lysator.liu.se>

2736 2737 2738 2739
	Fixed a protocol error with async_deleted_text.
	* src/server/prot-a-send-async.c (prot_a_async_deleted_text):
	Fixed the size in the header.  This emits 18 elements, not 16.

Per Cederqvist's avatar
Per Cederqvist committed
2740 2741 2742 2743 2744
	Minor documentation fixes.
	* doc/aux-info.doc: Document dont-garb.
	* doc/Protocol-A.texi: Spell checking performed.  Some other minor
	typos fixed.  State that the aux-item read-confirm should only be
	added after the user has acknowledged that he has read the text.
2745 2746 2747 2748
	(accept-async): Moved some text that belonged here from the
	query-async node.  The error-status indicates the first offending
	number, not the index of the first offending number, when
	unknown-async is returnd.
Per Cederqvist's avatar
Per Cederqvist committed
2749
	
2750 2751 2752 2753 2754 2755
	Fixed bugs in get_map and local_to_global.
	* src/server/text.c (get_map): Fixed a couple of fence errors.
	(local_to_global): Using first_local_no==0 is an error.  Fixed a
	fence error.
	* src/server/prot-a-output.c (prot_a_output_text_mapping): Emit
	"0" or "1", not "48" or "49", as the later-texts-exists flag.
2756
	Fixed a bug that could cause much too much data to be written.
2757 2758 2759

	Fixed bugs and made improvements to the test cases for get_map and
	local_to_global.
2760 2761
	* src/server/testsuite/lyskomd.0/00.exp: Many bugs fixed.  Several
	tests added. 
2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777
	* src/server/testsuite/config/unix.exp (attach): New constant.
	(line_leader): New variable.
	(meta_line_leader): New variable.
	(l2g_start): Set l2g_id, expect_active and expect_always.
	(fix_expect_after): New proc.
	(simple_expect): New argument: meta.  Handle line leaders.
	Removed tests for unexpected lines, which should now be handled
	via expect_active.
	(unanchored_expect): Added missing quotes.
	(lyskomd_start): Handle attach.  Set expect_active and
	expect_always to something sane.
	(client_start): Use tcpconnect.py and line leaders to make it
	easier to debug the test cases.  Set expect_active and
	expect_always to something sane.
	(talk_to): Handle l2g.  Handle line leaders.  Call
	fix_expect_after.
2778
	(client_death): New proc.
2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793
	* src/server/testsuite/tcpconnect.py: New file.
	* src/server/testsuite/Makefile.am (../lyskomd): New target.
	(lyskomd_check): Depend on ../lyskomd.
	(site.exp): Added srcdir.
	(EXTRA_DIST): Added tcpconnect.py.
	* src/server/Makefile.am (all-recursive check-recursive): Depend
	on lyskomd.
	
	Read the file name of the "Aux-item definition file" from the
	config file, not from the command line.
	* src/server/testsuite/config/Makefile.am (lyskomd-config): Added
	"Aux-item definition file".
	* src/server/server-config.c (parameters): Added "Aux-item
	definition file".
	(AUX_DEF_FILE): Removed.
2794 2795
	(read_configuration): Handle aux_def_file just like all the other
	file names.
2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822
	* src/server/ramkomd.c (initialize): Removed the aux_def_file
	argument.  All callers updated.  Get the file of the aux_def_file
	from the config file.
	(main): Removed the -c and -a options.  This reverts the change
	from Sat Sep 13 15:07:32 1997.  It is more consistent to get the
	file name of the aux-def file from the config file.  The -c option
	was buggy anyhow.
	* src/server/param.h (struct kom_par): Added aux_def_file.
	* doc/man/lyskomd.8: Removed the -c and -c flags.  Added "Aux-item
	definition file".
	* src/include/config.h (AUX_DEF_FILE): Constant removed.

	Default to sending async_new_text_old and ay_leave_conf, bug not
	async_new_text, just as the documentation says.
	* src/server/send-async.c (async_new_text_old): Use
	prot_a_async_new_text_old, not prot_a_async_new_text.
	* src/server/async.h (ASYNC_DEFAULT_MESSAGES): Added
	ay_new_text_old instead of ay_new_text.  Added ay_leave_conf.

	Get rid of some compiler warnings.
	* src/server/rfc931.c (get_real_username): Mark unused arguments.
	* src/server/dbck-cache.c (cached_lock_person): Marked unused
	arguments.
	(cached_unlock_person): Likewise.
	(cached_lock_conf): Likewise.
	(cached_unlock_conf): Likewise.

2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838
1998-08-07  Per Cederqvist  <ceder@signum.se>

	Merged old uncommitted changes to prot-A.txt.
	* doc/prot-A.txt: Error code 38=no-connect is no longer used.
	Documented 85=get-collate-table.  Typo fixes.

	Facilitate testing of Local_to_global with Electric Fence.
	* src/server/testsuite/config/unix.exp (efence): New constant.
	(efence_blurb): New proc.
	(l2g_start): Handle an efence-instrumented test program if the
	global variable efence is true.

	Improved the documentation on the config file.
	* doc/man/lyskomd.8: Documented the values that you can pass to
	bool config parameters.

2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868
1998-08-06  Per Cederqvist  <ceder@lysator.liu.se>

	Added the beginnings of a test suite for the complete lyskomd
	binary.
	* README: Talk a little about the test suite.
	* src/server/testsuite/Makefile.am (l2g_check): Added --srcdir to
	the runtest command line.
	(lyskomd_check): New target.
	* src/server/testsuite/Makefile.am (check): Added lyskomd_check.
	* src/server/testsuite/lyskomd.0/00.exp: New file.
	* src/server/testsuite/config/unix.exp:
	(hollerith): New constant.
	(maxint): New constant.
	(clientport): New constant.
	(muxport): New constant.
	(unanchored_expect): Continue with the expect if an unexpected
	line is detected.
	(lyskomd_start): New proc.
	(lyskomd_death): New proc.
	(client_start): New proc.
	(talk_to): New proc.
	(holl): New proc.
	* src/server/testsuite/config/Makefile.am (noinst_DATA): Added
	lyskomd-config.
	(lyskomd-config): New target.

	Regenerate protocol-a.info automatically.
	* doc/Makefile.am (protocol-a.info): Added an explicit rule
	because Automake 1.3 fails to add it automatically.

2869 2870
1998-08-05  Per Cederqvist  <ceder@lysator.liu.se>

2871 2872 2873 2874
	Fixed the documentation for the local-to-global call.
	* doc/Protocol-A.texi (LysKOM Data Types): Changed the name of the
	type Local-To-Global_Result to Text-Mapping.  All uses updated.

2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889
	Implemented the local-to-global call.
	* src/server/fncdef.txt: Added local_to_global.
	* src/include/services.h (local_to_global): New function.
	* src/include/kom-types.h (Text_mapping): New type.
	* src/server/text.c (get_map): Fixed the type of the no_of_texts
	argument.
	(local_to_global): New function.
	* src/server/prot-a.c (prot_a_reply): Handle rt_text_mapping.
	(prot_a_is_legal_fnc): Handle call_fnc_local_to_global.
	* src/server/prot-a-output.c (prot_a_output_text_mapping): New
	function.
	* src/server/prot-a-output.h: Likewise.
	* src/server/connections.h (Res_type): Added rt_text_mapping.
	(Result_holder): Added text_mapping.

2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902
1998-08-03  Per Cederqvist  <ceder@lysator.liu.se>

	Document the local-to-global call.
	* doc/Protocol-A.texi (Articles): Refer to local-to-global instead
	of get-map.
	(LysKOM Data Types): Added subsection titled "Mapping Local to
	Global Text Numbers".
	(Protocol Requests): Mark get-map as obsolete, and refer to 103.
	Added 103=local-to-global.
	(get-map): This is superseded by local-to-global.
	(accept-async): Fixed typo.
	(local-to-global): New node.

2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918
1998-08-02  Per Cederqvist  <ceder@lysator.liu.se>

	Generate and install protocol-a.info.
	* doc/Makefile.am (info_TEXINFOS): New target.  Moved
	Protocol-A.texi here.
	(EXTRA_DIST): Moved Protocol-A.texi to info_TEXINFOS.
	* mkmi: Remove scripts/texinfo.tex and expect automake to
	regenerate it.

	Minor syntactic documentation fixes.
	* doc/Protocol-A.texi: Added @dircategory and @direntry commands.
	(Protocol Requests): Added set-membership-type to the menu.
	(set-membership-type): Minor typo fixed.
	(Top): State that this is a draft, and that the version numbers
	are wrong.

2919 2920 2921 2922 2923 2924 2925
1998-07-27  Per Cederqvist  <ceder@lysator.liu.se>

	Fixed a pointer bug in Local_to_global.
	* src/server/local-to-global.c (join_range): Fixed a bug where
	a pointer that pointed to the old position of a reallocated block
	was used.

Per Cederqvist's avatar
Per Cederqvist committed
2926 2927
1998-07-26  Per Cederqvist  <ceder@lysator.liu.se>

2928 2929 2930 2931 2932 2933 2934
	dbck can now read database format 2.
	* src/server/dbck-cache.c (init_cache): Handle database format 2.

	Fix the bootstrap database.
	* db-crypt/db/lyskomd-data: CONF-RECORD uses the Local_to_global
	structure.

2935 2936 2937 2938 2939 2940 2941 2942 2943
	Remove all traces of the Text_list type.
	* src/include/kom-types.h (Text_list): Removed.
	* src/server/connections.h (Res_type): Removed rt_text_list.
	(Result_holder): Removed text_list.
	* src/server/prot-a-output.h (prot_a_output_text_list): Removed.
	* src/server/prot-a-output.c (prot_a_output_text_list): Removed.
	* src/server/prot-a.c (prot_a_reply): Don't attempt to handle
	rt_text_list.

Per Cederqvist's avatar
Per Cederqvist committed
2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185
	Code cleanup.
	* src/server/aux-item-def.y: Fixed indentation of include statements.
	* src/server/aux-item-def.lex.c: No longer kept under version
	control.

	Improve documentation.
	* doc/server.extend: Updated.

	Start using the Local_to_global structure.
	* doc/lyskomd-database-format (DATABASE VERSION 2): CONF-RECORD
	and PERS-RECORD uses the Local_to_global structure.
	* configure.in: Added AC_C_INLINE.
	* src/server/text.c (add_text_in_conf): Adjusted to the fact that
	the texts member of Conference is now a l2g.
	(do_sub_recpt): Likewise.
	(set_loc_no): Removed.
	(adjust_text_list): Removed.
	(do_delete_text): Adjusted to the fact that the created_texts
	member of Person is now a l2g.
	(do_create_text): Likewise.
	(get_map): The result argument now points to a
	l2g_iterator_as_text_list instead of a Text_list.  Adjusted to the
	fact that the texts member of Conference is now a l2g.
	* src/server/simple-cache.c (mark_conference_as_changed): Adjusted
	to the fact that the texts member of Conference is now a l2g.
	(setup_small_conf): Likewise.
	* src/server/ram-parse.h (fparse_text_list): Removed.
	* src/server/ram-parse.c (fparse_conference_2): Use l2g_read
	instead of fparse_text_list.
	(fparse_person_2): Likewise.
	(fparse_text_list): The result argument now points to a
	Local_to_global instead of a Text_list.
	* src/server/ram-output.h (foutput_text_list): The text_list
	argument is now a pointer to Local_to_global instead of a
	Text_list.
	* src/server/ram-output.c (foutput_person_0): Adjusted to new API
	of foutput_text_list.
	(foutput_person_2): Use l2g_write instead of foutput_text_list.
	(foutput_conference_2): Likewise.
	(foutput_conference_1): Adjusted to new API of foutput_text_list.
	(foutput_conference_0): Likewise.
	(foutput_text_list): The text_list argument is now a pointer to
	Local_to_global instead of a Text_list.  The generated output is
	still the same.
	(foutput_ulong): Eliminated a future buffer overrun.  Cleaned up
	the code.
	* src/server/prot-a.c (prot_a_reply): Handle
	rt_l2g_iterator_as_text_list.
	* src/server/prot-a-output.h
	(prot_a_output_l2g_iterator_as_text_list): New function.
	* src/server/prot-a-output.c (prot_a_output_person): Adjusted to
	the fact that the created_texts member of Person is now a l2g.
	(prot_a_output_conference): Adjusted to the fact that the texts
	member of Conference is now a l2g.
	(prot_a_output_conference_old): Likewise.
	(prot_a_output_l2g_iterator_as_text_list): New function which
	emulates a Text_list.
	* src/server/person.c (do_delete_pers): Adjusted to the fact that
	the created_texts member of Person is now a l2g.
	(get_created_texts): The return value is now an
	l2g_iterator_as_text_list, not a Text_list.  Adjusted to the fact
	that the created_texts member of Person is now a l2g.
	* src/server/memory.c (clear_text_list): Removed.
	(copy_text_list): Removed.
	(clear_conference): Adjusted to the fact that the texts member of
	Conference is now a l2g.
	(init_conference): Likewise.
	(copy_conference): Likewise.  Added const qualifier to the
	argument.
	(clear_person): Adjusted to the fact that the created_texts member
	of Person is now a l2g.
	(copy_person): Likewise.
	(init_person): Likewise.
	(init_text_list): Removed.
	(copy_aux_item_list): Added const qualifier to the src argument.
	* src/server/membership.c (add_rec_time): Adjusted to the fact
	that the texts member of Conference is now a l2g.
	(adjust_read): Likewise.
	(mark_as_read): Likewise.
	(check_membership): Likewise.
	(set_unread): Likewise.
	(set_last_read): Likewise.
	* src/server/kom-memory.h (copy_conference): The argument is const.
	(copy_aux_item_list): Likewise.
	(init_text_list): Removed.
	* src/server/fncdef.txt (get_map): Changed return type from
	text_list to l2g_iterator_as_text_list.
	(get_created_texts): Likewise.
	* src/server/dbck.c (struct delete_list): New struct.
	(delete_list_append): New static function.
	(execute_deletions): New static function.
	(check_misc_infos): Adjusted to the fact that the texts member of
	Conference is now a l2g.
	(adjust_text_list): Deleted.
	(check_created_texts): The "created" argument now points to a
	Local_to_global.  Removed the check for "bad created_texts array"
	since it can no longer be bad in that way.
	(check_membership): Adjusted to the fact that the texts member of
	Conference is now a l2g.
	(check_texts_in_conf): The "tlist" argument now points to a
	Local_to_global.  Removed the check for "bad created_texts array"
	since it can no longer be bad in that way.
	* src/server/dbck-cache.c (cached_get_highest_local_no): Adjusted
	to the fact that the texts member is now a l2g.
	(cache_sync): Fixed type in some printf format strings.
	* src/server/connections.h (Res_type): Added
	rt_l2g_iterator_as_text_list.
	(Result_holder): Added l2g_iterator_as_text_list.
	* src/server/conference.c: (do_delete_conf): Adjusted to the fact
	that the texts member is now a l2g.
	* src/server/Makefile.am (DBCK): Added local-to-global.c.
	(all-recursive, check-recursive): Require libcheck.a to be built.
	* src/include/services.h (get_created_texts): Changed type of
	the result to L2g_iterator_as_text_list.
	(get_map): Likewise.
	* src/include/kom-types.h (struct l2g_block_info): New forward
	declaration.
	(Local_to_global): New type.
	(L2g_iterator): New type.
	(L2g_iterator_as_text_list): New type.
	(Conference): The texts member is now a Local_to_global, not a
	Text_list.
	(Person): The created_texts member is now a Local_to_global, not a
	Text_list.

	Fixes and improvements to the Local_to_global structure.
	* src/server/local-to-global.h (L2G_BLOCKSIZE): Moved to
	local-to-global.c.
	(L2g_block_info): Likewise.
	(Local_to_global): Likewise.
	(l2g_copy): Switched placement of src and dest to match other copy
	functions in the lyskomd code.  Added const qualifier.
	(l2g_lookup): Added const qualifier to the l2g argument.
	(l2g_next_key): Likewise.
	(l2g_compact): Removed.
	(l2g_first_appendable_key): New function.
	(l2g_delete_global_in_sorted): New function.
	(l2g_dump): Switch placement of l2g and file arguments to match
	other similar functions in the lyskomd code.  Added const
	qualifier.
	(l2g_write): Likewise.
	(l2g_read): Likewise.
	(l2g_searchall): Added const qualifier.
	(L2g_iterator): Moved to kom-types.h.
	(l2gi_searchsome): Added const qualifier.
	(l2gi_begin): New function.
	(l2gi_end): New function.
	* src/server/local-to-global.c: Include assert.h.  Only include
	stdlib.h if HAVE_STDLIB_H.  Include stdio.h if we didn't get NULL
	from stdlib.h.  Inlucd lyskomd.h and server/smalloc.h.
	(L2G_BLOCKSIZE): Moved here from local-to-global.h.
	(struct l2g_block_info): Likewise.
	(is_dense): New static function.
	(is_empty): New static function.
	(key_value): New static function.
	(sparse_skip_deleted): New static function.
	(sparse_locate_value): New static function.
	(sparse_compact): New static function.
	(add_block): Use srealloc instead of realloc.  Don't initialize
	start -- the caller is responsible for doing so.
	(delete_block): Use sfree instead of free, and srealloc instead of
	realloc.
	(make_sparse): Don't change the value of start, since there is no
	need to, and make_sparse may now be called on an empty block,
	which would cause start to be set to a garbage value.
	(find_block): Added a const qualifier to the return value and l2g
	argument.  Use key_value to simplify code.
	(find_block_index_key): Added a const qualifier to the l2g
	argument.  Use helper functions to simplify the code.  Use
	sparse_skip_deleted so that the function never returns a deleted
	key.  Never return deleted keys in dense blocks either.
	(join_range): New static function.
	(join_blocks): New static function.
	(l2g_init): Set first_unused to 1.
	(l2g_clear): Use sfree instead of free.  Set first_unused to 1.