membership.c 47.3 KB
Newer Older
Linus Tolke's avatar
Linus Tolke committed
1
/*
2
 * $Id: membership.c,v 0.74 2002/11/06 19:46:17 ceder Exp $
Per Cederqvist's avatar
Per Cederqvist committed
3
 * Copyright (C) 1991-2002  Lysator Academic Computer Association.
Linus Tolke's avatar
Linus Tolke committed
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
 *
 * This file is part of the LysKOM server.
 * 
 * LysKOM is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License as published by 
 * the Free Software Foundation; either version 1, or (at your option) 
 * any later version.
 * 
 * LysKOM is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with LysKOM; see the file COPYING.  If not, write to
 * Lysator, c/o ISY, Linkoping University, S-581 83 Linkoping, SWEDEN,
 * or the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, 
 * MA 02139, USA.
 *
 * Please mail bug reports to bug-lyskom@lysator.liu.se. 
 */
Per Cederqvist's avatar
Per Cederqvist committed
25
26
27
28
29
30
/*
 * membership.c
 *
 * All atomic calls that controlls who is a member in what.
 * (The person/conf relation).
 */
Per Cederqvist's avatar
Per Cederqvist committed
31

David Byers's avatar
David Byers committed
32
33
34
35
36
37


#ifdef HAVE_CONFIG_H
#  include <config.h>
#endif

Per Cederqvist's avatar
Per Cederqvist committed
38
39
40
#define DEBUG_MARK_AS_READ

#include <stdio.h>
Per Cederqvist's avatar
Per Cederqvist committed
41
42
43
#ifdef HAVE_STRING_H
#  include <string.h>
#endif
44
#include <stddef.h>
Per Cederqvist's avatar
Per Cederqvist committed
45
#include <time.h>
Per Cederqvist's avatar
Per Cederqvist committed
46
#include <setjmp.h>
47
#include <sys/types.h>
Per Cederqvist's avatar
Per Cederqvist committed
48
49

#include "misc-types.h"
50
#include "s-string.h"
Per Cederqvist's avatar
Per Cederqvist committed
51
52
53
#include "kom-types.h"
#include "services.h"
#include "server/smalloc.h"
Per Cederqvist's avatar
Per Cederqvist committed
54
55
#include "lyskomd.h"
#include "com.h"
56
#include "async.h"
Per Cederqvist's avatar
Per Cederqvist committed
57
58
#include "connections.h"
#include "internal-connections.h"
Per Cederqvist's avatar
Per Cederqvist committed
59
60
61
62
63
#include "kom-errno.h"
#include "manipulate.h"
#include "cache.h"
#include "send-async.h"
#include "minmax.h"
Per Cederqvist's avatar
Per Cederqvist committed
64
#include "kom-memory.h"
65
#include "param.h"
66
#include "local-to-global.h"
67
#include "server-time.h"
Per Cederqvist's avatar
Per Cederqvist committed
68
69

#ifdef DEBUG_MARK_AS_READ
70
71
#  include "log.h"
#  include "ram-output.h"
Per Cederqvist's avatar
Per Cederqvist committed
72
73
#endif

74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
static void
set_membership_type_bits(Membership_type *type,
                    Bool invitation, Bool passive, Bool secret,
                    Bool reserved1, Bool reserved2, Bool reserved3, 
                    Bool reserved4, Bool reserved5)
{
    type->invitation = invitation;
    type->passive = passive;
    type->secret = secret;
    type->reserved1 = reserved1;
    type->reserved2 = reserved2;
    type->reserved3 = reserved3;
    type->reserved4 = reserved4;
    type->reserved5 = reserved5;
}

90
91
92
93
94
95
96
97
98
99
100
101
102

static enum memb_visibility
check_unread(Pers_no member)
{
    Person *memb_p;
    GET_P_STAT(memb_p, member, mv_none);
    if (memb_p->flags.unread_is_secret)
	return mv_censor_unread;
    else
	return mv_full;
}


103
enum memb_visibility
104
105
106
membership_visible(const Connection *viewer_conn,
		   Pers_no member,
		   Conf_no conf_no,
107
108
109
110
		   Membership_type type,
		   Bool is_supervisor_of_member,
		   Bool is_supervisor_of_conf)

111
{
112
113
114
115
    enum access ma = error;
    enum access ca = error;
    
    if (ENA_C(viewer_conn, admin, 2) || ENA_C(viewer_conn, wheel, 8))
116
117
	return mv_full;

118
119
120
121
122
    if (is_supervisor_of_member
	|| (ma = access_perm(member, viewer_conn, unlimited)) >= unlimited)
    {
	return mv_full;
    }
123

124
125
    if (is_supervisor_of_conf
	|| (ca = access_perm(conf_no, viewer_conn, unlimited)) >= unlimited)
126
127
128
    {
	return check_unread(member);
    }
129
130
131

    if (ma >= read_protected && ca >= read_protected && !type.secret)
	return check_unread(member);
132
133
134
135
    
    return mv_none;
}

Per Cederqvist's avatar
Per Cederqvist committed
136
137
138
139
140
141
142
/*
 * Copy all information that ACTPERS is authorized to know about ORIG_P's
 * membership in all conferences to CENSOR_P.
 *
 * This function is used in get_membership().
 */
static void
David Byers's avatar
Server    
David Byers committed
143
copy_public_confs (Connection * conn, /* The connection for which we copy */
144
		   Pers_no    pers_no,  /* The person being censored */
David Byers's avatar
Server    
David Byers committed
145
                   Person   * censor_p,	/* The censored Person-struct */
Per Cederqvist's avatar
Per Cederqvist committed
146
		   Person   * orig_p,	/* The uncensored Person-struct */
147
		   Bool	      want_read)
Per Cederqvist's avatar
Per Cederqvist committed
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
{
    int i;			/* Number of mships lefte in ORIG_P */
    Membership * censor_m;		/* Pointer in CENSOR_P */
    Membership * orig_m;	/* Pointer in ORIG_P */

    /* Copy all information except the secret. */
		    
    censor_p->conferences.confs
	= tmp_alloc( orig_p->conferences.no_of_confs * sizeof(Membership));
    censor_p->conferences.no_of_confs = 0;

    censor_m = censor_p->conferences.confs;
    orig_m   = orig_p->conferences.confs;

    for ( i = 0; i < orig_p->conferences.no_of_confs; i++, orig_m++ )
    {
164
165
166
167
	enum memb_visibility vis = membership_visible(
	    conn, pers_no, orig_m->conf_no, orig_m->type, FALSE, FALSE);

	if (vis > mv_none)
Per Cederqvist's avatar
Per Cederqvist committed
168
169
170
	{
	    *censor_m = *orig_m;

171
	    if (!want_read)
172
		censor_m->skip_read_texts = TRUE;
Per Cederqvist's avatar
Per Cederqvist committed
173

174
	    if (vis == mv_censor_unread)
Per Cederqvist's avatar
Per Cederqvist committed
175
176
	    {
		censor_m->last_time_read = NO_TIME;
177
178
		censor_m->no_of_read_ranges = 0;
		censor_m->read_ranges = NULL;
Per Cederqvist's avatar
Per Cederqvist committed
179
180
181
182
183
184
185
186
187
188
189
	    }
	    
	    ++censor_m;
	    ++censor_p->conferences.no_of_confs;
	}
    }
}

/*
 * Change the priority of a certain conference in a person.
 */
David Byers's avatar
David Byers committed
190

Per Cederqvist's avatar
Per Cederqvist committed
191
192
static void
do_change_priority (Membership * mship,
193
194
                    Conf_no conf_no,
                    Conference * conf_c,
195
196
		    unsigned char	 priority,
		    unsigned short	 where,
Per Cederqvist's avatar
Per Cederqvist committed
197
		    Pers_no	 pers_no,
198
		    Person     * pers_p,
David Byers's avatar
David Byers committed
199
200
                    Membership_type * type,
                    Bool            fake_passive)
Per Cederqvist's avatar
Per Cederqvist committed
201
202
{
    Membership tmp_conf;
David Byers's avatar
David Byers committed
203
    Member *mem;
Per Cederqvist's avatar
Per Cederqvist committed
204
    
David Byers's avatar
David Byers committed
205
    if (priority == 0 && fake_passive)
206
    {
David Byers's avatar
David Byers committed
207
        type->passive = 1;
208
209
210
211
212
    }
    else
    {
        mship->priority = priority;
    }
David Byers's avatar
David Byers committed
213

214
    mship->type = *type;
Per Cederqvist's avatar
Per Cederqvist committed
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
    
    /* Check range of where */
    
    if ( where >= pers_p->conferences.no_of_confs )
    {
	where = pers_p->conferences.no_of_confs - 1;
    }
    
    /* And now move the conference to slot number 'where' */
    
    if ( mship < pers_p->conferences.confs + where )
    {
	tmp_conf = *mship;
	while ( mship < pers_p->conferences.confs + where)
	{
	    *mship = *(mship + 1);
	    mship++;
	}
	*mship = tmp_conf;
    }
    else
    {
	tmp_conf = *mship;
	while ( mship > pers_p->conferences.confs + where)
	{
	    *mship = *(mship - 1);
	    mship--;
	}
	*mship = tmp_conf;
    }

David Byers's avatar
David Byers committed
246
247
248
    /* Sync the change with the corresponding member list */
    mem = locate_member(pers_no, conf_c);
    if (mem != NULL)
249
    {
David Byers's avatar
David Byers committed
250
251
        mem->type = *type;
        mark_conference_as_changed( conf_no );
252
253
    }

Per Cederqvist's avatar
Per Cederqvist committed
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
    mark_person_as_changed( pers_no );
}


/*
 * Insert a rec_time misc item to a text_status.
 * The item is put at position POS on the list. (0 == first)
 * Take no action if the misc_item at POS is a rec_time.
 * This function is only used when a person marks his letters as read.
 *
 *	Text_stat * text_stat_pointer	Textstatus to modify
 *	int	    pos			Where to insert rec_time
 */

static void
do_add_rec_time (Text_stat    * text_stat_ptr,
		 int		pos)
{
    int i;

    /* Defensive checks */
    if ( pos < 0 || pos > text_stat_ptr->no_of_misc )
    {
	restart_kom("do_add_rec_time() - illegal pos\n");
    }

    /* Check that no rec_time exists */

    if ( pos < text_stat_ptr->no_of_misc
	&& text_stat_ptr->misc_items[ pos ].type == rec_time )
    {
	return;
    }
    
    /* Allocate space */
    text_stat_ptr->misc_items
    = srealloc(text_stat_ptr->misc_items,
	       (++(text_stat_ptr->no_of_misc)) * sizeof(Misc_info));

    /* Move items. */

    for ( i = text_stat_ptr->no_of_misc - 1; i > pos; i-- )
    {
	text_stat_ptr->misc_items[ i ] = text_stat_ptr->misc_items[ i - 1 ];
    }

    /* Set type */
    text_stat_ptr->misc_items[ pos ].type = rec_time;

    /* Set value */
304
    text_stat_ptr->misc_items[ pos ].datum.received_at = current_time;
Per Cederqvist's avatar
Per Cederqvist committed
305
306
307
308
}

/*
 * add_rec_time adds a 'rec_time'  misc_item to text number LOC_NO in
David Byers's avatar
Server    
David Byers committed
309
310
 * conference CONF_C. The item will follow a recpt or cc_recpt to pers_no.
 * No action is taken if PERS_NO is not a recipient of the text, or the text
Per Cederqvist's avatar
Per Cederqvist committed
311
312
313
 * no longer exists, or the text has already been received.
 */
static void
314
add_rec_time(Conference * conf_c,
David Byers's avatar
Server    
David Byers committed
315
316
	     Local_text_no local_no,
             Pers_no pers_no)
Per Cederqvist's avatar
Per Cederqvist committed
317
318
319
320
321
322
{
    Bool 	  found;
    Text_no	  text_no;
    Text_stat 	* t_stat;
    int		  i;
    
323
    text_no = l2g_lookup(&conf_c->texts, local_no);
Per Cederqvist's avatar
Per Cederqvist committed
324
325
326
327
328
329

    if ( text_no == 0 )
    {
	return;			/* Text is deleted. */
    }
    
Per Cederqvist's avatar
Per Cederqvist committed
330
    VOID_GET_T_STAT(t_stat, text_no);
Per Cederqvist's avatar
Per Cederqvist committed
331
332
333
334
335
336
337
338
339

    /* locate the misc_item which says that ACTPERS is a recipient */

    for ( found = FALSE, i = 0; !found && i < t_stat->no_of_misc; i++ )
    {
	switch ( t_stat->misc_items[ i ].type )
	{
	case recpt:
	case cc_recpt:
340
	case bcc_recpt:
341
	    if ( t_stat->misc_items[ i ].datum.recipient == pers_no )
342
	    {
343
		do_add_rec_time( t_stat, i + 2 ); /* Add after loc_no */
344
345
346
347
		found = TRUE;
	    }
	    break;

Per Cederqvist's avatar
Per Cederqvist committed
348
349
350
351
352
353
354
355
356
	case comm_to:
	case comm_in:
	case footn_to:
	case footn_in:
	case loc_no:
	case rec_time:
	case sent_by:
	case sent_at:
	    break;
David Byers's avatar
David Byers committed
357
358
359
360

        case unknown_info:
        default:
            restart_kom("ERROR: bogus misc_info type detected in text %lu\n", text_no);
Per Cederqvist's avatar
Per Cederqvist committed
361
362
363
364
365
	}
    }

    if( found ==  FALSE )
    {
David Byers's avatar
David Byers committed
366
	kom_log("ERROR: add_rec_time(): found==FALSE\n");
Per Cederqvist's avatar
Per Cederqvist committed
367
368
369
370
371
372
373
    }
    
    mark_text_as_changed( text_no);
    return;
}

/*
374
375
 * Check if any read_ranges can be extended due to deleted texts.
 * Merge read_ranges blocks, if possible.
Per Cederqvist's avatar
Per Cederqvist committed
376
 *
377
378
379
 * This is currently only used from mark_as_read(), but it would be
 * good to have a background task that does this whenever a text has
 * been deleted.
Per Cederqvist's avatar
Per Cederqvist committed
380
381
 */
static void
382
383
adjust_read(Membership *m,
	    const Conference *conf)
Per Cederqvist's avatar
Per Cederqvist committed
384
{
385
386
387
388
389
390
391
    struct read_range *ptr;
    struct read_range *prev;
    struct read_range *next;
    struct read_range *tail;
    struct read_range *begin;
    struct read_range *end;

Per Cederqvist's avatar
Per Cederqvist committed
392
393
    Local_text_no   conf_max;	/* Highest used local_text_no in conf */
    Local_text_no   conf_min;	/* Lowest used local_text_no in conf */
394
395
396
397

    /* If nothing is marked as read, there is nothing to adjust.  */
    if (m->no_of_read_ranges == 0)
	return;
Per Cederqvist's avatar
Per Cederqvist committed
398

399
    /* (conf_min <= x < conf_max) if x is an existing local_text_no */
400
    conf_min = l2g_next_key(&conf->texts, 0);
401
402
    if (conf_min == 0)
	conf_min = l2g_first_appendable_key(&conf->texts);
403
    conf_max = l2g_first_appendable_key(&conf->texts);
Per Cederqvist's avatar
Per Cederqvist committed
404

405
406
    begin = &m->read_ranges[0];
    end = begin + m->no_of_read_ranges;
Per Cederqvist's avatar
Per Cederqvist committed
407

408
409
410
411
#ifdef DEBUG_MARK_AS_READ
    
    /* Check that the items in read_texts really ARE sorted in ascending order.
       If not, there is probably a bug in this routine or in mark_as_read. */
Per Cederqvist's avatar
Per Cederqvist committed
412

413
    for (ptr = begin; ptr < end; ptr++)
414
    {
415
	if (ptr->first_read > ptr->last_read)
Per Cederqvist's avatar
Per Cederqvist committed
416
	{
417
418
419
420
421
422
423
	    kom_log("Bad input to adjust_read. Conference %lu, Priority %lu."
		    " Range %lu-%lu is nonsensical.\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)ptr->first_read,
		    (unsigned long)ptr->last_read);
	    return;
Per Cederqvist's avatar
Per Cederqvist committed
424
	}
425
426

	if (ptr != begin && (ptr-1)->last_read >= ptr->first_read)
427
	{
428
429
430
431
432
433
434
435
436
	    kom_log("Bad input to adjust_read. Conference %lu, Priority %lu."
		    " Overlapping ranges: %lu-%lu, %lu-%lu.\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)(ptr-1)->first_read,
		    (unsigned long)(ptr-1)->last_read,
		    (unsigned long)ptr->first_read,
		    (unsigned long)ptr->last_read);
	    return;
437
438
	}
    }
439
440
441
#endif

    for (ptr = begin; ptr < end; ptr++)
Per Cederqvist's avatar
Per Cederqvist committed
442
    {
443
444
445
446
447
448
449
450
451
452
453
454
	if (ptr == begin)
	    prev = NULL;
	else
	    prev = ptr - 1;
	next = ptr + 1;
	if (next == end)
	    next = NULL;

	/* Try to lower first_read. */
	while (ptr->first_read > conf_min
	       && (prev == NULL || prev->last_read + 1 < ptr->first_read)
	       && l2g_lookup(&conf->texts, ptr->first_read - 1) == 0)
Per Cederqvist's avatar
Per Cederqvist committed
455
	{
456
	    ptr->first_read--;
Per Cederqvist's avatar
Per Cederqvist committed
457
	}
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483

	/* Try to raise last_read. */
	while (ptr->last_read < conf_max - 1
	       && (next == NULL || ptr->last_read < next->first_read - 1)
	       && l2g_lookup(&conf->texts, ptr->last_read + 1) == 0)
	{
	    ptr->last_read++;
	}
    }

    /* Join any ranges that became adjacent. */
    tail = begin;
    for (ptr = begin + 1; ptr < end; ptr++)
    {
	if (tail->last_read + 1 == ptr->first_read)
	    tail->last_read = ptr->last_read;
	else if (++tail != ptr)
	    *tail = *ptr;
    }
    if (end != tail + 1)
    {
	end = tail + 1;
	m->no_of_read_ranges = end - begin;
	m->read_ranges = srealloc(
	    m->read_ranges,
	    m->no_of_read_ranges * sizeof(m->read_ranges[0]));
Per Cederqvist's avatar
Per Cederqvist committed
484
485
    }

486
#ifndef NDEFENSIVE_CHECKS
Per Cederqvist's avatar
Per Cederqvist committed
487
488
    
    /* Check that the items in read_texts really ARE sorted in ascending order.
489
490
491
       If not, there is probably a bug in this routine or in mark_as_read. */

    for (ptr = begin; ptr < end; ptr++)
Per Cederqvist's avatar
Per Cederqvist committed
492
    {
493
	if (ptr->first_read > ptr->last_read)
Per Cederqvist's avatar
Per Cederqvist committed
494
	{
495
496
497
498
499
500
501
502
	    kom_log("Bug in adjust_read. Conference %lu, Priority %lu."
		    " Range %lu-%lu is nonsensical (fixed).\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)ptr->first_read,
		    (unsigned long)ptr->last_read);
	    ptr->last_read = ptr->first_read;
	    return;
Per Cederqvist's avatar
Per Cederqvist committed
503
504
	}

505
506
507
508
509
510
511
512
513
514
515
516
517
	if (ptr != begin && ptr->first_read <= (ptr-1)->last_read)
	{
	    kom_log("Bug in adjust_read. Conference %lu, Priority %lu."
		    " %lu not greater than %lu (fixed).\n",
		    (unsigned long)m->conf_no,
		    (unsigned long)m->priority,
		    (unsigned long)ptr->first_read,
		    (unsigned long)(ptr-1)->last_read);
	    sfree(m->read_ranges);
	    m->read_ranges = NULL;
	    m->no_of_read_ranges = 0;   
	    return;
	}
Per Cederqvist's avatar
Per Cederqvist committed
518
519
520
521
522
    }
#endif
}

/*
523
524
 * insert TEXT in the list of read texts in M. The texts are sorted.
 * m->no_of_read is updated.
Per Cederqvist's avatar
Per Cederqvist committed
525
526
527
528
529
530
531
532
533
534
 *
 * Returns FAILURE if the text is already read.
 *
 * This is only used from mark_as_read().
 */

static Success
insert_loc_no(Local_text_no   text,
	      Membership    * m)
{
535
536
537
538
539
540
541
542
543
544
    struct read_range *lo;
    struct read_range *hi;
    struct read_range *mid;
    struct read_range *begin;
    struct read_range *end;
    ptrdiff_t save;
    struct read_range *gap;
    struct read_range *move;

    if (m->no_of_read_ranges == 0)
Per Cederqvist's avatar
Per Cederqvist committed
545
    {
546
547
548
549
550
	m->read_ranges = smalloc(sizeof(m->read_ranges[0]));
	m->no_of_read_ranges = 1;
	m->read_ranges[0].first_read = text;
	m->read_ranges[0].last_read = text;
	return OK;
Per Cederqvist's avatar
Per Cederqvist committed
551
552
    }

553
554
555
556
    begin = lo = &m->read_ranges[0];
    end = hi = lo + m->no_of_read_ranges;

    while (hi - lo > 1)
Per Cederqvist's avatar
Per Cederqvist committed
557
    {
558
559
560
561
562
563
	mid = lo + (hi - lo) / 2;
	if (text < mid->first_read - 1)
	    hi = mid;
	else if (text > mid->last_read + 1)
	    lo = mid;
	else
Per Cederqvist's avatar
Per Cederqvist committed
564
	{
565
566
	    lo = mid;
	    hi = mid + 1;
Per Cederqvist's avatar
Per Cederqvist committed
567
	}
568
    }
Per Cederqvist's avatar
Per Cederqvist committed
569

570
571
    if (text >= lo->first_read && text <= lo->last_read)
	return FAILURE;		/* This text was already read. */
Per Cederqvist's avatar
Per Cederqvist committed
572

573
574
575
576
577
578
579
    if (text == lo->first_read - 1)
    {
	if (lo != begin && (lo-1)->last_read == text)
	    return FAILURE;	/* This text was already read. */
	lo->first_read = text;
	return OK;
    }
Per Cederqvist's avatar
Per Cederqvist committed
580

581
582
    if (text == lo->last_read + 1)
    {
583
	if (lo != end && lo + 1 != end && (lo+1)->first_read == text)
584
585
586
	    return FAILURE;	/* This text was already read. */
	lo->last_read = text;
	return OK;
Per Cederqvist's avatar
Per Cederqvist committed
587
588
    }

589
590
591
592
593
594
595
596
597
598
599
600
601
602
    /* We have to allocate a new block. */
    if (lo->last_read < text)
	lo++;

    save = lo - begin;
    m->read_ranges = srealloc(
	m->read_ranges,
	++(m->no_of_read_ranges) * sizeof(m->read_ranges[0]));
    begin = &m->read_ranges[0];
    gap = begin + save;
    end = begin + m->no_of_read_ranges;
    for (move = end - 1; move > gap; move--)
	*move = *(move - 1);
    gap->first_read = gap->last_read = text;
Per Cederqvist's avatar
Per Cederqvist committed
603
604
605
    return OK;
}

606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627

/*
 * Send a new-membership message to the affected person
 */

static void
send_async_new_membership(Pers_no pers_no,
                                      Conf_no conf_no)
{
    Connection *cptr = NULL;
    Session_no i = 0;

    while ((i = traverse_connections(i)) != 0)
    {
        cptr = get_conn_by_number(i);
        if (cptr->pers_no == pers_no)
        {
            async_new_membership(cptr, pers_no, conf_no);
        }
    }
}

628
629
630
631
632
633
634
635
636
637
638
639
640
/*
 * Compute the derived last-text-read value.
 */
static inline Local_text_no
last_text_read(const Membership *mship)
{
    if (mship->no_of_read_ranges == 0)
	return 0;
    if (mship->read_ranges[0].first_read > 1)
	return 0;
    return mship->read_ranges[0].last_read;
}

641

Per Cederqvist's avatar
Per Cederqvist committed
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
/*
 * End of static functions
 */

/*
 * Functions that are exported to the server.
 */

/*
 * Add a member to a conference. All errorchecking should already
 * be done when this function is called. The person must not already
 * be a member of the conference. It is _not_ an error to make WHERE bigger
 * than the number of conferences the person is a member in.
 */

void
do_add_member(Conf_no	   conf_no,  /* Conference to add a new member to. */
	      Conference * conf_c,   /* Conf. status. Must NOT be NULL.  */
	      Pers_no	   pers_no,  /* Person to be added. */
	      Person	 * pers_p,   /* Pers. status. Must NOT be NULL. */
David Byers's avatar
Server    
David Byers committed
662
              Pers_no      added_by, /* Person doing the adding */
663
	      unsigned char	   priority, /* Prioritylevel to assign to this conf */
664
	      unsigned short	   where,   /* Sequence number in the list */
David Byers's avatar
David Byers committed
665
666
              Membership_type      * type, /* Type of the membership */
              Bool              fake_passive
667
              )
Per Cederqvist's avatar
Per Cederqvist committed
668
669
{
    Membership  * mship;
David Byers's avatar
David Byers committed
670
671
672
673
674
675
676
677
    Member	* mem;


    if (fake_passive && priority == 0)
    {
        type->passive = 1;
    }

Per Cederqvist's avatar
Per Cederqvist committed
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698

    /* First add the conference in the person-struct.
     * Make room for it.
     */
    
    pers_p->conferences.confs = srealloc( pers_p->conferences.confs,
					 ++(pers_p->conferences.no_of_confs)
					 * sizeof(Membership));
    
    /* Fill in the room */

    /* Find last slot */    
    mship = pers_p->conferences.confs + pers_p->conferences.no_of_confs - 1 ;
    
    /* Move all data beyond WHERE */
    while ( mship > pers_p->conferences.confs + where )
    {
	*mship = *(mship - 1);
	mship--;
    }

699
    init_membership(mship);
Per Cederqvist's avatar
Per Cederqvist committed
700
    
David Byers's avatar
Server    
David Byers committed
701
    mship->added_by = added_by;
702
    mship->added_at = current_time;
Per Cederqvist's avatar
Per Cederqvist committed
703
704
    mship->conf_no = conf_no;
    mship->priority = priority;
705
    mship->last_time_read = current_time;
706
707
    mship->no_of_read_ranges = 0;
    mship->read_ranges = NULL;
708
    mship->type = *type;
709
    mship->skip_read_texts = FALSE;
710

Per Cederqvist's avatar
Per Cederqvist committed
711
712
713
714
715
716
717
718
    /* Make room for the person in the conference */
    
    conf_c->members.members = srealloc( conf_c->members.members,
				       ++(conf_c->members.no_of_members)
				       * sizeof(Member));

    /* New members go to the end of the list */
    
David Byers's avatar
David Byers committed
719
720
    mem = (conf_c->members.members + conf_c->members.no_of_members - 1);
    mem->member = pers_no;
David Byers's avatar
Server    
David Byers committed
721
    mem->added_by = added_by;
722
    mem->added_at = current_time;
David Byers's avatar
David Byers committed
723
    mem->type = *type;
Per Cederqvist's avatar
Per Cederqvist committed
724
725
726
    
    mark_conference_as_changed( conf_no );
    mark_person_as_changed( pers_no );
727

Per Cederqvist's avatar
Per Cederqvist committed
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
    return;
}

/*
 * Send an asynchronous message to person pers_no (if he is logged on)
 * and tell him that he is no longer a member of conf_no. Also calls
 * leave_conf(). 
 */
extern void
forced_leave_conf(Pers_no pers_no,
		  Conf_no conf_no)
{
    Connection *real_active_connection;
    Session_no i = 0;
    
    real_active_connection = active_connection;

    while ( (i = traverse_connections(i)) != 0 )
    {
	active_connection = get_conn_by_number(i);

	if ( active_connection->pers_no == pers_no )
	{
	    async_forced_leave_conf(active_connection, conf_no);

	    if ( active_connection->cwc == conf_no )
David Byers's avatar
Server    
David Byers committed
754
		leave_conf(active_connection);
Per Cederqvist's avatar
Per Cederqvist committed
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
	}
    }

    active_connection = real_active_connection;
}

/*
 * Delete a member from a conference.
 * No checks are made on the parameters.
 * The dynamically allocated areas conf_c->members.members and
 * pers_p->confs are NOT reallocated since they will anyhow sooner or later
 * be flushed from core.
 */

Success
do_sub_member(Conf_no	   conf_no, /* Conf to delete member from. */
	      Conference * conf_c,  /* May be NULL */
772
	      Member     * mbr,     /* May be NULL */
Per Cederqvist's avatar
Per Cederqvist committed
773
774
775
776
777
778
779
780
781
782
783
784
785
786
	      Pers_no	   pers_no, /* Person to be deleted. */
	      Person	 * pers_p,  /* May be NULL */
	      Membership * mship)   /* Pointer to the persons membership in
				       conf., or NULL if not known. */
{
    if ( conf_c == NULL )
	GET_C_STAT(conf_c, conf_no, FAILURE);
    
    if ( pers_p == NULL )
	GET_P_STAT(pers_p, pers_no, FAILURE);
    
    if ( mship == NULL && (mship = locate_membership(conf_no, pers_p)) == NULL)
	restart_kom("do_sub_member() - can't find mship\n");

787
    if ( mbr == NULL && (mbr = locate_member(pers_no, conf_c)) == NULL)
Per Cederqvist's avatar
Per Cederqvist committed
788
789
790
791
792
793
	restart_kom("do_sub_member() - can't find member.\n");

    forced_leave_conf(pers_no, conf_no);
    
    /* Delete from Person */

794
    sfree(mship->read_ranges);
Per Cederqvist's avatar
Per Cederqvist committed
795
796
797
798
799
800
801
802
803
804
805
    --pers_p->conferences.no_of_confs;
    while ( mship
	   < pers_p->conferences.confs + pers_p->conferences.no_of_confs )
    {
	*mship = *(mship + 1);
	++mship;
    }

    /* Delete from Conference */

    --conf_c->members.no_of_members;
806
    while ( mbr < conf_c->members.members + conf_c->members.no_of_members )
Per Cederqvist's avatar
Per Cederqvist committed
807
    {
808
809
	*mbr = *(mbr + 1);
	++mbr;
Per Cederqvist's avatar
Per Cederqvist committed
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
    }

    mark_person_as_changed( pers_no );
    mark_conference_as_changed( conf_no );
    
    return OK;    
}


/*
 * VICTIM is a person or a conference.
 * Meaning of return values:
 *	unlimited: ACTPERS is supervisor of VICTIM, or ACTPERS is admin,
 *		   or ACTPERS is VICTIM
 *	none:	   VICTIM is secret, and ACTPERS is not a member
 *	member:	   ACTPERS is a member in VICTIM, but doesn't have unlimited
 *		   access.
 *	read_protected: The conference is rd_prot and ACTPERS is not a member.
 *	limited:   otherwise.
 *	error:	   see kom_errno
 */

832
static enum access
833
834
access_perm_helper(Conf_no victim,
		   const Connection *conn,
835
		   enum access wanted_access)
Per Cederqvist's avatar
Per Cederqvist committed
836
{
David Byers's avatar
Server    
David Byers committed
837
838
    Pers_no     viewer;
    Person    * viewer_p;
839
    Conf_type   victim_type;
840
    int         victim_type_known = 0;
841
    static int  maxwarnings = 10;
842
843
844
845
846
847
848

    if (!cached_conf_exists(victim))
    {
        kom_errno = KOM_UNDEF_CONF;
        err_stat = victim;
	return error;
    }
David Byers's avatar
Server    
David Byers committed
849
850
851
852

    viewer = conn->pers_no;
    viewer_p = conn->person;

853
    if (victim == viewer)
Per Cederqvist's avatar
Per Cederqvist committed
854
855
    	return unlimited;

856
    if (ENA_C(conn, admin, 2) || ENA_C(conn, wheel, 8))
Per Cederqvist's avatar
Per Cederqvist committed
857
858
    	return unlimited;

859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
    if (wanted_access <= limited)
    {
	victim_type = cached_get_conf_type(victim);
	victim_type_known = 1;

	if (victim_type.secret == 0)
	{
	    if (victim_type.rd_prot)
	    {
		if (wanted_access <= read_protected)
		    return read_protected;
	    }
	    else
		return limited;
	}
    }

876
    if (is_supervisor(victim, viewer, viewer_p))
Per Cederqvist's avatar
Per Cederqvist committed
877
878
    	return unlimited;

879
880
    if ( viewer != 0 )
    {
881
	/* viewer_p should never be NULL here.  Log a warning
882
	   if the GET_P_STAT is ever executed.  */
883
	if ( viewer_p == NULL )
884
885
886
887
888
889
890
891
	{
	    if (maxwarnings > 0)
	    {
		kom_log("WNG: viewer_p unexpectedly NULL in "
			"access_perm_helper()\n");
		if (--maxwarnings == 0)
		    kom_log("WNG: Won't log the above warning any more.\n");
	    }
892
	    GET_P_STAT(viewer_p, viewer, error);
893
	}
894

895
896
	/* FIXME (bug 155): no need to call the expensive
	   locate_membership if supervisor(victim) == victim. */
897
898
899
	if ( locate_membership( victim, viewer_p ) != NULL )
	    return member;
    }
Per Cederqvist's avatar
Per Cederqvist committed
900

901
902
    if (victim_type_known == 0)
	victim_type = cached_get_conf_type(victim);
903
904

    if ( victim_type.secret )
Per Cederqvist's avatar
Per Cederqvist committed
905
906
        return none;

907
    if ( victim_type.rd_prot )
Per Cederqvist's avatar
Per Cederqvist committed
908
909
910
911
912
913
	return read_protected;
    
    return limited;
}


914
enum access
915
916
access_perm(Conf_no victim,
	    const Connection *viewer_conn,
917
	    enum access wanted_access)
918
{
919
    enum access result;
920

921
    if (wanted_access != read_protected
922
923
	&& wanted_access != limited
	&& wanted_access != unlimited)
924
925
926
927
928
929
930
931
932
933
934
935
    {
	static int ctr = 0;
	if (ctr < 10)
	{
	    kom_log("WNG: access_perm called with wanted_access=%d\n",
		    (int)wanted_access);
	    ctr++;
	    if (ctr == 10)
		kom_log("WNG: won't log the above warning any more.\n");
	}
    }

936
    result = access_perm_helper(victim, viewer_conn, wanted_access);
937
938
939
940
941
942
943
944

    if (wanted_access < result)
	return wanted_access;
    else
	return result;
}


945
946
947
948
949
950
951
952
953
954
Conf_no
filter_conf_no(Conf_no victim,
	       const Connection *viewer_conn)
{
    if (access_perm(victim, viewer_conn, read_protected) >= read_protected)
	return victim;
    else
	return 0;
}

955

Per Cederqvist's avatar
Per Cederqvist committed
956
957
958
959
960
961
962
963
/*
 * Locate the Member struct in CONF_C for person PERS_NO
 */

Member *
locate_member(Pers_no      pers_no,
	      Conference * conf_c)
{
964
    Member * mbr;
Per Cederqvist's avatar
Per Cederqvist committed
965
966
    int      i;

967
968
    for(mbr = conf_c->members.members, i = conf_c->members.no_of_members;
	i > 0; i--, mbr++)
Per Cederqvist's avatar
Per Cederqvist committed
969
    {
970
	if ( mbr->member == pers_no )
Per Cederqvist's avatar
Per Cederqvist committed
971
	{
972
	    return mbr;
Per Cederqvist's avatar
Per Cederqvist committed
973
974
975
976
977
978
979
980
981
982
983
984
985
	}
    }

    return NULL;
}


/*
 * Find the data about PERS_P:s membership in CONF_NO.
 * Return NULL if not found
 */

Membership *
986
987
locate_membership(Conf_no       conf_no,
                  const Person *pers_p)
Per Cederqvist's avatar
Per Cederqvist committed
988
989
990
991
992
993
994
995
996
{
    Membership * confp;
    int    i;

    for(confp = pers_p->conferences.confs, i = pers_p->conferences.no_of_confs;
	i > 0; i--, confp++)
    {
	if ( confp->conf_no == conf_no )
	{
997
            confp->position = pers_p->conferences.no_of_confs - i;
Per Cederqvist's avatar
Per Cederqvist committed
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
	    return confp;
	}
    }

    return NULL;
}

/*
 * Atomic functions.
 */

/*
 * Unsubscribe from a conference.
 *
 * You must be supervisor of either conf_no or pers_no to be allowed to
 * do this.
 */
extern Success
sub_member(	Conf_no		conf_no,
		Pers_no		pers_no )
{
    Conference  * conf_c;
    Membership	* mship;
    Person	* pers_p;
    
David Byers's avatar
Server    
David Byers committed
1023
    CHK_CONNECTION(FAILURE);
Per Cederqvist's avatar
Per Cederqvist committed
1024
1025
1026
    CHK_LOGIN(FAILURE);
    GET_C_STAT(conf_c, conf_no, FAILURE);

1027
    if ((pers_p = cached_get_person_stat(pers_no)) == NULL)
Per Cederqvist's avatar
Per Cederqvist committed
1028
    {
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
	/* If the conference is secret, we have to return an error
	   code for the conference instead of for the person. */

	if (access_perm(conf_no, active_connection, read_protected) <= none)
	{
	    kom_errno = KOM_UNDEF_CONF;
	    err_stat = conf_no;
	}
	return FAILURE;
    }

    if ((mship = locate_membership(conf_no, pers_p)) == NULL
	|| membership_visible(active_connection, pers_no, conf_no, 
			      mship->type, FALSE, FALSE) == mv_none)
    {
	/* FIXME (bug 707): If the person is secret, and the viewer
	   has no access to it, we should return KOM_UNDEF_PERS
	   instead of KOM_NOT_MEMBER. */
	set_conf_errno(active_connection, conf_no, KOM_NOT_MEMBER);
Per Cederqvist's avatar
Per Cederqvist committed
1048
1049
1050
	return FAILURE;
    }

1051
1052
    if ( !is_supervisor(conf_no, ACTPERS, ACT_P) &&
	 !is_supervisor(pers_no, ACTPERS, ACT_P) &&
David Byers's avatar
Server    
David Byers committed
1053
1054
         !ENA(wheel,8) &&       /* OK -- In an RPC call */
         !ENA(admin, 4) )       /* OK -- in an RPC call */
Per Cederqvist's avatar
Per Cederqvist committed
1055
    {
1056
	set_conf_errno(active_connection, conf_no, KOM_PERM);
Per Cederqvist's avatar
Per Cederqvist committed
1057
1058
1059
	return FAILURE;
    }

David Byers's avatar
David Byers committed
1060
1061
1062
1063
    return do_sub_member(conf_no, conf_c, NULL, pers_no, pers_p, mship);
}


Per Cederqvist's avatar
Per Cederqvist committed
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
/*
 * Add a member to a conference (join a conference) or
 * Change the priority of a conference.
 *
 * Anyone may add anyone as a member as long as the new member is not
 * secret and the conference is not rd_prot. This might be a bug.
 *
 * PRIORITY is the assigned priority for the conference. WHERE says
 * where on the list the person wants the conference. 0 is first. WHERE
 * is automatically set to the number of conferences that PERS_NO is member
 * in if WHERE is too big, so it is not an error to give WHERE == ~0 as
 * a parameter.
 *
 * You can only re-prioritize if you are supervisor of pers_no.
 */
1079

David Byers's avatar
David Byers committed
1080
1081
1082
static Success
add_member_common(Conf_no              conf_no,
                  Pers_no              pers_no,
1083
1084
                  unsigned char        priority,
                  unsigned short       where,		/* Range of where is [0..] */
David Byers's avatar
David Byers committed
1085
1086
1087
                  Membership_type     *type,
                  Bool                 fake_passive
    )
Per Cederqvist's avatar
Per Cederqvist committed
1088
{
1089
    Conference  * conf_c;
Per Cederqvist's avatar
Per Cederqvist committed
1090
1091
1092
    Person	* pers_p;
    Membership	* mship;

David Byers's avatar
Server    
David Byers committed
1093
    CHK_CONNECTION(FAILURE);
Per Cederqvist's avatar
Per Cederqvist committed
1094
1095
1096
1097
    CHK_LOGIN(FAILURE);
    GET_C_STAT(conf_c, conf_no, FAILURE);
    GET_P_STAT(pers_p, pers_no, FAILURE);

David Byers's avatar
David Byers committed
1098
    /* Force invitation bit if not adding as admin or supervisor */
1099
    if (param.invite_by_default &&
1100
        !is_supervisor(pers_no, ACTPERS, ACT_P) &&
David Byers's avatar
Server    
David Byers committed
1101
        !ENA(admin, 2))         /* OK -- Guarded */
1102
1103
1104
1105
    {
        type->invitation = 1;
    }

David Byers's avatar
David Byers committed
1106
1107
1108
    /* Check if secret membership bit is set and allowed */
    if (type->secret &&
        (!param.secret_memberships || conf_c->type.forbid_secret))
1109
1110
1111
1112
1113
1114
    {
        err_stat = 0;
        kom_errno = KOM_INVALID_MEMBERSHIP_TYPE;
        return FAILURE;
    }

David Byers's avatar
David Byers committed
1115
    /* Check access to the conference. We need limited access or more */
1116
    if (access_perm(conf_no, active_connection, limited) < limited
David Byers's avatar
Server    
David Byers committed
1117
	&& !ENA(wheel, 8) )     /* OK -- Guarded */
Per Cederqvist's avatar
Per Cederqvist committed
1118
    {
1119
        err_stat = conf_no;
1120
	kom_errno = (conf_c->type).secret ? KOM_UNDEF_CONF : KOM_ACCESS;
Per Cederqvist's avatar
Per Cederqvist committed
1121
1122
1123
1124
1125
1126
1127
	return FAILURE;
    }

    /* Is he already a member? */

    if ( (mship = locate_membership( conf_no, pers_p )) != NULL)
    {
David Byers's avatar
David Byers committed
1128
1129
        Bool pers_supervisor;
        Bool conf_supervisor;
Per Cederqvist's avatar
Per Cederqvist committed
1130

1131
1132
        pers_supervisor = is_supervisor(pers_no, ACTPERS, ACT_P);
        conf_supervisor = is_supervisor(conf_no, ACTPERS, ACT_P);
David Byers's avatar
David Byers committed
1133
1134

        /* Already a member, but a secret member? */
1135
1136
1137
        if (mship->type.secret &&
            !pers_supervisor &&
            !conf_supervisor &&
David Byers's avatar
Server    
David Byers committed
1138
1139
            !ENA(admin,2) &&    /* OK -- Guarded */
            !ENA(wheel,8))      /* OK -- Guarded */
David Byers's avatar
David Byers committed
1140
        {
1141
            /* FIXME (bug 156): This leaks secret information */
David Byers's avatar
David Byers committed
1142
1143
1144
1145
1146
1147
1148
1149
            /* The person is already a member, but we are not allowed
               to know this. Pretend that the addition worked, and hope
               that the user does not double-check */

            return OK;
        }

	/* He is already a member. Only change the priority. */
1150
	if( !pers_supervisor &&
David Byers's avatar
Server    
David Byers committed
1151
            !ENA(admin,2) && 
1152
            !ENA(wheel, 8) )
1153
1154
	{
	    /* Noone else can change one's priorities. */
1155
            err_stat = pers_no;
Per Cederqvist's avatar
Per Cederqvist committed
1156
1157
1158
1159
	    kom_errno = KOM_PERM;
	    return FAILURE;
	}

David Byers's avatar
David Byers committed
1160
1161
1162
1163
	do_change_priority( mship, conf_no, conf_c,
                            priority, where, pers_no, pers_p,
                            type, fake_passive );

Per Cederqvist's avatar
Per Cederqvist committed
1164
1165
1166
    }
    else
    {
1167
	if (pers_no != ACTPERS)
1168
        {
David Byers's avatar
David Byers committed
1169
	    kom_log("Person %lu added to conference %lu by %lu.\n",
1170
1171
1172
		(unsigned long)pers_no,
		(unsigned long)conf_no,
		(unsigned long)ACTPERS);
1173
        }
1174

David Byers's avatar
Server    
David Byers committed
1175
	do_add_member(conf_no, conf_c, pers_no, pers_p, ACTPERS,
David Byers's avatar
David Byers committed
1176
1177
                      priority, where, type, fake_passive);

David Byers's avatar
David Byers committed
1178
        send_async_new_membership(pers_no, conf_no);
Per Cederqvist's avatar
Per Cederqvist committed
1179
1180
1181
1182
1183
    }

    return OK;
}

David Byers's avatar
David Byers committed
1184
1185
1186
1187
1188
1189
1190
1191
1192

extern Success
add_member_old(Conf_no	conf_no,
               Pers_no	pers_no,
               unsigned char	priority,
               unsigned short	where)
{
    Membership_type type;

David Byers's avatar
Server    
David Byers committed
1193
    /* CHK_CONNECTION in add_member_common */
1194
    set_membership_type_bits(&type, 0,0,0,0,0,0,0,0);
David Byers's avatar
David Byers committed
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
    return add_member_common(conf_no, pers_no, priority, where, &type, TRUE);
}


extern Success
add_member(Conf_no	conf_no,
           Pers_no	pers_no,
           unsigned char	priority,
           unsigned short	where,		/* Range of where is [0..] */
           Membership_type     *type
           )
{
David Byers's avatar
Server    
David Byers committed
1207
    /* CHK_CONNECTION in add_member_common */
David Byers's avatar
David Byers committed
1208
1209
1210
1211
    return add_member_common(conf_no, pers_no, priority, where, type, FALSE);
}


Per Cederqvist's avatar
Per Cederqvist committed
1212
1213
1214
1215
#ifdef DEBUG_MARK_AS_READ
static int
check_membership(Pers_no pno,
		 const Conference *conf,
1216
		 Membership *mship)
Per Cederqvist's avatar
Per Cederqvist committed
1217
{
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
    static int log_no = 0;

    int errors = 0;
    struct read_range *begin;
    struct read_range *end;
    struct read_range *ptr;

    if (mship->no_of_read_ranges == 0 && mship->read_ranges != NULL)
    {
	if (log_no < 80)
	    kom_log("ERROR: check_membership(): (%d): "
		    "no_of_read_ranges == 0 but read_ranges != NULL\n",
		    ++log_no);
	/* We don't know what it points to, so we dare not free it.  */
	mship->read_ranges = NULL;
	errors++;
    }

    if (mship->no_of_read_ranges != 0 && mship->read_ranges == NULL)
    {
	if (log_no < 80)
	    kom_log("ERROR: check_membership(): (%d): "
		    "no_of_read_ranges == %ld but read_ranges == NULL\n",
		    ++log_no, (long)mship->no_of_read_ranges);
	mship->no_of_read_ranges = 0;
1243
	errors++;
Per Cederqvist's avatar
Per Cederqvist committed
1244
1245
    }

1246
1247
    if (mship->read_ranges == NULL)
	return errors;
Per Cederqvist's avatar
Per Cederqvist committed
1248

1249
1250
1251
1252
    begin = &mship->read_ranges[0];
    end = begin + mship->no_of_read_ranges;

    for (ptr = begin; ptr < end; ptr++)
Per Cederqvist's avatar
Per Cederqvist committed
1253
    {
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
	if (ptr != begin && (ptr-1)->last_read + 1 >= ptr->first_read)
	{
	    if (log_no < 80)
		kom_log("ERROR: check_membership(): (%d): "
			"bad range sequence %lu-%lu, %lu-%lu\n",
			++log_no,
			(unsigned long)(ptr-1)->first_read,
			(unsigned long)(ptr-1)->last_read,
			(unsigned long)ptr->first_read,
			(unsigned long)ptr->last_read);
	    errors++;
	}

	if (ptr->first_read > ptr->last_read)
Per Cederqvist's avatar
Per Cederqvist committed
1268
	{
1269
1270
1271
1272
1273
	    if (log_no < 80)
		kom_log("ERROR: check_membership(): (%d): bad range %lu-%lu\n",
			++log_no,
			(unsigned long)ptr->first_read,
			(unsigned long)ptr->last_read);
1274
	    errors++;
Per Cederqvist's avatar
Per Cederqvist committed
1275
	}
1276
    }
Per Cederqvist's avatar
Per Cederqvist committed
1277

1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
    if ((end-1)->last_read >= l2g_first_appendable_key(&conf->texts))
    {
	if (log_no < 80)
	    kom_log("ERROR: check_membership(): (%d): Person %lu has read text"
		    " %lu in conf %lu, which only has %lu texts.\n",
		    log_no,
		    (unsigned long)pno,
		    (unsigned long)(end-1)->last_read,
		    (unsigned long)mship->conf_no,
		    (unsigned long)(l2g_first_appendable_key(&conf->texts)-1));
	errors++;
Per Cederqvist's avatar
Per Cederqvist committed
1289
1290
    }

1291
    return errors;
Per Cederqvist's avatar
Per Cederqvist committed
1292
1293
1294
1295
1296
1297
1298
}
#endif

/*
 * mark_as_read() is used to tell LysKOM which texts you have read.
 * You can mark several texts in one chunk, but the chunk should not
 * be too big to prevent users from having to re-read texts in case of
1299
 * a server/client/network crash.
Per Cederqvist's avatar
Per Cederqvist committed
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
 *
 * The texts are marked per conference. If there are several recipients
 * to a text it should be mark_as_read() in all the recipients.
 *
 * If conference is ACTPERS mailbox it will add a rec_time item in the
 * misc_items field.
 *
 * It is only possible to mark texts as read in a conference you are
 * member in.
 *
 * Attempts to mark non-existing texts as read are ignored if the text
 * has existed. If the text has not yet been created KOM_NO_SUCH_LOCAL_TEXT
 * will be returned in kom_errno.
 *
1314
1315
1316
1317
1318
1319
 * If CONFERENCE is the current working conference of ACTPERS, and the
 * text has not previously been marked as read, ACT_P->read_texts will
 * be increased. If the client cooperates this will be correct. If the
 * client change_conference()s to all recipients of a text before
 * marking it as read the read_texts field will be too big. (If anyone
 * cares about that, feel free to rewrite this code as long as it
1320
 * doen't get too CPU-intensive.)
Per Cederqvist's avatar
Per Cederqvist committed
1321
1322
 */
extern Success
1323
1324
mark_as_read (Conf_no		     conference,
	      int		     no_of_texts,
Per Cederqvist's avatar
Per Cederqvist committed
1325
1326
1327
1328
1329
1330
1331
	      const Local_text_no  * text_arr )
{
    int		 i;
    Membership * m;
    Conference * conf_c;
    Success	 retval = OK;
    const Local_text_no  * const text_arr_start = text_arr;