ChangeLog 399 KB
Newer Older
1
2
2003-07-14  Per Cederqvist  <ceder@ceder.dyndns.org>

3
4
5
6
	Fixed a recently introduced typo.
	* src/server/connections.c (queue_remove): Fixed a typo that
	caused a broken pointer structure on the queue of pending clients.

7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
	Improve liboop error checking.
	* src/libraries/liboop/signal.c (add_flag): New static function,
	that checks the return values from fcntl properly.
	(oop_signal_new): Use add_flag() to simplify code. Fail (return
	NULL) if any of the fcntl calls on the new pipe fails.

	Increase PROTECTED_FDS, since liboop uses internal file
	descriptors.
	* src/include/kom-config.h (PROTECTED_FDS): Increased from 12 to
	20.  Document that liboop uses a couple of file descriptors, and
	that this setting is also present in unix.exp.
	* src/server/testsuite/config/unix.exp (PROTECTED_FDS): New
	constant.
	* src/server/testsuite/lyskomd.0/07.exp: Use PROTECTED_FDS.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.

25
26
27
28
29
30
31
32
33
34
35
	Flush the output less often.  This fixes the non-controversial
	parts of bug 107.
	* src/server/prot-a.c (prot_a_reply): Don't call isc_flush()
	here.  Doing so was redundant.
	* src/server/connections.c (parse_unparsed): Return true if
	anything was sent back to the client.  Don't call isc_flush().
	(read_from_connection): Call isc_flush() once if parse_unparsed()
	returned true at least once.
	* src/server/prot-a-send-async.c (async_trailer): Added a
	comment about the controversial parts of bug 107.

36
37
2003-07-13  Per Cederqvist  <ceder@ceder.dyndns.org>

38
39
40
41
42
43
44
	Don't call select() with a very large timeout.  This could
	possibly fix bug 1065.
	* src/libraries/liboop/sys.c (oop_sys_run): Clamp the value of the
	tv_sec field of the select timeout argument to 3600 seconds, to
	check if very large values is the reason that FreeBSD returns
	EINVAL here.  (Bug 1065).

45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
	Reverted the change of 1999-04-03: go_and_die is now a Bool once
	again.  It is no longer manipulated from a signal handler.
	* src/server/admin.c (shutdown_kom): Use TRUE instead of 1 as
	value of go_and_die.
	* src/server/connections.c (go_and_die): Now a Bool, once again.
	* src/server/ramkomd.c (sighandler_hup): Use TRUE instead of 1 as
	value of go_and_die.
	* src/server/sigflags.h (go_and_die): Now a Bool, once again.

	Terminate at once if go_and_die becomes set while the queue of
	pending requests is processed.
	* src/server/connections.c (check_idle_callback): Break out of the
	loop and return OOP_HALT if go_and_die is true.

	Header file cleanup.
	* src/server/sigflags.h (intr_syscalls_on_intr): Removed.
	(restart_syscalls_on_intr): Removed.
	(do_statistics): Removed.

64
65
66
67
68
69
2003-07-13  Per Cederqvist  <ceder@lysator.liu.se>

	Actually distribute all test cases...
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	37.exp.

70
71
2003-07-13  Per Cederqvist  <ceder@ceder.dyndns.org>

72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
	Tweak testsuite timeouts.
	* src/server/testsuite/config/unix.exp (timeout): Increase the
	timeout 2 more seconds.

	Move garb timers around so that the debug request start_garb() can
	actually start the garb.  Fixes breakage in lyskomd.0/09.exp.
	* src/server/text-garb.h (garb_text): This function is now
	static.
	(start_garb_thread): New function.
	(stop_garb_thread): New function.
	* src/server/text-garb.c (garb_timer): New static variable.
	(garb_timer_running): Ditto.
	(garb_text): Added static qualifier.
	(garb_callback): Moved here from connections.c.  Some minor
	modifications made to make it compiler in its new environment.
	(start_garb_thread): New function.
	(stop_garb_thread): New function.
	(start_garb): Restart the garb "thread".
	* src/server/connections.h (set_time): Now exported.
	(setup_timer): Ditto.
	(server_idle): New function.
	* src/server/connections.c (set_time): No longer static.
	(setup_timer): Ditto.
	(garb_callback): Moved to text-garb.c. 
	(saver_callback): The source argument is actually used.
	(toploop): Moved the garb timer to text-garb.c.
	(server_idle): New function.

	Use the liboop signal adapter; avoid using siglongjmp from signal
	handlers.  Ignore signals during shutdown.
	* src/server/ramkomd.c (kom_signal_adapter): New static variable.
	(server_init): Use oop_signal_new, since I don't trust the way
	liboop uses siglongjmp to break out of a signal handler.  Ignore
	the signals before registering them with liboop, to get a proper
	behaviour on shutdown.
	(main): Adjusted to use the signal adapter.

	Fix errors in ths liboop signal adapter.
	* src/libraries/liboop/signal.c (use_sa_restart): New static
	variable.
	(sig_on_signal): Add SA_RESTART if appropriate.
	(oop_signal_new): Don't just blindly set FD_CLOEXEC and
	O_NONBLOCK.  Read the old settings first.
	(oop_signal_use_sa_restart): New function.
	* src/libraries/liboop/oop.h (oop_signal_use_sa_restart): New
	function.

119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
	Updated documentation for the configuration file for "timeval"
	parameters and penalty points/client scheduling.
	* doc/lyskomd.texi (Parameter Types): Document "timeval".
	(Parameters): Updated the documentation for "timeval" parameters
	and the parameters relating to penalty points.

	Added test cases for parsing of timeval values.
	* src/include/services.h (dump_cfg_timevals): New debug request.
	* src/server/fncdef.txt: Added 1006=dump_cfg_timevals.
	* src/server/server-config.c (dump_timeval): New static function.
	(dump_cfg_timevals): New request.
	* src/server/testsuite/lyskomd.0/37.exp: New file: Test the
	parsing of "timeval" entries in the configuration file.

	Improved timeval parsing.
	* src/server/conf-file.c (assign_timeval): Skip whitespace between
	the number and the suffix.  Round the tv_usec field properly.

	Improve config file checking.
	* src/server/server-config.c (read_configuration): Give an error
	message if low_penalty isn't lower than max_penalty.

141
142
143
144
145
146
147
148
149
150
151
152
	Fixed more compilation errors.
	* src/server/simple-cache.c (cache_sync_finish): Added a missing
	parenthesis.
	* src/server/aux-item-def-parse.y: Include timewrap.h, since
	connections.h now needs it.
	* src/server/debug.c: Ditto.
	* src/server/standalone.c: Ditto.

	Added more liboop assertions.
	* src/libraries/liboop/sys.c (oop_sys_run): Added a few assertions
	to try to figure out why select still returns EINVAL sometimes.

153
154
155
156
	Fixed compilation error when compiled for coverage measurements.
	* src/server/simple-cache.c (cache_sync_finish): Adjusted to new
	API of sync_part().

157
	Include <time.h> and <sys/time.h> in a proper way.
158
	* src/server/Makefile.am (lyskomd_SOURCES): Added timewrap.h.
159
160
161
162
	* src/server/timewrap.h: New include file; a wrapper around
	<time.h> and <sys/time.h>.  All files that needs to include either
	file now does so via this wrapper.

163
164
2003-07-12  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
165
166
167
168
	Code cleanup.
	* src/server/server-config.c: (parameters): Added default_suffix
	initializers for all parameters.  Break overly long lines.

169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
	All configuration parameters that are time periods can now have an
	optional suffix such as "hours" appended.  Store them as a struct
	timeval, not as an int, so that the bulk of the code doesn't have
	to take the unit into account.
	* src/server/param.h (struct kom_par): Changed the type of the
	following fields from int to struct timeval:
	garb_busy_postponement, garbtimeout, synctimeout, garb_interval,
	sync_interval, sync_retry_interval.
	* src/server/server-config.c: (parameters): Changed the assigner
	of "Garb busy postponement", "Garb timeout", "Sync timeout", "Garb
	interval", "Sync interval" and "Sync retry interval" from int to
	timeval, and added appropriate default suffixes to those
	configuration parameters.
	* src/server/conf-file.h (struct parameter): New field:
	default_suffix.
	(assign_timeval): New assigner.
	* src/server/conf-file.c (struct suffix_conversion): New struct.
	(suffix_table): New table.
	(assign_timeval): New assigner.

	Use "struct timeval" instead of a number of milliseconds or
	seconds in several places.  This fixes a number of potential and
	actual overflows.
	* src/server/connections.h (Connection): Change the type of the
	session_start and active_time fields from time_t to struct
	timeval.
	* src/server/server-time.h (current_time): Now a struct timeval,
	not a time_t.
	* src/server/disk-end-of-atomic.c, src/server/end-of-atomic.h
	(end_of_atomic): Now returns a struct timeval, not a long.
	* src/server/cache.h (sync_part): Now returns a struct timeval.
	* src/server/text.c (add_text_in_conf): Extract the
	seconds from the current_time.
	(create_text_add_miscs): Ditto.
	(do_create_text): Ditto.
	(add_recipient): Ditto.
	(add_comment): Ditto.
	(add_footnote): Ditto.
	* src/server/text-garb.c (garb_text): Extract the seconds from the
	current_time.
	* src/server/simple-cache.c (sync_output_header): Extract the
	seconds from the current_time.
	(sync_part): Return a struct timeval instead of a long.  Use 
	struct timeval instead of a time_t.  Use timeval_remaining() to
	simplify the code.
	(init_cache): Use a struct timeval instead of time_t.
	(cache_sync_all): Adjusted to new API of sync_part().
	* src/server/session.c (leave_conf): Extract the seconds from the
	current_time.
	(login_old): Ditto.
	(login): Ditto.
	(get_static_session_info): Ditto.
	(get_time): Ditto.
	(logout): Ditto.  Use timeval_diff_sec instead of ldifftime.
	(who_is_on_dynamic): Use timeval_diff_sec instead of ldifftime.
	(get_session_info): Ditto.
	(get_session_info_ident): Ditto.
	* src/server/send-async.c (async_rejected_connection): Use struct
	timeval instead of time_t.
	* src/server/ramkomd.c (current_time): Now a struct timeval, not
	a time_t.
	(main): Adjusted for the new type of current_time.
	* src/server/person.c (create_person_generic): Extract the seconds
	from the current_time.
	* src/server/membership.c (do_add_rec_time): Extract the seconds
	from the current_time.
	(do_add_member): Ditto.
	* src/server/internal-connections.c (init_connection): Use struct
	timeval instead of time_t.
	* src/server/connections.c (set_time): Use struct timeval instead
	of time_t.
	(dump_statistics): Ditto.
	(saver_callback): Ditto.
	(setup_timer): Replaced the milliseconds argument with a struct
	timeval argument.
	(garb_callback): Simplified the code.
	* src/server/conference.c (do_create_conf): Extract the seconds
	from the current_time.
	* src/server/aux-items.c (prepare_aux_item): Extract the seconds
	from the current_time.

	Added utility functions for struct timeval.
	* src/libraries/libmisc/Makefile.am (libmisc_a_SOURCES): Added
	timeval-util.h and timeval-util.c.
	* src/libraries/libmisc/timeval-util.h,
	* src/libraries/libmisc/timeval-util.c: New files.
	(timeval_subtract): New static function.
	(timeval_nonzero): New function.
	(timeval_zero): Ditto.
	(timeval_ctor): Ditto.
	(timeval_remaining): Ditto.
	(timeval_greater): Ditto.
	(timeval_less): Ditto.
	(timeval_diff_sec): Ditto.

264
265
266
267
	Don't store garbage in struct timevals passed to liboop.
	* src/server/connections.c (setup_timer): Fixed an error that
	caused the tv_usec field to be out-of-range.

268
269
270
271
272
273
274
275
276
2003-07-12  Per Cederqvist  <ceder@lysator.liu.se>

	Make liboop refuse bad timestamps early on.
	* src/libraries/liboop/sys.c (sys_on_time): Trigger an assertion
	if a broken tv_usec is entered.

	Make gdb find the liboop sources.
	* src/server/Makefile.am (.gdbinit): Added liboop.

277
278
2003-07-12  Per Cederqvist  <ceder@ceder.dyndns.org>

279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
	Attempt to fix a bug that caused the testsuite to hang.
	* src/server/testsuite/config/unix.exp (kill_client): Fixed broken
	logic that caused the "looking for stray output" never to emit a
	pass message.  Look for eof on the client.

	Update valgrind suppressions.
	* src/server/testsuite/lyskomd.supp: Track the name change of
	isc_tcp_accept_fn() to isc_tcp_accept().

	Reduce the number of log messages.
	* src/server/connections.c (add_to_kill_list): Don't write a log
	message when the connection is already present on the kill list.
	With the liboop callbacks that can happen and is not an error.
	(write_err_cb): Don't log an error for ECONNRESET.

	Fixed compilation errors.
	* src/server/connections.c (read_from_connection): Removed
	left-over debug code.
	(enable_idle_check): Ditto.
	(check_idle_callback): Ditto.
	* src/libraries/liboop/www.c (reg): Don't use //-style comments.
	(unreg): Ditto.

302
303
304
305
306
	Fixed liboop compilation errors introduced by me.
	* src/libraries/liboop/sys.c (sys_on_time): Moved the assert
	statement to after all variable declarations.
	(sys_on_signal): Ditto.

307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
	Make it easier to run all the tests that don't require dejagnu.
	* src/server/testsuite/Makefile.am (check-nondejagnu): New target.
	(check-dejagnu): New target.
	(check): Depend on check-dejagnu and check-nondejagnu, and move
	all dependencies to one of those targets.

	Add scheduling of clients, so that one client cannot starve other
	clients for resources.  (Bug 102).
	* src/server/server-config.c (parameters): Added "Penalty per
	call", "Penalty per read", "Max penalty" and "Low penalty".
	* src/server/testsuite/lyskomd.0/conf-file-cov.exp: Check the
	parameter "Garb timeout" instead of "Idle timeout", since the
	latter no longer exists.
	* src/server/param.h (struct kom_par): Removed timeout.  Added
	garb_busy_postponement, penalty_per_call, penalty_per_read,
	max_penalty and low_penalty.
	* src/server/internal-connections.c (init_connection): 
	Initialize penalty, penalty_generation, queue_next, queue_prev,
	on_queue.
	(kill_client): Assert that on_queue is false.
	* src/server/connections.h (Connection): New fields: penalty,
	penalty_generation, queue_prev, queue_next, on_queue.
	(handle_accept_event): New function.
	* src/server/connections.c (penalty_generation): New static variable.
	(work_done): Ditto.
	(is_idle): Ditto.
	(queue_first): Ditto.
	(queue_last): Ditto.
	(queue_add): New static function.
	(queue_remove): Ditto.
	(logout_client): Remove the client from the queue of pending
	clients.
	(parse_unparsed): Add penalty points for finished calls and
	protocol errors.  Don't delete the parsed part of unparsed.
	(adjust_penalty): New static function.
	(enable_idle_check): Ditto.
	(check_idle_callback): Ditto.

	Run the database save, garb, and check for killed clients from
	three separate liboop timer callbacks.
	* src/server/connections.c (kill_pending): New static variable.
	(add_to_kill_list): Add an oop timer event callback to
	check_kill_flg when a client is added to the kill list.
	(check_kill_flg): Changed API: this is now an oop timer callback
	function.
	(garb_callback): New static function.
	(saver_callback): Ditto.
	* src/server/text-garb.c (last_start): Static variable removed.
	(garb_text): Expect the caller to wait long enough when the garb
	shouldn't be running.  Return true when the garb is completed,
	instead of when the garb shouldn't be running.
	* src/server/cache.h (sync_part): Return the number of seconds to
	wait instead of a Bool.
	* src/server/simple-cache.c (sync_part): Return the number of
	seconds to wait instead of a Bool.  All callers updated.
	* src/server/server-config.c (parameters): Removed "Idle timeout".
	Added "Garb busy postponement"
	* src/server/end-of-atomic.h (end_of_atomic): Removed the
	idle argument.
	* src/server/disk-end-of-atomic.c (end_of_atomic): Removed the
	idle argument.  Don't call the garb.  Adjusted to the new API of
	sync_part().

	Use liboop for signal dispatching.
	* src/server/ramkomd.c (sighandler_usr1): Now an liboop signal
	callback, not a real signal handler.  Do the real work here.
	(sighandler_winch): Ditto.
	(sighandler_hup): Now an liboop signal callback, not a real signal
	handler.
	(sighandler_quit): Ditto.
	(sighandler_usr2): Ditto.
	(setup_sighandlers): Removed.
	(restart_syscalls_on_intr): Removed.
	(intr_syscalls_on_intr): Removed.
	* src/server/param.h (reread_param): Variable removed.
	* src/server/server-config.c (reread_param): Removed.
	* src/server/connections.c (do_statistics): Variable removed.

	Use liboop.  (Bug 106).
	* src/server/Makefile.am (AM_CPPFLAGS): Added an -I flag for
	liboop.
	(lyskomd_SOURCES): Added oop-malloc.h and oop-malloc.c.
	(lyskomd_LDADD): Link against liboop.a.
	* src/server/oop-malloc.c, src/server/oop-malloc.h
	(oop_malloc_wrapper): New function.
	(oop_free_wrapper): New function.
	(oop_realloc_wrapper): New function.
	(dump_oop_alloc_counts): New function.
	* src/server/ramkomd.c (listen_client): Static variable removed.
	(server_init): Initialize liboop.  Adjusted to the new isc API:s.
	(main): Clean up liboop structures on shutdown.
	* src/server/rfc931.h: Adjusted to new libisc API.
	* src/server/rfc931.c: Include liboop.h.
	* src/server/prot-a.c: Include oop.h.
	* src/server/prot-a-send-async.c: Include oop.h.
	* src/server/prot-a-parse.c: Include oop.h.
	* src/server/prot-a-parse-arg-c.awk: Include oop.h.
	* src/server/prot-a-output.c: Include oop.h.
	* src/server/isc-interface.h (kom_server_oop_src): New global
	variable.
	* src/server/connections.c (kom_server_oop_src): New variable.
	(set_time): New static function.
	(parse_message): Function removed.
	(logout_request): Function removed.
	(parse_forgotten): Ditto.
	(message_request): Ditto.
	(write_err_cb): New static function.
	(read_from_connection): Ditto.
	(setup_timer): Ditto.
	(data_available_callback): Ditto.
	(handle_accept_event): New function.
	(login_request): Take an isc_scb as argument instead of an isc
	event.  Add read and write error callback functions for the new
	client.
	(toploop): Rewritten to use liboop.

	Code cleanup.
	* src/server/internal-connections.c (init_connection): Added
	static const qualifiers to the default_want_async variable.

	Renamed a few constants that have nothing to do with ISC.
	* src/server/isc-parse.h (KOM_PROTOCOL_ERR): New name for former
	ISC_PROTOCOL_ERR.  All users updated.
	(KOM_MSG_INCOMPLETE): New name for former ISC_MSG_INCOMPLETE.  All
	users updated.
	(KOM_LOGOUT): New name for former ISC_LOGOUT.  All users updated.
	* src/server/isc-parse.c (parse_char): Use KOM_MSG_INCOMPLETE
	instead of ISC_MSG_INCOMPLETE.

	Make it possible to read an unsigned int from the config file.
	* src/server/conf-file.h (assign_uint): New function.
	(union param_value): Unused union removed.
	* src/server/conf-file.c (assign_uint): New function.

	Add SA_RESTART support to liboop.  (This has been sent to the
	liboop maintainer.)  (Fixes bug 845).
	* src/libraries/liboop/oop.h (oop_sys_use_sa_restart): New
	function.
	* src/libraries/liboop/sys.c (sys_sig_owner): Added static
	qualifier.
	(use_sa_restart): New static variable.
	(sys_on_fd): Require the callback to be non-NULL.
	(sys_on_time): Ditto.	
	(sys_on_signal): Ditto.	
	(sys_on_signal): Use SA_RESTART if use_sa_restart is true.
	(oop_sys_use_sa_restart): New function.

	Add a few utility string functions.
	* src/libraries/libmisc/s-string.h,
	src/libraries/libmisc/s-string.c (s_trim_left): New function.
	(s_reserve): New function.
	(s_reserve_done): New function.

460
461
462
463
464
465
466
467
468
469
2003-07-10  Per Cederqvist  <ceder@ceder.dyndns.org>

	Solaris stores ar in /usr/ccs/bin.
	* src/libraries/liboop/configure.ac: Use the same check for the
	``ar'' program that lyskom-server uses.

	libisc will soon depend on liboop.
	* src/libraries/Makefile.am (SUBDIRS): Compile liboop before
	libisc-new, since isc is about to use liboop.

470
471
2003-07-09  Per Cederqvist  <ceder@ceder.dyndns.org>

472
473
474
475
	Link-time fix for liboop test program.
	* src/libraries/liboop/Makefile.am (test_oop_LDADD): Link against
	liboop.a, not -loop, to ensure that we get the local copy.

476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
	Build liboop (but don't use it yet).
	* configure.in: Added src/libraries/liboop to AC_CONFIG_SUBDIRS.
	* mkmi: Recreate configure and Makefile.in in liboop.
	* src/libraries/Makefile.am (SUBDIRS): Added liboop.

	Using libtool isn't worth the effort for our copy of liboop.
	Don't include adapters for things we are never going to use.
	* src/libraries/liboop/configure.ac: Removed checks for readline,
	glib, Tcl and libwww, since they are not used by lyskom-server.
	(AM_PROG_LIBTOOL): Removed.
	(PROG_LDCONFIG): Don't set it.
	(no_wacky_libs): Don't set it.
	(AC_PROG_RANLIB): Added.
	* src/libraries/liboop/Makefile.am (noinst_LIBRARIES): Added.
	(liboop_a_SOURCES): New name for former liboop_la_SOURCES.
	(noinst_HEADERS): New name for former include_HEADERS.
	(lib_LTLIBRARIES): Removed.
	(liboop_la_LDFLAGS): Removed.
	(liboop_adns_la_LDFLAGS): Removed.
	(liboop_adns_la_LIBADD): Removed.
	(liboop_adns_la_SOURCES): Removed.
	(liboop_glib_la_LDFLAGS): Removed.
	(liboop_glib_la_LIBADD): Removed.
	(liboop_glib_la_SOURCES): Removed.
	(liboop_tcl_la_LDFLAGS): Removed.
	(liboop_tcl_la_LIBADD): Removed.
	(liboop_tcl_la_SOURCES): Removed.
	(liboop_www_la_LDFLAGS): Removed.
	(liboop_www_la_LIBADD): Removed.
	(liboop_www_la_SOURCES): Removed.
	(liboop_rl_la_LDFLAGS): Removed.
	(liboop_rl_la_LIBADD): Removed.
	(liboop_rl_la_SOURCES): Removed.
	(check_PROGRAMS): New name for former noinst_PROGRAMS.
	(test_oop_LDADD): Removed $(lib_LTLIBRARIES) and added -loop.
	(install-exec-local): Removed.  There is no need to run ldconfig.

	Removed liboop files that are generated by autoconf or automake.
	* src/libraries/liboop/aclocal.m4: Removed.
	* src/libraries/liboop/Makefile.in: Removed.
	* src/libraries/liboop/configure: Removed.
	* src/libraries/liboop/install-sh: Removed.
	* src/libraries/liboop/missing: Removed.
	* src/libraries/liboop/mkinstalldirs: Removed.

	Import liboop-0.9.
	* src/libraries/liboop/README: File created.
	* src/libraries/liboop/*: Import version 0.9 of liboop to the
	lyskom-server repository.

526
527
528
529
530
531
532
533
534
535
536
537
538
	Liboop calls siglongjmp from a signal handler.  Check if that is
	really portable.
	* scripts/xenofarm.sh: Run the test-sigjmp program as a separate
	task.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
	test-sigjmp.
	(test_sigjmp_SOURCES): New variable.
	(test_sigjmp_LDADD): New variable.
	(check-test-sigjmp): New target.
	* src/server/testsuite/test-sigjmp.c: New test program.  Verify
	that select can be broken by a siglongjmp call from a signal
	handler.

539
540
2003-07-03  Per Cederqvist  <ceder@ceder.dyndns.org>

541
542
543
	Turn on the -Wfloat-equal gcc warning.
	* configure.in: Added -Wfloat-equal to CFLAGS.

544
545
546
547
548
	Update the test suite for the denial-of-service fix.
	* src/server/testsuite/lyskomd.0/01.exp: Expect the get-last-text,
	find-next-text-no and find-previous-text-no requests to fail when
	the user isn't logged in.

549
550
551
552
553
554
555
556
557
558
559
560
561
562
2003-05-09  Per Cederqvist  <ceder@ingate.com>

	Require that the user is logged in before allowing him to do
	get-last-text, find-next-text-no or find-previous-text-no.  This
	fixes a denial-of-service attack reported by Calle Dybedahl.
	* src/server/text.c (get_last_text): Require the user to be logged
	in.
	(find_next_text_no): Ditto.
	(find_previous_text_no): Ditto.
	* doc/Protocol-A.texi (get-last-text): This request now requires
	that the user is logged in.
	(find-next-text-no): Ditto.
	(find-previous-text-no): Ditto.

563
564
2003-03-23  Per Cederqvist  <ceder@ceder.dyndns.org>

565
566
567
568
	Don't copy zero-length arrays.  (Bug 1005).
	* src/server/memory.c (copy_membership): Don't allocate a copy of
	read_ranges if read_ranges is NULL.

569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
	Test for bug 1005.
	* src/server/testsuite/lyskomd.0/36.exp: New file that triggers an
	assertion.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	36.exp.

	Don't copy zero-length arrays.
	* src/server/membership.c (read_ranges_precondition): Don't
	allocate a copy of read_ranges if read_ranges is NULL.

	Code cleanup.
	* src/server/prot-a-output.c (prot_a_output_read_texts): Coding
	standards issue: compare the pointer read_ranges against NULL, not
	0.

584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
2003-03-15  Per Cederqvist  <ceder@ceder.dyndns.org>

	Remove the "magic" field of Connection.  Valgrind provides a
	better and less intrusive way to find memory allocation errors.
	* src/server/connections.h (CONN_MAGIC_ALLOC): Removed.
	(CONN_MAGIC_FREE): Removed.
	(Connection): Removed the magic field.
	* src/server/internal-connections.c (init_connection): Don't set
	the magic field.
	(new_client): Ditto.
	(kill_client): Ditto.
	* src/server/connections.c (logout_client): Don't check the magic
	field.

	Allow test suite configuration (such as the timeout) to be
	overridden in localcfg.exp.
	* src/server/testsuite/config/unix.exp: Source config/localcfg.exp
	if it exists.
	* src/server/testsuite/config/.cvsignore: Ignore localcfg.exp.

Per Cederqvist's avatar
Per Cederqvist committed
604
605
606
607
608
609
2003-03-08  Per Cederqvist  <ceder@ceder.dyndns.org>

	Port 4894 is official.
	* doc/Protocol-A.texi (Connecting to the Server): Mention that
	port 4894 is registered with IANA.

Per Cederqvist's avatar
Per Cederqvist committed
610
611
612
613
614
615
2003-02-09  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor makefile fix.
	* src/libraries/libeintr/Makefile.am (eintr.h $(funcs)): Use
	$(AWK) and not @AWK@.

Per Cederqvist's avatar
Per Cederqvist committed
616
617
618
619
620
621
622
2003-02-08  Per Cederqvist  <ceder@ceder.dyndns.org>

	Port to FreeBSD 4.7.
	* doc/Makefile.am (check-doc): Make sed pattern more portable by
	not using "[---a-z0-9]".  FreeBSD 4.7 said "RE error: invalid
	character range".

623
624
2003-01-18  Per Cederqvist  <ceder@ceder.dyndns.org>

625
626
627
628
629
630
631
	Xenofarm: use TZ=GMT to work around buggy dwim_time().
	* scripts/xenofarm.sh (log): Set TZ to GMT, and LC_ALL to C,
	before calling date.  The Pike function Calendar.ISO.dwim_time
	does very buggy things when a time zone it doesn't understand is
	encountered, so force everybody to use the well-known GMT time
	zone.

632
633
634
635
	Disable the test suite on taylor.
	* scripts/xenofarm.sh: Don't run the test suite on taylor.
	Runtest is broken there.

636
637
638
639
640
641
642
643
	Xenofarm: move warning filtering to a separate file.
	* scripts/xenofarm.sh: Moved large sed script to warnings.sed.
	* scripts/warnings.sed: New file.  This sed script removes all
	false warnings.  New coding standard rule: each (group of) removed
	warning(s) should be preceded by a comment that gives an example
	of where the warning occurs.  I'm starting with an almost empty
	file, and will add back the filters and collect info on from where
	they originate.
Per Cederqvist's avatar
Per Cederqvist committed
644
	* scripts/Makefile.am (EXTRA_DIST): Distribute warnings.sed.
645

646
647
648
649
650
651
2003-01-17  Per Cederqvist  <ceder@ceder.dyndns.org>

	Complete testing of async-deleted-text et c.  (Bug 59).
	* src/server/testsuite/.cvsignore: Ignore 35-aux.conf.
	* src/server/testsuite/lyskomd.0/35.exp: Test case completed.

Per Cederqvist's avatar
Per Cederqvist committed
652
653
654
655
656
2003-01-17  Per Cederqvist  <ceder@ingate.com>

	Xenofarm warnings.
	* scripts/xenofarm.sh: Ignore glibc-2.1.2/gcc-2.95.2 warnings.

657
658
2003-01-17  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
659
660
661
662
	Fixed cut-n-paste error.
	* src/server/text.c (report_bad_aux): Don't declare variables in
	the middle of a function!

663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
	Minor testsuite fixes.
	* src/server/testsuite/lyskomd.0/30.exp: Specify a long sync
	interval, to avoid spurious async-sync-db messages.
	* src/server/testsuite/config/unix.exp (epoch_time): New constant.
	* src/server/testsuite/lyskomd.0/05.exp: Use epoch_time.  This
	test used to fail when run west of London.

	Continue testing async-deleted-text et c.  Fix bugs found.  
	(Bug 59).
	* src/server/text.c (report_bad_aux): New static function.
	(is_member_in_linked_recpt): New argument: tno.  All callers
	updated.  For now, do nothing special with cross-reference; until
	but 23 is fixed that would be pointless.  Report bad aux-items
	with report_bad_aux.  Added missing breaks.
	(interested_party): New argument: tno.  All callers updated.
	* src/server/testsuite/lyskomd.0/35.exp: Commit of work in
	progress.  Still needs more work.

	Stricter checking on aux-item cross-reference.
	* run-support/aux-items.conf (cross-reference): If anything
	follows the reference, it must begin with a space.

	Typos fixed.
	* src/libraries/libmisc/s-string.h: Fixed typo in a comment.
	* README: Typo fixed.

689
690
691
692
693
694
695
696
697
698
2003-01-14  Per Cederqvist  <ceder@ceder.dyndns.org>

	Start testing async-deleted-text et c.  (Bug 59).
	* src/server/testsuite/lyskomd.0/35.exp: New file.  Test sending
	of async-deleted-text, async-new-text, async-new-text-old,
	async-add-recipient and async-sub-recipient to recipients of texts
	that are linked to the text.  Needs more work.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	35.exp.

699
700
2003-01-13  Per Cederqvist  <ceder@ingate.com>

Per Cederqvist's avatar
Per Cederqvist committed
701
702
703
704
705
706
	Xenofarm tweaking.
	* scripts/xenofarm.sh: Remove installedfiles.txt if it is empty.
	Use mv instead of cp to move files into the result package, to
	preserve time stamps.  Create corefiles.txt if any core files are
	found.

707
708
709
710
	Cut-n-paste error introduced in last commit fixed.
	* src/server/text.c (is_member_in_linked_recpt): Fixed cut-n-paste
	error.

Per Cederqvist's avatar
Per Cederqvist committed
711
712
2003-01-13  Per Cederqvist  <ceder@ceder.dyndns.org>

713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
	Send async-deleted-text, async-new-text, async-new-text-old,
	async-add-recipient and async-sub-recipient to recipients of text
	linked to the relevant text.  (Bug 59).
	* src/server/text.c (is_member_in): New static function.
	(is_member_in_recpt): Use is_member_in to simplify code.
	(is_member_in_recpt_of): New static function.
	(is_member_in_linked_recpt): New static function.
	(interested_party): New static function. This also considers if
	the potential message recipient is a member of a recipient of a
	text that is linked to the text, via a misc-info or a aux-item.
	(send_async_sub_recipient): Use interested_party to determine if
	the asynchronous message should be sent.
	(send_async_deleted_text): Ditto.
	(send_async_new_text_old): Ditto.
	(send_async_new_text): Ditto.
	(send_async_add_recipient): Ditto.
	(text_read_access): Added const qualifiers.
	* src/server/manipulate.h (text_read_access): Added const
	qualifiers.
	(person_text_read_access): Ditto.

Per Cederqvist's avatar
Per Cederqvist committed
734
735
736
737
	Port to DejaGnu 1.2.
	* scripts/xenofarm.sh: DejaGnu 1.2 doesn't understand --version,
	so use "runtest -V" instead when detecting runtest.

738
739
2003-01-12  Per Cederqvist  <ceder@ceder.dyndns.org>

740
741
742
743
	Fix too restrictive validation on content-type.
	* run-support/aux-items.conf (content-type): Allow anything
	after a semicolon.

744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
	Implemented passive-message-invert.  (Bug 827).
	* doc/Protocol-A.texi (Membership Information): Renamed the
	reserved1 bit of Membership-Type to passive-message-invert.
	Document it.
	(async-send-message): Mention that the passive and
	passive-message-invert bits of the Membership-Type influences if
	messages are sent or not.
	(send-message): Mention passive and passive-message-invert.
	Mention async-send-message.
	(Error Codes): Don't say "group message".
	* src/include/kom-types.h (Membership_type): Renamed reserved1 to
	passive_message_invert.
	* src/server/admin.c (send_message): Handle
	passive_message_invert.
	* src/server/ram-parse.c (fparse_membership_type): Handle
	passive_message_invert.
	* src/server/ram-output.c (foutput_membership_type): Handle
	passive_message_invert.
	* src/server/prot-a-parse.c (prot_a_parse_membership_type): Handle
	passive_message_invert.
	* src/server/prot-a-output.c (prot_a_output_membership_type):
	Handle passive_message_invert.
	* src/server/person.c (create_person_generic): Handle
	passive_message_invert.
	* src/server/memory.c (init_membership_type): Handle
	passive_message_invert.
	* src/server/membership.c (set_membership_type_bits): Handle
	passive_message_invert.
	* src/server/dbck.c (check_membership): Handle
	passive_message_invert.
	* src/server/testsuite/lyskomd.0/34.exp: New file.  Test the
	passive-message-invert bit of Membership-Type.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	34.exp.

	Made aux-items.conf more strict.  (Bug 451).
	* run-support/aux-items.conf (content-type): Don't allow more than
	one "/".
	(no-comment): This must be unique and contain no data.
	(personal-comment): Ditto.
	(request-confirmation): Ditto.
	(read-confirm): This must contain no data.
	(redirect): Clear inherit, secret and hide-creator.
	(mx-author): Clear inherit, secret, hide-creator and dont-garb.
	(mx-from): Ditto.
	(mx-reply-to): Ditto.
	(mx-message-id): Ditto.
	(mx-in-reply-to): Ditto.
	(mx-misc): Ditto.
	(mx-allow-filter): Ditto.
	(mx-reject-forward): Ditto.
	(mx-to): Clear inherit and dont-garb.
	(mx-cc): Ditto.
	(canonical-name): Ditto.
	(mx-date): Clear hide-creator, secret and dont-garb.
	(notify-comments): Clear inherit, hide-creator and dont-garb.
	(recommended-conf): Clear inherit and dont-garb.
	(allowed-content-type): Clear inherit and dont-garb.  Require a
	priority number before the content type, and don't allow more than
	one "/" or " ".
	(mx-list-name): Set owner-delete.  Clear dont-garb and inherit.
	(mx-refuse-import): Set unique.  Clear dont-garb and inherit.
	(mx-mime-misc): Set unique.
	(mx-envelope-sender): Set unique.
	* src/server/testsuite/lyskomd.0/20.exp: Adjusted for the new,
	stricter aux-items.conf.
	* src/server/testsuite/lyskomd.0/03.exp: Adjusted for the new,
	stricter aux-items.conf.

813
814
2003-01-10  Per Cederqvist  <ceder@ceder.dyndns.org>

815
816
817
818
819
	Document undocumented files.  (Bug 852).
	* doc/lyskomd.texi (Parameters): Documented the default values of
	"Connection status file" and "Connection status temp file".
	(Files): Documented db/number.txt and etc/connections.txt.

820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
	Use mark_person_as_changed properly in mark_as_read.  (Bug 877).
	* src/server/membership.c (mark_as_read): The list of read texts
	is part of the person, so use mark_person_as_changed, not
	mark_conference_as_changed.  (Bug 877).
	(mark_as_unread): FIXME comment removed.
	(set_read_ranges): Ditto.

	Write a test case for bug 877.
	* src/server/testsuite/lyskomd.0/bug-877.exp: New file.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	bug-877.exp.
	* src/server/simple-cache.c: All these changes are only in effect
	if DEBUG_CALLS is defined:
	Include services.h and manipulate.h.
	(block_after_pre_sync): New static variable.
	(save_one_conf): Return immediately if block_after_pre_sync is
	true.
	(cache_sync_all): Crash if block_after_pre_sync is true.
	(cache_sync_start): New request.
	(cache_sync_finish): New request.
	* src/server/fncdef.txt (cache_sync_start): New DEBUG_CALLS
	request.
	(cache_sync_finish): Ditto.
	* src/include/services.h (cache_sync_start): New DEBUG_CALLS
	request.
	(cache_sync_finish): Ditto.

	Code cleanup.
	* src/server/connections.c (kill_list): Now static.
	(kill_list_size): Now static.

851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
2003-01-07  Per Cederqvist  <ceder@lysator.liu.se>

	Port to IRIX64, where "unsigned long" isn't large enough to avoid
	alignment problems.
	* src/server/ram-smalloc.c: Include <inttypes.h> or <stdint.h>.
	(union overhead): New union.  Use two of these instead of two
	unsigned ints as the overhead at the front of a malloced block.
	This ensures we get the alignment that we need.
	(smalloc): Updated to use union overhead.  Some useless casts
	removed.
	(sfree): Ditto.
	(srealloc): Ditto.
	* configure.in: Check for <stdint.h>, intptr_t, intmax_t and
	size_t.

Per Cederqvist's avatar
Per Cederqvist committed
866
2003-01-07  Per Cederqvist  <ceder@ingate.com>
Per Cederqvist's avatar
Per Cederqvist committed
867
868
869
870
871

	Xenofarm cleanup.
	* scripts/xenofarm.sh: Don't create .pass-, .warn- and .fail
	files.  The information is present in mainlog.txt, and the
	Xenofarm scripts no longer need them.
Per Cederqvist's avatar
Per Cederqvist committed
872
873
874
875
876
877

	Upgrade to valgrind-1.9.2.
	* src/server/testsuite/lyskomd.supp: Valgrind 1.9.2 detects the
	isc_tcp_accept_fn in the calltrace, so we have to update the
	suppressions for bug 916.

Per Cederqvist's avatar
Per Cederqvist committed
878
879
880
881
882
2003-01-07  Per Cederqvist  <ceder@ceder.dyndns.org>

	Note a bug.
	* src/server/text.c (add_recipient): FIXME comment added.

883
884
885
886
887
888
889
890
891
892
893
2003-01-06  Per Cederqvist  <ceder@lysator.liu.se>

	Change to Xenofarm log file format version 2.
	* scripts/xenofarm.sh (logstart, logpass, logfail, logwarn): New
	functions.
	(dotask): New argument: warnfunc.  All callers updated.  Convert
	to Xenofarm log format version 2.
	(cfgwarn, makewarn, ckprgwarn): New functions that hunt for
	warnings.  Extracted from the top level.
	(Top Level): Removed special-caseing for taylor.

894
895
2003-01-06  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
896
897
898
899
	Xenofarm tweaking.
	* scripts/xenofarm.sh: Use sed -e instead of multiple grep -v.
	This should scale better.

900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
	Implemented async-new-user-area.  (Bug 7).
	* doc/Protocol-A.texi (async-new-user-area): New async message.
	* src/server/async.h (enum async): Added ay_new_user_area.
	* src/server/person.c (do_set_user_area): Renamed a few local
	variables.  Call async_new_user_area when the user area changes.
	* src/server/session.c (accept_async): Handle ay_new_user_area.
	* src/server/send-async.h, src/server/send-async.c
	(async_new_user_area): New function.
	* src/server/prot-a-send-async.h, src/server/prot-a-send-async.c
	(prot_a_async_new_user_area): New function.
	* src/server/person.c (do_set_user_area): Indentation fixes.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	33.exp.
	* src/server/testsuite/lyskomd.0/33.exp: New file: test
	async-new-user-area.
	* src/server/testsuite/lyskomd.0/03.exp: Expect asynchronous
	message 19 to exist.

	Improve the description on how to add an async message.
	* doc/lyskomd.texi (Adding Asynchronous Messages): Mention
	sesion.c, 03.exp and that new test cases should be written.

922
923
924
925
926
927
	Test deletion of a person that is logged in on another session.
	* src/server/testsuite/lyskomd.0/32.exp: New file.  Test deletion
	of a person that is logged in on another session.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	32.exp.

928
929
930
931
932
	Don't state that async-leave-conf is sent when the person is
	deleted.
	* doc/Protocol-A.texi (async-leave-conf): This is not sent when
	the person is deleted, so don't say that it is.

933
934
935
936
937
938
939
940
	Update the testsuite for the new semantics of "Max conferences".
	* src/server/testsuite/lyskomd.0/person-cov.exp: Lower "Max
	conferences" from 18 to 17, to compensate for the bugfix of
	2003-01-04.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Lower "Max
	conferences" from 20 to 19, to compensate for the bugfix of
	2003-01-04.

941
942
2003-01-04  Per Cederqvist  <ceder@ceder.dyndns.org>

943
944
945
946
947
	Make it easier to reduce the DejaGnu timeout.
	* src/server/testsuite/config/unix.exp: Moved the setting of
	timeout around so that people with a fast machine can reduce the
	timeout simply by removing a has sign.

948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
	Document what happens when a text, person or conference cannot be
	created because of the "Max texts"/"Max conferences" parameters.
	* doc/Protocol-A.texi (create-person-old): Document the error code
	index-out-of-range.
	(create-person): Ditto.
	(create-conf-old): Ditto.
	(create-conf): Ditto.
	(create-text-old): Ditto.
	(create-text): Document what error-status is set to when
	index-out-of-range is returned.

	The "Max texts" and "Max conferences" parameters was off by one.
	* src/server/server-config.c (read_configuration): Increase
	param.max_text and param.max_conf.  This fixes an off-by-one error
	in the documentation and parameter naming.

	Test the "Max texts" and "Max conferences" parameters.
	* src/server/testsuite/lyskomd.0/31.exp: Test the "Max texts" and
	"Max conferences" parameters.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	31.exp.

	The error code anonymous-rejected was not documented under
	create-text.
	* doc/Protocol-A.texi (create-text).  Document the error code
	anonymous-rejected.

975
976
2002-12-30  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
977
978
979
980
	Port to autoconf 2.57.
	* configure.in: Require autoconf 2.57.  Use AC_CONFIG_HEADERS
	instead of AM_CONFIG_HEADER.

Per Cederqvist's avatar
Per Cederqvist committed
981
982
983
984
985
	Update copyright headers.
	* <all files>: update the year in the copyright notice.
	* scripts/lyskomd-copyrights: Added bug-52.data and bug-52.texts
	to the list of files that should not have a copyright header.

986
987
988
989
	Clarify the faq-text item in aux-items.conf.
	* run-support/aux-items.conf (faq-text): Changed the regexp
	validation to explicitly forbid linking to text number 0.

Per Cederqvist's avatar
Per Cederqvist committed
990
991
992
993
	Minor doc fix.
	* doc/Protocol-A.texi (add-footnote): The description for the
	error code index-out-of-range was wrong.

994
995
996
997
998
999
	Autoconf: better check for "attribute unused" support.
	* configure.in: Use CMOD_C_WORKING_ATTRIBUTE_UNUSED instead of
	CMOD_C_ATTRIBUTE_UNUSED.
	* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Removed.
	(CMOD_C_WORKING_ATTRIBUTE_UNUSED): New defun.

1000
1001
2002-11-28  Per Cederqvist  <ceder@ceder.dyndns.org>

1002
1003
1004
	Added IPv6 support, coded by Thorild Selén
	<thorild@Update.UU.SE>.  (Bug 563).
	* configure.in: Added --enable-ipv6 switch.
1005
	* AUTHORS: Added Thorild Selén.
1006

1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
	Stop mark-as-read from leaking info about secret conferences.
	(Bug 48).
	* src/server/membership.c (mark_as_read): Don't leak info about
	secret conferences.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	bug-48.exp.
	* src/server/testsuite/lyskomd.0/bug-48.exp: New file.

	Removed redundant dbck runs from the test suite.
	* src/server/testsuite/lyskomd.0/bug-52.exp (stop): Removed a
	redundant call to dbck_run.

1019
1020
1021
1022
1023
1024
	Update documentation.
	* doc/lyskomd.texi (Adding New Input Types): Test for client
	disconnect during parsing.
	* doc/Protocol-A.texi (set-read-ranges): Added error code
	conference-zero.

1025
1026
2002-11-27  Per Cederqvist  <ceder@ceder.dyndns.org>

1027
1028
1029
1030
1031
	Test set-read-ranges.  (Bug 54).
	* src/server/testsuite/lyskomd.0/30.exp: Test set-read-ranges.	
	* src/server/testsuite/lyskomd.0/29.exp: Added test cases for
	client disconnect while parsing a read_range_list.

1032
1033
1034
	Test mark-as-unread.  (Bug 53).
	* src/server/testsuite/lyskomd.0/30.exp: Test mark-as-unread.

1035
1036
2002-11-26  Per Cederqvist  <ceder@ceder.dyndns.org>

1037
1038
1039
1040
	Use valgrind-1.1.0 instead of valgrind-1.0.0.
	* src/server/testsuite/lyskomd.supp: Adjusted to valgrind-1.1.0.
	Added suppressions for bug 916.

Per Cederqvist's avatar
Per Cederqvist committed
1041
1042
1043
1044
	Fixed a broken log message.
	* src/server/membership.c (read_ranges_postcondition): Added a
	missing newline in the log message.

1045
1046
1047
1048
	Plugged a memory leak in mark-as-unread.
	* src/server/membership.c (remove_loc_no): srealloc() or sfree()
	the read_ranges if we remove a range.

1049
1050
1051
1052
1053
1054
	Test mark-as-unread and set-read-ranges a little.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	30.exp.
	* src/server/testsuite/lyskomd.0/30.exp: New file.  Test
	mark-as-unread and set-read-ranges.  This is not complete yet.

1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
2002-11-25  Per Cederqvist  <ceder@ceder.dyndns.org>

	Upgraded for autoconf-2.56 and automake-1.7.1.
	* HACKING: Updated version numbers of autoconf and automake.
	* src/server/Makefile.am (AM_YFLAGS): Set AM_YFLAGS instead of
	YFLAGS.  The latter is reserved for the user.
	* doc/Protocol-A.texi: Use @c instead of @ignore..@end ignore
	inside the @copying command, since @ignore..@end ignore no longer
	works there with the texinfo.tex supplied with automake-1.7.1.
	* configure.in: Upgraded for autoconf-2.56 and automake-1.7.1:
	Use AC_COMPILE_IFELSE instead of AC_TRY_COMPILE.  Use
	AC_LANG_PROGRAM.  Use AC_LINK_IFELSE instead of AC_TRY_LINK.  Use
	AC_RUN_IFELSE instead of AC_TRY_RUN.

1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
2002-11-25  Per Cederqvist  <ceder@ingate.com>

	Bug 93 has been split into several bugs.  Update the FIXME
	comments that refered to bug 93.
	* src/server/text.c (modify_text_info): Update FIXME comment.
	* src/server/person.c (create_person): Update FIXME comment.
	* src/server/connections.c (logout_client): Update FIXME comment.
	* src/server/conference.c (do_delete_conf): Update FIXME comment.
	(set_etc_motd): Ditto.
	(modify_conf_info): Ditto.
	* src/server/admin.c (set_motd_of_lyskom): Update FIXME comment.

1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
2002-11-15  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor doc fixes.
	* doc/Protocol-A.texi (mark-as-read): Added markup.
	(set-unread): Ditto.
	(get-membership): This was introduced in protocol version 11, not
	10.

	Added new requests 109=mark-as-unread and 110=set-read-ranges.
	* doc/Protocol-A.texi (mark-as-unread): New request.
	(set-read-ranges): New request.
	(Error Codes): Added invalid-range and invalid-range-list.
	* src/include/services.h (mark_as_unread): New request.
	(set_read_ranges): New request.
	* src/server/fncdef.txt: Added mark_as_unread and
	set_read_ranges.
	* src/server/membership.c (remove_loc_no): New static function.
	(read_ranges_precondition): New static function.
	(read_ranges_postcondition): New static function.
	(mark_as_read): Extracted debug code to read_ranges_precondition
	and read_ranges_postcondition.
	(mark_as_unread): New function.
	(check_range_list): New static function.
	(set_read_ranges): New function.
	* src/server/testsuite/lyskomd.0/01.exp: Test 109=mark-as-unread
	and 110=set-read-ranges.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.

	Added parsing of "ARRAY Read-Range", aka read_range_list, needed
	by request 110=set-read-ranges.
1111
1112
	* doc/lyskomd.texi (Parameters): Document "Max read_ranges per
	call".
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
	* src/server/param.h (struct kom_par): Added max_read_ranges.
	* src/server/server-config.c (parameters): Added "Max read_ranges
	per call".
	* src/server/prot-a.c (prot_a_destruct): Free read_range_list.
	* src/server/prot-a-parse.h (prot_a_parse_read_range_list): New
	function.
	* src/server/prot-a-parse.c (prot_a_parse_read_range): New static
	function.
	(prot_a_parse_read_range_list): New function.
	* src/server/prot-a-parse-arg-c.awk: Handle read_range_list.
	* src/server/internal-connections.c (init_connection): Initialize
	read_range_list.
	* src/server/connections.h (Connection): Added read_range_list.
	* src/server/connections.c (free_parsed): Free read_range_list.
	* src/server/call-switch.awk: Handle read_range_list.
	* src/include/kom-types.h (struct read_range_list): New struct.
	* src/include/kom-errno.h (enum kom_err): Added KOM_INVALID_RANGE
	and KOM_INVALID_RANGE_LIST.

1132
1133
2002-11-14  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1134
1135
1136
	Release administrativa.
	* HACKING: Publish the NEWS file on the web when doing a release.

1137
1138
1139
1140
1141
1142
1143
1144
	Test 107=query-read-texts and 108=get-membership even 
	more.  (Bug 590).
	* src/server/testsuite/lyskomd.0/bug-37.exp: Test
	107=query-read-texts and 108=get-membership.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.

1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
2002-11-13  Per Cederqvist  <ceder@ceder.dyndns.org>

	Release administrativa.
	* HACKING: Make sure no closed bugs are left on the TODO list.

	Test 107=query-read-texts and 108=get-membership.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Fixed a couple of
	errors in the range-based test cases.
	(checkit): Test 107=query-read-texts and 108=get-membership.
	(checktrunc): New proc.  Use it a few times to check that the new
	requests can truncate the ranges of read texts.
	* src/server/testsuite/lyskomd.0/03.exp: Be prepared that
	query-read-texts-old now adjusts the read ranges.  Test
	107=query-read-texts and 108=get-membership.  Renumber.
	* src/server/testsuite/lyskomd.0/01.exp: Test 107=query-read-texts
	and 108=get-membership.  Renumber.

	Implement 107=query-read-texts and 108=get-membership.
	* src/server/prot-a.c (prot_a_reply): Handle rt_membership and
	rt_membership_list.
	* src/server/prot-a-output.h, src/server/prot-a-output.c 
	(prot_a_output_membership): New function.
	(prot_a_output_membership_list): New function.
	* src/server/person.c (do_query_read_texts): New arguments:
	want_read_ranges and max_ranges.  All callers updated.  Call
	adjust_read() if want_read_ranges is true.
	(query_read_texts): New function.
	* src/server/membership.c (copy_public_confs): New arguments:
	keep_read and max_ranges.  All callers updated.
	(adjust_read): Now has external linkage.  Changed return type from
	void to Bool; return true if the membership was modified.
	(do_get_membership): New arguments: keep_ranges and max_ranges.
	Renamed the want_read_texts argument to want_read_ranges.  All
	callers updated.
	(get_membership): New function.
	* src/server/manipulate.h (adjust_read): Now has external
	linkage.
	* src/server/fncdef.txt: Added query_read_texts and
	get_membership.
	* src/server/connections.h (Connection): Added num4.
	(enum res_type): Added rt_membership and rt_membership_list.
	(union result_holder): Added membership and membership_list.
	* src/include/services.h (get_membership): New function.
	(query_read_texts): New function.

	Documented new range-based requests get-membership and
	query-read-texts.  Renamed the old versions by adding a "-10"
	suffix.
	* doc/constructs.expected: Removed references to bug 52.
	* doc/Protocol-A.texi (Membership and Reading): Talk about
	read-ranges, not last-text-read and read-texts.
	(Person Status Types): Mention read-ranges.
	(Membership Information): Mention that obsolete versions of
	Membership exists.
	(Membership Information): Renamed Membership to Membership-10, and
	added new Membership and Read-Range types.
	(Protocol Requests): Flag 98=query-read-texts-10 and
	99=get-membership-10 as obsolete.  Added 107=query-read-texts and
	108=get-membership.
	(sub-member): Changed get-membership to get-membership-old, since
	that is was the example uses.  Added markup.
	(mark-as-read): Changed query-read-texts to query-read-texts-old,
	since that is what the example uses.  Added markup.
	(set-unread): Ditto.
	(set-last-read): Ditto.
	(query-read-texts-10): New name for former request
	query-read-texts.  Mark it as obsolete and refer to the new
	query-read-texts request.  Changed return type to Membership-10.
	(get-membership-10): New name for former request
	get-membership.  Mark it as obsolete and refer to the new
	get-membership request.  Changed return type to ARRAY
	Membership-10.
	(query-read-texts): New request.
	(get-membership): New request.
	(Membership visibility): Added get-membership-10 and
	query-read-texts-10.
	(What do I have unread): Added markup.
	(Future changes): Removed references to bug 52.
	(Document Edition History): Tracked the renaming of
	query-read-texts-10 and get-membership-10.

1226
1227
2002-11-12  Per Cederqvist  <ceder@ceder.dyndns.org>

1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
	Added a "_10" suffix to type Membership and all derived types and
	functions, in preparation of writing range-based replacements.
	* src/server/fncdef.txt: Renamed functions:
	    query_read_texts -> query_read_texts_10
	    get_membership   -> get_membership_10
	Renamed types:
	    membership       -> membership_10
	    membership_list  -> membership_list_10
	* src/include/services.h: Renamed functions:
	    query_read_texts -> query_read_texts_10
	    get_membership   -> get_membership_10
	* src/server/connections.h (enum res_type): Renamed:
	    rt_membership      -> rt_membership_10
	    rt_membership_list -> rt_membership_list_10
	(union result_holder): Renamed:
	    membership      -> membership_10
	    membership_list -> membership_list_10
	* src/server/prot-a.c (prot_a_reply): Use membership_old instead
	of membership where appropriate.  Track rename of *membership* to
	*membership*_10.
	* src/server/person.c (query_read_texts_10): Renamed from
	query_read_texts.
	* src/server/membership.c (get_membership_10): Renamed from
	get_membership.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
	(prot_a_output_membership_10): Renamed from
	prot_a_output_membership.
	(prot_a_output_membership_list_10): Renamed from
	prot_a_output_membership_list.

	Allow types in Protocol A to end in a number suffix.
	* doc/checkargs.py (lexer.__bad_type): Allow types that ends in a
	number, such as "Membership-10".

	Testsuite: work on even slower computers.
	* src/server/testsuite/config/unix.exp (timeout): Increase the
	timeout even further.

	Log message fixed.
	* src/server/ram-parse.c (fparse_read_range_0): Fixed wrong
	function name in a log message.

	Ignore gcov-generated files in libeintr.
	* src/libraries/libeintr/.cvsignore: Ignore *.bb, *.bbg and
	*.da.

	Doc typo fixed.
	* doc/lyskomd.texi (Modifying Output Types): Typo fixed.

1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
	Fixed all known bugs in the range-based read-texts implementation.
	* src/server/ram-parse.c (fparse_read_range_0): Don't forget the
	first interval that is created based on last-text-read.
	* src/server/membership.c (adjust_read): Aim at setting first_read
	of the first range to 1, even if that is lower than the first
	currently existing text in the conference.  Make the code that
	tries to extend ranges towards higher numbers more efficient -- no
	loop is needed, since l2g_next_key can be used.  Removed some dead
	code.
	* src/server/testsuite/lyskomd.0/bug-52.exp (start): Use serial
	number 999 instead of 1000 to ease debugging.

1289
1290
1291
1292
1293
1294
2002-11-11  Per Cederqvist  <ceder@ceder.dyndns.org>

	Finish the test-suite for range-based representation.  This
	reveals at least two errors in the implementation.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Renumber and extend.
	(do_restart): Set to 1.
1295
	(check_unread_confs): New proc.  Use it several times.
1296

1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
2002-11-10  Kent Engström  <kent@lysator.liu.se>

        Add support for the mx-refuse-import aux item.
	* run-support/aux-items.conf: Add mx-refuse-import [35].
	* doc/Protocol-A.texi (Aux-Item Types): Ditto.
	* doc/constructs.expected: Add @code{all}, @code{spam}.
	* src/server/testsuite/lyskomd.0/01.exp: Fix to accept the
	added aux item.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	* src/server/testsuite/lyskomd.0/18.exp: Ditto.

	Add information about dependence on texinfo version.
	* HACKING: Add entry about texinfo.

1311
1312
1313
1314
2002-11-10  Per Cederqvist  <ceder@lysator.liu.se>

	Make do_get_members() look nicer.
	* src/server/membership.c (do_get_members): Minor code cleanup and
1315
1316
	indentation fixes.  Use init_member() to set all fields, and then
	explicitly set (only) the secret bit.
1317

1318
1319
2002-11-09  Per Cederqvist  <ceder@ceder.dyndns.org>

1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
	Even more tests for the range-based representation.
	* src/server/testsuite/lyskomd.0/bug-52.exp: Expand the test suite
	and prepare it for range-based information commands.
	(lazy_expand): New variable.
	(mark_as_read_atomic): New variable.
	(do_restart): New variable.  This is currently set to 0 to hide
	known errors...
	(restart): New proc.
	(checkit): New argument: ranges.

1330
1331
1332
	Added more tests of the range-based representation for read
	texts.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
1333
	bug-52.data, bug-52.texts and bug-52.exp.
1334
1335
1336
1337
1338
1339
	* src/server/testsuite/lyskomd.0/bug-52.exp: New file.
	* src/server/testsuite/lyskomd.0/bug-52.data: New file.
	* src/server/testsuite/lyskomd.0/bug-52.texts: New file.
	* src/server/testsuite/config/unix.exp (unpack_db): New proc.
	(lyskomd_start): New args: confs, texts and nogarb.

1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
2002-11-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Use a range-based representation in core for the texts a user has
	read.  The external representation is not yet affected.  (Bug 52).
	* src/include/kom-types.h (struct read_range): New struct.
	(Membership): Removed fields last_text_read, no_of_read and
	read_texts.  Added fields no_of_read_ranges, read_ranges and
	skip_read_texts.
	* src/server/ram-parse.c (fparse_read_range_0): New static
	function that handles the new range-based representation of
	memberships.
	(fparse_membership_2): Use it.
	(fparse_membership_0): Use it.
	(fparse_membership_list_0): Handle the new range-based
	representation of memberships.
	(fparse_membership_list_2): Ditto.
	* src/server/ram-output.c (foutput_read_ranges_0): New static
	function that handles the new range-based representation of
	memberships.
	(foutput_membership_0): Use it.
	(foutput_membership_2): Use it.
	* src/server/prot-a-output.c (prot_a_output_read_texts): New
	static function that handles the new range-based representation of
	memberships.
	(prot_a_output_membership_old): Use it.
	* src/server/person.c (do_query_read_texts): Handle new
	range-based representation of memberships.
	* src/server/memory.c (clear_membership): Handle new
	range-based representation of memberships.
	(copy_membership): Ditto.
	(init_membership): Ditto.
	* src/server/membership.c (copy_public_confs): Handle new
	range-based representation of memberships.
	(adjust_read): Ditto.
	(insert_loc_no): Ditto.
	(do_add_member): Ditto.
	(do_sub_member): Ditto.
	(check_membership): Ditto.
	(mark_as_read): Ditto.
	(do_get_membership): Ditto.
	(get_unread_confs): Ditto.
	(set_unread): Ditto.
	(set_last_read): Ditto.
	(last_text_read): New static inline function.
	* src/server/dbck.c (check_membership): Handle range-based
	representation of memberships.

	Xenofarm warnings.
	* scripts/xenofarm.sh: Ignore warnings about reduced hard ulimit.

1390
1391
2002-11-05  Per Cederqvist  <ceder@ceder.dyndns.org>

1392
1393
1394
1395
	Spell-check Protocol-A.texi.
	* HACKING: Spell-check Protocol-A.texi when a release is made.
	* doc/Protocol-A.texi: A few spelling errors fixed.

1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
	Testsuite: timeout handling was broken.
	* src/server/testsuite/config/unix.exp (fix_expect_after): Don't
	unconditionally add a timeout pattern.  Contrary to my belief, a
	timeout pattern seems to refer to a specific spawn id.  If we add
	it here when there are no spawned processes, the timeout will
	refer to stdin, and this will cause expect to detect eof on stdin
	when run from Xenofarm.  Instead, everything that spawns a process
	must add timeout patterns to the expect_active variable.
	(l2g_start): Add a timeout pattern to expect_active.
	(lyskomd_start): Ditto.
	(lyskomd_start_fail): Ditto.
	(client_start): Ditto.
	(client_start_fail): Ditto.

	Test suite fixes.
Per Cederqvist's avatar
Per Cederqvist committed
1411
1412
	* src/server/testsuite/config/unix.exp (dbck_run): Added missing
	"global spawn_id".
1413
1414
	* src/server/testsuite/lyskomd.0/12.exp: After dbck_run has
	finished, we must re-specify which client we want to talk to.
Per Cederqvist's avatar
Per Cederqvist committed
1415

1416
1417
1418
1419
1420
1421
1422
1423
	The test suite didn't stop listening to lyskomd when it died.
	* src/server/testsuite/config/unix.exp (lyskomd_death): Don't
	listen to the lyskomd spawn id once it has died.
	(kill_lyskomd): Ditto.
	* src/server/testsuite/lyskomd.0/11.exp: Match all output.
	Somehow this test didn't fail even though there were unmatched
	output from lyskomd.  Strange.

1424
	Never reuse text or conference numbers.  (Bug 810).
1425
1426
	* doc/lyskomd.texi (Parameters): New parameters: "Number file:"
	and "Number temp file:".
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
	* src/server/param.h (struct kom_par): Added numberfile_name and
	numberfile_tmp_name.
	* src/server/server-config.c (parameters): Added "Number file" and
	"Number temp file".
	(read_configuration): Handle them.
	* src/server/simple-cache.c (highest_conf_no): Explicitly
	initialize to 0.
	(highest_text_no): Ditto.
	(write_number_file): New static function.
	(read_number_file): Ditto.
	(cached_create_conf): Call write_number_file, and return
	KOM_TEMPFAIL if it fails.
	(cached_create_text): Ditto.
	(init_cache): Don't set highest_conf_no and highest_text_no.  They
	are only used during the save phase.  Call read_number_file.
	* db-crypt/db/number.txt: New file.
	* db-crypt/db/Makefile.am (EXTRA_DIST): Added number.txt.
	(install-data-local): Install number.txt.
	(uninstall-local): Remove number.txt.  Don't remove anything if
	number.txt is altered.
	* src/server/testsuite/config/unix.exp (lyskomd_start): New
	optional arguments: log_messages, init_db and want_stale.  Copy
	number.txt.  Don't copy the database if init_db is 0.  Expect a
	log message about a removal of a stale lock file if want_stale is
	1.  Expect log_messages after the startup messages but before the
	garb messages.
	(lyskomd_fail_start): Copy number.txt.
	* src/server/testsuite/lyskomd.0/bug-810.exp: Expect messages
	about lost texts and conferences in the log.  Don't expect any
	failures.

1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
2002-11-04  Per Cederqvist  <ceder@ceder.dyndns.org>

	Write test case for bug 810: retain text, person and conference
	numbers after a crash.
	* src/server/testsuite/config/unix.exp (kill_lyskomd): New proc.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	bug-810.exp.
	* src/server/testsuite/lyskomd.0/bug-810.exp: Test that text,
	person and conference number are never reused, not even when the
	server crashes.

1469
1470
1471
1472
1473
1474
1475
1476
1477
2002-11-04  Per Cederqvist  <ceder@ingate.com>

	Xenofarm: ignore warnings from assignment of SIG_IGN.
	* scripts/xenofarm.sh: Updated list of warnings to ignore.
	* src/server/ramkomd.c (set_handler_sig_ign): New function.
	(server_init): Use it.
	(go_daemon): Use it.  This reduces the number of warnings on some
	platforms.

1478
1479
2002-11-04  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1480
1481
1482
1483
	Fixed a grammar error.
	* doc/Protocol-A.texi (Document Edition History): Fixed grammar
	error.  Reported by Hans Persson.

1484
1485
1486
1487
1488
1489
1490
1491
	Fixed typo.
	* src/server/ram-smalloc.c: Fixed a typo in a comment.

	Release administrativa that missed the deadline.
	* README: Recommend the "-C" option of "./configure".
	* HACKING: Updated with stuff found while performing the 2.0.7
	release.

1492
1493
1494
1495
2002-11-03  Per Cederqvist  <ceder@lysator.liu.se>

	* Release 2.0.7.

1496
1497
2002-11-02  Per Cederqvist  <ceder@ceder.dyndns.org>

1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
	Disable the extended tests for the release.
	* src/server/testsuite/lyskomd.0/gen-19.py (EXTENDED): Reset to 0.
	* src/server/testsuite/lyskomd.0/gen-15.py (EXTENDED): Reset to 0.

	Not all makes sets RM, so do it manually in all Makefile.am.
	* src/libraries/libeintr/Makefile.am (RM): Set it.
	* run-support/Makefile.am (RM): Set it.
	* db-crypt/db/Makefile.am (RM): Set it.

	A few files lacked a copyright header.
	* src/server/testsuite/lyskomd.0/summarize.sh: Added copyright
	header.
	* src/server/testsuite/bignum.c: Added copyright header.
	* src/libraries/libeintr/gen-wrapper.awk: Added copyright header.
	* src/libraries/libeintr/eintr.h.pre: Added copyright header.
	
	Update the copyright updater.
	* scripts/lyskomd-copyrights: Ignore generated files in libeintr
	and the testsuite.

1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
	Run extended tests on the Xenofarm.
	* src/server/testsuite/lyskomd.0/gen-19.py (EXTENDED): Set to 1.
	* src/server/testsuite/lyskomd.0/gen-15.py (EXTENDED): Set to 1.

	Fix the distribution.
	* src/libraries/libeintr/Makefile.am (nodist_libeintr_a_SOURCES):
	Added the nodist_ prefix, to avoid distributing these generated
	files.
	(MOSTLYCLEANFILES): Added the generated files.

	Release administrativa.
	* scripts/lyskomd-copyrights: Updated the copyright statement.
	* README: Updated version numbers for TCL and expect.  Updated
	copyright statement.
	* NEWS: Updated.
	* HACKING: We actually use Python 2.1 for the release generation,
1534
	not 2.2.1.  Extract the release from the Xenofarm build package.
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
	* doc/Protocol-A.texi (Document Edition History): Updated with all
	made changes.

	Fixed a few minor problems with Protocol-A.texi.
	* doc/Protocol-A.texi(Some Client-specific Aux-Item Types): New
	name for the appendix formerly known as "Client-specific Aux-Item
	Types".  Another node of that name already exists!
	(LysKOM Content Types): Fixed a typo.
	(Membership visibility): Fixed typos.
	(Order of misc-info groups): Fixed a typo.

1546
1547
1548
1549
1550
1551
2002-11-01  Per Cederqvist  <ceder@ceder.dyndns.org>

	The timeout of the test suite was too low.
	* src/server/testsuite/config/unix.exp (timeout): Increase the
	timeout further.  Hal apparently needs it.

1552
1553
2002-10-31  Per Cederqvist  <ceder@ceder.dyndns.org>

1554
1555
1556
1557
	NFS-mounted databases may fail.  Warn the administrator.
	* README: Added a warning that NFS-mounted databases may fail due
	to EINTR.

1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
	Added a library of wrapper functions that checks for EINTR.
	* configure.in: Generate src/libraries/libeintr/Makefile.
	* src/libraries/Makefile.am (SUBDIRS): Added libeintr.
	* src/libraries/libeintr/gen-wrapper.awk: New file.  Generate
	simple wrappers that check for EINTR.
	* src/libraries/libeintr/funcs.txt: New file.  Use wrappers for
	fopen, fclose and rename.
	* src/libraries/libeintr/eintr.h.pre: New file.
	* src/libraries/libeintr/Makefile.am: New file.

	Use the libeintr wrappers instead of fopen, fclose and rename.
	* src/server/Makefile.am (AM_CPPFLAGS): Added libeintr.
	(lyskomd_LDADD): Ditto.
	(dbck_LDADD): Ditto.
	(LDADD): Ditto.
	* src/server/updateLysKOM.c (main): Use i_fopen instead of fopen.
	Don't forget to close the status file.
	* src/server/splitkomdb.c (copy_file, copy_db_file): Use i_fopen
	and i_fclose instead of fopen and fclose.
	* src/server/simple-cache.c (is_clean, get_version, post_sync)
	(save_one_text, sync_part, init_cache, free_all_cache): Use
	i_fopen and i_fclose instead of fopen and fclose.
	(pre_sync): Ditto, and i_rename instead of rename.
	* src/server/ramkomd.c (save_pid, dump_exit_statistics): Use
	i_fopen and i_fclose instead of fopen and fclose.
	* src/server/ram-smalloc.c (trace_alloc_file): Use f_fopen
	intstead of fopen.
	* src/server/pidfile.c (read_pid_file): Use i_fopen and i_fclose
	instead of fopen and fclose.
	* src/server/komrunning.c (create_status): Use i_fopen and
	i_fclose instead of fopen and fclose.
	* src/server/dbck.c (garb_text_file): Use i_rename instead of
	rename.  Check the return value.
	* src/server/dbck-cache.c (get_version, is_clean, cache_sync_all) 
	(cache_open_new_text_file, init_cache): Use i_fopen, i_fclose and
	i_rename instead of fopen, fclose and rename.
	* src/server/connections.c (dump_statistics): Use i_fopen and
	i_fclose instead of fopen and fclose.
	(dump_connections): Ditto, and i_rename instead of rename.
	* src/server/conf-file.c (read_config): Use i_fopen and i_fclose
	instead of fopen and fclose.
	* src/server/aux-item-def-parse.y (parse_aux_item_definitions):
	Use i_fopen and i_fclose instead of fopen and fclose.

Per Cederqvist's avatar
Per Cederqvist committed
1602
1603
2002-10-28  Per Cederqvist  <ceder@ingate.com>

1604
1605
1606
1607
1608
	Check if rename really sets errno to EINTR.
	* src/server/connections.c (dump_connections): Set errno to 0
	before the rename that strangely returns with EINTR during the
	Xenofarm tests.

Per Cederqvist's avatar
Per Cederqvist committed
1609
1610
	* NEWS: Updated.

1611
1612
2002-10-28  Per Cederqvist  <ceder@ceder.dyndns.org>

1613
1614
1615
1616
1617
	Make dump_connections more robust.
	* src/server/connections.c (dump_connections): Call fflush() and
	ferror().  This might help track down spurious errors from the
	rename that I don't understand.

1618
1619
1620
1621
1622
1623
	Release administrativa.
	* HACKING: Mention "make distcheck".

	Test suite cleanup.
	* scripts/xenofarm.sh: Removed the "eintr" task.

1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
2002-10-28  Per Cederqvist  <ceder@lysator.liu.se>

	Port to AIX 4.2: limit the number of open file descriptors
	properly.
	* src/server/connections.c (toploop) [!USING_RLIMIT_NOFILE]: Fixed
	a off-by-one error.

	Fixed compile error on systems lacking SA_RESTART.
	* src/server/ramkomd.c (setup_sighandlers): Added a missing
	semicolon.

Per Cederqvist's avatar
Per Cederqvist committed
1635
1636
2002-10-27  Per Cederqvist  <ceder@ceder.dyndns.org>

1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
	Testsuite fixes.  Don't use __FILE__ in log messages, as it isn't
	very useful, and makes the test suite more complex.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: Don't expect
	the "connections.c" file name in the log message, as that broke
	when doing an srcdir build.
	* src/server/text.c (is_member_in_recpt): Don't use __FILE__.
	(do_sub_recpt): Ditto.
	(check_double_subm): Ditto.
	(check_double_comm): Ditto.  Fix the function name in a log
	message.
	* src/server/memory.c (clear_text_stat): Don't use __FILE__.  Fix
	the function name in a log message.
	* src/server/connections.c (dump_statistics): Don't use __FILE__.

1651
1652
1653
1654
1655
1656
	Don't require bison/yacc when compiling.  (Bug 843).
	* src/server/Makefile.am: The explicit dependencies added
	2002-10-21 to fix "make clean; make check" was broken: the ".c"
	extension was used instead of ".o" in several cases.  This
	resulted in bison being run on the client.

Per Cederqvist's avatar
Per Cederqvist committed
1657
1658
1659
1660
1661
	Consider FD_SETSIZE.
	* src/server/ramkomd.c (initialize): Don't allow the number of
	open files to be larger than FD_SETSIZE.
	* src/server/testsuite/testfd.c (find_limits): Report FD_SETSIZE.

Per Cederqvist's avatar
Per Cederqvist committed
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
2002-10-27  Per Cederqvist  <ceder@lysator.liu.se>

	Testsuite fixes.
	* src/server/testsuite/lyskomd.0/11.exp: Fixed a race condition in
	the test.
	* src/server/testsuite/config/unix.exp (obtain_lock): Search for
	locksuite.py in $srcdir.
	(lyskomd_start): Removed unused global declaration of srcdir.
	(lyskomd_fail_start): Ditto.
	(client_death): Ditto.

1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
2002-10-27  Per Cederqvist  <ceder@ceder.dyndns.org>

	Port to AIX 4.2: limit the number of open file descriptors in a
	more portable way.
	* src/include/kom-config.h (PROTECTED_FDS): Added parenthesis
	around the number.
	(MAX_NO_OF_CONNECTIONS): Removed.
	(USING_RLIMIT_NOFILE): Define if we have a good setrlimit.
	(fd_ceiling): New variable.
	* src/server/server-config.c (MAX_NO_OF_CONNECTIONS): Removed.
	(fd_ceiling): New variable.
	* src/server/connections.c (toploop): Transform ISC_EVENT_LOGIN to
	ISC_EVENT_LOGIN_UNRELOCATED if the file descriptor is above
	fd_ceiling.  This can only happen if USING_RLIMIT_NOFILE is
	undefined, so ifdef out this code.
	* src/server/ramkomd.c (go_daemon): Close everything below
	fd_ceiling instead of using MAX_NO_OF_CONNECTIONS + PROTECTED_FDS.
	(initialize): Use getrlimit/setrlimit if USING_RLIMIT_NOFILE is
	defined.  Check that getrlimit after setrlimit returns a sane
	value.  Don't use sysconf(_SC_OPEN_MAX), since getrlimit provides
	a better value.  Set fd_ceiling instead of MAX_NO_OF_CONNECTIONS.
	Make it possible to lower the ceiling even when we don't have a
	working setrlimit.  Removed the final sanity checks; the world
	ain't sane.
	* src/server/testsuite/testfd.c (main): Adjusted logic for error
	checks to be similar to the code now used.  In particular, don't
	test sysconf(_SC_OPEN_MAX), and don't test getrlimit if
	HAVE_BROKEN_NOFILE.

1702
1703
1704
1705
1706
1707
1708
2002-10-26  Per Cederqvist  <ceder@lysator.liu.se>

	Prepare for more portable handling of the number of file
	descriptors used.
	* configure.in: Define HAVE_BROKEN_NOFILE if
	setrlimit(RLIMIT_NOFILE) fails.

1709
1710
2002-10-26  Per Cederqvist  <ceder@ceder.dyndns.org>

1711
1712
1713
1714
1715
1716
1717
1718
	Update the testsuite so that it doesn't fail because of
	SA_RESTART/select() on HP-UX.
	* src/server/testsuite/Makefile.am (check-test-select): Pass
	--no-sa-restart to test-select, so that we test the code the way
	we actually use it.
	* src/server/testsuite/test-select.c (main): New argument:
	--no-sa-restart.  Don't use SA_RESTART if given.

1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
	Port to HP-UX: Use SA_RESTART except while calling select().
	* src/server/sigflags.h (restart_syscalls_on_intr): New function.
	(intr_syscalls_on_intr): New function.
	* src/server/ramkomd.c (setup_sighandlers): New function.  Use
	SA_RESTART if the "restartable" argument is true.
	(restart_syscalls_on_intr): New function.
	(intr_syscalls_on_intr): New function.
	(main): Move signal handler setup to setup_sighandlers().
	* src/server/connections.c (toploop): Call intr_syscalls_on_intr()
	before calling isc_getnextevent, and restart_syscalls_on_intr()
	immediately after its return.

1731
1732
1733
1734
1735
1736
1737
1738
2002-10-26  Per Cederqvist  <ceder@lysator.liu.se>

	Port to SunOS 4.1.1_U1 that lacks SA_RESTART.
	* src/server/testsuite/test-select.c (main): Call link_ansi().
	Only set SA_RESTART if it is available.
	* src/server/testsuite/Makefile.am (test_select_LDADD): New
	variable.

1739
1740
2002-10-26  Per Cederqvist  <ceder@ceder.dyndns.org>

1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
	Use SA_RESTART.
	* src/server/ramkomd.c (main): Use SA_RESTART, even though it
	potentially will cause lyskomd to block in select() instead of
	responding promptly to signals.

	Check that SA_RESTART can interrupt select().
	* src/server/testsuite/test-select.c: Test if select() can be
	interrupted by a signal even when SA_RESTART is specified.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added
	test-select.
	(test_select_SOURCES): New variable.
	(check): Added check-test-select.
	(check-test-select): New target.
	* scripts/xenofarm.sh: Added eintr test, to check the
	select/SA_RESTART in a separate task.

1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
	Fixed a race condition in the test suite.
	* src/server/testsuite/tcpconnect.py: Flush stdout more often.
	Give feedback on "#supsend socket" and "#resume socket" to avoid a
	race condition.
	* src/server/testsuite/config/unix.exp (kill_client): Include the
	client number in the test name when testing for stray output.
	This makes it easier to see which client that misbehaves.
	(suspend_client): Expect a response from the client.
	(resume_client): Ditto.

1767
1768
2002-10-25  Per Cederqvist  <ceder@ceder.dyndns.org>

1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
	The test suite now test for buffer overflow in the proper way.
	(Bug 844).
	* src/server/testsuite/config/unix.exp (l2g_start): Test for
	"full_buffer".  An old expect document has fooled us to test for
	"buffer_full" instead; that doesn't work.
	(simple_expect): Ditto.
	(good_bad_expect): Ditto.
	(extracting_expect): Ditto.
	(unanchored_expect): Ditto.
	(lyskomd_start): Ditto.
	(lyskomd_fail_start): Ditto.
	(client_start): Ditto.
	(client_start_fail): Ditto.

1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
	The test suite failed when configured with --with-debug-calls.
	* src/server/testsuite/config/unix.exp (lyskomd_fail_start):
	Handle --with-debug-calls compilations.
	* src/server/testsuite/lyskomd.0/09.exp: Handle --with-debug-calls
	compilations.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Ditto.

	Improve a few log messages.
	* src/server/person.c (do_set_user_area): Improve the "Old
	user_area X unmarked" message.
	* src/server/conference.c (do_set_presentation): Improve the "Old
	presentation not marked" message.
	(do_set_etc_motd): Improve the "New motd has X marks" and "Old
	motd not marked" messages.
	* src/server/admin.c (set_motd_of_lyskom): The "Old motd not
	marked" message used the wrong function name.

1802
1803
1804
1805
1806
	Log the reason why the connection status file cannot be renamed.
	(Bug 841).
	* src/server/connections.c (dump_connections): Emit
	strerror(errno) when file operations fails.

1807
1808
2002-10-23  Per Cederqvist  <ceder@ceder.dyndns.org>

1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
	Plugged a memory leak.  (Bug 816).
	* src/server/prot-a.c (prot_a_destruct): Clear dummy_aux_item, to
	plug a memory leak.  To trigger this leak, you had to send an
	oversized aux-item-list, that contained an oversized string in the
	last part of the oversized array, and disconnect while sending the
	last part of the string.

	Test client disconnect more thoroughly.  (Bug 63).
	* src/server/testsuite/lyskomd.0/29.exp: Several more test cases
	added.  We now trigger bug 816.
	(startup): Reduce "Max aux_item length" and "Max links per text".

Per Cederqvist's avatar
Per Cederqvist committed
1821
1822
1823
1824
1825
1826
1827
	Test suite fixes.
	* src/server/testsuite/lyskomd.0/03.exp: Wait for a third tick.
	This test failed on computers that were too fast, due to the
	script waiting too short a time.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Added a
	missing dot that caused --with-debug-calls tests to fail.

1828
1829
1830
1831
1832
1833
	Clients should offer to add the letterbox of the author if he
	isn't a member of any of the recipients.
	* doc/Protocol-A.texi (Recipients of comments): Added a
	description of what to do when the author of a new comment isn't a
	member of any of the recipients.