ChangeLog 137 KB
Newer Older
Per Cederqvist's avatar
Per Cederqvist committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
1999-05-14  Per Cederqvist  <ceder@lysator.liu.se>

	Fixes to the test suite.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: A client
	dies immediately when it receives %% No connections left, so the
	test case should not expect it to live longer.  Renumber the
	ref-nos.  The nologin file exists in the build directory, not in
	srcdir.
	* src/server/testsuite/leaks.0/leaks02.exp: Don't forget the flags
	argument to create-person.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Don't attempt
	to use debug calls unless debug_calls is true.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Likewise.

15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
1999-05-13  Per Cederqvist  <ceder@gratia>

	Distribute the leaks tests, and run them during "make check".
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Track the rename
	of lyskoms.0/leaks*.exp -> leaks.0/leaks*.exp.
	(check): Depend on check-leaks.
	(check-leaks): New target.

	Code cleanup/minor bugs fixed.
	* src/server/testsuite/tcpconnect.py: socket.recv can raise
	socket.error!  Handle it as end-of-file.
	* src/server/simple-cache.c (cached_conf_exists): Removed the
	unused variable node.
	* src/server/aux-items.c (find_linked_aux_item_list): Don't use an
	uninitialized variable.
	(delete_aux_item_list): Fail if the default branch is reached.
	(undelete_aux_item_list): Fail if the default branch is reached.
	(aux_item_trigger_mirror_faq): Test data->object for NULLness
	intstead of the uninitialized variable conf_stat.
	* doc/hacking.texi (Linking Pairs of Aux Items): Texinfo problem
	fixed.
	* doc/Protocol-A.texi (set-info): Untabify.
	(accept-async): Untabify.
	(query-async): Untabify.

David Byers's avatar
David Byers committed
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
1999-05-12  David Byers  <davby@ida.liu.se>

	Stuff I forgot to add below

	* Renamed log to kom_log since log is a function in math.h.
	
	* src/include/services.h (set_pers_flags): New prototype. 
	(create_person): Added flags parameter.
	
	* run-support/config: Set defaults for max texts and max
	conferences.

	* run-support/aux-items.conf (faq-text): Removed all triggers. Set
 	add-trigger to link-faq, added validator.
	(faq-for-conf): New item definition.

	* doc/lyskomd.texi (Parameters): Added Max conferences, Max texts, 
	Max client data length, Nologin fle. Updated some other parameter
	descriptions.
	(Aux-Item Definition File): Added system-only. Rewrote validate to 
	allow function identifiers. Added list of validator functions and
	triggers.
	(Files): Document /etc/nologin.

	* doc/hacking.texi: Correct minor typos. Change some @code into
	@file.
	(Linking Pairs of Aux Items): New section.

	* doc/Protocol-A.texi: Correct minor typos
	(Predefined Aux-Item Types): Rephrase some
	of the text. Remove statement that faq-text item marks a text.
	Document faq-for-conf. Specify formate for mx-message-id. 
	(Simple Data Types): Removed documentation for INTEGER.
	(set-etc-motd): Change too-many-marks to mark-limit
	(mark-text-old): Change too-many-marks to mark-limit
	(set-conf-type): Correct documentation for secret-public error.
	Correct spelling in invalid-membership-type documentation.
	(add-recipient): Add documentation for access-denied error
	(add-comment): Define error-status in index-out-of-range.
	(sub-comment): Change no-comment to not-comment.
	(send-message): Complete documentation of message-not-sent error.
	(create-text): Add index-out-of-range as possible error.
	(create-conf): Complete doc of permission-denied error.
	(create-person): Added personal-flags parameter.
	(create-person): Document person-exists error.
	(set-pers-flags): New call.
	(Error Codes): Clarify message-not-sent and index-out-of-range.

	* configure.in: Added flag --with-insure++. Define AVOID_ABORTS
	when compiling with support for gcov.
	
	* src/server/testsuite/tcpconnect.py: Added #hose socket to hose
 	the socket with lots of zeroes.

	* src/server/testsuite/config/prot-a.exp: New functions
	kom_set_permitted_submitters, kom_set_super_conf, kom_login_old,
	kom_mark_text, kom_sub_recipient, kom_set_conf_type,
	kom_change_conference, kom_set_priv_bits.
	(kom_create_person): Send the pers_flags field.

	* src/server/testsuite/config/unix.exp: Print a dot for every test 
	case in verbose mode.
	(lyskomd_start): New parameters extra_config for additional config 
	file contents and base_config for basic config file contents
	(defaults will not be used.) Don't print defaults for max
	conferences or max texts if they are in extra_config. It is
	possible to start lyskomd with arbitrary arguments.
	(lyskomd_fail_start): Function to use when lyskomd is supposed to
	not start properly (like lyskomd_start, but server failue is
	expected.)
	(client_start_fail): New function like client_start, but failure
	is expected.
	(kill_client): Unset expect_active and expect_always instead of
	setting to the empty string.
	(hose_client): New function

	* src/server/testsuite/lyskomd.0/00.exp: Send pers-flags in calls
	to create-person.

	* src/server/testsuite/lyskomd.0/01.exp: Update expected results
	in query-predefined-aux-items. Send pers-flags in call to
	create-person. Add test for set-pers-flags. Add test for
	nonexistent call 107.

	* src/server/testsuite/lyskomd.0/02.exp: Send pers-flags in call
	to create-person.

	* src/server/testsuite/lyskomd.0/03.exp: Expect aux-item 28 in
	query-predefined-aux-items. Send pers-flags in call to
	create-person. Expect the faq-for-conf aux-item in test 1327.
	Expect failure attempting to set nonexistent text as faq (test
	1342.) Remove the now failed faq item in subsequent tests. Add
	test for set-pers-flags.

	* src/server/testsuite/lyskomd.0/04.exp: Send pers-flags in calls
	to kom_create_person.

	* src/server/testsuite/lyskomd.0/05.exp: Send pers-flags in calls
	to kom_create_person. Be more flexible when expecting time
	corresponding to time_t zero. Set garb and sync interval to
	something really high to avoid spurious async messages while
	running the tests.

	* src/server/testsuite/lyskomd.0/06.exp: Send pers-flags in calls
	to kom_create_person.

	* src/server/testsuite/lyskomd.0/admin-cov.exp: More setup to
	support new tests. Test that we can't send messages to secret
	confs. Test that messages are filtered for passive members.

	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Send
	pers-flags in calls to kom_create_person. Attempt to create
	aux-items with broken validation regexp. Test the system-only
	attribute. Test a broken aux-item config file.

	* src/server/testsuite/lyskomd.0/aux-items.cov: Add an item
	definition with system-only property.
	
	* src/server/prot-a-parse.h: Added prototype for
 	prot_a_parse_pers_flags
	
	* src/server/prot-a-parse.c (prot_a_parse_pers_flags): New
	function to parse pers flags.
	
	* src/server/prot-a-output.c (prot_a_output_text_mapping):
 	Initialize the fields of iter to avoid warnings from tools that
 	detect access to uninitialize memory.
	
	* src/server/local-to-global.c: Use kom_log instead of log.
	
	* src/server/kom-memory.c: Added prototypes for init_aux_item and
	init_aux_item_link. 
	
	* src/server/aux-items.c (system_check_add_aux_item_list): Call
	aux_item_add_perm with INFO_OBJECT_TYPE for the object_type
	parameter.

	* src/server/admin.c: Use kom_log instead of log everywhere. 
	(send_message): Do not permit sending group messages to secret
	conferences. Set errno to KOM_MESSAGE_NOT_SENT if there are no
	appropriate recipients.

	* src/server/aux-item-def-parse.y: Parse validation functions in
	addition to validation regexps. Use kom_log instead of log. Parse
	the system-only property.
	(aux_item_def_check_validate): New function.

	* src/server/aux-items.c: Add the aux-item being involved item
 	itself to aux-item trigger data.
	(aux_item_validate_existing_text): New validation function.
 	(aux_item_trigger_mirror_faq): New add trigger function
 	(aux_item_trigger_unmark_text): Modified to work for aux-items on
 	texts and conferences, not just conferences. Do not unmark an
 	unmarked text.
	(aux_item_trigger_mark_text): Do not add more marks than
 	permitted.
	(find_aux_item_index): New function to find the index of an item
	with a particular number in an aux item list.
	(commit_aux_item_list): Renamed to commit_aux_item_list_internal.
	(commit_aux_item_list_internal): Delete linked aux items.
	(commit_aux_item_list): Wrapper for commit_aux_item_list_internal.
	(delete_aux_item_list): Manage deletion of linked items.
	(undelete_aux_item_list): Manage undeletion of linked items.
	(mark_linked_object_as_changed): New function to mark the object
	containing a linked aux item as changed.
	(find_linked_aux_item): New function to find the aux item that is
	linked to a given aux item.
	(find_linked_aux_item_list): New function to find the aux item
	list containing the aux item that is linked to a given aux item.
	(aux_item_validate): New function for validating aux items. Deals
	with regexps and validation functions.
	(aux_item_add_perm): Handle the system-only property of aux item
	definitions.
	

1999-05-09  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (prepare_aux_item): Clear the linked_item
 	field properly.

	* src/server/memory.c (init_aux_item_link): New function.
	(init_aux_item): Use init_aux_item_link
	(init_aux_item): New function added earlier.

	* src/server/prot-a-parse.c (prot_a_parse_aux_item): Clear the
	parsed aux_item to get good defaults for fields that are not read
	in the parser.

	* src/server/admin.c (modify_server_info): Pass INFO_OBJECT_TYPE
	to delete_aux_item_list and undelete_aux_item_list.

	* src/server/aux-items.h: Changed all declarations of object_type
	from short to Object_type.

	* src/server/aux-items.c: Changed all declarations of object_type
	from short to Object_type.

	* src/server/ram-parse.c (fparse_aux_item_link): New function.
	(fparse_aux_item): Parse the link as well.

	* src/include/kom-types.h (Object_type): New type (moved defs from
 	aux-items.h) 
	(Aux_item_link): New type
	(Aux_item): Added linked_item field.

	* src/server/ram-output.c (foutput_aux_item): Output linked_item
	field.
	(foutput_aux_item_link): New function to output a link to another
	aux item.

	* src/server/aux-items.c: Added handling of item field in aux item 
	trigger calls.

	* src/server/aux-items.h (Aux_item_trigger_data_s): Added item
	field.

	* src/server/aux-items.c (system_check_add_aux_item_list): Set
	owner_check to TRUE in call to aux_item_add_perm so system-only
	restriction works on system-info aux-item list.

	* src/server/testsuite/lyskomd.0/admin-cov.exp: Added tests for
	sending messages to secret confs and to conf with passive member
	logged in.

	* doc/Protocol-A.texi (send-message): Document that
	message-not-sent is returned when there are no recipients for a
	group message.

	* src/server/com-h.awk: Set illegal_fnc to -1 (was cnt) since cnt
	might be a legal function.

271
272
273
274
1999-05-02  Per Cederqvist  <ceder@gratia>

	"make check" in the top directory failed in some environments.
	* src/server/testsuite/Makefile.am (check-lyskomd): Close file
275
	descriptors 3-9 to avoid interference between file descriptors
276
277
	inherithed from make, sshd et c with lyskomd.0/07.exp.

Per Cederqvist's avatar
Per Cederqvist committed
278
279
280
281
282
283
284
1999-05-01  Per Cederqvist  <ceder@lysator.liu.se>

	Use libisc-1.00.
	* src/libraries/libisc-new: Replace the old contents with that of
	isc-1.00.  Se src/libraries/libisc-new/ChangeLog for information
	about any modifications that are made to the library.

285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
1999-04-28  Per Cederqvist  <ceder@lysator.liu.se>

	Remove support for the mux protocol.  Don't use isc_printf.
	* src/server/testsuite/lyskomd.0/07.exp: Decrease the all file
	descriptors by one, now that the server no longer listens for a
	mux.  Test that protocol B is unsupported.
	* src/server/testsuite/config/unix.exp (muxport): Removed.
	(lyskomd_start): Don't set "Mux port" in the config file.
	* src/server/server-config.c (parameters): Removed parameter "Mux
	port".
	* doc/lyskomd.texi (Parameters): Removed "Mux port".
	* src/server/ramkomd.c (listen_mux): Removed.
	(server_init): Remved the "mux_port" argument.  Don't listen for
	muxes.
	(initialize): Don't pass the "mux_port" argument to server_init.
	* src/server/prot-a.c (prot_a_reply): Use isc_putc, isc_putul,
	isc_flush and prot_a_output_ul instead of mux_printf, mux_flush
	and mux_putc.
	(prot_a_parse_packet): Likewise.
	* src/server/prot-a-send-async.c (async_header): Use isc_putc,
	isc_putul, prot_a_output_ul and isc_flush instead of mux_printf,
	mux_putc and mux_flush.
	(async_trailer): Likewise.
	(prot_a_async_new_text_old): Likewise.
	(prot_a_async_new_text): Likewise.
	(prot_a_async_logout): Likewise.
	(prot_a_async_new_name): Likewise.
	(prot_a_async_forced_leave_conf): Likewise.
	(prot_a_async_login): Likewise.
	(prot_a_async_send_message): Likewise.
	(prot_a_async_deleted_text): Likewise.
	(prot_a_async_new_recipient): Likewise.
	(prot_a_async_sub_recipient): Likewise.
	(prot_a_async_new_membership): Likewise.
	* src/server/prot-a-output.h (prot_a_output_ul): New function.
	* src/server/prot-a-parse.c (prot_a_get_token): Use isc_puts and
	isc_flush instead of mux_printf and mux_flush.
	(prot_a_parse_num_list): Likewise.
	(prot_a_parse_string): Likewise.
	* src/server/prot-a-output.c (prot_a_output_ul): New function.
	(prot_a_output_person): Use prot_a_output_ul, isc_puts, isc_putc
	and isc_write instead of mux_printf, mux_putc and mux_write.
	(prot_a_output_membership_type): Likewise.
	(prot_a_output_membership): Likewise.
	(prot_a_output_membership_old): Likewise.
	(prot_a_output_membership_list_old): Likewise.
	(prot_a_output_membership_list): Likewise.
	(prot_a_output_conf_list): Likewise.
	(prot_a_output_conf_no_list): Likewise.
	(prot_a_output_conference): Likewise.
	(prot_a_output_conference_old): Likewise.
	(prot_a_output_uconference): Likewise.
	(prot_a_output_mark_list): Likewise.
	(prot_a_output_aux_item_flags): Likewise.
	(prot_a_output_aux_item): Likewise.
	(prot_a_output_text_stat_old): Likewise.
	(prot_a_output_aux_item_list): Likewise.
	(prot_a_output_who_info_ident): Likewise.
	(prot_a_output_who_info): Likewise.
	(prot_a_output_who_info_list): Likewise.
	(prot_a_output_who_info_ident_list): Likewise.
	(prot_a_output_who_info_list_old): Likewise.
	(prot_a_output_session_info): Likewise.
	(prot_a_output_session_info_ident): Likewise.
	(prot_a_output_info_old): Likewise.
	(prot_a_output_string): Likewise.
	(prot_a_output_priv_bits): Likewise.
	(prot_a_output_personal_flags): Likewise.
	(prot_a_output_conf_type): Likewise.
	(prot_a_output_extended_conf_type): Likewise.
	(prot_a_output_member_list): Likewise.
	(prot_a_output_member_list_old): Likewise.
	(prot_a_output_member): Likewise.
	(prot_a_output_member_old): Likewise.
	(prot_a_output_mark): Likewise.
	(prot_a_output_misc_info): Likewise.
	(prot_a_output_time): Likewise.
	(prot_a_output_session_no): Likewise.
	(prot_a_output_text_no): Likewise.
	(prot_a_output_conf_z_info): Likewise.
	(prot_a_output_conf_z_info_list): Likewise.
	(prot_a_output_version_info): Likewise.
	(prot_a_output_num_list): Likewise.
	(prot_a_output_dynamic_session_info): Likewise.
	(prot_a_output_dynamic_session_info_list): Likewise.
	(prot_a_output_l2g_iterator_as_text_list): Likewise.
	(prot_a_output_text_mapping): Likewise.
	(prot_a_output_memory_info): Likewise.
	* src/server/param.h (struct kom_par): Removed ip_mux_port,
	num_ip_mux_port and num_ip_client_port.
	* src/server/isc-interface.h (ISC_UDGTYPE): Use "struct
	connection" instead of "struct mux".
	(ISC_PRINTF_SUPPORT): Don't define it.
	* src/server/internal-connections.c (init_connection): Use
	isc_session instead of mux.
	(kill_client): Likewise.
	* src/server/connections.h (Connection): Replaced mux with isc_session.
	* src/server/connections.c (logout_client): Use ISC instead of the
	removed mux layer.
	(parse_packet): Likewise.
	(parse_unparsed): Likewise.
	(login_request): Likewise.  Don't handle muxes.
	(logout_request): Likewise.
	(message_request): Likewise.
	(mux_handle_packet): Removed.
	(mux_logout): Removed.
	(mux_parse_unparsed): Removed.
	(mux_parse_message): Removed.
	(milli_timevaldiff): New name for former timevaldiff.  Return the
	difference in milliseconds instead of microseconds.
	(toploop): Use milli_timevaldiff instead of timevaldiff.  This is
	a thousand times better at avoiding overflow.  Use isc_puts
	instead of isc_printf.
	* src/server/mux.h: File removed.
	* src/server/mux.c: File removed.
	* src/server/mux-parse.h: File removed.
	* src/server/mux-parse.c: File removed.
	* src/server/Makefile.am (lyskomd_SOURCES): Removed mux-parse.h
	and mux.h.
	(MUX): Removed.  Removed mux.c and mux-parse.c.
	(GENOBJS): Removed $(MUX).
	* doc/mux.proto: File removed.
	* doc/Makefile.am (EXTRA_DIST): Remove mux.proto.
	* configure.in: Remove enable_isc_printf -- we no longer need
	isc_printf.

	Fix a warning message in the testsuite.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Fixed the
	"unsupported" message: The configure option is named
	--with-debug-calls, not --enable-debug-calls.

416
417
418
419
420
421
422
423
424
425
426
427
1999-04-25  Per Cederqvist  <ceder@gratia>

	Increase the block size of the l2g structure from 10 to 250.
	* src/server/local-to-global.h (l2g_set_block_size): New function.
	* src/server/local-to-global.c (L2G_BLOCKSIZE): Now a static int
	instead of a define.
	(l2g_set_block_size): New function, that can be called once to
	set the block size
 	(l2g_init): Set the block size to 250 unless it has already been
	set.
	* src/server/testsuite/test-l2g.c (main): Set the block size to 10.

David Byers's avatar
David Byers committed
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
1999-04-23  David Byers  <davby@ida.liu.se>

	* src/server/standalone.c (kom_info): Initialize the
	aux_item_list too.

	* src/server/ramkomd.c (initialize): Use kom_log instead of log.

	* src/server/local-to-global.c (l2g_read): Use kom_log instead of
	log.

	* src/server/text.c (text_read_access): Call
	person_text_read_access to do the work.
	(person_text_read_access): New function generalizes
	text_read_access.

	* src/server/manipulate.h: Prototype for person_text_read_access.

1999-04-21  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.c (aux_item_find_validator): New function.

449
450
451
452
453
454
455
456
1999-04-20  Per Cederqvist  <ceder@gratia>

	Two file descriptors were leaked during startup.
	* src/server/aux-item-def-parse.y (parse_aux_item_definitions):
	Close the config file once it is read.
	* src/server/conf-file.c (read_config): Close the config file once
	it is read.

Per Cederqvist's avatar
Per Cederqvist committed
457
458
459
460
461
462
463
464
465
466
467
1999-04-19  Per Cederqvist  <ceder@gratia>

	New parameter: "Client host".
	* doc/lyskomd.texi (Parameters): Documented "Client host".
	* src/server/server-config.c (parameters): New parameter: "Client
	host".
	* src/server/ramkomd.c (server_init): New argument: host.  Bind
	the specified IP number.
	(initialize): Pass param.ip_client_host to server_init.
	* src/server/param.h (struct kom_par): Added ip_client_host.

468
469
470
471
472
473
1999-04-19  Per Cederqvist  <ceder@lysator.liu.se>

	Test the "% No connections left." message.
	* src/server/testsuite/lyskomd.0/07.exp: Test what happens when
	too many clients try to connect at the same time.

Per Cederqvist's avatar
Per Cederqvist committed
474
475
476
477
478
479
480
1999-04-18  Per Cederqvist  <ceder@lysator.liu.se>

	More documentation.
	* doc/lyskomd.texi (Parameters): Documented "lyskomd path",
	"savecore path", "Normal shutdown time", "Mail after downtime" and
	"Mail until downtime".
	* doc/Protocol-A.texi (Protocol Version History): Call
Per Cederqvist's avatar
Per Cederqvist committed
481
	102=set-membership-type was omitted, and later calls were
Per Cederqvist's avatar
Per Cederqvist committed
482
483
484
	misnumbered.
	(map-created-texts): Documented.

485
486
487
488
489
490
491
492
493
494
495
1999-04-18  Per Cederqvist  <ceder@gratia>

	Removed the last hardcoded configuration from updateLysKOM.
	* src/server/updateLysKOM.c (savecore): Use param.core_dir and
	param.savecore_path instead of hardcoding the values.
	* src/server/server-config.c (parameters): New parameter:
	"savecore path".
	(read_configuration): Handle param.savecore_path.
	* src/server/param.h (struct kom_par): New parameter:
	savecore_path.

496
497
1999-04-17  Per Cederqvist  <ceder@lysator.liu.se>

498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
	updateLysKOM now reads the configuration file.
	* src/server/updateLysKOM.c (usage): New function.
	(checkstatus): Use parameters "Normal shutdown time", "Mail after
	downtime" and "Mail until downtime" instead of
	using hard-coded values.  Use "mail" instead of "Mail" to send the
	mail.
	(main): Read the configuration file.  Use parameters "Pid file",
	"Status file" and "lyskomd path" instead of hard-coded values.
	* src/server/server-config.c (param): Moved here from various
	files.
	(parameters): Added "Normal shutdown time", "Mail after downtime",
	"Mail until downtime" and "lyskomd path".
	(read_configuration): Handle param.lyskomd_path.
	* src/server/ramkomd.c: (param): Moved to server-config.c.
	* src/server/dbck.c (param): Moved to server-config.c.
	* src/server/Makefile.am (READ_CONFIG): New variable.
	(komrunning_SOURCES): Use READ_CONFIG to simplify code.
	(updateLysKOM_SOURCES): Added READ_CONFIG.
	* src/server/param.h (struct kom_par): New parameters:
	lyskomd_path, normal_shutdown_time, downtime_mail_start and
	downtime_mail_end.
	* src/server/server-config.c (parameters): Moved a few entries
	around, so that they fit under the various headings.

	Fixes to komrunning.c.
	* src/server/komrunning.c (param): Moved to server-config.c.
	(create_status): Write the name of the user as the first line of
	the status file.  With luck, that is a valid email address.

527
528
529
530
531
532
533
534
535
	Handle many simultaneous clients.
	* src/server/connections.c (login_request): Don't handle the "% No
	connections left" situation.
	(toploop): Handle ISC_EVENT_LOGIN_UNRELOCATED by returning a "% No
	connections left" message and closing the session, the way
	login_request used to do.
	* src/server/ramkomd.c (initialize): Warn if getrlimit and sysconf
	don't agree on the number of possible open files.

536
537
538
539
540
541
542
1999-04-17  Per Cederqvist  <ceder@gratia>

	Work towards handling more than 250 simultaneous clients.
	* src/server/ramkomd.c (server_init): Use isc configuration 1006
	and isc session configuration 1002.  Fill in fd_relocate with
	PROTECTED_FDS.

543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
1999-04-17  Per Cederqvist  <ceder@lysator.liu.se>

	Re-implement komrunning in C.
	* src/server/standalone.c (register_jubel): Dummy implementation.
	* src/server/dbck.c (register_jubel): Moved to standalone.c.
	* src/server/dbck-cache.c (kom_info): Moved to standalone.c.
	* src/server/komrunning.c: New file; a reimplementation of
	komrunning.sh in C.
	* src/server/Makefile.am (bin_PROGRAMS): Added komrunning.
	(komrunning_SOURCES): New variable, which among other files
	includes komrunning.c.
	(updateLysKOM_SOURCES): Added pidfile.c.
	(dbck_SOURCES): Added standalone.c.
	* run-support/komrunning.sh: Removed.
	* run-support/Makefile.am (komrunning): Target removed.
	(bin_SCRIPTS): Removed komrunning.
	(EXTRA_DIST): Removed komrunning.sh.
	(MOSTLYCLEANFILES): Removed komrunning.

	Introduce the "Status file" parameter.
	* src/server/server-config.c (parameters): Added "Status file".
	(read_configuration): Handle param.status_file.
	* src/server/param.h (struct kom_par): Added status_file.
	* doc/lyskomd.texi (Parameters): Documented "Status file".

	Move pid file reading to pidfile.c.
	* src/server/updateLysKOM.c (main): Use pidfile to simplify code.
	* src/server/pidfile.h (read_pid_file): New function.
	* src/server/pidfile.c (read_pid_file): New function.

Per Cederqvist's avatar
Per Cederqvist committed
573
574
1999-04-15  Per Cederqvist  <ceder@lysator.liu.se>

Per Cederqvist's avatar
Per Cederqvist committed
575
576
577
578
579
580
581
	Document 103=local-to-global.
	* doc/Protocol-A.texi (accept-async): Added the error code
	long-array.
	(add-member): Added a comment.
	(local-to-global): Documented.
	(The User Area): Register WWW-kom.

Per Cederqvist's avatar
Per Cederqvist committed
582
583
584
	Test suite improvement.
	* src/server/testsuite/lyskomd.0/03.exp: Test calls 103 and 104.

585
586
587
588
589
1999-04-06  Per Cederqvist  <ceder@gratia>

	Yesterdays changes were incomplete.
	* src/server/ramkomd.c: Include local-to-global.h.

590
591
592
593
594
1999-04-05  Per Cederqvist  <ceder@panic.signum.se>

	Explain the Text-Mapping data type.
	* doc/Protocol-A.texi (LysKOM Data Types): Explain Text-Mapping.

595
596
1999-04-05  Per Cederqvist  <ceder@gratia>

597
598
599
600
601
602
603
604
	Change the external file format of a Local_to_global.
	* src/server/testsuite/l2g.0/09.exp: Adjusted to new external
	format of Local_to_global.
	* db-crypt/db/lyskomd-data: Adapted to new format of
	Local_to_global objects.
	* src/server/local-to-global.c (l2g_read): New file format.
	(put_ulong): New static function.
	(l2g_write): New file format.
Per Cederqvist's avatar
Per Cederqvist committed
605
606
	* src/server/testsuite/l2g.0/11.exp: Added lots of test cases for
	l2g_write.
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676

	Added statistics to Local_to_global.
	* src/server/ramkomd.c (dump_exit_statistics): Call dump_l2g_stats.
	* src/server/local-to-global.h: Comments added and improved.
	(dump_l2g_stats): New function.
	* src/server/local-to-global.c (nr_constructs): New static
	variable, used to gather statistics.  Changed all functions to set
	it where appropriate.
	(nr_l2gs): Likewise.
	(nr_l2gs_peak): Likewise.
	(nr_destructs): Likewise.
	(nr_clears): Likewise.
	(nr_copies): Likewise.
	(nr_joins): Likewise.
	(nr_joined_blocks): Likewise.
	(nr_blocks): Likewise.
	(nr_blocks_peak): Likewise.
	(nr_blocks_sparse): Likewise.
	(nr_blocks_sparse_peak): Likewise.
	(sparse_skip_cost): Likewise.
	(nr_sparse_compactions): Likewise.
	(nr_sparsifications): Likewise.
	(l2g_destruct): Actually fill the destructed object with garbage
	data, unless NDEBUG is defined.
	(dump_l2g_stats): New function.

	Make a lot of functions in ram-output.c static.  Increase const
	awareness.
	* src/server/ram-output.c (foutput_person_0): Added const
	qualifier to the person argument.
	(foutput_person_2): Likewise.
	(foutput_person): Likewise.
	(foutput_conference_2): Added const qualifier to the conf_c
	argument.
	(foutput_aux_flags): Now static.
	(foutput_aux_item): Now static.
	(foutput_aux_item_list): Now static.  Added const qualifier to the
	aux argument.
	(foutput_membership_type): Now static.
	(foutput_string): Now static.
	(foutput_priv_bits): Now static.
	(foutput_personal_flags): Now static.
	(foutput_text_list): Now static.
	(foutput_mark_list): Added const qualifier to the mark_list
	argument.
	(foutput_mark): Now static.
	(foutput_membership_list): Now static.
	(foutput_time): Now static.
	(foutput_member_list): Now static.
	(foutput_member): Now static.
	(foutput_conf_type): Now static.
	(foutput_misc_info): Now static.
	(foutput_ulong): Now static.
	* src/server/ram-output.h: Track changes in ram-output.c.
	* src/include/kom-types.h (Text_mapping): The l2g pointer is
	const.

	Some minor improvements to memory handling.
	* src/server/memory.c (free_conference): Call l2g_destruct.
	(free_person): Likewise.
	* src/server/conference.c (do_delete_conf): Don't call l2g_clear,
	since cache_delete_conf will do so.

	Remove useless compiler warnings.
	* configure.in: Don't use -Wtraditional and -Wnested-externs.

	Test suite improvement.
	* src/server/testsuite/config/unix.exp (lyskomd_death): Collect
	etc/memory-usage in usage.all.

677
678
679
680
681
682
683
	Test suite fix.
	* src/server/testsuite/config/unix.exp (lyskomd_start): The
	detection of a server compiled with --with-debug-calls was
	broken.

	Test Local_to_global even more.
	* src/server/testsuite/l2g.0/11.exp: Increase coverage even
684
	further.  Test l2g_clear.
685
686
687
	* src/server/local-to-global.h: Comments improved.
	* src/server/local-to-global.c: Comments improved.

688
689
690
691
692
693
694
695
696
697
698
699
700
701
1999-04-05  Per Cederqvist  <ceder@panic.signum.se>

	Added range-begin and range-end to Text-Mapping.
	* doc/Protocol-A.texi (LysKOM Data Types): Added range-begin and
	range-end to Text-Mapping.
	* src/server/prot-a-output.c (prot_a_output_text_mapping): Emit
	range-begin and range-end.
	* src/server/person.c (map_created_texts): Set result->first to
	the first text number that the user requested.  Don't move it
	forward if the text has been deleted.
	* src/server/text.c (local_to_global): Likewise.
	* src/server/testsuite/lyskomd.0/00.exp: Expect range-begin and
	range-end in Text-Mappings.

Per Cederqvist's avatar
Per Cederqvist committed
702
703
1999-04-04  Per Cederqvist  <ceder@panic.signum.se>

704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
	Merge everything from prot-A.txt into Protocol-A.texi and remove
	prot-A.txt.
	* doc/prot-A.txt: Removed.  Everything in it should now be present
	in Protocol-A.texi.
	* doc/Makefile.am (EXTRA_DIST): Removed prot-A.txt.
	* doc/Protocol-A.texi: Removed all up, next and prev pointers.
	Makeinfo can figure them out automatically.  Fixed proper nesting
	of nodes, and use @Top, so that this work.  Merge everything in
	prot-A.txt into this document:
	(Document Revision History): This is going to be revision 10.0
	which documents protocol version 10.  9.0 was distributed with
	lyskomd 1.9.0.  8.0 was distributed with lyskomd 1.8.0.
	(Protocol Version History): New name for former "Protocol Revision
	History".  Updated the information about version 9.
	(Protocol Design Principles): Node removed.  The "Client-Server
	Dialog" node contains the same information.
	(Client-Server Dialog): Specify the LysKOM port in the example.
	(Simple Data Types): Moved the text about data element separator
	and call terminator to "Client-Server Dialog".
	(user-active): Talk more about when clients should send this.
	(who-is-on-dynamic): Improved the explanation.
	(get-static-session-info): State that the returned information is
	immutable.

Per Cederqvist's avatar
Per Cederqvist committed
728
729
730
	Distribute sigflags.h.
	* src/server/Makefile.am (lyskomd_SOURCES): Added sigflags.h.

731
732
1999-04-03  Per Cederqvist  <ceder@lysator.liu.se>

733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
	Renam do_sync_db to do_statistics.  Use sig_atomic_t instead of
	Bool for variables set from signal handlers.
	* src/server/sigflags.h: New file, containing sig_atomic_t flags.
	* src/server/ramkomd.c: Include "sigflags.h".
	(sighandler_hup): Use 1 instead of TRUE as
	value of go_and_die.
	(sighandler_usr1): Use 1 instead of TRUE as value of
	do_statistics.  Use do_statistics instead of do_sync_db.
	* src/server/connections.h (go_and_die): Declaration moved to
	sigflags.h.
	(do_sync_db): Renamed to do_statistics and moved to sigflags.h.
	* src/server/connections.c (go_and_die): Now sig_atomic_t instead
	of Bool.
	(do_statistics): New name for former do_sync_db.  New type:
	sig_atomic_t instead of Bool.  All users of do_sync_db updated.
	(toploop): Don't call cache_sync when do_statistics is set.
	* src/server/admin.c (shutdown_kom): Set go_and_die to 1, not TRUE.

	Cosmetic code cleanup.
	* src/server/prot-a-parse-arg-c.awk: Insert a blank line between
	the system includes and the local includes.

	Remove the empty function cache_sync.  Rename cache_sync in dbck
	to cache_sync_all.
	* src/server/simple-cache.c (cache_sync): Removed.
	* src/server/logII.c (log): Call cache_sync_all instead
	of cache_sync.
	* src/server/dbck.c (garb_text_file): Call cache_sync_all instead
	of cache_sync.
	(main): Likewise.
	* src/server/dbck-cache.c (cache_sync_all): New name for former
	cache_sync.
	* src/server/cache.h (cache_sync): Function removed.

	Distribution cleanup.
	* src/server/Makefile.am (EXTRA_DIST): Don't distribute logII.c.
	* configure.in: Create src/libraries/regex/doc/Makefile and
	src/libraries/regex/test/Makefile.

	Documentation fixes.
	* doc/lyskomdb.texi (Version 0): next-free-num and next-text-num
	are one greater than the number of existing records.
	(Version 1): The same error probably exists here.  Added comment
	about it.
	* doc/lyskomd.texi (Server Configuration File): Markup fixes.
	(Parameter Types): Markup fixes.
	(Parameters): Markup fixes.
	(Aux-Item Definition File): Markup fixes.
	(Administration): Update the discussion about updateLysKOM, dbck
	and komrunning.  Markup fixes.

	Make all man pages obsolete.  Generate the version number in
	lyskomd.texi automatically.  Make sure that lyskomd.texi and
	dbck.texi includes everyting that was documented in the man pages.
787
788
789
790
	* mkmi: Remove scripts/mdate-sh, which should be generated by
	automake.
	* doc/man/dbck.8: All documentation removed.  Refer to
	dbck.info.
791
792
793
	* doc/man/lyskom.5: Documentation removed.  Refer to lyskomdb.info.
	* doc/man/updateLysKOM.8: All documentation removed.  Refer to
	lyskomd.info.
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
	* doc/dbck.texi (Invoking dbck): Mention that dbck with no
	argument will examine the database without modifying it.
	(General Options): Document -h (aka --help).
	(Format Conversion Options): Minor layout fix.
	(Notes): Typos fixed.
	(Files): Markup fixes.
	* doc/Makefile.am: Break long lines.
	* doc/man/lyskomd.8: All documentation removed.  Refer to
	lyskomd.info.
	* doc/lyskomd.texi: Include version.texi and use @value{VERSION}
	instead of hard-coding the value.
	(Overview): Add Peter Eriksson to the list of signficant
	contributors.  ISC was a piece of very important "enabling
	technology".
	(Parameter Types): Mention that all files are absolute if the
	begin with '/'.
	(Parameters): Use @var{} instead of @i{}.  Markup fixes and other
	minor typo fixes.  The "Log statistics" path is used when the
	server receives a SIGUSR1 signal -- not a SIGHUP!
	(Aux-Item Definition File): The file name was wrong.  Don't use
	@i{}.  Document the "server" keyword.  Mention that permanent
	aux-items will be deleted when the object they belong to are
	deleted.
	(Signals): Removed a note about SIGUSR2 not working on Suns.  It
	should work fine there as well.
	(Files): Don't use @i{}.
	(Bugs): There is no detectable memory leak worth noting.

822
823
824
825
826
827
828
829
830
831
832
833
1999-04-03  Per Cederqvist  <ceder@gratia>

	The test cases shouldn't fail just because --with-debug-calls
	wasn't enabled.
	* src/server/ramkomd.c (main): Emit a warning message when
	--with-debug-calls is enabled.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Look for
	the warning message about --with-debug-calls, and set debug_calls
	to a true value if it is found.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Don't attempt to
	use debug calls unless debug_calls is true.

834
835
1999-04-02  Per Cederqvist  <ceder@panic.signum.se>

Per Cederqvist's avatar
Per Cederqvist committed
836
837
838
839
	Fix "make clean".
	* src/server/testsuite/Makefile.am (mostlyclean-local): Remove db
	and etc.

840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
	Use automake defaults for the Lex and Yacc files, so that the
	distribution works.
	* src/server/Makefile.am (YFLAGS): Set it to "-d" so that we get
	the .h header file.
	(EXTRA_DIST): Removed aux-item-def.l and aux-item-def.y.
	(MAINTAINERCLEANFILES): Removed aux-item-def.tab.h.
	(lyskomd_SOURCES): Added aux-item-def-parse.y,
	aux-item-def-parse.h and aux-item-def-scan.l.
	(DISKOBJS): Removed aux-item-def.tab.c and aux-item-def.lex.c.
	(aux-item-def.tab.c): Target removed.  Rely on automake.
	(aux-item-def.lex.c): Target removed.  Rely on automake.
	* src/server/aux-item-def-parse.y: Rename hack added.  Don't
	redefine yyin and yylineno, since the Lex file no longer uses
	"%option prefix".  Remove blank lines at end of file.
	* src/server/aux-item-def-scan.l: Rename hack added.  Include
	aux-item-def-parse.h instead of aux-item-def.tab.h.  Don't
	redefine yylval and yyerror, and don't use "%option prefix" -- this
	change makes it impossible to have multiple Lex scanners, but on
	the other hand, it makes it possible to use automake.
	* src/server/aux-item-def.l: Renamed aux-item-def-scan.l.
	* src/server/aux-item-def.y: Renamed aux-item-def-parse.y.

862
863
864
865
866
867
868
869
870
	Added some missing files to the distribution.
	* doc/Makefile.am (EXTRA_DIST): Added IDEAS.
	* src/include/Makefile.am (noinst_HEADERS): Added kom-config.h.
	* src/server/Makefile.am (EXTRA_DIST): Added prot-a-is-legal-fnc.awk.
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
	renumber.el, l2g.0/*.exp, lyskomd.0/*.exp,
	lyskomd.0/summarize.sh,	lyskomd.0/aux-items.conf,
	lyskomd.0/aux-items.cov and lyskomd.0/aux-items.leaks.

871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
1999-04-02  Per Cederqvist  <ceder@gratia>

	Make it possible to run "make check" even when not building in
	srcdir.
	* src/server/testsuite/config/unix.exp: (lyskomd_start): Run the
 	test suite in the build directory.  Look for files relative to
 	$srcdir or top_srcdir so that they are found properly.
	(aux_item_default_conf_file): Use $top_srcdir to get a full path.
	* src/server/testsuite/config/leaks.exp: Look for exp files in
	$srcdir.
	* src/server/testsuite/lyskomd.0/04.exp: Likewise.
	* src/server/testsuite/lyskomd.0/05.exp: Likewise.
	* src/server/testsuite/lyskomd.0/06.exp: Likewise.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks00.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks01.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks02.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks03.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks04.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks05.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks06.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks07.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks08.exp: Likewise.
	* src/server/testsuite/lyskomd.0/leaks99.exp: Likewise.

	Fix broken tests.
	* src/server/testsuite/lyskomd.0/01.exp: The test could fail due
	to bad timing.  Fixed.

	Makefile fixes.
	* src/server/testsuite/config/Makefile.am (EXTRA_DIST): Added
	leaks.exp.
	(MOSTLYCLEANFILES): Added lyskomd-config.

906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
1999-03-31  Per Cederqvist  <ceder@gratia>

	Fix bugs in "make dist".
	* doc/Makefile.am (EXTRA_DIST): Removed Makefile.src.

	Dead code removal.
	* src/server/local-to-global.c (find_block_index_key): Blocks can
	never be completely empty.  Code simplified accordingly.
	(l2g_append): Likewise.
	(l2gi_next): Likewise.
	* src/server/ram-parse.c (fparse_info_2): Unreachable code removed.

	Increase coverage of local-to-global.c.
	* src/server/testsuite/l2g.0/11.exp: New file.

Per Cederqvist's avatar
Per Cederqvist committed
921
922
923
924
925
1999-03-28  Per Cederqvist  <ceder@link>

	* TODO: Updated according to priorization made by me and David
	Byers.

David Byers's avatar
David Byers committed
926
927
928
929
930
931
932
933
934
935
1999-03-28  David Byers  <davby@ida.liu.se>

	* src/server/simple-cache.c (cached_conf_exists): Test existance
	in small_conf_arr. Don't go to disk.
	(cached_delete_conf): Free the associated small_conf_stat and set
	small_conf_arr[x] to NULL.

	* run-support/aux-items.conf: Restrict creation of mx-author to
	creation time.

936
937
938
939
1999-02-06  Per Cederqvist  <ceder@gratia>

	* configure.in: Fixed a syntax error introduced yesterday.

940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
1999-02-05  Per Cederqvist  <ceder@gratia>

	Don't produce meaningless warnings.
	* configure.in: Remove -Wshadow and -Wcast-qual since they give
	too many false warnings and are of limited use.

	Get rid of some warnings.
	* src/include/kom-types.h (Version_info_internal): const
	qualifiers added.
	* src/server/Makefile.am (version-info.c): Added const qualifier
	to kom_version_info.
	* src/server/version-info.h (kom_version_info): Added const
	qualifier.

	Don't use the wrong member of a union.
	* src/server/prot-a.c (prot_a_reply): Emit
	res->membership_list_old, not res->membership_list, when the
	return type is rt_membership_list_old.

	Remove the L2g_iterator_as_text_list typedef.
	* src/server/text.c (get_map): Use L2g_iterator
 	instead of L2g_iterator_as_text_list.
	* src/server/prot-a-output.h, src/server/prot-a-output.c
 	(prot_a_output_l2g_iterator_as_text_list): Use L2g_iterator
 	instead of L2g_iterator_as_text_list.
	* src/server/person.c (get_created_texts): Use L2g_iterator
	instead of L2g_iterator_as_text_list.
	* src/server/connections.h (Result_holder): The
	l2g_iterator_as_text_list member is now of type L2g_iterator
	instead of the typedef L2g_iterator_as_text_list.
	* src/include/services.h (get_created_texts): Use L2g_iterator
	instead of L2g_iterator_as_text_list.
	(get_map): Likewise.
	* src/include/kom-types.h (L2g_iterator_as_text_list): Typedef
	removed.

David Byers's avatar
David Byers committed
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1999-02-02  David Byers  <davby@ida.liu.se>

	* src/server/aux-items.h (Aux_item_validation_data): New type.
	(Aux_item_validation_function): New type.
	(Aux_item_validator): New type.

1999-01-28  David Byers  <davby@ida.liu.se>

	* src/server/prot-a-parse.c (prot_a_parse_aux_item_list): Check
	array size for -1. Check allocation of result.

	* src/server/person.c (mark_text): Return no-such-text if the user 
	is not allowed to read the text (just like get-text-stat)
	(set_user_area): Return UNDEF_PERS, not UNDEF_CONF.

	* src/include/kom-errno.h (enum kom_errno): Define
	KOM_PERS_EXISTS.

	* src/server/person.c (create_person_generic): Return
	KOM_PERS_EXISTS instead of KOM_CONF_EXISTS

1999-01-27  David Byers  <davby@ida.liu.se>

	* src/server/conference.c (do_create_conf): Don't just DIE if we
	fail to create a conference. Log a message and return an error.
For faster browsing, not all history is shown. View entire blame