ChangeLog 328 KB
Newer Older
1 2
2002-10-23  Per Cederqvist  <ceder@ceder.dyndns.org>

3 4 5 6 7 8 9 10 11 12 13 14
	Plugged a memory leak.  (Bug 816).
	* src/server/prot-a.c (prot_a_destruct): Clear dummy_aux_item, to
	plug a memory leak.  To trigger this leak, you had to send an
	oversized aux-item-list, that contained an oversized string in the
	last part of the oversized array, and disconnect while sending the
	last part of the string.

	Test client disconnect more thoroughly.  (Bug 63).
	* src/server/testsuite/lyskomd.0/29.exp: Several more test cases
	added.  We now trigger bug 816.
	(startup): Reduce "Max aux_item length" and "Max links per text".

Per Cederqvist's avatar
Per Cederqvist committed
15 16 17 18 19 20 21
	Test suite fixes.
	* src/server/testsuite/lyskomd.0/03.exp: Wait for a third tick.
	This test failed on computers that were too fast, due to the
	script waiting too short a time.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Added a
	missing dot that caused --with-debug-calls tests to fail.

22 23 24 25 26 27
	Clients should offer to add the letterbox of the author if he
	isn't a member of any of the recipients.
	* doc/Protocol-A.texi (Recipients of comments): Added a
	description of what to do when the author of a new comment isn't a
	member of any of the recipients.

28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104
	Added option "-f" (stay in foreground) to lyskomd.  "-d" no longer
	implies "stay in foreground".
	* src/server/ramkomd.c (foreground): New static variable.
	(go_daemon): Stay in foreground if given -f, not -d.
	(initialize): Prompt the operator for confirmation when given -f,
	not -d.
	(main): Ditto.  Handle -f: stay in foreground.
	* doc/lyskomd.texi (Invoking lyskomd): Documented the new -f
	option.

	Let the test suite check all output from lyskomd.
	* src/server/testsuite/config/unix.exp (maxint): Unused constant
	removed.
	(lyskomd_expect): New proc.
	(spawn_lyskomd): Use -f, not -d.
	(lyskomd_start): Check all output from lyskomd.
	(lyskomd_fail_start): Ditto.
	(lyskomd_death): New argument: reason. Check all output from
	lyskomd.
	(talk_to): Set current_talk_what and current_talk_nr, so that
	lyskomd_expect can restore the old settings.  Set proper
	line_leader for lyskomd.
	* src/server/testsuite/lyskomd.0/03.exp: Check all output from
	lyskomd.
	* src/server/testsuite/lyskomd.0/05.exp: Ditto.
	* src/server/testsuite/lyskomd.0/06.exp: Ditto.
	* src/server/testsuite/lyskomd.0/24.exp: Ditto.
	* src/server/testsuite/lyskomd.0/25.exp: Ditto.
	* src/server/testsuite/lyskomd.0/27.exp: Ditto.
	* src/server/testsuite/lyskomd.0/admin-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-349.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-612.exp: Ditto.
	* src/server/testsuite/lyskomd.0/conf-file-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/conference-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/connections-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/gen-15.py: Ditto.
	* src/server/testsuite/lyskomd.0/gen-19.py: Ditto.
	* src/server/testsuite/lyskomd.0/membership-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/person-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/session-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/text-cov.exp: Ditto.
	* src/server/testsuite/lyskomd.0/11.exp: Use the -f argument of
	lyskomd, not -d.  Pass the reason argument to lyskomd_death.
	* src/server/testsuite/lyskomd.0/07.exp: Pass the reason argument
	to lyskomd_death.

	Test suite cleanup.
	* src/server/testsuite/lyskomd.0/29.exp: Removed spurious newline
	from the log file.

	Fixed a race condition in the test suite.  (Bug 692).
	* src/server/testsuite/lyskomd.0/18.exp: Check all output from
	lyskomd.  Closes bug 692.
	* src/server/ramkomd.c (sighandler_winch): Moved log message to
	toploop().
	* src/server/connections.c (toploop): Log a message when SIGWINCH
	has been processed and the aux definitions reloaded.

	Fixed a false log message about a memory leak. (Half of Bug 816).
	* src/server/prot-a.c (prot_a_destruct): Set c_local_text_no_p to
	NULL after freeing it, to avoid logging "kill_client(): unexpected
	local_text_no remains." when a client disconnects while sending a
	c_local_text_no_p array.

	Clean up the output from lyskomd.
	* src/server/conf-file.c (configure_line): Don't add blank lines
	to the log.
	* src/server/aux-items.c (aux_item_validate): Added a trailing dot
	to a log message.
	* src/server/aux-item-def-parse.y: Fixed typo in a log message.

105 106
2002-10-21  Per Cederqvist  <ceder@ceder.dyndns.org>

107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124
	Don't crash if a client sends the length of an aux-item list and
	disconnects before sending the "{".  Fixed similar code for other
	arrays.
	* src/server/prot-a-parse.c (prot_a_parse_num_list): Don't set
	res->length until res->data is allocated.
	(prot_a_parse_misc_info_list): Ditto.
	(prot_a_parse_aux_item_list): Ditto.  Without this fix, a client
	can cause a crash by sending the length of the list, and
	disconnect before sending the "{".
	(prot_a_parse_string): Add an additional comment explaining why a
	client_len field should be added (bug 162).

	Fix testsuite.
	* src/server/testsuite/lyskomd.0/29.exp: Expect bug 836:
	mark-text-as-read gives a protocol error response instead of the
	error code long-array when an overly long array is sent to the
	server.

125 126 127 128 129 130 131 132 133 134 135 136 137 138
	"make clean; make check" failed.
	* src/server/Makefile.am: Added explicit dependencies so that
	"make clean; make check" no longer fails.

	Added missing semicolon i bison file.
	* src/server/aux-item-def-parse.y (action): Inserted a missing
	semicolon.

	Fixed a testsuite bug.
	* src/server/testsuite/lyskomd.0/prot-a-send-async-cov.exp: Use
	client_death instead of kill_client after receiving the "%% No
	connections left" message.
	* src/server/testsuite/lyskomd.0/send-async-cov.exp: Ditto.

139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157
2002-10-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Test client disconnect while while the client has sent partial
	requests.
	* src/server/testsuite/lyskomd.0/29.exp: New file: test for client
	disconnect.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	29.exp.

	Testsuite: check for unexpected data sent to clients immediately
	before they are killed.
	* src/server/testsuite/config/unix.exp (kill_client): Look for
	stray output before killing the client.
 
	Testsuite framework: make it possible to send incomplete lines to
	the server.
	* src/server/testsuite/tcpconnect.py: Added support for sending
	incomplete lines to the server via the "#nocr" instruction.

Per Cederqvist's avatar
Per Cederqvist committed
158 159 160 161 162 163
2002-10-18  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor doc improvement.
	* doc/Protocol-A.texi (Auxiliary Information): Added a reference
	to Aux-Item Types.

164 165 166 167 168 169 170
2002-10-17  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fixed a broken lookup-z-name example.
	* doc/Protocol-A.texi (lookup-z-name): "T C" doesn't match "Trains
	(-) Discussion", so remove it from the result.  Reported by Hans
	Persson.

Per Cederqvist's avatar
Per Cederqvist committed
171 172 173 174 175 176
2002-10-16  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fixed a typo.
	* doc/Protocol-A.texi (Membership Information): Fixed typo:
	"added-by", not "added-byp".

177 178 179 180 181 182
2002-10-15  Per Cederqvist  <ceder@ceder.dyndns.org>

	Better logging of leaks during client disconnect.
	* src/server/internal-connections.c (kill_client): Log left-overs
	from misc_info_list and local_text_no separately.

Per Cederqvist's avatar
Per Cederqvist committed
183 184 185 186 187 188 189 190
2002-10-14  Per Cederqvist  <ceder@ceder.dyndns.org>

	Port testfd.c to SunOS 5.4.
	* src/server/testsuite/testfd.c (find_limits): The code failed to
	compile unless HAVE_GETDTABLESIZE.  Flush stdout before writing
	something to stderr.
	(main): Flush stdout before writing something to stderr.

191 192 193 194 195 196 197
2002-10-13  Per Cederqvist  <ceder@ceder.dyndns.org>

	Gather more info about file descriptor usage.
	* src/server/testsuite/testfd.c: Lower the limit using setrlimit
	and test the limits afterwards as well.  Report an error if the
	assumptions made by lyskomd do not hold.

198 199
2002-10-12  Per Cederqvist  <ceder@ceder.dyndns.org>

200 201 202 203 204 205 206 207 208 209
	File descriptor counting on AIX is apparently wrong.  Collect some
	information from the farm.
	* scripts/xenofarm.sh: Run check-testfd as a separate task, so
	that the info can be easily collected.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added testfd.
	(testfd_SOURCES): New variable.
	(check): Added check-testfd.
	(check-testfd): New target.
	* src/server/testsuite/testfd.c: New test program.

210 211 212 213 214 215 216 217
	Handle a failure mode that seems to occur.
	* src/server/testsuite/lyskomd.0/11.exp: Handle one case of early
	lyskomd death.

	Improve testsuite lock handling.
	* src/server/testsuite/locksuite.py (try_symlink): Break stale
	lock files.

218 219 220 221 222 223 224
2002-10-11  Per Cederqvist  <ceder@ceder.dyndns.org>

	Removed obsolete Xenofarm compatibility cruft.
	* scripts/xenofarm.sh: Removed old Xenofarm compatibility stuff,
	including the --compat argument and the ability to give the
	compiler to use as an argument.  Added the --make argument.

225 226 227 228 229 230 231 232 233 234 235 236 237 238
2002-10-09  Per Cederqvist  <ceder@ceder.dyndns.org>

	Use AM_CPPFLAGS instead of the obsolete variable INCLUDES.
	* src/server/testsuite/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.
	* src/server/Makefile.am: (AM_CPPFLAGS): New name for former
	INCLUDES.
	* src/libraries/libmisc/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.
	* src/libraries/libcommon/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.
	* src/libraries/libansi/Makefile.am (AM_CPPFLAGS): New name for
	former INCLUDES.

239 240 241 242 243 244 245
2002-10-07  Per Cederqvist  <ceder@ceder.dyndns.org>

	Xenofarm builds could get stuck forever on a stale lock file.
	* src/server/testsuite/config/unix.exp (obtain_lock): This failed
	to break stale locks if the host name contained for instance a
	dot.  So this failed if a FQDN name is used.

Per Cederqvist's avatar
Per Cederqvist committed
246 247 248 249 250 251
2002-10-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix the doc fix.
	* doc/lyskomd.texi (Template for ram-parse.c): Break a too long
	line.

Per Cederqvist's avatar
Per Cederqvist committed
252 253 254 255 256 257 258
2002-10-06  Daniel Andersson <daniel@ds.hj.se>

        Doc fix. (Bug 814).
	* doc/lyskomd.texi (Template for ram-output.c): Corrections to
	function names etc.
	(Template for ram-parse.c): Ditto.

259 260
2002-10-06  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
261 262 263 264 265
	Xenofarm cleanup.
	* scripts/xenofarm.sh: Removed special cases for aristocat,
	moghedien and lysator.  Path setup et c is better handled in the
	configuration files of the corresponding computer.

266 267 268 269 270 271
	Fix configure tests for <sys/resource.h> and rlim_t.
	* configure.in: When checking for rlim_t in <sys/resource.h>, and
	when checking for <sys/resource.h> itself, include <time.h> and
	<sys/time.h> in the proper way.  Both these tests were made too
	early.

272 273
2002-10-05  Per Cederqvist  <ceder@ceder.dyndns.org>

274 275 276 277 278
	Update Xenofarm configuration of asmodean and moghedien.
	* scripts/xenofarm.sh: asmodean is no longer used by Xenofarm.
	moghedien needs runtest, but not a special makeinfo.  Also, 
	"uname -n" doesn't return a FQDN there.

279 280 281 282 283 284 285 286 287 288 289
	Send a broadcast message when the server fails to save the
	database.  (Bug 813).
	* src/server/simple-cache.c (sync_part): Send a broadcast message
	to everyone if the save failed.  Patch from Daniel Andersson,
	slightly edited.

	Get rid of some compiler warnings about conversions between char
	and unsigned char.
	* src/include/kom-config.h, src/server/server-config.c
	(WHITESPACE): Changed type from const unsigned char* to const
	char* to remove some compiler warnings.
290 291 292 293 294 295 296 297
	* src/libraries/libmisc/s-string.h,
	src/libraries/libmisc/s-string.c (s_usr_strcmp): Changed type of
	collat_tab argument from char to unsigned char.
	(s_usr_strhead): Ditto.
	* src/libraries/libcommon/parser.h,
	src/libraries/libcommon/parser.c (match): Changed type of
	collat_tab argument from char to unsigned char.
	(parse): Ditto.
298 299 300 301 302 303 304 305 306 307
	* src/server/regex-match.c (lookup_regexp): Cast the "pattern"
	argument of re_compile_pattern to char* to get rid of a warning.
	(lookup_regexp): Cast the "string" argument of re_search to char*
	to get rid of a warning.
	* src/server/aux-items.c (aux_item_definition_cache_regexp):
	Don't set the translate field of the pattern buffer to
	DEFAULT_COLLAT_TAB.  That causes a warning.  The field is anyhow
	set to NULL on the next line, as it should be.
	(aux_item_validate): Cast the "string" argument of re_search to
	char* to get rid of a warning.
308

309 310
2002-10-04  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
311 312 313 314 315 316
	Xenofarm refinements.
	* scripts/xenofarm.sh: Remove makewarn.txt and ckprgwarn.txt if
	they are empty.  Create ckprgfail.txt and cause the ckprg steg to
	fail if the string "error" is found in the output (case
	insensitive).

317 318 319 320 321
	Change s_free() to s_clear() in comments in s-string.h.
	* src/libraries/libmisc/s-string.h: Two comments mentioned
	s_free(), but the actual name of the function is s_clear().  
	Fixed the comments.

322 323
2002-10-02  Per Cederqvist  <ceder@ingate.com>

324 325 326 327
	Watch for runtest problems.
	* scripts/xenofarm.sh: Added "error" to the list of strings that
	should cause ckprg to flag a warning.

328 329 330 331 332 333
	Remove warnings about unused libraries from the test suite.
	* src/server/testsuite/test-l2g.c (main): Call link_ansi().
	* src/server/testsuite/Makefile.am (test_l2g_LDADD): Removed
	$(LDADD).  Added libmisc.a, liblyskom-server.a and libansi.a.
	(LDADD): Removed.  The bignum program doesn't need any of this,
	and test-l2g only needs parts of it.
334
	(INCLUDES): Added libansi.
335

336 337
2002-10-02  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
338 339 340 341 342 343
	Port to the ecc compiler.
	* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Improve the test, by
	checking that __attribute__((unused)) is accepted in a function
	declaration.  The ecc compiler on Linux/ia64 seems to accept it
	and give a warning when used on a local variable, but chokes on
	it when used in a function declaration.
Per Cederqvist's avatar
Per Cederqvist committed
344 345
	* scripts/xenofarm.sh: Ignore a warning created by
	__attribute__((format)) when compiling with ecc.
Per Cederqvist's avatar
Per Cederqvist committed
346

347 348 349 350
	Get more info from Xenofarm builds.
	* scripts/xenofarm.sh: Retrieve config.log and
	src/libraries/libisc-new/config.log.

Per Cederqvist's avatar
Per Cederqvist committed
351 352 353 354 355
2002-10-01  Per Cederqvist  <ceder@ceder.dyndns.org>

	Doc fix.
	* doc/man/dbck.8: Refer to lyskomd.info, not dbck.info.

Per Cederqvist's avatar
Per Cederqvist committed
356 357 358 359 360
2002-09-28  Per Cederqvist  <ceder@ceder.dyndns.org>

	Xenofarm warning handling.
	* scripts/xenofarm.sh: Fixed a warning regexp.

361 362 363 364 365 366 367 368 369
2002-09-19  Per Cederqvist  <ceder@ceder.dyndns.org>

	Get rid of a warning.  Xenofarm warning handling.
	* src/server/conference.c (do_lookup): Introduce a new variable
	letterflag to get rid of a compiler warning from gcc-2.7.2.2 on
	AIX.
	* scripts/xenofarm.sh: Check for warnings during configure and
	ckprg.  Ignore a few more warnings during make.

370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
2002-09-10  Per Cederqvist  <ceder@ceder.dyndns.org>

	Remove warnings about unused libraries.
	* src/server/updateLysKOM.c (main): Call link_ansi().
	* src/server/splitkomdb.c (main): Call link_ansi().
	* src/server/ramkomd.c (main): Call link_ansi().
	* src/server/komrunning.c (main): Call link_ansi().
	* src/server/dbck.c (main): Call link_ansi().
	* src/server/Makefile.am (INCLUDES): Added libansi.
	(lyskomd_LDADD): New variable.
	(dbck_LDADD): New variable.
	(LDADD): Removed several libraries that the other programs don't
	use.
	* src/libraries/libansi/empty.c (link_ansi): New function.
	(neveruse): Removed.
	* src/libraries/libansi/Makefile.am (libansi_a_SOURCES): Added
	linkansi.h.
	* src/libraries/libansi/linkansi.h: New file.
	(link_ansi): New function.

	Ignore a warning from <vnode.h>.
	* scripts/xenofarm.sh: Ignore a harmless warning from
	/usr/include/sys/vnode.h.

394 395
2002-09-09  Per Cederqvist  <ceder@ingate.com>

396 397 398 399
	Port to SunOS 4.1.1_U1 which lacks rlim_t.
	* configure.in: Check for rlim_t.
	* src/server/ramkomd.c [!HAVE_RLIM_T]: typedef rlim_t to int.

400 401 402 403
	No wonder locksuite.py failed: it wasn't distributed!
	* src/server/testsuite/Makefile.am (EXTRA_DIST): Added
	locksuite.py.  Sorted the lines.

404 405 406 407
	Xenofarm went amok on some computers, where locksuite.py fails.
	* src/server/testsuite/config/unix.exp (obtain_lock): Don't loop
	forever if we get an unexpected eof from locksuite.py.

408 409 410 411 412 413 414 415 416 417 418 419 420 421
2002-09-09  Per Cederqvist  <ceder@ceder.dyndns.org>

	Lock the test suite so that only one run at a time is performed.
	* src/server/testsuite/config/unix.exp (lock_count): New variable.
	(obtain_lock): New proc.
	(release_lock): New proc.
	(l2g_start): Get the lock.
	(l2g_stop): Release it.
	(lyskomd_start): Get the lock.
	(lyskomd_fail_start): Get and release the lock.
	(lyskomd_death): Release it.
	(client_start_fail): Get and release the lock
	* src/server/testsuite/lyskomd.0/11.exp: Release the lock.

Per Cederqvist's avatar
Per Cederqvist committed
422 423
2002-09-08  Per Cederqvist  <ceder@ceder.dyndns.org>

424 425 426 427 428 429
	Prepare for locking the test suite.
	* src/server/testsuite/config/unix.exp (clientport): Comment updated.
	* src/server/testsuite/locksuite.py: New file.  This is a basic
	building block for preventing simultaneous test runs on the same
	computer or in the same directory.

430 431 432 433 434 435
	Get rid of some compiler warnings.
	* src/include/kom-types.h (Info): Change highest_aux_no from long
	to unsigned long, since that is what aux_item_list_add_items()
	wants it to be.
	* configure.in: Check for crypt only if crypt isn't found in libc.

Per Cederqvist's avatar
Per Cederqvist committed
436 437
	More Xenofarm improvements.
	* scripts/xenofarm.sh: Include config.h in the result package.
438 439
	Ignore warnings about duplicate volatile.  These are due to AIX
	apparently including volatile in sig_atomic_t.
Per Cederqvist's avatar
Per Cederqvist committed
440

441 442
2002-09-07  Per Cederqvist  <ceder@ceder.dyndns.org>

443 444 445 446
	Better support for building multiple configurations under Xenofarm.
	* scripts/xenofarm.sh: Implement --cfg option.  Removed special
	setup for moria.

447 448 449
	Tweak types and add a few casts to get rid of several gcc warnings.
	* src/server/splitkomdb.c (copy_file): Changed type of sz from int
	to size_t to get rid of compiler warnings.
450 451
	* src/server/simple-cache.c (init_cache): Replaced "i" with "ic"
	and "it" to get rid of warnings when the wrong type was used.
452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468
	* src/server/ramkomd.c (initialize): Added casts to remove warnings.
	* src/server/ram-parse.c (fparse_aux_item_link): Added cast to
	remove warning.
	* src/server/prot-a.c (prot_a_parse_packet): Added cast to remove
	warning.
	* src/server/local-to-global.h (l2g_set_block_size): Comment
	updated.
	* src/server/local-to-global.c (l2g_append): Added cast to remove
	warning.
	(l2g_expensive_set): Ditto.
	(l2g_expensive_set): Ditto.
	* src/server/dbck.c (motd_of_lyskom): Now a Text_no, not int.
	(main): Use atol, not atoi, when setting motd_of_lyskom.
	* src/server/dbck-cache.c (next_free_num): Change type to
	Conf_no.  Added static qualifier.
	(cache_sync_all): Replaced the local variable "i" with "ic" and
	"it", for loops over conferences and texts.
469
	(init_cache): Changed type of "i" to unsigned long.  Changed type of
470 471 472 473 474 475 476 477 478
	motd_of_lyskom to Text_no.
	* src/server/connections.h, src/server/connections.c
	(num_fnc_defs): Change type to int.

	Make Xenofarm ignore a few warnings in code that we didn't write.
	* scripts/xenofarm.sh: Ignore warnings from aux-item-def-scan.c
	about defined stuff that isn't used.  This is an auto-generated
	file, and we can't help that it includes a few unused labels and
	functions.  Ignore warning from getopt about a function
479 480
	declaration that isn't a prototype.  Ignore cast warnings in
	<bits/socket.h>.
481

Per Cederqvist's avatar
Per Cederqvist committed
482 483 484 485 486 487
2002-09-04  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix bugs in last commit.
	* scripts/xenofarm.sh: More portable handling of "(W)".  
	Process all options, not just the first.

Per Cederqvist's avatar
Per Cederqvist committed
488 489 490 491 492 493
2002-09-03  Per Cederqvist  <ceder@ceder.dyndns.org>

	Xenofarm improves.  Adapt.
	* scripts/xenofarm.sh: Handle the --compat option.  Handle
	compilers that flag warnings with the string "(W)".

494 495 496 497 498
2002-08-25  Per Cederqvist  <ceder@ceder.dyndns.org>

	Create Xenofarm warning indications.
	* scripts/xenofarm.sh: Check for warnings during the build.

Per Cederqvist's avatar
Per Cederqvist committed
499 500 501 502
2002-08-24  Per Cederqvist  <ceder@ceder.dyndns.org>

	* NEWS: Updated.

Per Cederqvist's avatar
Per Cederqvist committed
503 504
2002-08-23  Per Cederqvist  <ceder@ceder.dyndns.org>

505 506 507 508
	Remove false xenofarm failures.
	* scripts/xenofarm.sh: Run without optimization and with an old
	version of gcc, to make valgrind more happy.

Per Cederqvist's avatar
Per Cederqvist committed
509 510 511 512
	Port to Solaris 2.4.
	* src/server/connections.c (login_request): Don't use snprintf.
	It's not portable.

513
2002-08-22  Per Cederqvist  <ceder@ceder.dyndns.org>
514 515 516 517 518 519 520 521 522 523 524 525 526

	Compile with more than one compiler on Xenofarm.
	* scripts/xenofarm.sh: Take an optional argument: the name of the
	compiler to use.  Include it in machineid.txt, and pass it to the
	configure script.

	Solaris 2.4 porting.
	* src/libraries/libmisc/s-collat-tabs.c,
	src/libraries/libmisc/s-collat-tabs.h:
	(swedish_collate_tab, english_collate_tab): Use unsigned char, not
	signed char, to get rid of a warning from SparcWorks 5.1 under
	Solaris 2.4.

527 528 529 530 531 532 533 534
	The info about elisp-client-specific aux-items is informative
	only.  (Bug 726).
	* doc/Protocol-A.texi (Aux-Item Types): Moved
	elisp-client-read-faq [10000] and
	elisp-client-rejected-recommendation [10001] to an appendix.
	(Client-specific Aux-Item Types): New appendix.
	(Document Edition History): Fixed broken @xref usage.
	* doc/Makefile.am (check-doc): Handle the "Client-specific
535
	Aux-Item Types" appendix.
536

Per Cederqvist's avatar
Per Cederqvist committed
537 538 539 540 541 542 543 544
2002-08-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Release administrativa.
	* doc/Protocol-A.texi (Order of misc-info groups): Fix typo.
	(Document Edition History): Updated edition 10.7 according to the
	NEWS file from 2002-08-17.
	* NEWS: "common block", not "common area".

545 546
2002-08-20  Per Cederqvist  <ceder@ingate.com>

547 548 549 550 551 552 553 554 555
	Document how lines in a text are separated.  Document the order of
	misc-info groups.
	* doc/Protocol-A.texi (create-text): Say "Misc-Info items", not
	"misc-items".
	(LysKOM Content Types): There should be no linefeed after the last
	line.
	(Reformattable Text (text/x-kom-basic)): Ditto.
	(Order of misc-info groups): New node.

556 557 558
	The test suite failed on certain slow machines.
	* src/server/testsuite/config/unix.exp: Increase the timeout.

559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579
2002-08-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Code cleanup.
	* src/server/testsuite/config/unix.exp (lyskomd_start): Removed an
	unused global declaration.

	The test suite failed on 64-bit platforms.
	* src/server/testsuite/bignum.c: New program.
	* src/server/testsuite/Makefile.am (check_PROGRAMS): Added bignum.
	(bignum_SOURCES): New variable.
	(check-lyskomd): Depend on bignum.
	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Use bignum
	to find a suitable big number.

	Don't include <sys/time.h> when it isn't available.
	* src/server/connections.c: Fix include guards for <time.h> and
	<sys/time.h>.
	* src/server/ramkomd.c: Ditto.

	Xenofarm tweaks.
	* scripts/xenofarm.sh: Store error message from "import socket" in
Per Cederqvist's avatar
Per Cederqvist committed
580 581
	the proper log file.  Run valgrind on moria.

582

583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
2002-08-19  Per Cederqvist  <ceder@ceder.dyndns.org>

	Increase test suite portability.
	* src/server/testsuite/lyskomd.0/18.exp (copy_aux): Don't use
	"file copy", since that isn't portable to old TCL versions.

	Fixed test suite typos.
	* src/server/testsuite/config/unix.exp (l2g_start): Fixed typo:
	";wait" should not be part of the fail string.
	(lyskomd_fail_start): Ditto.
	(client_start): Ditto.
	(client_start_fail): Ditto.

	Xenofarm refinements.
	* scripts/xenofarm.sh: Don't bother running the tests of python
	cannot import socket.

600 601
2002-08-18  Per Cederqvist  <ceder@ceder.dyndns.org>

602 603 604 605 606 607 608
	Increase test suite portability.
	* src/server/testsuite/lyskomd.0/18.exp (copy_aux): Don't use
	"file delete", since that isn't portable to old TCL versions.

	Make the Xenofarm result pages more readable.
	* scripts/xenofarm.sh: Shorten the header names.

609 610 611
	Break out "dvi" and "pdf" from Xenofarm task "checkdoc".
	* scripts/xenofarm.sh: Make check-doc, pdf and dvi separately,
	instead of using the "make check" target of the doc subdirectory.
612
	Don't attempt to "make pdf" unless we find pdftex.
613 614
	Don't attempt to "make dvi" unless we find texi2dvi and tex.
	
Per Cederqvist's avatar
Per Cederqvist committed
615 616
2002-08-17  Per Cederqvist  <ceder@ceder.dyndns.org>

617 618 619 620 621 622 623 624 625
	Don't require "grep -f" and "tac" to check the documentation.
	* doc/filterlines.py: New file, that we can use instead of the
	non-portable "grep -v -f ...".
	* doc/tac.py: New file, that replaces the "tac" program.
	* doc/Makefile.am (check-doc): Use filterlines.py instead of "grep
	-v -f ...".  Adjust the contents of several temporary files
	accordingly: they now contains lines to ignore, not regexp
	patterns to ignore.  Use tac.py instead of tac; not everybody has
	GNU textutils installed.
626
	(EXTRA_DIST): Added filterlines.py and tac.py.
627 628 629
	* scripts/xenofarm.sh (checkdocok): "grep -f" and tac are no
	longer required to "make check" in the doc subdirectory.

Per Cederqvist's avatar
Per Cederqvist committed
630 631 632 633
	Xenofarm refinements.
	* scripts/xenofarm.sh: Attempt to identify the version of the C
	compiler and the makeinfo program.

634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658
	Flag automatically generated files.
	* src/server/testsuite/lyskomd.0/gen-15.py: Insert a warning in
	the output that the result is automatically generated.
	* src/server/testsuite/lyskomd.0/gen-19.py: Ditto.
	* src/server/Makefile.am (aux.h): Se the mode of this generated
	file to 444, to avoid accidental edits.

	Portability fix.
	* configure.in: Use "test x && test y" instead of "test x -a y",
	since the -a option is less portable than the "&&" construct.

	Update copyright headers.
	* <all files>: update the year in the copyright notice.
	* scripts/lyskomd-copyrights: Updated the list of files to ignore.
	* src/server/testsuite/renumber.el: Copyright header added.

	Xenofarm integration.
	* scripts/xenofarm.sh: New file.  This version was taken from
	revision 1.9 of projects/lyskom-server/source-transform.sh in the
	xenofarm CVS module, and a copyright header and some initial
	comments were added.
	* scripts/Makefile.am (EXTRA_DIST): Added xenofarm.sh.
	* Makefile.am (ident-cc): New target.
	* doc/Makefile.am (ident-makeinfo): New target.

Per Cederqvist's avatar
Per Cederqvist committed
659 660 661 662 663 664
	Release administrativa.
	* HACKING: Mention gpg, the paths of the FTP an WWW servers, a few
	web pages, and Freshmeat.
	* NEWS: Updated for the upcoming 2.0.7 release.  This is only a
	first draft and needs more work.

665 666
2002-08-16  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
667 668 669
	Portability fixes.
	* doc/Makefile.am (check-doc): Use "diff -c" instead of "diff -u"
	for increased portability.
670 671
	* HACKING: Use bison 1.35.  Bison 1.28 produces a file that fails
	on AIX.
Per Cederqvist's avatar
Per Cederqvist committed
672

Per Cederqvist's avatar
Per Cederqvist committed
673 674 675 676
	Fix Texinfo error.
	* doc/Makefile.am (protocol-a.texi): Use '@"a', not '@"a{}', when
	substituting IAM.
	* doc/Protocol-A.texi (IAM): Use '@"a', not '@"a{}'.
Per Cederqvist's avatar
Per Cederqvist committed
677
	* doc/constructs.expected: @"a{} is no longer used.
Per Cederqvist's avatar
Per Cederqvist committed
678

679 680 681
	"make check" / Python 1.5 compatibility fixes.
	* doc/checkargs.py (lexer.__init__): Use string.split for Python
	1.5 compatibility.
682 683 684
	(number_suffixed): Don't use "".startswith.
	(isalpha): New function.  Use it instead of "".isalpha.
	(isdigit): New function.  Use it instead of "".isdigit.
685
	(isupper): New function.  Use it instead of "".isupper.
686 687
	(islower): New function.  Use it instead of "".islower.
	(isspace): New function.  Use it instead of "".isspace.
688 689 690 691
	(prot_a_bitstring.check_implemented): Old Python versions cannot
	loop over a dictionary; add an explicit call to the .keys()
	method.
	(lexer.__init__): Use string.strip instead of "".strip.
692

693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711
	Dump info about existing sessions to a file specified by 
	"Connection status file:".  (Bug 706).
	* src/server/connections.h (Connection): Added the "peer" field.
	* src/server/connections.c (dump_connections): New function.
	(check_kill_flg): Call dump_connections if any connection was
	killed.
	(login_request): Set the "peer" field.
	* src/server/internal-connections.h (dump_connections): New
	function.
	* src/server/internal-connections.c (kill_client): Free the "peer"
	field.
	* src/server/server-config.c (parameters): Added "Connection
	status file" and "Connection status temp file".
	(read_configuration): Handle them.
	* src/server/param.h (struct kom_par): Added
	connection_status_file and connection_status_file_tmp.
	* doc/lyskomd.texi (Parameters): New parameters: "Connection
	status file:" and "Connection status temp file:".

712 713
2002-08-15  Per Cederqvist  <ceder@ceder.dyndns.org>

714 715 716 717 718 719
	"make check" may now work with Python 1.5.
	* doc/checkargs.py (prot_a_type.use): Don't use +=.
	(reader.getc_eofok): Ditto.
	(lexer.toplevel_rarg): Ditto.
	(lexer.toplevel_aarg): Ditto.

720 721 722 723 724 725 726 727 728 729
	"make check" should no longer require gawk.
	* doc/Makefile.am (.texi.notab): Use $(AWK), not gawk.  At least
	some other awk implementations supports this script.

2002-08-14  Per Cederqvist  <ceder@ceder.dyndns.org>

	Makefile bug fixed.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Fixed
	a makefile syntax error.

730 731 732
2002-08-13  Per Cederqvist  <ceder@ceder.dyndns.org>

	* HACKING: Updated version number of automake.
733
	Mention Xenofarm.
734

735 736
2002-08-11  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
737 738 739 740 741 742 743 744 745 746 747 748 749
	Distribution cleanup.
	* src/server/testsuite/lyskomd.0/Makefile.am (EXTRA_DIST): Added
	21.exp, 22.exp, 23.exp, 24.exp, 25.exp, 26.exp, 27.exp, 28.exp,
	bug-145.exp, bug-225.exp, bug-349.exp, bug-37-2.exp, bug-37-3.exp,
	bug-37-4.exp, bug-37.exp, bug-38.exp, bug-598-2.exp, bug-598.exp,
	bug-612.exp and bug-84.exp.
	* doc/Makefile.am (MOSTLYCLEANFILES): Added TeX temp file
	regarding protocol-a.texi, and protocol-a.texi.
	(DISTCLEANFILES): Added Protocol-A.pdf.
	(Protocol-A.dvi): Fix the TEXINPUTS setting so that a VPATH
	compile works.
	(Protocol-A.pdf): Ditto.

750 751 752 753 754 755 756
	Update version numbers.
	* configure.in: Set version 2.0.7.
	* versions (SERVER-VERSION): 2.0.7.
	(SERVER-COMPAT-VERSION): 20007.
	* doc/Protocol-A.texi (PROTOEDITION): Set to 10.7.
	(VERSION): Set to 2.0.7.

757 758 759 760 761 762 763 764 765 766 767 768
	Document "language" in the common area.  (Bug 124).
	Fix grammar of common area.
	* doc/Protocol-A.texi (The User Area): The description of the
	common block grammar contained many errors.  State that everything
	is encoded as HOLLERITHs, and that they in turn contain
	datatypes.  Removed "list" and "elems"; added "string-list".
	Added the "language" setting.
	* doc/constructs.expected: Updated.
	* doc/checkargs.py (lexer.toplevel_copying): Ignore.
	(lexer.toplevel_quotation): Ignore
	(lexer.toplevel_insertcopying): Ignore.

769 770 771 772 773 774 775 776 777 778 779 780 781 782 783
	Make it possible to disable DNS lookups.  Log DNS lookups that
	takes too long.  (Bug 627).
	* src/server/server-config.c (parameters): Removed "Y2K
	Compatibility".  Added "Use DNS" and "DNS log threshold".
	* doc/lyskomd.texi (Parameter Types): Document "double".
	(Parameters): New parameters: "Use DNS:" and "DNS log
	threshold:".
	* src/server/param.h (struct kom_par): Added use_dns and
	dns_log_threshold.  Removed y2k_compat.
	* src/server/connections.c (get_host_name): New function.
	(login_request): Use get_host_name.
	(logout_request): Ditto.
	* src/server/conf-file.h, src/server/conf-file.c (assign_double):
	New function.

784 785
2002-08-10  Per Cederqvist  <ceder@ceder.dyndns.org>

786 787 788 789 790 791 792 793
	Fix documentation of privilege bits create-conf and create-pers.
	(Bug 688).
	* doc/Protocol-A.texi (Security): create-conf and create-pers are
	normally not assigned.  Added a footnote that says that they are
	normally not needed, either.
	* src/server/testsuite/lyskomd.0/27.exp: Removed references to bug
	688.

794 795 796 797 798 799 800 801 802 803
	Check for ar. (Bug 523).
	* configure.in: Check for ar.  Look in $PATH:/usr/ccs/bin, and
	stop with an error if no ar can be found.

	Avoid duplicating the license in Protocol-A.texi. (Bug 441).
	* doc/Protocol-A.texi: Use the new @copying and @insertcopying
	commands, to avoid repeating the copyright information.
	(About this document): New node, that makes the copyright
	information visible in Info and HTML.

804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830
	Fix the parser so that negative numbers are rejected.  Don't
	pretend that the protocol base will ever be anything but ten.
	(Bug 225).
	* src/libraries/libmisc/s-string.h: (s_strtol): Removed the base
	argument.
	* src/libraries/libmisc/s-string.c (char2digit): Removed the base
	argument.  Simplified the code.  This should be faster now.
	(s_strtol): Removed the base argument.  Don't allow leading '+'
	or '-' signs.  This simplifies the code.
	* src/server/prot-a-parse.c (prot_a_parse_long): Removed the
	base argument of s_strtol.
	(prot_a_parse_string): Ditto.
	* src/server/aux-items.c (aux_item_trigger_mark_text): Removed the
	base argument of s_strtol.
	(aux_item_trigger_unmark_text): Ditto.
	(aux_item_trigger_mirror_faq): Ditto.
	(aux_item_validate_existing_text): Ditto.
	* src/include/kom-config.h (PROTOCOL_NUMBER_BASE): Removed.
	* src/server/testsuite/lyskomd.0/prot-a-parse-cov.exp: Updated,
	now that the parser no longer accepts negative numbers.
	* src/server/testsuite/lyskomd.0/bug-225.exp: Test bug 225.

	Fix references to dbck documentation.  (Bug 386).
	* doc/lyskomd.texi (Parameters): Don't refer to dbck.info, since
	that document is now part of lyskomd.texi.
	(Administration): Ditto.

831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864
	Fix error codes for query-read-texts, query-read-texts-old and
	sub-member.  (Bug 161, Bug 703, Bug 43 and Bug 612).
	* src/server/person.c: "kom-errno.h" must now be included
	before "manipulate.h".
	(do_query_read_texts): Fix error code computations.  Previously,
	ENA(admin,4) was needed.  Now, ENA(admin,2) or ENA(wheel,8) is
	enough. (Bug 161 & Bug 703).
	* src/server/membership.c (enum memb_visibility): Moved to
	manipulate.h.
	(membership_visible): No longer static.
	(sub_member): Improve error code computations.  (Bug 612 & Bug 43).
	* src/server/manipulate.h (enum memb_visibility): Moved here from
	membership.c.
	(membership_visible): Now exported from membership.c.
	(set_conf_errno): New function.
	* src/server/conference.c: "kom-errno.h" must now be included
	before "manipulate.h".
	(set_conf_errno): New function.
	* src/server/admin.c: "kom-errno.h" must now be included before
	"manipulate.h".
	* src/server/aux-items.c: Ditto.
	* src/server/dbck.c: Ditto.
	* src/server/send-async.c: Ditto.
	* src/server/server-config.c: Ditto.
	* src/server/session.c: Ditto.
	* src/server/standalone.c: Ditto.
	* src/server/text.c: Ditto.
	* src/server/testsuite/lyskomd.0/27.exp: Bug 703 is fixed.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Bug 703 is fixed.
	* src/server/testsuite/lyskomd.0/bug-612.exp: Test cases for bug
	612.
	* doc/Protocol-A.texi (sub-member): Document the value of
	error-status for permission-denied errors.

865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886
	get-membership and get-membership-old didn't always honor
	unread-is-secret. (Bug 607).  (Bug 608).
	* src/server/membership.c (copy_public_confs): New argument:
	pers_no.  Caller updated.  Use membership_visible to simplify code
	and fix bugs 607 and 607.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Bug 607 and bug 608
	are now fixed.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.

	get-members and get-members-old leaks secret persons (Bug 705).
	* src/server/membership.c (membership_visible): New arguments:
	is_supervisor_of_member, is_supervisor_of_conf.  Callers updated.
	Avoid calling access_perm if possible.  Grant full access if
	ENA(admin,2) or ENA(wheel,8), as do_get_members did.
	(do_get_members): Use membership_visible to simplify code, and fix
	bug 705.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Bug 705 fixed.

	Minor doc fix.
	* doc/Protocol-A.texi (Membership visibility): Markup fixed.
	* doc/constructs.expected: Updated.

887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902
	Fix membership visibility for get-unread-confs. (Bug 597).
	* src/server/membership.c (enum memb_visibility): New enum.
	(check_unread): New static function.
	(membership_visible): New static function, that fully implements
	the membership visibility rules that were documented 2002-08-07.
	(get_unread_confs): Use membership_visible to simplify the code
	and use the correct membership visibility rules.  Various code
	cleanup.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: get-unread-confs is
	now better.  Bug 597 fixed.
	* src/server/testsuite/lyskomd.0/bug-37.exp: get-unread-confs now
	fails in a different, and better, way for secret persons.
	* src/server/testsuite/lyskomd.0/27.exp: query-read-texts-old, 
	query-read-texts and get-unread-confs should not censor the secret
	conference, since the viewer is supervisor of the member.

903 904
2002-08-08  Per Cederqvist  <ceder@ceder.dyndns.org>

905 906 907 908
	Comment added.
	* src/server/membership.c (sub_member): Added comments for bug
	612.

909 910 911 912 913 914 915 916 917
	Code cleanup: remove global define of SMALLOC_MAGIC_ALLOC and
	SMALLOC_MAGIC_FREE. (Bug 562).
	* src/server/ram-smalloc.c (SMALLOC_MAGIC_ALLOC): Moved here from
	smalloc.h.  Only define if USE_MALLOC_GUARDS is true.
	(SMALLOC_MAGIC_FREE): Ditto.
	* src/include/server/smalloc.h (SMALLOC_MAGIC_ALLOC): Moved to
	ram-smalloc.c.
	(SMALLOC_MAGIC_FREE): Ditto.

918 919 920 921 922 923 924
	Test membership visibility in get-members-old and get-members.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Test get-members-old
	and get-members.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Ditto.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.

925 926 927 928
2002-08-07  Per Cederqvist  <ceder@ceder.dyndns.org>

	Documented membership visibility.  (Bug 693).
	* doc/Protocol-A.texi (Membership visibility): New chapter.
929 930 931
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: Updated for new
	membership visibility rules.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: Ditto.
932

933 934 935 936 937 938 939
2002-08-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix some "make maintainer-clean" lossage.
	* src/server/Makefile.am (aux-item-def-scan.o): Added an explicit
	dependency on aux-item-def-parse.h.
	* Makefile.am (DISTCLEANFILES): Added config.cache.

Per Cederqvist's avatar
Per Cederqvist committed
940 941 942 943 944 945
2002-08-02  Per Cederqvist  <ceder@ceder.dyndns.org>

	More valgrind integration.
	* src/server/testsuite/config/unix.exp (check_valgrind): Remove
	boring valgrind logfiles.

946 947 948 949 950 951 952 953
2002-08-02  David Byers  <david.byers@swipnet.se>

	Add missing test cases for bug 84.
	* src/server/testsuite/config/prot-a.exp (kom_delete_text): New
	function. Use to delete a text from the test suite.
	* src/server/testsuite/lyskomd.0/bug-84.exp: Added missing test
	cases for bug 84 and one xfail for bug 690.

954
2002-08-02  Per Cederqvist  <ceder@ceder.dyndns.org>
955 956 957 958 959

	Work around a race condition in the test suite.
	* src/server/testsuite/lyskomd.0/18.exp: Sleep six seconds to work
	around a race condition (Bug 692).

960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006
	Suppress errors from regex.c.  Handle simultaneous runs of lyskomd
	and dbck.
	* src/server/testsuite/lyskomd.supp: New file for valgrind.  This
	contains a suppression for bug 691.
	* src/server/testsuite/config/unix.exp (l2g_start): Pass a log
	file name to the valgrind wrapper.
	(dbck_run): Ditto.
	(spawn_lyskomd): New argument: log file name.  All callers
	updated.  Use the lyskomd.supp valgrind suppressions file.  Pass
	--show-reachable=yes and a log file name to valgrind.
	(check_valgrind): New arguments: logfile, need_leaks and
	need_errs.  All callers updated.
	* src/server/testsuite/Makefile.am (valgrind.wrap): Expect the log
	file name as the first argument.
	(EXTRA_DIST): Added lyskomd.supp.

	Make it possible to run lyskomd without malloc guard areas.
	* configure.in: Added --disable-malloc-guards.  This is useful
	when combined with --with-valgrind, but should not be used in a
	production setting.
	* src/server/ram-smalloc.c: Document our guard areas, and make
	them optional.
	(OVERHEAD): New macro, that computes a size including the guard
	area overhead.  Two versions, depending on if USE_MALLOC_GUARDS is
	defined or not.
	(smalloc): Reindent.  Test USE_MALLOC_GUARDS.
	(sfree): Test USE_MALLOC_GUARDS.
	(srealloc): Test USE_MALLOC_GUARDS.

	Fixed a read past the end of a buffer.
	* src/libraries/libmisc/s-string.c (s_strtol): When a string
	containing only whitespace was passed to s_strtol, s_strtol would
	attempt to read the sign ('+' or '-') past the end of the string.

	Fix the l2g test cases.
	* src/server/testsuite/l2g.0/00.exp: Destroy all structures before
	exit, so that the leak check of valgrind works properly.
	* src/server/testsuite/l2g.0/01.exp: Ditto.
	* src/server/testsuite/l2g.0/02.exp: Ditto.
	* src/server/testsuite/l2g.0/03.exp: Ditto.
	* src/server/testsuite/l2g.0/04.exp: Ditto.
	* src/server/testsuite/l2g.0/05.exp: Ditto.
	* src/server/testsuite/l2g.0/06.exp: Ditto.
	* src/server/testsuite/l2g.0/07.exp: Ditto.
	* src/server/testsuite/l2g.0/08.exp: Ditto.
	* src/server/testsuite/l2g.0/09.exp: Ditto.
	* src/server/testsuite/l2g.0/10.exp: Ditto.
1007

1008 1009 1010
	Valgrind refinements.
	* src/server/testsuite/config/unix.exp (spawn_lyskomd): Use
	valgrind.wrap.
Per Cederqvist's avatar
Per Cederqvist committed
1011 1012 1013 1014 1015
	(l2g_start): Use valgrind.
	(l2g_stop): Check valgrind output.
	(lyskomd_fail_start): Use valgrind.
	(check_valgrind): Ensure that the memory report is seen.
	(dbck_run): Use valgrind.
1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
	* src/server/testsuite/Makefile.am (valgrind.wrap): New target.
	Since valgrind can only send the log to a specified file
	descriptor, and expect cannot open a specified file descriptor, we
	have to use a wrapper for valgrind.
	(noinst_DATA): Added
	valgrind.exp.
	(MOSTLYCLEANFILES): Added valgrind-*.log, valgrind.log and
	valgrind.wrap.
	(check-l2g): Depend on valgrind.wrap.
	(check-lyskomd): Ditto.
	(check-leaks): Ditto.

	Plug a memory leak.
	* src/server/aux-items.c (aux_item_definition_cache_regexp): Call
	regfree() when a regex compilation fail, since our
	re_compile_pattern may leave allocated stuff in the buffer.

1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050
	Improved valgrind support.
	* configure.in: Remove all remnants of the purify support, since
	it was broken when we switched to automake.  Added valgrind
	support.
	* src/server/testsuite/.cvsignore: Ignore valgrind-*.log.
	* src/server/testsuite/Makefile.am (site.exp): Set valgrind.
	* src/server/testsuite/config/unix.exp: Use the "valgrind"
	variable from site.exp.  It contains a the path name of the
	valgrind binary to use.
	(spawn_lyskomd): Adjust accordingly.  Don't use -v.
	(check_valgrind): New argument: expected_leaks.
	(lyskomd_death): Pass the new optional argument "expected_leaks"
	to check_valgrind.

	Note a memory leak.
	* src/server/testsuite/lyskomd.0/regexp-match-cov.exp: Bug 689 is
	a hard-to-fix memory leak.  Mark it as an expected failure.
	(shutdown): Pass info about expected leaks to lyskomd_death.
1051 1052
	* src/server/testsuite/lyskomd.0/aux-items-cov.exp: This triggers
	a hard-to-fix memory leak (Bug 689).
1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063

	Shut up valgrind.
	* src/server/memory.c (init_person): Clear the pwd field.  This
	way, we avoid writing junk to the database file, and we make
	valgrind happy.  The junk was never used, so this is not a
	bugfix.

	Test suite fix.
	* src/server/testsuite/lyskomd.0/27.exp: Use idholl where
	appropriate.

1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084
	Fix a minor memory leak.
	* src/server/aux-items.c (free_aux_item_definitions): Fixed a
	memory leak.  We have to call regfree() to deallocate stuff within
	the compiled regular expression.  This bug was found with
	valgrind.

	Added some valgrind support.  (Bug 514).
	* src/server/testsuite/config/unix.exp: Handle the VALGRIND
	command line argument.
	(spawn_lyskomd): New proc, that knows how to use valgrind.
	(lyskomd_fail_start): Use spawn_lyskomd.
	(parse_valgrind_leak): New proc.
	(check_valgrind): New proc.
	(lyskomd_death): Call check_valgrind.

2002-08-01  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor doc fix.
	* doc/Protocol-A.texi (Preface): Fix markup.
	* doc/constructs.expected: Updated.

1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
2002-07-31  Per Cederqvist  <ceder@ceder.dyndns.org>

	Updated send-comments-to [33] so that it now allows an optional
	recipient type.
	* run-support/aux-items.conf: Updated send-comments-to [33].
	* doc/Protocol-A.texi (Aux-Item Types): Ditto.
	* src/server/testsuite/lyskomd.0/23.exp: Refer to 28.exp.
	* src/server/testsuite/lyskomd.0/28.exp: Test the aux-item
	send-comments-to (33) with a specified recipient type.

	More membership visibility tests. 
	* src/server/testsuite/lyskomd.0/27.exp: Test basic visibility of
	a secret conference for the supervisor of a member.  Version 2.0.6
	of lyskomd passes the test as written.

1100 1101 1102 1103 1104 1105 1106
2002-07-22  Per Cederqvist  <ceder@ceder.dyndns.org>

	Fix typo in Protocol A example.
	* doc/Protocol-A.texi (re-z-lookup): Fixed ref-id error in
	example.  Thanks to Joorin for pointing it out.
	(Preface): Mention that bugs should be reported via Bugzilla.

Per Cederqvist's avatar
Per Cederqvist committed
1107 1108
2002-06-22  Per Cederqvist  <ceder@ceder.dyndns.org>

Per Cederqvist's avatar
Per Cederqvist committed
1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
	New membership-related tests.
	* doc/Protocol-A.texi (Person Status Types): Explicitly say that
	the supervisor of a person bypasses the unread-is-secret bit.
	* src/server/testsuite/lyskomd.0/bug-37-4.exp: New test cases.
	Like bug-37.exp, but let the observer be supervisor of all
	conferences, and let all memberships be secret.
	* src/server/testsuite/lyskomd.0/bug-37-3.exp: New test cases.
	Like bug-37.exp, but let the observer be supervisor of all
	conferences.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Don't set the flg3
	flag of the Personal-Flags.

Per Cederqvist's avatar
Per Cederqvist committed
1121 1122 1123 1124 1125
	Removed a comment.
	* src/server/conference.c (set_conf_type): David Byers is no
	longer a supporter of secret persons, so remove a comment that
	states that he is.

1126 1127
2002-06-15  Per Cederqvist  <ceder@ceder.dyndns.org>

1128 1129 1130 1131 1132 1133 1134 1135 1136 1137
	get_unread_confs no longer censors rd-prot conferences. (Bug 596).
	* src/server/membership.c (get_unread_confs): It is sufficient
	that the viewer has read_protected access to a conference for it
	to be returned.
	* src/server/testsuite/lyskomd.0/bug-37.exp: Bug 596 is fixed.
	This also causes two other tests to fail in a different way.
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Adjusted to the
	resolution of bug 596.  This only affects how certain tests
	fails.

1138 1139 1140 1141 1142 1143 1144 1145
	Don't lose the array size of get-membership and
	get-membership-old.  (Bug 598).
	* src/server/membership.c (copy_public_confs): Removed the
	"copy_secret" argument.  Simplify the code, and don't lose the
	array size just because want_read is false.
	* src/server/testsuite/lyskomd.0/bug-598.exp (want_array_size):
	Don't expect failure.

1146 1147 1148 1149 1150 1151 1152
	Added test cases for bug 598: get-membership and
	get-membership-old sometimes drops the array size.
	* src/server/testsuite/lyskomd.0/bug-598.exp: New file.  Test 
	bug 598.
	* src/server/testsuite/lyskomd.0/bug-598-2.exp: A version of the
	bug-598.exp test with unread-is-secret set.

Per Cederqvist's avatar
Per Cederqvist committed
1153 1154 1155 1156
	Fixed minor doc error.
	* doc/Protocol-A.texi (get-membership-old): Fixed error in
	description of index-out-of-range.
	(get-membership): Ditto.
1157
	* doc/constructs.expected: Updated.
Per Cederqvist's avatar
Per Cederqvist committed
1158

1159 1160 1161 1162 1163
	Introduce good_bad_expect, for trapping XFAIL situations nicely.
	* src/server/testsuite/config/unix.exp (good_bad_expect): New proc.
	* src/server/testsuite/renumber.el
	(renumber-lyskom-send-simple-expect): Handle good_bad_expect.

Per Cederqvist's avatar
Per Cederqvist committed
1164
	Write a test cases for bug 37.
1165 1166 1167
	* src/server/testsuite/lyskomd.0/bug-37.exp: New test case for bug
	37.  Bugs 593, 594, 595 and 596 were found while writing this test
	case...
Per Cederqvist's avatar
Per Cederqvist committed
1168 1169
	* src/server/testsuite/lyskomd.0/bug-37-2.exp: Like bug-37.exp,
	but with all memberships being secret.  Found bug 597.
1170

1171 1172 1173 1174 1175 1176 1177
	Document unread-is-secret.  (Bug 593).
	* doc/Protocol-A.texi (Person Status Types): Added a reference to
	Security, for an explanation of the privileges.  Document the bits
	in Personal-Flags.
	(Membership Information): Document how unread-is-secret affects
	some parts of Membership and Membership-Old.

1178 1179 1180 1181
	Added a test case for bug 349.
	* src/server/testsuite/lyskomd.0/bug-349.exp: Test case for bug
	349: wrong error code from set_supervisor.

Per Cederqvist's avatar
Per Cederqvist committed
1182 1183
2002-06-14  Per Cederqvist  <ceder@ceder.dyndns.org>

1184 1185 1186 1187
	Document the Message-ID format of exported texts.  (Bug 574).
	* doc/Protocol-A.texi (Importing and Exporting E-Mail): Document
	the Message-ID format of exported texts.

Per Cederqvist's avatar
Per Cederqvist committed
1188 1189 1190 1191 1192 1193
	Remove autoconf-2.53 warning.
	* configure.in: Use all three arguments of AC_DEFINE.
	* acinclude.m4 (CMOD_C_ATTRIBUTE_UNUSED): Use all three arguments
	of AC_DEFINE.
	* acconfig.h: File removed.

1194 1195 1196 1197 1198 1199
2002-05-20  Per Cederqvist  <ceder@ceder.dyndns.org>

	Minor doc fix.
	* doc/Protocol-A.texi (Client-Server Dialog): Don't mention
	feature-disabled twice.

1200 1201 1202 1203
2002-05-07  David Byers  <david.byers@swipnet.se>

	* Updated message from 2002-04-11.

1204 1205 1206 1207 1208
2002-04-14  David Byers  <david.byers@swipnet.se>

	* doc/Protocol-A.texi (Aux-Item Types): Documented
	elisp-client-read-faq and elisp-client-rejected-recommendation.

David Byers's avatar
David Byers committed
1209 1210 1211 1212 1213 1214 1215
2002-04-13  David Byers  <david.byers@swipnet.se>

	Test for fix of bug 145:
	* src/server/testsuite/config/prot-a.exp (kom_delete_conf): New
	function.
	(kom_lookup_z_name): New function.

1216 1217
2002-04-12  David Byers  <david.byers@swipnet.se>

David Byers's avatar
David Byers committed
1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235
	Fix bug 145:
	* src/server/conference.c (do_delete_conf): Removed lines that
	cleared the name of the conference. That is done in
	cached_delete_conf.

	Fix bug 38:
	* src/server/testsuite/lyskomd.0/bug-38.exp: New file.

	* src/server/testsuite/config/prot-a.exp (kom_set_user_area): New
	function.
	(kom_shutdown_server): New function.
	(kom_create_text_simple): New function.
	(cres): The else branch which does eval actually works now. Made
	ref_no global in this function.

	* src/server/person.c (do_set_user_area): Copied check for read
	access to new user area from get_text_stat.

1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252
	Fix bug 331:
	* src/server/testsuite/lyskomd.0/03.exp: Use idholl and
	lyskomd_host for hostname-dependend strings.

	* src/server/testsuite/lyskomd.0/16.exp: Use idholl and
	lyskomd_host for hostname-dependend strings.

	* src/server/testsuite/lyskomd.0/01.exp: Use idholl and
	lyskomd_host for hostname-dependend strings.

	* src/server/testsuite/lyskomd.0/00.exp: Use idholl and
	lyskomd_host for hostname-dependend strings.

	* src/server/testsuite/config/unix.exp (idholl): New function to
	create hollerith with at sign and name of localhost appended.
	(lyskomd_server): New variable containing the name of this host.

1253 1254
2002-04-11  David Byers  <david.byers@swipnet.se>

1255 1256 1257 1258
	* src/server/aux-items.c (aux_item_trigger_mirror_faq): Don't just
	return when the object type is INFO_OBJECT_TYPE (which represents
	server aux-items). Instead, create the mirror aux-item as required
	by the protocol.
1259

1260 1261
	* configure.in: Added AC_PREREQ.

1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289
2002-04-07  Per Cederqvist  <ceder@ceder.dyndns.org>

	Added the world-readable aux item.  (Bug 5).
	* run-support/aux-items.conf: Added world-readable [34].
	* src/server/text.c (person_text_read_access): Give everybody read
	access to texts with a world-readable aux-item.
	* doc/Protocol-A.texi (Aux-Item Types): New aux-item: world-readable.
	(get-text): Mention the world-readable aux
	item under the no-such-text error code.
	(get-text-stat-old): Ditto.
	(get-text-stat): Ditto.
	* src/server/testsuite/lyskomd.0/01.exp: Handle world-readable.
	* src/server/testsuite/lyskomd.0/03.exp: Ditto.
	* src/server/testsuite/lyskomd.0/18.exp: Ditto
	* src/server/testsuite/lyskomd.0/26.exp: Test world-readable.

2002-04-06  Per Cederqvist  <ceder@ceder.dyndns.org>

	Use symbolic names for aux item tags.
	* src/server/aux-items.c (aux_item_trigger_mirror_faq): Use
	aux_faq_for_conf from aux.h instead of a hardcoded 28.
	* src/server/Makefile.am (aux.h): New target.
	(MOSTLYCLEANFILES): Added aux.h.
	(NODIST_GENOBJS): Added aux.h.
	(BUILT_SOURCES): Added aux.h.
	(version.incl): Fixed spelling error.
	(version-info.c): Ditto.

Per Cederqvist's avatar
Per Cederqvist committed
1290 1291
2002-04-02  Per Cederqvist  <ceder@ceder.dyndns.org>

1292 1293 1294 1295
	Fix the documentation of no-of-created-texts (Bug 384).
	* doc/Protocol-A.texi (Person Status Types): Fix the documentation
	of no-of-created-texts.  (Bug 384).

1296 1297 1298 1299 1300 1301
	Clarify the description of get-person-stat-old.
	* doc/Protocol-A.texi (get-person-stat-old): Don't call the
	"username" field "name".  Add markup for it.  Clarify that the
	empty string is returned; dont say that the "name is not
	returned".

Per Cederqvist's avatar
Per Cederqvist committed
1302 1303 1304 1305 1306
	Automake improves.
	* src/server/testsuite/Makefile.am (noinst_DATA): Removed a
	comment about an Automake deficiency that is no longer there.
	(Bug 208).

1307 1308 1309 1310 1311
2002-03-29  Per Cederqvist  <ceder@moria>

	* Release 2.0.6.

	Release administrativa.
Per Cederqvist's avatar
Per Cederqvist committed
1312 1313
	* doc/checkargs.py: Copyright header added.
	* scripts/lyskomd-copyrights: Updated.
1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344
	* HACKING: Updated version numbers.  Mention Bugzilla.
	* configure.in: Set version 2.0.6.
	* versions (SERVER-VERSION): 2.0.6.
	(SERVER-COMPAT-VERSION): 20006.
	* README: Updated for the 2.0.6 release.
	* NEWS: Updated for the 2.0.6 release.
	* doc/Protocol-A.texi (PROTOEDITION): Set to 10.6.
	(VERSION): Set to 2.0.6.
	(Document Edition History): Document changes in edition 10.6.
	* doc/constructs.expected: Updated.

	Create PDF and DVI output from the protocol specification.
	* doc/Makefile.am (pdf): New target.
	(html): New target.
	(Protocol-A.dvi): New target.
	(Protocol-A.pdf): Use texi2dvi --pdf instead of texi2pdf.
	(protocol-a.texi): New target.  Major hack.  Expand a few of the
	macros so that texinfo.tex can cope with the rest.
	(protocol-a/index.html): New target.
	(.texi.notab): Use automake comments instead of /bin/sh comments.
	(update-www): Also depend on protocol-a/index.html, Protocol-A.dvi
	and Protocol-A.pdf, and install them.
	(check): Also depend on the targets pdf and dvi.

	Doc fixes.
	* doc/Protocol-A.texi (create-person-old): Moved a misplaced brace
	to its proper place.
	(get-text): State that ^J represents a newline in the example.
	(create-person-old): Move punctuation outside of quotes, according
	to the Texinfo style guide.

Per Cederqvist's avatar
Per Cederqvist committed
1345 1346 1347 1348 1349 1350 1351
2002-03-26  Per Cederqvist  <ceder@ingate.com>

	Port to Cygwin.
	* src/server/Makefile.am (all-recursive): Added the $(EXEEXT)
	suffix to lyskomd and dbck, so that the makefile works on cygwin.
	(check-recursive): Ditto.

1352 1353
2002-03-24  Per Cederqvist  <ceder@moria>

Per Cederqvist's avatar
Per Cederqvist committed
1354
	Allow faq-text to be set on letterboxes.  (Bug 423).
1355 1356 1357 1358 1359 1360 1361
	* run-support/aux-items.conf (faq-text): Allow it on letterboxes
	as well as conferences and the server.
	* doc/Protocol-A.texi (Aux-Item Types): Document that faq-text may
	be set on letterboxes.
	* src/server/testsuite/lyskomd.0/03.exp: Set an faq-text on the
	letterbox of person 8.

1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381
2002-02-15  Per Cederqvist  <ceder@moria>

	Added support for the "Jubel: public" parameter, that enforces
	the policy that certain texts must be created in public
	conferences.
	* src/server/testsuite/lyskomd.0/25.exp: Test public jubels.
	* src/server/text.c (create_text_check_misc): New argument:
	need_public_jubel.
	(struct jubel): New field: public.
	(register_jubel): New argument: public.
	(ok_to_create_next_text): New result parameter: must_be_public.
	(do_create_text): Check for jubels that must be public.
	* src/server/standalone.c (register_jubel): New argument: public.
	* src/server/server-config.c (jubel): Handle the new "public" form.
	* src/server/manipulate.h (register_jubel): New argument: public.
	* doc/lyskomd.texi (Parameter Types): These are standard types,
	not all legal types.
	(Parameters): Document the "public" forms of the Jubel parameters.
	Mention that there may be several Jubel parameters.

1382 1383
2002-02-11  Per Cederqvist  <ceder@moria>