Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Per Cederqvist
lyskom-server-ceder-1616-generations-topgit
Commits
37a966f7
Commit
37a966f7
authored
Nov 03, 2001
by
Per Cederqvist
Browse files
Removed obsolete FIXME comments. Added references to Bugzilla for all
remaining FIXME comments.
parent
a2ff5da8
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/server/session.c
View file @
37a966f7
/*
* $Id: session.c,v 0.5
6
200
0/09
/0
6
1
9:54
:3
2
ceder Exp $
* $Id: session.c,v 0.5
7
200
1/11
/0
3
1
8:00
:3
3
ceder Exp $
* Copyright (C) 1991-1994, 1996-2000 Lysator Academic Computer Association.
*
* This file is part of the LysKOM server.
...
...
@@ -34,7 +34,7 @@
#endif
static
const
char
*
rcsid
=
"$Id: session.c,v 0.5
6
200
0/09
/0
6
1
9:54
:3
2
ceder Exp $"
;
rcsid
=
"$Id: session.c,v 0.5
7
200
1/11
/0
3
1
8:00
:3
3
ceder Exp $"
;
#include
"rcs.h"
USE
(
rcsid
);
...
...
@@ -93,7 +93,6 @@ leave_conf(Connection *conn)
{
Membership
*
mship
;
/* FIXME NOW */
if
(
conn
->
cwc
!=
0
)
{
if
((
mship
=
locate_membership
(
conn
->
cwc
,
conn
->
person
))
...
...
@@ -144,7 +143,7 @@ login_old (Pers_no pers_no,
return
FAILURE
;
}
logout
();
/*FIXME: How many tries are allowed before disconnection? */
logout
();
active_connection
->
flags
.
invisible
=
FALSE
;
...
...
@@ -229,7 +228,7 @@ login (Pers_no pers_no,
same_person
=
(
ACTPERS
==
pers_no
)
?
TRUE
:
FALSE
;
logout
();
/*+++ How many tries are allowed before disconnection? */
logout
();
if
(
invisible
)
active_connection
->
flags
.
invisible
=
TRUE
;
...
...
@@ -854,7 +853,7 @@ get_time( time_t *clk )
/*
* Set ena_level. 0 means don't use any privileges.
///
* Set ena_level. 0 means don't use any privileges.
*/
extern
Success
enable
(
u_char
ena_level
)
...
...
@@ -956,8 +955,9 @@ accept_async(Number_list *num_list)
* Check agains maliciously long arrays
*/
/* FIXME: The following test only needs one branch depending on
FIXME: which implementation of prot_a_parse_num_list we go with. */
/* FIXME (bug 166): The following test only needs one branch
depending on which implementation of prot_a_parse_num_list we
go with. */
if
(
num_list
->
length
>
param
.
accept_async_len
||
(
num_list
->
data
==
NULL
&&
num_list
->
length
>
0
))
...
...
src/server/text.c
View file @
37a966f7
/*
* $Id: text.c,v 0.8
4
2001/
09/30 16:52:00
ceder Exp $
* $Id: text.c,v 0.8
5
2001/
11/03 18:03:25
ceder Exp $
* Copyright (C) 1991-2001 Lysator Academic Computer Association.
*
* This file is part of the LysKOM server.
...
...
@@ -34,7 +34,7 @@
#endif
static
const
char
*
rcsid
=
"$Id: text.c,v 0.8
4
2001/
09/30 16:52:00
ceder Exp $"
;
rcsid
=
"$Id: text.c,v 0.8
5
2001/
11/03 18:03:25
ceder Exp $"
;
#include
"rcs.h"
USE
(
rcsid
);
...
...
@@ -662,10 +662,8 @@ perform_subtraction(Text_no text_no,
/*
* Delete a recipient from a text. Does not fail if the recipient doesn't
* exist - that is not an error.
*
* FIXME: 1999-05-30: is it really possible for the recipient to be
* nonexisting? When?
* exist - that is not an error. (The recipients of a text are not
* removed when a conference is deleted.)
*/
static
Success
do_sub_recpt
(
Text_no
text_no
,
...
...
@@ -1179,7 +1177,7 @@ recp_sent_by(const Misc_info *misc,
/*
* Copy the text_stat original into result, but only those part
* that viewer is allowed to see.(Censor away information about
* that viewer is allowed to see.
(Censor away information about
* conferences that viewer is not allowed to know about).
*
* All memory is allocated via tmp_alloc().
...
...
@@ -1195,7 +1193,7 @@ filter_secret_info(Text_stat *result,
Pers_no
viewer
;
const
Person
*
viewer_p
;
/* FIXME: Possible optimisation:
/* FIXME
(bug 177)
: Possible optimisation:
No need to copy unless there is a secret conf among the recipients. */
*
result
=
*
original
;
...
...
@@ -1403,13 +1401,13 @@ text_read_access(Connection *conn,
*/
/*
* FIXME: This function checks if pers_no is the same as
ACTPERS in a
*
FIXME:
number of places. This means that this function does
not
*
FIXME:
quite do the right thing. However, in order to remove these
*
FIXME:
tests, additional code may be needed in callers of this
*
FIXME: function
(for example, we might have to pass the connection
*
FIXME: in the
aux-item-add-triggers so that they can do a proper
*
FIXME: privilege
check).
* FIXME
(bug 178)
: This function checks if pers_no is the same as
*
ACTPERS in a
number of places. This means that this function does
*
not
quite do the right thing. However, in order to remove these
* tests, additional code may be needed in callers of this
function
* (for example, we might have to pass the connection
in the
* aux-item-add-triggers so that they can do a proper
privilege
* check).
*/
Bool
...
...
@@ -1712,7 +1710,7 @@ get_text(Text_no text_no,
return
FAILURE
;
}
/* Should use something in s-string.c to do this.
+++
*/
/*
FIXME (bug 179):
Should use something in s-string.c to do this. */
result
->
string
+=
start_char
;
result
->
len
=
min
(
result
->
len
-
1
,
end_char
)
+
1
-
start_char
;
...
...
@@ -2707,12 +2705,10 @@ get_last_text(struct tm *wanted_time,
try
=
middle
;
text_stat
=
NULL
;
/*
FIXME: Once there is a more efficient structure that
FIXME: maps Text_nos to the internal cache_node this
FIXME: loop could probably be rewritten in a more
FIXME: efficient way.
*/
/* FIXME (bug 180): Once there is a more efficient structure
that maps Text_nos to the internal cache_node this loop
could probably be rewritten in a more efficient way. */
while
(
text_stat
==
NULL
&&
try
<=
higher
)
text_stat
=
cached_get_text_stat
(
try
++
);
...
...
@@ -2880,8 +2876,9 @@ add_recipient(Text_no text_no,
&&
!
is_supervisor
(
conf_no
,
ACTPERS
,
ACT_P
)
&&
!
ENA
(
wheel
,
8
))
/* OK -- In an RPC call */
{
/* FIXME: if there is a sent-by misc-item that belongs to this,
the sender should also be allowed to do this. */
/* FIXME (bug 181): if there is a sent-by misc-item that
belongs to this, the sender should also be allowed to
do this. */
err_stat
=
conf_no
;
kom_errno
=
KOM_PERM
;
return
FAILURE
;
...
...
@@ -2894,13 +2891,11 @@ add_recipient(Text_no text_no,
t_stat
->
misc_items
[
rcpt_index
].
type
=
type
;
#if 0
/*
FIXME: This should possibly be done, but differently.
FIXME: ADD_MISC adds things lasts in the misc-info, and
FIXME: that is not the correct thing to do. The change is
FIXME: now performed silently instead. Also note that
FIXME: these fields may already be present...
*/
/* FIXME (bug 182): This should possibly be done, but
differently. ADD_MISC adds things lasts in the misc-info,
and that is not the correct thing to do. The change is now
performed silently instead. Also note that these fields
may already be present... */
if (t_stat->author != ACTPERS)
ADD_MISC(t_stat, sent_by, sender, ACTPERS);
...
...
@@ -2920,10 +2915,6 @@ add_recipient(Text_no text_no,
return
FAILURE
;
}
/*
FIXME: Should extract the "is allowed to write to this
FIXME: conference" test from submit_to()
*/
submit_conf
=
submit_to
(
conf_no
,
conf_c
);
if
(
submit_conf
==
0
)
...
...
@@ -3065,12 +3056,11 @@ add_comment(Text_no comment,
CHK_CONNECTION
(
FAILURE
);
CHK_LOGIN
(
FAILURE
);
/*
FIXME: The following code can not cope with a text that is
FIXME: a comment to itself. That is considered to be a bug.
FIXME: Work around it for now, until a proper misc-info-list
FIXME: handling package is written.
*/
/* FIXME (bug 183): The following code can not cope with a text
that is a comment to itself. That is considered to be a bug.
Work around it for now, until a proper misc-info-list handling
package is written. */
if
(
comment
==
comment_to
)
{
err_stat
=
comment
;
...
...
@@ -3189,12 +3179,11 @@ add_footnote(Text_no footnote,
return
FAILURE
;
}
/*
FIXME: The following code can not cope with a text that
FIXME: is a footnote to itself. That is considered to be
FIXME: a bug. Work around it for now, until a proper
FIXME: misc-info-list handling package is written.
*/
/* FIXME (bug 184): The following code can not cope with a text
that is a footnote to itself. That is considered to be a
bug. Work around it for now, until a proper misc-info-list
handling package is written. */
if
(
footnote
==
footnote_to
)
{
err_stat
=
footnote
;
...
...
@@ -3270,9 +3259,6 @@ sub_footnote(Text_no footnote, /* 'footnote' is no longer a */
/*
* Get mapping from Local_text_no to(global) Text_no for part of
* a conference.
*
* BUG: You should be allowed to get the mapping if it is a letterbox
* which is not unread_is_secret. +++(Really? I don't think so. /ceder)
*/
extern
Success
get_map
(
Conf_no
conf_no
,
...
...
@@ -3454,7 +3440,7 @@ modify_text_info(Text_no text,
text_stat_add_aux_item_list
(
text_s
,
text
,
aux
,
ACTPERS
);
commit_aux_item_list
(
&
text_s
->
aux_item_list
);
/* FIXME: async_text_changed(text, text_s); */
/* FIXME
(bug 93)
: async_text_changed(text, text_s); */
mark_text_as_changed
(
text
);
return
OK
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment