Commit 3aaff933 authored by Per Cederqvist's avatar Per Cederqvist
Browse files

Writing to a client that was disconnecting and blocked could cause

the server to crash.  (Bug 1403).
* src/server/connections.c (check_idle_callback): Don't crash if
isc_enable() fails.  Emit the session number in the log, mostly
for debug purposes.
parent d4ad19a5
2005-12-24 Per Cederqvist <ceder@lysator.liu.se>
Writing to a client that was disconnecting and blocked could cause
the server to crash. (Bug 1403).
* src/server/connections.c (check_idle_callback): Don't crash if
isc_enable() fails. Emit the session number in the log, mostly
for debug purposes.
2005-12-23 Per Cederqvist <ceder@lysator.liu.se>
 
Add automake-generated files to svn:ignore.
......
......@@ -1106,13 +1106,16 @@ check_idle_callback(oop_source *UNUSED(source),
next = next->queue_next;
c->queue_next = NULL;
if (isc_enable(c->isc_session) < 0)
restart_kom("failed to re-enable session\n");
/* The call to read_from_connection() might add the
connection to the queue. That's why we remove all entries
first, and use a private queue within this function. */
if (!go_and_die)
{
kom_log("failed to re-enable session %ld\n", (long)c->session_no);
}
else if (!go_and_die)
{
/* The call to read_from_connection() might add the
connection to the queue. That's why we remove all entries
first, and use a private queue within this function. */
read_from_connection(c);
}
}
if (!is_idle)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment