Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Per Cederqvist
lyskom-server-ceder-1616-generations-topgit
Commits
50a0a16e
Commit
50a0a16e
authored
Nov 03, 2001
by
Per Cederqvist
Browse files
Added references to Bugzilla for all FIXME comments.
parent
c1862181
Changes
3
Hide whitespace changes
Inline
Side-by-side
src/server/aux-items.c
View file @
50a0a16e
/*
* $Id: aux-items.c,v 1.3
0
2001/1
0/28 21:05
:5
8
ceder Exp $
* $Id: aux-items.c,v 1.3
1
2001/1
1/03 17:28
:5
4
ceder Exp $
* Copyright (C) 1994-2001 Lysator Academic Computer Association.
*
* This file is part of the LysKOM server.
...
...
@@ -771,7 +771,7 @@ aux_item_link_items(Object_type src_type, /* Source object type */
text_stat_add_aux_item_list
((
Text_stat
*
)
dst_ptr
,
(
Text_no
)
dst_no
,
&
item_list
,
src_item
->
creator
);
/* FIXME: is this necessary? The call to
/* FIXME
(bug 141)
: is this necessary? The call to
mark_linked_object_as_changed below seems to fix this,
right? --ceder 1999-07-10. */
mark_text_as_changed
((
Text_no
)
dst_no
);
...
...
@@ -780,7 +780,7 @@ aux_item_link_items(Object_type src_type, /* Source object type */
conf_stat_add_aux_item_list
((
Conference
*
)
dst_ptr
,
(
Conf_no
)
dst_no
,
&
item_list
,
src_item
->
creator
);
/* FIXME: is this necessary? The call to
/* FIXME
(bug 141)
: is this necessary? The call to
mark_linked_object_as_changed below seems to fix this,
right? --ceder 1999-07-10. */
mark_conference_as_changed
((
Conf_no
)
dst_no
);
...
...
@@ -801,7 +801,7 @@ aux_item_link_items(Object_type src_type, /* Source object type */
* objects are the same and reallocing the aux item list causes
* it to move in memory
*/
/* FIXME: but src_item isn't used below this point! What is the
/* FIXME
(bug 142)
: but src_item isn't used below this point! What is the
point of setting it to NULL? --ceder 1999-07-10. */
src_item
=
NULL
;
...
...
src/server/conf-file.c
View file @
50a0a16e
/*
* $Id: conf-file.c,v 1.1
7 1999/06/03 22:11:05
ceder Exp $
* $Id: conf-file.c,v 1.1
8 2001/11/03 17:28:54
ceder Exp $
* Copyright (C) 1994-1995, 1998-1999 Lysator Academic Computer Association.
*
* This file is part of the LysKOM server.
...
...
@@ -33,7 +33,7 @@
static
const
char
*
rcsid
=
"$Id: conf-file.c,v 1.1
7 1999/06/03 22:11:05
ceder Exp $"
;
rcsid
=
"$Id: conf-file.c,v 1.1
8 2001/11/03 17:28:54
ceder Exp $"
;
#include
"rcs.h"
USE
(
rcsid
);
...
...
@@ -243,7 +243,7 @@ assign_text_no(const char *val,
{
int
c
;
/* FIXME: use strtol */
/* FIXME
(bug 143)
: use strtol */
if
(
val
!=
NULL
)
{
c
=
(
unsigned
char
)
*
val
;
...
...
@@ -260,7 +260,7 @@ assign_conf_no(const char *val,
{
int
c
;
/* FIXME: use strtol */
/* FIXME
(bug 143)
: use strtol */
if
(
val
!=
NULL
)
{
c
=
(
unsigned
char
)
*
val
;
...
...
@@ -277,7 +277,7 @@ assign_int(const char *val,
{
int
c
;
/* FIXME: use strtol */
/* FIXME
(bug 143)
: use strtol */
if
(
val
!=
NULL
)
{
c
=
(
unsigned
char
)
*
val
;
...
...
src/server/conference.c
View file @
50a0a16e
/*
* $Id: conference.c,v 0.6
4
2001/
09/30 16:52:02
ceder Exp $
* $Id: conference.c,v 0.6
5
2001/
11/03 17:28:54
ceder Exp $
* Copyright (C) 1991-2001 Lysator Academic Computer Association.
*
* This file is part of the LysKOM server.
...
...
@@ -35,7 +35,7 @@
static
const
char
*
rcsid
=
"$Id: conference.c,v 0.6
4
2001/
09/30 16:52:02
ceder Exp $"
;
rcsid
=
"$Id: conference.c,v 0.6
5
2001/
11/03 17:28:54
ceder Exp $"
;
#include
"rcs.h"
USE
(
rcsid
);
...
...
@@ -110,7 +110,8 @@ do_delete_conf (Conf_no conf_no,
/* Delete the name.
FIXME: This is done by cached_delete_conf */
/* FIXME (bug 145): I don't understand the above comment. Check
this for memory leaks and memory corruption. */
s_clear
(
&
conf_c
->
name
);
cached_change_name
(
conf_no
,
EMPTY_STRING
);
...
...
@@ -121,10 +122,14 @@ do_delete_conf (Conf_no conf_no,
* they will not live long.
*/
/* ??? Note that there will still be a recipient in the texts, but it
will not exist in reality. This might cause problems. A do_sub_recpt()
should maybe be used. */
/* Yes, do! Also, send out asynchronous message about deleted conf. */
/*
* Note that there will still be a recipient in the texts, but it
* will not exist in reality. This is maybe unfortunate, but
* there might be thousands of texts in the conference, and we
* cannot modify all those text statuses in a single atomic call.
*/
/* FIXME (bug 93): There should be an async message about the deletion. */
cached_delete_conf
(
conf_no
);
...
...
@@ -312,7 +317,7 @@ do_create_conf(String name,
creator
,
TRUE
)
!=
OK
)
{
/* FIXME: Conf_no leak: We create a conference, check the
/* FIXME
(bug 146)
: Conf_no leak: We create a conference, check the
aux-items, determine that the aux-items are bogus, and
immediately delete the conference. This leaks a conference
number. We can live with that, but it isn't pretty. */
...
...
@@ -921,7 +926,7 @@ set_presentation (Conf_no conf_no,
*
* Only the supervisor can change the motd.
*
*
BUG: +++
There is no asynchronous message that reports new motds.
*
FIXME (bug 93):
There is no asynchronous message that reports new motds.
*/
extern
Success
set_etc_motd
(
Conf_no
conf_no
,
...
...
@@ -1417,7 +1422,7 @@ modify_conf_info(Conf_no conf_no,
conf_stat_add_aux_item_list
(
conf
,
conf_no
,
aux
,
ACTPERS
);
commit_aux_item_list
(
&
conf
->
aux_item_list
);
/* FIXME: async_conf_changed(conf_no, conf); */
/* FIXME
(bug 93)
: async_conf_changed(conf_no, conf); */
mark_conference_as_changed
(
conf_no
);
return
OK
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment