Commit e5a8f5b6 authored by David Byers's avatar David Byers
Browse files

Fixed some aux-item-related bugs

Updated test cases to work with a newer DejaGnu
parent 7472cb88
2001-06-06 David Byers <>
* src/server/aux-items.c (check_delete_aux_item_list): Rewrote
check for delete permissions as multiple if-elseif statements
instead of a compound expression, 'cause the compound expression
was getting just a little bit difficult to understand.
* run-support/aux-items.conf (redirect): Set owner-delete.
(x-face): Ditto.
(pgp-public-key): Ditto.
(e-mail-address): Ditto.
(faq-text): Ditto.
(allowed-content-type): Ditto.
* src/server/text.c (modify_text_info): Added author as owner
argument to check_delete_aux_item_list.
* src/server/admin.c (modify_system_info): Added zero as owner
argument to check_delete_aux_item_list.
* src/server/aux-item-def-parse.y (assign): Added owner-delete.
* src/server/aux-items.c (empty_aux_item_definition): Added
value for owner_delete.
(simple_aux_item): Ditto.
* src/server/aux-items.h: Added owner_delete parameter after
* src/server/aux-items.c (check_delete_aux_item_list): Add owner
parameter. Check owner_delete to see if object owner may delete
* src/server/conference.c (modify_conf_info): Pass conference
supervisor to check_delete_aux_item_list.
2001-09-22 Per Cederqvist <ceder@moria>
Document that clients should allow conferences to be looked up by
......@@ -7,8 +7,27 @@ server.
** Who is allowed to remove an faq-text-aux-item? 6024603.
Added owner-delete parameter to aux-item definition as this is a
somewhat more general problem. It is getting obvious that the
original code for handling access to aux-items is getting stretched
beyond its limits. The code could stand a complete rewrite that
would allow for detailed control of access to items depending on
the type objects they are attached to.
** Analyze the bug reported in 5970012.
Applied the patch. Regrettably it does not break any existing test
cases. Embarrassing...
** Add test cases for recent changes:
Delete aux-item with owner-delete when creator, owner, supervisor
of creator, supervisor of owner, ENA, and someone else.
Check that we get new text messages when for texts that have
recipients we are passive members of. Order with passive conf
first, normal second and the reverse.
* Unsorted.
** New aux-item: text is world-readable without login.
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment