GitLab

connection, and never uses active_connection. (Bug 178).  Fixing this
also required me to remove the ability to specify an faq-text for a
freshly created person on a session where nobody is logged on; this
could be considered a security fix.

	are not logged in.  This change means that create-person
	cannot accept aux-items with the existing-readable-text
	validator if nobody is logged in.  I think this is more
	reasonable than the number of special cases in the code that
	were needed to support the old functionality.

(person_text_read_access): Removed.

	text_read_access.
(text_read_access): Use the supplied Connection for all checks.  Don't
	use active_connection, ENA, ACTPERS or ACT_P.  Fail and log an
	error message if the Connection is NULL.  Use is_supervisor()
	instead of is_supervisor_2().

faq-text using a modify-conf-info request instead.  Test that creation
of a new person with a faq-text item really fails.

ENA_C() and text_read_access() can be used.  Get rid of broken concept
"owner", and introduced "subordinate" instead.  (Bug 334).  Some other
aux-item-related code cleanup.  Added code to diagnose Success
vs. Bool mixups.  Make etags find our documentation.  Include an Emacs
indentation style for our code.  Added more hacking documentation.
Document that send async-deleted-text, async-new-text,
async-new-text-old, async-new-recipient and async-sub-recipient are
sent to recipients of text linked to the relevant text.

	aux_inherit_items().
(do_create_text): Adjusted to new API of
	text_stat_check_add_aux_item_list().
(modify_text_info): Ditto.

	conf_stat_check_add_aux_item_list().

	updated.
(modify_conf_info): Adjusted to new API of
	check_delete_aux_item_list() and
	conf_stat_check_add_aux_item_list().

(aux_item_add_perm): Removed the arguments item_creator,
	object_creator and owner_check.  Added the arguments
	creating_conn and subordinate.  All callers updated.
	Simplified the code.  Use is_supervisor() instead of
	is_strictly_supervisor() where appropriate.  Use the supplied
	connection instead of checking that ACTPERS is the
	item_creator.  Adjusted for the new contents of
	Aux_item_validation_data.
(aux_inherit_items): Removed arguments target_creator, creating and
	object_type.  Added argument subordinate.  Changed type of
	arguments object_no and object, since we know that they are a
	Text_no and Text_stat, respectively.
(filter_aux_item_list): Assert that the viewer_conn argument is
	non-NULL.
(check_delete_aux_item_list): Renamed the "owner" argument
	"subordinate".
(text_stat_check_add_aux_item_list): Removed the item_creator and
	creating arguments.  Added the creating_conn argument, and
	assert it is non-NULL.
(conf_stat_check_add_aux_item_list): Replaced the "creator" argument
	with "creating_conn".  Argument assertions added.
(system_check_add_aux_item_list): Ditto.
(aux_item_validate_existing_text): Changed return type from Bool to
	Success.  Use person_text_read_access() only when necessary,
	and add a comment explaining why it might happen.

	system_check_add_aux_item_list().

	owner_check.  Added creating_conn and subordinate.  Placed
	add_to_list, start_looking_at and object_type inside #if
	0..#endif, since they are not currently used.
(aux_inherit_items):Removed arguments target_creator, creating and
	object_type.  Added argument subordinate.  Changed type of
	arguments object_no and object, since we know that they are a
	Text_no and Text_stat, respectively.
(check_delete_aux_item_list): Renamed the "owner" argument
	"subordinate".
(text_stat_check_add_aux_item): Removed the item_creator and creating
	arguments.  Added the creating_conn argument.
(conf_stat_check_add_aux_item_list): Ditto.
(system_check_add_aux_item_list): Ditto.
(conf_stat_check_add_aux_item): Declaration for undefined and
	unused function removed.
(conf_stat_add_aux_item): Ditto.

(person_text_read_access): Docstring added.

to fail.  Fixed a broken test outcome.

	assurance.

(get_time_often_LDADD): Ditto.

(lyskomd_SOURCES): Ditto.
(komrunning_SOURCES): Ditto.
(updateLysKOM_SOURCES): Ditto.
(dbck_SOURCES): Ditto.
(splitkomdb_SOURCES): Ditto.

(SUCCESS_AS_PTR): Ditto.
(Bool): Provide a pointer-based non-working implementation, that
	can be used for compile-time checks, but not for running code.
(Success): Provide a pointer-based implementation.  Switch to
	using it, at least for now; this might give us good warnings
	from the compilers.

(local-to-global): Ditto.
(Modifying Stored Types): Mention that dbck needs to be updated.
(Coding conventions): New section.

(async-new-text-old): Document that recipients of linked texts
	also gets this message.
(async-deleted-text): Ditto.
(async-new-text): Ditto.
(async-new-recipient): Ditto.
(async-sub-recipient): Ditto.

	for Emacs.

	the documentation.

the system.

	on persons.
(Aux-Item Inheritance): New node.

	supervisor-only has no effect on items placed on the system.

recommended.

	set-connection-time-format request has been used.
(get-last-text): Ditto.
(set-connection-time-format): Change the status from experimental
	to recommended.

new aux-item file.  If there is a syntax error, the server will abort.
Test parsing of broken aux-items at runtime.

(Signals): Ditto.

	probability of one in a million.