1. 28 Sep, 2006 1 commit
    • Per Cederqvist's avatar
      Renamed the error code illegal-aux-item to illegal-aux-item-tag. · 147c0add
      Per Cederqvist authored
      Added error code 62=aux-exists, 63=aux-bad-object,
      64=illegal-aux-data, 65=aux-create-only, 66=aux-modify-only,
      67=aux-server-only, 68=aux-data-exists and 69=aux-no-such-text.
      Return proper error codes.  (Bug 192).
      * doc/Protocol-A.texi (Predefined Aux-Item Types): Renamed the
      error code illegal-aux-item to illegal-aux-item-tag.
      (create-text): Updated the error code section to mention the
      aux-related error codes illegal-aux-item-tag, aux-item-permission,
      aux-exists, aux-bad-object, illegal-aux-data, aux-modify-only,
      aux-server-only, aux-data-exists and aux-no-such-text instead of
      only illegal-aux-item and aux-item-permission.  Refer to the
      "Error Codes" node instead of duplicating the reasons here.
      (create-anonymous-text): Ditto.
      (create-conf): Ditto.
      (create-person): Ditto.
      (modify-text-info): Ditto, but with aux-create-only instead of
      aux-modify-only.
      (modify-conf-info): Ditto.
      (modify-system-info): Ditto.
      (Error Codes): Renamed error code 48 from illegal-aux-item to
      illegal-aux-item-tag, and redefine it to not include errors in the
      data.  Added error code 62=aux-exists, 63=aux-bad-object,
      64=illegal-aux-data, 65=aux-create-only, 66=aux-modify-only,
      67=aux-server-only, 68=aux-data-exists and 69=aux-no-such-text.
      * doc/Makefile.am (check-doc): Replaced the error code
      illegal-aux-item with illegal-aux-item-tag and
      illegal-aux-item-data.
      * src/include/kom-errno.h (enum kom_err): Renamed KOM_ILL_AUX to
      KOM_ILL_AUX_TAG.  Added KOM_AUX_EXISTS, KOM_AUX_BAD_OBJECT,
      KOM_ILL_AUX_DATA, KOM_AUX_CREATE_ONLY, KOM_AUX_MODIFY_ONLY,
      KOM_AUX_SERVER_ONLY, KOM_AUX_DATA_EXISTS and KOM_AUX_NO_SUCH_TEXT.
      * src/server/aux-items.c (aux_item_validate): Doc added.  Added
      missing punctuation in comments.  Set kom_errno to
      KOM_ILL_AUX_DATA instead of KOM_ILL_AUX when a regexp cannot be
      compiled or doesn't match an entry, or when a validator fails.
      (aux_item_add_perm): Document that kom_errno is set on failure.
      Do not modify kom_errno on success.  Track name change of
      KOM_ILL_AUX_TAG.  Set KOM_AUX_MODIFY_ONLY, KOM_AUX_CREATE_ONLY,
      KOM_AUX_SERVER_ONLY when appropriate (used to be KOM_AUX_PERM).
      Don't override the error code set by aux_item_check_unique() or
      aux_item_validate() when any of those check fails.
      (aux_item_check_unique): Set kom_errno to KOM_AUX_EXISTS or
      KOM_AUX_DATA_EXISTS on failure (used to sometimes be
      KOM_ILL_AUX).
      (text_stat_check_add_aux_item_list): Track name change of
      KOM_ILL_AUX_TAG.  Set kom_errno to KOM_AUX_BAD_OBJECT if the
      aux-item is not allowed on the active object (used to be
      KOM_AUX_PERM).
      (conf_stat_check_add_aux_item_list): Ditto.
      (system_check_add_aux_item_list): Ditto.
      (aux_item_validate_existing_text): Set kom_errno to
      KOM_AUX_NO_SUCH_TEXT instead of NO_SUCH_TEXT.  Set it to
      KOM_ILL_AUX_DATA if the text number is non-numeric.
      * src/server/testsuite/lyskomd.0/00.exp: Updated the expected
      error codes for aux-item-related errors.
      * src/server/testsuite/lyskomd.0/03.exp: Ditto.
      * src/server/testsuite/lyskomd.0/04.exp: Ditto.
      * src/server/testsuite/lyskomd.0/14.exp: Ditto.
      * src/server/testsuite/lyskomd.0/17.exp: Ditto.
      * src/server/testsuite/lyskomd.0/55.exp: Ditto.
      * src/server/testsuite/lyskomd.0/aux-items-cov.exp: Ditto.
      * src/server/testsuite/lyskomd.0/bug-572.exp: Ditto.
      * src/server/testsuite/lyskomd.0/20.exp: Ditto.  Remove the
      want_illegal_aux_item proc and simplify the code that checks the
      error codes.
      * src/server/testsuite/lyskomd.0/23.exp: Ditto.
      * src/server/testsuite/lyskomd.0/26.exp: Ditto.
      * src/server/testsuite/lyskomd.0/28.exp: Ditto.
      
      Added test cases for handling duplicate faq-text aux-items.
      * src/server/testsuite/lyskomd.0/21.exp: Added new tests that
      attempt to set duplicate faq-text aux-items on a conference in
      various ways, and removing it and re-adding it.  Also test adding
      two different faq-text aux-items at the same time.
      147c0add
  2. 06 Aug, 2006 4 commits
    • Per Cederqvist's avatar
      Comment fix. · fd3b89a7
      Per Cederqvist authored
      * src/server/aux-items.c (aux_item_validate): Fixed a typo in a
      comment.
      fd3b89a7
    • Per Cederqvist's avatar
      Code cleanup. · 8fae314b
      Per Cederqvist authored
      * src/server/aux-items.c (aux_item_check_unique): Removed bogus
      code that find_aux_item_definitions to be needlessly called.
      Force the caller to supply the definition, as all callers already
      do.
      8fae314b
    • Per Cederqvist's avatar
      Removed code with no effect. (Bug 142). · 146944b2
      Per Cederqvist authored
      * src/server/aux-items.c (aux_item_link_items): Removed assignment
      to a local variable that is not used after the assignment.
      146944b2
    • Per Cederqvist's avatar
      Removed bogus FIXME comments. (Bug 141). · 397fc353
      Per Cederqvist authored
      * src/server/aux-items.c (aux_item_link_items): Removed FIXME
      comment about bug 141.  Bug 141 is invalid.  The call to
      mark_text_as_changed is not redundant, since we must mark both the
      source and destination item as changed.
      397fc353
  3. 24 Apr, 2006 1 commit
    • Per Cederqvist's avatar
      Tell svn to ignore core files. · e37c8984
      Per Cederqvist authored
      * src/server/testsuite: Ignore core and vgcore.*.
      
      Replaced the "Client host" and "Client port" configuration file
      parameters with "Listen", and allow lyskomd to listen to more than
      one port.
      * doc/lyskomd.texi (Parameters): Replaced "Client host" and
      "Client port" with "Listen".
      * src/server/ramkomd.c (start_listen_sockets): New static
      function.  Listen to all the ports specified by the "Listen:"
      parameter.
      (server_init): Use start_listen_sockets() instead of calling
      isc_listentcp().  Removed the host and client_port arguments.  All
      callers updated.
      * src/server/testsuite/lyskomd.0/54.exp: New test suite.
      * src/server/conf-file.c (ctor_ipport_list): New static function.
      (dtor_ipport_list): New static function.
      (assign_ipport_list): New static function.
      (cf_ipport_list): New constant.
      * src/server/conf-file.h (struct ipport_entry): New struct.
      (struct ipport_list): New struct.
      (cf_ipport_list): New constant.
      * src/server/param.h (struct kom_par): Replaced "ip_client_host"
      and "ip_client_port" with "listen".
      * src/server/server-config.c (parameters): Ditto.
      * src/server/prot-a-parse-arg-c.awk: Include "conf-file.h" from
      the generated files.
      * src/server/admin.c: Include "conf-file.h".
      * src/server/aux-items.c: Ditto.
      * src/server/checkkomspace.c: Ditto.
      * src/server/conference.c: Ditto.
      * src/server/connections.c: Ditto.
      * src/server/dbck-cache.c: Ditto.
      * src/server/dbck.c: Ditto.
      * src/server/disk-end-of-atomic.c: Ditto.
      * src/server/komrunning.c: Ditto.
      * src/server/lockdb.c: Ditto.
      * src/server/membership.c: Ditto.
      * src/server/person.c: Ditto.
      * src/server/prot-a-output.c: Ditto.
      * src/server/prot-a-parse.c: Ditto.
      * src/server/prot-a.c: Ditto.
      * src/server/regex-match.c: Ditto.
      * src/server/rfc931.c: Ditto.
      * src/server/send-async.c: Ditto.
      * src/server/session.c: Ditto.
      * src/server/simple-cache.c: Ditto.
      * src/server/splitkomdb.c: Ditto.
      * src/server/text-garb.c: Ditto.
      * src/server/text.c: Ditto.
      * src/server/updateLysKOM.c: Ditto.
      * run-support/config: Removed the "Client port" setting.
      
      Adjust the test suite for the above change.
      * src/server/testsuite/lyskomd.0/bug-64.exp: Expect memory leaks
      due to bug 1599.
      * src/server/testsuite/lyskomd.0/53.exp: Expect a more informative
      error message when isc_listentcp fails.
      * src/server/testsuite/lyskomd.0/11.exp: Expect an IP address in
      the "Listening for clients" log message.
      * src/server/testsuite/config/unix.exp (clientport_2): New
      constant.
      (clientport_3): New constant.
      (lyskomd_start): New argument: listen_messages.  Use "Listen:"
      instead of "Client port:".
      (lyskomd_fail_start): Use "Listen:" instead of "Client port:".
      (client_start): New optional argument: port.
      e37c8984
  4. 25 Aug, 2003 1 commit
  5. 23 Aug, 2003 1 commit
  6. 20 Aug, 2003 3 commits
    • Per Cederqvist's avatar
      (find_linked_aux_item_list): Removed all traces of PERS_OBJECT_TYPE. · 199948cf
      Per Cederqvist authored
      (mark_linked_object_as_changed): Ditto.
      199948cf
    • Per Cederqvist's avatar
      (aux_item_validate_existing_text): Don't allow access to texts if you · e36e658c
      Per Cederqvist authored
      	are not logged in.  This change means that create-person
      	cannot accept aux-items with the existing-readable-text
      	validator if nobody is logged in.  I think this is more
      	reasonable than the number of special cases in the code that
      	were needed to support the old functionality.
      e36e658c
    • Per Cederqvist's avatar
      (aux_item_validate): Return Success, not Bool. All callers updated. · a39fe654
      Per Cederqvist authored
      (aux_item_add_perm): Removed the arguments item_creator,
      	object_creator and owner_check.  Added the arguments
      	creating_conn and subordinate.  All callers updated.
      	Simplified the code.  Use is_supervisor() instead of
      	is_strictly_supervisor() where appropriate.  Use the supplied
      	connection instead of checking that ACTPERS is the
      	item_creator.  Adjusted for the new contents of
      	Aux_item_validation_data.
      (aux_inherit_items): Removed arguments target_creator, creating and
      	object_type.  Added argument subordinate.  Changed type of
      	arguments object_no and object, since we know that they are a
      	Text_no and Text_stat, respectively.
      (filter_aux_item_list): Assert that the viewer_conn argument is
      	non-NULL.
      (check_delete_aux_item_list): Renamed the "owner" argument
      	"subordinate".
      (text_stat_check_add_aux_item_list): Removed the item_creator and
      	creating arguments.  Added the creating_conn argument, and
      	assert it is non-NULL.
      (conf_stat_check_add_aux_item_list): Replaced the "creator" argument
      	with "creating_conn".  Argument assertions added.
      (system_check_add_aux_item_list): Ditto.
      (aux_item_validate_existing_text): Changed return type from Bool to
      	Success.  Use person_text_read_access() only when necessary,
      	and add a comment explaining why it might happen.
      a39fe654
  7. 17 Aug, 2003 1 commit
  8. 16 Aug, 2003 4 commits
  9. 12 Aug, 2003 1 commit
  10. 12 Jul, 2003 2 commits
  11. 23 Oct, 2002 1 commit
  12. 05 Oct, 2002 1 commit
  13. 17 Aug, 2002 1 commit
  14. 10 Aug, 2002 2 commits
  15. 02 Aug, 2002 2 commits
  16. 11 Apr, 2002 1 commit
  17. 06 Apr, 2002 1 commit
  18. 30 Dec, 2001 2 commits
  19. 29 Dec, 2001 3 commits
  20. 28 Dec, 2001 3 commits
  21. 03 Nov, 2001 1 commit
  22. 28 Oct, 2001 1 commit
    • Per Cederqvist's avatar
      (simple_aux_item): Added a cast for the name. · 4c91113c
      Per Cederqvist authored
      (find_aux_item_definition): Added static modifier.
      (find_aux_item_index): Ditto.
      (aux_item_add_perm): Ditto.
      (find_aux_item): Ditto.
      (aux_item_trigger_mirror_faq): Ditto.
      (aux_item_trigger_link_item): Ditto.
      (aux_item_validate_existing_text): Ditto.
      (aux_item_trigger_mark_text): Ditto.
      (aux_item_trigger_unmark_text): Ditto.
      4c91113c
  23. 30 Sep, 2001 1 commit
  24. 22 Sep, 2001 1 commit