GitLab

	in the link.
	* src/server/text-store.h: New file, currently empty.
	* src/server/text-store.c: New file.  Include text-store.h, but do
	not yet do anything.
	* src/server/Makefile.am (DISKOBJS): Added text-store.c and
	text-store.h.
	(DBCK): Added text-store.c.

	* src/include/kom-types.h (Text_stat): Remove the reclamation
	field.  It was a mistake to add it 2006-11-06.
	* src/server/dbck-cache.c (cached_flush_text): Don't touch
	reclamation.
	* src/server/memory.c (copy_text_stat): Ditto.
	(init_text_stat): Ditto.
	* src/server/ram-output.c (foutput_text_stat_3): Ditto.
	* src/server/ram-parse.c (fparse_text_stat_3): Ditto.
	(fparse_text_stat_2): Ditto.
	(fparse_text_stat_0): Ditto.
	* src/server/simple-cache.c (cached_create_text): Ditto.

Added support for renaming a datafile once it has been completely
written, and to write it using a temporary extension.

* src/server/ram-io.h (struct dbfile): Added fields fn,
tmp_extension and tmp_fn.  Added documentation.
(dbfile_open_write): New argument: tmp_extension.
(dbfile_rename): New function.
(dbfile_abort): New function.
* src/server/ram-io.c (dbfile_new): Initialize fn, tmp_extension
and tmp_fn.
(current_fn): New static function.  Return tmp_fn if non-NULL,
otherwise fn.
(dbfile_delete): Free the new fields fn, tmp_extension and
tmp_fn.
(dbfile_open_write): New argument: tmp_extension.  Store a copy of
the supplied filename.  If tmp_extension is non-NULL, store a copy
of it, and compute the actual file name to open as the filname
followed by the tmp_extension.
(fsync_dirname): New static function.
(dbfile_rename): New function.  Rename the file from tmp_fn to the
wanted final filename, and sync the directory.
(dbfile_abort): New function.
* src/server/dbck-cache.c (cache_sync_all): Pass a NULL pointer as
tmp_extension of dbfile_open_write(), to get the old behavior.
* src/server/simple-cache.c (pre_sync): Ditto.

* src/server/ram-smalloc.c, src/include/server/smalloc.h:
(sstrdup): New function.

* src/server/ram-io.c (dbfile_open_read): New argument:
wanted_magic.  Log a message and return NULL if the file contains
the wrong magic cookie.  All callers updated to supply "CLEAN" as
the magic cookie.

This causes "make check" to fail quickly if running on an expect that
has broken handling of zero-lenght writes, or if expect is really,
really slow due to broken glob gate.

* src/server/testsuite/Makefile.am (check-l2g): Depend on
working-dejagnu.
(check-lyskomd): Ditto.
(check-leaks): Ditto.
(working-dejagnu): New target.
(EXTRA_DIST): Added dejagnu.0/00-zero-length-write.exp and
dejagnu.0/90-slow-glob-gate.exp.

* src/server/testsuite/dejagnu.0/00-zero-length-write.exp: New
test, that fails on known bad versions of expect.

* src/server/testsuite/dejagnu.0/90-slow-glob-gate.exp: New test,
that fails if a simple regexp pattern causes expect to run too
slow, indicating that it is converted to a glob pattern that
causes a lot of backtracking.

* src/server/testsuite/.gitignore: Ignore dejagnu.log and
dejagnu.sum.

* src/server/testsuite/Makefile.am (site.exp): Set use_dns to yes
or no depending on if adnshost can resolve 127.0.0.1 or not.
* src/server/testsuite/config/unix.exp (lyskomd_start): Set the
"Use DNS" configuration depending on the use_dns setting from
site.exp.

* doc/lyskomd.texi (Parameters): DNS has been unblocking since
version 2.1.0, so don't state that it blocks the server.

* doc/Protocol-A.texi: Don't use "@begin tex" instead of "@tex".  That
construct worked in texinfo.tex version 2003-11-16.09, but support was
removed in 2003-11-29.14.

* src/server/testsuite/timeval-overflow.c (main): Now a tiny bit more
portable.  This code still violates the C standard, but at least it
works as intended in gcc 4.4.1 now.  The old code was optimized to an
eternal loop. :-)

* src/server/testsuite/config/unix.exp (lyskomd_start): Turn on the
garb, unless the test case explicitly disables it.

* doc/lyskomd.texi (File Object Types): New node.
(File Types): New node.

* doc/lyskomd.texi (Hacking): Fill in descriptions in the menu.

* src/server/ram-io.c (set_output_format): Handle format 3.

* src/server/simple-cache.c (cached_create_text),
* src/server/text.c (do_create_text),
* src/server/testsuite/get-time-often.c (read_server): Fixed typos
in comments.

* src/server/ram-smalloc.c: Added a missing newline.

* src/server/testsuite/lyskomd.0/03.exp: Fix a race condition by
sleeping one second.

* src/server/ram-parse.c (fskipwhite): Don't unget EOF.

* doc/lyskomd.texi (Parameters): Changed "Garb" from "on" to
"off".
(Administration): Suggest that the administrator may want to turn
on the garb.
* src/server/server-config.c (parameters): Changed "Garb" from
"on" to "off".

* doc/lyskomd.texi (Files): The lyskomd.clients example line was
missing the third field.  Fix.

use them.
* src/server/ram-io.c, src/server/ram-io.h
(dbfile_putc): New function.
(dbfile_fputs): New function.
(dbfile_feof): New function.
(dbfile_ferror): New function.
* src/server/simple-cache.c (save_one_text): Use dbfile_ferror.
(sync_part): Ditto.
* src/server/ram-output.c (foutput_string): Use dbfile_putc.
(foutput_ulong): Ditto.
(foutput_atsign): Ditto.
(foutput_newline): Ditto.
(foutput_space): Ditto.
(foutput_bool): Ditto.
(foutput_array_start): Use dbfile_fputs.
(foutput_array_end): Ditto.
(foutput_array_nodata): Ditto.
* src/server/ram-io.c (dbfile_change_magic): Use dbfile_ferror.
* src/server/local-to-global.c (l2g_write): Use dbfile_putc.
* src/server/dbck-cache.c (init_cache): Use dbfile_feof().

that changes the state to dbfile_change_magic().  Reduce code
duplication by teaching foutput_header() to handle old file
formats.
* src/server/simple-cache.c (pre_sync): Adjusted to new API of
dbfile_open_write(), including removing calls to foutput_header().
(save_one_text): Extracted parts of the functionality to
dbfile_change_magic().
* src/server/ram-output.c (foutput_header): Moved support for file
formats 0, 1 and 2 here from sync_output_header().
* src/server/ram-io.c, src/server/ram-io.h
(dbfile_open_write): New argument: magic.  Write a file header
with the specified state.
(dbfile_change_magic): New function, extracted from
cache_sync_all() in dbck-cache.c and save_one_text().
* src/server/dbck-cache.c (sync_output_header): Removed.
The ability to emit old-style headers moved to foutput_header().
(cache_sync_all): Adjusted to new API of dbfile_open_write,
including removing calls to sync_output_header().  Use
dbfile_change_magic() instead of rewind() and
sync_output_header().
* src/server/Makefile.am (libcheck_a_SOURCES): Added
server-time.c.

* regex.c: Removed local variables setting for Emacs.

* mkmi (WANT_AUTOCONF): Set to 2.5, not 1.5.

* doc/Protocol-A.texi (The Misc-Info List): Document that it is up
to the server to convert bcc-recpt to cc-recpt or to ignore them,
when clients use an old-style request.  This agrees better with
the wordings in get-text-stat-old.