GitLab

be triggered by a broken aux-item definition file, so it was
mostly harmless.
* src/server/aux-item-def-parse.y (aux_item_def_check_trigger):
Don't free a string before using it.

valgrind.
* src/server/testsuite/lyskomd.supp: Added aid_lexer_2.
* src/server/testsuite/lyskomd.0/regexp-match-cov.exp (shutdown):
Don't expect any suppressed leaked blocks.
* src/server/testsuite/lyskomd.0/aux-items-cov.exp: Expect less
suppressed leaked blocks.
* src/server/testsuite/lyskomd.0/37.exp: Adjusted to new report
format when configuration errors are found.
* src/server/testsuite/lyskomd.0/conf-file-cov.exp: Ditto.
* src/server/simple-cache.c (free_all_cache): Close text_file and
file_a.
* src/server/testsuite/lyskomd.supp: Removed i_fopen-2.3.1 and
i_fopen-2.3.5, which were actually caused by the above problem.
* src/server/server-config.c (read_configuration): Check the
return value of read_config().  Free the configuration before
calling restart_kom if there are any problems with the
configuration.  Report the name of the configuation file if
problems are found.
* src/server/ramkomd.c (dump_exit_statistics): Call clear_info()
instead of free_kom_info.
(free_kom_info): Removed.  The new clear_info() function contains
a better implementation, with less code duplication.
* src/server/memory.c, src/server/kom-memory.h (clear_info): New
function.
* src/server/dbck.c (free_person_scratchpad): New static function.
(free_person_scratch): Ditto.
(main): Call free_person_scratch(), clear_info(),
free_configuration() and free_all_dbck_cache() when terminating to
make it possible to check for leaks with valgrind.
* src/server/dbck-cache.c, src/server/dbck-cache.h
(free_all_dbck_cache): New function.
* src/server/conf-file.c, src/server/conf-file.h (read_config):
Changed return type from void to Success.  Return FAILURE instead
of calling restart_kom when configuration errors are found.

* src/libraries/adns/src/event.c (adns_processreadable):
udpaddrlen should be a socklen_t, not int.

* src/libraries/adns/src/check.c: Include <stdlib.h>, which is
needed since abort() is used here.
* scripts/warnings.sed: gcc 3.4.3 uses 'foo' instead of `foo' to
mark identifiers.  Adjusted a few warnings that were found by
various Xenofarm machines.

(Commit of some files that were unsaved in previous commit.)

performing a pattern name match.  
* src/server/simple-cache.c: Removed obsolete comments.  Fixed
spelling errors in comments.
(find_matching_info_compare): Don't overflow if a Conf_no doesn't
fit in an int.
(find_matching_info): Removed obsolete comments (bug 172).
(rebuild_matching_info_entry): Added a comment that explains a
magic "2" in the code.
(build_matching_info): Use cached_no_of_existing_conferences()
instead of next_free_num when deciding how large temporary table
we need.  Reduce the number of loop induction variables.
(cached_lookup_name): Made code more readable by introducing a
temporary variable.

* src/server/testsuite/config/unix.exp (simple_expect): Log what
we are looking for and when we are done looking at verbosity level
2 and above.

* src/server/testsuite: Add locksuite.lock to svn:ignore.

allocating certain data structures.  (Bug 164).
* src/server/simple-cache.c (existing_confs): New static
variable.
(cached_no_of_existing_conferences): Return existing_confs,
instead of overestimating the number of conferences as
next_free_num.  (Bug 164).
(cached_create_conf): Increase existing_confs.
(cached_delete_conf): Decrease existing_confs.
(init_cache): Increase existing_confs when a new conference is
created.
(free_all_cache): Decrease existing_confs when conferences are
deallocated.
(dump_cache_mem_usage): Dump existing_confs.
* src/server/testsuite/config/unix.exp (check_memory_usage): Check
the dump of existing_confs.  Fail if allocated_strings or
allocated_blocks isn't found in the file.

memory, by removing the priority field of Matching_info.
* src/libraries/libcommon/parser.c (parse): Don't let the priority
influence the match.  The priority functionality was poorly
documented, not used by lyskomd, and made the code more complex.
* src/libraries/libcommon/parser.h (Matching_info): Removed the
priority field, which is no longer used.
* src/server/simple-cache.c (rebuild_matching_info_entry): Don't
initialize the priority field.
(build_matching_info): Ditto.

* src/libraries/libcommon/parser.c (parse): Code cleanup: get rid
of one level of indentation, and avoid using multiple ways to get
to the next iteration of the main loop.

the server to crash.  (Bug 1403).
* src/server/connections.c (check_idle_callback): Don't crash if
isc_enable() fails.  Emit the session number in the log, mostly
for debug purposes.

* scripts: Add depcomp, install-sh, mdate-sh, missing,
mkinstalldirs and texinfo.tex to svn:ignore.
* src/libraries/adns: Add depcomp, missing,  and mkinstalldirs to
svn:ignore.
* src/libraries/libisc-new: Add depcomp to svn:ignore.
* src/libraries/liboop: Add depcomp, install-sh, missing and
mkinstalldirs to svn:ignore.

Sten who reported the bug and proposed an alternate fix.
* src/server/connections.c (login_request): Don't hang if the "Use
DNS" option is false.  (Bug 1318).  Log a warning message if
isc_resolve_remote() fails.
(src/server/testsuite/lyskomd.0/bug-1318.exp): New file.  Test the
"Use DNS: off" configuration option.

checkkomspace was not built early enough.  Also, the test suite
should not fail on platforms that don't support fsusage.c.
* src/server/Makefile.am (CHECKKOMSPACE): New empty variable.
Append checkkomspace$(EXEEXT) to it if we HAVE_FSUSAGE.
(check-lyskomd): Depend on $(CHECKKOMSPACE).
(check-recursive): Ditto.
* src/server/testsuite/lyskomd.0/50.exp: Report "unsupported" if
checkkomspace is not built.  (Don't fail with fatal errors.)

* src/server/testsuite/lyskomd.0/11.exp: Handle the message that
is emitted when the debug calls are disabled.  That message was
introduced 2004-07-21; apparently, nobody has used the test suite
without debug calls since then.

copyright statement.

Some minor code refactoring.

that the output queue fills up properly.

(new_client): Ditto.

	client is disabled by disable_client.
(may_read_more): New method, extracted from read_from_connection.
	Return false if disabled by disable_client.
(should_be_disabled): New method, extracted from read_from_connection
	and check_idle_callback. Return true if disabled by
	disable_client.
(read_from_connection): Simplified code by using may_read_more and
	should_be_disabled.
(check_idle_callback): Simplified code by using should_be_disabled.
(disable_client): New debug request.