lyskom-elisp-client issueshttps://git.lysator.liu.se/groups/lyskom-elisp-client/-/issues2020-08-10T06:53:57Zhttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/9Use mailcap to display (some) non-text content2020-08-10T06:53:57ZDavid ByersUse mailcap to display (some) non-text contentThe mailcap library can display content based on MIME type. See e.g. `eww-display-pdf` for an example of how. This could replace custom code to display non-text types.The mailcap library can display content based on MIME type. See e.g. `eww-display-pdf` for an example of how. This could replace custom code to display non-text types.https://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/13Clean up NOCOMPAT comments2020-08-10T06:49:43ZDavid ByersClean up NOCOMPAT commentsComments with `NOCOMPAT` have been added to questionable code that needs reviewing and more thorough testing. Check these towards the end of developing the nocompat branch.Comments with `NOCOMPAT` have been added to questionable code that needs reviewing and more thorough testing. Check these towards the end of developing the nocompat branch.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/10Update envcheck.el2020-08-08T09:31:36ZDavid ByersUpdate envcheck.el* Remove check for w3
* Remove check for custom and widget
* Add check for emacs version* Remove check for w3
* Remove check for custom and widget
* Add check for emacs versionDavid ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/11Replace lyskom-princ2020-08-07T19:36:03ZDavid ByersReplace lyskom-princThe function `lyskom-princ` is used to insert text with text properties at a marker. Replace it with something like this:
(defun lyskom-insert-at (string marker)
(save-excursion (goto-char marker) (insert string)))
The existi...The function `lyskom-princ` is used to insert text with text properties at a marker. Replace it with something like this:
(defun lyskom-insert-at (string marker)
(save-excursion (goto-char marker) (insert string)))
The existing code is far too complex.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/8Replace w3 with eww2020-08-07T18:47:57ZDavid ByersReplace w3 with ewwFor in-line formatting of HTML texts. Check the ugly cases, such as setting background color and "forgetting" a closing tag.
This code renders html:
(eww-display-html 'utf-8 base-url
(libxml-parse-html-region (point-min) (p...For in-line formatting of HTML texts. Check the ugly cases, such as setting background color and "forgetting" a closing tag.
This code renders html:
(eww-display-html 'utf-8 base-url
(libxml-parse-html-region (point-min) (point-max))
(point-min)
(current-buffer))
Check for the presense of `libxml-parse-html-region`.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/2Re-implement URL handling2020-08-07T18:47:55ZDavid ByersRe-implement URL handlingWhen the code for opening web links was written, support for browsing the web was very new in Emacs. Rewrite it all to rely on the standard functions. Remove lyskom-specific customization.
Remove support for w3 that is a pain to maintai...When the code for opening web links was written, support for browsing the web was very new in Emacs. Rewrite it all to rely on the standard functions. Remove lyskom-specific customization.
Remove support for w3 that is a pain to maintain since w3 has not been updated since 2008.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/12Review the magic minibuffer2020-08-07T18:47:29ZDavid ByersReview the magic minibufferReview all the code that goes in to the magic minibuffer in `utilities.el` starting at:
;;; ============================================================
;;; Magic that allows us to clear the initial value in the
;;; minibuff...Review all the code that goes in to the magic minibuffer in `utilities.el` starting at:
;;; ============================================================
;;; Magic that allows us to clear the initial value in the
;;; minibuffer when the user types a character.
For `nocompat` simplify the advice so it only works in Gnu Emacs. Consider using before-change-functions (mentioned in the comment) instead. There may be an ancient checkin that does this (and that crashed Emacs 20.7).David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/6Use define-error to define errors2020-08-06T15:25:44ZDavid ByersUse define-error to define errorsInstead of setting the error properties manually. Look for `error-conditions` and `error-message`.Instead of setting the error properties manually. Look for `error-conditions` and `error-message`.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/1Remove backwards compatibility2020-08-06T15:08:32ZDavid ByersRemove backwards compatibilitySuggestion: remove backwards compatibility to XEmacs and Gnu Emacs prior to 24.x or 25.x or something like that.Suggestion: remove backwards compatibility to XEmacs and Gnu Emacs prior to 24.x or 25.x or something like that.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/14Emacs 28.0.50 decode-time error "Invalid time specification"2020-08-06T12:22:20ZKent EngströmEmacs 28.0.50 decode-time error "Invalid time specification"I did a quick test with Emac 28.0.50 (master branch from yesterday) and could login but not read a text, failing at
(decode-time '(24361 35390 nil))
...I did a quick test with Emac 28.0.50 (master branch from yesterday) and could login but not read a text, failing at
(decode-time '(24361 35390 nil))
from lyskom-calculate-day-diff from lyskom-format-time from lyskom-view-text.
The error is (error "Invalid time specification")
and seems to be due to the function no longer accepting exactly type of arguments used.
26.3:
The optional TIME should be a list of (HIGH LOW . IGNORED),
as from ‘current-time’ and ‘file-attributes’, or nil to use the
current time. It can also be a single integer number of seconds since
the epoch. The obsolete form (HIGH . LOW) is also still accepted.
28.0.50:
The optional TIME is the time value to convert. See
‘format-time-string’ for the various forms of a time value.
and there
A time value that is omitted or nil stands for the current time,
a number stands for that many seconds, an integer pair (TICKS . HZ)
stands for TICKS/HZ seconds, and an integer list (HI LO US PS) stands
for HI*2**16 + LO + US/10**6 + PS/10**12 seconds. This function
treats seconds as time since the epoch of 1970-01-01 00:00:00 UTC.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/16Get rid of elib-string2020-08-06T11:30:23ZDavid ByersGet rid of elib-stringRemove `elib-string.el` from the sources. `string-replace-match` can be replaced by `replace-regexp-in-string` and `string-split` by `split-string`.Remove `elib-string.el` from the sources. `string-replace-match` can be replaced by `replace-regexp-in-string` and `string-split` by `split-string`.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/15Background faces do not extend to edge in emacs 272020-08-06T11:14:01ZDavid ByersBackground faces do not extend to edge in emacs 27As reported in 24032669:
```
En ändring i emacs-27 (ur NEWS)
** New face attribute ':extend' to control face extension at EOL.
The new face attribute ':extend' controls whether to use the face for
displaying the empty space beyond e...As reported in 24032669:
```
En ändring i emacs-27 (ur NEWS)
** New face attribute ':extend' to control face extension at EOL.
The new face attribute ':extend' controls whether to use the face for
displaying the empty space beyond end of line (EOL) till the edge of
the window.
...
Gör att highligtning av text-body blir ful (fyller inte ut till
fönsterkanten)
Jag har fixat det för mej själv så här
(set-face-attribute 'kom-face--dashed-lines-face nil :extend t)
(set-face-attribute 'kom-face--text-body-face nil :extend t)
```David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/7Get rid of string-as-unibyte2020-08-05T16:00:04ZDavid ByersGet rid of string-as-unibyteEmacs sez:
lyskom.el:64214:23:Warning: ‘string-as-unibyte’ is an obsolete function (as of
26.1); use ‘encode-coding-string’.Emacs sez:
lyskom.el:64214:23:Warning: ‘string-as-unibyte’ is an obsolete function (as of
26.1); use ‘encode-coding-string’.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/5Use declare to declare indent and debug spec2020-08-05T15:44:29ZDavid ByersUse declare to declare indent and debug specReplace things like this:
(put 'lyskom-traverse-aux 'edebug-form-spec '(sexp form body))
(put 'lyskom-traverse 'lisp-indent-hook 2)
with:
(declare (debug (sexp form body)) (indent 2))
in the definition.Replace things like this:
(put 'lyskom-traverse-aux 'edebug-form-spec '(sexp form body))
(put 'lyskom-traverse 'lisp-indent-hook 2)
with:
(declare (debug (sexp form body)) (indent 2))
in the definition.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/3Eliminate compatibility.el2020-08-05T13:37:04ZDavid ByersEliminate compatibility.elEliminate the file "compatibility.el" and fix/rewrite/delete all code that relies on it.Eliminate the file "compatibility.el" and fix/rewrite/delete all code that relies on it.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/4Clean redundant code from macros.el2020-08-05T13:36:54ZDavid ByersClean redundant code from macros.elThe file macros.el contains macros that exist, like `when` and `unless`. Get rid of them.The file macros.el contains macros that exist, like `when` and `unless`. Get rid of them.David ByersDavid Byers