.simplify 3.66 KB
Newer Older
Niels Möller's avatar
Niels Möller committed
1
2
3
4
5
6
7
8
abstract_compress.h done
abstract_crypto.h done
abstract_io.h done
algorithms.h done
alist.h done
atoms.h done
bignum.h done

Niels Möller's avatar
Niels Möller committed
9
blocking_write.h (done)
Niels Möller's avatar
Niels Möller committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28

  Used only by lsh-keygen.c. Should be deleted.

channel.h

  struct channel_open_info should perhaps be used more, or deleted.

  should the write attribute be removed from ssh_channel?

  Perhaps introduce an channel_global_request_info analogous to
  channel_request_info. 

  Change the fallbacks (used by the gateway), to pass the entire
  packets.
  
channel_commands.h done
charset.h done
client.h done
client_keyexchange.h done
Niels Möller's avatar
Niels Möller committed
29
client_pty.h (done)
Niels Möller's avatar
Niels Möller committed
30
31
32

  Move the declaration of make_pty_request to client.h.
  
Niels Möller's avatar
Niels Möller committed
33
client_session.h (done)
Niels Möller's avatar
Niels Möller committed
34
35
36
37
38
39
40
41
42
43

  Move the declaration of make_client_session to client.h
  
client_userauth.h done

command.h

  Do we need both catch_command and catch_report?

  Delete make_delay_continuation.
Niels Möller's avatar
Niels Möller committed
44
45

  Review the collect_info_n abstraction.
Niels Möller's avatar
Niels Möller committed
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
  
compress.h done
connection.h

  Delete the CONNECTION_SRP flag and all related code.
  
connection_commands.h

  Delete make_connection_if_srp.
  
crypto.h done
daemon.h

  daemon_close is not used.
  
debug.h done

digits.h

  simple_decode_base64 is not used.
  
disconnect.h

  Perhaps move somewhere else.

dsa.h done

encrypt.h

  Perhaps move?

exception.h

  Why the name EXC_SERVICE?

  We don't need both EXC_PAUSE_READ/EXC_PAUSE_CONNECTION and
  EXC_PAUSE_START_READ/EXC_PAUSE_START_CONNECTION.
  
format.h

  NUL-terminate all strings.
  
gateway.h done

gateway_channel.h

  Use channel_open_info

  Keep less state, try forwarding requests and replies by just
  patching the channel-numbers.
  
gateway_commands.h done
gc.h done
handshake.h

  Perhaps remove ssh1_fallback?
  
interact.h done

io.h

  kill_fd() and close_fd() does the same thing. Delete kill_fd.
  
io_commands.h

  IO_READ_STDIN and IO_WRITE_FILE is used only by lsh-writekey.
  CONNECT_PORT unused.
  make_simple_listen used only by lsh_proxy.c.
  
jpoll.h done
keyexchange.h

  Ignore weak-keys issues.
  
list.h done
lookup_verifier.h done
lsh.h

  Delete LSH_ALLOC_STACK and STACK_HEADER. Delete NUL_TERMINATED, we
  need some other function for checking for valid C strings (i.e check
  that there are no NUL:s inside the string).
  
lsh_argp.h done
lsh_types.h done
memxor.h done
pad.h

  Move declaration of make_packet_pad somewhere else.

parse.h done
parse_macros.h done
proxy.h done
proxy_agentforward.h done
proxy_session.h done
proxy_tcpforward.h done
proxy_userauth.h done
proxy_x11forward.h done
publickey_crypto.h done
queue.h done

randomness.h

  Clean up the number of different generators.

read_data.h

  Move declaration of make_read_data somewhere else.

read_file.h

  Move declarations somewhere else?
  
read_line.h done

read_packet.h

  Move declaration somewhere else?

reaper.h done
resource.h done
rsa.h done 

server.h

  Move declaration?
  
server_authorization.h

  Move declaration?
  
server_keyexchange.h done
server_pty.h done
server_session.h done
server_userauth.h done

Niels Möller's avatar
Niels Möller committed
181
sexp.h (done)
Niels Möller's avatar
Niels Möller committed
182
183

  Remove traces of cons.
Niels Möller's avatar
Niels Möller committed
184
  Remove SEXP_SET
Niels Möller's avatar
Niels Möller committed
185
186
187
188
189
190
191
192
193
194
195
196
  
sexp_commands.h

  Change read_sexp to not use the complex streamed parser.
  
sexp_parser.h done
spki.h done

spki_commands.h

  SPKI_READ_ACLS is not used.
  
Niels Möller's avatar
Niels Möller committed
197
198
199
200
201
202
srp.h done
ssh1_fallback.h done
string_buffer.h done
tcpforward.h done
tcpforward_commands.h done

Niels Möller's avatar
Niels Möller committed
203
translate_signal.h
Niels Möller's avatar
Niels Möller committed
204
205
206
207

  Obsoleted by later draft. Now signals should be sent as strings, not
  numbers.
  
Niels Möller's avatar
Niels Möller committed
208
tty.h
Niels Möller's avatar
Niels Möller committed
209
210
211

  Use terminal_dimensions from interact.h.
  
Niels Möller's avatar
Niels Möller committed
212
unpad.h
Niels Möller's avatar
Niels Möller committed
213
214
215
216
217
218

  Move declaration?
  
userauth.h done
version.h done
werror.h done
Niels Möller's avatar
Niels Möller committed
219
write_buffer.h
Niels Möller's avatar
Niels Möller committed
220
221
222
223
224

  Rename write_buffer_alloc to make_write_buffer.

  Change the conventions for write_buffer_pre_write?

Niels Möller's avatar
Niels Möller committed
225
xalloc.h
Niels Möller's avatar
Niels Möller committed
226
227

  Make lsh_object_alloc and lsh_object_free static.