ChangeLog 12.1 KB
Newer Older
Niels Möller's avatar
Niels Möller committed
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
2003-02-23  Niels Moller  <nisse@carduelis>

	* dc.c (lsftp_dc_r_isdir): Adapted to new sftp_attrib argument to
	lsftp_do_stat. 
	* commands.c (get_file_or_folder, com_chown, com_chgrp): Likewise.

	* dc.h: Deleted the posixperms field, and replaced it with two
	fields, has_permissions and permissions. That way we don't need
	to compare (unsigned) mode_t:s to the special constant -1.

	* sftp_bind.h (struct lsftp_callback): Deleted stat pointer.

	* sftp_bind.c (lsftp_do_stat): Use a struct sftp_attrib for
	reporting the result, not a struct stat.
	(lsftp_handle_stat): Just copy the sftp_attrib struct, don't try
	converting it to a struct stat.

	* configure.ac: Use LSH_GCC_ATTRIBUTES.

	* Use uint32_t and friends instead of UINT32.

22
23
24
25
2003-02-17  Niels Mller  <niels@s3.kth.se>

	* configure.ac: Deleted initial newline in readline warning.

26
27
28
29
30
2003-02-11  Niels Mller  <niels@s3.kth.se>

	* sftp_c.c (sftp_get_file_main): Added an explicit cast to kludge
	around a bug in the constification.

31
32
33
34
35
2002-11-07  Pontus Skld  <pont@soua.net>

	* rl.c (lsftp_rl_completion): Bugfix: Don't free memory for every
	command checked.

36
37
38
39
40
2002-07-29  Pontus Skld  <pont@soua.net>

	* configure.ac: Take advantage of lshg now understanding -G (pass
	-G by default if compiling with lsh).

41
42
43
44
2002-07-18  Niels Mller  <niels@s3.kth.se>

	* configure.ac: Don't use -ggdb3 with gcc-2.96.

45
46
2002-06-27  Pontus Skld  <pont@soua.net>

47
48
49
50
51
52
	* commands.c (com_mv): Use lsftp_dc_endglob instead of freeing the
	strings in the glob.
	(com_chown): Dito.
	(put_file_or_folder): Cleaned up types of variables used.
	(get_file_or_folder): Dito.

53
54
55
56
57
58
59
	* sftp_bind.c (lsftp_do_cd): Pass a char** to lsftp_do_realpath.

	* sftp_bind.h: lsftp_do_realpath takes a char** destptr, not const
	char**.

	* sftp_bind.c (lsftp_do_realpath): Dito.
	
Pontus Freyhult's avatar
Pontus Freyhult committed
60
61
2002-06-27  Pontus Skld  <Pontus.Skold@dis.uu.se>

62
63
64
	* commands.c (com_umask): Do an explicit cast of the parameter to
	isdigit.

Pontus Freyhult's avatar
Pontus Freyhult committed
65
	* str_utils.c (lsftp_s_strtok): Don't use strndup.
66
	(lsftp_s_strtok): Removed unused variable.
Pontus Freyhult's avatar
Pontus Freyhult committed
67

Pontus Freyhult's avatar
Pontus Freyhult committed
68
69
70
71
72
2002-06-27  Pontus Skld  <pont@soua.net>

	* commands.h: Include gnu_stuff.h to get declaration for
	canonicalize_file_name compability function.

Niels Möller's avatar
Niels Möller committed
73
74
75
76
2002-06-25  Niels Mller  <niels@s3.kth.se>

	* gnu_stuff.c (help_option): Deleted spuriuos comma.

77
78
79
80
81
2002-06-25  Pontus Skld  <pont@soua.net>

        * gnu_stuff.c (help_option): Added note about where to report
        bugs.

82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
2002-06-06  Pontus Skld  <pont@soua.net>

	* commands.c (com_lpwd): Don't assume getcwd with extended
	functionality, use 8192 as a fallback if PATH_MAX is undefined.

	* configure.ac: Check for canonicalize_file_name.

	* commands.c (get_file_or_folder): Use canonicalize_file_name
	instead of realpath.
	(put_file_or_folder): Dito.

	* gnu_stuff.c: Added compability function for systems without
	canonicalize_file_name.

	* gnu_stuff.h: Declaration of compability function.

2002-06-05  Pontus Skld  <pont@soua.net>

	* str_utils.h: Changed declaration of lsftp_s_strtok, take a
	char** to fill in with a new allocated string instead of a buffer
	and it's length.

	* str_utils.c (lsftp_s_strtok): See above.

	* commands.c: Changed to use the new lsftp_s_strtok.

	* rl.c (lsftp_rl_completion): Dito.

	* sftp_bind.c (lsftp_open_connection): Dito.

Pontus Freyhult's avatar
Pontus Freyhult committed
112
113
2002-05-26  Pontus Skld  <pont@soua.net>

Pontus Freyhult's avatar
Pontus Freyhult committed
114
115
116
117
	* rl.c (lsftp_rl_remotefile_generator):
	Bugfix. lsftp_unqualify_path returns a pointer into the given
	string. We can't free that.

Pontus Freyhult's avatar
Pontus Freyhult committed
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
	* commands.c (com_cd): Glob absolute paths only.
	(com_rm): Dito.
	(com_get): Dito.
	(com_mv): Dito.

2002-05-25  Pontus Skld  <pont@soua.net>

	* rl.c (lsftp_rl_remotefile_generator): (Hopefully) fixed
	completion to behave correctly. Always glob on absolute path and
	make them relative if neccessary when returning them.

	* sftp_bind.c (lsftp_path_is_absolute): New function.

	* sftp_bind.h: Declaration.

Pontus Freyhult's avatar
Pontus Freyhult committed
133
134
135
136
2002-05-23  Pontus Skld  <pont@soua.net>

	* sftp_bind.c (lsftp_do_ls): Bail out if globbing failed.

Pontus Freyhult's avatar
Pontus Freyhult committed
137
138
2002-05-15  Pontus Skld  <pont@soua.net>

Pontus Freyhult's avatar
Pontus Freyhult committed
139
140
141
142
143
	* commands.c (get_file_or_folder): Removed debug message.

	* dc.c (lsftp_dc_r_startglob): Remove lsftp_unqualify_path calls,
	I wonder why I thought they should be there from the beginning.

Pontus Freyhult's avatar
Pontus Freyhult committed
144
145
146
147
148
149
150
151
152
153
154
155
156
	* commands.c (com_longhelp): New function (almost identical to the
	old help function, just ignore the visible bit). Cosmetic fix at
	the same time (an empty line inserted before the help for a
	command).
	(com_help): Rewrote to just display all available commands in
	short form (if called without arguments). If arguments are given,
	leave it to longhelp.

	* commands.h: New function com_longhelp.

	* commands.c: Added longhelp entry to available commands, changed
	text for help.

Niels Möller's avatar
Niels Möller committed
157
158
159
160
2002-05-06  Niels Mller  <niels@s3.kth.se>

	* configure.ac (CFLAGS): Don't enable -Waggregate-return.

Niels Möller's avatar
Niels Möller committed
161
162
2002-05-05  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
163
164
	* acconfig.h: Deleted file.

Niels Möller's avatar
Niels Möller committed
165
166
167
	* configure.ac: Pass no arguments to AM_INIT_AUTOMAKE. Use the
	three-argument form of AC_DEFINE.

Niels Möller's avatar
Niels Möller committed
168
169
170
171
2002-05-05  Niels Mller  <nisse@cuckoo.hack.org>

	* configure.ac: Update for automake-1.6.

Pontus Freyhult's avatar
Pontus Freyhult committed
172
173
174
175
176
177
178
2002-04-02  Pontus Skld  <pont@soua.net>

	* sftp-server.c (sftp_process_readdir): Include up to
	MAX_DIRENTS_PER_REQUEST files in response to a single
	SSH_FXP_READDIR. Should (and seems to) speed up directory 
	traversal dramatically.
	
Niels Möller's avatar
Niels Möller committed
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
2002-03-27  Niels Mller  <nisse@cuckoo.hack.org>

	* werror.c (_fatal): New function.

	* sftp.h (SFTP_MAX_PACKET): New constant.

	* sftp-test-client.c: Replaced FATAL with calls of fatal.
	* sftp_bind.c: Likewise.

	* sftp-server.c: Define the werror_program_name constant. Replaced
	FATAL with calls of fatal.

	* buffer.c: Moved the definitions of struct sftp_input and struct
	sftp_output, and selected functions, to separate files io_input
	and io_output. The code left in this file does not depend on the
	details of those structs.

	* Makefile.am (shared_src): New make variable listing
	source files used by all clients and servers. Added io_input and
	io_output. 

	* io.h (sftp_make_output): New file with declarations that doesn't
	fit in buffer.h, in particular the constructors for sftp_input and
	sftp_output. 

	* lsftp.c: Include werror.h, and define
	werror_program_name. 

	* io_output.c: New file, with all the functions that need to knwo
	about the internals of struct sftp_output.
	* io_input.c: New file, with all the functions that need to knwo
	about the internals of struct sftp_input.

	* misc_fun.c (FATAL): Deleted function, use the fatal
	function in werror.c instead.

Pontus Freyhult's avatar
Pontus Freyhult committed
215
216
2002-03-26  Pontus Skld  <pont@soua.net>

Pontus Freyhult's avatar
Pontus Freyhult committed
217
218
219
220
	* sftp-server.c (MAX_DIRENTS_PER_REQUEST): New constant, the
	maximum number of directory entries to include in response to one
	SSH_FXP_READDIR.

Pontus Freyhult's avatar
Pontus Freyhult committed
221
222
223
224
225
226
	* buffer.c (sftp_read_packet): Cosmetic fixes and a bugfix (if
	sftp_get_data returns -1, it's not ok).

	* gnu_stuff.c (help_option): Added an help text. It needs work but
	is (hopefully) better than nothing.

Pontus Freyhult's avatar
Pontus Freyhult committed
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
2002-03-25  Pontus Skld  <pont@soua.net>

	* buffer.c (sftp_read_packet): Loop to read data.
	(sftp_get_data): Likewise.
	(sftp_write_packet): Loop to write data.

	* sftp_c.c (sftp_ls_main): Check return values from
	sftp_get_string.

	* sftp-test-client.c (fork_server): Use fds, not FILE*s.

	* sftp-server.c (sftp_init): Use fds, not FILE*s.
	(main): Use fds STDIN_FILENO and STDOUT_FILENO instead of FILE*s
	stdin and stdout.

	* buffer.c: We need unistd.h to have read and write defined. And
	we want errno to, so we need errno.h
	(sftp_make_input): Use fd, not FILE*
	(sftp_make_output): Likewise.	

	* sftp_bind.c (lsftp_close_connection): Use fd_to_transport and
	fd_from_transport instead of to_transport and from_transport.

	* configure.ac (CPPFLAGS): use AC_DEFINE_UNQUOTED instead of
	putting options for before and after in CPPFLAGS. Solves problem
	with spaces in before- and after-opts.
 
	* sftp_bind.c (lsftp_open_connection): Dont't use FILE* but fds
	directly.
	(lsftp_handshake): Use read instead of fread, and pass fds to
	sftp_make_input and sftp_make_output.

	* buffer.c (struct sftp_input): Use fd instead of FILE*.
	(struct sftp_output): Likewise.
	(sftp_get_data): Use read instead of fread.
	(sftp_read_packet): Likewise.
	(sftp_write_packet): Use write instead of fwrite.

	* buffer.h: Changed prototype of sftp_make_input and
	sftp_make_output to use fds instead of files.

Pontus Freyhult's avatar
Pontus Freyhult committed
268
269
2002-03-24  Pontus Skld  <pont@soua.net>

Pontus Freyhult's avatar
Pontus Freyhult committed
270
271
272
	* configure.ac: Added --no-pty to default options if we're using
	lsh(g).

Pontus Freyhult's avatar
Pontus Freyhult committed
273
274
	* commands.c (com_quit): Only call com_close if connected.

Pontus Freyhult's avatar
Pontus Freyhult committed
275
276
277
278
2002-03-23  Pontus Skld  <pont@soua.net>

	* configure.ac: Removed -G from default after options.

Pontus Freyhult's avatar
Pontus Freyhult committed
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
2002-03-23  Pontus Skld  <pont@it.uu.se>

	* configure.ac (termcap): Added check for libtermcap. This should
	help systems with a dynamically linked libreadline that depends on
	libtermcap.

2002-03-21  Pontus Skld  <pont@soua.net>

	* configure.ac: Almost completely rewrote the checks for readline
	and history, now actually uses the results of the library checks.

	* rl.c: Use WITH_READLINE and WITH_HISTORY instead of header
	existence.
	
	* rl.h: Use <readline.h> and <history.h> if available.

Pontus Freyhult's avatar
Pontus Freyhult committed
295
296
297
298
299
2002-03-19  Pontus Skld  <pont@it.uu.se>

	* Makefile.am: sftp-server should go to sbin (or should it go to
	libexec? Not bin anyway).

Niels Möller's avatar
Niels Möller committed
300
301
302
2002-03-18  Niels Mller  <nisse@lysator.liu.se>

	* commands.c (com_umask): Use unsigned char.
303
304
	(com_chown): Likewise.
	(com_chgrp): Likewise.
Niels Möller's avatar
Niels Möller committed
305
306
	(handle_command): Unsigned char argument.

Pontus Freyhult's avatar
   
Pontus Freyhult committed
307
308
309
310
311
312
2002-03-14  Pontus  <pont@it.uu.se>

	* configure.ac: Changed version number from 1.0 to 1.0-pre to make
	sure noone thinks "to highly" of the code. Also removed debug code
	that shouldn't have been checked in.

Niels Möller's avatar
Niels Möller committed
313
314
315
316
2002-02-27  Niels Mller  <nisse@cuckoo.hack.org>

	* gnu_stuff.c: Include stdlib.h and string.h.

317
318
2002-02-25  Pontus  <pont@it.uu.se>

319
320
321
322
323
324
325
	* lsftp.c (main): Readded support for GNU-thingies (was lost
	somehow some time ago).

	* gnu_stuff.c (lsftp_welcome): Included Niels in welcome message.
	(version_option): dito.
	(do_gnu_stuff): New function to check for GNU-thingies.
	
326
327
328
329
	* configure.ac: Added ugly fix to detect if we're part of the main
	lsh distribution. If we are, assume $bindir/lshg works
	satisfactionary.
	
330
331
332
333
334
335
336
337
338
339
340
341
342
343
	* sftp_bind.c (lsftp_install_lsftp_cb): Return a pointer to the
	callback instead.
	(lsftp_do_rm): Adopted for new use of lsftp_install_lsftp_cb.
	(lsftp_do_get): dito.
	(lsftp_do_ls): dito.
	(lsftp_do_chmod): dito.
	(lsftp_do_mv): dito.
	(lsftp_do_realpath): dito.
	(string_comparer): Changed type for arguments from char** to const
	void*.

	* sftp_bind.h: Changed return type of lsftp_install_lsftp_cb from
	int to struct lsftp_callback*.

344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
	* sftp_bind.c (lsftp_lsftp_cb_init): Fixed a bug using the same
	memory both for sftp_cbs and lsftp_cbs, mumble!

2002-02-24  Pontus  <pont@it.uu.se>

	* sftp_bind.c (lsftp_remove_lsftp_cb): Use lsftp_nullcb to clean
	out callback.
	(lsftp_handle_packet): Changed variable i (used twice) to r.

	* sftp_bind.h: New function lsftp_nullcb.

	* sftp_bind.c (lsftp_compact_sftp_cbs): Fixed a bug that would
	loose callbacks before a hole if there were any more.
	(lsftp_compact_lsftp_cbs): Fixed the same bug for struct
	lsftp_callbacks.
	(lsftp_handle_packet): Clean out old state after callbacks, should
	hopefully make things more robust.

	(lsftp_nullcb): New function to clean a struct lsftp_callback.

	* dc.c (lsftp_dc_init): Check that malloc succeeded before using
	the memory (duh!).
	
	* sftp_bind.c: Removed obsolete default callback array sizes.

	* dc.c: Removed obsolete default dircache size.

	* lsftp.c (main): Always init the callbacks.

	* sftp_bind.c (lsftp_lsftp_cb_init): Also clear option flags.

	* lsftp.c (main): Added some comments.

	* sftp_bind.c (lsftp_do_put): Added some comments.

379
380
381
382
383
2002-02-22  Pontus  <pont@it.uu.se>

	* configure.ac (lsh_cv_c_attribute): Removed obsolete checks for
	behaviour of stat and lstat.

384
385
386
387
388
2002-02-12  Pontus  <pont@it.uu.se>

	* commands.c (com_mv): Didn't properly check for error in return value of
	lsftp_dc_r_isdir.

389
390
2002-02-11  Pontus  <pont@it.uu.se>

391
392
393
394
395
396
397
	* sftp-server.c (sftp_process_realpath): Added deugging message.
	(sftp_process): Added debugging message.
	(sftp_process_symlink): Added debugging message.

	* buffer.c (sftp_read_packet): If called with data left, flush
	(read and throw away) remaining data.

398
399
400
401
402
	* configure.ac: Created new configure.ac as a merge of the
	configure.in from lsftp and the sftp package.

	* Started new Changelog in sftp.