server.c 16.5 KB
Newer Older
Niels Möller's avatar
Niels Möller committed
1 2
/* server.c
 *
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 *
 *
 * $Id$ */

/* lsh, an implementation of the ssh protocol
 *
 * Copyright (C) 1998 Niels Mller
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation; either version 2 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
Niels Möller's avatar
Niels Möller committed
24 25 26 27 28
 */

#include "server.h"

#include "abstract_io.h"
29
#include "channel.h"
30
#include "connection.h"
Niels Möller's avatar
Niels Möller committed
31 32
#include "debug.h"
#include "format.h"
33 34 35
#include "keyexchange.h"
#include "read_line.h"
#include "read_packet.h"
Niels Möller's avatar
Niels Möller committed
36
#include "reaper.h"
37
#include "ssh.h"
Niels Möller's avatar
Niels Möller committed
38
#include "translate_signal.h"
Niels Möller's avatar
Niels Möller committed
39
#include "unpad.h"
40
#include "version.h"
Niels Möller's avatar
Niels Möller committed
41 42 43
#include "werror.h"
#include "xalloc.h"

Niels Möller's avatar
Niels Möller committed
44 45 46 47
#ifndef _GNU_SOURCE
#warning _GNU_SOURCE undefined
#endif

48 49 50 51 52 53 54
#include <assert.h>
#include <string.h>
#include <errno.h>

#include <sys/types.h>
#include <sys/socket.h>

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
struct server_callback
{
  struct fd_callback super;
  struct io_backend *backend;

  struct signer *secret;        /* secret key */
  struct lsh_string *host_key;  /* public key */
  UINT32 block_size;
  char *id_comment;

  struct randomness *random;
  struct make_kexinit *init;
  struct packet_handler *kexinit_handler;
};

Niels Möller's avatar
Niels Möller committed
70
static int server_initiate(struct fd_callback **c,
Niels Möller's avatar
Niels Möller committed
71 72
			   int fd)
{
Niels Möller's avatar
Niels Möller committed
73 74
  struct server_callback *closure = (struct server_callback *) *c;
  
75 76 77
  struct ssh_connection *connection
    = make_ssh_connection(closure->kexinit_handler);

Niels Möller's avatar
Niels Möller committed
78 79
  int res;
  
80
  verbose("server_initiate()\n");
Niels Möller's avatar
Niels Möller committed
81 82 83 84 85 86 87 88

  connection_init_io(connection,
		     io_read_write(closure->backend, fd,
				   make_server_read_line(connection),
				   closure->block_size,
				   make_server_close_handler()),
		     closure->random);

Niels Möller's avatar
Niels Möller committed
89 90
  
  connection->server_version
Niels Möller's avatar
Niels Möller committed
91
    = ssh_format("SSH-%lz-%lz %lz",
Niels Möller's avatar
Niels Möller committed
92 93 94
		 PROTOCOL_VERSION,
		 SOFTWARE_SERVER_VERSION,
		 closure->id_comment);
Niels Möller's avatar
Niels Möller committed
95

Niels Möller's avatar
Niels Möller committed
96 97
  res = A_WRITE(connection->raw,
		 ssh_format("%lS\r\n", connection->server_version));
98
  if (LSH_CLOSEDP(res))
Niels Möller's avatar
Niels Möller committed
99 100
    return res;

101 102 103
  return res | initiate_keyexchange(connection, CONNECTION_SERVER,
				    MAKE_KEXINIT(closure->init),
				    NULL);
Niels Möller's avatar
Niels Möller committed
104 105 106 107 108 109 110 111
}

struct server_line_handler
{
  struct line_handler super;
  struct ssh_connection *connection;
};

Niels Möller's avatar
Niels Möller committed
112
static struct read_handler *do_line(struct line_handler **h,
Niels Möller's avatar
Niels Möller committed
113 114 115
				    UINT32 length,
				    UINT8 *line)
{
Niels Möller's avatar
Niels Möller committed
116 117
  struct server_line_handler *closure = (struct server_line_handler *) *h;
  
Niels Möller's avatar
Niels Möller committed
118 119
  MDEBUG(closure);
  
Niels Möller's avatar
Niels Möller committed
120 121 122 123 124
  if ( (length >= 4) && !memcmp(line, "SSH-", 4))
    {
      /* Parse and remember format string */
      if ((length >= 8) && !memcmp(line + 4, "2.0-", 4))
	{
Niels Möller's avatar
Niels Möller committed
125 126 127
	  struct read_handler *new = make_read_packet
	    (make_packet_unpad
	     (make_packet_debug(&closure->connection->super,
128
				"recieved")),
Niels Möller's avatar
Niels Möller committed
129
	     closure->connection);
Niels Möller's avatar
Niels Möller committed
130 131
	  
	  closure->connection->client_version
Niels Möller's avatar
Niels Möller committed
132
	    = ssh_format("%ls", length, line);
Niels Möller's avatar
Niels Möller committed
133

Niels Möller's avatar
Niels Möller committed
134 135 136 137 138
	  verbose("Client version: ");
	  verbose_safe(closure->connection->client_version->length,
		       closure->connection->client_version->data);
	  verbose("\n");
	  
Niels Möller's avatar
Niels Möller committed
139
	  /* FIXME: Cleanup properly. */
Niels Möller's avatar
Niels Möller committed
140
	  lsh_object_free(closure);
Niels Möller's avatar
Niels Möller committed
141 142 143 144 145 146 147 148 149

	  return new;
	}
      else
	{
	  werror("Unsupported protocol version: ");
	  werror_safe(length, line);
	  werror("\n");

Niels Möller's avatar
Niels Möller committed
150
	  /* FIXME: Clean up properly */
Niels Möller's avatar
Niels Möller committed
151
	  lsh_object_free(closure);
Niels Möller's avatar
Niels Möller committed
152 153
	  *h = 0;
		  
Niels Möller's avatar
Niels Möller committed
154 155 156 157 158 159 160 161 162 163 164 165
	  return 0;
	}
    }
  else
    {
      /* Display line */
      werror_safe(length, line);

      /* Read next line */
      return 0;
    }
}
Niels Möller's avatar
Niels Möller committed
166

Niels Möller's avatar
Niels Möller committed
167
struct read_handler *make_server_read_line(struct ssh_connection *c)
Niels Möller's avatar
Niels Möller committed
168
{
Niels Möller's avatar
Niels Möller committed
169 170 171
  struct server_line_handler *closure;

  NEW(closure);
Niels Möller's avatar
Niels Möller committed
172 173
  
  closure->super.handler = do_line;
Niels Möller's avatar
Niels Möller committed
174
  closure->connection = c;
Niels Möller's avatar
Niels Möller committed
175 176 177 178
  
  return make_read_line(&closure->super);
}

179 180 181 182
struct fd_callback *
make_server_callback(struct io_backend *b,
		     char *comment,
		     UINT32 block_size,
Niels Möller's avatar
Niels Möller committed
183 184
		     struct randomness *random,
		     struct make_kexinit *init,
185
		     struct packet_handler *kexinit_handler)
Niels Möller's avatar
Niels Möller committed
186
{
Niels Möller's avatar
Niels Möller committed
187 188 189
  struct server_callback *connected;

  NEW(connected);
Niels Möller's avatar
Niels Möller committed
190 191 192 193 194

  connected->super.f = server_initiate;
  connected->backend = b;
  connected->block_size = block_size;
  connected->id_comment = comment;
195

Niels Möller's avatar
Niels Möller committed
196 197
  connected->random = random;  
  connected->init = init;
198
  connected->kexinit_handler = kexinit_handler;
Niels Möller's avatar
Niels Möller committed
199 200 201 202
  
  return &connected->super;
}

203
static int server_die(struct close_callback *closure, int reason)
Niels Möller's avatar
Niels Möller committed
204
{
205 206 207 208
  verbose("Connection died, for reason %d.\n", reason);
  if (reason != CLOSE_EOF)
    werror("Connection died.\n");

Niels Möller's avatar
Niels Möller committed
209 210 211
  return 0;  /* Ignored */
}

212
struct close_callback *make_server_close_handler(void)
Niels Möller's avatar
Niels Möller committed
213
{
Niels Möller's avatar
Niels Möller committed
214 215 216
  struct close_callback *c;

  NEW(c);
Niels Möller's avatar
Niels Möller committed
217 218 219 220 221 222

  c->f = server_die;

  return c;
}

223 224 225 226 227 228 229 230 231 232
/* Session */
struct server_session
{
  struct ssh_channel super;

  /* User information */
  struct unix_user *user;

  /* Non-zero if a shell or command has been started. */
  int running;
Niels Möller's avatar
Niels Möller committed
233 234

  /* Child process's stdio */
Niels Möller's avatar
Niels Möller committed
235
  struct io_fd *in;
Niels Möller's avatar
Niels Möller committed
236 237
  struct io_fd *out;
  struct io_fd *err;
238 239
};

Niels Möller's avatar
Niels Möller committed
240 241 242 243 244 245 246 247 248 249 250
/* Recieve channel data */
static int do_recieve(struct ssh_channel *c,
		      int type, struct lsh_string *data)
{
  struct server_session *closure = (struct server_session *) c;
  
  MDEBUG(closure);

  switch(type)
    {
    case CHANNEL_DATA:
Niels Möller's avatar
Niels Möller committed
251
      return A_WRITE(&closure->in->buffer->super, data);
Niels Möller's avatar
Niels Möller committed
252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
    case CHANNEL_STDERR_DATA:
      werror("Ignoring unexpected stderr data.\n");
      lsh_string_free(data);
      return LSH_OK | LSH_GOON;
    default:
      fatal("Internal error!\n");
    }
}

/* We may send more data */
static int do_send(struct ssh_channel *c)
{
  struct server_session *closure = (struct server_session *) c;

  MDEBUG(closure);

  closure->out->on_hold = 0;
  closure->err->on_hold = 0;
  
  return LSH_OK | LSH_GOON;
}

274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293
struct ssh_channel *make_server_session(struct unix_user *user,
					UINT32 max_window,
					struct alist *request_types)
{
  struct server_session *self;

  NEW(self);

  init_channel(&self->super);

  self->super.max_window = max_window;
  self->super.rec_window_size = max_window;

  /* FIXME: Make maximum packet size configurable. */
  self->super.rec_max_packet = SSH_MAX_PACKET;

  self->super.request_types = request_types;
  self->user = user;

  self->running = 0;
Niels Möller's avatar
Niels Möller committed
294 295 296 297

  self->in = NULL;
  self->out = NULL;
  self->err = NULL;
298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326
  
  return &self->super;
}

struct open_session
{
  struct channel_open super;

  struct unix_user *user;
  struct alist *session_requests;
};

#define WINDOW_SIZE (SSH_MAX_PACKET << 3)

static struct ssh_channel *do_open_session(struct channel_open *c,
					   struct simple_buffer *args,
					   UINT32 *error,
					   char **error_msg,
					   struct lsh_string **data)
{
  struct open_session *closure = (struct open_session *) c;
  
  MDEBUG(closure);

  debug("server.c: do_open_session()\n");
  
  if (!parse_eod(args))
    return 0;
  
Niels Möller's avatar
Niels Möller committed
327 328
  return make_server_session(closure->user, WINDOW_SIZE,
			     closure->session_requests);
329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
}

struct channel_open *make_open_session(struct unix_user *user,
				       struct alist *session_requests)
{
  struct open_session *closure;

  NEW(closure);

  closure->super.handler = do_open_session;
  closure->user = user;
  closure->session_requests = session_requests;
  
  return &closure->super;
}

struct server_connection_service
{
  struct unix_service super;

  struct alist *global_requests;

  /* Requests specific to session channels */
  struct alist *session_requests; 

  /* FIXME: Doesn't support any channel types but "session".
   * This must be fixed to support for "direct-tcpip" channels. */
};

/* Start an authenticated ssh-connection service */
static struct ssh_service *do_login(struct unix_service *c,
				    struct unix_user *user)
{
  struct server_connection_service *closure
    = (struct server_connection_service *) c;

  MDEBUG(closure);

  debug("server.c: do_login()\n");
  
  return
    make_connection_service(closure->global_requests,
			    make_alist(1, ATOM_SESSION,
				       make_open_session(user,
							 closure->session_requests),
				       -1),
			    NULL);
}

struct unix_service *make_server_session_service(struct alist *global_requests,
						 struct alist *session_requests)
{
  struct server_connection_service *closure;

  NEW(closure);

  closure->super.login = do_login;
  closure->global_requests = global_requests;
  closure->session_requests = session_requests;
  
  return &closure->super;
}

Niels Möller's avatar
Niels Möller committed
392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429
struct lsh_string *format_exit_signal(struct ssh_channel *channel,
				      int core, int signal)
{
  struct lsh_string *msg = ssh_format("Process killed by %z.", strsignal(signal));
  
  return format_channel_request(ATOM_EXIT_SIGNAL,
				channel,
				0,
				"%i%c%fS%z",
				signal_local_to_network(signal),
				core,
				msg, "");
}

struct lsh_string *format_exit(struct ssh_channel *channel, int value)
{
  return format_channel_request(ATOM_EXIT_STATUS,
				channel,
				0,
				"%i", value);
}
      
struct exit_shell
{
  struct exit_callback super;

  struct server_session *session;
};

static void do_exit_shell(struct exit_callback *c, int signaled,
			  int core, int value)
{
  struct exit_shell *closure = (struct exit_shell *) c;
  struct server_session *session = closure->session;
  struct ssh_channel *channel = &session->super;
  
  MDEBUG(closure);
  MDEBUG(session);
430 431 432 433

  /* FIXME: Should we explicitly mark these files for closing?
   * The io-backend should notice EOF anyway. */
#if 0
Niels Möller's avatar
Niels Möller committed
434 435 436
  close_fd(session->in);
  close_fd(session->out);
  close_fd(session->err);
437
#endif
Niels Möller's avatar
Niels Möller committed
438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475
  
  if (!(channel->flags & CHANNEL_SENT_EOF)
      /* Don't send eof if the process died violently. */
      && !signaled)
    {
      int res = channel_eof(channel);
      if (LSH_CLOSEDP(res))
	/* FIXME: Can we do anything better with the return code than
	 * ignore it? */
	return;
    }

  if (!(channel->flags & CHANNEL_SENT_CLOSE))
    {
      int res = A_WRITE(channel->write,
			signaled
			? format_exit_signal(channel, core, value)
			: format_exit(channel, value));
      res = channel_close(channel);
      /* FIXME: Can we do anything better with the return code than
       * ignore it? */
      
      return;
    }
}

static struct exit_callback *make_exit_shell(struct server_session *session)
{
  struct exit_shell *self;

  NEW(self);

  self->super.exit = do_exit_shell;
  self->session = session;

  return &self->super;
}

476 477 478 479 480
struct shell_request
{
  struct channel_request super;

  struct io_backend *backend;
Niels Möller's avatar
Niels Möller committed
481
  struct reap *reap;
482 483 484 485 486 487 488 489 490 491 492
};

/* Creates a one-way socket connection. Returns 1 on successm 0 on
 * failure. fds[0] is for reading, fds[1] for writing (like for the
 * pipe() system call). */
static int make_pipe(int *fds)
{
  /* From the shutdown(2) man page */
#define REC 0
#define SEND 1

Niels Möller's avatar
Niels Möller committed
493 494 495 496 497 498 499 500 501 502 503 504 505 506
  if (socketpair(AF_UNIX, SOCK_STREAM, 0, fds) < 0)
    {
      werror("socketpair() failed: %s\n", strerror(errno));
      return 0;
    }
  debug("Created socket pair. Using fd:s %d <-- %d\n", fds[0], fds[1]);

  if(shutdown(fds[0], SEND) < 0)
    {
      werror("shutdown(%d, SEND) failed: %s\n", fds[0], strerror(errno));
      return 0;
    }
  if (shutdown(fds[1], REC) < 0)
    {
507
      werror("shutdown(%d, REC) failed: %s\n", fds[0], strerror(errno));
Niels Möller's avatar
Niels Möller committed
508 509 510
      return 0;
    }
  return 1;
511 512
#undef REC
#undef SEND
513 514 515 516
}

static char *make_env_pair(char *name, struct lsh_string *value)
{
517
  return ssh_format("%lz=%lS%c", name, value, 0)->data;
518 519 520 521
}

static char *make_env_pair_c(char *name, char *value)
{
522
  return ssh_format("%lz=%lz%c", name, value, 0)->data;
523 524 525 526 527 528 529 530 531 532
}

static int do_spawn_shell(struct channel_request *c,
			  struct ssh_channel *channel,
			  int want_reply,
			  struct simple_buffer *args)
{
  struct shell_request *closure = (struct shell_request *) c;
  struct server_session *session = (struct server_session *) channel;

Niels Möller's avatar
Niels Möller committed
533 534 535
  int in[2];
  int out[2];
  int err[2];
536 537

  MDEBUG(closure);
Niels Möller's avatar
Niels Möller committed
538
  MDEBUG(session);
539 540 541 542 543 544 545 546

  if (!parse_eod(args))
    return LSH_FAIL | LSH_DIE;

  if (session->running)
    /* Already spawned a shell or command */
    goto fail;
  
Niels Möller's avatar
Niels Möller committed
547 548
  /* {in|out|err}[0] is for reading,
   * {in|out|err}[1] for writing. */
549

Niels Möller's avatar
Niels Möller committed
550
  if (make_pipe(in))
551
    {
Niels Möller's avatar
Niels Möller committed
552
      if (make_pipe(out))
553
	{
Niels Möller's avatar
Niels Möller committed
554
	  if (make_pipe(err))
555 556 557 558 559 560 561 562 563 564
	    {
	      pid_t child;
	      
	      switch(child = fork())
		{
		case -1:
		  werror("fork() failed: %s\n", strerror(errno));
		  /* Close and return channel_failure */
		  break; 
		case 0:
565
		  { /* Child */
566 567 568 569 570 571
		    char *shell = session->user->shell->data;
#define MAX_ENV 7
		    char *env[MAX_ENV];
		    char *tz = getenv("TZ");
		    int i = 0;

572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
		    int old_stderr;
		    
		    debug("do_spawn_shell: Child process\n");

		    if (!session->user->shell)
		      {
			werror("No login shell!\n");
			exit(EXIT_FAILURE);
		      }

		    if (getuid() != session->user->uid)
		      if (!change_uid(session->user))
			{
			  werror("Changing uid failed!\n");
			  exit(EXIT_FAILURE);
			}
		    
		    assert(getuid() == session->user->uid);
		    
		    if (!change_dir(session->user))
		      {
			werror("Could not change to home (or root) directory!\n");
			exit(EXIT_FAILURE);
		      }

		    debug("Child: Setting up environment.\n");
		    
599 600 601 602 603 604 605 606 607 608 609 610 611
		    env[i++] = make_env_pair("LOGNAME", session->user->name);
		    env[i++] = make_env_pair("USER", session->user->name);
		    env[i++] = make_env_pair("SHELL", session->user->shell);
		    if (session->user->home)
		      env[i++] = make_env_pair("HOME", session->user->home);
		    if (tz)
		      env[i++] = make_env_pair_c("TZ", tz);

		    /* FIXME: The value of $PATH should not be hard-coded */
		    env[i++] = "PATH=/bin:/usr/bin";
		    env[i++] = NULL;
		    
		    assert(i <= MAX_ENV);
612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677
#undef MAX_ENV

		    debug("Child: Environment:\n");
		    for (i=0; env[i]; i++)
		      debug("Child:   '%s'\n", env[i]);
		    
		    /* Close all descriptors but those used for
		     * communicationg with parent. We rely on the
		     * close-on-exec flag for all fd:s handled by the
		     * backend. */
		    
#if 0
		    close(STDIN_FILENO);
#endif
		    if (dup2(in[0], STDIN_FILENO) < 0)
		      {
			werror("Can't dup stdin!\n");
			exit(EXIT_FAILURE);
		      }
		    close(in[0]);
		    close(in[1]);
		    
#if 0
		    close(STDOUT_FILENO);
#endif
		    if (dup2(out[1], STDOUT_FILENO) < 0)
		      {
			werror("Can't dup stdout!\n");
			exit(EXIT_FAILURE);
		      }
		    close(out[0]);
		    close(out[1]);

		    if ((old_stderr = dup(STDERR_FILENO)) < 0)
		      werror("Couldn't safe old file_no.\n");
		    io_set_close_on_exec(old_stderr);

		    debug("Child: Duping stderr (bye).\n");
		    
#if 0
		    close(STDERR_FILENO);
#endif
		    if (dup2(err[1], STDERR_FILENO) < 0)
		      {
			/* Can't write any message to stderr. */ 
			exit(EXIT_FAILURE);
		      }
		    close(err[0]);
		    close(err[1]);
		    
		    execle(shell, shell, NULL, env);

		    /* exec failed! */
		    {
		      int exec_errno = errno;

		      if (dup2(old_stderr, STDERR_FILENO) < 0)
			{
			  /* This is really bad... We can't restore stderr
			   * to report our problems. */
			  char msg[] = "child: execle() failed!\n";
			  write(old_stderr, msg, sizeof(msg));
			}
		      else
			debug("Child: execle() failed (errno = %d): %s\n",
			      exec_errno, strerror(exec_errno));
678 679

		      exit(EXIT_FAILURE);
680
		    }
681 682 683 684
#undef MAX_ENV
		  }
		default:
		  /* Parent */
Niels Möller's avatar
Niels Möller committed
685 686 687 688 689

		  debug("Parent process\n");

		  REAP(closure->reap, child, make_exit_shell(session));
		  
690
		  /* Close the child's fd:s */
Niels Möller's avatar
Niels Möller committed
691 692
		  close(in[0]);
		  close(out[1]);
Niels Möller's avatar
Niels Möller committed
693
		  close(err[1]);
694

Niels Möller's avatar
Niels Möller committed
695
		  session->in
Niels Möller's avatar
Niels Möller committed
696
		    = io_write(closure->backend, in[1],
Niels Möller's avatar
Niels Möller committed
697 698
				SSH_MAX_PACKET,
				/* FIXME: Use a proper close callback */
Niels Möller's avatar
Niels Möller committed
699
				make_channel_close(channel));
Niels Möller's avatar
Niels Möller committed
700 701 702 703 704 705 706 707 708 709 710 711
		  session->out
		    = io_read(closure->backend, out[0],
			      make_channel_read_data(channel),
			      NULL);
		  session->err
		    = io_read(closure->backend, err[0],
			      make_channel_read_stderr(channel),
			      NULL);

		  channel->recieve = do_recieve;
		  channel->send = do_send;
		  
712 713 714 715 716 717 718
		  session->running = 1;
		  return want_reply
		    ? A_WRITE(channel->write,
			      format_channel_success(channel->channel_number))
		    : LSH_OK | LSH_GOON;
		  
		}
Niels Möller's avatar
Niels Möller committed
719 720
	      close(err[0]);
	      close(err[1]);
721
	    }
Niels Möller's avatar
Niels Möller committed
722 723
	  close(out[0]);
	  close(out[1]);
724
	}
Niels Möller's avatar
Niels Möller committed
725 726
      close(in[0]);
      close(in[1]);
727 728 729 730 731 732 733
    }
 fail:
  return want_reply
    ? A_WRITE(channel->write, format_channel_failure(channel->channel_number))
    : LSH_OK | LSH_GOON;
}

Niels Möller's avatar
Niels Möller committed
734 735
struct channel_request *make_shell_handler(struct io_backend *backend,
					   struct reap *reap)
736 737 738 739 740
{
  struct shell_request *closure;

  NEW(closure);
  closure->super.handler = do_spawn_shell;
Niels Möller's avatar
Niels Möller committed
741
  closure->backend = backend;
Niels Möller's avatar
Niels Möller committed
742
  closure->reap = reap;
Niels Möller's avatar
Niels Möller committed
743
  
744 745 746
  return &closure->super;
}