ChangeLog 220 KB
Newer Older
1
2
3
4
5
2004-10-20  Niels Mller  <niels@s3.kth.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): Disable dependency
	tracking for gcc-2.

Niels Möller's avatar
Niels Möller committed
6
7
8
9
10
2004-10-20  Niels Mller  <nisse@lysator.liu.se>

	* .bootstrap: Link install-sh, texinfo.tex, COPYING and INSTALL
	into the nettle subdir.

Niels Möller's avatar
Niels Möller committed
11
12
13
14
15
16
17
18
2004-10-19  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): New macro.
	(LSH_MAKE_CONDITIONAL): New macro.

	* .bootstrap: In the nettle subdir, link acinclude.m4 as
	aclocal.m4, not acinclude.m4.

Niels Möller's avatar
Niels Möller committed
19
20
21
2004-10-08  Niels Mller  <niels@s3.kth.se>

	* src/client_userauth.c (do_userauth_info_request): Enforce limits
Niels Möller's avatar
Niels Möller committed
22
23
	on the length of name and instruction. Prepend the name and an
	empty line to the instruction.
Niels Möller's avatar
Niels Möller committed
24
25
26
27
28
29
30
31
32

	* src/unix_interact.c (unix_dialog): Deleted instruction argument,
	display dialog->instruction instead.

	* src/interact.h (interact_dialog): New instruction attribute.
	(INTERACT_DIALOG): Deleted instruction argument.
	* src/interact.c (make_interact_dialog): Initialize
	self->instruction to NULL.

Niels Möller's avatar
Niels Möller committed
33
34
2004-10-07  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
35
36
37
38
39
40
	* src/lsh-writekey.c (main_argp_parser): When --server is given,
	don't use encryption by default.

	* src/testsuite/login-auth-test (LSHD_FLAGS): Use --login-shell
	instead of --login-program.

Niels Möller's avatar
Niels Möller committed
41
42
	* doc/lsh.texinfo: Updated for version 1.5.6.

Niels Möller's avatar
Niels Möller committed
43
44
	* src/lshd.c (make_lshd_options): New default: Enable X11
	forwarding.
Niels Möller's avatar
Niels Möller committed
45
	(main_options): Deleted broken --login-program option.
Niels Möller's avatar
Niels Möller committed
46
47
48
49
50
51
52
53
54
55
56
57
58
59

	* src/lsh-writekey.c (make_lsh_writekey_options): New default:
	Encrypt private key using aes256-cbc.

	* src/lsh-keygen.c (make_lsh_keygen_options): New default:
	Generate RSA keys.

	* src/testsuite/keygen-1-test: Pass -c none to lsh-writekey.
	* src/testsuite/keygen-2-test: Likewise.
	* src/testsuite/lsh-decrypt-key-test: Likewise.
	* src/testsuite/setup-env: Likewise.
	* src/testsuite/write-key-1-test: Likewise.
	* src/testsuite/write-key-2-test: Likewise.
	
Niels Möller's avatar
Niels Möller committed
60
61
62
63
2004-10-06  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/Makefile.am (EXTRA_DIST): Added UTF-8-test.txt.

Niels Möller's avatar
Niels Möller committed
64
65
2004-10-05  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
66
67
68
69
70
71
72
73
74
	* src/Makefile.am (GPERF_FLAGS): Added -k21, to distinguish
	diffie-hellman-group1-sha1 and diffie-hellman-group2-sha1.

	* src/lsh.c (main_argp_parser): Support "diffie-hellman-group2-sha1".
	* src/lshd.c (main_argp_parser): Likewise.

	* src/atoms.in (diffie-hellman-group2-sha1): New name, for now an
	alias to diffie-hellman-group14-sha1.

Niels Möller's avatar
Niels Möller committed
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
	* src/testsuite/inetd-test: Start lshd with --daemon --no-syslog.
	Note that this test is not yet enabled, and inetd mode not working.

	* src/parse.c (parse_utf8): Keep track of the length of invalid
	sequences. Moved the check for overlong sequences, not it's done
	after the complete sequence is processed.

	* src/charset.c (low_utf8_to_local): If utf8_tolerant is set,
	replace invalid utf8 sequences with '?'. Used mainly by the
	testsuite. 

	* src/charset.h (enum utf8_flag): New flag utf8_tolerant.

	* src/testsuite/utf8-test.c: New test program.
	* src/testsuite/Makefile.am (TS_PROGS): Added utf8-test.
	* src/testsuite/UTF-8-test.txt: Markus Kuhn's utf8 testfile.

	* src/testsuite/functions.sh: Added -q to LSHD_FLAGS again.

Niels Möller's avatar
Niels Möller committed
94
95
2004-10-02  Niels Mller  <nisse@lysator.liu.se>

96
97
	* src/daemon.c (daemon_started_by_inetd): More debug output.

Niels Möller's avatar
Niels Möller committed
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
	Implemented client-side "keyboard-interactive".
	* src/unix_interact.c (unix_read_password): Split off...
	(read_password): New function, reads password and doesn't free
	prompt. 
	(unix_dialog): New function.

	* src/ssh.h (SSH_MSG_USERAUTH_INFO_REQUEST) 
	(SSH_MSG_USERAUTH_INFO_RESPONSE): New constants.

	* src/server_password.c (do_authenticate): Disallow control
	characters in user names.
	* src/server_userauth.c (do_none_preauth): Likewise.
	* src/server_publickey.c (do_authenticate): Likewise.

	* src/parse.c (parse_utf8): New argument *utf8_length. Treat
	overlong sequences surrigates and the non-characters 0xfffe and
	0xffff as errors.

	* src/lsh.c (make_lsh_login): Use keyboard-interactive, if the
	other methods fail.

Niels Möller's avatar
Niels Möller committed
119
120
121
	* src/scm/gaba.scm (make-freer): Free elements of allocated
	arrays, i.e. variables of type "space".

Niels Möller's avatar
Niels Möller committed
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
	* src/interact.h (interact_dialog): New class. 
	(INTERACT_DIALOG): New method.

	* src/interact.c (make_interact_dialog): New function.

	* src/debug.c (do_debug): Censor packets of type
	SSH_MSG_USERAUTH_INFO_RESPONSE. 

	* src/client_userauth.c (client_password_method): Renamed class
	to...
	(client_userauth_interactive_method): ... Used for both "password"
	and "keyboard-interactive".
	(format_userauth_kbdinteract, format_userauth_info_response): New
	functions.
	(client_kbdinteract_state, userauth_info_request_handler): New
	classes.
	(do_userauth_info_request, make_userauth_info_request_handler)
	(do_kbdinteract_failure, make_client_kbdinteract_state)
	(do_kbdinteract_login, make_client_kbdinteract_auth): New
	functions.

	* src/atoms.in: Added "keyboard-interactive". 

	Changes to utf8 decoding.
	* src/charset.h (enum utf8_flag): New enum.

	* src/charset.c (utf8_to_local, low_utf8_to_local): Implemented
	control character fitlering. Replaced STRICT argument with two
	flags utf8_replace and utf8_paranoid.
	(ucs4_is_control): New function.
	(local_is_utf8): Deleted function.

	* src/werror.c (werror_vformat): Improved utf8 handling. Always
	convert with utf8_replace, and add utf8_paranoid in paranoia mode.
	
Niels Möller's avatar
Niels Möller committed
157
158
159
160
2004-09-22  Niels Mller  <niels@s3.kth.se>

	* acinclude.m4 (LSH_CCPIC): Don't use -fpic on cygwin.

Niels Möller's avatar
Niels Möller committed
161
162
163
164
2004-08-31  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_CCPIC): New macro.

Niels Möller's avatar
Niels Möller committed
165
166
167
168
2004-07-16  Niels Mller  <nisse@lysator.liu.se>

	* src/client.c (do_background_process): Fixed C99-ism.

Niels Möller's avatar
Niels Möller committed
169
170
2004-06-22  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
171
172
	* src/parse.c (parse_utf8): Use unsigned variables.

Niels Möller's avatar
Niels Möller committed
173
174
	* src/testsuite/inetd-test: New test case, not yet enabled.

Niels Möller's avatar
Niels Möller committed
175
176
177
178
179
2004-06-17  Niels Mller  <nisse@lysator.liu.se>

	* src/parse.c (parse_utf8): Check that the buffer doesn't end in
	the middle of an utf8 sequence.

Niels Möller's avatar
Niels Möller committed
180
181
2004-06-15  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
182
183
184
	* src/version.h (SOFTWARE_SLOGAN): New macro; string appended to
	the software version in the initial handshake.

Niels Möller's avatar
Niels Möller committed
185
186
187
188
189
190
	* src/lsh.c (main_argp_parser): Added support for
	diffie-hellman-group14-sha1. 
	* src/lshd.c (main_argp_parser): Likewise.

	* src/dh_exchange.c (make_dh14): New function.

Niels Möller's avatar
Niels Möller committed
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
	* src/publickey_crypto.c (zn_member): Deleted unused method.
	(zn_range, zn_invert, zn_mul, zn_exp, zn_exp_ui, zn_add, zn_sub):
	Non-static functions replaces the GROUP_COMBINE etc methods.
	(make_group_zn, make_ring_zn): Deleted functions...
	(make_ssh_group): ... replaced by new funtion.
	(make_ssh_group1, make_ssh_ring_srp_1): Use make_ssh_group.
	(make_ssh_group14): New function.

	* src/publickey_crypto.h (abstract_group): Deleted class and
	methods.
	(zn_group): Declare class here, and plain functions for using it.
	Replaced all uses of struct abstract_group with const struct
	zn_group.
	(dh_instance): Use const for the dh_method pointer.
	
	* src/atoms.in: Added diffie-hellman-group14-sha1.

Niels Möller's avatar
Niels Möller committed
208
209
2004-06-12  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
210
211
	* configure.ac: Bumped version to 1.5.6.

Niels Möller's avatar
Niels Möller committed
212
213
	* Released lsh-1.5.5.

Niels Möller's avatar
Niels Möller committed
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
2004-06-10  Niels Mller  <nisse@lysator.liu.se>

	* src/keyexchange.c (parse_kexinit): Deleted unused argument
	peer_flags.

	* misc/Makefile.am (EXTRA_DIST): Include tsocks-forcelocal.patch.

	* src/algorithms.c (lookup_hash): Deleted unused function.
	(all_symmetric_algorithms): Deleted old aes alias
	rijndael-cbc@lysator.liu.se. Added official serpent name
	serpent256-cbc. The alias serpent-cbc@lysator.liu.se should be
	removed at a later date.	
	(all_crypto_algorithms): Likewise.
	(lookup_crypto): Likewise.

	* src/atoms.in: Deleted spki-related atoms, now handled by
	libspki. Also deleted pkcs5-related atoms that aren't used.
	Deleted rijndael-cbc@lysator.liu.se.
	
Niels Möller's avatar
Niels Möller committed
233
234
2004-06-09  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
235
236
237
238
239
	* src/testsuite/functions.sh: Removed -q from LSHD_FLAGS.

	* src/server_pty.c (SYSTEM_GROUP): New macro.
	(pty_check_permissions): If there's no "tty" group, try "system".

Niels Möller's avatar
Niels Möller committed
240
241
242
	* src/testsuite/Makefile.am (TS_SH): Removed ssh1-fallback-test.
	(EXTRA_DIST): Removed fake-sshd1.

Niels Möller's avatar
Niels Möller committed
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
	* src/testsuite/fake-sshd1, src/testsuite/ssh1-fallback-test:
	Deleted files.

	* src/version.h (SSH1_SERVER_PROTOCOL_VERSION): Deleted.

	* src/Makefile.am (liblsh_a_SOURCES): Removed ssh1_fallback.c.

	* src/lshd.c: Removed the ssh1-fallback option.

	* src/handshake.c (do_line): Made the server disallow banner lines
	from clients.

	* configure.ac: Deleted option --with-sshd1.

	* src/io.c (io_set_blocking): Deleted function.

	* src/handshake.c (connection_line_handler): Deleted fd and
	fallback attributes.
	(make_connection_read_line): Deleted fd and fallback arguments.
	(make_handshake_info): Deleted fallback argument. Updated callers.
	(do_line): Deleted ssh1-fallback handling.
	
	* src/ssh1_fallback.h, src/ssh1_fallback.c: Deleted file.

	* src/handshake.h (handshake_info): Deleted fallback attribute.

	* doc/lsh.texinfo (Invoking lshd): Deleted --ssh1-fallback.

	* src/keyexchange.c (KEXINIT_MAX_ALGORITMS): Increased limit to
	500.
	(parse_kexinit): Deleted code handling of
	PEER_KEXINIT_LANGUAGE_KLUDGE.

	* src/handshake.c (compat_peer_flags): #if:ed out function.

	* src/connection.h (enum peer_flags): Deleted constants.

	* configure.ac: Deleted option --disable-datafellows-workarounds.

	* src/proxy_x11forward.c (do_proxy_open_x11): Deleted code
	handling PEER_X11_OPEN_KLUDGE.

Niels Möller's avatar
Niels Möller committed
285
286
2004-06-08  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
287
288
	* src/client.c (client_prepend_action): New function.

Niels Möller's avatar
Niels Möller committed
289
290
291
292
293
294
295
296
	* src/client.c (client_options): New option --write-pid, to be
	used together with -B.
	(do_background_process): Optionally write the child pid to stdout.
	(make_background_process): New function.
	(client_argp_parser): When processing -B, pass the value of
	write_pid to make_background_process.
	(client_argp_parser): Handle --write-pid.

Niels Möller's avatar
Niels Möller committed
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
	Testsuite tweaks.
	* src/testsuite/lshg-1-test, src/testsuite/lshg-cat-2-test,
	src/testsuite/lshg-cat-test, src/testsuite/lshg-tcpip-local-test,
	src/testsuite/socks4-test, src/testsuite/socks5-test,
	src/testsuite/tcpip-local-in-use-test,
	src/testsuite/tcpip-local-test: Deleted unnessary sleep calls.

	* src/testsuite/functions.sh (at_connect): For the
	tcpip-local-in-use-test to work, we must record the mini-inetd
	pid, and kill it before exiting.

	* src/testsuite/functions.sh (spawn_lsh, spawn_lshg): Use new
	--write-pd option and -B to start processes in the background.

	* src/lsh.c (main_argp_parser): Use client_prepend_action to make
	sure that the gateway is started first.

	Removal of old bug-compatibility code.
	* src/handshake.c: Deleted most of the bug-compatibility flags. 

Niels Möller's avatar
Niels Möller committed
317
318
319
320
321
322
323
324
325
326
327
328
	* src/client_userauth.c (do_userauth_pk_ok): Deleted handling of
	PEER_USERAUTH_REQUEST_KLUDGE. 
	* src/server_publickey.c (do_authenticate): Likewise.

	* src/server.c (format_service_accept_kludge): Deleted function.
	(do_service_request): Deleted handling of
	PEER_SERVICE_ACCEPT_KLUDGE.

	* src/client.c (do_accept_service): Deleted handling of
	PEER_SERVICE_ACCEPT_KLUDGE. 
	* src/proxy.c (do_proxy_accept_service): Likewise.

Niels Möller's avatar
Niels Möller committed
329
330
331
332
333
334
335
336
337
338
	* src/dsa.c (do_dsa_verify, do_dsa_sign): Deleted handling of
	ATOM_SSH_DSS_KLUDGE_LOCAL. 

	* src/client_keyexchange.c (do_handle_dh_reply): Deleted handling
	of PEER_SSH_DSS_KLUDGE.
	* src/server_keyexchange.c (do_init_server_dh): Likewise.
	* src/server_publickey.c (do_authenticate): Likewise.

	* src/atoms.in: Deleted ssh-dss-kludge@lysator.liu.se.

Niels Möller's avatar
Niels Möller committed
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
2004-06-08  Niels Mller  <niels@s3.kth.se>

	* src/client.c (client_options): Deleted --cvs-workaround option.
	(client_argp_parser): Deleted handling of --cvs-workaround.
	(fork_input): Deleted function.
	(fork_output): Deleted function.
	(make_client_session): Keep our original stdio fd:s in blocking
	mode, and pass the type IO_STDIO to make_lsh_fd when appropriate.
	(do_detach_cb): Resetting stdio to blocking mode is no longer
	needed.

	* src/client.h (client_options): Deleted stdin_fork, stdout_fork
	and stderr_fork attributes.

	* src/werror.c (set_error_nonblocking): Deleted function.

	* src/server_session.c (spawn_process): Pass correct type
	(IO_NORMAL or IO_PTY) to make_lsh_fd. io_set_type is no longer
	needed. 

	* src/io.h (enum io_type): New type IO_STDIO.

	* src/io.c (io_final): No longer any need to reset stdio file
	descriptors to blocking mode.
	(write_raw_with_poll): Deleted function.
	(io_set_type): Deleted function.
	(io_init_fd): New argument, allowing certain fd:s to remain in
	blocking mode.
	(make_lsh_fd): New argument TYPE. Updated callers.
	(close_fd): Don't close fd:s that are of type IO_STDIO.

Niels Möller's avatar
Niels Möller committed
370
371
372
373
374
375
376
2004-04-07  Niels Mller  <nisse@lysator.liu.se>

	* src/server_pty.c (pty_open_slave): More verbose messages on failure.

	* src/write_packet.c (do_write_packet): Deleted debug output that
	may contain passwords.

377
378
379
380
2004-03-20  Niels Mller  <nisse@lysator.liu.se>

	* configure.ac: Use AC_CONFIG_AUX_DIR([.]).

Niels Möller's avatar
Niels Möller committed
381
382
383
384
2004-03-18  Niels Mller  <niels@s3.kth.se>

	* misc/run-tests (test_program): Strip .exe suffix from name.

Niels Möller's avatar
Niels Möller committed
385
386
2004-03-17  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
387
388
389
390
391
392
393
394
395
396
397
398
	* src/testsuite/Makefile.am (TS_SH): Run the socks4 and socks5
	tests. This is pointless, and hopefully harmless, on machines that
	don't have my hacked version of tsocks.

	* src/socks.c (socks_reply): Send a version 4 reply, if
	appropriate.
	(do_read_socks): Almost implemented socks4. Handling of username
	is slightly broken.

	* src/testsuite/socks4-test: New file.
	* src/testsuite/socks4-config: New file.

Niels Möller's avatar
Niels Möller committed
399
400
	* misc/tsocks-forcelocal.patch: New file.

Niels Möller's avatar
Niels Möller committed
401
402
403
	* misc/tsocks-forcelocal.patch: Also patch the tsocks script to
	look for the library in $libdir.

Niels Möller's avatar
Niels Möller committed
404
405
406
407
2004-03-15  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/socks5-config: Added forcelocal keyword.

Niels Möller's avatar
Niels Möller committed
408
409
410
411
2004-03-01  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/functions.sh (need_tsocks): New function.

412
413
414
415
416
2004-03-01  Niels Mller  <niels@s3.kth.se>

	* acinclude.m4 (LSH_FUNC_ALLOCA): Check for malloc.h, and include
	it if it exists. Needed for alloca on windows.

Niels Möller's avatar
Niels Möller committed
417
418
2004-02-29  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
419
420
421
422
423
424
425
426
427
428
429
430
	* src/testsuite/socks5-config: tsocks configuration file for
	socks5 test case.

	* src/testsuite/socks5-test: New socks5 test.

	* src/testsuite/tcpip-local-test: Check both directions of
	forwarded channel.

	* src/io.c (io_connect_list): Avoid resource leakage if the
	address list is empty, or all connection attempts fail
	immediately. 

Niels Möller's avatar
Niels Möller committed
431
432
433
434
	* src/socks.c (do_read_socks): Bugfix, update self->pos.

	* src/client.c (client_arg_unsigned): Typo fix.

Niels Möller's avatar
Niels Möller committed
435
436
437
438
439
440
	* src/lshg.c (main_options): Deleted short options -I and -D. The
	corresponding long options --send-debug and --send-ignore remains.

	* src/socks.c (do_read_socks): Fixed bugs in parsing of client's
	first message.

Niels Möller's avatar
Niels Möller committed
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
2004-02-27  Niels Mller  <nisse@lysator.liu.se>

	* src/client.c (client_argp_parser): New command line option -D,
	--forward-socks. 	
	(client_arg_unsigned): New function.

	* src/lshd.c: Don't include tcpforward_commands.h.

	* src/tcpforward_commands.c (make_open_tcpip_command): Made non-static.
	(open_direct_tcpip): Moved declaration back here, reverting
	yesterday's change.
	
	* src/tcpforward_commands.h: Deleted file. Prototypes moved to...
	* src/tcpforward.h: ...here.

	* src/socks.c: Rewritten. A successful connect should transform
	the control channel into a data channel.

	* src/process_atoms: Added extra quotes needed to get the length
	of "*" into atoms_table.c.

	* src/lsh.c (main): make_lsh_connect now returns a struct command *, so
	can delete one CAST_SUBTYPE.

	* src/channel_forward.c (channel_forward_start_io_read): New function.

Niels Möller's avatar
Niels Möller committed
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
2004-02-26  Niels Mller  <nisse@lysator.liu.se>

	* src/lsh_string.c (lsh_string_ntop): Use const void * for the
	input. 

	* src/tcpforward_commands.h (open_direct_tcpip,
	OPEN_DIRECT_TCPIP): Moved declarations here...
	* src/tcpforward_commands.c: ... from here.

	* src/socks.c: New file.
	* src/Makefile.am (liblsh_a_SOURCES): Added socks.c.

	* src/scm/gaba.scm (process-expr): Let the generated code return a
	struct command *, not a struct lsh_object *.

	* src/dummy.c (cbc_encrypt, cbc_decrypt): Use nettle_crypt_func
	for typing. 

485
486
487
488
489
2004-02-25  Niels Mller  <nisse@lysator.liu.se>

	* misc/xenofarm.sh (cfgwarn, makewarn, ckprgwarn): Renamed
	variables log, warn and fail. 

490
491
2004-02-24  Niels Mller  <nisse@lysator.liu.se>

492
493
494
495
	* misc/xenofarm.sh (dotask): Fixed handling of $var.
	(cfgwarn, makewarn, ckprgwarn): Use $task when constructing
	filenames.

496
497
498
	* misc/xenofarm.sh: Fixed tasks argpmake and nettlemake. New tasks
	ckargp and cknettle.

Niels Möller's avatar
Niels Möller committed
499
500
501
502
503
	* src/Makefile.am (lshg_SOURCES, lshg_LDADD): Avoid linking with
	nettle. Need to link with dummy.o instead.

	* src/dummy.c: New file.

504
505
506
	* misc/xenofarm.sh (cfgargs): Add the flags we want to use to cfgargs.
	(dotask): New optional argument with the name of the status variable.

507
508
509
510
511
512
2004-02-20  Niels Mller  <nisse@lysator.liu.se>

	* src/process_atoms: Fixes to make it work with Solaris /bin/sh.
	Replaced uses of echo -n with printf(1), and ${#foo} with `expr
	$foo : '.*'`.

Niels Möller's avatar
Niels Möller committed
513
514
515
516
517
518
519
520
521
522
2004-02-20  Niels Mller  <niels@s3.kth.se>

	* src/scm/Makefile.am (EXTRA_DIST): Deleted make-char-classes.

	* configure.ac: Deleted tests for bash.

	* src/Makefile.am (atoms_gperf.c, atoms_table.c): Don't use
	bash to run process_atoms script.
	(packet_types.h): Don't use bash to run the invert-defs script.

Niels Möller's avatar
Niels Möller committed
523
524
2004-02-19  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
525
526
	* src/scm/guile-compat.scm: Deleted most of the contents.

Niels Möller's avatar
Niels Möller committed
527
528
	* src/scm/make-char-classes.scm: Deleted obsolete file.

Niels Möller's avatar
Niels Möller committed
529
530
531
532
533
2004-02-18  Niels Mller  <niels@s3.kth.se>

	* src/Makefile.am (prime_table.h, sexp_table.h, digit_table.h):
	Deleted rules for building obsolete files.

Pontus Freyhult's avatar
Pontus Freyhult committed
534
535
2004-02-18  Pontus Skld  <pont@soua.net>

Niels Möller's avatar
Niels Möller committed
536
	* src/process_atoms: Converted script from bash to /bin/sh.
Pontus Freyhult's avatar
Pontus Freyhult committed
537

Niels Möller's avatar
Niels Möller committed
538
539
2004-02-17  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
540
541
542
	* src/unix_user.c (do_lookup_user) [!HAVE_SHADOW_H]: Enable shadow
	database code only if shadow.h can be included.

Niels Möller's avatar
Niels Möller committed
543
544
545
546
547
548
549
550
	* src/unix_process.c (do_logout_notice): Deleted gratious
	semicolon at end of function definition.
	(do_utmp_cleanup): Use UTMPX_UT_EXIT___E_TERMINATION and
	UTMPX_UT_EXIT_UT_TERMINATION. 

	* configure.ac: Check for ut_exit.__e_termination and
	ut_exit.ut_termination in struct utmp and struct utmpx.

Niels Möller's avatar
Niels Möller committed
551
552
553
554
555
2004-02-16  Niels Mller  <niels@s3.kth.se>

	* configure.ac: Added gss-related configure checks (patch from
	Simon Josefsson).

Niels Möller's avatar
Niels Möller committed
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
2004-02-15  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/Makefile.am (AM_CPPFLAGS): Need -I.., in order to
	include nettle-types.h.

	* src/unix_user.c (do_lookup_user): Just ignore shadow database if
	getspnam returns NULL.

	* src/lsh.h: #include nettle/types.h instead of inttypes.h.

	* src/atoms.h: #include lsh.h instead of inttypes.h.
	* src/charset.h: Likewise.
	* src/tty.h: Likewise.
	* src/testsuite/testutils.h: Likewise.

	* configure.ac: Bumped version to 1.5.5.

Niels Möller's avatar
Niels Möller committed
573
574
575
576
577
2004-02-13  Niels Mller  <niels@s3.kth.se>

	* src/ssh.h: Added GSSAPI constants (patch from Simon Josefsson).
	* src/atoms.in: New symbol "gssapi".

Niels Möller's avatar
Niels Möller committed
578
579
580
581
582
2004-02-12  Niels Mller  <nisse@lysator.liu.se>

	* src/io.c (address_info2sockaddr) [!HAVE_GETADDRINFO]: Updated
	code to work with new string abstraction.

583
584
585
586
2004-02-12  Niels Mller  <niels@s3.kth.se>

	* configure.ac: No space between "-I" and include directories.

Niels Möller's avatar
Niels Möller committed
587
588
2004-02-08  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
589
590
	* Released lsh-1.5.4.

Niels Möller's avatar
Niels Möller committed
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
	Implemented flow control for the connections write_buffer. The
	buffer is now of limited size. When it starts to get large, channel
	i/o is disabled. If it hits the limit, the connection is closed.

	* src/connection.c (WRITE_BUFFER_MAX, WRITE_BUFFER_MARGIN): New
	constants.
	(connection_flow_controlled): New class.
	(do_connection_flow_controlled): Reenable channel i/o when we have
	room in the write buffer.
	(make_ssh_connection): Initialize ssh_connection attributes
	wakeup, soft_limit and hard_limit.
	(connection_init_io): Changed argument type from struct
	abstract_write to struct lsh_fd. Install flow control on the
	socket's write_buffer. Deleted the randomness argument, and don't
	call make_packet_write. This way, both handshake_command and
	gateway_make_connection can call this function.
	(connection_wakeup): New function, which installs a wakeup
	callback on the connection.
	(connection_send_kex): Compare the size of the write_buffer to the
	soft and hard limits.
	(connection_send_kex_end): Invoke wakeup callback, if it's
	non-NULL.

	* src/connection.h (ssh_connection): New attribute socket,
	replaces old attribute raw. New attributes hard_limit and
	soft_limit. 

	* src/read_data.c (do_read_data_query): Stop reading, if
	connection->hard_limit is set, indicating an almost full
	write_buffer for the connection.

	* src/handshake.c (handshake_command): Adapt to changed
	connection_init_io. Use connection->socket instead of
	connection->raw. 

	* src/gateway_commands.c (gateway_make_connection): Use
	connection_init_io, so that flow control is set up properly.

	* src/channel.c (window_adjust_handler): Deleted redundant assert.
	(do_channels_after_keyexchange): Renamed to do_channels_wakeup. No
	longer needs to reinstall the handler.
	(init_connection_service): Use connection_wakeup, not
	connection_after_keyexchange. 

635
636
2004-02-07  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
637
638
	* install-sh: Removed from CVS repository. Let automake supply it.

639
640
641
	* acinclude.m4 (LSH_FUNC_ALLOCA): Include <alloca.h>, if
	available, also when compiling with gcc.

Niels Möller's avatar
Niels Möller committed
642
643
2004-01-08  Niels Mller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
644
645
646
	* src/rsync/rsync.h: Don't include inttypes.h, just let
	<nettle/md5.h> define uint8_t and other types.

Niels Möller's avatar
Niels Möller committed
647
648
649
650
651
652
653
654
	* src/Makefile.am (AM_CPPFLAGS): Added -I./nettle. Needed to find
	the nettle-types.h include file when building outside of the
	source directory.
	(packet_types.h): Changed rule to use $< to refer to the input
	file. 
	* src/testsuite/Makefile.am (AM_CPPFLAGS): Added -I../nettle.
	* src/rsync/Makefile.am (AM_CPPFLAGS): Added -I../nettle.

Niels Möller's avatar
Niels Möller committed
655
656
657
658
659
660
2004-01-08  Niels Mller  <niels@s3.kth.se>

	* src/tcpforward.c (do_channel_open_direct_tcpip): Log
	direct-tcpip request.
	(do_tcpip_forward_request): Log forward-tcpip request.

Niels Möller's avatar
Niels Möller committed
661
662
663
664
2004-01-08  Niels Mller  <nisse@harpo.hack.org>

	* configure.ac: No space between "-L" and library directories.

Niels Möller's avatar
Niels Möller committed
665
666
667
668
669
2004-01-07  Niels Mller  <nisse@harpo.hack.org>

	* acinclude.m4 (AX_CREATE_STDINT_H): Copied macro definition from
	http://ac-archive.sourceforge.net/guidod/ax_create_stdint_h.html.

Niels Möller's avatar
Niels Möller committed
670
671
672
673
674
2003-11-18  Niels Mller  <niels@s3.kth.se>

	* src/unix_process.c (utmp_book_keeping) [UTMPX_UT_SYSLEN]: Use
	lsh_string_length. 

Niels Möller's avatar
Niels Möller committed
675
676
677
678
679
680
681
682
683
684
685
686
2003-11-17  Niels Mller  <nisse@harpo.hack.org>

	* src/read_packet.c (class read_packet): New attribute
	mac_computed.
	(lsh_string_realloc): Deleted function.
	(do_read_packet, make_read_packet): Allocate block_buffer,
	mac_buffer and mac_computed at creation time, using
	SSH_MAX_BLOCK_SIZE and SSH_MAX_MAC_SIZE.

	* src/ssh.h (SSH_MAX_BLOCK_SIZE, SSH_MAX_MAC_SIZE): New constants,
	with the implementations's maximum block size and mac size.

Niels Möller's avatar
Niels Möller committed
687
688
2003-11-16  Niels Mller  <nisse@harpo.hack.org>

689
690
691
	* src/lsh-writekey.c (main_argp_parser): Move declaration to
	support C90.

Niels Möller's avatar
Niels Möller committed
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
	* src/Makefile.am (liblsh_a_SOURCES): Added lsh_string.c.

	* src/lsh_string.c, src/lsh_string.h: New files, with a private
	string implementation. The point is that no other code should
	write directly into strings or other buffers.

	* src/gateway_commands.c (class read_gateway_packet): Use an
	lsh_string for the header buffer, not a plain char array.
	* src/read_line.c (class read_line): Likewise, for the line buffer.
	* src/write_buffer.h, src/write_buffer.c (class write_buffer):
	Likewise for the output buffer.

	* src/pkcs5.c (pkcs5_derive_key): Take lsh_string arguments, and
	return key as an lsh_string. Also use lsh_strings internally,
	instead of plain char buffers.

	* src/format.c (ssh_format_write, ssh_vformat_write)
	(format_hex_string, format_decimal, write_decimal_length): Take a
	lsh_string and position for the destination. Updated to use
	functions from lsh_string.c. Moved some functions to lsh_string.c.
	(lsh_string_colonize): Use const for input string. Use
	lsh_string_putc.
	(lsh_string_bubblebabble): Use lsh_string_putc. No need for
	explicit NUL-termination. Use const for input string.
	
	* src/format.c (ssh_format): Changed definition of %r, now stores
	the start position of the reserved area, not a pointer. Updated
	all callers.

	* src/lock_file.c, src/lsh-make-seed.c, src/server_session.c,
	src/server_x11.c: #include lsh_string.h.

	* src/spki.c (spki_hash_data): Rewritten to use hash_digest_string
	instead of hash_digest.

	* src/testsuite/testutils.c (decode_hex): Use const for input.
	Also other updates for lsh_string changes.
	
	* src/zlib.c (do_zlib): Use lsh_string_zlib. Updated for
	lsh_string changes.

	* src/werror.c (werror_decimal): Rewrote to not use
	format_decimal.
	(werror_hexdump): Use const for input.
	(werror_vformat): Updated for lsh_string changes.

	* src/unix_user.c (kerberos_check_pw, do_verify_password): Updated
	for lsh_string changes.

	* src/unix_interact.c (unix_yes_or_no): Updated for lsh_string
	changes.

	* src/string_buffer.h (struct string_buffer): Replaced current
	pointer with an integer position.
	* src/string_buffer.c: Updated for lsh_string changes.

	* src/spki.c (spki_pkcs5_encrypt): Use const for input argument.

	* src/server_userauth.c (do_handle_userauth): Updated for
	lsh_string changes.

	* src/server_publickey.c (do_authenticate): Updated for lsh_string
	changes. 

	* src/server_pty.c (pty_open_slave): Updated for lsh_string changes.

	* src/read_file.c (do_read_file): Updated for lsh_string changes.

	* src/parse_config.c: #include lsh_string.h.

	* src/lsh.h: Removed declarations for lsh_string. This is now
	provate to lsh_string.c. Only kept a forward declaration of struct
	lsh_string, and a declaration of lsh_string_free.

	* src/lsh-export-key.c (encode_base64): Use lsh_string.c functions.

	* src/lsh-decrypt-key.c (main): Updated for lsh_string changes.

	* src/lsh-decode-key.c (main): Use lsh_string_base64_decode.

	* src/io.c (do_consuming_read, io_read_file_raw): Use lsh_string_read.
	(do_write_callback): Updated for lsh_string changes.
	(sockaddr2info): Use lsh_string_ntop.

	* src/handshake.c (compat_peer_flags, split_version_string) 
	(do_line): Use const for input strings.

	* src/read_line.h (class line_handler): Use a const for the
	handler method.

	* src/dsa.c (make_ssh_dss_verifier): Use a lsh_string for the
	input. Updated for lsh_string changes.
	* src/rsa.c (make_ssh_rsa_verifier): Likewise.
	* src/publickey_crypto.h: Updated prototypes.

	* src/sexp.c (lsh_sexp_format): Function renamed to
	lsh_string_format_sexp, and moved to lsh_string.c. Updated
	callers.

	* src/daemon.c (daemon_pidfile): Updated for lsh_string changes.

	* src/client_keyexchange.c (do_handle_dh_reply): Updated for
	lsh_string changes. 

	* src/client.c (rebuild_command_line): Use lsh_string_write.

	* src/charset.c: Updated for lsh_string changes.
	(low_utf8_to_local): Use const for input.

	* src/xalloc.c: Removed string related functions. Moved to
	lsh_string.c. 

	* src/gc.c (gc): Use lsh_get_number_of_strings to access string
	counter. 
	(gc_final): Call lsh_string_final_check. 

	* src/abstract_crypto.h (CRYPT): Changed method to take an
	lsh_string and an index for source and destination. Also changed
	the order of source and destination arguments.
	(MAC_DIGEST): Take a lsh_string and index for the destination.

	* src/crypto.c: Rewrote cipher classes to use functions in
	lsh_string.c, instead of writing directly into the output string.
	(hash_digest_string): New function.
	(hash_digest): New function.
	(do_hmac_digest): Use lsh_string_write_hmac.

	* src/channel.c: Updated for lsh_string changes.
	* src/client_escape.c: Likewise.
	* src/client_userauth.c: Likewise.
	* src/client_x11.c: Likewise.
	* src/connection.c: Likewise.
	* src/debug.c: Likewise.
	* src/dh_exchange.c: Likewise.
	* src/keyexchange.c: Likewise.
	* src/lsh-writekey.c: Likewise.
	* src/lsh.c: Likewise.
	* src/read_packet.c: Likewise.
	* src/server.c: Likewise.
	* src/spki.c: Likewise.
	* src/srp-gen.c: Likewise.
	* src/srp_exchange.c: Likewise.
	* src/tcpforward.c: Likewise.
	* src/tty.c: Likewise.
	* src/unix_process.c: Likewise.
	* src/unix_random.c: Likewise.
	* src/write_packet.c: Likewise.
	* src/xauth.c: Likewise.

Niels Möller's avatar
Niels Möller committed
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
2003-11-11  Niels Mller  <nisse@harpo.hack.org>

	* src/Makefile.am (liblsh_a_SOURCES): Deleted unpad.c.

	* src/xalloc.c (lsh_object_free): Changed to take a const argument.

	* src/read_packet.c (do_read_packet): Moved code for stripping
	padding and inflating read packets to this function.
	* src/handshake.c (do_line): Deleted calls to make_packet_unpad
	and make_packet_inflate. 
	* src/unpad.c, src/unpad.h: Deleted files.
	* src/compress.c (class packet_compressor): Deleted class.
	(make_packet_codec): Deleted function.
	* src/compress.h (make_packet_deflate, make_packet_inflate):
	Deleted macros.

Niels Möller's avatar
Niels Möller committed
857
858
859
860
861
862
863
864
865
866
867
868
869
2003-11-10  Niels Mller  <nisse@harpo.hack.org>

	* src/connection.c (connection_send_kex): New function, replacing
	macro C_WRITE_NOW. Updated all callers.

	* src/read_file.h: Deleted file. Moved declarations to...
	* src/abstract_io.h: ... here. Deleted all inclusions of read_file.h.

2003-11-09  Niels Mller  <nisse@harpo.hack.org>

	* src/debug.h: Deleted file. Moved declarations to...
	* src/connection.h: ... here. Deleted all inclusions of debug.h.

Niels Möller's avatar
Niels Möller committed
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
2003-11-08  Niels Mller  <nisse@harpo.hack.org>

	* src/Makefile.am (liblsh_a_SOURCES): Removed pad.c, encrypt.c.
	Added write_packet.c. 

	* src/compress.c (do_packet_inflate): Keep sequence number.

	* src/pad.c, src/pad.h, src/encrypt.c, src/encrypt.h: Deleted
	files.
	* src/write_packet.c: New file and function, to replace pad.c and
	encrypt.c. 	
	* src/client.c, src/connection.c: Don't include pad.h and encrypt.h.
	* src/connection.h: Prototype for make_write_packet.

	* src/connection.c (connection_init_io): Use make_write_packet.

Niels Möller's avatar
Niels Möller committed
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
2003-10-30  Niels Mller  <nisse@harpo.hack.org>

	* src/connection.h (C_WRITE): Deleted macro. Updated all callers
	to use connection_send directly.

	Changed gateway protocol, to not use any extra padding.
	* src/gateway_commands.c (do_read_gateway): New function
	(make_read_gateway): New function.
	(do_gateway_pad): New extra padding.
	(gateway_make_connection): No need to call make_packet_unpad.

	* src/abstract_io.h (class read_handler): Use a const uint8_t *
	argument for the handler method.
	* src/read_file.c (do_read_file): Const argument.
	* src/read_line.c (do_read_line): Likewise.
	* src/read_packet.c (do_read_packet): Likewise.

Niels Möller's avatar
Niels Möller committed
903
904
2003-10-23  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
905
906
907
908
909
910
911
912
913
914
915
	* src/server_userauth.c: Rewrote comment about userauth
	serialization. 

	* src/io.c (close_fd): Deleted fd = -1 special case. 

	* src/connection.c (connection_lock, connection_unlock): Simplified.
	(do_exc_connection_handler): Deleted handling of
	EXC_PAUSE_CONNECTION and EXC_PAUSE_START_CONNECTION.
	* src/exception.h (EXC_PAUSE_CONNECTION) 
	(EXC_PAUSE_START_CONNECTION): Deleted exception types.

Niels Möller's avatar
Niels Möller committed
916
917
918
919
920
921
922
	* src/dsa_keygen.c, src/rsa_keygen.c: Deleted files. Moved the
	dsa_generate_key and rsa_generate_key functions to ...
	* src/lsh-keygen.c: ... here.

	* src/dsa.c (generic_dsa_verify): Deleted function.
	(generic_dsa_sign): Likewise.

Niels Möller's avatar
Niels Möller committed
923
924
2003-10-22  Niels Mller  <niels@s3.kth.se>

Niels Möller's avatar
Niels Möller committed
925
926
927
	* src/client_x11.c (client_x11_auth_info): Deleted commented out
	class.

Niels Möller's avatar
Niels Möller committed
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
	* src/server_session.c (do_alloc_pty): Return channel in question.
	(do_window_change_request): Likewise.
	(do_spawn_subsystem): Likewise.

	* src/gateway_channel.c (do_gateway_channel_request): Added FIXME
	on returned value.
	* src/server_x11.c (do_xauth_exit): Likewise.

	* src/client.c (do_exit_status): Return the channel in question to
	the continuation.
	(do_exit_signal): Likewise.

	* src/channel.c (channel_request_continuation): Expanded FIXME
	comment. 

Niels Möller's avatar
Niels Möller committed
943
944
945
946
947
948
949
950
951
952
953
954
955
	* src/parse.h: Include nettle/bignum.h instead of bignum.h.

	* src/format.h: Don't include bignum.h.
	* src/keyexchange.h: Likewise.
	* src/publickey_crypto.c: Likewise.
	* src/werror.h: Likewise.

	* src/dh_exchange.c (dh_generate_secret): Use nettle_mpz_random.
	Needs inclusion of nettle/bignum.h.

	* src/bignum.c, src/bignum.h: Deleted files.
	* src/Makefile.am (liblsh_a_SOURCES): Deleted bignum.c

Niels Möller's avatar
Niels Möller committed
956
957
	* configure.ac: Bumped version to 1.5.4.

Niels Möller's avatar
Niels Möller committed
958
959
960
961
962
963
	* src/interact.h (INTERACT_READ_PASSWORD): Deleted the forth
	argument FREE. Now the prompt string is always consumed. Updated
	all callers.
	* src/unix_interact.c (unix_read_password): Deleted fourth
	argument FREE.

Niels Möller's avatar
Niels Möller committed
964
965
966
967
968
969
970
971
972
973
	* src/lsh.h: Forward declaration of catch_report_collect.
	* src/channel_forward.h: ... and deleted corresponding declaration
	here. 

	* src/abstract_compress.c, src/abstract_compress.h: Deleted files.
	Moved contents to...
	* src/compress.c, src/compress.h: ... here. Updated users.

	* src/Makefile.am (liblsh_a_SOURCES): Removed abstract_compress.

Niels Möller's avatar
Niels Möller committed
974
975
976
977
978
979
980
981
2003-10-10  Niels Mller  <niels@s3.kth.se>

	* src/unix_user.c (do_read_file_fail): Return the created
	exception. 

	* src/lshd.c (main_argp_parser): Use getenv(ENV_LOGNAME), not
	getenv("LOGNAME"). 

Niels Möller's avatar
Niels Möller committed
982
983
984
985
986
987
2003-10-05  Niels Mller  <nisse@cuckoo.hack.org>

	* src/lsh.c (read_user_keys): Display error message for missing
	identity file only in verbose mode. Suggested by Thomas
	Krennwallner.

Niels Möller's avatar
Niels Möller committed
988
989
990
991
992
993
994
995
996
997
2003-09-27  Niels Mller  <nisse@cuckoo.hack.org>

	* src/gateway_channel.c (do_channel_open_forward): Moved creation
	of ORIGIN channel object from here...
	(do_gateway_channel_open_continuation): ... to here.
	(make_gateway_channel_open_continuation): Deleted ORIGIN argument.

	* src/channel.c (channel_open_handler): Bugfix for the case that
	alloc_channel fails.

Niels Möller's avatar
Niels Möller committed
998
999
1000
2003-09-26  Niels Mller  <nisse@cuckoo.hack.org>

	* src/channel.c (login_service_command): Deleted redundant command.
For faster browsing, not all history is shown. View entire blame