ChangeLog

2004-12-07  Niels Mller  <nisse@lysator.liu.se>

	* Released lsh-2.0.

	* src/environ.h.in (USER_NAME_FROM_ENV): Examine $LOGNAME before
	$USER. This is the same behaviour as emacs and rcs.

2004-12-07  Pontus Freyhult  <pont@soua.net>

	* doc/lsh.texinfo (Action options): Added --detach and
	--write-pid options.
	(Features): Added section about gateway mode.
	(Invoking lshg): New node.
	(Action options): Added --subsystem option.
	(Invoking lshd): Added --subsystems option.

2004-12-06  Niels Mller  <nisse@lysator.liu.se>

	* configure.ac: Bumped version to 2.0.

2004-12-05  Niels Mller  <nisse@lysator.liu.se>

	* src/lshg.c (do_exc_lshg_handler): Exit only for EXC_IO_CONNECT
	errors. 

2004-12-05  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/tcpip-remote-test: Don't run tcpconnect with
	/dev/null as standard input; for some reason, that doesn't work on
	SunOS-5.4. 

2004-11-30  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/functions.sh (test_done): New function, used when
	exiting the testscripts. This is instead of using trap, which
	seemed to be unreliable on SunOS-5.4.
	(spawn_lshd): On failure, return exit code 1 from the function,
	instead of invoking test_fail.

	* src/testsuite/lsh-6-test: Fixed handling of return value from
	spawn_lshd. 

	* src/testsuite/lcp-test: Use die instead of test_fail.
	* src/testsuite/lsh-decrypt-key-test: Likewise.

	* src/testsuite/inetd-test: Use test_done.
	* src/testsuite/keygen-1-test: Likewise.
	* src/testsuite/keygen-2-test: Likewise.
	* src/testsuite/lsh-1-test: Likewise.
	* src/testsuite/lsh-2-test: Likewise.
	* src/testsuite/lsh-3-test: Likewise.
	* src/testsuite/lsh-5-test: Likewise.
	* src/testsuite/lsh-7-test: Likewise.
	* src/testsuite/lsh-8-test: Likewise.
	* src/testsuite/lsh-9-test: Likewise.
	* src/testsuite/lsh-encrypted-key-test: Likewise.
	* src/testsuite/lshd-no-auth-test: Likewise.
	* src/testsuite/lshg-1-test: Likewise.
	* src/testsuite/lshg-tcpip-local-test: Likewise.
	* src/testsuite/seed-test: Likewise.
	* src/testsuite/socks4-test: Likewise.
	* src/testsuite/socks5-test: Likewise.
	* src/testsuite/tcpip-local-in-use-test: Likewise.
	* src/testsuite/tcpip-local-test: Likewise.
	* src/testsuite/tcpip-remote-test: Likewise.
	* src/testsuite/write-key-1-test: Likewise.
	* src/testsuite/write-key-2-test: Likewise.
	* src/testsuite/x11-1-test: Likewise.

2004-11-26  Niels Mller  <nisse@lysator.liu.se>

	* src/io.c (io_bind_local): NUL-terminate AF_UNIX socket name.

2004-11-25  Niels Mller  <nisse@lysator.liu.se>

	* misc/xenofarm.sh: Don't insist on using GNU make. If we're not
	using GNU make, disable dependency tracking, since it wont' work
	with nettle.

2004-11-23  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): New configure flag
	--disable-dependency-tracking. New substitution DEP_INCLUDE.

	* src/lshg.c (make_lshg_connect): New argument, resource.
	(main): Pass options->super.resources to make_lshg_connect.

	* src/gateway_commands.c (gateway_make_connection): New argument,
	a resource to be adopted by the connection.
	(gateway_init): Likewise.
	(gateway_accept): Pass a NULL-resource to gateway_make_connection.

2004-11-22  Niels Mller  <nisse@lysator.liu.se>

	* src/client.c (init_client_options): Init the resources list.
	(make_client_session): Use IO_STDERR. Add the session resources to
	options->resources, instead of calling gc_global.

	* src/client.h (client_options): New attribute, resources.

	* src/srp-gen.c (main_argp_parser): Updated for changes to
	io_write_file. 

	* src/lshd.c: Updated for changes to handshake_command. Pass a
	NULL resource.
	(make_lshd_listen_callback): Updated for changes to
	make_handshake_info. 

	* src/lsh.c (do_lsh_lookup): Use a single A_WRITE to write the
	acl-entry to a file.
	(make_lsh_connect): New argument resource. Deleted kexinit
	argument (it's now part of handshake_info). Use the new protect
	command, to pass the resource to handshake, and destroy it on
	exceptions.
	(main_argp_parser): Updated for changes io_write_file.
	(main): Updated for changes to make_lsh_connect and
	make_handshake_info. Pass options->super.resources to the
	handshake command.

	* src/io.c (WITH_LIBOOP_SIGNAL_ADAPTER): Compile time choice of
	whether or not to use the liboop signal adapter.
	(io_init) [WITH_LIBOOP_SIGNAL_ADAPTER]: Create signal adapter.
	(io_final) [WITH_LIBOOP_SIGNAL_ADAPTER]: Destroy signal adapter.
	(make_lsh_fd): Files of both types IO_STDIO and IO_STDERR are
	shared. Bugfix: Don't reset type to zero.	
	(write_only_file): New class.
	(do_write_only_file, make_io_write_file): New function.
	(io_write_file): Don't create a lsh_fd. Instead, use the simpler
	write_only_file, and return a struct abstract_write *. These files
	are never closed.
	(close_fd): Don't close files of type IO_STDERR. For files of type
	IO_STDIO, close them, and map the fd to /dev/null.

	* src/io.h (io_type): New enum constant IO_STDERR.

	* src/handshake.c (make_handshake_info): New argument kexinit.
	(handshake_command): New first argument, a resource to be adopted
	by the connection. Deleted the kexinit argument, kexinit is now
	passed as an attribute of handshake_info.

	* src/handshake.h (handshake_info): New attribute kexinit.

	* src/gc.c (gc_iterate_objects): New function (#if:ed out), for
	debugging purposes.

	* src/command.c (catch_collect_body): Deleted unused class.
	(do_catch_collect_body, make_catch_collect_body, do_catch_simple):
	Deleted functions. 
	(protect_handler): New class.
	(protect_command)): New command.

	* src/command.h (catch_command): Deleted unused class.

2004-11-20  Pontus Freyhult  <pont@soua.net>

	* doc/Makefile.am (man_MANS): Added new manpages so they'll
	be installed.
	(EXTRA_DIST): Added man_MANS.

	* doc/lsh.texinfo (Files and environment variables): Added
	documentation for LSHFLAGS, LSHGFLAGS, SSH_CLIENT and SSH_TTY.
	(Converting keys): Added lsh-export-key example. Rewrote part
	about lshs SPKI format slightly.

	* doc/lshg.1: LSHGFLAGS, not LSHG_FLAGS.

	* doc/lshg.1: LSHFLAGS, not LSH_FLAGS.	

	* doc/ssh-conv.1, doc/lsh-upgrade.1, doc/lsh-make-seed.1,
	doc/lsh-keygen.1, doc/lsh-keygen.1, doc/lsh-export-key.1,
	doc/lsh-decrypt-key.1, doc/lsh-decode-key.1, doc/lsh-writekey.1,
	doc/lsh-authorize.1, doc/lsh-upgrade-key.1, doc/lsh.1, 
	doc/lshd.8, doc/lshg.1: Added disclaimer pointing to info system.
	
	* doc/ssh-conv.1 (lsh-decode-key): New manpage.

	* doc/lsh-upgrade.1: Misc. fixes.

	* doc/lsh-make-seed.1: New manpage.

	* doc/lsh-keygen.1: New manpage.

	* doc/lsh-export-key.1: New manpage.

	* doc/lsh-decrypt-key.1: New manpage.

	* doc/lsh-decode-key.1: New manpage.

	* doc/lsh-writekey.1: New manpage.

2004-11-19  Niels Mller  <nisse@lysator.liu.se>

	* src/io.c (io_final): Assert that nfiles == 0.
	(do_buffered_read): Added trace output on EOF.
	(do_consuming_read): Likewise.
	(close_fd_write): Added trace output. Close the file if there's no
	write buffer and no read callback.

	* src/io.h (class lsh_fd): Deleted unused attribute next.

2004-11-19  Pontus Freyhult  <pont@soua.net>

	* doc/lsh-authorize.1, doc/lsh-upgrade-key.1, doc/lsh-upgrade.1,
	doc/lsh.1, doc/lshd.8, doc/lshg.1: Added missing dot in AUTHOR
	sentence.

	* doc/lsh.texinfo (Converting keys): Added example for sshd host.
	(Features): Added bit about SOCKS proxy feature.

	* src/lshg.c (main_options): Added missing dot in -G option help.

	* doc/lsh.1: Updated for lsh 2.0.
	
	* doc/lshd.8: Updated for lsh 2.0.
	
	* doc/lshg.1: New man page.

	* doc/lsh-authorize.1: New man page.

	* doc/lsh-upgrade.1: New man page.

	* doc/lsh-upgrade-key.1: New man page.

2004-11-18  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): Use [!...] instead of
	[^...] for inverted character classes in case.

	* src/Makefile.am (bin_SCRIPTS): Install the lcp script.

	* src/lsh-export-key.c (enum output_mode): New enum.
	(encode_base64_line): New function.
	(sexp_to_ssh2_key): Alternative output formats, fingerprint and
	openssh single-line format.
	(main_options): New options --fingerprint and --openssh.
	(make_options): Make standard format the default output format.
	(main_argp_parser): Handle new options.

	* src/spki.c (spki_make_verifier): New third argument for
	returning the name of the algorithm. Updated callers.

	* misc/xenofarm.sh (oopcfgargs): Disable all add-on liboop
	adapters. 

2004-11-18  Niels Mller  <niels@s3.kth.se>

	* README: Updated examples, and the lists of needed tools and
	libraries. 

	* misc/xenofarm.sh (oopcfgargs): Build liboop with
	--disable-shared.

2004-11-17  Niels Mller  <nisse@lysator.liu.se>

	* src/unix_random.c (do_trivia_source): Check HAVE_GETRUSAGE.

	* src/lsh-writekey.c (main_argp_parser): Fixed C99-ism.

2004-11-16  Niels Mller  <nisse@lysator.liu.se>

	* misc/getopt.h: Deleted __ from argument names in prototypes,
	i.e. "argc", not "__argc". Needed for mingw compilation.

	* .bootstrap: Typo fix.

	* misc/getopt.c, misc/getopt1.c, misc/getopt.h: Moved files here.
	Linked into the directories that need them by ./.bootstrap.

	* src/environ.h.in (USER_NAME_FROM_ENV): Check $USER first.

2004-11-14  Niels Mller  <nisse@lysator.liu.se>

	* src/io.c (handle_nonblock_error): Ignore errno ENOTTY. FreeBSD 5
	returns this error code when we try to set /dev/null in
	non-blocking mode.

	* src/environ.h.in (USER_NAME_FROM_ENV): New macro, which consults
	both $LOGNAME and $USER.
	* src/client.c (init_client_options): Use it.
	* src/srp-gen.c (make_srp_gen_options): Likewise.
	* src/lshd.c (main_argp_parser): Likewise.
	* src/lsh-writekey.c (main_argp_parser): Likewise.

	* src/server_pty.c: When using snprintf, NUL-terminate the strings
	explicitly.

	* .bootstrap: Link misc/vsnprintf.c info the argp and sftp
	directories.

	* misc/vsnprintf.c: Portable and public domain implementation of
	snprintf and vsnprintf, copied from
	http://www.fiction.net/blong/programs/snprintf.c, with some minor
	fixes. This file is moved here from the src/argp directory.

	* src/testsuite/Makefile.am (CLEANFILES): Delete testfiles lcp-file-*.txt
	(TS_SH): Added lcp-test.

	* src/testsuite/lcp-test: Test cases for lcp.

2004-11-13  Niels Mller  <nisse@lysator.liu.se>

	* src/lcp: Reviewed, and fixed some bugs. Looks at $LCP_RSH,
	instead of $LCP_SSH.

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): Don't add dependency
	files themselves as targets.

	* misc/xenofarm.sh (status): There's no config.h in the liboop
	directory, so don't try to copy it.

2004-11-12  Niels Mller  <nisse@lysator.liu.se>

	* misc/xenofarm.sh (--make-program): New command line option.

2004-11-09  Niels Mller  <niels@s3.kth.se>

	* src/lsh-krb-checkpw.c (main): Noted that the current code seems
	to work only with Heimdal, not MIT kerberos.

	* configure.ac: Check for krb5_verify_user_lrealm, and disable
	kerberos support if not found.

2004-11-09  Niels Mller  <nisse@lysator.liu.se>

	* doc/lsh.texinfo: Set UPDATED-FOR to 2.0.

	* misc/xenofarm.sh: Fixed typos in the oop-related tasks.

2004-11-07  Niels Mller  <nisse@lysator.liu.se>

	* doc/lsh.texinfo (Action options): Documented -D (socks
	forwarding).

	* misc/xenofarm.sh: If a liboop dist is included in the build
	package, install it in $pfx before trying to build lsh.

2004-10-26  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): Need extra quoting in
	case pattern.

2004-10-20  Niels Mller  <niels@s3.kth.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): Disable dependency
	tracking for gcc-2.

2004-10-20  Niels Mller  <nisse@lysator.liu.se>

	* .bootstrap: Link install-sh, texinfo.tex, COPYING and INSTALL
	into the nettle subdir.

2004-10-19  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_DEPENDENCY_TRACKING): New macro.
	(LSH_MAKE_CONDITIONAL): New macro.

	* .bootstrap: In the nettle subdir, link acinclude.m4 as
	aclocal.m4, not acinclude.m4.

2004-10-08  Niels Mller  <niels@s3.kth.se>

	* src/client_userauth.c (do_userauth_info_request): Enforce limits
	on the length of name and instruction. Prepend the name and an
	empty line to the instruction.

	* src/unix_interact.c (unix_dialog): Deleted instruction argument,
	display dialog->instruction instead.

	* src/interact.h (interact_dialog): New instruction attribute.
	(INTERACT_DIALOG): Deleted instruction argument.
	* src/interact.c (make_interact_dialog): Initialize
	self->instruction to NULL.

2004-10-07  Niels Mller  <niels@s3.kth.se>

	* src/lsh-writekey.c (main_argp_parser): When --server is given,
	don't use encryption by default.

	* src/testsuite/login-auth-test (LSHD_FLAGS): Use --login-shell
	instead of --login-program.

	* doc/lsh.texinfo: Updated for version 1.5.6.

	* src/lshd.c (make_lshd_options): New default: Enable X11
	forwarding.
	(main_options): Deleted broken --login-program option.

	* src/lsh-writekey.c (make_lsh_writekey_options): New default:
	Encrypt private key using aes256-cbc.

	* src/lsh-keygen.c (make_lsh_keygen_options): New default:
	Generate RSA keys.

	* src/testsuite/keygen-1-test: Pass -c none to lsh-writekey.
	* src/testsuite/keygen-2-test: Likewise.
	* src/testsuite/lsh-decrypt-key-test: Likewise.
	* src/testsuite/setup-env: Likewise.
	* src/testsuite/write-key-1-test: Likewise.
	* src/testsuite/write-key-2-test: Likewise.
	
2004-10-06  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/Makefile.am (EXTRA_DIST): Added UTF-8-test.txt.

2004-10-05  Niels Mller  <nisse@lysator.liu.se>

	* src/Makefile.am (GPERF_FLAGS): Added -k21, to distinguish
	diffie-hellman-group1-sha1 and diffie-hellman-group2-sha1.

	* src/lsh.c (main_argp_parser): Support "diffie-hellman-group2-sha1".
	* src/lshd.c (main_argp_parser): Likewise.

	* src/atoms.in (diffie-hellman-group2-sha1): New name, for now an
	alias to diffie-hellman-group14-sha1.

	* src/testsuite/inetd-test: Start lshd with --daemon --no-syslog.
	Note that this test is not yet enabled, and inetd mode not working.

	* src/parse.c (parse_utf8): Keep track of the length of invalid
	sequences. Moved the check for overlong sequences, not it's done
	after the complete sequence is processed.

	* src/charset.c (low_utf8_to_local): If utf8_tolerant is set,
	replace invalid utf8 sequences with '?'. Used mainly by the
	testsuite. 

	* src/charset.h (enum utf8_flag): New flag utf8_tolerant.

	* src/testsuite/utf8-test.c: New test program.
	* src/testsuite/Makefile.am (TS_PROGS): Added utf8-test.
	* src/testsuite/UTF-8-test.txt: Markus Kuhn's utf8 testfile.

	* src/testsuite/functions.sh: Added -q to LSHD_FLAGS again.

2004-10-02  Niels Mller  <nisse@lysator.liu.se>

	* src/daemon.c (daemon_started_by_inetd): More debug output.

	Implemented client-side "keyboard-interactive".
	* src/unix_interact.c (unix_read_password): Split off...
	(read_password): New function, reads password and doesn't free
	prompt. 
	(unix_dialog): New function.

	* src/ssh.h (SSH_MSG_USERAUTH_INFO_REQUEST) 
	(SSH_MSG_USERAUTH_INFO_RESPONSE): New constants.

	* src/server_password.c (do_authenticate): Disallow control
	characters in user names.
	* src/server_userauth.c (do_none_preauth): Likewise.
	* src/server_publickey.c (do_authenticate): Likewise.

	* src/parse.c (parse_utf8): New argument *utf8_length. Treat
	overlong sequences surrigates and the non-characters 0xfffe and
	0xffff as errors.

	* src/lsh.c (make_lsh_login): Use keyboard-interactive, if the
	other methods fail.

	* src/scm/gaba.scm (make-freer): Free elements of allocated
	arrays, i.e. variables of type "space".

	* src/interact.h (interact_dialog): New class. 
	(INTERACT_DIALOG): New method.

	* src/interact.c (make_interact_dialog): New function.

	* src/debug.c (do_debug): Censor packets of type
	SSH_MSG_USERAUTH_INFO_RESPONSE. 

	* src/client_userauth.c (client_password_method): Renamed class
	to...
	(client_userauth_interactive_method): ... Used for both "password"
	and "keyboard-interactive".
	(format_userauth_kbdinteract, format_userauth_info_response): New
	functions.
	(client_kbdinteract_state, userauth_info_request_handler): New
	classes.
	(do_userauth_info_request, make_userauth_info_request_handler)
	(do_kbdinteract_failure, make_client_kbdinteract_state)
	(do_kbdinteract_login, make_client_kbdinteract_auth): New
	functions.

	* src/atoms.in: Added "keyboard-interactive". 

	Changes to utf8 decoding.
	* src/charset.h (enum utf8_flag): New enum.

	* src/charset.c (utf8_to_local, low_utf8_to_local): Implemented
	control character fitlering. Replaced STRICT argument with two
	flags utf8_replace and utf8_paranoid.
	(ucs4_is_control): New function.
	(local_is_utf8): Deleted function.

	* src/werror.c (werror_vformat): Improved utf8 handling. Always
	convert with utf8_replace, and add utf8_paranoid in paranoia mode.
	
2004-09-22  Niels Mller  <niels@s3.kth.se>

	* acinclude.m4 (LSH_CCPIC): Don't use -fpic on cygwin.

2004-08-31  Niels Mller  <nisse@lysator.liu.se>

	* acinclude.m4 (LSH_CCPIC): New macro.

2004-07-16  Niels Mller  <nisse@lysator.liu.se>

	* src/client.c (do_background_process): Fixed C99-ism.

2004-06-22  Niels Mller  <niels@s3.kth.se>

	* src/parse.c (parse_utf8): Use unsigned variables.

	* src/testsuite/inetd-test: New test case, not yet enabled.

2004-06-17  Niels Mller  <nisse@lysator.liu.se>

	* src/parse.c (parse_utf8): Check that the buffer doesn't end in
	the middle of an utf8 sequence.

2004-06-15  Niels Mller  <niels@s3.kth.se>

	* src/version.h (SOFTWARE_SLOGAN): New macro; string appended to
	the software version in the initial handshake.

	* src/lsh.c (main_argp_parser): Added support for
	diffie-hellman-group14-sha1. 
	* src/lshd.c (main_argp_parser): Likewise.

	* src/dh_exchange.c (make_dh14): New function.

	* src/publickey_crypto.c (zn_member): Deleted unused method.
	(zn_range, zn_invert, zn_mul, zn_exp, zn_exp_ui, zn_add, zn_sub):
	Non-static functions replaces the GROUP_COMBINE etc methods.
	(make_group_zn, make_ring_zn): Deleted functions...
	(make_ssh_group): ... replaced by new funtion.
	(make_ssh_group1, make_ssh_ring_srp_1): Use make_ssh_group.
	(make_ssh_group14): New function.

	* src/publickey_crypto.h (abstract_group): Deleted class and
	methods.
	(zn_group): Declare class here, and plain functions for using it.
	Replaced all uses of struct abstract_group with const struct
	zn_group.
	(dh_instance): Use const for the dh_method pointer.
	
	* src/atoms.in: Added diffie-hellman-group14-sha1.

2004-06-12  Niels Mller  <nisse@lysator.liu.se>

	* configure.ac: Bumped version to 1.5.6.

	* Released lsh-1.5.5.

2004-06-10  Niels Mller  <nisse@lysator.liu.se>

	* src/keyexchange.c (parse_kexinit): Deleted unused argument
	peer_flags.

	* misc/Makefile.am (EXTRA_DIST): Include tsocks-forcelocal.patch.

	* src/algorithms.c (lookup_hash): Deleted unused function.
	(all_symmetric_algorithms): Deleted old aes alias
	rijndael-cbc@lysator.liu.se. Added official serpent name
	serpent256-cbc. The alias serpent-cbc@lysator.liu.se should be
	removed at a later date.	
	(all_crypto_algorithms): Likewise.
	(lookup_crypto): Likewise.

	* src/atoms.in: Deleted spki-related atoms, now handled by
	libspki. Also deleted pkcs5-related atoms that aren't used.
	Deleted rijndael-cbc@lysator.liu.se.
	
2004-06-09  Niels Mller  <niels@s3.kth.se>

	* src/testsuite/functions.sh: Removed -q from LSHD_FLAGS.

	* src/server_pty.c (SYSTEM_GROUP): New macro.
	(pty_check_permissions): If there's no "tty" group, try "system".

	* src/testsuite/Makefile.am (TS_SH): Removed ssh1-fallback-test.
	(EXTRA_DIST): Removed fake-sshd1.

	* src/testsuite/fake-sshd1, src/testsuite/ssh1-fallback-test:
	Deleted files.

	* src/version.h (SSH1_SERVER_PROTOCOL_VERSION): Deleted.

	* src/Makefile.am (liblsh_a_SOURCES): Removed ssh1_fallback.c.

	* src/lshd.c: Removed the ssh1-fallback option.

	* src/handshake.c (do_line): Made the server disallow banner lines
	from clients.

	* configure.ac: Deleted option --with-sshd1.

	* src/io.c (io_set_blocking): Deleted function.

	* src/handshake.c (connection_line_handler): Deleted fd and
	fallback attributes.
	(make_connection_read_line): Deleted fd and fallback arguments.
	(make_handshake_info): Deleted fallback argument. Updated callers.
	(do_line): Deleted ssh1-fallback handling.
	
	* src/ssh1_fallback.h, src/ssh1_fallback.c: Deleted file.

	* src/handshake.h (handshake_info): Deleted fallback attribute.

	* doc/lsh.texinfo (Invoking lshd): Deleted --ssh1-fallback.

	* src/keyexchange.c (KEXINIT_MAX_ALGORITMS): Increased limit to
	500.
	(parse_kexinit): Deleted code handling of
	PEER_KEXINIT_LANGUAGE_KLUDGE.

	* src/handshake.c (compat_peer_flags): #if:ed out function.

	* src/connection.h (enum peer_flags): Deleted constants.

	* configure.ac: Deleted option --disable-datafellows-workarounds.

	* src/proxy_x11forward.c (do_proxy_open_x11): Deleted code
	handling PEER_X11_OPEN_KLUDGE.

2004-06-08  Niels Mller  <nisse@lysator.liu.se>

	* src/client.c (client_prepend_action): New function.

	* src/client.c (client_options): New option --write-pid, to be
	used together with -B.
	(do_background_process): Optionally write the child pid to stdout.
	(make_background_process): New function.
	(client_argp_parser): When processing -B, pass the value of
	write_pid to make_background_process.
	(client_argp_parser): Handle --write-pid.

	Testsuite tweaks.
	* src/testsuite/lshg-1-test, src/testsuite/lshg-cat-2-test,
	src/testsuite/lshg-cat-test, src/testsuite/lshg-tcpip-local-test,
	src/testsuite/socks4-test, src/testsuite/socks5-test,
	src/testsuite/tcpip-local-in-use-test,
	src/testsuite/tcpip-local-test: Deleted unnessary sleep calls.

	* src/testsuite/functions.sh (at_connect): For the
	tcpip-local-in-use-test to work, we must record the mini-inetd
	pid, and kill it before exiting.

	* src/testsuite/functions.sh (spawn_lsh, spawn_lshg): Use new
	--write-pd option and -B to start processes in the background.

	* src/lsh.c (main_argp_parser): Use client_prepend_action to make
	sure that the gateway is started first.

	Removal of old bug-compatibility code.
	* src/handshake.c: Deleted most of the bug-compatibility flags. 

	* src/client_userauth.c (do_userauth_pk_ok): Deleted handling of
	PEER_USERAUTH_REQUEST_KLUDGE. 
	* src/server_publickey.c (do_authenticate): Likewise.

	* src/server.c (format_service_accept_kludge): Deleted function.
	(do_service_request): Deleted handling of
	PEER_SERVICE_ACCEPT_KLUDGE.

	* src/client.c (do_accept_service): Deleted handling of
	PEER_SERVICE_ACCEPT_KLUDGE. 
	* src/proxy.c (do_proxy_accept_service): Likewise.

	* src/dsa.c (do_dsa_verify, do_dsa_sign): Deleted handling of
	ATOM_SSH_DSS_KLUDGE_LOCAL. 

	* src/client_keyexchange.c (do_handle_dh_reply): Deleted handling
	of PEER_SSH_DSS_KLUDGE.
	* src/server_keyexchange.c (do_init_server_dh): Likewise.
	* src/server_publickey.c (do_authenticate): Likewise.

	* src/atoms.in: Deleted ssh-dss-kludge@lysator.liu.se.

2004-06-08  Niels Mller  <niels@s3.kth.se>

	* src/client.c (client_options): Deleted --cvs-workaround option.
	(client_argp_parser): Deleted handling of --cvs-workaround.
	(fork_input): Deleted function.
	(fork_output): Deleted function.
	(make_client_session): Keep our original stdio fd:s in blocking
	mode, and pass the type IO_STDIO to make_lsh_fd when appropriate.
	(do_detach_cb): Resetting stdio to blocking mode is no longer
	needed.

	* src/client.h (client_options): Deleted stdin_fork, stdout_fork
	and stderr_fork attributes.

	* src/werror.c (set_error_nonblocking): Deleted function.

	* src/server_session.c (spawn_process): Pass correct type
	(IO_NORMAL or IO_PTY) to make_lsh_fd. io_set_type is no longer
	needed. 

	* src/io.h (enum io_type): New type IO_STDIO.

	* src/io.c (io_final): No longer any need to reset stdio file
	descriptors to blocking mode.
	(write_raw_with_poll): Deleted function.
	(io_set_type): Deleted function.
	(io_init_fd): New argument, allowing certain fd:s to remain in
	blocking mode.
	(make_lsh_fd): New argument TYPE. Updated callers.
	(close_fd): Don't close fd:s that are of type IO_STDIO.

2004-04-07  Niels Mller  <nisse@lysator.liu.se>

	* src/server_pty.c (pty_open_slave): More verbose messages on failure.

	* src/write_packet.c (do_write_packet): Deleted debug output that
	may contain passwords.

2004-03-20  Niels Mller  <nisse@lysator.liu.se>

	* configure.ac: Use AC_CONFIG_AUX_DIR([.]).

2004-03-18  Niels Mller  <niels@s3.kth.se>

	* misc/run-tests (test_program): Strip .exe suffix from name.

2004-03-17  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/Makefile.am (TS_SH): Run the socks4 and socks5
	tests. This is pointless, and hopefully harmless, on machines that
	don't have my hacked version of tsocks.

	* src/socks.c (socks_reply): Send a version 4 reply, if
	appropriate.
	(do_read_socks): Almost implemented socks4. Handling of username
	is slightly broken.

	* src/testsuite/socks4-test: New file.
	* src/testsuite/socks4-config: New file.

	* misc/tsocks-forcelocal.patch: New file.

	* misc/tsocks-forcelocal.patch: Also patch the tsocks script to
	look for the library in $libdir.

2004-03-15  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/socks5-config: Added forcelocal keyword.

2004-03-01  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/functions.sh (need_tsocks): New function.

2004-03-01  Niels Mller  <niels@s3.kth.se>

	* acinclude.m4 (LSH_FUNC_ALLOCA): Check for malloc.h, and include
	it if it exists. Needed for alloca on windows.

2004-02-29  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/socks5-config: tsocks configuration file for
	socks5 test case.

	* src/testsuite/socks5-test: New socks5 test.

	* src/testsuite/tcpip-local-test: Check both directions of
	forwarded channel.

	* src/io.c (io_connect_list): Avoid resource leakage if the
	address list is empty, or all connection attempts fail
	immediately. 

	* src/socks.c (do_read_socks): Bugfix, update self->pos.

	* src/client.c (client_arg_unsigned): Typo fix.

	* src/lshg.c (main_options): Deleted short options -I and -D. The
	corresponding long options --send-debug and --send-ignore remains.

	* src/socks.c (do_read_socks): Fixed bugs in parsing of client's
	first message.

2004-02-27  Niels Mller  <nisse@lysator.liu.se>

	* src/client.c (client_argp_parser): New command line option -D,
	--forward-socks. 	
	(client_arg_unsigned): New function.

	* src/lshd.c: Don't include tcpforward_commands.h.

	* src/tcpforward_commands.c (make_open_tcpip_command): Made non-static.
	(open_direct_tcpip): Moved declaration back here, reverting
	yesterday's change.
	
	* src/tcpforward_commands.h: Deleted file. Prototypes moved to...
	* src/tcpforward.h: ...here.

	* src/socks.c: Rewritten. A successful connect should transform
	the control channel into a data channel.

	* src/process_atoms: Added extra quotes needed to get the length
	of "*" into atoms_table.c.

	* src/lsh.c (main): make_lsh_connect now returns a struct command *, so
	can delete one CAST_SUBTYPE.

	* src/channel_forward.c (channel_forward_start_io_read): New function.

2004-02-26  Niels Mller  <nisse@lysator.liu.se>

	* src/lsh_string.c (lsh_string_ntop): Use const void * for the
	input. 

	* src/tcpforward_commands.h (open_direct_tcpip,
	OPEN_DIRECT_TCPIP): Moved declarations here...
	* src/tcpforward_commands.c: ... from here.

	* src/socks.c: New file.
	* src/Makefile.am (liblsh_a_SOURCES): Added socks.c.

	* src/scm/gaba.scm (process-expr): Let the generated code return a
	struct command *, not a struct lsh_object *.

	* src/dummy.c (cbc_encrypt, cbc_decrypt): Use nettle_crypt_func
	for typing. 

2004-02-25  Niels Mller  <nisse@lysator.liu.se>

	* misc/xenofarm.sh (cfgwarn, makewarn, ckprgwarn): Renamed
	variables log, warn and fail. 

2004-02-24  Niels Mller  <nisse@lysator.liu.se>

	* misc/xenofarm.sh (dotask): Fixed handling of $var.
	(cfgwarn, makewarn, ckprgwarn): Use $task when constructing
	filenames.

	* misc/xenofarm.sh: Fixed tasks argpmake and nettlemake. New tasks
	ckargp and cknettle.

	* src/Makefile.am (lshg_SOURCES, lshg_LDADD): Avoid linking with
	nettle. Need to link with dummy.o instead.

	* src/dummy.c: New file.

	* misc/xenofarm.sh (cfgargs): Add the flags we want to use to cfgargs.
	(dotask): New optional argument with the name of the status variable.

2004-02-20  Niels Mller  <nisse@lysator.liu.se>

	* src/process_atoms: Fixes to make it work with Solaris /bin/sh.
	Replaced uses of echo -n with printf(1), and ${#foo} with `expr
	$foo : '.*'`.

2004-02-20  Niels Mller  <niels@s3.kth.se>

	* src/scm/Makefile.am (EXTRA_DIST): Deleted make-char-classes.

	* configure.ac: Deleted tests for bash.

	* src/Makefile.am (atoms_gperf.c, atoms_table.c): Don't use
	bash to run process_atoms script.
	(packet_types.h): Don't use bash to run the invert-defs script.

2004-02-19  Niels Mller  <niels@s3.kth.se>

	* src/scm/guile-compat.scm: Deleted most of the contents.

	* src/scm/make-char-classes.scm: Deleted obsolete file.

2004-02-18  Niels Mller  <niels@s3.kth.se>

	* src/Makefile.am (prime_table.h, sexp_table.h, digit_table.h):
	Deleted rules for building obsolete files.

2004-02-18  Pontus Skld  <pont@soua.net>

	* src/process_atoms: Converted script from bash to /bin/sh.

2004-02-17  Niels Mller  <nisse@lysator.liu.se>

	* src/unix_user.c (do_lookup_user) [!HAVE_SHADOW_H]: Enable shadow
	database code only if shadow.h can be included.

	* src/unix_process.c (do_logout_notice): Deleted gratious
	semicolon at end of function definition.
	(do_utmp_cleanup): Use UTMPX_UT_EXIT___E_TERMINATION and
	UTMPX_UT_EXIT_UT_TERMINATION. 

	* configure.ac: Check for ut_exit.__e_termination and
	ut_exit.ut_termination in struct utmp and struct utmpx.

2004-02-16  Niels Mller  <niels@s3.kth.se>

	* configure.ac: Added gss-related configure checks (patch from
	Simon Josefsson).

2004-02-15  Niels Mller  <nisse@lysator.liu.se>

	* src/testsuite/Makefile.am (AM_CPPFLAGS): Need -I.., in order to
	include nettle-types.h.

	* src/unix_user.c (do_lookup_user): Just ignore shadow database if
	getspnam returns NULL.

	* src/lsh.h: #include nettle/types.h instead of inttypes.h.

	* src/atoms.h: #include lsh.h instead of inttypes.h.
	* src/charset.h: Likewise.
	* src/tty.h: Likewise.
	* src/testsuite/testutils.h: Likewise.

	* configure.ac: Bumped version to 1.5.5.

2004-02-13  Niels Mller  <niels@s3.kth.se>

	* src/ssh.h: Added GSSAPI constants (patch from Simon Josefsson).
	* src/atoms.in: New symbol "gssapi".

2004-02-12  Niels Mller  <nisse@lysator.liu.se>

	* src/io.c (address_info2sockaddr) [!HAVE_GETADDRINFO]: Updated
	code to work with new string abstraction.

2004-02-12  Niels Mller  <niels@s3.kth.se>

	* configure.ac: No space between "-I" and include directories.

2004-02-08  Niels Mller  <nisse@lysator.liu.se>

	* Released lsh-1.5.4.

	Implemented flow control for the connections write_buffer. The
	buffer is now of limited size. When it starts to get large, channel
	i/o is disabled. If it hits the limit, the connection is closed.

	* src/connection.c (WRITE_BUFFER_MAX, WRITE_BUFFER_MARGIN): New
	constants.
	(connection_flow_controlled): New class.
	(do_connection_flow_controlled): Reenable channel i/o when we have
	room in the write buffer.
	(make_ssh_connection): Initialize ssh_connection attributes
	wakeup, soft_limit and hard_limit.
	(connection_init_io): Changed argument type from struct
	abstract_write to struct lsh_fd. Install flow control on the
	socket's write_buffer. Deleted the randomness argument, and don't
	call make_packet_write. This way, both handshake_command and
	gateway_make_connection can call this function.
	(connection_wakeup): New function, which installs a wakeup
	callback on the connection.
	(connection_send_kex): Compare the size of the write_buffer to the
	soft and hard limits.
	(connection_send_kex_end): Invoke wakeup callback, if it's
	non-NULL.

	* src/connection.h (ssh_connection): New attribute socket,
	replaces old attribute raw. New attributes hard_limit and
	soft_limit. 

	* src/read_data.c (do_read_data_query): Stop reading, if
	connection->hard_limit is set, indicating an almost full
	write_buffer for the connection.

	* src/handshake.c (handshake_command): Adapt to changed
	connection_init_io. Use connection->socket instead of
	connection->raw. 

	* src/gateway_commands.c (gateway_make_connection): Use
	connection_init_io, so that flow control is set up properly.

	* src/channel.c (window_adjust_handler): Deleted redundant assert.
	(do_channels_after_keyexchange): Renamed to do_channels_wakeup. No
	longer needs to reinstall the handler.
	(init_connection_service): Use connection_wakeup, not
	connection_after_keyexchange. 

2004-02-07  Niels Mller  <nisse@lysator.liu.se>

	* install-sh: Removed from CVS repository. Let automake supply it.

	* acinclude.m4 (LSH_FUNC_ALLOCA): Include <alloca.h>, if
	available, also when compiling with gcc.

2004-01-08  Niels Mller  <nisse@lysator.liu.se>

	* src/rsync/rsync.h: Don't include inttypes.h, just let
	<nettle/md5.h> define uint8_t and other types.

	* src/Makefile.am (AM_CPPFLAGS): Added -I./nettle. Needed to find
	the nettle-types.h include file when building outside of the
	source directory.
	(packet_types.h): Changed rule to use $< to refer to the input
	file. 
	* src/testsuite/Makefile.am (AM_CPPFLAGS): Added -I../nettle.
	* src/rsync/Makefile.am (AM_CPPFLAGS): Added -I../nettle.

2004-01-08  Niels Mller  <niels@s3.kth.se>

	* src/tcpforward.c (do_channel_open_direct_tcpip): Log
	direct-tcpip request.
	(do_tcpip_forward_request): Log forward-tcpip request.