Commit 441fbd9b authored by Niels Möller's avatar Niels Möller
Browse files

Comment update.

Rev: src/crypto.c:1.40
Rev: src/daemon.c:1.20
Rev: src/dsa.c:1.45
Rev: src/gateway_channel.c:1.32
Rev: src/gateway_tcpforward.c:1.3
Rev: src/gc.c:1.37
Rev: src/spki.c:1.65
Rev: src/unix_random.c:1.21
parent e0e1826d
......@@ -743,8 +743,7 @@ crypt_string(struct crypto_instance *c,
return out;
}
/* FIXME: Missing testcases. This is only used for encrypted private
* keys. */
/* This is only used for encrypted private keys. */
/* Consumes input string. */
struct lsh_string *
crypt_string_pad(struct crypto_instance *c,
......
......@@ -132,8 +132,6 @@ daemon_started_by_init(void)
Closing stdin and stdout. We also wouldn't need to fork(2) and
exec(2) because there isn't a controlling terminal in sight. */
/* FIXME: Do we need to detect if the socket is listening or connected
* to a peer? */
static int
daemon_started_by_inetd(void)
{
......
......@@ -186,8 +186,6 @@ do_dsa_public_spki_key(struct verifier *s, int transport)
static void
init_dsa_verifier(struct dsa_verifier *self)
{
/* FIXME: The allocator could do this kind of initialization
* automatically. */
dsa_public_key_init(&self->key);
self->super.verify = do_dsa_verify;
......
......@@ -183,9 +183,8 @@ do_gateway_channel_event(struct ssh_channel *c, enum channel_event event)
case CHANNEL_EVENT_STOP:
case CHANNEL_EVENT_START:
/* FIXME: Ignore? The entire gateway has to be stopped and
started anyway. Or do we need to buffer one window of
data? */
/* Ignore. The channel doesn't do any i/o of its own, so flow
control must be handled elsewhere. */
break;
}
}
......
......@@ -222,7 +222,8 @@ struct global_request
gateway_tcpip_forward_handler =
{ STATIC_HEADER, do_gateway_tcpip_forward_handler };
/* FIXME: Implement cancelling? */
/* Not implemented. The client never sends CANCEL_TCPIP_FORWARD to a
gateway. */
#if 0
static void
do_gateway_cancel_tcpip_forward_handler(struct global_request *s UNUSED,
......
......@@ -82,7 +82,9 @@ static void gc_mark(struct lsh_object *o)
/* Fall through */
case LSH_ALLOC_STATIC:
/* Can't use mark bit on static objects, as there's no way to
* reset all the bits */
* reset all the bits. FIXME: Check if any static object ever
* points to a non-static one. If they don't, there's no need to
* process them at all. */
assert(!o->dead);
{
struct lsh_class *class;
......
......@@ -388,7 +388,6 @@ spki_pkcs5_encrypt(struct lsh_string *label,
assert(crypto);
assert(prf);
/* NOTE: Allows random to be of bad quality */
salt = lsh_string_random(salt_length);
key = pkcs5_derive_key(prf,
......
......@@ -289,7 +289,6 @@ random_init(const struct lsh_string *seed_file_name)
seed_file_fd = open(lsh_get_cstring(seed_file_name), O_RDWR);
if (seed_file_fd < 0)
{
/* FIXME: Offer to create seed file for the user. */
werror("No seed file. Please create one by running\n");
werror("lsh-make-seed -o \"%S\".\n", seed_file_name);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment