Commit 5454d957 authored by Niels Möller's avatar Niels Möller

*** empty log message ***

Rev: ChangeLog:1.419
Rev: src/channel_commands.c:1.26
Rev: src/client_pty.c:1.21
Rev: src/client_session.c:1.12
Rev: src/client_x11.c:1.15
Rev: src/connection.c:1.65
Rev: src/gateway_commands.c:1.12
Rev: src/gc.c:1.25
Rev: src/lsh.c:1.150
Rev: src/lshd.c:1.127
Rev: src/proxy.c:1.14
Rev: src/server_session.c:1.70
Rev: src/server_userauth.c:1.35
parent bd932e60
2001-09-27 Niels Mller <nisse@cuckoo.hack.org>
* src/resource.c (make_resource_list): Renamed functions, was
empty_resource_list. Updated all callers.
(dont_free_live_resource): #if:ed out check of gc_final_p.
* src/io_commands.c: Deleted old function do_io_read_file.
* src/io.c: Deleted old backend code.
(io_run): Check for OOP_ERROR. #if:ed out for now, as it is not
defined in liboop-0.7.
* src/client.c (accept_service_handler): Deleted exception_handler
attribute.
(do_accept_service): Use the connection's exception handler for
raising protocol error.
(make_accept_service_handler): Deleted exception_handler argument.
* src/channel.c (send_channel_request_responses): Deleted
connection argument.
(make_channel_request_response): Likewise.
(channel_request_exception_handler): Deleted connection attribute.
(make_channel_request_exception_handler): Deleted connection
argument.
2001-09-26 Niels Mller <nisse@ehand.com>
* src/server_session.c (shell_request_handler,
......
......@@ -68,8 +68,8 @@ do_channel_open_command(struct command *s,
}
else
{
/* FIXME: Set up channel->write here? If we do that, perhaps we
* need not pass the connection to NEW_CHANNEL. */
/* FIXME: Set up channel->connection here? If we do that,
* perhaps we need not pass the connection to NEW_CHANNEL. */
channel->open_continuation = c;
channel->e = e;
register_channel(index, channel, 0);
......
......@@ -127,11 +127,7 @@ make_client_winch_handler(struct ssh_channel *channel)
(req object pty_request)))
*/
/* FIXME: !!! failed requests show up as an exception. /Bazsi
*
* I think that is normal. It's up to the caller to do something reasonable
* about the exception. /nisse
*/
/* NOTE: Failed requests show up as exceptions. */
static void
do_pty_continuation(struct command_continuation *s,
struct lsh_object *x)
......
......@@ -55,7 +55,6 @@
/* Callback used when the server sends us eof */
/* FIXME: Perhaps unify with server_session.c:do_eof */
static void
do_client_session_eof(struct ssh_channel *c)
{
......@@ -136,10 +135,10 @@ do_client_io(struct command *s UNUSED,
channel->receive = do_receive;
/* FIXME: It seems a little kludgy to modify
* exception handlers here; it would be better to create the
* fd-objects at a point where the right exception handlers can be
* installed from the start. */
/* FIXME: It seems a little kludgy to modify exception handlers
* here; it would be better to create the fd-objects at a point
* where the right exception handlers can be installed from the
* start. */
session->out->e
= make_channel_io_exception_handler(channel,
"lsh: I/O error on stdout",
......
......@@ -63,7 +63,7 @@
(auth string)))
*/
/* FIXME: Perhaps merge auth_info directly into this struct */
/* FIXME: Perhaps merge auth_info directly into this struct. */
/* GABA:
(class
(name client_x11_display)
......
......@@ -292,7 +292,7 @@ make_ssh_connection(UINT32 flags,
connection->peer_flags = 0;
connection->user = NULL;
connection->resources = empty_resource_list();
connection->resources = make_resource_list();
connection->rec_max_packet = SSH_MAX_PACKET;
......
......@@ -49,7 +49,7 @@
* uint32 packet_length
* byte[n] payload; n = packet_length
*
* But then we can reuse the plain read_packet class. */
* But then we can't reuse the plain read_packet class. */
static void
do_gateway_pad(struct abstract_write *w,
......
......@@ -228,7 +228,7 @@ void
gc_global(struct resource *o)
{
if (!root_set)
root_set = empty_resource_list();
root_set = make_resource_list();
assert(root_set->super.alive);
......
......@@ -627,6 +627,10 @@ main_options[] =
0, "", CLIENT_ARGP_ACTION_GROUP },
{ "gateway", 'G', NULL, 0, "Setup a local gateway", 0 },
/* FIXME: Perhaps this should be moved from lsh.c to client.c? It
* doesn't work with lshg. Or perhaps that can be fixed?
* About the same problem applies to -R. */
{ "x11-forward", 'x', NULL, 0, "Enable X11 forwarding.", CLIENT_ARGP_MODIFIER_GROUP },
{ "no-x11-forward", 'x' | ARG_NOT, NULL, 0,
"Disable X11 forwarding (default).", 0 },
......
......@@ -731,7 +731,6 @@ main_argp =
*/
#if WITH_GCOV
/* FIXME: Perhaps move to daemon.c? */
/* Catch SIGTERM and call exit(). That way, profiling info is written
* properly when the process is terminated. */
......@@ -888,10 +887,6 @@ int main(int argc, char **argv)
connection_hooks
= make_object_list (1, session_setup, -1);
{
/* FIXME: We should check that we have at least one host key. We
* should also extract the host-key algorithms for which we have
* keys, instead of hardcoding ssh-dss below. */
CAST_SUBTYPE(command, connection_service,
make_lshd_connection_service(connection_hooks));
CAST_SUBTYPE(command, server_listen,
......
......@@ -68,11 +68,8 @@ do_exc_chain_connections_handler(struct exception_handler *c,
self->connection->chain->chain = NULL;
self->connection->chain = NULL; /* prevent raising this exception again */
/* FIXME: is it possible to pass the same exception to two handlers?
*
* It should be. /nisse
*/
/* NOTE: It's fine to pass the same exception to several
* handlers. */
EXCEPTION_RAISE(chain->e, e);
}
}
......
......@@ -126,7 +126,6 @@ do_send_adjust(struct ssh_channel *s,
}
}
/* FIXME: Perhaps unify with client_session.c:do_client_session_eof */
static void
do_eof(struct ssh_channel *channel)
{
......
......@@ -110,6 +110,11 @@ format_userauth_success(void)
* is rather stupid. And will crash if a userauth method returns to
* the main loop while the connection is still locked. */
/* FIXME: I don't think the about is true anymore. Locking should
* work, packets queued up properly while a connection is locked, etc.
* This is needed for password userauthentication using a password
* helper process. */
/* GABA:
(class
(name userauth_continuation)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment