*** empty log message ***

Rev: doc/TODO:1.113
Rev: src/io.c:1.134
Rev: src/lshg.c:1.9
Rev: src/unix_user.c:1.36

doc/TODO

@@ -75,6 +75,16 @@ even deleted.
 The CHANNEL_CLOSE_AT_EOF should be enabled by default. It is the
 correct behaviour for all channels except the server side of sessions.
 
+The following bug should be eliminated: I use lshg to get a large
+file,
+
+  src/lshg -v --trace --debug >lsh-test.log.gz sture.lysator.liu.se
+  cat 'incoming/lsh-test.log.gz' 2>lshg.log
+
+The file is 0x614ef9 bytes, but only 0x610000 bytes gets through.
+Looking at the lshg log, the final SSH_MSG_DATA packet(s) is missing,
+so the data is lost either in lsh, or in the remote opensshd.
+
 
 FREENESS
 

src/io.c

@@ -747,8 +747,8 @@ do_write_callback(struct io_callback *s UNUSED,
 	break;
       case EPIPE:
 	debug("io.c: Broken pipe.\n");
-	close_fd(fd);
-	break;
+	
+	/* Fall through */
       default:
 	werror("io.c: write failed, %z\n", STRERROR(errno));
 	EXCEPTION_RAISE(fd->e,
@@ -1799,6 +1799,9 @@ void close_fd_nicely(struct lsh_fd *fd)
 {
   /* Don't attempt to read any further. */
 
+  trace("io.c: close_fd_nicely called on fd %i: %z\n",
+	fd->fd, fd->label);
+  
   fd->want_read = 0;
   fd->read = NULL;
   

src/lshg.c

@@ -279,6 +279,9 @@ main(int argc, char **argv)
 
   io_run(backend);
 
+  /* Close all files and other resources associated with the backend. */
+  io_final(backend);
+
   gc_final();
   
   return exit_code;

src/unix_user.c

@@ -685,6 +685,9 @@ do_chdir_home(struct lsh_user *u)
   return 1;  
 }
 
+/* FIXME: initgroups in glibc (and possibly on other systems as well)
+ * is broken, and can't handle more than 32 groups. We need a
+ * workaround for that. */
 static int
 change_uid(struct unix_user *user)
 {