Commit 72bdaef1 authored by Niels Möller's avatar Niels Möller
Browse files

Comment fixes.

Rev: src/transport.h:1.11
Rev: src/transport_forward.c:1.8
Rev: src/transport_read.c:1.9
parent b9449f73
...@@ -180,7 +180,7 @@ transport_write_flush(struct transport_write_state *self, ...@@ -180,7 +180,7 @@ transport_write_flush(struct transport_write_state *self,
(kexinit object make_kexinit))) (kexinit object make_kexinit)))
*/ */
/* Use primarily for the key exchange method */ /* Uses for the key exchange method */
/* GABA: /* GABA:
(class (class
......
...@@ -59,6 +59,9 @@ forward_start_write(struct transport_forward *self); ...@@ -59,6 +59,9 @@ forward_start_write(struct transport_forward *self);
static void static void
forward_stop_write(struct transport_forward *self); forward_stop_write(struct transport_forward *self);
/* FIXME: Let a NULL kill imply a kill method equivalent to
transport_forward_kill (like it's set up in
lshd.c:kill_lshd_connection. */
void void
init_transport_forward(struct transport_forward *self, init_transport_forward(struct transport_forward *self,
void (*kill)(struct resource *s), void (*kill)(struct resource *s),
...@@ -189,6 +192,12 @@ forward_start_read(struct transport_forward *self) ...@@ -189,6 +192,12 @@ forward_start_read(struct transport_forward *self)
if (!self->service_read_active) if (!self->service_read_active)
{ {
self->service_read_active = 1; self->service_read_active = 1;
/* FIXME: Must also arrange so that buffered data is read. Set
up an OOP_TIME_NOW callback, and have it loop around
service_read_packet in a similar way as
transport.c:transport_start_read. */
global_oop_source->on_fd(global_oop_source, self->service_in, global_oop_source->on_fd(global_oop_source, self->service_in,
OOP_READ, oop_read_service, self); OOP_READ, oop_read_service, self);
} }
...@@ -267,9 +276,6 @@ forward_event_handler(struct transport_connection *connection, ...@@ -267,9 +276,6 @@ forward_event_handler(struct transport_connection *connection,
switch (event) switch (event)
{ {
case TRANSPORT_EVENT_START_APPLICATION: case TRANSPORT_EVENT_START_APPLICATION:
/* FIXME: Must also arrange so that buffered data is read. Set
up an OOP_TIME_NOW callback, and have it loop around
service_read_packet in a similar way as oop_read_service. */
forward_start_read(self); forward_start_read(self);
break; break;
......
...@@ -343,7 +343,7 @@ transport_read_packet(struct transport_read_state *self, int fd, ...@@ -343,7 +343,7 @@ transport_read_packet(struct transport_read_state *self, int fd,
} }
/* Approximate test, to avoid overflow when computing the total /* Approximate test, to avoid overflow when computing the total
size. Precice comparison to available buffer space comes size. Precise comparison to available buffer space comes
later. */ later. */
if (packet_length > (SSH_MAX_PACKET + SSH_MAX_PACKET_FUZZ)) if (packet_length > (SSH_MAX_PACKET + SSH_MAX_PACKET_FUZZ))
{ {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment