Commit f12b38c0 authored by Niels Möller's avatar Niels Möller
Browse files

*** empty log message ***

Rev: ChangeLog:1.233
Rev: doc/HACKING:1.12
Rev: doc/TODO:1.86
parent 9b95ddcb
2000-08-04 Niels Mller <nisse@cuckoo.localdomain> 2000-08-04 Niels Mller <nisse@cuckoo.localdomain>
* src/client_userauth.c (client_userauth_failure): Added again
argument to the CLIENT_USERAUTH_FAILURE method.
(client_userauth_state): Added attribute next.
(userauth_method_is_useful): New function.
(do_userauth_failure): Don't modify current. Instead, increment
next as appropriate, and pass the new again argument to
CLIENT_USERAUTH_FAILURE
(do_exc_client_userauth): Update current correctly, unsing the new
next attribute.
(exc_userauth_disconnect): New class.
(make_exc_userauth_disconnect): New function.
(do_client_userauth): Use make_exc_userauth_disconnect().
(send_password): Simplified tried_empty_passwd handling; just
increment it.
(do_password_failure): Use again and tried_empty_passwd to figure
out what to do.
* src/client_userauth.c (exc_client_userauth): Renamed (was
client_exc_userauth). Updated all uses.
* src/command.h: Made declaration of command_die_on_null extern. * src/command.h: Made declaration of command_die_on_null extern.
* src/client_userauth.c: Added trace output. * src/client_userauth.c: Added trace output.
......
...@@ -409,7 +409,10 @@ These are names of packet handlers. There's no common suffix for ...@@ -409,7 +409,10 @@ These are names of packet handlers. There's no common suffix for
packet handler types; perhaps there should be. packet handler types; perhaps there should be.
Types that inherit command or command_continuation should have a Types that inherit command or command_continuation should have a
_command or _continuation prefix. Below, TYPE stands for a type name, _command or _continuation suffix. Types that inherit exception_handler
should ahve an exc_ prefix.
Below, TYPE stands for a type name,
and METHOD for the name one of its methods. and METHOD for the name one of its methods.
The constructor function for a TYPE should be make_TYPE(). Functions The constructor function for a TYPE should be make_TYPE(). Functions
......
...@@ -228,8 +228,3 @@ Should lsh fail if some port forwardings fails? In particular, ...@@ -228,8 +228,3 @@ Should lsh fail if some port forwardings fails? In particular,
is pretty useless if the server doesn't let us bind the remote port. is pretty useless if the server doesn't let us bind the remote port.
There's a bug in client_userauth.c, related to
client_userauth_state->current. It is incremented at two places, in
do_userauth_failure and do_client_exc_userauth, but a single
SSH_MSG_USERAUTH_FAILURE message should result in incrementing it at
at most one of those places.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment