ChangeLog 283 KB
Newer Older
Niels Möller's avatar
Niels Möller committed
1
2
3
2014-04-27  Niels Möller  <nisse@lysator.liu.se>

	* nettle.texinfo (Cipher modes): Subsection on AEAD constructions.
Niels Möller's avatar
Niels Möller committed
4
5
	(GCM): Update GCM documentation, including functions for
	gcm_aes128, gcm_camellia128, ...
Niels Möller's avatar
Niels Möller committed
6

7
8
2014-04-26  Niels Möller  <nisse@lysator.liu.se>

9
10
	* nettle.texinfo: Update for introduction of nettle_cipher_func.
	(GCM): Document GCM_DIGEST_SIZE.
11
	(UMAC): Document new UMAC constants.
12
	(Keyed hash functions): Make HMAC and UMAC their own info nodes.
Niels Möller's avatar
Niels Möller committed
13
	(EAX): Document EAX.
14

15
16
17
	* umac.h (UMAC_MIN_NONCE_SIZE, UMAC_MAX_NONCE_SIZE): New
	constants.

18
19
2014-04-25  Niels Möller  <nisse@lysator.liu.se>

20
21
	* All hash-related files: Renamed all _DATA_SIZE constants to
	_BLOCK_SIZE, for consistency. Old names kept for backwards
22
	compatibility.
23

Owen Kirby's avatar
Owen Kirby committed
24
25
26
	* nettle.texinfo (CCM): Documentation for CCM mode, contributed by
	Owen Kirby.

27
28
29
30
31
32
33
34
35
	* testsuite/ccm-test.c (test_cipher_ccm): And tests.

	* ccm.c (ccm_decrypt_message): Change length argument, should now
	be clear text (dst) length.
	* ccm-aes128.c (ccm_aes128_decrypt_message): Likewise.
	* ccm-aes192.c (ccm_aes192_decrypt_message): Likewise.
	* ccm-aes256.c (ccm_aes256_decrypt_message): Likewise.
	* ccm.h: Updated prototypes.

36
37
2014-04-22  Niels Möller  <nisse@lysator.liu.se>

38
39
40
	* nettle.texinfo (Recommended hash functions): Document additional
	sha512 variants.

41
42
43
	* sha2.h (sha512_224_ctx, sha512_256_ctx): New aliases for the
	sha512_ctx struct tag.

44
45
46
47
48
2014-04-17  Niels Möller  <nisse@lysator.liu.se>

	* examples/Makefile.in (SOURCES): Deleted next-prime.c (forgotten
	in 2014-04-13 change).

Niels Möller's avatar
Niels Möller committed
49
50
2014-04-16  Niels Möller  <nisse@lysator.liu.se>

51
52
53
	* testsuite/ccm-test.c (test_cipher_ccm): Deleted check for NULL
	authdata.

Niels Möller's avatar
Niels Möller committed
54
55
56
57
58
59
	* sha3-224.c (sha3_224_init): Pass pointer to context struct, not
	pointer to first element, to memset.
	* sha3-256.c (sha3_256_init): Likewise.
	* sha3-384.c (sha3_384_init): Likewise.
	* sha3-512.c (sha3_512_init): Likewise.

Niels Möller's avatar
Niels Möller committed
60
61
62
63
	* examples/eratosthenes.c (vector_alloc): Use sizeof(*vector)
	instead of explicit type in malloc call.
	(vector_init): Make constant explicitly unsigned long.

Niels Möller's avatar
Niels Möller committed
64
65
	* tools/input.c (sexp_get_quoted_char): Deleted useless for loop.

66
67
2014-04-13  Niels Möller  <nisse@lysator.liu.se>

68
69
70
71
72
	* rsa-compat.c: Deleted file.
	* rsa-compat.h: Deleted file.
	* Makefile.in (hogweed_SOURCES): Deleted rsa-compat.c.
	(HEADERS): Deleted rsa-compat.h.

73
74
75
76
77
78
79
80
81
82
	* examples/next-prime.c: Deleted file.
	* bignum-next-prime.c (nettle_next_prime): Deleted file and
	function.
	* prime-list.h: Deleted file.
	* bignum.h (nettle_next_prime): Deleted prototype.
	* Makefile.in (hogweed_SOURCES): Deleted bignum-next-prime.c.
	(DISTFILES): Deleted prime-list.h.
	* examples/Makefile.in (HOGWEED_TARGETS): Deleted next-prime, and
	corresponding make target.

Niels Möller's avatar
Niels Möller committed
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
2014-04-12  Niels Möller  <nisse@lysator.liu.se>

	* nettle.texinfo (Copyright): Updated licensing info.
	* README: Likewise.

	* Makefile.in (DISTFILES): Distribute new COPYING* files.

	* COPYING.LESSERv3: New file.
	* COPYINGv3: New file.
	* COPYING.LIB: Deleted.
	* COPYINGv2: New name for GPL version 2 file.
	* COPYING: Old name, deleted.

	* Update license headers for LGPL3+ and GPL2+ dual licensing.

Niels Möller's avatar
Niels Möller committed
98
99
2014-04-11  Niels Möller  <nisse@lysator.liu.se>

100
101
	* testsuite/testutils.c (test_aead): Use aead->digest_size.

102
103
	* configure.ac: Skip GMP tests if public key support is disabled.

104
105
	* eax.c (block16_xor): Fixed bug effecting 32-bit platforms.

Niels Möller's avatar
Niels Möller committed
106
107
108
109
	* Makefile.in (DISTFILES): Deleted memxor.c, already included via
	nettle_SOURCES.
	* tools/Makefile.in (SOURCES): Add nettle-pbkdf2.c.

110
111
112
113
114
115
116
2014-04-10  Niels Möller  <nisse@lysator.liu.se>

	From Nikos Mavrogiannopoulos:
	* examples/hogweed-benchmark.c (bench_openssl_ecdsa_init): Support
	for secp192r1 and secp256r1.
	(alg_list): Add them.

117
118
2014-04-09  Niels Möller  <nisse@lysator.liu.se>

119
120
121
	* examples/nettle-benchmark.c (main): Benchmark sha512_224 and
	sha512_256.

122
123
124
125
	* testsuite/sha512-224-test.c: New file.
	* testsuite/sha512-256-test.c: New file.
	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added new files.

126
127
128
129
	* nettle-meta.h (nettle_sha512_224, nettle_sha512_256): Declare.
	* sha512-224-meta.c (nettle_sha512_224): New file, new nettle_hash.
	* sha512-256-meta.c (nettle_sha512_256): New file, new nettle_hash.

130
131
132
	* sha2.h (SHA512_224_DIGEST_SIZE, SHA512_224_DATA_SIZE)
	(SHA512_256_DIGEST_SIZE, SHA512_256_DATA_SIZE): New constants.

133
134
	* sha512.c (sha512_256_digest): Typo fix, call sha512_256_init.

135
136
137
	* testsuite/testutils.c (test_hash): Removed redundant init call.
	Tests that digest implies init.

138
139
2014-03-28  Niels Möller  <nisse@lysator.liu.se>

140
141
	* testsuite/dsa-keygen-test.c (test_main): Explicitly use
	dsa_compat_generate_keypair.
142
143
144
	(test_main): Test dsa_generate_params and dsa_generate_keypair
	with a large q; p_bits = 1024, q_bits = 768.

145
146
	* testsuite/testutils.h: Undo dsa-compat.h name mangling.

147
148
149
150
151
	* dsa-keygen.c (dsa_generate_keypair): New interface, generating
	only a keypair, and no new parameters.
	* dsa-compat-keygen.c (dsa_compat_generate_keypair): New file.
	Moved old key generation function here. Use dsa_generate_keypair.

152
153
2014-03-27  Niels Möller  <nisse@lysator.liu.se>

154
155
156
157
158
159
160
161
162
	* dsa-compat.c (dsa_public_key_init, dsa_public_key_clear)
	(dsa_private_key_init, dsa_private_key_clear): : Move deprecated
	DSA functions to a separate file...
	* dsa.c: ...from here.
	* dsa-compat.h: New file, declaring deprecated DSA interface.
	Include in corresponding C files.
	* Makefile.in (hogweed_SOURCES): Add dsa-compat.c.
	(HEADERS): Add dsa-compat.h.

163
164
165
166
	* dsa-gen-params.c (dsa_generate_params): New file and function,
	extracted from DSA key generation.
	* dsa-keygen.c (dsa_generate_keypair): Use dsa_generate_params.

Niels Möller's avatar
Niels Möller committed
167
168
2014-03-26  Niels Möller  <nisse@lysator.liu.se>

169
170
171
172
173
174
175
176
177
178
179
180
181
182
	* der2dsa.c (dsa_params_from_der_iterator): Converted to new DSA
	interface. Allow q_size == 0, meaning any q < p is allowed.
	Additional validity checks.
	(dsa_public_key_from_der_iterator): Converted to new DSA
	interface. Also check that the public value is in the correct
	range.
	(dsa_openssl_private_key_from_der_iterator): Converted
	to new DSA interface. Additional validity checks.
	(dsa_openssl_private_key_from_der): Converted to new DSA
	interface.
	* tools/pkcs1-conv.c (convert_dsa_private_key): Update to use
	struct dsa_params, and adapt to the der decoding changes.
	(convert_public_key): Likewise.

183
184
185
	* examples/hogweed-benchmark.c: Update dsa benchmarking to use new
	DSA interface.

186
187
188
189
	* dsa.c (dsa_params_init, dsa_params_clear): New functions.
	(dsa_public_key_init): Use dsa_params_init.
	(dsa_public_key_clear): Use dsa_params_clear.

190
191
192
193
194
195
	* sexp2dsa.c (dsa_keypair_from_sexp_alist): Converted to new DSA
	interface. Allow q_size == 0, meaning any q < p is allowed.
	Additional validity checks.
	(dsa_sha1_keypair_from_sexp, dsa_sha256_keypair_from_sexp):
	Converted to new DSA interface.

196
197
198
199
	* dsa2sexp.c (dsa_keypair_to_sexp): Converted to new DSA
	interface.
	* tools/pkcs1-conv.c: Updated uses of dsa_keypair_to_sexp.

200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
	* dsa.h (struct dsa_params): New struct.

	* dsa-sign.c (dsa_sign): Use struct dsa_params, with key as a
	separate mpz_t.
	* dsa-verify.c (dsa_verify): Likewise.
	* dsa-sha1-verify.c (dsa_sha1_verify_digest, dsa_sha1_verify): Use
	dsa_verify, cast the struct dsa_public_key * input to a struct
	dsa_params *
	* dsa-sha256-verify.c (dsa_sha256_verify_digest)
	(dsa_sha256_verify): Likewise.
	* dsa-sha1-sign.c (dsa_sha1_sign_digest, dsa_sha1_sign): Likewise
	use dsa_sign, with a cast from struct dsa_public_key * to struct
	dsa_params *.
	* dsa-sha256-sign.c (dsa_sha256_sign_digest, dsa_sha256_sign):
	Likewise.

	* testsuite/testutils.c (test_dsa_verify): Use struct dsa_params.
	(test_dsa_key): Likewise.
	* testsuite/dsa-test.c (test_main): Adapt to test_dsa_key and
	test_dsa_verify changes.
	* testsuite/dsa-keygen-test.c (test_main): Adapt to
	test_dsa_key change.

Niels Möller's avatar
Niels Möller committed
223
224
225
	* testsuite/testutils.c (test_dsa_sign): #if out, currently
	unused.

Owen Kirby's avatar
Owen Kirby committed
226
227
228
229
230
231
232
233
234
235
236
237
238
2014-03-23  Niels Möller  <nisse@lysator.liu.se>

	From Owen Kirby:
	* ccm.c: New file.
	* ccm.h: New file.
	* ccm-aes128.c: New file.
	* ccm-aes192.c: New file.
	* ccm-aes256.c: New file.
	* Makefile.in (nettle_SOURCES): Added ccm source files.
	(HEADERS): Added ccm.h.
	* testsuite/ccm-test.c: New file.
	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added ccm-test.c.

Niels Möller's avatar
Niels Möller committed
239
240
241
2014-03-20  Niels Möller  <nisse@lysator.liu.se>

	From Joachim Strömbergson:
242
243
244
245
246
247
	* sha512.c (K): Indentation fix.
	(sha512_224_init, sha512_224_digest, sha512_256_init)
	(sha512_256_digest): New functions.
	* sha2.h: Add prototypes.
	(sha512_224_update, sha512_256_update): New aliases for
	sha512_update.
Niels Möller's avatar
Niels Möller committed
248

249
250
2014-03-18  Niels Möller  <nisse@lysator.liu.se>

251
252
253
254
255
256
257
258
259
	* examples/nettle-benchmark.c (main): Add benchmarking of arcfour,
	salsa20 and chacha, via time_aead.

	* nettle-internal.c (nettle_arcfour128): Define, as a struct
	nettle_aead (with NULL set_nonce, update, and digest methods).
	* examples/nettle-openssl.c (nettle_openssl_arcfour128): Likewise.
	* nettle-internal.h (nettle_arcfour128)
	(nettle_openssl_arcfour128): Declare.

260
261
262
263
264
265
266
267
268
269
270
	* nettle-types.h (nettle_cipher_func): New typedef, similar to
	nettle_crypt_func, but with a const context, intended for block
	ciphers.
	* nettle-meta.h (struct nettle_cipher): Use the nettle_cipher_func
	type.
	* Many other files affected: aes*-meta.c, camellia*-meta.c,
	cast128-meta.c, serpent-meta.c, twofish-meta.c, cbc.[ch],
	ctr.[ch], ctr.[ch], des-compat.c, eax.[ch], gcm*.[ch],
	nettle-internal.*, testsuite/aes-test.c,
	examples/nettle-benchmark.c, examples/nettle-openssl.c.

271
272
2014-03-16  Niels Möller  <nisse@lysator.liu.se>

273
274
	* chacha-set-key.c: Include string.h.

275
276
277
278
279
280
281
282
283
	* arcfour-meta.c: Deleted file.
	* nettle-meta.h (nettle_arcfour128): Deleted declaration.
	* nettle-meta-ciphers.c (nettle_ciphers): Deleted
	nettle_arcfour128 from list.
	* Makefile.in (nettle_SOURCES): Deleted arcfour-meta.c.
	* examples/nettle-openssl.c (nettle_openssl_arcfour128): Deleted.
	* testsuite/meta-cipher-test.c: Adjust test for removal of
	nettle_arcfour128.

284
285
2014-03-15  Niels Möller  <nisse@lysator.liu.se>

286
287
288
289
290
291
292
	* examples/nettle-benchmark.c (struct bench_aead_info): New
	struct.
	(bench_aead_crypt, bench_aead_update, init_nonce, time_aead): New
	functions, for benchmarking aead algorithms.
	(time_gcm, time_eax): Deleted functions.
	(main): Use time_aead to benchmark gcm, eax and chacha-poly1305.

293
294
295
296
	* salsa20.h (SALSA20_NONCE_SIZE): Renamed constant, old name
	SALSA20_IV_SIZE kept as an alias.
	(salsa20_set_nonce): Update prototype for the 2014-01-20 rename.

297
298
299
	* Makefile.in (.asm.s): Add dependencies.
	(.s.o, .s.po): Empty any dependency .d file.

300
301
2014-03-04  Niels Möller  <nisse@lysator.liu.se>

302
303
304
	* testsuite/chacha-test.c (test_main): Additional test cases, for
	256-bit keys.

305
306
307
308
309
310
311
312
313
314
	* Makefile.in (nettle_SOURCES): Deleted chacha128-set-key.c and
	chacha256-set-key.c.

	* chacha.h (CHACHA256_KEY_SIZE): Deleted.
	(chacha_set_key): Updated prototype.
	* chacha256-set-key.c (chacha256_set_key): Deleted file and
	function, moved to...
	* chacha-set-key.c (chacha_set_key): Do 256-bit keys only. Deleted
	length argument. Updated all callers.

315
316
317
318
319
320
321
322
323
	* chacha128-set-key.c (chacha128_set_key): Deleted file and
	function. Support for 128-bit chacha keys may be reintroduced
	later, if really needed.
	* chacha.h: Deleted chacha128-related declarations.
	* chacha-set-key.c (chacha_set_key): Drop support for 128-bit
	keys.
	* testsuite/chacha-test.c (test_main): #if:ed out all tests with
	128-bit keys.

Niels Möller's avatar
Niels Möller committed
324
325
2014-02-16  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
326
327
328
329
330
331
332
333
334
	* gcm.h: Declarations for gcm-camellia256.
	* gcm-camellia256.c: New file.
	* gcm-camellia256-meta.c: New file.
	* nettle-meta.h (nettle_gcm_camellia256): Declare.
	* Makefile.in (nettle_SOURCES): Added gcm-camellia256.c and
	gcm-camellia256-meta.c.
	* testsuite/gcm-test.c (test_main): Test cases for
	nettle_gcm_camellia256.

Niels Möller's avatar
Niels Möller committed
335
336
337
338
339
340
341
342
343
	* gcm.h: Include camellia.h. Declarations for gcm-camellia128.
	* gcm-camellia128.c: New file.
	* gcm-camellia128-meta.c: New file.
	* nettle-meta.h (nettle_gcm_camellia128): Declare.
	* Makefile.in (nettle_SOURCES): Added gcm-camellia128.c and
	gcm-camellia128-meta.c.
	* testsuite/gcm-test.c (test_main): Test cases for
	nettle_gcm_camellia128. From Nikos Mavrogiannopoulos.

344
345
2014-02-13  Niels Möller  <nisse@lysator.liu.se>

346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
	* Makefile.in (nettle_SOURCES): Added eax-aes128.c
	eax-aes128-meta.c.
	* examples/nettle-benchmark.c: Include eax.h.
	* nettle-meta.h (nettle_eax_aes128): Declare, moved from
	nettle-internal.h.
	* eax.h: Declare eax_aes128_ctx and related functions. Moved from
	nettle-internal.h
	(EAX_IV_SIZE): New constant.
	* eax-aes128-meta.c (nettle_eax_aes128): Moved definition to new
	file.
	* eax-aes128.c (eax_aes128_set_key, eax_aes128_set_nonce)
	(eax_aes128_update, eax_aes128_encrypt, eax_aes128_decrypt)
	(eax_aes128_digest): Moved functions to a new file.
	* nettle-internal.c: ... from old location.
	* nettle-internal.h: Moved eax declarations elsewhere.

362
363
	* tools/nettle-pbkdf2.c (main): Added missing deallocation.

364
365
2014-02-12  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
366
367
368
369
370
371
372
373
374
375
376
377
378
379
	* chacha-poly1305.h: New file.
	* chacha-poly1305.c: New file.
	* chacha-poly1305-meta.c (nettle_chacha_poly1305): New file, new
	aead algorithm.
	* nettle-meta.h (nettle_chacha_poly1305): Declare.

	* Makefile.in (nettle_SOURCES): Added chacha-poly1305.c and
	chacha-poly1305-meta.c.
	(HEADERS): Added chacha-poly1305.h.

	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added
	chacha-poly1305-test.c.
	* testsuite/chacha-poly1305-test.c: New file.

380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
	* nettle-meta.h (struct nettle_aead): New generalized version
	if this struct.
	(nettle_gcm_aes128, nettle_gcm_aes192, nettle_gcm_aes256)
	(nettle_eax_aes128): Declare, moved from nettle-internal.h.
	* nettle-internal.h (struct nettle_aead): Deleted struct, moved to
	nettle-meta.h. Deleted declarations of unused instances.
	(_NETTLE_AEAD): Deleted macro.
	* nettle-internal.c (nettle_eax_aes128): Updated for new
	nettle_aead struct.
	(nettle_gcm_aes128, nettle_gcm_aes192, nettle_gcm_aes256):
	Deleted, moved to new files.
	* gcm-aes128-meta.c (nettle_gcm_aes128): Moved to new file,
	updated for new nettle_aead struct.
	* gcm-aes192-meta.c (nettle_gcm_aes192): Likewise.
	* gcm-aes256-meta.c (nettle_gcm_aes256): Likewise.
	* testsuite/testutils.c (test_aead): Take alternative set_nonce
	function as argument, and use it when nonce size differs from
	aead->nonce_length.
	* testsuite/testutils.h (test_aead): Updated prototype.
	* testsuite/gcm-test.c (nettle_gcm_unified_aes128): Updated for
	new nettle_aead struct.
	(test_main): Pass additional argument to test_aead.
	* testsuite/eax-test.c (test_main): Pass additional NULL argument
	to test_aead.

405
406
407
	* eax.h (EAX_DIGEST_SIZE): New constant.
	* gcm.h (GCM_DIGEST_SIZE): Likewise.

408
409
410
411
412
413
2014-02-10  Niels Möller  <nisse@lysator.liu.se>

	* chacha-set-nonce.c (chacha_set_nonce): Renamed file and
	function, updated callers and Makefile.in.
	* chacha-set-iv.c (chacha_set_iv): ... from old names.

414
415
2014-02-08  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
416
417
418
419
420
	* testsuite/chacha-test.c (test_chacha): For 20 rounds, use
	chacha_crypt, and test varying the message length.
	(test_main): Add second key stream block, for all testcases with
	20 rounds.

421
422
	* chacha-crypt.c (chacha_crypt): Fixed block counter update.

423
424
2014-02-07  Niels Möller  <nisse@lysator.liu.se>

425
426
427
428
	* nettle.texinfo (ASCII encoding): Document that
	base16_encode_update and base64_encode_update now uses dst_length
	as an output only.

Niels Möller's avatar
Niels Möller committed
429
430
431
	* testsuite/base64-test.c (test_main): Updated
	base64_decode_update test case.

432
433
	* sexp-transport.c (sexp_transport_iterator_first): For
	base64_decode_update, omit initialization of coded_length.
434
435
	* examples/base64dec.c (main): Likewise.
	* examples/base16dec.c (main): Likewise, for base16_decode_update.
436

437
438
439
440
	* base64-decode.c (base64_decode_update): Use *dst_length for
	output only. Don't require callers to pass a sane value.
	* base16-decode.c (base16_decode_update): Likewise.

441
442
2014-02-06  Niels Möller  <nisse@lysator.liu.se>

443
444
	* NEWS: List _set_key incompatibilities.

Niels Möller's avatar
Niels Möller committed
445
446
447
448
449
450
	* nettle-meta.h (_NETTLE_CIPHER_SEP, _NETTLE_CIPHER_SEP_SET_KEY)
	(_NETTLE_CIPHER_FIX, _NETTLE_CIPHER): Deleted unused macros.

	* nettle-internal.c (nettle_blowfish128): Deleted only use of
	_NETTLE_CIPHER.

451
452
453
	* blowfish.c (blowfish128_set_key): New function.
	* blowfish.h (BLOWFISH128_KEY_SIZE): New constant.

Niels Möller's avatar
Niels Möller committed
454
455
456
	* cast128-meta.c (nettle_cast128): Deleted only use of
	_NETTLE_CIPHER_FIX.

457
458
	* examples/nettle-benchmark.c (time_cipher): Fixed memset calls.

Niels Möller's avatar
Niels Möller committed
459
460
2014-01-30  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
461
462
	* Makefile.in (nettle_SOURCES): Arrange in alphabetic order.

463
464
465
	* nettle.texinfo: Updated, document size_t for length arguments.
	Document new AES and Camellia interfaces.

Niels Möller's avatar
Niels Möller committed
466
	* ecc-size.c (ecc_bit_size): New function.
Niels Möller's avatar
Niels Möller committed
467
	* ecc.h (ecc_bit_size): Declare it.
Niels Möller's avatar
Niels Möller committed
468

469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
2014-01-29  Niels Möller  <nisse@lysator.liu.se>

	* nettle-types.h (typedef nettle_set_key_func): Deleted length
	argument.

	* arctwo.c (arctwo40_set_key, arctwo64_set_key)
	(arctwo128_set_key, arctwo128_set_key_gutmann): New functions.
	* arctwo.h: Declare them.
	* arctwo-meta.c (ARCTWO): New macro.
	(nettle_arctwo40, nettle_arctwo64, nettle_arctwo128)
	(nettle_arctwo_gutmann128): Use new _set_key functions.

	* arcfour.h (ARCFOUR128_KEY_SIZE): New constant.
	* arcfour.c (arcfour128_set_key): New function.
	* arcfour-meta.c (nettle_arcfour128): Use arcfour128_set_key and
	ARCFOUR128_KEY_SIZE.

	* cast128.c (cast5_set_key): Renamed, was cast128_set_key.
	(cast128_set_key): New definition, with fixed key size.
	* cast128.h (CAST128_MIN_KEY_SIZE, CAST128_MAX_KEY_SIZE): Renamed
	constants, to...
	(CAST5_MIN_KEY_SIZE, CAST5_MAX_KEY_SIZE): ... new names.

	* eax.h (EAX_SET_KEY): Deleted length argument.

	* aes128-meta.c: Deleted _set_key wrappers.
	* aes192-meta.c: Likewise.
	* aes256-meta.c: Likewise.
	* camellia128-meta.c: Likewise.
	* camellia192-meta.c: Likewise.
	* camellia256-meta.c: Likewise.

	* gcm-aes128.c (gcm_aes128_set_key): Deleted length argument.
	* gcm-aes192.c (gcm_aes192_set_key): Likewise.
	* gcm-aes256.c (gcm_aes256_set_key): Likewise.
	* gcm.h: Updated prototypes.

	* serpent-set-key.c (serpent128_set_key, serpent192_set_key)
	(serpent256_set_key): New functions.
	* serpent.h: Declare new functions.
	(SERPENT128_KEY_SIZE, SERPENT192_KEY_SIZE)
	(SERPENT256_KEY_SIZE): New constants.
	* serpent-meta.c (SERPENT): New macro.
	(nettle_serpent128, nettle_serpent192, nettle_serpent256): Use new
	_set_key functions.

	* twofish-set-key.c (twofish128_set_key, twofish192_set_key)
	(twofish256_set_key): New functions.
	* twofish.h: Declare new functions.
	(TWOFISH128_KEY_SIZE, TWOFISH192_KEY_SIZE)
	(TWOFISH256_KEY_SIZE): New constants.
	* twofish-meta.c (TWOFISH): New macro.
	(nettle_twofish128, nettle_twofish192, nettle_twofish256): Use new
	_set_key functions.

	* nettle-internal.h (struct nettle_aead): Use
	nettle_hash_update_func for the set_iv function pointer.

	* nettle-internal.c (des_set_key_hack, des3_set_key_hack): Deleted
	wrapper functions.
	(chacha_set_key_hack): Deleted length argument. Use
	chacha256_set_key.
	(salsa20_set_key_hack): Deleted length argument. Use
	salsa20_256_set_key.
	(nettle_unified_aes128, nettle_unified_aes192)
	(nettle_unified_aes256): Deleted, moved to test program.
	(eax_aes128_set_key): Deleted length argument. Use EAX_SET_KEY.

	* examples/nettle-benchmark.c: Updated for _set_key changes.
	* examples/nettle-openssl.c: Likewise.
	* testsuite/testutils.c: Likewise.
	* testsuite/gcm-test.c: Likewise.

	* testsuite/aes-test.c (UNIFIED_AES): New macro. Moved glue for
	testing the old aes interface (struct aes_ctx) here.

	* testsuite/arcfour-test.c (test_arcfour): New function, for key
	sizes != 128 bits.
	(test_main): Use it.

	* testsuite/blowfish-test.c (test_blowfish): New function.
	(test_main): Use it. Also deleted old #if:ed out code.

	* testsuite/cast128-test.c (test_cast5): New function.
	(test_main): Use it, for 40-bit and 80-bit tests.

	* testsuite/serpent-test.c (test_serpent): New function.
	(test_main): Use it.

558
559
2014-01-27  Niels Möller  <nisse@lysator.liu.se>

560
561
562
563
564
	* eax.h (struct eax_key, struct eax_ctx): Use union
	nettle_block16, for alignment.
	* eax.c: Updated everything to use nettle_block16.
	(block16_xor): New function.

Niels Möller's avatar
Niels Möller committed
565
566
567
	* examples/nettle-benchmark.c (time_eax): New function.
	(main): Use it.

568
569
570
	* x86_64/chacha-core-internal.asm: Use pshufhw + pshuflw for the
	16-bit rotate.

Niels Möller's avatar
Niels Möller committed
571
572
573
	* configure.ac (asm_replace_list): Added chacha-core-internal.asm.
	* x86_64/chacha-core-internal.asm: New file.

Niels Möller's avatar
Niels Möller committed
574
575
576
577
	* examples/nettle-benchmark.c (main): Add benchmarking of chacha.
	* nettle-internal.c (nettle_chacha): New const struct, for the
	benchmark.

578
579
580
581
582
583
584
585
586
587
588
589
590
591
	Chacha implementation, based on contribution by Joachim
	Strömbergson.
	* chacha.h: New file.
	* chacha256-set-key.c (chacha256_set_key): New file and function.
	* chacha128-set-key.c (chacha128_set_key): New file and function.
	* chacha-set-key.c (chacha_set_key): New file and function.
	* chacha-set-iv.c (chacha_set_iv): New file and function.
	* chacha-core-internal.c (_chacha_core): New file and function.
	* chacha-crypt.c (chacha_crypt): New file and function.
	* Makefile.in (nettle_SOURCES): Added chacha files.
	(HEADERS): Added chacha.h.
	* testsuite/chacha-test.c: New file.
	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added chacha-test.c.

Niels Möller's avatar
Niels Möller committed
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
2014-01-26  Niels Möller  <nisse@lysator.liu.se>

	* nettle-internal.h (_NETTLE_AEAD_FIX): Renamed to...
	(_NETTLE_AEAD): ... new name, and deleted old definition. Also use
	_set_nonce instead of _set_iv.
	* nettle-internal.c (nettle_gcm_aes128, nettle_gcm_aes192)
	(nettle_gcm_aes256): Define in terms of new interface.
	(nettle_eax_aes128): Updated for _NETTLE_AEAD changes.

	* testsuite/gcm-test.c (test_gcm_hash): Likewise use struct
	gcm_aes128_ctx.
	(test_main): Added a testcase using the old interface based on
	struct gcm_aes_ctx.

	* examples/nettle-benchmark.c (time_gcm): Update to use new struct
	gcm_aes128_ctx. Also use name "gcm-aes128" in output.

	* gcm.h: New interface for gcm_aes128, gcm_aes192, gcm_aes256,
	using the new AES interface.
	(GCM_CTX): Reorder fields, putting the cipher context
	last.

	* Makefile.in (nettle_SOURCES): Added gcm-aes128.c, gcm-aes192.c,
	and gcm-aes256.c.

	* gcm-aes128.c: New file.
	* gcm-aes192.c: New file
	* gcm-aes256.c: New file.

621
622
623
624
625
626
2014-01-25  Niels Möller  <nisse@lysator.liu.se>

	* gcm.h (GCM_SET_KEY): Deleted length argument.
	* gcm-aes.c (gcm_aes_set_key): Use aes_set_encrypt_key and
	gcm_set_key, can no longer use GCM_SET_KEY macro.

Niels Möller's avatar
Niels Möller committed
627
628
629
630
631
2014-01-23  Niels Möller  <nisse@lysator.liu.se>

	* testsuite/gcm-test.c (test_main): Use the correct
	nettle_gcm_aes128/192/256 object.

632
633
634
635
2014-01-21  Niels Möller  <nisse@lysator.liu.se>

	Merged camellia-reorg changes (starting at 2013-10-07).

Niels Möller's avatar
Niels Möller committed
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
2013-10-10  Niels Möller  <nisse@lysator.liu.se>

	* Makefile.in (nettle_SOURCES): Updated list of camellia files.

	* testsuite/camellia-test.c (test_invert): Updated for new
	camellia interface.

	* camellia.h: Reorganized camellia interface, with distinct
	context structs and functions for camellia128 and camellia256.

	* camellia-meta.c: Deleted file.
	* camellia256-meta.c: New file.
	* camellia192-meta.c: New file.
	* camellia128-meta.c: New file.

	* camellia-set-decrypt-key.c: Deleted file, code moved to:
	* camellia128-set-decrypt-key.c: New file.
	(camellia128_invert_key, camellia128_set_decrypt_key): New
	functions.
	* camellia256-set-decrypt-key.c: New file.
	(camellia256_invert_key, camellia256_set_decrypt_key)
	(camellia192_set_decrypt_key): New functions.
	* camellia-invert-key.c (_camellia_invert_key): New file and
	function.

	* camellia-set-encrypt-key.c: Deleted file, code moved to:
	* camellia128-set-encrypt-key.c: New file.
	(camellia128_set_encrypt_key): New function.
	* camellia256-set-encrypt-key.c: New file.
	(_camellia256_set_encrypt_key, camellia256_set_encrypt_key)
	(camellia192_set_encrypt_key): New functions.
	* camellia-absorb.c (_camellia_absorb): New file and function.
	* camellia-internal.h: Moved key schedule macros here.

	* camellia-crypt.c: Deleted file, code moved to:
	* camellia128-crypt.c (camellia128_crypt): New file and function.
	* camellia256-crypt.c (camellia256_crypt): New file and function.

674
675
2013-10-07  Niels Möller  <nisse@lysator.liu.se>

676
677
678
679
	* configure.ac: Delete check for ALIGNOF_UINT64_T, no longer
	needed.
	* config.m4.in: Likewise delete ALIGNOF_UINT64_T.

680
681
682
683
684
	* camellia-crypt.c (camellia_crypt): Updated call to
	_camellia_crypt.
	* camellia-internal.h (_camellia_crypt): Updated prototype.
	* camellia-crypt-internal.c (_camellia_crypt): Take separate
	arguments for rounds and subkey array.
Niels Möller's avatar
Niels Möller committed
685
686
	* x86_64/camellia-crypt-internal.asm: Likewise.	Also corrected
	.file pseudo-ops.
687
688
	* x86/camellia-crypt-internal.asm: Likewise.

689
690
2014-01-20  Niels Möller  <nisse@lysator.liu.se>

691
692
693
694
695
	* poly1305-internal.c (poly1305_digest): Use union nettle_block16
	for s argument.
	* poly1305-aes.c (poly1305_aes_digest): Update for poly1305_digest
	change.

Niels Möller's avatar
Niels Möller committed
696
	Merged poly1305 changes (starting at 2013-11-08).
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
	* x86_64/poly1305-internal.asm: Update to new interface.
	poly1305_digest much simplified.

	* poly1305.h (struct poly1305_ctx): Moved block and index
	fields...
	(struct poly1305_aes_ctx): ... to here.
	* asm.m4: Delete also from the assembly definition of struct
	poly1305_ctx.

	* poly1305-internal.c (poly1305_digest): Don't do final padding
	here, leave that to caller. Add digest to the provided nonce s,
	and deleted length and dst arguments. Also reset h0-h4 to zero
	when done.
	(_poly1305_block): Renamed, from...
	(poly1305_block): ...old name.

	* poly1305-aes.c (poly1305_aes_update): New function.
	(poly1305_aes_digest): Update for poly1305_digest changes, do
	final padding here.

	* poly1305.c (poly1305_update): Deleted file and function. Moved
	to poly1305-aes.c.
	* Makefile.in (nettle_SOURCES): Deleted poly1305.c.

721
722
2014-01-17  Niels Möller  <nisse@lysator.liu.se>

723
724
725
726
727
728
729
730
731
732
733
	* poly1305-internal.c (poly1305_block): Additional argument with
	the high bit.
	(poly1305_block_internal): Deleted function, code moved into the
	poly1305_block.
	(poly1305_digest): Simplified padding code, call poly1305_block
	with high bit 0.
	* poly1305.h (poly1305_block): Update prototype.
	* poly1305.c (poly1305_update): Call poly1305_block with high bit 1.
	* x86_64/poly1305-internal.asm (poly1305_block): Handle new
	argument.

734
735
736
737
738
739
740
741
	* poly1305.h (struct poly1305_ctx): Moved nonce field from here...
	(struct poly1305_aes_ctx): ... to here.
	* poly1305-aes.c (poly1305_aes_set_nonce, poly1305_aes_digest):
	Updated for above.
	* poly1305.c (poly1305_set_nonce): Deleted function.
	* asm.m4: Delete nonce also from the assembly definition of struct
	poly1305_ctx.

742
743
2014-01-16  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
744
	* poly1305-aes.c: Include poly1305.h. Rewrite functions without
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
	using the POLY1305_* macros.

	* Makefile.in (HEADERS): Deleted poly1305-aes.h.

	* poly1305.h (POLY1305_CTX, POLY1305_SET_KEY, POLY1305_SET_NONCE)
	(POLY1305_DIGEST): Deleted macros. Only implemented variant is
	poly1305-aes.
	(POLY1305_DIGEST_SIZE, POLY1305_BLOCK_SIZE, POLY1305_KEY_SIZE):
	New constants.
	(POLY1305_AES_KEY_SIZE, POLY1305_AES_DIGEST_SIZE): Moved here,
	from poly1305-aes.h.
	(struct poly1305_aes_ctx): Likewise.
	(poly1305_aes_set_key, poly1305_aes_set_nonce)
	(poly1305_aes_update, poly1305_aes_digest): Likewise.
	* poly1305-aes.h: Deleted file, declarations moved to poly1305.h.
	Update all users.

762
763
	* poly1305-internal.c (s2, s3, s4): Fixed macros.

764
765
766
767
768
769
770
	* poly1305-aes.h (struct poly1305_aes_ctx): Replace struct aes_ctx
	by struct aes128_ctx.
	* poly1305-aes.c (poly1305_aes_set_key, poly1305_aes_digest):
	Update to use aes128_* functions.
	* poly1305.h (POLY1305_SET_KEY): Drop key size argument when
	calling set_key.

Niels Möller's avatar
Niels Möller committed
771
772
773
774
775
776
777
778
779
780
781
782
2013-12-19  Niels Möller  <nisse@lysator.liu.se>

	* poly1305-aes.h (poly1305_aes_update): Define as an alias for
	poly1305_update, using preprocessor and a type cast.

	* poly1305-aes.c (poly1305_aes_update): Deleted function.

	* poly1305.h (poly1305_update): Declare.
	(_POLY1305_BLOCK, POLY1305_UPDATE): Deleted macros.

	* poly1305.c (poly1305_update): New function.

783
784
2013-11-21  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
785
786
787
788
789
	* x86_64/poly1305-internal.asm: New file. Almost a factor of two
	speedup.

	* configure.ac (asm_replace_list): Added poly1305-internal.asm.

Niels Möller's avatar
Niels Möller committed
790
	* asm.m4: Define struct offsets for 64-bit poly1305_ctx.
Niels Möller's avatar
Niels Möller committed
791

792
793
794
795
796
797
798
799
800
	* poly1305.h (POLY1305_DIGEST): Pass the encrypted nonce as an
	additional argument to poly1305_digest.
	(struct poly1305_ctx): Introduce unions, to support either 26-bit
	or 64-bit implementation.

	* poly1305-internal.c (poly1305_digest): Added s argument.

	* poly1305.c (poly1305_set_s): Deleted function.

Niels Möller's avatar
Niels Möller committed
801
802
803
804
2013-11-12  Niels Möller  <nisse@lysator.liu.se>

	* poly1305-internal.c: New file, for poly1305 functions depending
	on the internal mod (2^130 - 5) representation.
805
806
	(poly1305_block_internal): New helper function.
	(poly1305_block, poly1305_digest): Use it.
Niels Möller's avatar
Niels Möller committed
807

808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
2013-11-08  Nikos Mavrogiannopoulos  <nmav@gnutls.org>

	* poly1305.h: New file.
	* poly1305.c: New file.
	* poly1305-aes.h: New file.
	* poly1305-aes.c: New file.
	* Makefile.in (nettle_SOURCES): Added poly1305-aes.c and poly1305.c.
	(HEADERS): Added poly1305-aes.h and poly1305.h.

	* testsuite/poly1305-test.c: New file.
	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added poly1305-test.c.

	* examples/nettle-benchmark.c (time_poly1305_aes): New function.
	(main): Benchmark poly1305.

823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
2014-01-20  Niels Möller  <nisse@lysator.liu.se>

	* Makefile.in (nettle_SOURCES): Added salsa20-set-nonce.c,
	salsa20-128-set-key.c, and salsa20-256-set-key.c.

	* salsa20.h: Declare new functions.
	(SALSA20_128_KEY_SIZE, SALSA20_256_KEY_SIZE): New constants.
	(salsa20_set_iv): Define as an alias for salsa20_set_nonce.

	* salsa20-set-key.c (salsa20_set_key): Use salsa20_128_set_key and
	salsa20_256_set_key.
	(salsa20_set_iv): Renamed and moved...
	* salsa20-set-nonce.c (salsa20_set_nonce): ... new file, new name.

	* salsa20-256-set-key.c (salsa20_256_set_key): New file and
	function.
	* salsa20-128-set-key.c (salsa20_128_set_key): New file and
	function.

Niels Möller's avatar
Niels Möller committed
842
843
844
845
846
847
848
2014-01-13  Niels Möller  <nisse@lysator.liu.se>

	* nettle-types.h (union nettle_block16): New type, replacing union
	gcm_block.
	* gcm.h (union gcm_block): Deleted. Replaced by nettle_block16.
	* gcm.c: Replaced all use of gcm_block by nettle_block16.

849
850
2014-01-04  Niels Möller  <nisse@lysator.liu.se>

851
852
853
854
	* config.guess: Updated to 2014-01-01 version, from
	git://git.sv.gnu.org/config.git.
	* config.sub: Likewise.

855
856
857
858
859
	* testsuite/memxor-test.c [HAVE_VALGRIND_MEMCHECK_H] (test_mark):
	New function.
	(test_memxor, test_memxor3): Use test_mark to tell valgrind the
	start and end of src and destination areas.

860
861
	* configure.ac: Check for valgrind/memcheck.h.

862
863
864
	* testsuite/Makefile.in (VALGRIND): Added --partial-loads-ok=yes,
	needed for the way unaligned data is handled in, e.g., memxor.

865
866
867
868
869
2014-01-03  Niels Möller  <nisse@lysator.liu.se>

	* shadata.c (main): Zero-pad output values to 8 hex digits.
	* sha256.c (K): Updated table.

Niels Möller's avatar
Niels Möller committed
870
2013-12-17  Niels Möller  <nisse@lysator.liu.se>
871

872
873
874
875
876
	* configure.ac (ASM_RODATA): New substituted variable. Needed for
	portability to darwin.
	* config.m4.in: Define RODATA, using configure variable ASM_RODATA
	* x86_64/gcm-hash8.asm: Use RODATA macro.

877
878
879
880
	* bignum-random-prime.c (_nettle_generate_pocklington_prime): Use
	stronger variants of Pocklington's theorem, to allow p0 of size
	down to bits/3.

881
882
883
884
885
2013-12-15  Niels Möller  <nisse@lysator.liu.se>

	* nettle-internal.h (NETTLE_MAX_BIGNUM_BITS)
	(NETTLE_MAX_BIGNUM_SIZE): Deleted arbitrary limits.

886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
2013-12-15  Nikos Mavrogiannopoulos <nmav@redhat.com>

	Introduced TMP_GMP_ALLOC macro for temporary allocations of
	potentially large data, e.g, sized as an RSA key.
	* gmp-glue.h (TMP_GMP_DECL, TMP_GMP_ALLOC, TMP_GMP_FREE): New
	macros.
	* gmp-glue.c (gmp_alloc, gmp_free): New functions.
	* bignum-next-prime.c (nettle_next_prime): Use TMP_GMP_ALLOC.
	* bignum-random.c (nettle_mpz_random_size): Likewise.
	* pkcs1-decrypt.c (pkcs1_decrypt): Likewise.
	* pkcs1-encrypt.c (pkcs1_encrypt): Likewise.
	* pkcs1-rsa-digest.c (pkcs1_rsa_digest_encode): Likewise.
	* pkcs1-rsa-sha512.c (pkcs1_rsa_sha512_encode)
	(pkcs1_rsa_sha512_encode_digest): Likewise.
	* pkcs1-rsa-sha256.c (pkcs1_rsa_sha256_encode)
	(pkcs1_rsa_sha256_encode_digest): Likewise.
	* pkcs1-rsa-sha1.c (pkcs1_rsa_sha1_encode)
	(pkcs1_rsa_sha1_encode_digest): Likewise.
	* pkcs1-rsa-md5.c (pkcs1_rsa_md5_encode)
	(pkcs1_rsa_md5_encode_digest): Likewise.

907
908
909
910
911
2013-12-14  Niels Möller  <nisse@lysator.liu.se>

	* x86_64/gcm-hash8.asm: Use .short rather than .hword, for
	compatibility with apple's assembler.

Niels Möller's avatar
Niels Möller committed
912
913
2013-12-03  Niels Möller  <nisse@lysator.liu.se>

914
	* x86_64/sha1-compress.asm: Reorganized, to get closer to the x86
Niels Möller's avatar
Niels Möller committed
915
	version. No difference in running time.
916

917
918
919
	* configure.ac (dummy-dep-files): Don't overwrite any existing
	dependency files.

Niels Möller's avatar
Niels Möller committed
920
	* x86_64/md5-compress.asm: New file, similar to the x86 version.
Niels Möller's avatar
Niels Möller committed
921
	35% speedup on AMD, 15% speedup on Intel.
Niels Möller's avatar
Niels Möller committed
922

923
924
2013-11-25  Niels Möller  <nisse@lysator.liu.se>

925
926
927
	* testsuite/dsa-test.c (test_main): Additional tests from NIST
	test vectors.

Niels Möller's avatar
Niels Möller committed
928
929
930
	* testsuite/testutils.c (test_dsa_sign, test_dsa_verify): New
	functions, supporting arbitrary digest size.

931
932
	* testsuite/testutils.h (ASSERT): Improved failure message.

933
934
935
	* dsa-verify.c (dsa_verify): Renamed, from _dsa_verify.
	* dsa-sign.c (dsa_sign): Renamed, from _dsa_sign.

936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
2013-11-24  Niels Möller  <nisse@lysator.liu.se>

	* testsuite/dsa-keygen-test.c (test_main): Test generating a
	key with 224-bit q.

	* dsa-verify.c (_dsa_verify): Use _dsa_hash.

	* dsa-sign.c (_dsa_sign): Use _dsa_hash. Fix memory leak in
	error case, spotted by Nikos.

	* dsa-keygen.c (dsa_generate_keypair): Allow q_bits == 224.

	* dsa-hash.c (_dsa_hash): New file and function. Allows digest
	sizes not matching the bitsize of q.
	* dsa.h (_dsa_hash): Declare it.
	* Makefile.in (hogweed_SOURCES): Added dsa-hash.c.

953
954
955
956
2013-11-23  Niels Möller  <nisse@lysator.liu.se>

	* configure.ac: Check also for openssl/ecdsa.h.

Niels Möller's avatar
Niels Möller committed
957
958
2013-10-05  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
	* Makefile.in (nettle_SOURCES): Added eax.c.
	(HEADERS): Added eax.h.

	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added eax-test.c.

	* testsuite/eax-test.c: New file.

	* nettle-internal.c (nettle_eax_aes128): New aead algorithm.
	(eax_aes128_set_key, eax_aes128_set_nonce, eax_aes128_update)
	(eax_aes128_encrypt, eax_aes128_decrypt, eax_aes128_digest): New
	functions.

	* eax.c: New file.
	* eax.h: New file.

Niels Möller's avatar
Niels Möller committed
974
	* aes.h: Fixed typo in name mangling for new aes functions.
Niels Möller's avatar
Niels Möller committed
975

Niels Möller's avatar
Niels Möller committed
976
977
978
979
980
2013-09-28  Niels Möller  <nisse@lysator.liu.se>

	* Merge aes-reorg branch. Changes below,
	dated 2013-05-17 - 2013-08-13.

981
982
983
984
985
2013-08-13  Niels Möller  <nisse@lysator.liu.se>

	* yarrow.h (struct yarrow256_ctx): Use aes256_ctx, not aes_ctx.
	* yarrow256.c: Adapted to use new aes256 interface.

986
987
988
989
990
991
992
993
994
2013-08-07  Niels Möller  <nisse@lysator.liu.se>

	* umac.h (_UMAC_STATE): Use struct aes128_ctx, not aes_ctx.
	* umac-set-key.c (umac_kdf, _umac_set_key): Use aes128 interface.
	* umac32.c (umac32_digest): Likewise.
	* umac64.c (umac64_digest): Likewise.
	* umac96.c (umac96_digest): Likewise.
	* umac128.c (umac128_digest): Likewise.

Niels Möller's avatar
Niels Möller committed
995
996
2013-06-25  Niels Möller  <nisse@lysator.liu.se>

997
998
999
1000
	* aes-meta.c: Deleted file.

	Analogous changes for new aes192 and aes256 interface.

Niels Möller's avatar
Niels Möller committed
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
	* aes.h (struct aes128_ctx): New aes128 declarations.
	* aes-decrypt.c (aes128_decrypt): New function.
	* aes-encrypt.c (aes128_encrypt): New function.
	* aes128-meta.c: New file.
	* aes128-set-encrypt-key.c (aes128_set_encrypt_key): New file and
	function.
	* aes128-set-decrypt-key.c (aes128_set_decrypt_key)
	(aes128_invert_key): New file and functions.
	* Makefile.in (nettle_SOURCES): Added aes128-set-encrypt-key.c,
	aes128-set-decrypt-key.c and aes128-meta.c.

	* nettle-internal.c (nettle_unified_aes128): For testing the old
	AES interface.
	* testsuite/aes-test.c (test_cipher2): New function.
	(test_main): Test both nettle_aes128 and nettle_unified_aes128.

1017
1018
2013-05-22  Niels Möller  <nisse@lysator.liu.se>

1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
	* Makefile.in (nettle_SOURCES): Added aes-invert-internal.c and
	aes-set-key-internal.c.

	* aes.h (AES128_KEY_SIZE, _AES128_ROUNDS): New constants.
	Similarly also for aes192 and aes256.

	* aes-internal.h: Declare new functions.

	* aes-set-key-internal.c (_aes_set_key): New file and funxtion
	extracted from aes_set_encrypt_key.
	* aes-set-encrypt-key.c (aes_set_encrypt_key): Use _aes_set_key.

	* aes-invert-internal.c (_aes_invert): New file and function,
	extracted from aes_invert_key.
	* aes-set-decrypt-key.c (aes_invert_key): Use _aes_invert.

1035
1036
1037
1038
1039
1040
	* arm/v6/aes-encrypt-internal.asm: Adapted to new interface.
	Unfortunately, 4% slowdown on Cortex-A9, for unknown reason.
	* arm/v6/aes-decrypt-internal.asm: Likewise.
	* arm/aes-encrypt-internal.asm: Adapted to new interface.
	* arm/aes-decrypt-internal.asm: Likewise.

1041
2013-05-21  Niels Möller  <nisse@lysator.liu.se>
1042

1043
1044
1045
1046
1047
	* sparc32/aes-encrypt-internal.asm: Adapted to new interface.
	* sparc32/aes-decrypt-internal.asm: Likewise.
	* sparc64/aes-encrypt-internal.asm: Likewise.
	* sparc64/aes-decrypt-internal.asm: Likewise.

1048
1049
1050
1051
	* x86/aes-encrypt-internal.asm: Adapted to new interface.
	* x86/aes-decrypt-internal.asm: Likewise.

2013-05-20  Niels Möller  <nisse@lysator.liu.se>
1052
1053

	* x86_64/aes-encrypt-internal.asm: Adapted to new interface.
1054
	* x86_64/aes-decrypt-internal.asm: Likewise.
1055

1056
1057
2013-05-17  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1058
1059
1060
1061
1062
	* aes.h (struct aes_ctx): Renamed nrounds to rounds, and moved
	first in the structure.
	* aes-set-encrypt-key.c (aes_set_encrypt_key): Updated for renaming.
	* aes-set-decrypt-key.c (aes_invert_key): Likewise.

1063
1064
1065
1066
1067
1068
	* aes-encrypt-internal.c (_nettle_aes_encrypt): Take rounds and
	subkeys as separate arguments, not a struct aes_ctx *. Updated
	callers.
	* aes-decrypt-internal.c (_nettle_aes_decrypt): Likewise.
	* aes-internal.h: Updated prototypes.

Niels Möller's avatar
Niels Möller committed
1069
1070
	* Start of aes-reorg changes.

1071
1072
2013-09-28  Niels Möller  <nisse@lysator.liu.se>

1073
1074
1075
1076
1077
1078
1079
1080
	* md4.h (struct md4_ctx): Use single uint64_t variable for block
	count.
	* md4.c: Use new block count variable.
	* md5.c, md5.h (struct md5_ctx): Likewise.
	* ripemd160.c, ripemd160.h (struct ripemd160_ctx): Likewise.
	* sha1.c, sha1.h (struct sha1_ctx): Likewise.
	* sha256.c, sha2.h (struct sha256_ctx): Likewise.

1081
1082
1083
	* testsuite/testutils.c (test_hash_large): Added simple progress
	indicator.

1084
1085
1086
	* macros.h (MD_PAD): Use size argument, don't depend on
	sizeof of the count field(s).

1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
2013-09-22  Niels Möller  <nisse@lysator.liu.se>

	* x86_64/gcm-hash8.asm: New file.
	* x86_64/gcm-gf-mul-8.asm: Deleted.

	* configure.ac (asm_nettle_optional_list): Look for gcm-hash8.asm,
	not gcm-gf-mul-8.asm.
	* gcm.c [HAVE_NATIVE_gcm_hash8]: Make use of (optional) assembly
	implementation.

Niels Möller's avatar
Niels Möller committed
1097
1098
1099
1100
1101
2013-09-21  Niels Möller  <nisse@lysator.liu.se>

	* Makefile.in (des.po): Add same dependencies as for des.o.
	Reported by Vincent Torri.

Niels Möller's avatar
Niels Möller committed
1102
1103
1104
1105
1106
1107
1108
2013-09-20  Niels Möller  <nisse@lysator.liu.se>

	* testsuite/gcm-test.c: Added tests with associated data of
	varying size.

	* testsuite/testutils.c (tstring_alloc): Add NUL-termination.

1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
2013-09-18  Niels Möller  <nisse@lysator.liu.se>

	* Makefile.in: New stampfiles, libnettle.stamp and
	libhogweed.stamp, updated when both static and shared libraries
	are rebuilt. Used as link dependencies in subdirectories.
	* examples/Makefile.in: Make executable targets depend on
	../libnettle.stamp and libhogweed.stamp, not directly on the
	static library files.
	* testsuite/Makefile.in: Likewise.
	* tools/Makefile.in: Likewise.

1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
2013-09-09  Niels Möller  <nisse@lysator.liu.se>

	* gcm.c [HAVE_NATIVE_gcm_gf_mul_8]: Make use of (optional)
	assembly implementation.

	* configure.ac: Support optional assembly files for both nettle
	and hogweed. Replaced OPT_ASM_SOURCES with OPT_ASM_NETTLE_SOURCES,
	OPT_ASM_HOGWEED_SOURCES, and asm_optional_list with
	asm_nettle_optional_list and asm_hogweed_optional_list.
	(asm_nettle_optional_list): Added gcm-gf-mul-8.asm.

Niels Möller's avatar
Niels Möller committed
1131
1132
2013-06-25  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1133
1134
	* testsuite/gcm-test.c: Deleted redundant include of aes.h.

1135
1136
1137
	* testsuite/testutils.c (test_aead): Allow digest size smaller
	than the block size.

Niels Möller's avatar
Niels Möller committed
1138
1139
1140
1141
1142
1143
	* tools/nettle-pbkdf2.c: New command line tool.
	* tools/Makefile.in (TARGETS): Added nettle-pbkdf2.
	(nettle-pbkdf2$(EXEEXT)): New target.
	* testsuite/nettle-pbkdf2-test: New test case.
	* testsuite/Makefile.in (TS_SH): Added nettle-pbkdf2-test.

1144
1145
1146
	* tools/nettle-hash.c (digest_file): Use stack allocation for the
	small hex output buffer.

Niels Möller's avatar
Niels Möller committed
1147
1148
	* examples/io.c (MIN): Deleted unused macro.

1149
1150
1151
1152
1153
2013-05-21  Niels Möller  <nisse@lysator.liu.se>

	From nettle-2.7-fixes branch:
	* Makefile.in (distdir): Distribute files in arm/v6 subdirectory.

1154
1155
2013-05-20  Niels Möller  <nisse@lysator.liu.se>

1156
1157
1158
1159
	* arm/v6/sha1-compress.asm: Moved into v6 directory, since it uses
	the v6 instruction uadd8, sel and rev.
	* arm/v6/sha256-compress.asm: Likewise.

1160
1161
	* nettle-types.h: Include <stddef.h>, for size_t.

1162
1163
2013-05-17  Niels Möller  <nisse@lysator.liu.se>

1164
1165
1166
1167
	* macros.h (ROTL32, ROTL64): Avoid undefined behaviour for zero
	rotation count. Unfortunately makes CAST128 a bit slower with
	gcc-4.6.3.

1168
1169
1170
1171
	* ecc-j-to-a.c (ecc_j_to_a): Fixed ecc_modp_mul call, to avoid
	invalid overlap of arguments to mpn_mul_n. Problem tracked down by
	Magnus Holmgren.

1172
1173
2013-05-16  Niels Möller  <nisse@lysator.liu.se>

1174
1175
1176
1177
1178
1179
	* arm/aes-encrypt-internal.asm: New file, for pre-v6 processors.
	* arm/aes-decrypt-internal.asm: New file, likewise.

	* arm/aes.m4 (AES_FINAL_ROUND_V5): Variant without using uxtb.
	(AES_FINAL_ROUND_V6): New name, updated callers.
	(AES_FINAL_ROUND): ... old name. Also eliminated one uxtb
Niels Möller's avatar
Niels Möller committed
1180
1181
	instruction.
	(AES_ENCRYPT_ROUND, AES_DECRYPT): Moved macros to the
1182
1183
	files using them.

1184
1185
1186
1187
1188
	* arm/v6/aes-encrypt-internal.asm: Use ALIGN macro. Use 16-byte
	alignment for loops.
	* arm/v6/aes-decrypt-internal.asm: Likewise. Also added a nop
	which mysteriously improves benchmark performance on Cortex-A9.

1189
1190
1191
1192
1193
1194
1195
1196
1197
2013-05-15  Niels Möller  <nisse@lysator.liu.se>

	* configure.ac (asm_path): Handle armv6 and armv7 differently from
	older ARMs. Add the arm/v6 directory to asm_path when appropriate.

	* arm/v6/aes-encrypt-internal.asm: Moved into v6 directory. Uses
	the uxtb instruction which is not available for older ARMs.
	* arm/v6/aes-decrypt-internal.asm: Likewise.

1198
1199
1200
1201
1202
1203
1204
1205
1206
2013-05-03  Niels Möller  <nisse@lysator.liu.se>

	* cast128.c: Adapt to new struct cast128_ctx.
	(cast128_set_key): Rewrite, eliminating lots of conditions and
	some false warnings.

	* cast128.h (struct cast128_ctx): Separate the small 5-bit
	rotation subkeys and the larger 32-bit masking subkeys.

1207
1208
2013-05-02  Niels Möller  <nisse@lysator.liu.se>

1209
1210
1211
1212
	* testsuite/testutils.c (mpz_combit): Renamed. Define only if not
	provided GMP. Updated all uses.
	(mpz_togglebit): ... old name.

1213
1214
1215
	* sexp-format.c (sexp_vformat): Use type mpz_srcptr rather
	than the old MP_INT *.

1216
1217
1218
1219
1220
1221
2013-04-26  Niels Möller  <nisse@lysator.liu.se>

	* Many files: Use size_t rather than unsigned for data sizes.
	* x86_64/aes-encrypt-internal.asm: Accept 64-bit length.
	* x86_64/aes-decrypt-internal.asm: Likewise.

1222
1223
2013-04-25  Niels Möller  <nisse@lysator.liu.se>

1224
1225
1226
1227
1228
	* configure.ac: Changed version number, to 2.8.
	(LIBNETTLE_MAJOR): Bumped major number, following
	nettle_memxor ABI break.
	(LIBNETTLE_MINOR): Reset to zero.

1229
1230
	* examples/hogweed-benchmark.c: Add benchmarking of OpenSSL's RSA
	functions.
1231
	(all functions): Deleted unneeded casts.
1232

Niels Möller's avatar
Niels Möller committed
1233
1234
2013-04-24  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1235
1236
1237
	* nettle.texinfo (Miscellaneous functions): Updated memxor
	prototype. Document memxor3.

1238
1239
1240
1241
1242
	* salsa20-crypt.c (salsa20_crypt): Deleted cast of memxor
	argument, no longer needed.
	* salsa20r12-crypt.c (salsa20r12_crypt): Likewise.
	* sha3.c (sha3_absorb): Likewise.

1243
1244
1245
1246
1247
1248
1249
1250
	* memxor.h: Updated prototypes. Drop include of nettle-types.h.

	* memxor.c: Include nettle-types.h, for uintptr_t. Replace all
	internal uses of uint8_t by plain char.
	(memxor): Use void * rather than uint8_t * for
	arguments.
	(memxor3): Likewise.

1251
1252
1253
1254
1255
1256
1257
1258
1259
	* x86_64/memxor.asm: Added nettle_ prefix to symbols.
	* arm/memxor.asm: Likewise.

	* testsuite/symbols-test: Don't allow memxor functions without
	nettle prefix,

	* memxor.h (memxor3): Added name mangling to add "nettle_" prefix
	to memxor and memxor3 symbols.

1260
1261
1262
1263
1264
1265
1266
	* Makefile.in (nettle_OBJS): Deleted $(LIBOBJS), and also deleted
	LIBOBJS substitution.
	(nettle_SOURCES): Added memxor.c, to include it in the library
	unconditionally.

	* configure.ac: Deleted AC_REPLACE_FUNCS for memxor.

Niels Möller's avatar
Niels Möller committed
1267
1268
	* Released nettle-2.7.

1269
1270
1271
2013-04-23  Niels Möller  <nisse@lysator.liu.se>

	From Martin Storsjö:
1272
1273
	* x86_64/sha256-compress.asm: Add forgotten W64_EXIT.
	* x86_64/sha512-compress.asm: Likewise.
1274
1275
	* x86_64/salsa20-crypt.asm (Lpartial): Don't return via W64_EXIT
	within this subfunction.
1276
1277
	* x86_64/machine.m4 (W64_ENTRY): Use movdqu instead of movdqa for
	saving xmm registers, since the stack is not guaranteed to be
1278
1279
1280
	16-byte aligned on win64. Take pushed xmm registers into account
	when reading the fifth parameter from the stack.

1281
1282
	* Makefile.in: Consistently use EXEEXT_FOR_BUILD.

Niels Möller's avatar
Niels Möller committed
1283
1284
1285
1286
1287
2013-04-21  Niels Möller  <nisse@lysator.liu.se>

	* Makefile.in (DISTFILES): Added mini-gmp.c and mini-gmp.h.
	(distdir): Use find, for identifying assembly files to copy.

1288
1289
2013-04-18  Niels Möller  <nisse@lysator.liu.se>

1290
1291
	* configure.ac: Recognize cpu type "arm*", not just "armv7*'.

1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
	* arm/aes-encrypt-internal.asm: Updated include of aes.m4.
	* arm/aes-decrypt-internal.asm: Likewise.

	* Makefile.in (distdir): Updated for ARM reorganization.

	* configure.ac (asm_path): Generalized, can now be a list of
	directories. On ARM, check for neon instructions, and add arm/neon
	if appropriate. New command line options
	--enable-arm-neon/--disable-arm-neon, for overriding the default.

	arm/neon: New subdirectory, for assembly files making use of neon
	instructions.

	arm: Renamed directory, from...
	armv7: ...old name.

	* aclocal.m4 (NETTLE_CHECK_ARM_NEON): New macro.

Niels Möller's avatar
Niels Möller committed
1310
1311
	* nettle.texinfo (Keyed hash functions): Document UMAC.

1312
1313
	* umac.h (UMAC32_DIGEST_SIZE, UMAC64_DIGEST_SIZE)
	(UMAC96_DIGEST_SIZE, UMAC128_DIGEST_SIZE): New constants.
1314
1315
1316
	(UMAC_DATA_SIZE): New name, for consistency with hash functions.
	Updated all uses.
	(UMAC_BLOCK_SIZE): ... old name.
1317

1318
1319
2013-04-17  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1320
1321
1322
1323
1324
1325
	* examples/nettle-benchmark.c (main): Benchmark salsa20r12.

	* nettle-internal.c (nettle_salsa20r12): Cipher struct for
	benchmarking only.
	* nettle-internal.h (nettle_salsa20): Declare it.

1326
1327
	* Makefile.in (eccdata): Depend on mini-gmp files. Drop -lgmp.

1328
1329
1330
1331
1332
1333
1334
	* eccdata.c: Use mini-gmp, to avoid gmp dependency and associated
	configure tests for the *build* system. Replaced mpz_submul_ui by
	mpz_mul_ui + mpz_sub, and gmp_printf and gmp_fprintf by calls to
	mpz_out_str.

	* mini-gmp.h, mini-gmp.c: New files, copied from gmp-5.1.1.

1335
1336
2013-04-16  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1337
1338
1339
	* umac-set-key.c (BE_SWAP32_N): Fixed dummy definition used for
	big-endian systems.

1340
1341
1342
1343
	* Makefile.in (TARGETS): Deleted eccdata, it should be build only
	when public key support is enabled.
	(clean-here): Exlicitly list it here.

1344
1345
1346
1347
	* asm.m4 (m4_log2): New macro, similar to the one in gmp.
	(ALIGN): Changed to take alignment in bytes. Updated all callers,
	currently used only in x86 and x86_64 files.

1348
1349
1350
1351
	* umac.h (umac32_ctx, umac64_ctx, umac96_ctx, umac128_ctx): Make
	block count an uint64_t. Reorder some elements to put short values
	together.
	* umac-l2.c (_umac_l2, _umac_l2_final): Make count argument an uint64_t.
1352
1353
1354
1355
	(_umac_l2): Deleted redundant memcpy.
	(_umac_l2, _umac_l2_final): Store input buffer at end of the
	poly64/poly128 state. Deleted l1_out from corresponding context
	structs, and updated all callers.
1356

1357
	* configure.ac: Changed version number to 2.7.
Niels Möller's avatar
Niels Möller committed
1358
1359
	(LIBNETTLE_MINOR): Bumped library version, to 4.6.
	(LIBHOGWEED_MINOR): And to 2.4.
1360

1361
1362
	* Makefile.in (distdir): Include files from armv7 subdirectory.

Niels Möller's avatar
Niels Möller committed
1363
1364
	* x86_64/umac-nh-n.asm: New file, 3.5 time speedup.

1365
1366
1367
	* umac32.c (umac32_digest): Fix nonce caching.
	* umac64.c (umac64_digest): Likewise.

Niels Möller's avatar
Niels Möller committed
1368
1369
1370
	* testsuite/umac-test.c (test_incr): New function.
	(test_main): Test nonce increment.

1371
1372
1373
1374
1375
	* misc/umac/umac.py: UMAC reference implementation.
	* misc/umac/rijndael.py: AES implementation used by umac.py.
	* misc/umac/mkvectors: Script to generate UMAC test vectors.
	* misc/umac/vectors.out: Generated test vectors.

Niels Möller's avatar
Niels Möller committed
1376
1377
1378
1379
1380
1381
	* umac32.c (umac32_digest): Fix nonce increment, use INCREMENT
	macro.
	* umac64.c (umac64_digest): Likewise.
	* umac96.c (umac96_digest): Likewise.
	* umac128.c (umac128_digest): Likewise.

1382
1383
	* macros.h (INCREMENT): Allow size == 1.

Niels Möller's avatar
Niels Möller committed
1384
1385
2013-04-15  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1386
1387
	* x86_64/umac-nh.asm: New file. 4.4 time speedup.

Niels Möller's avatar
Niels Möller committed
1388
1389
	* armv7/umac-nh-n.asm: New file. 2.0-2.3 time speedup.

Niels Möller's avatar
Niels Möller committed
1390
1391
	* testsuite/umac-test.c (test_align): Fixed memory leak.

Niels Möller's avatar
Niels Möller committed
1392
1393
2013-04-12  Niels Möller  <nisse@lysator.liu.se>

1394
1395
	* armv7/umac-nh.asm: New file. 2.4 time speedup.

Niels Möller's avatar
Niels Möller committed
1396
1397
	* armv7/machine.m4 (D0REG, D1REG): New macros.

1398
1399
1400
	* configure.ac (asm_replace_list): Added umac-nh.asm and
	umac-nh-n.asm.

Niels Möller's avatar
Niels Möller committed
1401
1402
1403
	* testsuite/umac-test.c: Test different alignments for the
	message.

1404
1405
2013-04-11  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1406
1407
1408
	* umac-nh-n.c (_umac_nh_n): Rewrote as a single pass over the
	message data.

Niels Möller's avatar
Niels Möller committed
1409
1410
1411
	* examples/nettle-benchmark.c (time_umac): New function.
	(main): Call it.

1412
1413
1414
1415
1416
1417
1418
1419
1420
	* umac-set-key.c (_umac_set_key): Drop byteswapping of l3_key2, it
	can be xored directly to the pad in native byteorder.
	* umac-l3.c (_umac_l3): Drop key_2 argument, let caller do that
	xor. Updated all callers.
	* umac32.c (umac32_digest): Adapt to l3 changes.
	* umac64.c (umac64_digest): Likewise.
	* umac96.c (umac96_digest): Likewise.
	* umac128.c (umac128_digest): Likewise.

Niels Möller's avatar
Niels Möller committed
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
	Initial implementation of umac.
	* umac.h: New file.
	* umac-nh.c: New file.
	* umac-nh-n.c: New file.
	* umac-poly64.c: New file.
	* umac-poly128.c: New file.
	* umac-l2.c: New file.
	* umac-l3.c: New file.
	* Makefile.in (nettle_SOURCES): Added umac source files.
	(HEADERS): Added umac.h.
	* testsuite/umac-test.c: New file.
	* testsuite/Makefile.in (TS_NETTLE_SOURCES): Added umac-test.c.

1434
1435
1436
1437
1438
1439
	* ecc-mul-a.c (ecc_mul_a): Avoid using mp_bitcnt_t, for
	compatibility with older GMP versions.
	* ecc-mul-g.c (ecc_mul_g): Likewise.
	* eccdata.c (ecc_mul_binary): Likewise.
	* sec-modinv.c (sec_modinv): Likewise.

1440
1441
1442
	* x86_64/sha3-permute.asm: Go via memory for moves between general
	registers and xmm registers.

1443
1444
1445
1446
1447
1448
2013-04-06  Niels Möller  <nisse@lysator.liu.se>

	From Edgar E. Iglesias:
	* sha3.c (_sha3_update): Fix condition for when the block buffer
	is full.

1449
1450
2013-04-04  Niels Möller  <nisse@lysator.liu.se>

1451
1452
1453
	* ecc-point.c (ecc_point_get): Allow NULL x or y, ignore
	corresponding coordinate.

1454
1455
1456
	* nettle.texinfo (Elliptic curves): Document high-level ECDSA
	support.

1457
1458
1459
	From Martin Storsjö. Fallback functions for older GMP releases.
	* gmp-glue.c (mpn_copyd, mpn_copyi, mpn_zero): New functions.
	* gmp-glue.h: Declare them.
1460
	(mpn_sqr): Fallback macro.
1461

1462
1463
1464
1465
1466
1467
1468
1469
1470
	* gmp-glue.h (cnd_add_n, cnd_sub_n): Moved here, define in terms
	of mpn_cnd_add_n and mpn_sub_n if available, otherwise in terms of
	mpn_addmul_1 and mpn_submul_1. This seems to be an improvement for
	subtraction, but more questionable for addition.

	* ecc-internal.h: Include gmp-glue.h. Deleted corresponding
	include in all files using ecc-internal.h.
	(cnd_add_n, cnd_sub_n): Moved from here.

Niels Möller's avatar
Niels Möller committed
1471
1472
2013-04-03  Niels Möller  <nisse@lysator.liu.se>

1473
1474
1475
1476
1477
1478
	* ecc-point-mul-g.c (ecc_point_mul_g): New file and function.
	* ecc-point-mul.c (ecc_point_mul): New file and function.
	* ecc.h: Updated declarations and name mangling.
	* Makefile.in (hogweed_SOURCES): Added ecc-point-mul.c and
	ecc-point-mul-g.c.

Niels Möller's avatar
Niels Möller committed
1479
1480
1481
	* testsuite/salsa20-test.c (test_main): Tests for salsa20r12,
	contributed by Nikos Mavrogiannopoulos.

Niels Möller's avatar
Niels Möller committed
1482
1483
1484
1485
2013-03-26  Niels Möller  <nisse@lysator.liu.se>

	* armv7/salsa20-core-internal.asm: New file. 45% speedup.

1486
1487
2013-03-25  Niels Möller  <nisse@lysator.liu.se>

1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
	From Martin Storsjö:
	* examples/timing.c: New file, extracted from nettle-benchmark.c.
	* examples/timing.h: New file.
	* examples/Makefile.in (SOURCES): Added timing.c.
	(DISTFILES): Added timing.h.
	(BENCH_OBJS, ECC_BENCH_OBJS, HOGWEED_BENCH_OBJS): Added timing.o.
	* examples/nettle-benchmark.c: Use timing.h.
	* examples/hogweed-benchmark.c: Likewise.
	* examples/ecc-benchmark.c: Likewise.

Niels Möller's avatar
Niels Möller committed
1498
1499
1500
1501
1502
	From Nikos Mavrogiannopoulos:
	* salsa20r12-crypt.c (salsa20r12_crypt): New file and function.
	* salsa20.h (salsa20r12_crypt): Declare.
	* Makefile.in (nettle_SOURCES): Added salsa20r12-crypt.c.

1503
	From Martin Storsjö:
1504
1505
	* examples/hogweed-benchmark.c: Include local headers.
	* testsuite/ecdsa-keygen-test.c: Likewise.
1506
	* x86_64/sha3-permute.asm: Workaround for Apple's assembler; write
1507
	movq instructions as movd.
1508

1509
1510
1511
	* Makefile.in (hogweed_PURE_OBJS): Don't include OPT_ASM_SOURCES
	twice.

Niels Möller's avatar
Niels Möller committed
1512
1513
2013-03-15  Niels Möller  <nisse@lysator.liu.se>

1514
1515
	* armv7/sha3-permute.asm: New file. 4.5 time speedup.

Niels Möller's avatar
Niels Möller committed
1516
1517
	* armv7/machine.m4 (QREG): New macro.

Niels Möller's avatar
Niels Möller committed
1518
1519
2013-03-14  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1520
1521
1522
1523
	* configure.ac (asm_replace_list): Added sha3-permute.asm,
	revering 2012-12-30 change. 34% speedup on intel i5, from 2190
	cycles for the C implementation down to 1630.

Niels Möller's avatar
Niels Möller committed
1524
1525
1526
	* armv7/sha512-compress.asm: Optimized. Keep expanded data in
	registers, exploit parallelism. Another 70% speedup.

Niels Möller's avatar
Niels Möller committed
1527
1528
1529
	* testsuite/sha512-test.c (test_main): Additional test vectors,
	including some longer than 128 bytes.

Niels Möller's avatar
Niels Möller committed
1530
1531
2013-03-13  Niels Möller  <nisse@lysator.liu.se>

1532
1533
1534
	* armv7/sha512-compress.asm: New file, using neon instructions.
	2.3 time speedup.

Niels Möller's avatar
Niels Möller committed
1535
1536
1537
1538
	* configure.ac (asm_replace_list): Added sha512-compress.asm.
	* x86_64/machine.m4 (OFFSET64): New macro.
	* x86_64/sha512-compress.asm: New file, 20% speedup.

1539
1540
1541
	* sha512-compress.c (ROUND): Eliminated a temporary, analogous to
	sha256 change below.

Niels Möller's avatar
Niels Möller committed
1542
1543
1544
	* x86_64/sha256-compress.asm: New file, 16% speedup (benchmarked
	on intel i5).

1545
1546
2013-03-11  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1547
1548
1549
1550
	* armv7/sha256-compress.asm: New file, 25% speedup.

	* configure.ac (asm_replace_list): Added sha256-compress.asm.

1551
1552
	* sha256-compress.c (ROUND): Eliminated a temporary.

Niels Möller's avatar
Niels Möller committed
1553
1554
	* armv7/sha1-compress.asm: New file, 9% speedup.

1555
1556
1557
	* testsuite/testutils.c (test_hash): Test different alignments for
	the hash input.

Niels Möller's avatar
Niels Möller committed
1558
1559
1560
1561
1562
1563
2013-03-08  Niels Möller  <nisse@lysator.liu.se>

	* armv7/aes-decrypt-internal.asm: New file, 15% speedup.
	* armv7/aes-encrypt-internal.asm: New file, 25% speedup.
	* armv7/aes.m4: New file.

1564
1565
2013-03-07  Niels Möller  <nisse@lysator.liu.se>

1566
1567
	* gmp-glue.c (mpz_limbs_cmp): Don't use PTR and SIZ macros.

Niels Möller's avatar
Niels Möller committed
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
	* Makefile.in (aesdata, desdata, twofishdata, shadata, gcmdata)
	(eccdata): Arrange for compiling these programs for running on the
	build system, also when cross compiling everything else.

	* config.make.in (CC_FOR_BUILD, EXEEXT_FOR_BUILD): New variables.

	* configure.ac: Use GMP_PROG_CC_FOR_BUILD and
	GMP_PROG_EXEEXT_FOR_BUILD.

	* aclocal.m4 (GMP_PROG_CC_FOR_BUILD, GMP_PROG_CC_FOR_BUILD_WORKS)
	(GMP_PROG_EXEEXT_FOR_BUILD): New macros, based on GMP's.

1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
	* aesdata.c: Deleted includes of config.h and nettle-types.h. Use
	unsigned char and unsigned long instead of stdint.h types.

	* desdata.c: Deleted includes of config.h and desCode.h.
	(main): Return 1 on invalid argument. Don't use ROR macro. Use
	unsigned long instead of uint32_t, and make it work if unsigned
	long is larger than 32 bits.

	* gcmdata.c: Deleted include of config.h and use UNUSED macro.
	* shadata.c: Likewise.

	* twofishdata.c: Deleted include of nettle-types.h. Use unsigned
	char instead of stdint.h types.

1594
1595
	* x86_64/ecc-521-modp.asm: New file. 2.4 time speedup.

1596
1597
2013-03-06  Niels Möller  <nisse@lysator.liu.se>

1598
	* x86_64/ecc-384-modp.asm: New file, 3 time speedup.
1599
	* x86_64/ecc-256-redc.asm: New file, 2.5 time speedup.
1600
1601
1602
	* x86_64/ecc-224-modp.asm: New file, 5 time speedup over C
	version.

Niels Möller's avatar
Niels Möller committed
1603
1604
1605
1606
1607
1608
1609
2013-03-05  Niels Möller  <nisse@lysator.liu.se>

	* configure.ac (asm_optional_list): Added ecc-521-modp.asm.
	* ecc-521.c: Check HAVE_NATIVE_ecc_521_modp, and use native
	version if available.
	* armv7/ecc-521-modp.asm: New file, 2 time speedup over C version.

Niels Möller's avatar
Niels Möller committed
1610
1611
1612
1613
1614
1615
1616
1617
2013-03-04  Niels Möller  <nisse@lysator.liu.se>

	* configure.ac (asm_optional_list): Added ecc-384-modp.asm. Deleted
	bogus reference to $asm_search_list.
	* ecc-384.c: Check HAVE_NATIVE_ecc_384_modp, and use native
	version if available.
	* armv7/ecc-384-modp.asm: New file, 3 time speedup over C version.

1618
1619
1620
1621
2013-03-03  Niels Möller  <nisse@lysator.liu.se>

	* ecc-256.c: Fixed definition of USE_REDC.

1622
1623
2013-03-01  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1624
1625
1626
1627
	* ecc-256.c: Check HAVE_NATIVE_ecc_256_redc, and use native
	version if available.
	* armv7/ecc-256-redc.asm: New file, 4 time speedup over C version.

1628
1629
	* testsuite/ecc-redc-test.c: Increased test count.

Niels Möller's avatar
Niels Möller committed
1630
1631
1632
1633
1634
	* ecc-224.c: Check HAVE_NATIVE_ecc_224_modp, and use native
	version if available.
	* armv7/ecc-224-modp.asm: New file, 4.5 time speedup over C
	version.

1635
1636
1637
	* configure.ac (asm_optional_list): Added ecc-224-modp.asm.
	(OPT_ASM_SOURCES): Fixed assignment.

Niels Möller's avatar
Niels Möller committed
1638
1639
2013-02-28  Niels Möller  <nisse@lysator.liu.se>

1640
1641
1642
	* x86_64/ecc-192-modp.asm: Reorganized to reduce number of
	additions. Use setc instruction.

1643
1644
1645
	* examples/Makefile.in: Let $(HOGWEED_TARGETS) depend on
	../libhogweed.a.

Niels Möller's avatar
Niels Möller committed
1646
1647
1648
	* armv7/ecc-192-modp.asm: New file. 2.5 time speedup over C
	version.

1649
1650
2013-02-27  Niels Möller  <nisse@lysator.liu.se>

1651
1652
	* ecc-192.c: Check HAVE_NATIVE_ecc_192_modp, and use native
	version if available.
Niels Möller's avatar
Niels Möller committed
1653
	(ecc_192_modp): Fixed carry handling bug in 32-bit version.
1654

Niels Möller's avatar
Niels Möller committed
1655
1656
	* x86_64/ecc-192-modp.asm: New file. 3.8 times speedup over C
	version.
1657

1658
1659
1660
1661
1662
1663
1664
1665
	* configure.ac (OPT_ASM_SOURCES): New substituted variable.
	(asm_replace_list, asm_optional_list): New variables. For files in
	asm_optional_list, also add them to OPT_ASM_SOURCES and define
	appropriate HAVE_NATIVE_* symbols found.

	* Makefile.in (OPT_ASM_SOURCES): New variable. Used for setting
	hogweed_OBJS and hogweed_PURE_OBJS.

1666
1667
	* testsuite/ecc-mod-test.c: Increased test count.

1668
1669
1670
	* ecc-384.c (ecc_384_modp): Fixed typo which broke carry handling
	in the 64-bit version.

Niels Möller's avatar
Niels Möller committed
1671
1672
1673
	* examples/ecc-benchmark.c (bench_add_jjj): Typo fix, benchmark
	the right function.

1674
1675
1676
1677
1678
1679
	* gmp-glue.h: Check if GMP provides mpz_limbs_read (expected in
	next release).
	* gmp-glue.c: Use GMP's mpz_limbs_read and friends if available.
	Renamed all functions for consistency with GMP. Updated all
	callers.

1680
1681
2013-02-20  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1682
1683
1684
1685
1686
1687
1688
	* examples/Makefile.in (HOGWEED_TARGETS): Added
	hogweed-benchmark$(EXEEXT).
	(SOURCES): Added hogweed-benchmark.c.
	(hogweed-benchmark$(EXEEXT)): New target.

	* examples/hogweed-benchmark.c: New file.

1689
1690
1691
1692
1693
1694
	* ecdsa-keygen.c (ecdsa_generate_keypair): New file and function.
	* Makefile.in (hogweed_SOURCES): Added ecdsa-keygen.c.
	* testsuite/ecdsa-keygen-test.c: New testcase.
	* testsuite/Makefile.in (TS_HOGWEED_SOURCES): Added
	ecdsa-keygen-test.c.

1695
1696
	* nettle-internal.h (TMP_ALLOC): Added missing parentheses.

1697
1698
2013-02-18  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1699
1700
1701
1702
1703
1704
	* testsuite/ecdsa-verify-test.c: New testcase.
	* testsuite/ecdsa-sign-test.c: New testcase.
	* testsuite/Makefile.in (TS_HOGWEED_SOURCES): Added
	ecdsa-sign-test.c and ecdsa-verify-test.c.
	* testsuite/testutils.h: Include ecdsa.h.
	(SHEX): Deleted const cast.
1705

1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
	* ecc-point.c: New file, struct ecc_point abstraction.
	* ecc-scalar.c: New file, struct ecc_scalar abstraction.
	* ecc-random.c (ecc_modq_random, ecc_scalar_random): New file, new
	functions.
	* ecc-hash.c (ecc_hash): New file and function.
	* ecc-ecdsa-sign.c: New file, low-level signing interface.
	* ecc-ecdsa-verify.c: New file, low-level ecdsa verify.
	* ecdsa-sign.c: (ecdsa_sign): New file and function.
	* ecdsa-verify.c (ecdsa_verify): New file and function.
	* ecdsa.h: New header file.
	* ecc.h: Declare ecc_point and ecc_scalar functions.
	* ecc-internal.h: Added declarations.
	* Makefile.in (hogweed_SOURCES): Added new source files.
	(HEADERS): Added ecdsa.h.

Niels Möller's avatar
Niels Möller committed
1721
1722
1723
1724
1725
1726
	* gmp-glue.c (_mpz_set_mpn): New convenience function.
	(_mpn_set_base256): New function.
	(_gmp_alloc_limbs): New function.
	(_gmp_free_limbs): New function.
	* gmp-glue.h: Corresponding declarations. Include nettle-stdinh.h.

1727
1728
1729
1730
1731
1732
1733
	* examples/Makefile.in (HOGWEED_TARGETS): Renamed, was
	RSA_TARGETS. Added ecc-benchmark$(EXEEXT).
	(SOURCES): Added ecc-benchmark.c.
	(ecc-benchmark$(EXEEXT)): New target.

	* examples/ecc-benchmark.c: New file, benchmarking ecc primitives.

1734
1735
2013-02-15  Niels Möller  <nisse@lysator.liu.se>

Niels Möller's avatar
Niels Möller committed
1736
1737
1738
1739
1740
1741
1742
1743
1744
	Integrate ecc_mul_a.
	* ecc-a-to-j.c: New file.
	* ecc-add-jjj.c: New file.
	* ecc-mul-a.c: New file.
	* Makefile.in (hogweed_SOURCES): Added new files.
	* testsuite/ecc-mul-a-test.c: New file.
	* testsuite/Makefile.in (TS_HOGWEED_SOURCES): Added
	ecc-mul-a-test.c.

1745
1746
1747
	* testsuite/testutils.c: Removed redundant includes.
	(die): New function.

Niels Möller's avatar
Niels Möller committed
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
	Integrate ecc_mul_g.
	* ecc.h: New file.
	* ecc-j-to-a.c: New file.
	* ecc-size.c: New file.
	* ecc-add-jja.c: New file.
	* ecc-dup-jj.c: New file.
	* ecc-mul-g.c: New file.
	* sec-tabselect.c: New file.
	* Makefile.in (hogweed_SOURCES): Added new files.
	(HEADERS): Added ecc.h
	* testsuite/ecc-mul-g-test.c: New file.
	* testsuite/Makefile.in (TS_HOGWEED_SOURCES): Added
	ecc-mul-g-test.c.
	* testsuite/testutils.c (xalloc_limbs): New function.
	(test_mpn): New function.
	(test_ecc_point): New function.
	(test_ecc_mul_a): New function.
	(test_ecc_mul_j): New function.
	* testsuite/testutils.h: Corresponding declarations.

Niels Möller's avatar
Niels Möller committed
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
	Integrate ECC internals.
	* ecc-curve.h: New file.
	* ecc-internal.h: New file.
	* cnd-cop