From 037d694ba0e9d9e84f30b2176231fa1e06680c03 Mon Sep 17 00:00:00 2001
From: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Date: Sat, 21 May 2011 12:51:32 +0200
Subject: [PATCH] (dsa_generate_keypair): Avoid double init of mpz variable.
Spotted by Nikos Mavrogiannopoulos.
Rev: nettle/ChangeLog:1.167
Rev: nettle/dsa-keygen.c:1.10
---
ChangeLog | 5 +++++
dsa-keygen.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 2a61f702..2a4e2c52 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-05-21 Niels M�ller <nisse@lysator.liu.se>
+
+ * dsa-keygen.c (dsa_generate_keypair): Avoid double init of mpz
+ variable. Spotted by Nikos Mavrogiannopoulos.
+
2011-05-06 Niels M�ller <nisse@lysator.liu.se>
* configure.ac: Fix link flags for shared libraries on Solaris,
diff --git a/dsa-keygen.c b/dsa-keygen.c
index be177712..00bd35f6 100644
--- a/dsa-keygen.c
+++ b/dsa-keygen.c
@@ -106,7 +106,7 @@ dsa_generate_keypair(struct dsa_public_key *pub,
if (progress)
progress (progress_ctx, 'g');
- mpz_init_set(r, pub->q);
+ mpz_set(r, pub->q);
mpz_sub_ui(r, r, 2);
nettle_mpz_random(key->x, random_ctx, random, r);
--
GitLab