From 4f0ad31af6b5c80757cd460d1c3efb38fe4f0ae0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= <nisse@lysator.liu.se> Date: Thu, 13 Sep 2018 08:18:16 +0200 Subject: [PATCH] rsa_generate_keypair: Delete unlikely and redundant check for p == q. --- ChangeLog | 5 +++++ rsa-keygen.c | 4 ---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 83e96789..4c384ffa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-09-13 Niels Möller <nisse@lysator.liu.se> + + * rsa-keygen.c (rsa_generate_keypair): Delete unlikely and + redundant check for p == q. + 2018-08-09 Niels Möller <nisse@lysator.liu.se> * rsa-internal.h (_rsa_blind, _rsa_unblind): Mark with diff --git a/rsa-keygen.c b/rsa-keygen.c index b7e38f77..702b63b8 100644 --- a/rsa-keygen.c +++ b/rsa-keygen.c @@ -126,10 +126,6 @@ rsa_generate_keypair(struct rsa_public_key *pub, random_ctx, random, progress_ctx, progress); - /* Very unlikely. */ - if (mpz_cmp (key->q, key->p) == 0) - continue; - mpz_sub_ui(q1, key->q, 1); /* If e was given, we must choose q such that q-1 has no factors in -- GitLab