Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Dmitry Baryshkov
nettle
Commits
bc702ca3
Commit
bc702ca3
authored
Oct 23, 2014
by
Niels Möller
Browse files
Enable valgrind's --partial-loads-ok only when build includes assembly files.
parent
842abf37
Changes
3
Hide whitespace changes
Inline
Side-by-side
ChangeLog
View file @
bc702ca3
2014-10-23 Niels Möller <nisse@lysator.liu.se>
* configure.ac (IF_ASM): New substituted variable.
* testsuite/Makefile.in (VALGRIND): Allow partial loads only when
build includes assembly files.
* memxor-internal.h (READ_PARTIAL): New macro.
* memxor.c (memxor_different_alignment): Avoid out-of-bounds
reads, corresponding to valgrind's --partial-loads-ok. Use
...
...
configure.ac
View file @
bc702ca3
...
...
@@ -356,6 +356,12 @@ fi
AC_SUBST([OPT_ASM_NETTLE_SOURCES])
AC_SUBST([OPT_ASM_HOGWEED_SOURCES])
AC_SUBST([ASM_RODATA])
if test "x$enable_assembler" = xyes ; then
IF_ASM=''
else
IF_ASM='#'
fi
AC_SUBST([IF_ASM])
AH_VERBATIM([HAVE_NATIVE],
[/* Define to 1 each of the following for which a native (ie. CPU specific)
...
...
testsuite/Makefile.in
View file @
bc702ca3
...
...
@@ -114,7 +114,7 @@ $(TARGETS) $(EXTRA_TARGETS): testutils.$(OBJEXT) ../nettle-internal.$(OBJEXT) \
# --partial-loads-ok=yes is needed for memxor's handling of unaligned
# data.
VALGRIND
=
valgrind
--error-exitcode
=
1
--leak-check
=
full
--
partial-loads-ok
=
yes
--show-reachable
=
yes
VALGRIND
=
valgrind
--error-exitcode
=
1
--leak-check
=
full
--
show-reachable
=
yes
@IF_ASM@
--partial-loads-ok
=
yes
# The PATH update is for locating dlls on w*ndows.
check
:
$(TS_ALL)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment