Commit a27e848d authored by Johan Sundström's avatar Johan Sundström
Browse files

Improved default guess for kom-go-to-conf and kom-sub-self, according to the...

Improved default guess for kom-go-to-conf and kom-sub-self, according to the principle "if we have no good guess, do not annoy the user with a horrible one".
parent 427a670a
2003-08-05 Johan Sundström <jhs@lysator.liu.se>
* commands1.el (kom-go-to-conf): Never suggest going to the
conference you are already in. It is a very annoying default.
(kom-sub-self): Never suggest dropping out of your mailbox. It
is about the last conference you are likely to want to leave.
2003-08-04 David Byers <byers@lysator.liu.se>
* commands2.el (kom-status-server): Show ascent and descent rates
......
......@@ -888,7 +888,7 @@ supervisor of the conference or of the member being removed."
'(all) nil nil t)))
(def-kom-command kom-sub-self (&optional conf)
(def-kom-command kom-sub-self (&optional conf-no)
"Resign your membership of a conference. If
`kom-unsubscribe-makes-passive' is set, them resigning once converts
your membership to a passive membership and resigning twice removes
......@@ -897,11 +897,16 @@ memberships).
See `kom-unsubscribe-makes-passive'."
(interactive)
(lyskom-sub-member
(blocking-do 'get-conf-stat lyskom-pers-no)
(if conf (blocking-do 'get-conf-stat conf)
(lyskom-read-conf-stat (lyskom-get-string 'leave-what-conf)
'(membership) nil nil t))))
(let* ((me (blocking-do 'get-conf-stat lyskom-pers-no))
(conf (if conf-no (blocking-do 'get-conf-stat conf-no)
(let ((default (lyskom-read-conf-guess-initial '(membership)))
(mailbox (conf-stat->name me)))
(if (equal default mailbox)
(setq default ""))
(lyskom-read-conf-stat
(lyskom-get-string 'leave-what-conf)
'(membership) nil default t)))))
(lyskom-sub-member me conf)))
(defun lyskom-sub-member (pers conf &optional have-message)
"Remove the person indicated by PERS as a member of CONF."
......@@ -1705,11 +1710,18 @@ Changing conferences runs `kom-change-conf-hook' and
(interactive)
(let ((conf (if conf-no
(blocking-do 'get-conf-stat conf-no)
(lyskom-read-conf-stat
(lyskom-get-string 'go-to-conf-p)
'(all) nil nil t))))
(when (lyskom-check-go-to-conf conf)
(lyskom-go-to-conf conf))))
(let ((default (lyskom-read-conf-guess-initial '(all)))
(current (uconf-stat->name
(blocking-do 'get-uconf-stat
lyskom-current-conf))))
(if (or (null current)
(equal default current))
(setq default ""))
(lyskom-read-conf-stat
(lyskom-get-string 'go-to-conf-p)
'(all) nil default t)))))
(when (lyskom-check-go-to-conf conf)
(lyskom-go-to-conf conf))))
(defun lyskom-go-to-conf (conf &optional no-prompt)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment