1. 22 Feb, 2004 2 commits
    • David Byers's avatar
      Refactored the code that controls adding memberships to eliminate · c3e8f21f
      David Byers authored
      duplicated code in callers, to simplify callers and to make sure that
      the appropriate questions were asked in the appropriate order at the
      appropriate time regardless how one joins a conference.
      
      Detailed changes:
      > 	Fix new bug in kom-is-person-member-of-conference:
      > 	* lyskom-rest.el (lyskom-get-read-texts-for-membership): Removed
      > 	this function again. It isn't used anywhere any more.
      >
      > 	* commands2.el (kom-is-person-member-of-conference): Don't use
      > 	lyskom-get-read-texts-for-membership. Don't need it.
      >
      > 	Refactoring of adding members to simplify all callers:
      > 	* lyskom-rest.el (lyskom-check-go-to-conf): Use lyskom-add-member
      > 	to add self when going to a conference we have been invited to or
      > 	need to depassivate.
      > 	(lyskom-startup-check-recommended-memberships): Use
      > 	lyskom-add-member to accept recommendations.
      >
      > 	* commands1.el (lyskom-add-member): New function.
      > 	(kom-add-self): Use lyskom-add-member.
      > 	(kom-add-member): Use lyskom-add-member.
      > 	(lyskom-add-member-by-no): Use lyskom-add-member.
      > 	(lyskom-go-to-conf): Don't ask for number of unread here.
      > 	(lyskom-add-member-answer): Removed this junk.
      > 	(lyskom-try-add-member): Removed this junk too.
      > 	(kom-change-priority): Use lyskom-add-member. Refuse to change
      > 	priority of passive memberships.
      >
      c3e8f21f
    • David Byers's avatar
      Fix bug 1251 · 5d15ad0b
      David Byers authored
      Detailed changes:
      > 	Fix bug 1251:
      > 	* commands1.el (kom-move-text): Don't try to move footnotes and
      > 	attachments that we can't read.
      >
      5d15ad0b
  2. 21 Feb, 2004 2 commits
    • David Byers's avatar
      Fixed bug 1276 · d7ea496a
      David Byers authored
      Detailed changes:
      > 2004-02-22  David Byers  <byers@lysator.liu.se>
      >
      > 	* option-edit.el: Added kom-auto-confirm-new-conferences to the
      > 	settings buffer.
      >
      2a8,13
      > 	Fix bug 1276:
      > 	* startup.el (lyskom-setup-ssh-relay): Use kom-ssh-command instead
      > 	of hardcoding the ssh command name.
      >
      > 	* vars.el.in (kom-ssh-command): New variable.
      >
      20c31
      <
      ---
      >
      d7ea496a
    • David Byers's avatar
      Fixed bug 1250. I hope. · bb7aca6f
      David Byers authored
      Detailed changes:
      > 2004-02-21  David Byers  <byers@lysator.liu.se>
      >
      > 	Fix bug 1250:
      > 	* view-text.el (lyskom-text-read-at-least-once-p): Don't consider
      > 	passive memberships.
      > 	(lyskom-text-read-p): Same here.
      >
      > 	* services.el (initiate-get-part-of-membership): Don't get read texts.
      >
      > 	* lyskom-rest.el (lyskom-get-read-texts-for-membership): New
      > 	function.
      >
      > 	* commands2.el (kom-is-person-member-of-conference): Use it here.
      >
      bb7aca6f
  3. 12 Feb, 2004 1 commit
    • David Byers's avatar
      Fix some bugs. Make server calls cancelable. Prompt for date in... · 57b0f861
      David Byers authored
      Fix some bugs. Make server calls cancelable. Prompt for date in lyskom-list-new-conferences when appropriate. Binary search on conference creation date. Cleanup.
      
      Detailed changes:
      > 2004-02-12  David Byers  <byers@lysator.liu.se>
      >
      > 	Make kom-list-new-conferences quittable:
      > 	* commands2.el (lyskom-list-new-conferences): Handle C-g when
      > 	listing conferences or persons using the new lyskom-cancel-calls.
      >
      > 	* internal.el (lyskom-cancel-calls): It works now.
      >
      > 2004-02-11  David Byers  <byers@lysator.liu.se>
      >
      > 	Improve ability to cancel calls:
      > 	* services.el (initiate-get-text): Add lyskom-ref-no to PARSED.
      > 	(initiate-get-text-stat): Ditto.
      > 	(initiate-get-pers-stat): Ditto.
      > 	(initiate-get-conf-stat): Ditto.
      > 	(initiate-get-uconf-stat): Ditto.
      > 	(initiate-get-static-session-info): Ditto.
      > 	(initiate-get-stats-description): Ditto.
      > 	(initiate-get-boottime-info): Ditto.
      >
      > 	* internal.el (lyskom-apply-handler): Allow ref-no in PARSED.
      >
      > 	* parse.el (lyskom-tr-call-to-parsed): Leave the ref-no in PARSED.
      >
      > 	* internal.el (lyskom-cancel-calls): New function.
      >
      > 	Prevent lyskom-ref-no from going negative:
      > 	* macros.el (lyskom-ref-no): New macro to get and increment
      > 	lyskom-ref-no.
      >
      > 	* internal.el (lyskom-send-packet): Ensure that lyskom-ref-no
      > 	never goes negative.
      >
      > 	Fix bug 1272:
      > 	* review.el (kom-review-converted): Don't bind
      > 	lyskom-format-special (why did we *ever* bind it here?)
      >
      > 2004-02-09  David Byers  <byers@lysator.liu.se>
      >
      > 	* clienttypes.el (lyskom-queue-remove-matching): New function.
      >
      > 2004-02-07  David Byers  <byers@lysator.liu.se>
      >
      > 	* utilities.el (lyskom-read-date): Added optional parameter empty.
      >
      > 	Speed up behavior after changing user area:
      > 	* async.el (lyskom-parse-async): Don't re-read settings if the new
      > 	user area is one we've already read (or just created).
      >
      > 	* flags.el (lyskom-save-options-2): Set lyskom-current-user-area.
      > 	(lyskom-read-options-eval): Ditto.
      >
      > 	Bug 1271 (and then some):
      > 	* commands2.el (kom-list-new-conferences): Accept prefix arg to
      > 	list from a specific date.
      > 	(kom-list-new-persons): Ditto.
      > 	(lyskom-list-new-conferences): Prompt for start date if the caller
      > 	requests it or the command has never been used before.
      >
      > 2004-02-06  David Byers  <byers@lysator.liu.se>
      >
      > 	* utilities.el (lyskom-find-conf-by-date): New function.
      >
      1a65,67
      >
      > 	* macros.el (blocking-do-multiple): Use modern backquote syntax to
      > 	make the code more readable.
      57b0f861
  4. 28 Jan, 2004 1 commit
    • David Byers's avatar
      Fixed two bugs. · 76a54e40
      David Byers authored
      Detailed changes:
      > 2004-01-29  David Byers  <byers@lysator.liu.se>
      >
      > 	* vars.el.in (lyskom-text-buttons): Improved performance of some
      > 	regexps in lyskom-text-buttons.
      >
      > 	* commands1.el (kom-move-text): Prevent moving from a conference
      > 	back to the same conference. Doing this deletes the recipient
      > 	completely.
      >
      4a14
      > 	(lyskom-text-buttons): Simplified the regexps for URLs.
      76a54e40
  5. 26 Jan, 2004 1 commit
    • David Byers's avatar
      Use modern calls for get-membership. Fix bug 1259. Make review state buffer-local. · b4bfa57a
      David Byers authored
      Detailed changes:
      > 2004-01-26  David Byers  <byers@lysator.liu.se>
      >
      > 	* vars.el.in (lyskom-format-special): Explicitly format plaintext
      > 	types.
      >
      > 	* lyskom-rest.el (smiley-region): New function.
      > 	(smiley-region): Use it. Clean up some of the code.
      >
      > 2004-01-13  David Byers  <byers@lysator.liu.se>
      >
      > 	* review.el: Made all state variables (for kom-review-more)
      > 	buffer-local.
      >
      > 2004-01-12  David Byers  <byers@lysator.liu.se>
      >
      > 	* services.el (initiate-get-membership): Use call 108 when
      > 	possible.
      > 	(initiate-get-part-of-membership): Same here.
      >
      > 	* parse.el (lyskom-parse-membership-list-11): New function.
      >
      b4bfa57a
  6. 01 Jan, 2004 6 commits
    • David Byers's avatar
      Fixed bug 1236. · deebac2d
      David Byers authored
      Detailed changes:
      > 	Fix bug 1236:
      > 	* vars.el.in (lyskom-default-conference-strategy): Added
      > 	kom-force-logout.
      >
      > 	* commands1.el (lyskom-return-username): Handle
      > 	static-session-info and session-info in addition to who-info.
      >
      deebac2d
    • David Byers's avatar
      Bug fix · fbcd48a7
      David Byers authored
      fbcd48a7
    • David Byers's avatar
      Changelog entries for recent changes. · 2503af95
      David Byers authored
      Detailed changes:
      > 	Fix bug 1237:
      > 	* vars.el.in (lyskom-commands-not-in-menu): New variable.
      >
      > 	* check-strings.el (lyskom-check-strings): Check main menu to
      > 	ensure that all commands are in menus.
      > 	(lcs-check-menu-template): New function.
      > 	(lcs-extract-commands-from-menu-template): New function.
      >
      > 	Improve display of accelerators in menus:
      2503af95
    • David Byers's avatar
      Bug fix for last checkin. · e4da1c6e
      David Byers authored
      Detailed changes:
      e4da1c6e
    • David Byers's avatar
      Attempt to clean up menus in W32 · 1b085b7d
      David Byers authored
      Detailed changes:
      < 	(lyskom-define-menu-gnu): Same here.
      ---
      > 	(lyskom-define-menu-gnu): Same here. In W32, encode the keyboard
      > 	shortcut using latin-1. Hopefully that will get rid of the little
      > 	boxes in the menus.
      1b085b7d
    • David Byers's avatar
      Keyboard shortcuts using swedish chars in menus. Make language selection... · f52621b4
      David Byers authored
      Keyboard shortcuts using swedish chars in menus. Make language selection options clearer in the menus.
      
      Detailed changes:
      > 2004-01-01  David Byers  <byers@lysator.liu.se>
      >
      > 	* menus.el (lyskom-define-menu-xemacs): Try to use swedish
      > 	characters rather than brackets and braces for bindings that have
      > 	both.
      > 	(lyskom-define-menu-gnu): Same here.
      >
      > 	* utilities.el (lyskom-traverse-keymap): New function.
      >
      > 	* compatibility.el (map-keymap): More fixes.
      >
      > 	* menus.el (lyskom-menu-guess-shortcuts): New function.
      >
      > 	* vars.el.in (lyskom-swedish-bindings): New variable.
      > 	(lyskom-swedish-bindings-reverse): Ditto.
      >
      > 2003-12-18  David Byers  <byers@lysator.liu.se>
      >
      > 	* compatibility.el (map-keymap): I think this function will work
      > 	in Gnu Emacs now.
      >
      > 	Make language selection more available:
      > 	* swedish-strings.el (lyskom-menus): Language-related texts in
      > 	swedish and english.
      > 	(lyskom-message): Ditto.
      >
      > 	* menus.el (lyskom-menu-template): Added change local and global
      > 	language.
      >
      > 	* commands2.el (kom-change-global-language): New command.
      > 	(kom-change-local-language): New command.
      >
      > 	Commands at when-done in current language:
      > 	* language.el (lyskom-try-get-string): Added language parameter.
      > 	(lyskom-get-string): Added language parameter.
      >
      > 	* command.el (lyskom-command-name): Added language parameter.
      >
      f52621b4
  7. 17 Dec, 2003 1 commit
    • David Byers's avatar
      Updated menus · acd4415d
      David Byers authored
      Detailed changes:
      > 2003-12-17  David Byers  <byers@lysator.liu.se>
      >
      > 	Update menus:
      > 	* utilities.el (lyskom-gensym): New function (it really seems that
      > 	elisp doesn't have a built-in gensym function).
      >
      > 	* menus.el (lyskom-define-menu-gnu): Use gensym to generate
      > 	separator symbols (so we can say just (hline) in the menu spec).
      > 	(lyskom-menu-template): All-new menu definitions.
      >
      acd4415d
  8. 16 Dec, 2003 1 commit
  9. 11 Dec, 2003 1 commit
    • David Byers's avatar
      Fixed bugs 1232, 1233 and 1234 · d5111bf8
      David Byers authored
      Detailed changes:
      > 2003-12-11  David Byers  <byers@lysator.liu.se>
      >
      > 	Fix bug 1233:
      > 	* commands1.el (kom-change-priority): Pass old mship-type to
      > 	lyskom-add-member-answer.
      >
      > 	Fix bug 1234:
      > 	* lyskom-rest.el (lyskom-update-prompt): New prompts for when
      > 	prioritised texts are in the letterbox, or the prioritised
      > 	conference is the letterbox.
      >
      > 	Fix bug 1233:
      > 	* commands1.el (lyskom-list-clients-collect): Deal with version
      > 	set to nil.
      >
      d5111bf8
  10. 10 Dec, 2003 1 commit
    • David Byers's avatar
      Show a help link about changing languages at startup · ace5925a
      David Byers authored
      Detailed changes:
      > 2003-12-10  David Byers  <byers@lysator.liu.se>
      >
      > 	* startup.el (kom-start-anew): Show a help link when setting the
      > 	language.
      >
      > 	* lyskom-rest.el (lyskom-format-aux-help): The argument for a
      > 	conditional format is not optional, so we can handle extending
      > 	format strings with additional boolean conditionals without
      > 	altering the argument lists where they are used.
      >
      1a12,13
      >
      > 	* NEWS-0.48: Updated to here.
      ace5925a
  11. 07 Dec, 2003 1 commit
    • David Byers's avatar
      Added privilege display and manipulation code. · 5f880c3e
      David Byers authored
      Detailed changes:
      > 2003-12-07  David Byers  <byers@lysator.liu.se>
      >
      > 	Handle user privileges:
      > 	* commands2.el (kom-change-privileges): New command.
      > 	 (kom-status-person): Print privileges.
      >
      > 	* komtypes.el (pers-stat): Make privileges read-write.
      >
      > 	* utilities.el (lyskom-privilege-string): New function.
      >
      > 	* vars.el.in (lyskom-default-conference-strategy): Added
      > 	change-conf-type, which was missing, to this list.
      >
      5f880c3e
  12. 05 Dec, 2003 1 commit
    • David Byers's avatar
      Fixed bugs 1229 and 1228. · 652c1d22
      David Byers authored
      Detailed changes:
      > 2003-12-04  David Byers  <byers@lysator.liu.se>
      >
      > 	* lyskom-rest.el (lyskom-read-number): Use lyskom-string-to-int so
      > 	we never create floats by mistake.
      >
      > 	More features for padding and truncating formatted strings:
      > 	* commands1.el (lyskom-print-comment-like-aux): Don't print FAQ
      > 	links if the data in the aux-item is invalid.
      >
      > 	* utilities.el (lyskom-truncate-string-to-width): New simpler
      > 	implementation that only supports the features we use and supports
      > 	the TRAILER argument.
      >
      > 	* lyskom-rest.el (lyskom-format-aux-help): Support < > and = to
      > 	specify stuff in pad-length. Support a ... trailer for truncated
      > 	strings.
      >
      > 	Improve handling of invalid numeric data:
      > 	* aux-items.el (lyskom-status-print-faq-text): Handle invalid data
      > 	in aux item.
      > 	(lyskom-faq-for-conf-action): Use lyskom-string-to-int to convert
      > 	data and throw an error on invalid format.
      > 	(lyskom-aux-item-validate): New function.
      > 	(lyskom-status-print-faq-text): Validate aux-item data before
      > 	printing.
      > 	(lyskom-print-faq-for-conf): Same here.
      > 	(lyskom-print-send-comments-to): Same here.
      > 	(lyskom-print-recommended-conf): Same here.
      >
      > 	* utilities.el (lyskom-string-to-int): New function.
      > 	(lyskom-integer-conversion-error): New error symbol.
      >
      > 	Fix bug 1229:
      > 	* commands2.el (kom-list-new-conferences): The data got from the
      > 	server is a conf-stat, not an uconf-stat. Treat it as such...
      > 	(lyskom-list-new-conferences): Same here.
      >
      652c1d22
  13. 03 Dec, 2003 2 commits
  14. 17 Nov, 2003 3 commits
    • David Byers's avatar
      Fixed bug 1142 (show mark type in message when marking) · 7153ef52
      David Byers authored
      Detailed changes:
      > 	Fix bug 1142:
      > 	* commands1.el (lyskom-mark-text): Print the mark type in the
      > 	marking message.
      >
      > 	* commands2.el (lyskom-symbolic-mark-type-string): Added argument
      > 	STRICT.
      >
      7153ef52
    • David Byers's avatar
      Fixed bugs 1174, 1213 and some problems I spotted on the way. · 50128cff
      David Byers authored
      Detailed changes:
      > 	Minor bug fixes:
      > 	* commands2.el (kom-is-person-member-of-conference): When reading
      > 	pers-to-check-mship-for, only read persons.
      >
      > 	* vars.el.in (lyskom-default-conference-strategy): Fixed typo in
      > 	kom-move-text-tree.
      >
      > 	Fix bug 1174:
      > 	* commands2.el (kom-join-all-conferences): Ask about receiving
      > 	group messages in all conferences.
      >
      > 	* commands1.el (lyskom-add-member-answer): Added mship-type
      > 	parameter.
      > 	(lyskom-add-member-by-no): Added mship-type parameter.
      > 	(kom-create-conf): Added mship-type parameter in call to
      > 	lyskom-add-member-by-no
      >
      > 	Fix bug 1213:
      > 	* commands1.el (lyskom-write-text): Handle argument correctly so
      > 	both prefix arguments and menus work properly.
      > 	(lyskom-add-member-answer): Added mship-type parameter
      >
      50128cff
    • David Byers's avatar
      Fixed bug 1132. Fixed bug 1140 and similar problems. Minor bug fixes. · 1097cc30
      David Byers authored
      Detailed changes:
      > 2003-11-17  David Byers  <byers@lysator.liu.se>
      >
      > 	Fix bug 1132:
      > 	* commands2.el (lyskom-list-new-conferences): Made this function
      > 	asynchronous. Use lyskom-get-conf-stat since there's a good
      > 	chance, shortly after release at any rate, that this command will
      > 	cause an explosion of get-conf-stats anyway (when the client gets
      > 	the conf-stat in order to display the presentation status).
      >
      > 2003-11-14  David Byers  <byers@lysator.liu.se>
      >
      > 	Fix bug 1140:
      > 	* vars.el.in (kom-pick-text-no-strategy-alist): Added items to
      > 	this list corresponding to commands that have non-standard
      > 	defaults, since these were ignored.
      >
      > 	* faqs.el (kom-add-faq): Don't pass DEFAULT to
      > 	lyskom-read-text-no-prefix-arg (the default made little sense
      > 	anyway).
      > 	(kom-add-server-faq): Same here.
      >
      > 	* commands1.el (kom-set-presentation): Don't pass DEFAULT to
      > 	lyskom-read-text-no-prefix-arg (the default made little sense
      > 	anyway).
      > 	(kom-set-motd-text): Same here.
      >
      > 2003-09-21  David Byers  <byers@lysator.liu.se>
      >
      > 	* commands1.el (lyskom-read-mark-type): Improve handling of empty
      > 	string entered as mark type.
      >
      > 2003-09-17  David Byers  <byers@lysator.liu.se>
      >
      > 	* cache.el (lyskom-tell-server): Never, ever, send nil to
      > 	change-what-i-am-doing since this causes a protocol error.
      >
      1097cc30
  15. 26 Oct, 2003 2 commits
  16. 23 Oct, 2003 1 commit
    • Joel Rosdahl's avatar
      Fix bug 1137: · 777abb7b
      Joel Rosdahl authored
      * commands1.el (lyskom-read-mark-type): Handle empty
      input correctly.
      777abb7b
  17. 15 Sep, 2003 1 commit
  18. 30 Aug, 2003 4 commits
  19. 29 Aug, 2003 1 commit
    • David Byers's avatar
      Fixed problem filling messages. · 003d7be3
      David Byers authored
      Detailed changes:
      > 2003-08-29  David Byers  <byers@lysator.liu.se>
      >
      > 	* lyskom-rest.el (lyskom-fill-message): Don't kill the last char.
      >
      003d7be3
  20. 28 Aug, 2003 4 commits
    • Ulrik Haugen's avatar
      * vars.el.in (kom-builtin-server-aliases, kom-server-aliases): Fix · 13fb699b
      Ulrik Haugen authored
      documentation string ((NICKNAME . SERVER) -> (SERVER . NICKNAME)).
      13fb699b
    • David Byers's avatar
      Improve handling when filling very long texts. · cff365e7
      David Byers authored
      Detailed changes:
      > 	Handle breaking very long texts:
      > 	* lyskom-rest.el (lyskom-fill-message): Added option of a timeout
      > 	for filling, replaced whitespace deletion at the end with a method
      > 	that does not rely on regexps (it seems that anchoring a regexp at
      > 	the end of the buffer does not improve performance as much as I
      > 	expected), and caused C-g to break out of the filling loop, but
      > 	not out of the function.
      >
      > 	* vars.el.in (kom-autowrap-timeout): New variable.
      >
      cff365e7
    • David Byers's avatar
      Removed kom-set-keep-commented and put the functionality in kom-set-garb-nice. · 88aacfa7
      David Byers authored
      Detailed changes:
      > 	Fix bug 1117:
      > 	* commands2.el (kom-set-garb-nice): Moved kom-set-keep-commented
      > 	into this function. It makes more sense that way.
      > 	(kom-set-keep-commented): Deleted this command.
      88aacfa7
    • David Byers's avatar
      Fixed bugs 1128 and 1125. · 4d39e9fa
      David Byers authored
      Detailed changes:
      > 2003-08-28  David Byers  <byers@lysator.liu.se>
      >
      > 	Fix bug 1128:
      > 	* commands2.el (kom-limit-import): Support refusing HTML import.
      >
      > 	Fix bug 1125:
      > 	* edit-text.el (lyskom-edit-insert-miscs): Make more of the
      > 	separator line read-only, taking care (I hope) to get text
      > 	properties right so the read-only property does not affect the
      > 	subject line.
      >
      4d39e9fa
  21. 27 Aug, 2003 2 commits
  22. 26 Aug, 2003 1 commit
    • David Byers's avatar
      Fix problem with completing-read in XEmacs. · 1e6e2229
      David Byers authored
      Detailed changes:
      > 2003-08-26  David Byers  <byers@lysator.liu.se>
      >
      > 	* utilities.el (lyskom-magic-minibuffer-mangle-initial):
      > 	Explicitly make properties at the front of the initial value
      > 	nonsticky (mainly for XEmacs where they are sticky by default).
      > 	(completing-read): Add explicity uses for all variables to avoid
      > 	compiler warnings in XEmacs at run time.
      > 	(read-from-minibuffer): Same.
      >
      > 	* commands2.el (kom-send-message): Remoed unused variables.
      >
      1e6e2229