lyskom-elisp-client issueshttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues2020-08-10T06:49:43Zhttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/13Clean up NOCOMPAT comments2020-08-10T06:49:43ZDavid ByersClean up NOCOMPAT commentsComments with `NOCOMPAT` have been added to questionable code that needs reviewing and more thorough testing. Check these towards the end of developing the nocompat branch.Comments with `NOCOMPAT` have been added to questionable code that needs reviewing and more thorough testing. Check these towards the end of developing the nocompat branch.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/12Review the magic minibuffer2020-08-07T18:47:29ZDavid ByersReview the magic minibufferReview all the code that goes in to the magic minibuffer in `utilities.el` starting at:
;;; ============================================================
;;; Magic that allows us to clear the initial value in the
;;; minibuff...Review all the code that goes in to the magic minibuffer in `utilities.el` starting at:
;;; ============================================================
;;; Magic that allows us to clear the initial value in the
;;; minibuffer when the user types a character.
For `nocompat` simplify the advice so it only works in Gnu Emacs. Consider using before-change-functions (mentioned in the comment) instead. There may be an ancient checkin that does this (and that crashed Emacs 20.7).David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/11Replace lyskom-princ2020-08-07T19:36:03ZDavid ByersReplace lyskom-princThe function `lyskom-princ` is used to insert text with text properties at a marker. Replace it with something like this:
(defun lyskom-insert-at (string marker)
(save-excursion (goto-char marker) (insert string)))
The existi...The function `lyskom-princ` is used to insert text with text properties at a marker. Replace it with something like this:
(defun lyskom-insert-at (string marker)
(save-excursion (goto-char marker) (insert string)))
The existing code is far too complex.David ByersDavid Byershttps://git.lysator.liu.se/lyskom-elisp-client/lyskom-elisp-client/-/issues/9Use mailcap to display (some) non-text content2020-08-10T06:53:57ZDavid ByersUse mailcap to display (some) non-text contentThe mailcap library can display content based on MIME type. See e.g. `eww-display-pdf` for an example of how. This could replace custom code to display non-text types.The mailcap library can display content based on MIME type. See e.g. `eww-display-pdf` for an example of how. This could replace custom code to display non-text types.