Commit 187c350e authored by David Byers's avatar David Byers

Synkning inför release av 0.46.2-BETA-1

parent 76c2b3e4
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
# #
# Please mail bug reports to bug-lyskom@lysator.liu.se. # Please mail bug reports to bug-lyskom@lysator.liu.se.
CLIENTVERSION = 0.46.1 CLIENTVERSION = 0.46.2-BETA-1
SHELL = /bin/sh SHELL = /bin/sh
RM = rm -f RM = rm -f
......
...@@ -60,6 +60,16 @@ ...@@ -60,6 +60,16 @@
eller set-buffer-multibyte i din .emacs. eller set-buffer-multibyte i din .emacs.
XEmacs 21.2
-----------
En del användare har rapporterat problem i med elispklienten i
XEmacs 21.2. Om klienten fungerar i XEmacs 21.2 så är det ren tur.
Om den inte fungerar så är det dags att uppgradera till en
tidigare version. När XEmacs 21.2 har börjat stabiliseras så
kommer säkert någon att se till att elispklienten fungerar där.
Kompilering Kompilering
----------- -----------
......
2001-05-21 David Byers <davby@sen2.ida.liu.se>
* Release av 0.46.1-BETA-1
2001-05-21 David Byers <davby@ida.liu.se>
* option-edit.el: Added kom-review-uses-cache.
* view-text.el (lyskom-view-text): Don't prefetch stuff if we are
reviewing and will delete the prefetched stuff anyway.
* lyskom-rest.el (kom-view): Check kom-review-uses-cache.
(kom-view-next-text): Same here.
* edit-text.el (lyskom-edit-show-commented): Check
kom-review-uses-cache.
* commands1.el (lyskom-view-commented-text): Check
kom-review-uses-cache.
* review.el (kom-find-root): Check kom-review-uses-cache.
(kom-review-comments): Same here.
(kom-review-tree): Same here.
(kom-find-root): Same here.
(kom-find-root-review): Same here.
(lyskom-find-root): Same here (two places)
(lyskom-review-comments): Same here.
(kom-review-last-normally-read): Same here.
(kom-review-noconversion): Same here.
* commands1.el (kom-view-commented-text): Check
kom-review-uses-cache.
(kom-view-previous-commented-text): Same here.
* vars.el.in (kom-review-uses-cache): New variable.
2001-05-15 David Byers <davby@ida.liu.se> 2001-05-15 David Byers <davby@ida.liu.se>
* commands1.el (kom-jump): Probably works in tree review mode, at * commands1.el (kom-jump): Probably works in tree review mode, at
......
...@@ -188,6 +188,8 @@ optional arg TEXT-NO is present review the text that text commented instead." ...@@ -188,6 +188,8 @@ optional arg TEXT-NO is present review the text that text commented instead."
(if text-no (if text-no
(progn (progn
(lyskom-tell-internat 'kom-tell-read) (lyskom-tell-internat 'kom-tell-read)
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(lyskom-view-commented-text (lyskom-view-commented-text
(blocking-do 'get-text-stat text-no))) (blocking-do 'get-text-stat text-no)))
(lyskom-insert-string 'confusion-what-to-view))) (lyskom-insert-string 'confusion-what-to-view)))
...@@ -202,6 +204,8 @@ the other ones." ...@@ -202,6 +204,8 @@ the other ones."
lyskom-previous-text))) lyskom-previous-text)))
(cond (text-no (cond (text-no
(lyskom-tell-internat 'kom-tell-read) (lyskom-tell-internat 'kom-tell-read)
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(lyskom-view-commented-text (lyskom-view-commented-text
(blocking-do 'get-text-stat lyskom-previous-text))) (blocking-do 'get-text-stat lyskom-previous-text)))
(t (lyskom-insert-string 'confusion-what-to-view)))) (t (lyskom-insert-string 'confusion-what-to-view))))
...@@ -235,6 +239,8 @@ the other ones." ...@@ -235,6 +239,8 @@ the other ones."
(lyskom-create-text-list (cdr text-nos)) (lyskom-create-text-list (cdr text-nos))
lyskom-current-text) lyskom-current-text)
lyskom-reading-list t)) lyskom-reading-list t))
(unless kom-review-uses-cache
(cache-del-text-stat (car text-nos)))
(lyskom-view-text (car text-nos) (lyskom-view-text (car text-nos)
nil nil nil nil nil nil
nil nil nil nil nil nil
......
...@@ -1763,6 +1763,8 @@ the with-output-to-temp-buffer command is issued to make them both apear." ...@@ -1763,6 +1763,8 @@ the with-output-to-temp-buffer command is issued to make them both apear."
(kom-deferred-printing nil)) (kom-deferred-printing nil))
(save-selected-window (save-selected-window
(lyskom-display-buffer buf) (lyskom-display-buffer buf)
(unless kom-review-uses-cache
(cache-del-text-stat (text->text-no text)))
(save-excursion (set-buffer buf) (save-excursion (set-buffer buf)
(erase-buffer) (erase-buffer)
(lyskom-view-text (text->text-no text)) (lyskom-view-text (text->text-no text))
......
...@@ -3234,7 +3234,12 @@ be saved in the server. Otherwise it will be saved in your .emacs.") ...@@ -3234,7 +3234,12 @@ be saved in the server. Otherwise it will be saved in your .emacs.")
(kom-print-seconds-in-time-strings-doc . "\ (kom-print-seconds-in-time-strings-doc . "\
If this setting is on, some time strings (for example the creation If this setting is on, some time strings (for example the creation
time of texts and sent messages) will include seconds.") time of texts and sent messages) will include seconds.")
(kom-review-uses-cache-doc . "\
If this is turned on, commands that review texts will use saved copies
of the text rather then get new copies from the server. This makes the
commands run significantly faster, but in some cases the texts may
have changed since they were copied, and you will not see those
changes.")
;; ;;
;; Tags for variables ;; Tags for variables
...@@ -3396,6 +3401,7 @@ be saved in the server. Otherwise it will be saved in your .emacs.") ...@@ -3396,6 +3401,7 @@ be saved in the server. Otherwise it will be saved in your .emacs.")
(kom-dont-check-commented-authors-tag . "Authors not to check:") (kom-dont-check-commented-authors-tag . "Authors not to check:")
(kom-print-relative-dates-tag . "Show relative dates:") (kom-print-relative-dates-tag . "Show relative dates:")
(kom-print-seconds-in-time-strings-tag . "Include seconds in time strings:") (kom-print-seconds-in-time-strings-tag . "Include seconds in time strings:")
(kom-review-uses-cache-tag . "Review commands use cached texts:")
) )
) )
......
...@@ -319,6 +319,8 @@ If the optional argument REFETCH is non-nil, all caches are cleared and ...@@ -319,6 +319,8 @@ If the optional argument REFETCH is non-nil, all caches are cleared and
) )
(lyskom-tell-internat 'kom-tell-review) (lyskom-tell-internat 'kom-tell-review)
(lyskom-format-insert 'review-text-no text-no) (lyskom-format-insert 'review-text-no text-no)
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(lyskom-view-text text-no)) (lyskom-view-text text-no))
(t (lyskom-insert 'confusion-what-to-view)))) (t (lyskom-insert 'confusion-what-to-view))))
(lyskom-end-of-command))) (lyskom-end-of-command)))
...@@ -400,7 +402,9 @@ If the optional argument REFETCH is non-nil, all caches are cleared and ...@@ -400,7 +402,9 @@ If the optional argument REFETCH is non-nil, all caches are cleared and
is-review-tree)) is-review-tree))
(mark-as-read (not is-review))) (mark-as-read (not is-review)))
(when is-review (when is-review
(delq text-no (read-info->text-list tri))) ;First entry only (delq text-no (read-info->text-list tri)) ;First entry only
(unless kom-review-uses-cache
(cache-del-text-stat text-no)))
(setq action (setq action
(lyskom-view-text text-no mark-as-read (lyskom-view-text text-no mark-as-read
(and kom-read-depth-first (and kom-read-depth-first
......
...@@ -158,6 +158,7 @@ ...@@ -158,6 +158,7 @@
[kom-follow-attachments] [kom-follow-attachments]
[kom-created-texts-are-read] [kom-created-texts-are-read]
[kom-created-texts-are-saved] [kom-created-texts-are-saved]
[kom-review-uses-cache]
"\n" "\n"
[kom-saved-file-name] [kom-saved-file-name]
[kom-default-mark] [kom-default-mark]
...@@ -492,6 +493,7 @@ customize buffer but do not save them to the server." ...@@ -492,6 +493,7 @@ customize buffer but do not save them to the server."
(kom-enabled-prompt-format-executing (string)) (kom-enabled-prompt-format-executing (string))
(kom-cite-string (string)) (kom-cite-string (string))
(kom-created-texts-are-read (toggle (yes no))) (kom-created-texts-are-read (toggle (yes no)))
(kom-review-uses-cache (toggle (yes no)))
(kom-created-texts-are-saved (choice ((const (no nil)) (kom-created-texts-are-saved (choice ((const (no nil))
(file nil :tag to-file)))) (file nil :tag to-file))))
(kom-default-mark (choice ((number (0 255) (kom-default-mark (choice ((number (0 255)
......
...@@ -978,11 +978,15 @@ instead. In this case the text TEXT-NO is first shown." ...@@ -978,11 +978,15 @@ instead. In this case the text TEXT-NO is first shown."
(interactive (list (lyskom-read-text-no-prefix-arg 'review-tree-q))) (interactive (list (lyskom-read-text-no-prefix-arg 'review-tree-q)))
(lyskom-tell-internat 'kom-tell-review) (lyskom-tell-internat 'kom-tell-review)
(if text-no (if text-no
(let ((ts (blocking-do 'get-text-stat text-no))) (progn
(lyskom-follow-comments ts (unless kom-review-uses-cache
nil 'review (cache-del-text-stat text-no))
(lyskom-review-get-priority)
t)) (let ((ts (blocking-do 'get-text-stat text-no)))
(lyskom-follow-comments ts
nil 'review
(lyskom-review-get-priority)
t)))
(lyskom-insert-string 'read-text-first))) (lyskom-insert-string 'read-text-first)))
...@@ -992,6 +996,8 @@ instead. In this case the text TEXT-NO is first shown." ...@@ -992,6 +996,8 @@ instead. In this case the text TEXT-NO is first shown."
(lyskom-tell-internat 'kom-tell-review) (lyskom-tell-internat 'kom-tell-review)
(cond (cond
(text-no (text-no
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(let* ((ts (blocking-do 'get-text-stat text-no)) (let* ((ts (blocking-do 'get-text-stat text-no))
(r (lyskom-find-root ts t))) (r (lyskom-find-root ts t)))
(cond ((> (length r) 1) (cond ((> (length r) 1)
...@@ -1004,7 +1010,9 @@ instead. In this case the text TEXT-NO is first shown." ...@@ -1004,7 +1010,9 @@ instead. In this case the text TEXT-NO is first shown."
(lyskom-review-get-priority) (lyskom-review-get-priority)
(lyskom-create-text-list r) (lyskom-create-text-list r)
nil t) t)) nil t) t))
(r (lyskom-view-text (car r))) (r (unless kom-review-uses-cache
(cache-del-text-stat (car r)))
(lyskom-view-text (car r)))
(t (signal 'lyskom-internal-error "Could not find root"))) (t (signal 'lyskom-internal-error "Could not find root")))
) )
) )
...@@ -1019,6 +1027,8 @@ reviews the whole tree in deep-first order." ...@@ -1019,6 +1027,8 @@ reviews the whole tree in deep-first order."
(lyskom-tell-internat 'kom-tell-review) (lyskom-tell-internat 'kom-tell-review)
(cond (cond
(text-no (text-no
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(let* ((ts (blocking-do 'get-text-stat text-no)) (let* ((ts (blocking-do 'get-text-stat text-no))
(start (lyskom-find-root ts t))) (start (lyskom-find-root ts t)))
(cond ((> (length start) 1) (cond ((> (length start) 1)
...@@ -1052,12 +1062,16 @@ If ALL is set, return a list of all root texts." ...@@ -1052,12 +1062,16 @@ If ALL is set, return a list of all root texts."
(setq misclist (text-stat->misc-info-list head)) (setq misclist (text-stat->misc-info-list head))
(while misclist (while misclist
(cond ((eq (misc-info->type (car misclist)) 'COMM-TO) (cond ((eq (misc-info->type (car misclist)) 'COMM-TO)
(unless kom-review-uses-cache
(cache-del-text-stat (misc-info->comm-to (car misclist))))
(setq tmp (setq tmp
(cons (cons
(blocking-do 'get-text-stat (blocking-do 'get-text-stat
(misc-info->comm-to (car misclist))) (misc-info->comm-to (car misclist)))
tmp))) tmp)))
((eq (misc-info->type (car misclist)) 'FOOTN-TO) ((eq (misc-info->type (car misclist)) 'FOOTN-TO)
(unless kom-review-uses-cache
(cache-del-text-stat (misc-info->footn-to (car misclist))))
(setq tmp (setq tmp
(cons (cons
(blocking-do 'get-text-stat (blocking-do 'get-text-stat
...@@ -1092,6 +1106,8 @@ Does a lyskom-end-of-command. ...@@ -1092,6 +1106,8 @@ Does a lyskom-end-of-command.
Text is a text-no." Text is a text-no."
(cond (cond
((integerp text) ((integerp text)
(unless kom-review-uses-cache
(cache-del-text-stat text))
(lyskom-view-text text nil t nil (lyskom-review-get-priority) t)) (lyskom-view-text text nil t nil (lyskom-review-get-priority) t))
(t (t
(signal 'lyskom-internal-error (signal 'lyskom-internal-error
...@@ -1197,6 +1213,8 @@ text is shown and a REVIEW list is built to shown the other ones." ...@@ -1197,6 +1213,8 @@ text is shown and a REVIEW list is built to shown the other ones."
(interactive (list (lyskom-read-text-no-prefix-arg 'review-comments-q))) (interactive (list (lyskom-read-text-no-prefix-arg 'review-comments-q)))
(lyskom-tell-internat 'kom-tell-review) (lyskom-tell-internat 'kom-tell-review)
(cond (text-no (cond (text-no
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(lyskom-review-comments (lyskom-review-comments
(blocking-do 'get-text-stat text-no))) (blocking-do 'get-text-stat text-no)))
(t lyskom-insert-string 'read-text-first))) (t lyskom-insert-string 'read-text-first)))
...@@ -1223,6 +1241,8 @@ text is shown and a REVIEW list is built to shown the other ones." ...@@ -1223,6 +1241,8 @@ text is shown and a REVIEW list is built to shown the other ones."
text-nos) text-nos)
;; Only try to review texts that we can read. ;; Only try to review texts that we can read.
(while all-text-nos (while all-text-nos
(unless kom-review-uses-cache
(cache-del-text-stat (car all-text-nos)))
(if (blocking-do 'get-text-stat (car all-text-nos)) (if (blocking-do 'get-text-stat (car all-text-nos))
(setq text-nos (cons (car all-text-nos) text-nos))) (setq text-nos (cons (car all-text-nos) text-nos)))
(setq all-text-nos (cdr all-text-nos))) (setq all-text-nos (cdr all-text-nos)))
...@@ -1237,6 +1257,9 @@ text is shown and a REVIEW list is built to shown the other ones." ...@@ -1237,6 +1257,9 @@ text is shown and a REVIEW list is built to shown the other ones."
'REVIEW nil (lyskom-review-get-priority) 'REVIEW nil (lyskom-review-get-priority)
(lyskom-create-text-list (cdr text-nos)) (lyskom-create-text-list (cdr text-nos))
lyskom-current-text) t)) lyskom-current-text) t))
;; Don't check the no-cache thing here since we already
;; did earlier. We may end up slightly out of sync with
;; the server, but not so anyone will really notice.
(lyskom-view-text (car text-nos))) (lyskom-view-text (car text-nos)))
(lyskom-insert-string 'no-such-text)))) (lyskom-insert-string 'no-such-text))))
...@@ -1263,6 +1286,8 @@ text is shown and a REVIEW list is built to shown the other ones." ...@@ -1263,6 +1286,8 @@ text is shown and a REVIEW list is built to shown the other ones."
'REVIEW nil (lyskom-review-get-priority) 'REVIEW nil (lyskom-review-get-priority)
(lyskom-create-text-list (cdr text-nos)) (lyskom-create-text-list (cdr text-nos))
lyskom-current-text) t)) lyskom-current-text) t))
(unless kom-review-uses-cache
(cache-del-text-stat (car text-nos)))
(lyskom-view-text (car text-nos))) (lyskom-view-text (car text-nos)))
(lyskom-format-insert 'no-such-text)))) (lyskom-format-insert 'no-such-text))))
...@@ -1280,6 +1305,8 @@ text is shown and a REVIEW list is built to shown the other ones." ...@@ -1280,6 +1305,8 @@ text is shown and a REVIEW list is built to shown the other ones."
(let ((lyskom-format-special nil) (let ((lyskom-format-special nil)
(kom-smileys nil) (kom-smileys nil)
(kom-autowrap nil)) (kom-autowrap nil))
(unless kom-review-uses-cache
(cache-del-text-stat text-no))
(lyskom-view-text text-no)) (lyskom-view-text text-no))
(lyskom-insert 'confusion-what-to-view))) (lyskom-insert 'confusion-what-to-view)))
......
...@@ -3670,6 +3670,11 @@ i servern. Annars sparas det i din .emacs.") ...@@ -3670,6 +3670,11 @@ i servern. Annars sparas det i din .emacs.")
Om denna instllning r pslagen kommer en del tidsangivelser (till Om denna instllning r pslagen kommer en del tidsangivelser (till
exempel fr visade inlgg och snda meddelanden) att inkludera exempel fr visade inlgg och snda meddelanden) att inkludera
sekunder.") sekunder.")
(kom-review-uses-cache-doc . "\
Om detta r pslaget s kommer kommandon som terser inlgg att
anvnda sparade kopior av inlggen om de finns. Det gr att kommandona
gr lite snabbare, men det finns en viss risk fr att ett inlgg kan
ha ndrats sedan kopian sparades.")
;; ;;
...@@ -3832,6 +3837,7 @@ i servern. Annars sparas det i din .emacs.") ...@@ -3832,6 +3837,7 @@ i servern. Annars sparas det i din .emacs.")
(kom-dont-check-commented-authors-tag . "Frfattare som inte kontrolleras:") (kom-dont-check-commented-authors-tag . "Frfattare som inte kontrolleras:")
(kom-print-relative-dates-tag . "Visa relativa datumangivelser:") (kom-print-relative-dates-tag . "Visa relativa datumangivelser:")
(kom-print-seconds-in-time-strings-tag . "Inkludera sekunder i tidsangivelser:") (kom-print-seconds-in-time-strings-tag . "Inkludera sekunder i tidsangivelser:")
(kom-review-uses-cache-tag . "tersekommandon anvnder sparade inlgg:")
) )
) )
......
...@@ -218,6 +218,11 @@ The value of this variable is the file name on which to save new texts." ...@@ -218,6 +218,11 @@ The value of this variable is the file name on which to save new texts."
server server
inherited) inherited)
(def-kom-var kom-review-uses-cache t
"*If non-nil, review commands don't use the cache."
server
inherited)
(def-kom-var kom-postpone-default 17 (def-kom-var kom-postpone-default 17
"*The number of articles to postpone by default." "*The number of articles to postpone by default."
server) server)
......
...@@ -377,7 +377,9 @@ Note that this function must not be called asynchronously." ...@@ -377,7 +377,9 @@ Note that this function must not be called asynchronously."
(progn (progn
;; this is a bit silly, as it prefetches all ;; this is a bit silly, as it prefetches all
;; the texts many times. ;; the texts many times.
(lyskom-prefetch-texttree text-no) (unless (and build-review-tree
kom-review-uses-cache)
(lyskom-prefetch-texttree text-no))
(lyskom-follow-comments text-stat (lyskom-follow-comments text-stat
conf-stat mark-as-read conf-stat mark-as-read
priority build-review-tree))) priority build-review-tree)))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment