diff --git a/ChangeLog b/ChangeLog index cbe00c35a98777f3bf4abcfb2b2cb50806b01281..e900fb0296dcd627ebacbc75d32883b45d94821b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2020-04-23 Niels Möller <nisse@lysator.liu.se> + + * testsuite/ecc-add-test.c (test_main): Delete ASSERTs with + functions pointer comparisons. They provide little value, and fail + when linking with hogweed.dll on windows. + * testsuite/ecc-dup-test.c (test_main): Likewise. + 2020-04-22 Niels Möller <nisse@lysator.liu.se> * testsuite/Makefile.in: Use pattern rules for test executables, diff --git a/testsuite/ecc-add-test.c b/testsuite/ecc-add-test.c index 3e14b30ea216b8a34fa467d2ee624773d7af5ef3..d3b0bd92f4356c48e72dd8e2360f5a913a041028 100644 --- a/testsuite/ecc-add-test.c +++ b/testsuite/ecc-add-test.c @@ -23,10 +23,6 @@ test_main (void) { mp_limb_t *z = xalloc_limbs (ecc_size_j (ecc)); - ASSERT ((ecc->p.bit_size == 255 && ecc->add_hh == ecc_add_th) - || (ecc->p.bit_size == 448 && ecc->add_hh == ecc_add_eh)); - ASSERT ((ecc->p.bit_size == 255 && ecc->add_hhh == ecc_add_thh) - || (ecc->p.bit_size == 448 && ecc->add_hhh == ecc_add_ehh)); ASSERT (ecc->add_hh_itch <= ecc->add_hhh_itch); /* Zero point has x = 0, y = 1, z = 1 */ @@ -53,11 +49,6 @@ test_main (void) free (z); } - else - { - ASSERT (ecc->add_hhh == ecc_add_jjj); - ASSERT (ecc->dup == ecc_dup_jj); - } ecc->dup (ecc, g2, g, scratch); test_ecc_mul_h (i, 2, g2); diff --git a/testsuite/ecc-dup-test.c b/testsuite/ecc-dup-test.c index 500826acecd9131c15024452de62242ba49eeaf6..c7fefdb799c09fab290247d78f1ba09bf41be526 100644 --- a/testsuite/ecc-dup-test.c +++ b/testsuite/ecc-dup-test.c @@ -18,9 +18,6 @@ test_main (void) { mp_limb_t *z = xalloc_limbs (ecc_size_j (ecc)); - ASSERT ((ecc->p.bit_size == 255 && ecc->dup == ecc_dup_th) - || (ecc->p.bit_size == 448 && ecc->dup == ecc_dup_eh)); - /* Zero point has x = 0, y = 1, z = 1 */ mpn_zero (z, 3*ecc->p.size); z[ecc->p.size] = z[2*ecc->p.size] = 1; @@ -30,8 +27,6 @@ test_main (void) free (z); } - else - ASSERT (ecc->dup == ecc_dup_jj); ecc->dup (ecc, p, g, scratch); test_ecc_mul_h (i, 2, p);