From 1de8a9f71e021350bb858729794e65cf8002a9b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20Grubbstr=C3=B6m=20=28Grubba=29?=
<grubba@grubba.org>
Date: Mon, 29 Oct 2018 12:03:33 +0100
Subject: [PATCH] Thread.Queue [Paranoia]: Broadcast the changed state.
This is intended to ensure that the state-changed signal
is not lost.
Consider the case when there is a thread that listens on the
condition, but does not act on it; it could starve the threads
that do intend to act on it.
Fixes [PIKE-140].
---
lib/modules/Thread.pmod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/modules/Thread.pmod b/lib/modules/Thread.pmod
index 6e84496fc5..35867454a6 100644
--- a/lib/modules/Thread.pmod
+++ b/lib/modules/Thread.pmod
@@ -378,7 +378,7 @@ optional class Queue {
buffer[w_ptr] = value;
w_ptr++;
int items = w_ptr - r_ptr;
- r_cond::signal();
+ r_cond::broadcast();
key=0;
return items;
}
--
GitLab