From a38bf772e46c02ea7ffb91a7074b1217023ae5c0 Mon Sep 17 00:00:00 2001
From: Martin Jonsson <marty@roxen.com>
Date: Fri, 28 Jun 2013 21:11:57 +0200
Subject: [PATCH] SNMP: Fixed error in GetRequest variable bindings.

The variable value should be ASN1 "Null" rather than a bogus integer.
C.f. RFC 1905 section #3.
---
 lib/modules/Protocols.pmod/SNMP.pmod/protocol.pike | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/modules/Protocols.pmod/SNMP.pmod/protocol.pike b/lib/modules/Protocols.pmod/SNMP.pmod/protocol.pike
index 92b15bbdbb..dd15e5de61 100644
--- a/lib/modules/Protocols.pmod/SNMP.pmod/protocol.pike
+++ b/lib/modules/Protocols.pmod/SNMP.pmod/protocol.pike
@@ -370,7 +370,7 @@ int get_request(array(string) varlist, string|void rem_addr,
     vararr += ({Standards.ASN1.Types.asn1_sequence(
 	      ({Standards.ASN1.Types.asn1_identifier(
 		@(array(int))(varname/".")),
-		Standards.ASN1.Types.asn1_integer(1)}) //doesn't sense but req
+		Standards.ASN1.Types.Null()})
 	      )});
 
   pdu = Protocols.LDAP.ldap_privates.asn1_context_sequence(0,
@@ -524,7 +524,7 @@ int get_nextrequest(array(string) varlist, string|void rem_addr,
     vararr += ({Standards.ASN1.Types.asn1_sequence(
 	      ({Standards.ASN1.Types.asn1_identifier(
 		 @(array(int))(varname/".")),
-		Standards.ASN1.Types.asn1_integer(1)}) //doesn't sense but req
+		Standards.ASN1.Types.Null()})
 	      )});
 
   pdu = Protocols.LDAP.ldap_privates.asn1_context_sequence(1,
-- 
GitLab