From ecf1279bd769f9e012fc1ce4b07f345a02e9ca8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Grubbstr=C3=B6m=20=28Grubba=29?= <grubba@grubba.org> Date: Thu, 25 Feb 2016 16:35:58 +0100 Subject: [PATCH] Image.Colortable: Use explicit casts. Use explicit casts from unsigned char to int to avoid warnings about space factor overflows. Fixes [CID 742699], [CID 742700] and [CID 742701]. --- src/modules/Image/colortable.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/modules/Image/colortable.c b/src/modules/Image/colortable.c index 2951c104da..59c4d3e937 100644 --- a/src/modules/Image/colortable.c +++ b/src/modules/Image/colortable.c @@ -463,8 +463,9 @@ static ptrdiff_t reduce_recurse(struct nct_flat_entry *src, diff.r += (sq(src[i].color.r-(INT32)sum.r)/8)*mul; diff.g += (sq(src[i].color.g-(INT32)sum.g)/8)*mul; diff.b += (sq(src[i].color.b-(INT32)sum.b)/8)*mul; - gdiff += (sq(src[i].color.r*sf.r+src[i].color.g*sf.g+ - src[i].color.b*sf.b-g)/8)*mul; + gdiff += (sq(((INT32)src[i].color.r)*sf.r+ + ((INT32)src[i].color.g)*sf.g+ + ((INT32)src[i].color.b)*sf.b-g)/8)*mul; tot+=mul; } -- GitLab