From faa4cde106b7c811890982f7484e3552232db42a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20Grubbstr=C3=B6m=20=28Grubba=29?=
<grubba@grubba.org>
Date: Mon, 26 Jul 1999 00:22:51 +0200
Subject: [PATCH] Added some notes from DMALLOC.
Rev: src/modules/_Image_TIFF/image_tiff.c:1.10
---
src/modules/_Image_TIFF/image_tiff.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/modules/_Image_TIFF/image_tiff.c b/src/modules/_Image_TIFF/image_tiff.c
index 03bedba602..227ea22b55 100644
--- a/src/modules/_Image_TIFF/image_tiff.c
+++ b/src/modules/_Image_TIFF/image_tiff.c
@@ -13,7 +13,7 @@
#ifdef HAVE_LIBTIFF
-RCSID("$Id: image_tiff.c,v 1.9 1999/05/26 17:06:48 grubba Exp $");
+RCSID("$Id: image_tiff.c,v 1.10 1999/07/25 22:22:51 grubba Exp $");
#include "global.h"
#include "machine.h"
@@ -86,6 +86,12 @@ static void increase_buffer_size( struct buffer * buffer )
if(buffer->len > 1024*1024*400)
error("Too large buffer (temprary error..)\n");
if(!buffer->len) buffer->len = INITIAL_WRITE_BUFFER_SIZE;
+
+ /* FIXME: According to DMALLOC this leaks.
+ *
+ * NOTE: buffer->str seems to point into Pike strings sometimes,
+ * in which case realloc() is wrong.
+ */
new_d = realloc( buffer->str, buffer->len*2 );
if(!new_d) error("Realloc (%d->%d) failed!\n", buffer->len,buffer->len*2);
MEMSET(new_d+buffer->len, 0, buffer->len);
--
GitLab