pike issueshttps://git.lysator.liu.se/pikelang/pike/-/issues2019-04-15T09:57:13Zhttps://git.lysator.liu.se/pikelang/pike/-/issues/8181Add more info in the Promise broken error.2019-04-15T09:57:13ZPeter BortasAdd more info in the Promise broken error.Imported from https://youtrack.roxen.com/issue/PIKE-181
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-181
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8180Former Merge to 8.0 and master task of PIKE-177 (#8177). See it for details.2019-04-10T09:47:44ZPeter BortasFormer Merge to 8.0 and master task of PIKE-177 (#8177). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-180
Reported by Roxen Scrum Team <roxenscrumteam@roxen.com>
Blocking [PIKE-177](#8177)Imported from https://youtrack.roxen.com/issue/PIKE-180
Reported by Roxen Scrum Team <roxenscrumteam@roxen.com>
Blocking [PIKE-177](#8177)https://git.lysator.liu.se/pikelang/pike/-/issues/8179Former QA task of PIKE-177 (#8177). See it for details.2019-04-12T08:19:00ZPeter BortasFormer QA task of PIKE-177 (#8177). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-179
Reported by Roxen Scrum Team <roxenscrumteam@roxen.com>
Blocking [PIKE-177](#8177)Imported from https://youtrack.roxen.com/issue/PIKE-179
Reported by Roxen Scrum Team <roxenscrumteam@roxen.com>
Blocking [PIKE-177](#8177)https://git.lysator.liu.se/pikelang/pike/-/issues/8178Former Fix task of PIKE-177 (#8177). See it for details.2019-04-10T09:46:33ZPeter BortasFormer Fix task of PIKE-177 (#8177). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-178
Reported by Roxen Scrum Team <roxenscrumteam@roxen.com>
Blocking [PIKE-177](#8177)Imported from https://youtrack.roxen.com/issue/PIKE-178
Reported by Roxen Scrum Team <roxenscrumteam@roxen.com>
Blocking [PIKE-177](#8177)https://git.lysator.liu.se/pikelang/pike/-/issues/8177Concurrent.Future->try_success() causes logging when promise already fulfilled2020-03-05T17:52:35ZPeter BortasConcurrent.Future->try_success() causes logging when promise already fulfilledImported from https://youtrack.roxen.com/issue/PIKE-177
Reported by KG Sterneberg <kg@roxen.com>
While testing some new archive code I got
`
10:33:26 : Internal server error: Promise has already been finalised.
/usr/local/p...Imported from https://youtrack.roxen.com/issue/PIKE-177
Reported by KG Sterneberg <kg@roxen.com>
While testing some new archive code I got
`
10:33:26 : Internal server error: Promise has already been finalised.
/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod (f581060e):903: Concurrent->Promise(/* Concurrent->Promise(/* REP.Archive.StoryArchiver()->ArcDataField()->prepare_file("pv_web") */)->promise_factory() */)->finalise(1,,,2)
/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod:926: Concurrent->Promise(/* Concurrent->Promise(/* REP.Archive.StoryArchiver()->ArcDataField()->prepare_file("pv_web") */)->promise_factory() */)->success(,,,1)
base_server/roxen.pike:763: roxen()->handler_thread(14)
`
I wrote a separate test running not in Roxen and I still got logging when `try_success()` was called:
`
int main(int argc, array(string) argv)
{
Concurrent.Promise promise = Concurrent.Promise();
Thread.Thread(
lambda(Concurrent.Promise promise) {
sleep(3);
werror("Success!\n");
promise->try_success("hej hopp");
}, promise);
Concurrent.Future future = promise->future()->timeout(1);
future = future->recover_with(lambda(mixed value) {
return Concurrent.resolve( ([ "failure" : value ]) );
});
future->on_success(lambda(mixed result) {
werror("TRACE: got result: %O\n", result);
});
return -1;
// return 0;
}
`
*Output:*
`
>./tmp.pike
TRACE: got result: ([ /* 1 element */
"failure": ({ /* 2 elements */
"Timeout.\n",
({ /* 3 elements */
backtrace_frame(/usr/local/pike/8.0.787/lib/master.pike:3634, _main(), Args: 1),
backtrace_frame(/Users/kg/dev/learning/pike/tmp.pike:21, main(), Args: 2),
backtrace_frame(/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod:677, timeout(), Args: 1)
})
})
])
Success!
Promise has already been finalised.
/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod:903:
Concurrent.Promise(rejection_reported,({ /* 2 elements */
"Timeout.\n",
({ /* 3 elements */
backtrace_frame(/usr/local/pike/8.0.787/lib/master.pike:3634, _main(), Args: 1),
backtrace_frame(/Users/kg/dev/learning/pike/tmp.pike:21, main(), Args: 2),
backtrace_frame(/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod:677, timeout(), Args: 1)
})
}))->finalise(1,"hej hopp",UNDEFINED,UNDEFINED)
/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod:926:
Concurrent.Promise(rejection_reported,({ /* 2 elements */
"Timeout.\n",
({ /* 3 elements */
backtrace_frame(/usr/local/pike/8.0.787/lib/master.pike:3634, _main(), Args: 1),
backtrace_frame(/Users/kg/dev/learning/pike/tmp.pike:21, main(), Args: 2),
backtrace_frame(/usr/local/pike/8.0.787/lib/modules/Concurrent.pmod:677, timeout(), Args: 1)
})
}))->success("hej hopp",UNDEFINED)
-:1: Pike.Backend(0)->`()(3600.0)
`
*Pike version*
`Pike v8.0 release 787 running Hilfe v3.5 (Incremental Pike Frontend)`https://git.lysator.liu.se/pikelang/pike/-/issues/8176Former Backport to Pike 8.0. task of PIKE-174 (#8174). See it for details.2019-04-05T09:18:16ZPeter BortasFormer Backport to Pike 8.0. task of PIKE-174 (#8174). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-176
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-176
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8175Former QA task of PIKE-174 (#8174). See it for details.2019-04-02T08:37:57ZPeter BortasFormer QA task of PIKE-174 (#8174). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-175
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-175
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8174Fix expert system in Calendar module.2020-03-05T17:51:48ZPeter BortasFix expert system in Calendar module.Imported from https://youtrack.roxen.com/issue/PIKE-174
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-174
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8173Bad assignment in Protocols.HTTP.Server.Request2019-03-06T10:05:51ZPeter BortasBad assignment in Protocols.HTTP.Server.RequestImported from https://youtrack.roxen.com/issue/PIKE-173
Reported by @grubba
`low_make_response_header()` attempts to assign a non-existent variable `error` in a `Stdio.Buffer` object.Imported from https://youtrack.roxen.com/issue/PIKE-173
Reported by @grubba
`low_make_response_header()` attempts to assign a non-existent variable `error` in a `Stdio.Buffer` object.https://git.lysator.liu.se/pikelang/pike/-/issues/8172Former Merge task of PIKE-169 (#8169). See it for details.2019-03-11T10:27:59ZPeter BortasFormer Merge task of PIKE-169 (#8169). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-172
Reported by @grubba
Blocking [PIKE-169](#8169)Imported from https://youtrack.roxen.com/issue/PIKE-172
Reported by @grubba
Blocking [PIKE-169](#8169)https://git.lysator.liu.se/pikelang/pike/-/issues/8171Former QA task of PIKE-169 (#8169). See it for details.2019-03-11T08:28:05ZPeter BortasFormer QA task of PIKE-169 (#8169). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-171
Reported by @grubba
Blocking [PIKE-169](#8169)Imported from https://youtrack.roxen.com/issue/PIKE-171
Reported by @grubba
Blocking [PIKE-169](#8169)https://git.lysator.liu.se/pikelang/pike/-/issues/8170Former Fix task of PIKE-169 (#8169). See it for details.2020-03-06T10:52:35ZPeter BortasFormer Fix task of PIKE-169 (#8169). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-170
Reported by @grubba
Blocking [PIKE-169](#8169)Imported from https://youtrack.roxen.com/issue/PIKE-170
Reported by @grubba
Blocking [PIKE-169](#8169)https://git.lysator.liu.se/pikelang/pike/-/issues/8168Former Investigate task of PIKE-169 (#8169). See it for details.2020-03-06T10:53:04ZPeter BortasFormer Investigate task of PIKE-169 (#8169). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-168
Reported by @grubba
Blocking [PIKE-169](#8169)Imported from https://youtrack.roxen.com/issue/PIKE-168
Reported by @grubba
Blocking [PIKE-169](#8169)https://git.lysator.liu.se/pikelang/pike/-/issues/8167Former QA Concurrent.Promise failure handling. task of PIKE-166 (#8166). See ...2019-02-28T12:07:48ZPeter BortasFormer QA Concurrent.Promise failure handling. task of PIKE-166 (#8166). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-167
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-167
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8166Global on_failure callback is called too early.2020-03-05T17:49:36ZPeter BortasGlobal on_failure callback is called too early.Imported from https://youtrack.roxen.com/issue/PIKE-166
Reported by @grubba
The callback installed via `Concurrent.on_failure()` may get called before the user has had a chance at installing custom failure callbacks.
Defer the call un...Imported from https://youtrack.roxen.com/issue/PIKE-166
Reported by @grubba
The callback installed via `Concurrent.on_failure()` may get called before the user has had a chance at installing custom failure callbacks.
Defer the call until the `Promise` is destructed.https://git.lysator.liu.se/pikelang/pike/-/issues/8165Former Merge [PIKE-163] to Pike 8.0. task of PIKE-163 (#8163). See it for det...2019-02-18T13:28:59ZPeter BortasFormer Merge [PIKE-163] to Pike 8.0. task of PIKE-163 (#8163). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-165
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-165
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8164Former QA [PIKE-163] task of PIKE-163 (#8163). See it for details.2019-02-18T13:26:26ZPeter BortasFormer QA [PIKE-163] task of PIKE-163 (#8163). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-164
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-164
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8163Propagate backend setting for Promises.2020-03-05T17:48:47ZPeter BortasPropagate backend setting for Promises.Imported from https://youtrack.roxen.com/issue/PIKE-163
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-163
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8162Former Merge [PIKE-160] to Pike 8.0 task of PIKE-160 (#8160). See it for deta...2019-02-15T14:26:57ZPeter BortasFormer Merge [PIKE-160] to Pike 8.0 task of PIKE-160 (#8160). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-162
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-162
Reported by @grubbahttps://git.lysator.liu.se/pikelang/pike/-/issues/8161Former QA [PIKE-160] task of PIKE-160 (#8160). See it for details.2019-02-15T14:06:16ZPeter BortasFormer QA [PIKE-160] task of PIKE-160 (#8160). See it for details.Imported from https://youtrack.roxen.com/issue/PIKE-161
Reported by @grubbaImported from https://youtrack.roxen.com/issue/PIKE-161
Reported by @grubba