Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pike pike
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pikelang
  • pikepike
  • Issues
  • #10055
Closed
Open
Issue created Oct 26, 2020 by Henrik (Grubba) Grubbström@grubbaMaintainer

Race-condition in Concurrent.Promise()->finalise()

Callbacks may get lost due to a race condition.


sequenceDiagram

  participant T1 as Thread 1
  participant P as Promise
  participant T2 as Thread 2

  T2->>P: success()
  Note right of P: success_cbs read.

  T1->>P: on_success()
  activate P
  Note right of P: success_cbs updated.

  P->>T1: returns
  deactivate P

  T2->>P: success() calls finalise()
  activate P
  Note right of P: Old success_cbs called.
  Note right of P: success_cbs cleared.

  P->>T2: returns
  deactivate P
  Note right of P: The callback installed by Thread 1 has been lost.
Assignee
Assign to
Time tracking