Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
pike
pike
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 106
    • Issues 106
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pikelang
  • pikepike
  • Issues
  • #7216

Closed
Open
Opened Jul 15, 2014 by Peter Bortas@zinoOwner

Optimizer broken for some cases of foreach.

Imported from http://bugzilla.roxen.com/bugzilla/show_bug.cgi?id=7216

Reported by @grubba

From LysLysKOM 20892964:

20892964 igår 19:14 /35 rader/ Per Hedbor () Mottagare: Henrik Grubbström (Lysator) <12718> Mottagare: Per Hedbor () <9371> Mottagare: Martin Nilsson (Opera Mini - AFK!) <15149> Ärende: foreach() optimering

Det finns en optimering av foreach som har ett aningens trasigt fall:

foreach( arr[START..], ... ):

Om start är icke-konstant och evaulerar till ett negativt tal får man ett fel.

Det hela förklarar (eller, ja....) den aningens udda kollen för om loop-variabeln är negativ i gamla 7.8 versioner.

Med nyare pikear så får man lite random-data som svalue istället:

# leopard$ pike ~/bug.pike
Failed to use <Unknown 16384>
/home/per/bug.pike:21: /main()->_bug(4)
/home/per/bug.pike:29: /main()->main()

# leopard$ pike7.8 ~/bug.pike
Foreach loop variable is negative!
/home/per/bug.pike:17: /main()->_bug(3)
/home/per/bug.pike:29: /main()->main()

Testfall:

array sorted_configs = ({});
string backups_dir = "/tmp";

void main()
{
    foreach (column (sorted_configs, 0)[random(0) - 1..], string entry)
        if( catch( combine_path (backups_dir, entry) )  )
           error("Failed to use %O\n", entry );
}
(20892964) /Per Hedbor ()/--------------------------
Assignee
Assign to
Pike 8.0
Milestone
Pike 8.0
Assign milestone
Time tracking
None
Due date
None
Reference: pikelang/pike#7216