diff --git a/ChangeLog b/ChangeLog index 1a24b79fc8c5a1a3ba91da010cac2fb2923d15e2..3f51fa45ef5a0d214dcc61b724da0b9466d7bec2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2018-11-25 Niels Möller <nisse@lysator.liu.se> + * rsa-sec-compute-root.c (_rsa_sec_compute_root): Avoid calls to + mpz_sizeinbase, since that potentially leaks most significant bits + of private key parameters a and b. + * testsuite/pkcs1-sec-decrypt-test.c (pkcs1_decrypt_for_test): Fix valgrind marking of return value. diff --git a/rsa-sec-compute-root.c b/rsa-sec-compute-root.c index 580d39acf482a35c8393a0a59d8a7c3c36932074..8383c9116e6ac56fe8d2745072d53597b58d3611 100644 --- a/rsa-sec-compute-root.c +++ b/rsa-sec-compute-root.c @@ -60,9 +60,9 @@ _rsa_sec_compute_root_itch (const struct rsa_private_key *key) itch = MAX (itch, i2); i2 = mpn_sec_div_r_itch (nn, pn); itch = MAX (itch, i2); - i2 = mpn_sec_powm_itch (qn, mpz_sizeinbase (key->b, 2), qn); + i2 = mpn_sec_powm_itch (qn, mpz_size (key->b) * GMP_NUMB_BITS, qn); itch = MAX (itch, i2); - i2 = mpn_sec_powm_itch (pn, mpz_sizeinbase (key->a, 2), pn); + i2 = mpn_sec_powm_itch (pn, mpz_size (key->a) * GMP_NUMB_BITS, pn); itch = MAX (itch, i2); i2 = mpn_sec_div_r_itch (qn, pn); itch = MAX (itch, i2); @@ -111,13 +111,13 @@ _rsa_sec_compute_root (const struct rsa_private_key *key, mpn_copyi (scratch, mp, nn); mpn_sec_div_r (scratch, nn, qp, qn, sp); mpn_sec_powm (r_mod_q, scratch, qn, mpz_limbs_read (key->b), - mpz_sizeinbase (key->b, 2), qp, qn, sp); + mpz_size (key->b) * GMP_NUMB_BITS, qp, qn, sp); /* Compute r_mod_p = m^d % p = (m%p)^a % p */ mpn_copyi (scratch, mp, nn); mpn_sec_div_r (scratch, nn, pp, pn, sp); mpn_sec_powm (r_mod_p, scratch, pn, mpz_limbs_read (key->a), - mpz_sizeinbase (key->a, 2), pp, pn, sp); + mpz_size (key->a) * GMP_NUMB_BITS, pp, pn, sp); /* Set r_mod_p' = r_mod_p * c % p - r_mod_q * c % p . */ mpn_sec_mul (scratch, r_mod_p, pn, mpz_limbs_read (key->c), cn, sp);