Fix the visibility of bcc-recipients, so that the same rules are used

everywhere.  Tighten the rules so that secret info cannot leak through
get-text-stat.  Re-indent text.c.  Add a few const qualifiers all over
the code.

ChangeLog

+2000-09-03  Per Cederqvist  <ceder@moria>
+
+	Typo fixed.
+	* doc/Protocol-A.texi (Protocol Requests): Typo in menu fixed.
+
+	Fix the visibility of bcc-recipients, so that the same rules are
+	used everywhere.  Tighten the rules so that secret info cannot
+	leak through get-text-stat.
+	* src/server/testsuite/lyskomd.0/gen-15.py (text_stat): New
+	class.  Rewrite the rest of this file to use it.  Give authors
+	special privileges regarding bcc-recpts.
+	* src/server/testsuite/lyskomd.0/10.exp: Removed an obsolete
+	comment, since this test no longe fails.
+	* src/server/testsuite/config/unix.exp (lyskomd_start): The tests
+	now require more than 2000 texts.  Give them 20000.
+	* src/server/text.c (send_async_sub_recipient): Use
+	filter_secret_info() so that the exact same visibility is used by
+	async-sub-recipient and get-text-stat.
+	(filter_secret_info): Don't allow the author of a text to see
+	bcc-recpt which are secret to him.  Simplify the code slightly.
+	(send_async_add_recipient): Use filter_secret_info() so that the
+	exact same visibility is used by async-add-recipient and
+	get-text-stat.
+
+2000-09-02  Per Cederqvist  <ceder@moria>
+
+	Re-indent text.c.  Add a few const qualifiers.
+	* src/server/text.c: Code re-indented.
+	(count_recipients): const qualifiers added
+	to some arguments.  Code simplified.
+	(count_footn): Likewise.
+	(count_comment): Likewise.
+	(text_read_access): Code clarified.
+	(delete_text): Likewise.
+	(find_recipient): qualifiers added to some arguments.  
+	(is_comment_to): Likewise.
+	(is_footnote_to): Likewise.
+	(submit_to): Likewise.
+	(is_member_in_recpt): Likewise.
+	(send_async_sub_recipient): Likewise.
+	(sender): Likewise.
+	(is_sender): Likewise.
+	(is_comm_sender): Likewise.
+	(check_footn): Likewise.
+	(check_comm): Likewise.
+	(locate_mark): Likewise.
+	(skip_recp): Likewise.
+	(recp_sent_by): Likewise.
+	(filter_secret_info): Likewise.
+	(send_async_deleted_text): Likewise.
+	(check_double_subm): Likewise.
+	(check_double_comm): Likewise.
+	(send_async_new_text_old): Likewise.
+	(send_async_new_text): Likewise.
+	(send_async_add_recipient): Likewise.
+	* src/server/membership.c (access_perm_helper): const qualifiers added
+	to some arguments.
+	(access_perm): Likewise.
+	(locate_membership): Likewise.
+	* src/server/dbck.c (locate_membership): const qualifiers added
+	to some arguments.
+	* src/server/conference.c (is_supervisor): const qualifiers added
+	to some arguments.
+	(is_strictly_supervisor): Likewise.
+	* src/server/manipulate.h: (access_perm): const qualifiers added
+	to some arguments.
+	(is_supervisor): Likewise.
+	(is_strictly_supervisor): Likewise.
+	(locate_membership): Likewise.
+	* src/server/aux-items.c: Lots of const qualifiers added.
+	* src/server/aux-items.h (Aux_item_validation_data): const
+	qualifiers added to the item and def members.
+	(aux_inherit_items): const qualifiers added to some arguments.
+	(aux_item_add_perm): Likewise.
+	(prepare_aux_item): Likewise.
+	(find_aux_item_definition): Likewise.
+	(aux_item_find_trigger): Likewise.
+	(aux_item_find_validator): Likewise.
+	(find_aux_item): Likewise.
+	(filter_aux_item_list): Likewise.
+	(delete_aux_item_list): Likewise.
+	(undelete_aux_item_list): Likewise.
+	(check_delete_aux_item_list): Likewise.
+
+	Test suite cleanup.
+	* src/server/testsuite/lyskomd.0/16.exp (assert_0): New proc.  Use
+	it to simplify the code.
+
 2000-08-28  Per Cederqvist  <ceder@moria>
 
 	Secret conference numbers can apparently leak from the