- Sep 19, 2014
-
-
Per Cederqvist authored
-
- Sep 07, 2014
-
-
-
Technically, the else are redundant because of the continue statements on the line above. But writing "} if (...) {" instead of "} else if (...) {" seems like an unforgivable coding standard violation, even if this project does not have any coding standard document.
-
- Sep 05, 2014
-
-
Per Cederqvist authored
MySQL 5.0 adds "release" as a reserved word. Quote it properly. This partially reverts f869ebd1.
-
- Jun 12, 2014
-
-
Per Cederqvist authored
-
- Jun 10, 2014
-
-
Per Cederqvist authored
-
- Feb 15, 2013
-
-
Per Cederqvist authored
It turns out that curl 7.15.5 does not have keepalive support. Make sure we always use --speed-tiemout, --max-time and --connect-timeout to avoid hangs due to network issues and/or server restarts.
-
Per Cederqvist authored
-
Per Cederqvist authored
-
Per Cederqvist authored
-
- Jan 27, 2013
-
-
Per Cederqvist authored
By using git fetch -p git reset --hard $UPSTREAM instead of git pull we ensure that: - we don't create merge commits if a branch has been rebased - we handle the case where a branch has been reset to an earlier commit - any changes to the work tree made while creating the previous source distribution are reverted
-
Per Cederqvist authored
The new git_parse() function can run any command, and returns what it wrote to stdout. It exits if the command fails.
-
Per Cederqvist authored
The new rev_parse() method can parse any ref. Use it in current_commit_id() to simplify the code.
-
Per Cederqvist authored
Rename GitClient::update_to_current_source() to get_current_source(), to stress that this method has nothing to do with FakeTimeClient::update_to_current_source(). Don't return git log output; the only caller ignored the return value.
-
- Jan 15, 2013
-
-
Per Cederqvist authored
-
Per Cederqvist authored
Rename low_process_package() to parse_package(). Call store_result() directly from process_package() instead of doing it in low_process_package(). This removes one redundant check of the dry_run variable. More importantly, it lets us avoid modifying the database if we reject a binary package because we already had a result from that system for that source distribution. The new name makes the responsibility of the function more clear: parse everything we need to know about, but don't modify any state yet (except perhaps creating a new system). Modifying the state is the responsibility of store_result().
-
Per Cederqvist authored
It makes more sense to parse everything first, and store info later.
-
Per Cederqvist authored
-
Per Cederqvist authored
Derived result-parsers that need to extend process_package needs this, so that they can know if the package was processed successfully or not.
-
Per Cederqvist authored
This way, derived result-parsers may safely extend store_files().
-
Per Cederqvist authored
Write an error message if the build or system isn't set when store_files() is called.
-
Per Cederqvist authored
-
Per Cederqvist authored
Let the caller of store_files save the file name in processed_results. This simplifies the overall code slightly.
-
Per Cederqvist authored
Once we have processed a file, and removed it, there really is no point in storing it in processed_results. Since the file no longer exists, it would just needlessly take up space in the mapping.
-
Per Cederqvist authored
If we fail to rm() a result package, put it on processed_results so that it will not be processed again (until the result-parser restarts, at least).
-
Per Cederqvist authored
-
Per Cederqvist authored
-
- Dec 12, 2012
-
-
Per Cederqvist authored
Also, rename the result file from res*.tar.gz to dup*.tar.gz, so it isn't processed again when the result-parser is restarted.
-
Per Cederqvist authored
-
Per Cederqvist authored
If using curl 7.21 or earlier, we increase the timestamp of the downloaded snapshot.tar.gz one second so that the -z option works properly. If GNU stat and GNU touch are installed, they are used, otherwise the new retouch program is compiled and used. If we are using curl 7.22.0 or newer, we don't need to modify the timestamp. This reuses the old dormant machinery that were previously used to build put.
-
Per Cederqvist authored
We now download the new snapshot in a separate directory. Only if the download is complete do we check if we got a new file.
-
Per Cederqvist authored
-
Per Cederqvist authored
-
Per Cederqvist authored
This is preparation for replacing wget with curl.
-
Per Cederqvist authored
This gives us support for using https to upload the compiled sources. That is good, since it makes it a lot harder for a man-in-the-middle attack. It also simplifies the client package a lot. This patch keeps some support code for building put. That code isn't used right now, but a future commit will reuse it to build the new retouch program introduced by that commit.
-
Per Cederqvist authored
-
Per Cederqvist authored
-
Per Cederqvist authored
-
Per Cederqvist authored
Since $fulldir is created in this function, the "cd $fulldir" that follows should never fail. Exit if it should fail anyhow. (The code used to run the NEWCHECK ls command only if the cd succeeded. The rest of the function was always run, though, which was probably not intended.) Call wget_exit immediately if wget fails, instead of chaining it with the following if statement.
-
Per Cederqvist authored
If a bad --client-type argument is given, fail with an error message instead of assuming the user meant "cvs". Thanks to Niels Möller for suggesting this fix.
-