*** empty log message ***

Rev: ChangeLog:1.348
Rev: doc/TODO:1.115
Rev: src/unix_random.c:1.9

ChangeLog

+2001-04-25  Niels Mller  <nisse@ehand.com>
+
+	* src/keyexchange.c (do_handle_newkeys): Added verbose message
+	when receiving NEWKEYS.
+	(do_handle_kexinit): Added verbose message when receiving KEXINIT
+	message. 
+
+	* src/parse.c (parse_next_atom): Tolerate empty atoms, for
+	compatibility with "SSH-1.99-2.0.13 (non-commercial)". XXX Fix in
+	1.2 branch? 
+
 2001-04-17  Niels Mller  <nisse@cuckoo.hack.org>
 
 	* src/testsuite/Makefile.am (TS_MORE_SH): Added tests

doc/TODO

@@ -152,6 +152,10 @@ PROTOCOL ISSUES
 Update the signal-related messages to conform to
 draft-ietf-secsh-connect-08.txt.
 
+Some SSH Inc sshd server sends USERAUTH_FAILURE messages with a
+trailing ",", like "publickey,password,". Consider hacking
+parse.c:parse_next_atom to allow that.
+
 
 USER INTERFACE ISSUES
 
@@ -401,3 +405,26 @@ problems. So we need to avoid setting stderr into non-blocking mode.
 
 Add a keep-alive option, which sends SSH_MSG_IGNORE at regular
 intervals.
+
+The lshd --daemonic option doesn't work with the
+RANDOM_POLL_BACKGROUND.
+
+: loic@gnu.org writes:
+: 
+: >       When I run
+: >
+: >       lshd  --daemonic --ssh1-fallback=/usr/sbin/sshd
+: > 
+: >       It dies on first connection and says :
+: >
+: > Apr 25 04:49:02 subversions lshd[25773]: Background randomness poll failed.
+: > Apr 25 04:49:02 subversions lshd[25773]: lshd: Could not get enough entropy from the environment.
+: 
+: Strange. A guess on what's happening:
+: 
+:   1. lshd starts a background process for collecting randomness,
+: 
+:   2. next it forks and exits to get into the background,
+: 
+:   3. it tries to waitpid the process created in 1, but it's no longer
+:      the parent of that process, so waiting fails.

src/unix_random.c

@@ -690,7 +690,8 @@ wait_background_poll(struct unix_random *self)
   assert(self->status == POLL_RUNNING);
   trace("unix_random.c: wait_background_poll\n");
   self->status = POLL_FAILED;
-  
+
+  /* FIXME: Check error code. */
   if (waitpid(self->pid, &status, 0) == self->pid)
     {
       if (WIFEXITED(status) && !WEXITSTATUS(status))