Commit ed3377db authored by Niels Möller's avatar Niels Möller
Browse files

Reduce ecc_add_eh scratch need.

parent 43d4d194
2014-07-17 Niels Möller <> 2014-07-17 Niels Möller <>
* ecc-add-eh.c (ecc_add_eh): Reduce scratch need.
* ecc-internal.h (ECC_ADD_EH_ITCH): Reduced to 6*size.
* testsuite/curve25519-dup-test.c (test_main): Free allocated * testsuite/curve25519-dup-test.c (test_main): Free allocated
storage. storage.
...@@ -65,47 +65,49 @@ ecc_add_eh (const struct ecc_curve *ecc, ...@@ -65,47 +65,49 @@ ecc_add_eh (const struct ecc_curve *ecc,
Computation Operation Live variables Computation Operation Live variables
B = z1^2 sqr B C = x1*x2 mul C
C = x1*x2 mul B, C D = y1*y2 mul C, D
D = y1*y2 mul B, C, D T = (x1+y1)(x2+y2) - C - D C, D, T
E = b*C*D 2 mul B, C, D, E E = b*C*D 2 mul C, E, T (Replace C <-- D - C)
F = B - E B, C, D, E, F B = z1^2 sqr B, C, E, T
G = B + E C, D, F, G F = B - E B, C, E, F, T
x3 = z1*F*[(x1+y1)(x2+y2) - C - D] 3 mul C, D, G G = B + E C, F, G, T
x3 = z1*F*T 3 mul C, F, G, T
y3 = z1*G*(D-C) 2 mul F, G y3 = z1*G*(D-C) 2 mul F, G
z3 = F*G mul z3 = F*G mul
*/ */
#define B (scratch) #define C (scratch)
#define C (scratch + 1*ecc->size) #define D (scratch + 1*ecc->size)
#define D (scratch + 2*ecc->size) #define T (scratch + 2*ecc->size)
#define E (scratch + 3*ecc->size) #define E (scratch + 3*ecc->size)
#define F (scratch + 4*ecc->size) #define B (scratch + 4*ecc->size)
#define G (scratch + 5*ecc->size) #define F D
#define T (scratch + 6*ecc->size) #define G E
ecc_modp_sqr (ecc, B, z1);
ecc_modp_mul (ecc, C, x1, x2); ecc_modp_mul (ecc, C, x1, x2);
ecc_modp_mul (ecc, D, y1, y2); ecc_modp_mul (ecc, D, y1, y2);
ecc_modp_mul (ecc, T, C, D); ecc_modp_add (ecc, x3, x1, y1);
ecc_modp_mul (ecc, E, T, ecc->b); ecc_modp_add (ecc, y3, x2, y2);
ecc_modp_mul (ecc, T, x3, y3);
ecc_modp_sub (ecc, T, T, C);
ecc_modp_sub (ecc, T, T, D);
ecc_modp_mul (ecc, x3, C, D);
ecc_modp_mul (ecc, E, x3, ecc->b);
ecc_modp_sub (ecc, C, D, C);
ecc_modp_sqr (ecc, B, z1);
ecc_modp_sub (ecc, F, B, E); ecc_modp_sub (ecc, F, B, E);
ecc_modp_add (ecc, G, B, E); ecc_modp_add (ecc, G, B, E);
/* x3 */ /* x3 */
ecc_modp_add (ecc, B, x1, y1); ecc_modp_mul (ecc, B, F, T);
ecc_modp_add (ecc, E, x2, y2); ecc_modp_mul (ecc, x3, B, z1);
ecc_modp_mul (ecc, T, B, E);
ecc_modp_sub (ecc, T, T, C);
ecc_modp_sub (ecc, x3, T, D);
ecc_modp_mul (ecc, T, x3, z1);
ecc_modp_mul (ecc, x3, T, F);
/* y3 */ /* y3 */
ecc_modp_sub (ecc, C, D, C); ecc_modp_mul (ecc, B, G, C);
ecc_modp_mul (ecc, T, z1, C); ecc_modp_mul (ecc, y3, B, z1);
ecc_modp_mul (ecc, y3, T, G);
/* z3 */ /* z3 */
ecc_modp_mul (ecc, T, F, G); ecc_modp_mul (ecc, B, F, G);
mpn_copyi (z3, T, ecc->size); mpn_copyi (z3, B, ecc->size);
} }
...@@ -242,7 +242,7 @@ sec_modinv (mp_limb_t *vp, mp_limb_t *ap, mp_size_t n, ...@@ -242,7 +242,7 @@ sec_modinv (mp_limb_t *vp, mp_limb_t *ap, mp_size_t n,
#define ECC_DUP_EH_ITCH(size) (5*(size)) #define ECC_DUP_EH_ITCH(size) (5*(size))
#define ECC_ADD_JJA_ITCH(size) (6*(size)) #define ECC_ADD_JJA_ITCH(size) (6*(size))
#define ECC_ADD_JJJ_ITCH(size) (8*(size)) #define ECC_ADD_JJJ_ITCH(size) (8*(size))
#define ECC_ADD_EH_ITCH(size) (8*(size)) #define ECC_ADD_EH_ITCH(size) (6*(size))
#define ECC_ADD_EHH_ITCH(size) (9*(size)) #define ECC_ADD_EHH_ITCH(size) (9*(size))
#define ECC_MUL_G_ITCH(size) (9*(size)) #define ECC_MUL_G_ITCH(size) (9*(size))
#if ECC_MUL_A_WBITS == 0 #if ECC_MUL_A_WBITS == 0
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment