Commit 9cdaa3c8 authored by David Kågedal's avatar David Kågedal
Browse files

Gjorde så att det syns vem som adderat kommentarslänkar.

Isolerade och utrotade en otrevlig bug som bara visade sig i sällsynta
fall. Resultatet var att blocking-do(-multiple) anropads rekursivt.
parent 472a3abd
Fri Mar 29 03:26:34 1996 David Kgedal <davidk@lysator.liu.se>
* review.el (lyskom-review-comments,kom-review-comments): Skrev om
icke-asynkron. Kunde i sllsynta fall generera allvarliga fel
genom att anropa lyskom-view-text nr cachen inte var fylld. Nu
anropas bara lyskom-review-comments synkront, s vi r utom fara.
* commands1.el (kom-add-comment,kom-sub-comment): Anvnd
def-kom-command.
* view-text.el (lyskom-print-header-comm): Visa nr
kommentarslnken adderades.
Wed Mar 27 16:19:57 1996 David Byers <davby@sen2.ida.liu.se>
* Version 0.40.1 release
......
......@@ -1760,18 +1760,16 @@ the user has used a prefix command argument."
;;; Author: David Byers
;;; Heavily based on code by Lars Willf|r
(defun kom-add-comment (text-no-arg)
(def-kom-command kom-add-comment (text-no-arg)
"Add a text as a comment to another text."
(interactive "P")
(lyskom-start-of-command 'kom-add-comment)
(lyskom-add-sub-comment text-no-arg
(lyskom-get-string 'text-to-add-comment-to)
t))
(defun kom-sub-comment (text-no-arg)
(def-kom-command kom-sub-comment (text-no-arg)
"Remove a comment from a text."
(interactive "P")
(lyskom-start-of-command 'kom-sub-comment)
(lyskom-add-sub-comment text-no-arg
(lyskom-get-string 'text-to-delete-comment-from)
nil))
......
......@@ -488,15 +488,14 @@ end."
;;; Author: Inge Wallin
(defun kom-review-comments ()
(def-kom-command kom-review-comments ()
"View the comments to this text.
If the current text has comments in (footnotes in) some texts then the first
text is shown and a REVIEW list is built to shown the other ones."
(interactive)
(lyskom-start-of-command 'kom-review-comments)
(lyskom-tell-internat 'kom-tell-review)
(initiate-get-text-stat 'read 'lyskom-review-comments
lyskom-current-text))
(lyskom-review-comments
(blocking-do 'get-text-stat lyskom-current-text)))
(defun lyskom-review-comments (text-stat)
......@@ -528,8 +527,7 @@ text is shown and a REVIEW list is built to shown the other ones."
lyskom-current-text)
lyskom-reading-list t))
(lyskom-view-text (car text-nos)))
(lyskom-insert-string 'no-such-text)))
(lyskom-run 'main 'lyskom-end-of-command))
(lyskom-insert-string 'no-such-text))))
;;; ================================================================
......
......@@ -48,7 +48,9 @@ If FOLLOW-COMMENTS is non-nil all comments and footnotes to this text will be
read before the next text. CONF-STAT must be the conference status of the
current conference, and PRIORITY the priority, if FOLLOW-COMMENTS is non-nil.
If BUILD-REVIEW-TREE is non-nil then it fixes a new entry in the
lyskom-reading-list to read the comments to this."
lyskom-reading-list to read the comments to this.
Note that this function must not be called asynchronously."
(let ((filter (and filter-active
(lyskom-filter-text-p text-no)))
......@@ -484,7 +486,14 @@ Args: TEXT-STAT of the text being read."
((eq type 'FOOTN-IN)
(lyskom-format-insert 'footnote-in-text-by
(misc-info->footn-in misc)
tyname))))
tyname)))
;; Print information about who added the link
(if (misc-info->sent-at misc)
(lyskom-format-insert 'send-at
(lyskom-return-date-and-time
(misc-info->sent-at misc))))
(if (misc-info->sender misc)
(lyskom-insert (lyskom-format 'sent-by (misc-info->sender misc)))))
;; Client tolerans agains buggy servers...
;; We are writing the line about what comments exists and
;; the reference text does not exist anymore. Strange.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment